authorizenet 1.9.4 → 1.9.5

data/lib/authorize_net/line_item.rb

@@ -1,25 +1,21 @@
 module AuthorizeNet
-  
   # Models an line item.
   class LineItem
-    
     include AuthorizeNet::Model
-    
+
     attr_accessor :id, :name, :description, :quantity, :price, :taxable
-    
+
     def to_hash
       hash = {
-        :line_item_id => @id,
-        :line_item_name => @name,
-        :line_item_description => @description,
-        :line_item_quantity => @quantity,
-        :line_item_unit_price => @price,
-        :line_item_taxable => @taxable
+        line_item_id: @id,
+        line_item_name: @name,
+        line_item_description: @description,
+        line_item_quantity: @quantity,
+        line_item_unit_price: @price,
+        line_item_taxable: @taxable
       }
-      hash.delete_if {|k, v| v.nil?}
+      hash.delete_if { |_k, v| v.nil? }
       hash
     end
-    
   end
-  
-end
+end

data/lib/authorize_net/order.rb

@@ -1,42 +1,38 @@
 module AuthorizeNet
-  
   # Models an order.
   class Order
-    
     include AuthorizeNet::Model
-    
+
     attr_accessor :invoice_num, :description, :tax, :tax_name, :tax_description, :freight, :freight_name, :freight_description, :duty, :duty_name, :duty_description, :tax_exempt, :po_num, :line_items
-    
+
     def add_line_item(id = nil, name = nil, description = nil, quantity = nil, price = nil, taxable = nil)
-      if id.kind_of?(AuthorizeNet::LineItem)
+      if id.is_a?(AuthorizeNet::LineItem)
         line_item = id
       else
-        line_item = AuthorizeNet::LineItem.new({:id => id, :name => name, :description => description, :quantity => quantity, :price => price, :taxable => taxable})
+        line_item = AuthorizeNet::LineItem.new(id: id, name: name, description: description, quantity: quantity, price: price, taxable: taxable)
       end
       @line_items = @line_items.to_a << line_item
     end
-    
+
     def to_hash
       hash = {
-        :invoice_num => @invoice_num,
-        :description => @description,
-        :tax => @tax,
-        :tax_name => @tax_name,
-        :tax_description => @tax_description,
-        :freight => @freight,
-        :freight_name => @freight_name,
-        :freight_description => @freight_description,
-        :duty => @duty,
-        :duty_name => @duty_name,
-        :duty_description => @duty_description,
-        :tax_exempt => @tax_exempt,
-        :po_num => @po_num,
-        :line_items => handle_multivalue_hashing(@line_items)
+        invoice_num: @invoice_num,
+        description: @description,
+        tax: @tax,
+        tax_name: @tax_name,
+        tax_description: @tax_description,
+        freight: @freight,
+        freight_name: @freight_name,
+        freight_description: @freight_description,
+        duty: @duty,
+        duty_name: @duty_name,
+        duty_description: @duty_description,
+        tax_exempt: @tax_exempt,
+        po_num: @po_num,
+        line_items: handle_multivalue_hashing(@line_items)
       }
-      hash.delete_if {|k, v| v.nil?}
+      hash.delete_if { |_k, v| v.nil? }
       hash
     end
-    
   end
-  
-end
+end

data/lib/authorize_net/payment_methods/credit_card.rb

@@ -1,8 +1,7 @@
 module AuthorizeNet
-
   # Defines constants for each payment method type.
   module PaymentMethodType
-    CREDIT_CARD = 'CC'
+    CREDIT_CARD = 'CC'.freeze
   end
 
   # Models a credit card.
@@ -11,8 +10,8 @@ module AuthorizeNet
 
     # The option defaults for the constructor.
     @@option_defaults = {
-      :card_code => nil,
-      :card_type => nil
+      card_code: nil,
+      card_type: nil
     }
 
     attr_accessor :card_number, :expiration, :card_code, :card_type, :track_1, :track_2
@@ -47,15 +46,15 @@ module AuthorizeNet
     end
 
     def to_hash
-      Hash.new.tap do |ch|
+      {}.tap do |ch|
         ch[:method] = PAYMENT_METHOD_CODE
         ch[:card_num] = @card_number
         ch[:exp_date] = @expiration
         ch[:card_code] = @card_code if @card_code
         ch[:track1] = @track_1.match(/(%|^)(.*?)(\?|$)/)[2] if @track_1
         ch[:track2] = @track_2.match(/(;|^)(.*?)(\?|$)/)[2] if @track_2
-        #ch[:track1] = @track_1.match(/^%(?<fc>.)(?<p>[\d]{1,19}+)\^(?<n>.{2,26})\^(?<e>[\d]{0,4}|\^)(?<sc>[\d]{0,3}|\^)(?<dd>.*)\?\Z/) if @track_1
-        #ch[:track2] = @track_2.match(/\A;(?<pan>[\d]{1,19}+)=(?<expiration>[\d]{0,4}|=)(?<service_code>[\d]{0,3}|=)(?<discretionary_data>.*)\?\Z/) if @track_2
+        # ch[:track1] = @track_1.match(/^%(?<fc>.)(?<p>[\d]{1,19}+)\^(?<n>.{2,26})\^(?<e>[\d]{0,4}|\^)(?<sc>[\d]{0,3}|\^)(?<dd>.*)\?\Z/) if @track_1
+        # ch[:track2] = @track_2.match(/\A;(?<pan>[\d]{1,19}+)=(?<expiration>[\d]{0,4}|=)(?<service_code>[\d]{0,3}|=)(?<discretionary_data>.*)\?\Z/) if @track_2
       end
     end
   end

data/lib/authorize_net/payment_methods/echeck.rb

@@ -1,42 +1,41 @@
 module AuthorizeNet
-  
   # Defines constants for each payment method type.
   module PaymentMethodType
-    ECHECK = 'ECHECK'
+    ECHECK = 'ECHECK'.freeze
   end
-  
+
   # Models an eCheck.
   class ECheck
     PAYMENT_METHOD_CODE = AuthorizeNet::PaymentMethodType::ECHECK
-    
+
     # Defines constants for each bank account type.
     module AccountType
-      CHECKING = 'CHECKING'
-      SAVINGS = 'SAVINGS'
-      BUSINESS_CHECKING = 'BUSINESSCHECKING'
+      CHECKING = 'CHECKING'.freeze
+      SAVINGS = 'SAVINGS'.freeze
+      BUSINESS_CHECKING = 'BUSINESSCHECKING'.freeze
     end
-    
+
     # Defines constants for each check type.
     module CheckType
-      ACCOUNTS_RECEIVABLE_CONVERSION = 'ARC'
-      BACK_OFFICE_CONVERSION = 'BOC'
-      CASH_CONCENTRATION_DISBURSEMENT = 'CCD'
-      PREARRANGED_PAYMENT_DEPOSIT = 'PPD'
-      TELEPHONE_INITIATED = 'TEL'
-      INTERNET_INITIATED = 'WEB'
+      ACCOUNTS_RECEIVABLE_CONVERSION = 'ARC'.freeze
+      BACK_OFFICE_CONVERSION = 'BOC'.freeze
+      CASH_CONCENTRATION_DISBURSEMENT = 'CCD'.freeze
+      PREARRANGED_PAYMENT_DEPOSIT = 'PPD'.freeze
+      TELEPHONE_INITIATED = 'TEL'.freeze
+      INTERNET_INITIATED = 'WEB'.freeze
     end
-    
+
     # The option defaults for the constructor.
     @@option_defaults = {
-      :echeck_type => CheckType::INTERNET_INITIATED,
-      :check_number => nil,
-      :account_type => AccountType::CHECKING
+      echeck_type: CheckType::INTERNET_INITIATED,
+      check_number: nil,
+      account_type: AccountType::CHECKING
     }
-    
+
     attr_accessor :routing_number, :account_number, :bank_name, :account_holder_name, :echeck_type, :check_number, :account_type
-    
+
     # Constructs a new eCheck object.
-    # 
+    #
     # +routing_number+:: The bank routing number as a string.
     # +account_number+:: The bank account number as a string.
     # +bank_name+:: The legal name of the bank. This should match the name associated with the +routing_number+.
@@ -53,20 +52,19 @@ module AuthorizeNet
       @check_number = options[:check_number]
       @account_type = options[:account_type]
     end
-    
+
     def to_hash
       hash = {
-        :method => PAYMENT_METHOD_CODE,
-        :bank_aba_code => @routing_number,
-        :bank_acct_num => @account_number,
-        :bank_acct_type => @account_type,
-        :bank_name => @bank_name,
-        :bank_acct_name => @account_holder_name,
-        :echeck_type => @echeck_type
+        method: PAYMENT_METHOD_CODE,
+        bank_aba_code: @routing_number,
+        bank_acct_num: @account_number,
+        bank_acct_type: @account_type,
+        bank_name: @bank_name,
+        bank_acct_name: @account_holder_name,
+        echeck_type: @echeck_type
       }
       hash[:bank_check_number] = @check_number unless @check_number.nil?
       hash
     end
   end
-  
-end
+end

data/lib/authorize_net/reporting/batch.rb

@@ -1,19 +1,16 @@
 module AuthorizeNet::Reporting
-
   # Models a batch of credit cards.
   class Batch
-    
     include AuthorizeNet::Model
-    
+
     attr_accessor :id, :settled_at, :state, :statistics, :payment_method
-    
+
     def settled_at=(time)
-      if time.kind_of?(DateTime)
+      if time.is_a?(DateTime)
         @settled_at = time
       else
         @settled_at = DateTime.parse(time.to_s)
       end
     end
   end
-
-end
+end

data/lib/authorize_net/reporting/batch_statistics.rb

@@ -1,10 +1,8 @@
 module AuthorizeNet::Reporting
-
   # Models a batch of credit cards.
   class BatchStatistics
-    
     include AuthorizeNet::Model
-    
+
     attr_accessor :account_type, :charge_count, :charge_amount, :refund_count,
                   :refund_amount, :void_count, :decline_count, :error_count,
                   :returned_item_amount, :returned_item_count, :chargeback_count,
@@ -13,7 +11,5 @@ module AuthorizeNet::Reporting
                   :refund_chargeback_count, :charge_returned_items_amount,
                   :charge_returned_items_count, :refund_returned_items_amount,
                   :refund_returned_items_count
-    
   end
-
-end
+end

data/lib/authorize_net/reporting/fds_filter.rb

@@ -1,11 +1,8 @@
 module AuthorizeNet::Reporting
-
   # Models a fraud detection filter.
   class FDSFilter
-    
     include AuthorizeNet::Model
-    
+
     attr_accessor :name, :action
   end
-
-end
+end

data/lib/authorize_net/reporting/response.rb

@@ -1,10 +1,8 @@
 module AuthorizeNet::Reporting
-
   # The CIM response class.
   class Response < AuthorizeNet::XmlResponse
-    
     include AuthorizeNet::CIM::Fields
-    
+
     # Constructs a new response object from raw_response in the context of transaction.
     # You don‘t typically construct this object yourself, as AuthorizeNet::Reeporting::Transaction
     # will build one for you when it makes the request to the gateway.
@@ -15,13 +13,12 @@ module AuthorizeNet::Reporting
           @batch_list = @root.at_css('batchList')
           @transactions = @root.at_css('transactions')
           @transaction = @root.at_css('transaction')
-        rescue
-          @raw_response = $!
+        rescue StandardError
+          @raw_response = $ERROR_INFO
         end
       end
     end
-    
-    
+
     # Returns an Array of Batch objects built from the entities returned in the response. Returns nil if no batchList was returned.
     def batch_list
       unless @batch_list.nil?
@@ -29,104 +26,102 @@ module AuthorizeNet::Reporting
         @batch_list.element_children.each do |child|
           batches <<= build_entity(child, Fields::BATCH_ENTITY_DESCRIPTION) unless child.nil?
         end
-        return batches unless batches.length == 0
+        return batches unless batches.empty?
       end
     end
-    
+
     # Returns an Array of TransactionDetail objects built from the entities returned in the response. Returns nil if no transactions were returned.
     def transactions
       unless @transactions.nil?
         transactions = []
         @transactions.element_children.each do |child|
-          unless child.nil?
-            transaction = build_entity(child, Fields::TRANSACTION_DETAILS_ENTITY_DESCRIPTION)
-            
-            # handle some stuff thats too tricky for EntityDecription to handle
-             first_name = node_content_unless_nil(child.at_css('firstName'))
-            last_name = node_content_unless_nil(child.at_css('lastName'))
-            unless first_name.nil? && last_name.nil?
-              address = AuthorizeNet::Address.new(:first_name => first_name, :last_name => last_name)
-              transaction.customer = AuthorizeNet::Customer.new(:address => address)
-            end
-            invoice_number = node_content_unless_nil(child.at_css('invoiceNumber'))
-            unless invoice_number.nil?
-              transaction.order = AuthorizeNet::Order.new(:invoice_num => invoice_number)
-            end
-            subscription = child.at_css('subscription')
-            unless subscription.nil?
-                subscription_id = node_content_unless_nil(child.at_css('subscription').at_css('id'))
-                transaction.subscription_id = subscription_id unless subscription_id.nil?
-
-                pay_num = node_content_unless_nil(child.at_css('subscription').at_css('payNum'))
-                transaction.subscription_paynum = pay_num unless pay_num.nil?
-            end
-
-
-            transactions <<= transaction
+          next if child.nil?
+          transaction = build_entity(child, Fields::TRANSACTION_DETAILS_ENTITY_DESCRIPTION)
+
+          # handle some stuff thats too tricky for EntityDecription to handle
+          first_name = node_content_unless_nil(child.at_css('firstName'))
+          last_name = node_content_unless_nil(child.at_css('lastName'))
+          unless first_name.nil? && last_name.nil?
+            address = AuthorizeNet::Address.new(first_name: first_name, last_name: last_name)
+            transaction.customer = AuthorizeNet::Customer.new(address: address)
           end
+          invoice_number = node_content_unless_nil(child.at_css('invoiceNumber'))
+          unless invoice_number.nil?
+            transaction.order = AuthorizeNet::Order.new(invoice_num: invoice_number)
+          end
+          subscription = child.at_css('subscription')
+          unless subscription.nil?
+            subscription_id = node_content_unless_nil(child.at_css('subscription').at_css('id'))
+            transaction.subscription_id = subscription_id unless subscription_id.nil?
+
+            pay_num = node_content_unless_nil(child.at_css('subscription').at_css('payNum'))
+            transaction.subscription_paynum = pay_num unless pay_num.nil?
+          end
+
+          transactions <<= transaction
         end
-        return transactions unless transactions.length == 0
+        return transactions unless transactions.empty?
       end
     end
-    
+
     # Builds and returns a TransactionDetail entity built from the response. If no transaction was found, returns nil.
     def transaction
       unless @transaction.nil?
         transaction = build_entity(@transaction, Fields::TRANSACTION_DETAILS_ENTITY_DESCRIPTION)
-        
+
         ip = node_content_unless_nil(@transaction.at_css('customerIP'))
         unless ip.nil?
-          transaction.customer ||= AuthorizeNet::CIM::CustomerProfile.new()
+          transaction.customer ||= AuthorizeNet::CIM::CustomerProfile.new
           transaction.customer.ip = ip
         end
-        
+
         tax_exempt = node_content_unless_nil(@transaction.at_css('taxExempt'))
         unless tax_exempt.nil?
-          transaction.order ||= AuthorizeNet::Order.new()
+          transaction.order ||= AuthorizeNet::Order.new
           transaction.order.tax_exempt = value_to_boolean(tax_exempt)
         end
-        
+
         tax = @transaction.at_css('tax')
         unless tax.nil?
-          transaction.order ||= AuthorizeNet::Order.new()
+          transaction.order ||= AuthorizeNet::Order.new
           tax_amount = node_content_unless_nil(tax.at_css('amount'))
-          transaction.order.tax_amount = value_to_decimal(tax_amount) unless tax_amount.nil?
+          transaction.order.tax = value_to_decimal(tax_amount) unless tax_amount.nil?
           transaction.order.tax_name = node_content_unless_nil(tax.at_css('name'))
           transaction.order.tax_description = node_content_unless_nil(tax.at_css('description'))
         end
-        
+
         shipping = @transaction.at_css('shipping')
         unless shipping.nil?
-          transaction.order ||= AuthorizeNet::Order.new()
+          transaction.order ||= AuthorizeNet::Order.new
           shipping_amount = node_content_unless_nil(shipping.at_css('amount'))
-          transaction.order.shipping_amount = value_to_decimal(shipping_amount) unless shipping_amount.nil?
-          transaction.order.shipping_name = node_content_unless_nil(shipping.at_css('name'))
-          transaction.order.shipping_description = node_content_unless_nil(shipping.at_css('description'))
+          transaction.order.freight = value_to_decimal(shipping_amount) unless shipping_amount.nil?
+          transaction.order.freight_name = node_content_unless_nil(shipping.at_css('name'))
+          transaction.order.freight_description = node_content_unless_nil(shipping.at_css('description'))
         end
-        
+
         duty = @transaction.at_css('duty')
         unless duty.nil?
-          transaction.order ||= AuthorizeNet::Order.new()
+          transaction.order ||= AuthorizeNet::Order.new
           duty_amount = node_content_unless_nil(duty.at_css('amount'))
-          transaction.order.duty_amount = value_to_decimal(duty_amount) unless duty_amount.nil?
+          transaction.order.duty = value_to_decimal(duty_amount) unless duty_amount.nil?
           transaction.order.duty_name = node_content_unless_nil(duty.at_css('name'))
           transaction.order.duty_description = node_content_unless_nil(duty.at_css('description'))
         end
-        
+
         line_items = @transaction.at_css('lineItems')
         unless line_items.nil?
-          transaction.order ||= AuthorizeNet::Order.new()
+          transaction.order ||= AuthorizeNet::Order.new
           line_items.element_children.each do |child|
             line_item = build_entity(child, Fields::LINE_ITEM_ENTITY_DESCRIPTION)
             transaction.order.add_line_item(line_item)
           end
         end
-        
+
         # Really not sure what to do with customer type here. It should go on a payment
         customer_type = node_content_unless_nil(@transaction.at_css('customer type'))
         unless customer_type.nil?
-          transaction.customer ||= AuthorizeNet::CIM::CustomerProfile.new()
-          transaction.customer.payment_profiles = [AuthorizeNet::CIM::PaymentProfile.new(:cust_type => customer_type)]
+          transaction.customer ||= AuthorizeNet::CIM::CustomerProfile.new
+          transaction.customer.payment_profiles = [AuthorizeNet::CIM::PaymentProfile.new(cust_type: customer_type)]
         end
 
         subscription = @transaction.at_css('subscription')
@@ -141,7 +136,7 @@ module AuthorizeNet::Reporting
         solution = @transaction.at_css('solution')
         unless solution.nil?
           solution_id = node_content_unless_nil(@transaction.at_css('solution').at_css('id'))
-          transaction.solution_id = value_to_decimal(solution_id) unless solution_id.nil?
+          transaction.solution_id = solution_id unless solution_id.nil?
 
           transaction.solution_name = node_content_unless_nil(@transaction.at_css('solution').at_css('name'))
         end
@@ -155,9 +150,8 @@ module AuthorizeNet::Reporting
           end
         end
 
-        return transaction
+        transaction
       end
     end
-    
   end
-end
+end