authorizenet 1.9.4 → 1.9.5

data/lib/authorize_net/api/transaction.rb

@@ -1,263 +1,261 @@
 module AuthorizeNet::API
-  class Transaction < ApiTransaction    
+  class Transaction < ApiTransaction
     attr_accessor :access_token
-	attr_accessor :options_OAuth
-	
+    attr_accessor :options_OAuth
+
     def initialize(api_login_id = nil, api_transaction_key = nil, options = {})
-       super
+      super
     end
-       
+
     # This request enables you to create a transaction, and optional
     # customer profile.
     # NOTE: Network tokenized transactions (e.g. Apple Pay), or PayPal should
     # not be used to create payment profiles.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def create_transaction(request)  
-      make_request(request,CreateTransactionResponse,Type::API_CREATE_TRANSACTION)
+    def create_transaction(request)
+      make_request(request, CreateTransactionResponse, Type::API_CREATE_TRANSACTION)
     end
-    
+
     # This request enables you to create a recurring billing subscription.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def create_subscription(request)
-      make_request(request,ARBCreateSubscriptionResponse,Type::API_CREATE_SUBSCRIPTION)
+      make_request(request, ARBCreateSubscriptionResponse, Type::API_CREATE_SUBSCRIPTION)
     end
 
     # This request enables you to update a recurring billing subscription.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def update_subscription(request)
-      make_request(request,ARBUpdateSubscriptionResponse,Type::API_UPDATE_SUBSCRIPTION)
+      make_request(request, ARBUpdateSubscriptionResponse, Type::API_UPDATE_SUBSCRIPTION)
     end
 
     # This request enables you to cancel a recurring billing subscription.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def cancel_subscription(request)
-      make_request(request,ARBCancelSubscriptionResponse,Type::API_CANCEL_SUBSCRIPTION)
+      make_request(request, ARBCancelSubscriptionResponse, Type::API_CANCEL_SUBSCRIPTION)
     end
 
     # This request enables you to get a recurring billing subscription status.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def get_subscription_status(request)
-      make_request(request,ARBGetSubscriptionStatusResponse,Type::API_GET_SUBSCRIPTION_STATUS)
+      make_request(request, ARBGetSubscriptionStatusResponse, Type::API_GET_SUBSCRIPTION_STATUS)
     end
 
     # This request enables you to get a list of all recurring billing
     # subscriptions.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def get_subscription_list(request)
-      make_request(request,ARBGetSubscriptionListResponse,Type::API_GET_SUBSCRIPTION_LIST)
+      make_request(request, ARBGetSubscriptionListResponse, Type::API_GET_SUBSCRIPTION_LIST)
     end
 
     # This request enables you to create a customer profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def create_customer_profile(request)
-      make_request(request,CreateCustomerProfileResponse,Type::API_CREATE_CUSTOMER_PROFILE)
+      make_request(request, CreateCustomerProfileResponse, Type::API_CREATE_CUSTOMER_PROFILE)
     end
-    
+
     # This request enables you to retrieve a customer profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def get_customer_profile(request)
-      make_request(request,GetCustomerProfileResponse,Type::API_GET_CUSTOMER_PROFILE)
+      make_request(request, GetCustomerProfileResponse, Type::API_GET_CUSTOMER_PROFILE)
     end
 
-
     # This request enables you to retrieve all customer profile IDs.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def get_customer_profile_ids(request)
-      make_request(request,GetCustomerProfileIdsResponse,Type::API_GET_CUSTOMER_PROFILE_IDS)
+      make_request(request, GetCustomerProfileIdsResponse, Type::API_GET_CUSTOMER_PROFILE_IDS)
     end
 
     # This request enables you to update a customer profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def update_customer_profile(request)
-      make_request(request,UpdateCustomerProfileResponse,Type::API_UPDATE_CUSTOMER_PROFILE)
+      make_request(request, UpdateCustomerProfileResponse, Type::API_UPDATE_CUSTOMER_PROFILE)
     end
 
     # This request enables you to delete a customer profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def delete_customer_profile(request)
-      make_request(request,DeleteCustomerProfileResponse,Type::API_DELETE_CUSTOMER_PROFILE)
+      make_request(request, DeleteCustomerProfileResponse, Type::API_DELETE_CUSTOMER_PROFILE)
     end
-   
+
     # This request enables you to create a customer payment profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def create_customer_payment_profile(request)
-      make_request(request,CreateCustomerPaymentProfileResponse,Type::API_CREATE_CUSTOMER_PAYMENT_PROFILE)
+      make_request(request, CreateCustomerPaymentProfileResponse, Type::API_CREATE_CUSTOMER_PAYMENT_PROFILE)
     end
-    
+
     # This request enables you to retrieve a customer payment profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def get_customer_payment_profile(request)
-      make_request(request,GetCustomerPaymentProfileResponse,Type::API_GET_CUSTOMER_PAYMENT_PROFILE)
+      make_request(request, GetCustomerPaymentProfileResponse, Type::API_GET_CUSTOMER_PAYMENT_PROFILE)
     end
 
     # This request enables you to update a customer payment profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def update_customer_payment_profile(request)
-      make_request(request,UpdateCustomerPaymentProfileResponse,Type::API_UPDATE_CUSTOMER_PAYMENT_PROFILE)
+      make_request(request, UpdateCustomerPaymentProfileResponse, Type::API_UPDATE_CUSTOMER_PAYMENT_PROFILE)
     end
 
     # This request enables you to delete a customer payment profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def delete_customer_payment_profile(request)
-      make_request(request,DeleteCustomerPaymentProfileResponse,Type::API_DELETE_CUSTOMER_PAYMENT_PROFILE)
+      make_request(request, DeleteCustomerPaymentProfileResponse, Type::API_DELETE_CUSTOMER_PAYMENT_PROFILE)
     end
 
     # This request enables you to create a customer shipping profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def create_customer_shipping_profile(request)
-      make_request(request,CreateCustomerShippingAddressResponse,Type::API_CREATE_CUSTOMER_SHIPPING_PROFILE)
+      make_request(request, CreateCustomerShippingAddressResponse, Type::API_CREATE_CUSTOMER_SHIPPING_PROFILE)
     end
-    
+
     # This request enables you to retrieve a customer shipping profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def get_customer_shipping_profile(request)
-      make_request(request,GetCustomerShippingAddressResponse,Type::API_GET_CUSTOMER_SHIPPING_PROFILE)
+      make_request(request, GetCustomerShippingAddressResponse, Type::API_GET_CUSTOMER_SHIPPING_PROFILE)
     end
 
     # This request enables you to update a customer shipping profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def update_customer_shipping_profile(request)
-      make_request(request,UpdateCustomerShippingAddressResponse,Type::API_UPDATE_CUSTOMER_SHIPPING_PROFILE)
+      make_request(request, UpdateCustomerShippingAddressResponse, Type::API_UPDATE_CUSTOMER_SHIPPING_PROFILE)
     end
 
     # This request enables you to delete a customer shipping profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def delete_customer_shipping_profile(request)
-      make_request(request,DeleteCustomerShippingAddressResponse,Type::API_DELETE_CUSTOMER_SHIPPING_PROFILE)
+      make_request(request, DeleteCustomerShippingAddressResponse, Type::API_DELETE_CUSTOMER_SHIPPING_PROFILE)
     end
-   
 
     # This request enables you to create a customer profile, payment
     # profile, and shipping profile from an existing successful transaction.
     # NOTE: Network tokenized transactions (e.g. Apple Pay), or PayPal
     # should not be used to create payment profiles.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def create_customer_profile_from_transaction(request)
-      make_request(request,CreateProfileResponse,Type::API_CREATE_CUSTOMER_PROFILE_FROM_TRANSACTION)
+      make_request(request, CreateProfileResponse, Type::API_CREATE_CUSTOMER_PROFILE_FROM_TRANSACTION)
     end
 
     # This request enables you to decrypt a payment data blob.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
     def decrypt_payment_data(request)
-      make_request(request,DecryptPaymentDataResponse,Type::API_DECRYPT_PAYMENT_DATA)
+      make_request(request, DecryptPaymentDataResponse, Type::API_DECRYPT_PAYMENT_DATA)
     end
 
     # This request enables confirm authentication values.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def authenticate_test_request(request)            
-      make_request(request,AuthenticateTestResponse,Type::API_AUTHENTICATE_TEST_REQUEST)
+    def authenticate_test_request(request)
+      make_request(request, AuthenticateTestResponse, Type::API_AUTHENTICATE_TEST_REQUEST)
     end
-    
+
     # This request enables you to get batch statistics details.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def get_batch_statistics(request)            
-      make_request(request,GetBatchStatisticsResponse,Type::API_GET_BATCH_STATISTICS)
+    def get_batch_statistics(request)
+      make_request(request, GetBatchStatisticsResponse, Type::API_GET_BATCH_STATISTICS)
     end
 
     # This request enables you to get batch transaction details.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def get_transaction_details(request)            
-      make_request(request,GetTransactionDetailsResponse,Type::API_GET_TRANSACTION_DETAILS)
+    def get_transaction_details(request)
+      make_request(request, GetTransactionDetailsResponse, Type::API_GET_TRANSACTION_DETAILS)
     end
 
     # This request enables you to get batch settled transaction details.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def get_settled_batch_list(request)            
-      make_request(request,GetSettledBatchListResponse,Type::API_GET_SETTLED_BATCH_LIST)
+    def get_settled_batch_list(request)
+      make_request(request, GetSettledBatchListResponse, Type::API_GET_SETTLED_BATCH_LIST)
     end
 
     # This request enables you to get batch unsettled transaction details.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def get_unsettled_transaction_list(request)            
-      make_request(request,GetUnsettledTransactionListResponse,Type::API_GET_UNSETTLED_TRANSACTION_LIST)
+    def get_unsettled_transaction_list(request)
+      make_request(request, GetUnsettledTransactionListResponse, Type::API_GET_UNSETTLED_TRANSACTION_LIST)
     end
-  
-  # This request enables confirm authentication values.
-    # 
+
+    # This request enables confirm authentication values.
+    #
     # See spec/api_spec.rb for usage examples
-    def get_hosted_profile_page(request)            
-      make_request(request,GetHostedProfilePageResponse,Type::API_GET_HOSTED_PROFILE_PAGE)
+    def get_hosted_profile_page(request)
+      make_request(request, GetHostedProfilePageResponse, Type::API_GET_HOSTED_PROFILE_PAGE)
     end
-    
+
     # This request enables you to update split tender group.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def update_split_tender_group(request)  
-      make_request(request,UpdateSplitTenderGroupResponse,Type::API_UPDATE_SPLIT_TENDER_GROUP)
+    def update_split_tender_group(request)
+      make_request(request, UpdateSplitTenderGroupResponse, Type::API_UPDATE_SPLIT_TENDER_GROUP)
     end
-    
+
     # This request enables you to get customer payment profile list.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def get_customer_payment_profile_list(request)  
-      make_request(request,GetCustomerPaymentProfileListResponse,Type::API_GET_CUSTOMER_PAYMENT_PROFILE_LIST)
+    def get_customer_payment_profile_list(request)
+      make_request(request, GetCustomerPaymentProfileListResponse, Type::API_GET_CUSTOMER_PAYMENT_PROFILE_LIST)
     end
-    
+
     # This request enables you to get ARB Subscription.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def arb_get_subscription_request(request)  
-      make_request(request,ARBGetSubscriptionResponse,Type::API_ARB_GET_SUBSCRIPTION_REQUEST)
+    def arb_get_subscription_request(request)
+      make_request(request, ARBGetSubscriptionResponse, Type::API_ARB_GET_SUBSCRIPTION_REQUEST)
     end
 
     # This request enables you to get transaction list.
     #
     # See spec/api_spec.rb for usage examples
     def get_transaction_list(request)
-      make_request(request,GetTransactionListResponse,Type::API_GET_TRANSACTION_LIST)
+      make_request(request, GetTransactionListResponse, Type::API_GET_TRANSACTION_LIST)
     end
-    
+
     # This request enables you to validate customer payment profile.
-    # 
+    #
     # See spec/api_spec.rb for usage examples
-    def validate_customer_payment_profile(request)  
-      make_request(request,ValidateCustomerPaymentProfileResponse,Type::API_VALIDATE_CUSTOMER_PAYMENT_PROFILE)
+    def validate_customer_payment_profile(request)
+      make_request(request, ValidateCustomerPaymentProfileResponse, Type::API_VALIDATE_CUSTOMER_PAYMENT_PROFILE)
     end
 
-    def get_merchant_details(request)  
-      make_request(request,GetMerchantDetailsResponse,Type::API_GET_MERCHANT_DETAILS)
+    def get_merchant_details(request)
+      make_request(request, GetMerchantDetailsResponse, Type::API_GET_MERCHANT_DETAILS)
     end
 
-    def get_hosted_payment_page(request)  
-      make_request(request,GetHostedPaymentPageResponse,Type::API_GET_HOSTED_PAYMENT_PAGE)
+    def get_hosted_payment_page(request)
+      make_request(request, GetHostedPaymentPageResponse, Type::API_GET_HOSTED_PAYMENT_PAGE)
     end
 
-    def update_held_transaction(request)  
-      make_request(request,UpdateHeldTransactionResponse,Type::API_UDPATE_HELD_TRANSACTION)
+    def update_held_transaction(request)
+      make_request(request, UpdateHeldTransactionResponse, Type::API_UDPATE_HELD_TRANSACTION)
     end
 
     def get_transaction_list_for_customer(request)
-      make_request(request,GetTransactionListResponse,Type::API_GET_TRANSACTION_LIST_FOR_CUSTOMER)
+      make_request(request, GetTransactionListResponse, Type::API_GET_TRANSACTION_LIST_FOR_CUSTOMER)
     end
-  
+
     def update_merchant_details(request)
-      make_request(request,UpdateMerchantDetailsResponse,Type::API_UPDATE_MERCHANT_DETAILS)
+      make_request(request, UpdateMerchantDetailsResponse, Type::API_UPDATE_MERCHANT_DETAILS)
     end
   end
 end

data/lib/authorize_net/arb/fields.rb

@@ -1,24 +1,24 @@
 module AuthorizeNet::ARB
-    module Fields
-      EntityDescription = Struct.new(:node_structure, :entity_class, :arg_mapping)
+  module Fields
+    EntityDescription = Struct.new(:node_structure, :entity_class, :arg_mapping)
 
-      SUBSCRIPTION_DETAIL_ENTITY_DESCRIPTION = EntityDescription.new(
-        [
-          {:id => :id},
-          {:name => :name},
-          {:status => :status},
-	  {:createTimeStampUTC => :create_time_stamp_utc},
-	  {:firstName => :first_name},
-	  {:lastName => :last_name},
-	  {:totalOccurrences => :total_occurrences},
-	  {:pastOccurrences => :past_occurrences},
-	  {:paymentMethod => :payment_method},
-	  {:accountNumber => :account_number},
-	  {:invoice => :invoice},
-	  {:amount => :amount},
-          {:currencyId => :currency_id}
-        ],
-        AuthorizeNet::ARB::SubscriptionDetail
-      )
-    end
+    SUBSCRIPTION_DETAIL_ENTITY_DESCRIPTION = EntityDescription.new(
+      [
+        { id: :id },
+        { name: :name },
+        { status: :status },
+        { createTimeStampUTC: :create_time_stamp_utc },
+        { firstName: :first_name },
+        { lastName: :last_name },
+        { totalOccurrences: :total_occurrences },
+        { pastOccurrences: :past_occurrences },
+        { paymentMethod: :payment_method },
+        { accountNumber: :account_number },
+        { invoice: :invoice },
+        { amount: :amount },
+        { currencyId: :currency_id }
+      ],
+      AuthorizeNet::ARB::SubscriptionDetail
+    )
+  end
 end

data/lib/authorize_net/arb/paging.rb

@@ -1,13 +1,11 @@
 module AuthorizeNet::ARB
-
   class Paging
-
     # Models Paging
     include AuthorizeNet::Model
-    
-    attr_accessor :offset,:limit
 
-    # Initializes Paging object. 
+    attr_accessor :offset, :limit
+
+    # Initializes Paging object.
     #
     # Typical usage:
     #  paging = AuthorizeNet::ARB::Paging.new(1,1000)
@@ -15,19 +13,17 @@ module AuthorizeNet::ARB
     # Valid values for offset: 1 to 100000
     # Valid values for limit: 1 to 1000
     #
-    def initialize(offset,limit)
+    def initialize(offset, limit)
       @offset = offset
       @limit = limit
     end
 
     def to_hash
       hash = {
-        :offset => @offset,
-        :limit => @limit
+        offset: @offset,
+        limit: @limit
       }
-      hash.delete_if {|k, v| v.nil?}
+      hash.delete_if { |_k, v| v.nil? }
     end
-      
   end
-
 end

data/lib/authorize_net/arb/response.rb

@@ -1,8 +1,6 @@
 module AuthorizeNet::ARB
-
   # The ARB response class.
   class Response < AuthorizeNet::XmlResponse
-    
     # Constructs a new response object from a +raw_response. You don't typically
     # construct this object yourself, as AuthorizeNet::ARB::Transaction will
     # build one for you when it makes the request to the gateway.
@@ -12,23 +10,17 @@ module AuthorizeNet::ARB
         begin
           @subscription_id = node_content_unless_nil(@root.at_css('subscriptionId'))
           @subscription_status = node_content_unless_nil(@root.at_css('Status'))
-        rescue
-          @raw_response = $!
+        rescue StandardError
+          @raw_response = $ERROR_INFO
         end
       end
     end
-    
+
     # Returns the subscriptionId from the response if there is one. Otherwise returns nil.
-    def subscription_id
-      @subscription_id
-    end
-    
+    attr_reader :subscription_id
+
     # Returns the status of the Subscription from the response if there is one. Otherwise returns nil. This value
     # is only returned in response to a get_status transaction.
-    def subscription_status
-      @subscription_status
-    end
-    
+    attr_reader :subscription_status
   end
-  
-end
+end