aruba 0.14.9 → 0.14.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db02b356180d59cbb7130462250f2cafebd1c6c8291ddaba3ad35aea0627f42c
-  data.tar.gz: d87419e2e9919ef52a11f3df15c26d69f1dd420ba82836891cb658132febd318
+  metadata.gz: aac7113c05858afc5a48b644bdb6e29427357319e13d6b7c5fb0c2a4d5afef4b
+  data.tar.gz: 463b5d14a0f1c0a2cbab30a5f51ab188916e077e8e00364d635353cdcb9346af
 SHA512:
-  metadata.gz: 7fdd47811f42d432484946e87196aa413bc245b7b0dbe02598c7739a17b148813f69b3b4257f914ed8043c42f688265115b9e702976ac96e94a2a3fd41a1cbea
-  data.tar.gz: 7ee7be3262b56ebb59c68e0ee67f1804b03e2bd56f09f0e20b1070db2fae199090ffc27a1bd35a4d97c20abdf927df465f37708492a0f4da9584f38b8b66131e
+  metadata.gz: e525789f39d2f6cb13f178a174eae0c55a02ea8b8487353da9f075cc7dcab54498638ea101a7727bb9c87265d1232f711d9294988c81eb0de71408fa26113dde
+  data.tar.gz: 9604df096eb13935a3fe24114c9c381dc8cd0f3f749b01bcdde73e315dd1d8d23ba0dd819c0277517974b0a588788b787f9b648131a1a257a5cc954aea7ef966

data/.rubocop.yml

@@ -1,7 +1,9 @@
 AllCops:
   Exclude:
     - tmp/**/*
+    - vendor/bundle/**/*
   DisplayCopNames: true
+
 # Cop supports --auto-correct.
 # Configuration parameters: SupportedStyles.
 Style/HashSyntax:

data/.travis.yml

@@ -1,54 +1,34 @@
 sudo: false
 language: ruby
 script: script/test
-install: script/bootstrap --without development debug
+bundler_args: --without development debug
+cache: bundler
+
 rvm:
   - 1.8.7
   - 1.9.2
   - 1.9.3
   - 2.0.0
   - 2.1.8
-  - 2.2.4
-  - 2.3.8
-  - 2.4.5
-  - 2.5.3
-  - 2.6.0
-  - jruby-1.7.26
-  - jruby-20mode
-  - jruby-21mode
-  - rbx
+  - 2.2
+  - 2.3
+  - 2.4
+  - 2.5
+  - 2.6
+  - jruby-1.7
+  - jruby-9.0
+  - jruby-9.1
+  - jruby-9.2.6.0
+  - rbx-3
 matrix:
   include:
-    - rvm: jruby-9.0.1.0
-      env: JRUBY_OPTS='--dev'
-    - rvm: jruby-9.0.1.0-20mode
-      env: JRUBY_OPTS='--dev'
-    - rvm: jruby-9.0.1.0-21mode
-      env: JRUBY_OPTS='--dev'
+    - rvm: jruby-1.7
+      env: JRUBY_OPTS='--dev --1.8'
   allow_failures:
-  - rvm: rbx
-  - rvm: jruby-9.0.1.0
-    env: JRUBY_OPTS='--dev'
-  - rvm: jruby-9.0.1.0-20mode
-    env: JRUBY_OPTS='--dev'
-  - rvm: jruby-9.0.1.0-21mode
-    env: JRUBY_OPTS='--dev'
+  - rvm: rbx-3
 branches:
   only:
     - master
     - still
-notifications:
-  email:
-    - cukes-devs@googlegroups.com
-  webhooks:
-    urls:
-      - https://webhooks.gitter.im/e/d4d9080e2a8c4910f609
 env:
-  global:
-   - secure: l8uznA5K4K9mZ1krmP3lTMD8WcJ32qGxFOR3jubKHcOBSLB4xSzU2aIqjyJdO+rLzebkwamhJc8pGSIWOUDQYvFiX7splK+uEkbBJ5huAhXtLF4Qgl86bCWbEXYzN7rvn0DQfpJAovyFMNRMnfo70XhwqWzFsaYa7Z0YbqYsJE4=
-   - JRUBY_OPTS='--dev'
-cache: apt
-addons:
-  apt:
-    packages:
-    - zsh
+  - JRUBY_OPTS='--dev'

data/CHANGELOG.md

@@ -6,6 +6,24 @@ This project will adhere to [Semantic Versioning][1] once version 1.0.0 is relea
 
 This document is formatted according to the principles of [Keep A CHANGELOG][2].
 
+## [v0.14.10]
+
+* Backport replacement of problematic AnsiColor module with simple
+  implementation ([#642])
+* Undo preprecation of `#all_output`, `#all_stdout`, `#all_stderr` and
+  `#in_current_directory` API methods, as well as of checking the combined
+  output from all commands in cucumber steps ([#638])
+* Warn when deprecated files `aruba/in_process` and `aruba/spawn_process` are
+  required ([#639])
+* Backport allowing decimal timeout values ([#621])
+* Move deprecated cucumber steps into a separate file ([#622])
+* Backport renaming of bin/cli in features ([#620])
+* Improve build set for CI ([#611])
+* Make JRuby before :command helper hook work on the environment the command
+  will actually be run in ([#610], [#612])
+* Reorganize spec files to match master branch ([#603])
+* Reorganize feature files to match master branch ([#602])
+
 ## [v0.14.9]
 
 * Formally deprecate `#use_clean_gemset` ([#597])
@@ -649,7 +667,18 @@ This document is formatted according to the principles of [Keep A CHANGELOG][2].
 
 <!-- issues & pull requests -->
 
+[#642]: https://github.com/cucumber/aruba/pull/642
+[#639]: https://github.com/cucumber/aruba/pull/639
+[#638]: https://github.com/cucumber/aruba/pull/638
+[#622]: https://github.com/cucumber/aruba/pull/622
+[#621]: https://github.com/cucumber/aruba/pull/621
+[#620]: https://github.com/cucumber/aruba/pull/620
+[#612]: https://github.com/cucumber/aruba/pull/612
+[#611]: https://github.com/cucumber/aruba/pull/611
+[#610]: https://github.com/cucumber/aruba/pull/610
 [#604]: https://github.com/cucumber/aruba/pull/604
+[#603]: https://github.com/cucumber/aruba/pull/603
+[#602]: https://github.com/cucumber/aruba/pull/602
 [#601]: https://github.com/cucumber/aruba/pull/601
 [#597]: https://github.com/cucumber/aruba/pull/597
 [#591]: https://github.com/cucumber/aruba/pull/591
@@ -831,6 +860,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG][2].
 
 <!-- Releases -->
 
+[v0.14.10]:       https://github.com/cucumber/aruba/compare/v0.14.9...v0.14.10
 [v0.14.9]:        https://github.com/cucumber/aruba/compare/v0.14.8...v0.14.9
 [v0.14.8]:        https://github.com/cucumber/aruba/compare/v0.14.7...v0.14.8
 [v0.14.7]:        https://github.com/cucumber/aruba/compare/v0.14.6...v0.14.7

data/Gemfile

@@ -70,7 +70,7 @@ group :development, :test do
   end
 
   # Code Coverage
-  gem 'simplecov', '~> 0.10'
+  gem 'simplecov', '~> 0.10' unless RUBY_PLATFORM.include?('java')
 
   # Test api
   gem 'rspec', '~> 3.4'
@@ -84,6 +84,12 @@ group :development, :test do
     gem 'cucumber', '~> 2.0'
   end
 
+  if RUBY_VERSION < '1.9.2'
+    gem 'childprocess', '~> 0.6.3'
+  else
+    gem 'childprocess', '~> 1.0.1'
+  end
+
   if RUBY_VERSION < '1.9.2'
     gem 'contracts', '~> 0.15.0'
   else
@@ -99,5 +105,9 @@ group :development, :test do
     gem 'cucumber-pro', '~> 0.0'
   end
 
+  if RUBY_VERSION < '2.0.0'
+    gem 'ffi', '< 1.11.0'
+  end
+
   gem 'minitest', '~> 5.8'
 end

data/features/{getting_started/cleanup.feature → 01_getting_started_with_aruba/cleanup_working_directory.feature}

@@ -1,10 +1,9 @@
 Feature: Cleanup Aruba Working Directory
 
-  By default Aruba removes its scratch directory before
-  every scenario. This isn't always the right thing
-  to do, especially when the path to the default directory
-  has been changed. Use @no-clobber to stop Aruba from
-  cleaning up after itself.
+  By default Aruba removes its scratch directory *before* every scenario. This
+  isn't always the right thing to do, especially when the path to the default
+  directory has been changed. Use the `@no-clobber`-tag on your scenarios to
+  stop Aruba from cleaning up *before* it runs.
 
   Background:
     Given I use a fixture named "cli-app"

data/features/{getting_started → 01_getting_started_with_aruba}/run_commands.feature

@@ -12,25 +12,25 @@ Feature: Run commands with Aruba
 
   Background:
     Given I use a fixture named "getting-started-app"
+
+  @requires-bash
+  Scenario: Bash Program
+    Given an executable named "bin/aruba-test-cli" with:
+    """bash
+    #!/usr/bin/env bash
+
+    echo "Hello, Aruba!"
+    """
     And a file named "features/hello_aruba.feature" with:
     """
     Feature: Getting Started With Aruba
       Scenario: First Run of Command
-        Given I successfully run `cli`
+        Given I successfully run `aruba-test-cli`
         Then the output should contain:
         \"\"\"
         Hello, Aruba!
         \"\"\"
     """
-
-  @requires-bash
-  Scenario: Bash Program
-    Given an executable named "bin/cli" with:
-    """bash
-    #!/usr/bin/env bash
-
-    echo "Hello, Aruba!"
-    """
     When I successfully run `cucumber`
     Then the features should all pass
 
@@ -55,12 +55,22 @@ Feature: Run commands with Aruba
 
   @requires-ruby
   Scenario: Ruby Program
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """ruby
     #!/usr/bin/env ruby
 
     puts "Hello, Aruba!"
     """
+    And a file named "features/hello_aruba.feature" with:
+    """
+    Feature: Getting Started With Aruba
+      Scenario: First Run of Command
+        Given I successfully run `aruba-test-cli`
+        Then the output should contain:
+        \"\"\"
+        Hello, Aruba!
+        \"\"\"
+    """
     When I successfully run `cucumber`
     Then the features should all pass
 
@@ -85,12 +95,22 @@ Feature: Run commands with Aruba
 
   @requires-python
   Scenario: Python Program
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """python
     #!/usr/bin/env python
 
     print("Hello, Aruba!")
     """
+    And a file named "features/hello_aruba.feature" with:
+    """
+    Feature: Getting Started With Aruba
+      Scenario: First Run of Command
+        Given I successfully run `aruba-test-cli`
+        Then the output should contain:
+        \"\"\"
+        Hello, Aruba!
+        \"\"\"
+    """
     When I successfully run `cucumber`
     Then the features should all pass
 
@@ -115,12 +135,22 @@ Feature: Run commands with Aruba
 
   @requires-perl
   Scenario: Perl Program
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """perl
     #!/usr/bin/env perl
 
     print "Hello, Aruba!\n";
     """
+    And a file named "features/hello_aruba.feature" with:
+    """
+    Feature: Getting Started With Aruba
+      Scenario: First Run of Command
+        Given I successfully run `aruba-test-cli`
+        Then the output should contain:
+        \"\"\"
+        Hello, Aruba!
+        \"\"\"
+    """
     When I successfully run `cucumber`
     Then the features should all pass
 
@@ -160,7 +190,7 @@ Feature: Run commands with Aruba
           }
         }
         \"\"\"
-        And I successfully run `javac tmp/HelloArubaApp.java`
+        And I successfully run `javac tmp/HelloArubaApp.java` for up to 20 seconds
         And I cd to "tmp/"
         And I successfully run `java HelloArubaApp`
         Then the output should contain:
@@ -168,7 +198,7 @@ Feature: Run commands with Aruba
         Hello, Aruba!
         \"\"\"
     """
-    When I successfully run `cucumber`
+    When I successfully run `cucumber` for up to 21 seconds
     Then the features should all pass
 
   @requires-posix-standard-tools

data/features/{getting_started → 01_getting_started_with_aruba}/supported_testing_frameworks.feature

@@ -31,19 +31,11 @@ Feature: Supported Testing Frameworks
     Then the features should all pass
 
   Scenario: Use "aruba" with "RSpec"
-    Given a file named "spec/support/aruba.rb" with:
-    """
-    require 'aruba/rspec'
-    """
-    And a file named "spec/spec_helper.rb" with:
+    Given a file named "spec/spec_helper.rb" with:
     """
     $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
-    if RUBY_VERSION < '1.9.3'
-      ::Dir.glob(::File.expand_path('../support/**/*.rb', __FILE__)).each { |f| require File.join(File.dirname(f), File.basename(f, '.rb')) }
-    else
-      ::Dir.glob(::File.expand_path('../support/**/*.rb', __FILE__)).each { |f| require_relative f }
-    end
+    require 'aruba/rspec'
     """
     And a file named "spec/use_aruba_with_rspec_spec.rb" with:
     """
@@ -63,19 +55,11 @@ Feature: Supported Testing Frameworks
 
 
   Scenario: Use "aruba" with "Minitest"
-    Given a file named "test/support/aruba.rb" with:
-    """
-    require 'aruba/api'
-    """
-    And a file named "test/test_helper.rb" with:
+    Given a file named "test/test_helper.rb" with:
     """
     $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
-    if RUBY_VERSION < '1.9.3'
-      ::Dir.glob(::File.expand_path('../support/**/*.rb', __FILE__)).each { |f| require File.join(File.dirname(f), File.basename(f, '.rb')) }
-    else
-      ::Dir.glob(::File.expand_path('../support/**/*.rb', __FILE__)).each { |f| require_relative f }
-    end
+    require 'aruba/api'
     """
     And a file named "test/use_aruba_with_minitest.rb" with:
     """
@@ -93,7 +77,7 @@ Feature: Supported Testing Frameworks
 
       def getting_started_with_aruba
         file = 'file.txt'
-        content = 'Hello World' 
+        content = 'Hello World'
 
         write_file file, content
         read(file).must_equal [content]

data/features/{configuration → 02_configure_aruba}/activate_announcer_on_command_failure.feature

@@ -8,7 +8,7 @@ Feature: Configure announcer activation on command failure
     Given I use the fixture "cli-app"
 
   Scenario: Default value
-    Given a file named "features/support/aruba.rb" with:
+    Given a file named "features/support/aruba_config.rb" with:
     """ruby
     Aruba.configure do |config|
       puts %(The default value is "#{config.activate_announcer_on_command_failure.inspect}")
@@ -21,7 +21,7 @@ Feature: Configure announcer activation on command failure
     """
 
   Scenario: Modify value
-    Given a file named "features/support/aruba.rb" with:
+    Given a file named "features/support/aruba_config.rb" with:
     """ruby
     Aruba.configure do |config|
       config.activate_announcer_on_command_failure = [:foo, :bar]

data/features/{configuration/usage.feature → 02_configure_aruba/basics.feature}

@@ -13,7 +13,7 @@ Feature: Usage of configuration
 
   Background:
     Given I use a fixture named "cli-app"
-    And an executable named "bin/cli" with:
+    And an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     trap "exit 128" SIGTERM SIGINT
@@ -21,12 +21,10 @@ Feature: Usage of configuration
     """
 
   Scenario: Setting default values for option for RSpec
-    Given a file named "spec/support/aruba.rb" with:
+    Given a file named "spec/support/aruba_config.rb" with:
     """ruby
-    require 'aruba/rspec'
-
     Aruba.configure do |config|
-      config.exit_timeout = 1
+      config.exit_timeout = 0.1
     end
     """
     And a file named "spec/usage_configuration_spec.rb" with:
@@ -35,12 +33,12 @@ Feature: Usage of configuration
 
     RSpec.describe 'Run command', :type => :aruba do
       context 'when fast command' do
-        before(:each) { run_command('cli 0') }
+        before(:each) { run_command('aruba-test-cli 0') }
         it { expect(last_command_started).to be_successfully_executed }
       end
 
       context 'when slow command' do
-        before(:each) { run_command('cli 2') }
+        before(:each) { run_command('aruba-test-cli 0.2') }
         it { expect(last_command_started).not_to be_successfully_executed }
       end
     end
@@ -54,12 +52,10 @@ Feature: Usage of configuration
     want to set the default timeout for all commands to the maximum value only
     to prevent those commands from failing.
 
-    Given a file named "spec/support/aruba.rb" with:
+    Given a file named "spec/support/aruba_config.rb" with:
     """ruby
-    require 'aruba/rspec'
-
     Aruba.configure do |config|
-      config.exit_timeout = 1
+      config.exit_timeout = 0.1
     end
     """
     And a file named "spec/support/hooks.rb" with:
@@ -68,7 +64,7 @@ Feature: Usage of configuration
       config.before :each do |example|
         next unless example.metadata.key? :slow_command
 
-        aruba.config.exit_timeout = 5
+        aruba.config.exit_timeout = 0.3
       end
     end
     """
@@ -78,17 +74,17 @@ Feature: Usage of configuration
 
     RSpec.describe 'Run command', :type => :aruba do
       context 'when fast command' do
-        before(:each) { run_command('cli 0') }
+        before(:each) { run_command('aruba-test-cli 0') }
         it { expect(last_command_started).to be_successfully_executed }
       end
 
       context 'when slow command and this is known by the developer', :slow_command => true do
-        before(:each) { run_command('cli 2') }
+        before(:each) { run_command('aruba-test-cli 0.2') }
         it { expect(last_command_started).to be_successfully_executed }
       end
 
       context 'when slow command, but this might be a failure' do
-        before(:each) { run_command('cli 2') }
+        before(:each) { run_command('aruba-test-cli 0.2') }
         it { expect(last_command_started).not_to be_successfully_executed }
       end
     end
@@ -97,23 +93,21 @@ Feature: Usage of configuration
     Then the specs should all pass
 
   Scenario: Setting default values for option for Cucumber
-    Given a file named "features/support/aruba.rb" with:
+    Given a file named "features/support/aruba_config.rb" with:
     """ruby
-    require 'aruba/cucumber'
-
     Aruba.configure do |config|
-      config.exit_timeout = 1
+      config.exit_timeout = 0.1
     end
     """
     And a file named "features/run.feature" with:
     """
     Feature: Run it
       Scenario: Fast command
-        When I run `cli 0`
+        When I run `aruba-test-cli 0`
         Then the exit status should be 0
 
       Scenario: Slow command
-        When I run `cli 2`
+        When I run `aruba-test-cli 0.2`
         Then the exit status should be 128
     """
     When I run `cucumber`
@@ -125,34 +119,32 @@ Feature: Usage of configuration
     want to set the default timeout for all commands to the maximum value only
     to prevent those commands from failing.
 
-    Given a file named "features/support/aruba.rb" with:
+    Given a file named "features/support/aruba_config.rb" with:
     """ruby
-    require 'aruba/cucumber'
-
     Aruba.configure do |config|
-      config.exit_timeout = 1
+      config.exit_timeout = 0.1
     end
     """
     And a file named "features/support/hooks.rb" with:
     """ruby
     Before '@slow-command' do
-      aruba.config.exit_timeout = 5
+      aruba.config.exit_timeout = 0.3
     end
     """
     And a file named "features/usage_configuration.feature" with:
     """
     Feature: Run it
       Scenario: Fast command
-        When I run `cli 0`
+        When I run `aruba-test-cli 0`
         Then the exit status should be 0
 
       @slow-command
       Scenario: Slow command known by the developer
-        When I run `cli 2`
+        When I run `aruba-test-cli 0.2`
         Then the exit status should be 0
 
       Scenario: Slow command which might be a failure
-        When I run `cli 3`
+        When I run `aruba-test-cli 0.2`
         Then the exit status should be 128
     """
     When I run `cucumber`