aruba 0.14.9 → 0.14.10

data/spec/aruba/jruby_spec.rb

@@ -2,54 +2,72 @@ require 'spec_helper'
 require 'aruba/api'
 
 describe "Aruba JRuby Startup Helper" do
-  before(:all) do
-    @fake_env = ENV.clone
+  include Aruba::Api
+
+  let(:rb_config) { double('RbConfig::CONFIG') }
+  let(:command) do
+    instance_double(Aruba::Processes::BasicProcess, :environment => command_environment)
   end
+  let(:command_environment) { { 'JRUBY_OPTS' => '--1.9', 'JAVA_OPTS' => '-Xdebug' } }
 
-  before :each do
+  before do
     Aruba.config.reset
 
-    # Define before_cmd-hook
+    # Define before :command hook
     load 'aruba/config/jruby.rb'
   end
 
-  before(:each) do
-    @fake_env['JRUBY_OPTS'] = "--1.9"
-    @fake_env['JAVA_OPTS'] = "-Xdebug"
-
-    stub_const('ENV', @fake_env)
-  end
-
-  context 'when some mri ruby' do
-    before :each do
+  context 'when running under some MRI Ruby' do
+    before do
       stub_const('RUBY_PLATFORM', 'x86_64-chocolate')
     end
 
-    before :each do
-      Aruba.config.before :command, self
-    end
+    it 'keeps the existing JRUBY_OPTS and JAVA_OPTS environment values' do
+      # Run defined before :command hook
+      Aruba.config.before :command, self, command
 
-    it { expect(ENV['JRUBY_OPTS']).to eq '--1.9' }
-    it { expect(ENV['JAVA_OPTS']).to eq '-Xdebug' }
+      aggregate_failures do
+        expect(command_environment['JRUBY_OPTS']).to eq '--1.9'
+        expect(command_environment['JAVA_OPTS']).to eq '-Xdebug'
+      end
+    end
   end
 
-  context 'when jruby ruby' do
-    before :each do
-      stub_const('RUBY_PLATFORM', 'java')
+  context 'when running under JRuby but not on Solaris' do
+    before do
+      stub_const 'RUBY_PLATFORM', 'java'
+      stub_const 'RbConfig::CONFIG', rb_config
+
+      allow(rb_config).to receive(:[]).with('host_os').and_return('foo-os')
     end
 
-    before :each do
-      rb_config = double('rb_config')
-      allow(rb_config).to receive(:[]).and_return('solaris')
+    it 'updates the existing JRuby but not Java option values' do
+      # Run defined before :command hook
+      Aruba.config.before :command, self, command
 
-      stub_const 'RbConfig::CONFIG', rb_config
+      aggregate_failures do
+        expect(command_environment['JRUBY_OPTS']).to eq '--dev -X-C --1.9'
+        expect(command_environment['JAVA_OPTS']).to eq '-Xdebug'
+      end
     end
+  end
 
+  context 'when running under JRuby on Solaris' do
     before :each do
-      Aruba.config.before :command, self
+      stub_const 'RUBY_PLATFORM', 'java'
+      stub_const 'RbConfig::CONFIG', rb_config
+
+      allow(rb_config).to receive(:[]).with('host_os').and_return('solaris')
     end
 
-    it { expect(ENV['JRUBY_OPTS']).to eq '--dev -X-C --1.9' }
-    it { expect(ENV['JAVA_OPTS']).to eq '-d32 -Xdebug' }
+    it 'keeps the existing JRuby and Java option values' do
+      # Run defined before :command hook
+      Aruba.config.before :command, self, command
+
+      aggregate_failures do
+        expect(command_environment['JRUBY_OPTS']).to eq '--dev -X-C --1.9'
+        expect(command_environment['JAVA_OPTS']).to eq '-d32 -Xdebug'
+      end
+    end
   end
 end

data/spec/aruba/{spawn_process_spec.rb → processes/spawn_process_spec.rb}

@@ -42,19 +42,35 @@ RSpec.describe Aruba::Processes::SpawnProcess do
     before(:each) { process.start }
 
     context 'when stopped successfully' do
-      it { process.stop }
+      it { expect { process.stop }.not_to raise_error }
+
+      it "leaves the process in the 'stopped' state" do
+        process.stop
+        aggregate_failures do
+          expect(process).to be_stopped
+          expect(process).not_to be_started
+        end
+      end
     end
   end
 
   describe "#start" do
     context "when process run succeeds" do
       it { expect { process.start }.not_to raise_error }
+
+      it "leaves the process in the 'started' state" do
+        process.start
+        aggregate_failures do
+          expect(process).to be_started
+          expect(process).not_to be_stopped
+        end
+      end
     end
 
     context "when process run fails" do
       let(:command) { 'does_not_exists' }
 
-      it { expect {process.start}.to raise_error Aruba::LaunchError }
+      it { expect { process.start }.to raise_error Aruba::LaunchError }
     end
 
     context 'with a command with a space in the path on unix' do

data/spec/spec_helper.rb

@@ -2,9 +2,11 @@
 
 $LOAD_PATH << ::File.expand_path('../../lib', __FILE__)
 
-require 'simplecov'
-SimpleCov.command_name 'rspec'
-SimpleCov.start
+unless RUBY_PLATFORM.include?('java')
+  require 'simplecov'
+  SimpleCov.command_name 'rspec'
+  SimpleCov.start
+end
 
 # Pull in all of the gems including those in the `test` group
 require 'bundler'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aruba
 version: !ruby/object:Gem::Version
-  version: 0.14.9
+  version: 0.14.10
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-18 00:00:00.000000000 Z
+date: 2019-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -154,114 +154,107 @@ files:
 - cucumber.yml
 - doc/dependency_decisions.yml
 - features/.nav
-- features/api/command/find_command.feature
-- features/api/command/last_command_started.feature
-- features/api/command/last_command_stopped.feature
-- features/api/command/run.feature
-- features/api/command/run_simple.feature
-- features/api/command/send_signal.feature
-- features/api/command/stderr.feature
-- features/api/command/stdout.feature
-- features/api/command/stop.feature
-- features/api/command/stop_all_commands.feature
-- features/api/command/terminate_all_commands.feature
-- features/api/command/which.feature
-- features/api/core/expand_path.feature
-- features/api/environment/append_environment_variable.feature
-- features/api/environment/delete_environment_variable.feature
-- features/api/environment/prepend_environment_variable.feature
-- features/api/environment/set_environment_variable.feature
-- features/api/filesystem/cd.feature
-- features/api/filesystem/create_directory.feature
-- features/api/filesystem/disk_usage.feature
-- features/api/filesystem/does_exist.feature
-- features/api/filesystem/fixtures.feature
-- features/api/filesystem/is_absolute.feature
-- features/api/filesystem/is_directory.feature
-- features/api/filesystem/is_file.feature
-- features/api/filesystem/is_relative.feature
-- features/api/filesystem/move.feature
-- features/api/text/extract_text.feature
-- features/api/text/replace_variables.feature
-- features/api/text/sanitize_text.feature
-- features/api/text/unescape_text.feature
-- features/cli/console.feature
-- features/cli/init.feature
-- features/configuration/activate_announcer_on_command_failure.feature
-- features/configuration/command_runtime_environment.feature
-- features/configuration/console_history_file.feature
-- features/configuration/exit_timeout.feature
-- features/configuration/fixtures_directories.feature
-- features/configuration/fixtures_path_prefix.feature
-- features/configuration/home_directory.feature
-- features/configuration/io_timeout.feature
-- features/configuration/keep_ansi.feature
-- features/configuration/log_level.feature
-- features/configuration/physical_block_size.feature
-- features/configuration/remove_ansi_escape_sequences.feature
-- features/configuration/root_directory.feature
-- features/configuration/startup_wait_time.feature
-- features/configuration/usage.feature
-- features/configuration/working_directory.feature
-- features/development/build.feature
-- features/getting_started/cleanup.feature
-- features/getting_started/run_commands.feature
-- features/getting_started/supported_testing_frameworks.feature
-- features/getting_started/writing_good_feature_tests.feature
-- features/hooks/after/command.feature
-- features/hooks/before/command.feature
-- features/matchers/collection/include_an_object.feature
-- features/matchers/directory/have_sub_directory.feature
-- features/matchers/file/be_a_command_found_in_path.feature
-- features/matchers/file/be_existing_executable.feature
-- features/matchers/file/be_existing_file.feature
-- features/matchers/file/have_file_content.feature
-- features/matchers/file/have_file_size.feature
-- features/matchers/path/be_an_absolute_path.feature
-- features/matchers/path/be_an_existing_path.feature
-- features/matchers/path/have_permissions.feature
-- features/matchers/timeouts.feature
-- features/platforms/jruby.feature
-- features/rspec/integration.feature
-- features/step_definitions/aruba_dev_steps.rb
+- features/01_getting_started_with_aruba/cleanup_working_directory.feature
+- features/01_getting_started_with_aruba/run_commands.feature
+- features/01_getting_started_with_aruba/supported_testing_frameworks.feature
+- features/02_configure_aruba/activate_announcer_on_command_failure.feature
+- features/02_configure_aruba/basics.feature
+- features/02_configure_aruba/command_runtime_environment.feature
+- features/02_configure_aruba/console_history_file.feature
+- features/02_configure_aruba/exit_timeout.feature
+- features/02_configure_aruba/fixtures_directories.feature
+- features/02_configure_aruba/fixtures_path_prefix.feature
+- features/02_configure_aruba/home_directory.feature
+- features/02_configure_aruba/io_timeout.feature
+- features/02_configure_aruba/keep_ansi.feature
+- features/02_configure_aruba/log_level.feature
+- features/02_configure_aruba/physical_block_size.feature
+- features/02_configure_aruba/remove_ansi_escape_sequences.feature
+- features/02_configure_aruba/root_directory.feature
+- features/02_configure_aruba/startup_wait_time.feature
+- features/02_configure_aruba/working_directory.feature
+- features/03_testing_frameworks/cucumber/announce_information_for_troubleshooting.feature
+- features/03_testing_frameworks/cucumber/disable_bunder.feature
+- features/03_testing_frameworks/cucumber/steps/command/check_for_exit_statuses.feature
+- features/03_testing_frameworks/cucumber/steps/command/check_output_of_command.feature
+- features/03_testing_frameworks/cucumber/steps/command/check_stderr_of_command.feature
+- features/03_testing_frameworks/cucumber/steps/command/check_stdout_of_command.feature
+- features/03_testing_frameworks/cucumber/steps/command/debug_your_command_in_aruba.feature
+- features/03_testing_frameworks/cucumber/steps/command/run_a_command.feature
+- features/03_testing_frameworks/cucumber/steps/command/run_command_in_process.feature
+- features/03_testing_frameworks/cucumber/steps/command/run_command_interactively.feature
+- features/03_testing_frameworks/cucumber/steps/command/run_commands_which_require_a_shell.feature
+- features/03_testing_frameworks/cucumber/steps/command/send_signal_to_command.feature
+- features/03_testing_frameworks/cucumber/steps/command/stop_command.feature
+- features/03_testing_frameworks/cucumber/steps/environment/append_environment_variable.feature
+- features/03_testing_frameworks/cucumber/steps/environment/modify_home_variable_for_testing.feature
+- features/03_testing_frameworks/cucumber/steps/environment/prepend_environment_variable.feature
+- features/03_testing_frameworks/cucumber/steps/environment/set_environment_variable.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/append_to_file.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/cd_to_directory.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/check_existence_of_directory.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/check_existence_of_file.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/check_file_content.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/check_non_existence_of_directory.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/check_non_existence_of_file.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/check_permissions_of_file.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/compare_files.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/copy_file_or_directory.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/create_directory.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/create_file.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/move_file_or_directory.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/overwrite_file.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/remove_directory.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/remove_file.feature
+- features/03_testing_frameworks/cucumber/steps/filesystem/use_fixtures_for_setup_test.feature
+- features/03_testing_frameworks/rspec/hooks/define_after_hook_for_commands.feature
+- features/03_testing_frameworks/rspec/hooks/define_before_hook_for_commands.feature
+- features/03_testing_frameworks/rspec/setup_aruba_for_rspec.feature
+- features/04_aruba_api/command/find_a_started_command.feature
+- features/04_aruba_api/command/find_command_in_PATH.feature
+- features/04_aruba_api/command/read_stderr_of_command.feature
+- features/04_aruba_api/command/read_stdout_of_command.feature
+- features/04_aruba_api/command/run_command.feature
+- features/04_aruba_api/command/run_simple.feature
+- features/04_aruba_api/command/send_signal_to_command.feature
+- features/04_aruba_api/command/stop_all_commands.feature
+- features/04_aruba_api/command/stop_single_command.feature
+- features/04_aruba_api/command/terminate_all_commands.feature
+- features/04_aruba_api/command/use_last_command_started.feature
+- features/04_aruba_api/command/use_last_command_stopped.feature
+- features/04_aruba_api/core/expand_path.feature
+- features/04_aruba_api/environment/append_environment_variable.feature
+- features/04_aruba_api/environment/delete_environment_variable.feature
+- features/04_aruba_api/environment/prepend_environment_variable.feature
+- features/04_aruba_api/environment/set_environment_variable.feature
+- features/04_aruba_api/filesystem/cd_to_directory.feature
+- features/04_aruba_api/filesystem/check_existence_file_or_directory.feature
+- features/04_aruba_api/filesystem/check_if_path_is_absolute.feature
+- features/04_aruba_api/filesystem/check_if_path_is_directory.feature
+- features/04_aruba_api/filesystem/check_if_path_is_file.feature
+- features/04_aruba_api/filesystem/check_if_path_is_relative.feature
+- features/04_aruba_api/filesystem/create_directory.feature
+- features/04_aruba_api/filesystem/move_file_or_directory.feature
+- features/04_aruba_api/filesystem/report_disk_usage.feature
+- features/04_aruba_api/filesystem/use_fixtures.feature
+- features/04_aruba_api/text/extract_text.feature
+- features/04_aruba_api/text/replace_variables.feature
+- features/04_aruba_api/text/sanitize_text.feature
+- features/04_aruba_api/text/unescape_text.feature
+- features/05_use_rspec_matchers/command/check_timeouts.feature
+- features/05_use_rspec_matchers/directory/have_sub_directory.feature
+- features/05_use_rspec_matchers/file/be_a_command_found_in_path.feature
+- features/05_use_rspec_matchers/file/be_existing_executable.feature
+- features/05_use_rspec_matchers/file/be_existing_file.feature
+- features/05_use_rspec_matchers/file/have_file_content.feature
+- features/05_use_rspec_matchers/file/have_file_size.feature
+- features/05_use_rspec_matchers/path/be_an_absolute_path.feature
+- features/05_use_rspec_matchers/path/be_an_existing_path.feature
+- features/05_use_rspec_matchers/path/have_permissions.feature
+- features/06_use_aruba_cli/initialize_project_with_aruba.feature
+- features/06_use_aruba_cli/open_console.feature
+- features/08_other/improve_performance_if_using_jruby.feature
 - features/step_definitions/hooks.rb
-- features/steps/command/debug.feature
-- features/steps/command/exit_statuses.feature
-- features/steps/command/in_process.feature
-- features/steps/command/interactive.feature
-- features/steps/command/output.feature
-- features/steps/command/run.feature
-- features/steps/command/send_signal.feature
-- features/steps/command/shell.feature
-- features/steps/command/stderr.feature
-- features/steps/command/stdout.feature
-- features/steps/command/stop.feature
-- features/steps/core/announce.feature
-- features/steps/environment/append_environment_variable.feature
-- features/steps/environment/disable_bunder.feature
-- features/steps/environment/home_variable.feature
-- features/steps/environment/prepend_environment_variable.feature
-- features/steps/environment/set_environment_variable.feature
-- features/steps/filesystem/append_to_file.feature
-- features/steps/filesystem/cd_to_directory.feature
-- features/steps/filesystem/check_file_content.feature
-- features/steps/filesystem/check_permissions_of_file.feature
-- features/steps/filesystem/compare_files.feature
-- features/steps/filesystem/copy.feature
-- features/steps/filesystem/create_directory.feature
-- features/steps/filesystem/create_file.feature
-- features/steps/filesystem/existence_of_directory.feature
-- features/steps/filesystem/existence_of_file.feature
-- features/steps/filesystem/file_content.feature
-- features/steps/filesystem/fixtures.feature
-- features/steps/filesystem/move.feature
-- features/steps/filesystem/non_existence_of_directory.feature
-- features/steps/filesystem/non_existence_of_file.feature
-- features/steps/filesystem/overwrite_file.feature
-- features/steps/filesystem/remove_directory.feature
-- features/steps/filesystem/remove_file.feature
-- features/steps/filesystem/use_fixture.feature
-- features/steps/overview.feature
 - features/support/aruba.rb
 - features/support/env.rb
 - features/support/jruby.rb
@@ -270,7 +263,7 @@ files:
 - fixtures/cli-app/.rspec
 - fixtures/cli-app/README.md
 - fixtures/cli-app/Rakefile
-- fixtures/cli-app/bin/cli
+- fixtures/cli-app/bin/aruba-test-cli
 - fixtures/cli-app/cli-app.gemspec
 - fixtures/cli-app/features/support/env.rb
 - fixtures/cli-app/lib/cli/app.rb
@@ -319,6 +312,7 @@ files:
 - lib/aruba/cucumber.rb
 - lib/aruba/cucumber/command.rb
 - lib/aruba/cucumber/core.rb
+- lib/aruba/cucumber/deprecated.rb
 - lib/aruba/cucumber/environment.rb
 - lib/aruba/cucumber/file.rb
 - lib/aruba/cucumber/hooks.rb
@@ -407,10 +401,9 @@ files:
 - script/console
 - script/test
 - spec/aruba/api/bundler_spec.rb
+- spec/aruba/api/core_spec.rb
 - spec/aruba/api/deprecated_spec.rb
-- spec/aruba/api/environment/restore_env_spec.rb
-- spec/aruba/api/environment/set_env_spec.rb
-- spec/aruba/api/filesystem/file_size_spec.rb
+- spec/aruba/api/filesystem_spec.rb
 - spec/aruba/api/runtime_spec.rb
 - spec/aruba/api_spec.rb
 - spec/aruba/aruba_path_spec.rb
@@ -429,9 +422,9 @@ files:
 - spec/aruba/platform/windows_environment_variables_spec.rb
 - spec/aruba/platforms/unix_command_string_spec.rb
 - spec/aruba/platforms/windows_command_string_spec.rb
+- spec/aruba/processes/spawn_process_spec.rb
 - spec/aruba/rspec_spec.rb
 - spec/aruba/runtime_spec.rb
-- spec/aruba/spawn_process_spec.rb
 - spec/event_bus/name_resolver_spec.rb
 - spec/event_bus_spec.rb
 - spec/spec_helper.rb
@@ -492,5 +485,5 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: aruba-0.14.9
+summary: aruba-0.14.10
 test_files: []

data/features/development/build.feature

@@ -1,15 +0,0 @@
-Feature: Build Aruba Gem
-
-  As a aruba developer
-  I want to build the `aruba` gem
-  In order to install it
-
-  Scenario: Building aruba using rake task
-
-    To build the `aruba`-gem you can use the `build`-rake task.
-
-    Given I successfully run `rake -T build`
-    Then the output should contain:
-    """
-    build
-    """

data/features/getting_started/writing_good_feature_tests.feature

@@ -1,38 +0,0 @@
-Feature: Writing good feature tests with aruba to create documentations
-
-  You can use Markdown within your feature tests. This is quite good to write a
-  living documentation.
-
-  There are some edge cases where Gherkin and Markdown don't agree. Bullet lists
-  using `*` is one example. The `*` is also an alias for step keywords in
-  Gherkin. Markdown headers (the kind starting with a `#`) is another example.
-  They are parsed as comments by Gherkin. To use either of these, just escape
-  them with a backslash. Alternatively just use the "-".
-
-  You'd write:
-
-  ```gherkin
-  Scenario: Make tea
-    \## Making tea
-    \* Get a pot
-    \* And some hot water
-
-    Given...
-  ```
-
-  This way Gherkin won't recognize these lines as special tokens, and the
-  reporter will render them as Markdown. (The reporter strips away any leading
-  the backslashes before handing it off to the Markdown parser).
-
-  Another option is to use alternative Markdown syntax and omit conflicts and
-  escaping altogether:
-
-  ```gherkin
-  Scenario: Make tea
-    Making tea
-    ----------
-    - Get a pot
-    - And some hot water
-
-    Given...
-  ```