aruba 0.14.9 → 0.14.10

data/features/{api → 04_aruba_api}/command/run_simple.feature

@@ -1,4 +1,4 @@
-Feature: Run command
+Feature: Run command in a simpler fashion
 
   To run a command use the `#run_command_and_stop`-method. There are some configuration options
   which are relevant here:
@@ -13,7 +13,7 @@ Feature: Run command
     Given I use a fixture named "cli-app"
 
   Scenario: Require executable to succeed (by default value)
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     exit 1
@@ -23,14 +23,14 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_command_and_stop('cli') }.to raise_error RSpec::Expectations::ExpectationNotMetError }
+      it { expect { run_command_and_stop('aruba-test-cli') }.to raise_error RSpec::Expectations::ExpectationNotMetError }
     end
     """
     When I run `rspec`
     Then the specs should all pass
 
   Scenario: Require executable to succeed (set by option)
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     exit 1
@@ -40,14 +40,14 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_command_and_stop('cli', :fail_on_error => true) }.to raise_error }
+      it { expect { run_command_and_stop('aruba-test-cli', :fail_on_error => true) }.to raise_error }
     end
     """
     When I run `rspec`
     Then the specs should all pass
 
   Scenario: Require executable to succeed (set by option, deprecated)
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     exit 1
@@ -57,14 +57,14 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_command_and_stop('cli', true) }.to raise_error }
+      it { expect { run_command_and_stop('aruba-test-cli', true) }.to raise_error }
     end
     """
     When I run `rspec`
     Then the specs should all pass
 
   Scenario: Ignore failure of executable (set by option)
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     exit 1
@@ -74,14 +74,14 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_command_and_stop('cli', :fail_on_error => false) }.not_to raise_error }
+      it { expect { run_command_and_stop('aruba-test-cli', :fail_on_error => false) }.not_to raise_error }
     end
     """
     When I run `rspec`
     Then the specs should all pass
 
   Scenario: Ignore failure of executable (set by option, deprecated)
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     exit 1
@@ -91,7 +91,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_command_and_stop('cli', false) }.not_to raise_error }
+      it { expect { run_command_and_stop('aruba-test-cli', false) }.not_to raise_error }
     end
     """
     When I run `rspec`
@@ -102,14 +102,14 @@ Feature: Run command
     If you have got a command with a long startup phase or use `ruby` together
     with `bundler`, you should consider using the `startup_wait_time`-option.
     Otherwise methods like `#send_signal` don't work since they require the
-    command to be running and have setup it's signal handler.
+    command to be running and have setup its signal handler.
 
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/usr/bin/env bash
 
     function initialize_script {
-      sleep 2
+      sleep 0.2
     }
 
     function do_some_work {
@@ -125,27 +125,31 @@ Feature: Run command
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 2 do
-      before(:each) { run_command_and_stop('cli') }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 0.1, :startup_wait_time => 0.3 do
+      before(:each) { run_command_and_stop('aruba-test-cli') }
 
-      it { expect(last_command_started).to be_successfully_executed }
-      it { expect(last_command_started).to have_output /Hello, Aruba is working/ }
+      it 'runs the command with the expected results' do
+        aggregate_failures do
+          expect(last_command_started).to be_successfully_executed
+          expect(last_command_started).to have_output /Hello, Aruba is working/
+        end
+      end
     end
     """
     When I run `rspec`
     Then the specs should all pass
 
-  Scenario: Long running command
+  Scenario: Long-running command
 
-    If you have got a "long running" command, you should consider using the
+    If you have got a long-running command, you should consider using the
     `exit_timeout`-option.
 
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/usr/bin/env bash
 
     function do_some_work {
-      sleep 2
+      sleep 0.2
       echo "Hello, Aruba here"
     }
 
@@ -155,11 +159,15 @@ Feature: Run command
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 3 do
-      before(:each) { run_command_and_stop('cli') }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 0.3 do
+      before(:each) { run_command_and_stop('aruba-test-cli') }
 
-      it { expect(last_command_started).to be_successfully_executed }
-      it { expect(last_command_started).to have_output /Hello, Aruba here/ }
+      it 'runs the command with the expected results' do
+        aggregate_failures do
+          expect(last_command_started).to be_successfully_executed
+          expect(last_command_started).to have_output /Hello, Aruba here/
+        end
+      end
     end
     """
     When I run `rspec`
@@ -171,16 +179,16 @@ Feature: Run command
     `#run_command_and_stop()` does not make sense. The command is stopped internally when
     its exit status is checked.
 
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/usr/bin/env bash
 
     function initialize_script {
-      sleep 1
+      sleep 0.1
     }
 
     function cleanup_script {
-      sleep 1
+      sleep 0.1
     }
 
     function do_some_work {
@@ -198,9 +206,13 @@ Feature: Run command
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 2, :startup_wait_time => 1 do
-      before(:each) { run_command_and_stop('cli') }
-      it { expect { last_command_started.send_signal 'HUP' }.to raise_error Aruba::CommandAlreadyStoppedError }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 0.2, :startup_wait_time => 0.2 do
+      before { run_command_and_stop('aruba-test-cli') }
+
+      it 'refuses to send a signal' do
+        expect { last_command_started.send_signal 'HUP' }.
+          to raise_error Aruba::CommandAlreadyStoppedError
+      end
     end
     """
     When I run `rspec`
@@ -208,7 +220,7 @@ Feature: Run command
 
   Scenario: Activate announcer channels on failure
 
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     echo "Hello, I'm STDOUT"
@@ -224,7 +236,7 @@ Feature: Run command
     end
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_command_and_stop('cli', :fail_on_error => true) }.to_not raise_error }
+      it { expect { run_command_and_stop('aruba-test-cli', :fail_on_error => true) }.to_not raise_error }
     end
     """
     When I run `rspec`

data/features/{api/command/send_signal.feature → 04_aruba_api/command/send_signal_to_command.feature}

@@ -8,7 +8,7 @@ Feature: Send running command a signal
     Given I use a fixture named "cli-app"
 
   Scenario: Existing executable
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """ruby
     #!/usr/bin/env bash
 
@@ -19,14 +19,14 @@ Feature: Send running command a signal
 
     trap hup HUP
 
-    while [ true ]; do sleep 1; done
+    while [ true ]; do sleep 0.1; done
     """
     And a file named "spec/run_spec.rb" with:
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 5 do
-      before(:each) { run_command('cli') }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 0.1 do
+      before(:each) { run_command('aruba-test-cli') }
       before(:each) { last_command_started.send_signal 'HUP' }
       it { expect(last_command_started).to have_output /Exit/ }
     end
@@ -35,7 +35,7 @@ Feature: Send running command a signal
     Then the specs should all pass
 
   Scenario: Dying command
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """ruby
     #!/usr/bin/env bash
     exit 1
@@ -44,9 +44,9 @@ Feature: Send running command a signal
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 5 do
-      before(:each) { run_command('cli') }
-      it { expect { last_command_started.send_signal 'HUP' }.to raise_error Aruba::CommandAlreadyStoppedError, /Command "cli" with PID/ }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 0.1 do
+      before(:each) { run_command('aruba-test-cli') }
+      it { expect { last_command_started.send_signal 'HUP' }.to raise_error Aruba::CommandAlreadyStoppedError, /Command "aruba-test-cli" with PID/ }
     end
     """
     When I run `rspec`

data/features/{api → 04_aruba_api}/command/stop_all_commands.feature

@@ -6,18 +6,18 @@ Feature: Stop all commands
     Given I use a fixture named "cli-app"
 
   Scenario: Multiple commands are running
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
-    sleep 3
+    sleep 0.2
     """
     And a file named "spec/run_spec.rb" with:
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 5 do
-      before(:each) { run_command('cli') }
-      before(:each) { run_command('cli') }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 0.3 do
+      before(:each) { run_command('aruba-test-cli') }
+      before(:each) { run_command('aruba-test-cli') }
 
       before(:each) { stop_all_commands }
 
@@ -28,25 +28,29 @@ Feature: Stop all commands
     Then the specs should all pass
 
   Scenario: Stop all commands for which the block returns true
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
-    sleep 1
+    sleep 0.1
     """
     And a file named "spec/run_spec.rb" with:
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 2 do
-      before(:each) { @cmd1 = run_command('cli') }
-      before(:each) { @cmd2 = run_command('cli') }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 0.2 do
+      before(:each) { @cmd1 = run_command('aruba-test-cli') }
+      before(:each) { @cmd2 = run_command('aruba-test-cli') }
       before(:each) { @cmd3 = run_command('sleep 1') }
 
-      before(:each) { stop_all_commands { |c| c.commandline == 'cli' } }
+      before(:each) { stop_all_commands { |c| c.commandline == 'aruba-test-cli' } }
 
-      it { expect(@cmd1).to be_stopped }
-      it { expect(@cmd2).to be_stopped }
-      it { expect(@cmd3).not_to be_stopped }
+      it 'only stops selected commands' do
+        aggregate_failures do
+          expect(@cmd1).to be_stopped
+          expect(@cmd2).to be_stopped
+          expect(@cmd3).not_to be_stopped
+        end
+      end
     end
     """
     When I run `rspec`

data/features/{api/command/stop.feature → 04_aruba_api/command/stop_single_command.feature}

@@ -6,14 +6,14 @@ Feature: Stop command
   - `find_command('command').stop`
 
   But normally there's no need to stop a command manually. All matchers
-  handling commands make sure, that they stop ALL command before check actual
+  handling commands make sure, that they stop ALL commands before checking actual
   against expected.
 
   Background:
     Given I use a fixture named "cli-app"
 
   Scenario: Stop command started last
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     function term {
@@ -21,14 +21,14 @@ Feature: Stop command
     }
 
     trap term TERM
-    while [ true ]; do sleep 1; done
+    while [ true ]; do sleep 0.1; done
     """
     And a file named "spec/run_spec.rb" with:
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run_command('cli') }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 0.2 do
+      before(:each) { run_command('aruba-test-cli') }
       before(:each) { last_command_started.stop }
       it { expect(last_command_started).to be_successfully_executed }
     end
@@ -37,7 +37,7 @@ Feature: Stop command
     Then the specs should all pass
 
   Scenario: Find and stop command
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     function term {
@@ -45,15 +45,16 @@ Feature: Stop command
     }
 
     trap term TERM
-    while [ true ]; do sleep 1; done
+    while [ true ]; do sleep 0.1; done
+    exit 1
     """
     And a file named "spec/run_spec.rb" with:
     """ruby
     require 'spec_helper'
 
-    RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run_command('cli') }
-      before(:each) { find_command('cli').stop }
+    RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 0.2 do
+      before(:each) { run_command('aruba-test-cli') }
+      before(:each) { find_command('aruba-test-cli').stop }
       it { expect(last_command_started).to be_successfully_executed }
     end
     """
@@ -61,7 +62,7 @@ Feature: Stop command
     Then the specs should all pass
 
   Scenario: Stop successful command with configured signal
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     function hup {
@@ -76,7 +77,7 @@ Feature: Stop command
 
     trap hup HUP
     trap term TERM
-    while [ true ]; do sleep 1; done
+    while [ true ]; do sleep 0.1; done
     """
     And a file named "spec/run_spec.rb" with:
     """ruby
@@ -84,11 +85,11 @@ Feature: Stop command
 
     Aruba.configure do |config|
       config.stop_signal  = 'HUP'
-      config.exit_timeout = 1
+      config.exit_timeout = 0.2
     end
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run_command('cli') }
+      before(:each) { run_command('aruba-test-cli') }
       it { expect(last_command_started).to be_successfully_executed }
     end
     """
@@ -96,7 +97,7 @@ Feature: Stop command
     Then the specs should all pass
 
   Scenario: Stop unsuccessful command with configured signal
-    Given an executable named "bin/cli" with:
+    Given an executable named "bin/aruba-test-cli" with:
     """bash
     #!/bin/bash
     function hup {
@@ -111,7 +112,7 @@ Feature: Stop command
 
     trap hup HUP
     trap term TERM
-    while [ true ]; do sleep 1; done
+    while [ true ]; do sleep 0.1; done
     """
     And a file named "spec/run_spec.rb" with:
     """ruby
@@ -119,11 +120,11 @@ Feature: Stop command
 
     Aruba.configure do |config|
       config.stop_signal  = 'HUP'
-      config.exit_timeout = 1
+      config.exit_timeout = 0.2
     end
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run_command('cli') }
+      before(:each) { run_command('aruba-test-cli') }
       it { expect(last_command_started).to have_exit_status 2 }
     end
     """