aruba 1.0.0.pre.alpha.3 → 1.0.2

data/lib/aruba/cucumber/file.rb

@@ -3,11 +3,13 @@ Given(/^I use (?:a|the) fixture(?: named)? "([^"]*)"$/) do |name|
   cd name
 end
 
-Given(/^I copy (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) do |source, destination|
+Given(/^I copy (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) \
+  do |source, destination|
   copy source, destination
 end
 
-Given(/^I move (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) do |source, destination|
+Given(/^I move (?:a|the) (?:file|directory)(?: (?:named|from))? "([^"]*)" to "([^"]*)"$/) \
+  do |source, destination|
   move source, destination
 end
 
@@ -15,7 +17,8 @@ Given(/^(?:a|the|(?:an empty)) directory(?: named)? "([^"]*)"$/) do |dir_name|
   create_directory(dir_name)
 end
 
-Given(/^(?:a|the) directory(?: named)? "([^"]*)" with mode "([^"]*)"$/) do |dir_name, dir_mode|
+Given(/^(?:a|the) directory(?: named)? "([^"]*)" with mode "([^"]*)"$/) \
+  do |dir_name, dir_mode|
   create_directory(dir_name)
   chmod(dir_mode, dir_name)
 end
@@ -25,14 +28,15 @@ Given(/^(?:a|the) file(?: named)? "([^"]*)" with:$/) do |file_name, file_content
 end
 
 Given(/^(?:an|the) executable(?: named)? "([^"]*)" with:$/) do |file_name, file_content|
-  step %(a file named "#{file_name}" with mode "0755" and with:), file_content
+  step %(a file named "#{file_name}" with mode "0o755" and with:), file_content
 end
 
 Given(/^(?:a|the) file(?: named)? "([^"]*)" with "([^"]*)"$/) do |file_name, file_content|
   write_file(file_name, unescape_text(file_content))
 end
 
-Given(/^(?:a|the) file(?: named)? "([^"]*)" with mode "([^"]*)" and with:$/) do |file_name, file_mode, file_content|
+Given(/^(?:a|the) file(?: named)? "([^"]*)" with mode "([^"]*)" and with:$/) \
+  do |file_name, file_mode, file_content|
   write_file(file_name, unescape_text(file_content))
   chmod(file_mode, file_name)
 end
@@ -45,7 +49,8 @@ Given(/^(?:an|the) empty file(?: named)? "([^"]*)"$/) do |file_name|
   write_file(file_name, '')
 end
 
-Given(/^(?:an|the) empty file(?: named)? "([^"]*)" with mode "([^"]*)"$/) do |file_name, file_mode|
+Given(/^(?:an|the) empty file(?: named)? "([^"]*)" with mode "([^"]*)"$/) \
+  do |file_name, file_mode|
   write_file(file_name, '')
   chmod(file_mode, file_name)
 end
@@ -54,7 +59,8 @@ When(/^I write to "([^"]*)" with:$/) do |file_name, file_content|
   write_file(file_name, file_content)
 end
 
-When(/^I overwrite(?: (?:a|the) file(?: named)?)? "([^"]*)" with:$/) do |file_name, file_content|
+When(/^I overwrite(?: (?:a|the) file(?: named)?)? "([^"]*)" with:$/) \
+  do |file_name, file_content|
   overwrite_file(file_name, file_content)
 end
 
@@ -66,7 +72,8 @@ When(/^I append to "([^"]*)" with "([^"]*)"$/) do |file_name, file_content|
   append_to_file(file_name, file_content)
 end
 
-When(/^I remove (?:a|the) (?:file|directory)(?: named)? "([^"]*)"( with full force)?$/) do |name, force_remove|
+When(/^I remove (?:a|the) (?:file|directory)(?: named)? "([^"]*)"( with full force)?$/) \
+  do |name, force_remove|
   remove(name, force: force_remove.nil? ? false : true)
 end
 
@@ -88,21 +95,21 @@ Then(/^the following files should (not )?exist:$/) do |negated, files|
   end
 end
 
-Then(/^(?:a|the) (file|directory)(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) do |directory_or_file, path, expect_match|
-  if directory_or_file == 'file'
-    if expect_match
-      expect(path).not_to be_an_existing_file
-    else
-      expect(path).to be_an_existing_file
-    end
-  elsif directory_or_file == 'directory'
-    if expect_match
-      expect(path).not_to be_an_existing_directory
-    else
-      expect(path).to be_an_existing_directory
-    end
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) \
+  do |path, expect_match|
+  if expect_match
+    expect(path).not_to be_an_existing_file
+  else
+    expect(path).to be_an_existing_file
+  end
+end
+
+Then(/^(?:a|the) directory(?: named)? "([^"]*)" should (not )?exist(?: anymore)?$/) \
+  do |path, expect_match|
+  if expect_match
+    expect(path).not_to be_an_existing_directory
   else
-    fail ArgumentError, %("#{directory_or_file}" can only be "directory" or "file".)
+    expect(path).to be_an_existing_directory
   end
 end
 
@@ -114,7 +121,8 @@ Then(/^(?:a|the) file matching %r<(.*?)> should (not )?exist$/) do |pattern, exp
   end
 end
 
-Then(/^(?:a|the) (\d+) byte file(?: named)? "([^"]*)" should (not )?exist$/) do |size, file, negated|
+Then(/^(?:a|the) (\d+) byte file(?: named)? "([^"]*)" should (not )?exist$/) \
+  do |size, file, negated|
   if negated
     expect(file).not_to have_file_size(size)
   else
@@ -132,7 +140,8 @@ Then(/^the following directories should (not )?exist:$/) do |negated, directorie
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain "([^"]*)"$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain "([^"]*)"$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_including(content.chomp)
   else
@@ -140,7 +149,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain "([^"]*)"$/) do
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain:$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain:$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_including(content.chomp)
   else
@@ -148,7 +158,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain:$/) do |file, n
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain exactly:$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain exactly:$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content content
   else
@@ -156,7 +167,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?contain exactly:$/) do
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match %r<([^>]*)>$/) do |file, negated, content|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match %r<([^>]*)>$/) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_matching(content)
   else
@@ -164,7 +176,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match %r<([^>]*)>$/) do
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match \/([^\/]*)\/$/) do |file, negated, content|
+Then(%r{^(?:a|the) file(?: named)? "([^"]*)" should (not )?match /([^/]*)/$}) \
+  do |file, negated, content|
   if negated
     expect(file).not_to have_file_content file_content_matching(content)
   else
@@ -172,7 +185,8 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?match \/([^\/]*)\/$/) d
   end
 end
 
-Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?be equal to file "([^"]*)"/) do |file, negated, reference_file|
+Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?be equal to file "([^"]*)"/) \
+  do |file, negated, reference_file|
   if negated
     expect(file).not_to have_same_file_content_as(reference_file)
   else
@@ -180,10 +194,14 @@ Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?be equal to file "([^"]
   end
 end
 
-Then(/^the (?:file|directory)(?: named)? "([^"]*)" should( not)? have permissions "([^"]*)"$/) do |path, negated, permissions|
-  if negated
-    expect(path).not_to have_permissions(permissions)
-  else
-    expect(path).to have_permissions(permissions)
-  end
+Then(
+  /^(?:a|the) (?:file|directory)(?: named)? "([^"]*)" should have permissions "([^"]*)"$/
+) do |path, permissions|
+  expect(path).to have_permissions(permissions)
+end
+
+Then(
+  /^(?:a|the) (?:file|directory)(?: named)? "([^"]*)" should not have permissions "([^"]*)"$/
+) do |path, permissions|
+  expect(path).not_to have_permissions(permissions)
 end

data/lib/aruba/cucumber/hooks.rb

@@ -9,7 +9,10 @@ end
 
 Before do
   # ... so every change needs to be done later
-  prepend_environment_variable 'PATH', aruba.config.command_search_paths.join(File::PATH_SEPARATOR) + File::PATH_SEPARATOR
+  prepend_environment_variable(
+    'PATH',
+    aruba.config.command_search_paths.join(File::PATH_SEPARATOR) + File::PATH_SEPARATOR
+  )
   set_environment_variable 'HOME', aruba.config.home_directory
 end
 

data/lib/aruba/cucumber/testing_frameworks.rb

@@ -1,25 +1,33 @@
 # Cucumber
-Then /^the feature(?:s)? should( not)?(?: all)? pass$/ do |negated|
-  if negated
-    step 'the output should contain " failed)"'
-    step 'the exit status should be 1'
-  else
-    step 'the output should not contain " failed)"'
-    step 'the output should not contain " undefined)"'
-    step 'the exit status should be 0'
-  end
+Then(/^the feature(?:s)? should not(?: all)? pass$/) do
+  step 'the output should contain " failed)"'
+  step 'the exit status should be 1'
+end
+
+# Cucumber
+Then(/^the feature(?:s)? should(?: all)? pass$/) do
+  step 'the output should not contain " failed)"'
+  step 'the output should not contain " undefined)"'
+  step 'the exit status should be 0'
 end
 
 # Cucumber
-Then /^the feature(?:s)? should( not)?(?: all)? pass with( regex)?:$/ do |negated, regex, string|
-  if negated
-    step 'the output should contain " failed)"'
-    step 'the exit status should be 1'
+Then(/^the feature(?:s)? should not(?: all)? pass with( regex)?:$/) do |regex, string|
+  step 'the output should contain " failed)"'
+  step 'the exit status should be 1'
+
+  if regex
+    step "the output should match %r<#{string}>"
   else
-    step 'the output should not contain " failed)"'
-    step 'the output should not contain " undefined)"'
-    step 'the exit status should be 0'
+    step 'the output should contain:', string
   end
+end
+
+# Cucumber
+Then(/^the feature(?:s)? should(?: all)? pass with( regex)?:$/) do |regex, string|
+  step 'the output should not contain " failed)"'
+  step 'the output should not contain " undefined)"'
+  step 'the exit status should be 0'
 
   if regex
     step "the output should match %r<#{string}>"
@@ -29,30 +37,39 @@ Then /^the feature(?:s)? should( not)?(?: all)? pass with( regex)?:$/ do |negate
 end
 
 # RSpec
-Then /^the spec(?:s)? should( not)?(?: all)? pass(?: with (\d+) failures?)?$/ do |negated, count_failures|
-  if negated
-    if count_failures.nil?
-      step 'the output should not contain "0 failures"'
-    else
-      step %(the output should contain "#{count_failures} failures")
-    end
-
-    step 'the exit status should be 1'
+Then(/^the spec(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/) \
+  do |count_failures|
+  if count_failures.nil?
+    step 'the output should not contain "0 failures"'
   else
-    step 'the output should contain "0 failures"'
-    step 'the exit status should be 0'
+    step %(the output should contain "#{count_failures} failures")
   end
+
+  step 'the exit status should be 1'
 end
 
 # RSpec
-Then /^the spec(?:s)? should( not)?(?: all)? pass with( regex)?:$/ do |negated, regex, string|
-  if negated
-    step 'the output should not contain "0 failures"'
-    step 'the exit status should be 1'
+Then(/^the spec(?:s)? should all pass$/) do
+  step 'the output should contain "0 failures"'
+  step 'the exit status should be 0'
+end
+
+# RSpec
+Then(/^the spec(?:s)? should not(?: all)? pass with( regex)?:$/) do |regex, string|
+  step 'the output should not contain "0 failures"'
+  step 'the exit status should be 1'
+
+  if regex
+    step "the output should match %r<#{string}>"
   else
-    step 'the output should contain "0 failures"'
-    step 'the exit status should be 0'
+    step 'the output should contain:', string
   end
+end
+
+# RSpec
+Then(/^the spec(?:s)? should(?: all)? pass with( regex)?:$/) do |regex, string|
+  step 'the output should contain "0 failures"'
+  step 'the exit status should be 0'
 
   if regex
     step "the output should match %r<#{string}>"
@@ -62,30 +79,39 @@ Then /^the spec(?:s)? should( not)?(?: all)? pass with( regex)?:$/ do |negated,
 end
 
 # Minitest
-Then /^the tests(?:s)? should( not)?(?: all)? pass(?: with (\d+) failures?)?$/ do |negated, count_failures|
-  if negated
-    if count_failures.nil?
-      step 'the output should not contain "0 errors"'
-    else
-      step %(the output should contain "#{count_failures} errors")
-    end
-
-    step 'the exit status should be 1'
+Then(/^the tests(?:s)? should not(?: all)? pass(?: with (\d+) failures?)?$/) \
+  do |count_failures|
+  if count_failures.nil?
+    step 'the output should not contain "0 errors"'
   else
-    step 'the output should contain "0 errors"'
-    step 'the exit status should be 0'
+    step %(the output should contain "#{count_failures} errors")
   end
+
+  step 'the exit status should be 1'
 end
 
 # Minitest
-Then /^the test(?:s)? should( not)?(?: all)? pass with( regex)?:$/ do |negated, regex, string|
-  if negated
-    step 'the output should contain "0 errors"'
-    step 'the exit status should be 1'
+Then(/^the tests(?:s)? should all pass$/) do
+  step 'the output should contain "0 errors"'
+  step 'the exit status should be 0'
+end
+
+# Minitest
+Then(/^the test(?:s)? should not(?: all)? pass with( regex)?:$/) do |regex, string|
+  step 'the output should contain "0 errors"'
+  step 'the exit status should be 1'
+
+  if regex
+    step "the output should match %r<#{string}>"
   else
-    step 'the output should not contain "0 errors"'
-    step 'the exit status should be 0'
+    step 'the output should contain:', string
   end
+end
+
+# Minitest
+Then(/^the test(?:s)? should(?: all)? pass with( regex)?:$/) do |regex, string|
+  step 'the output should not contain "0 errors"'
+  step 'the exit status should be 0'
 
   if regex
     step "the output should match %r<#{string}>"

data/lib/aruba/event_bus.rb

@@ -33,7 +33,9 @@ module Aruba
     def register(event_ids, handler_object = nil, &handler_proc)
       handler = handler_proc || handler_object
 
-      fail ArgumentError, 'Please pass either an object#call or a handler block' if handler.nil? || !handler.respond_to?(:call)
+      if handler.nil? || !handler.respond_to?(:call)
+        raise ArgumentError, 'Please pass either an object#call or a handler block'
+      end
 
       Array(event_ids).flatten.each do |id|
         @handlers[
@@ -51,7 +53,7 @@ module Aruba
     #   handler.
     #
     def notify(event)
-      fail NoEventError, 'Please pass an event object, not a class' if event.is_a?(Class)
+      raise NoEventError, 'Please pass an event object, not a class' if event.is_a?(Class)
 
       @handlers[event.class.to_s].each { |handler| handler.call(event) }
     end

data/lib/aruba/event_bus/name_resolver.rb

@@ -15,11 +15,11 @@ module Aruba
 
         # Thanks ActiveSupport
         # (Only needed to support Ruby 1.9.3 and JRuby)
-        # rubocop:disable Metrics/CyclomaticComplexity
         def constantize(camel_cased_word)
           names = camel_cased_word.split('::')
 
-          # Trigger a built-in NameError exception including the ill-formed constant in the message.
+          # Trigger a built-in NameError exception including the ill-formed
+          # constant in the message.
           Object.const_get(camel_cased_word) if names.empty?
 
           # Remove the first blank element in case of '::ClassName' notation.
@@ -49,7 +49,6 @@ module Aruba
             end
           end
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
       end
 
       # @private
@@ -120,7 +119,8 @@ module Aruba
       class FailingResolver
         class << self
           def match?(event_id)
-            fail ArgumentError, %(Input type "#{event_id.class}" of event_id "#{event_id}" is invalid)
+            raise ArgumentError,
+                  %(Input type "#{event_id.class}" of event_id "#{event_id}" is invalid)
           end
 
           def supports
@@ -147,10 +147,11 @@ module Aruba
 
       def transform(event_id)
         resolvers.find { |r| r.match? event_id }.new.transform(default_namespace, event_id)
-      rescue => e
-        # rubocop:disable Metrics/LineLength
-        raise EventNameResolveError, %(Transforming "#{event_id}" into an event class failed. Supported types are: #{@resolvers.map(&:supports).flatten.join(', ')}. #{e.message}.\n\n#{e.backtrace.join("\n")})
-        # rubocop:enable Metrics/LineLength
+      rescue StandardError => e
+        types = @resolvers.map(&:supports).flatten.join(', ')
+        message = "Transforming \"#{event_id}\" into an event class failed." \
+          " Supported types are: #{types}. #{e.message}."
+        raise EventNameResolveError, message, cause: e
       end
     end
   end

data/lib/aruba/events.rb

@@ -4,7 +4,8 @@ module Aruba
   module Events
     # Basic event
     #
-    # This is not meant for direct use - BasicEvent.new - by users. It is inherited by normal events
+    # This is not meant for direct use - BasicEvent.new - by users. It is
+    # inherited by normal events
     #
     # @private
     class BasicEvent

data/lib/aruba/hooks.rb

@@ -21,12 +21,10 @@ module Aruba
     # @param [Proc] block
     #   The block which should be run for the hook
     def append(label, block)
-      if store.key?(label.to_sym) && store[label.to_sym].respond_to?(:<<)
-        store[label.to_sym] << block
-      else
+      unless store.key?(label.to_sym) && store[label.to_sym].respond_to?(:<<)
         store[label.to_sym] = []
-        store[label.to_sym] << block
       end
+      store[label.to_sym] << block
     end
 
     # Run hook