aruba 1.0.0.pre.alpha.3 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: edbb16f00c301a3cb9b030dcabe626cd35e3bfebdd8e76efc47ccb78963b632c
-  data.tar.gz: 3cfea7febab3db1a8943a6a25c6724a5fcd51db9916a9426619767b4260479d6
+  metadata.gz: 5f5a2c9af56d4b502edae4592455415530bd8077f5078608ac174fdd42828e84
+  data.tar.gz: e057fc77eb5bf2680b08978f90d3d4bf5c166e3a400a3d691124f5d624e37e67
 SHA512:
-  metadata.gz: 31f78dc5373408128c519af63839ed5e85a0fe4d749fc475b96aa36803ec98b5d04b072c69df39ac7fc25ee47a4189e22a6e6943f3df94d9c2e2de7cd831e177
-  data.tar.gz: e6342327449b14d5a91a96fb5df785e911a451b17d6745c4e7986ad3ea79bd4c36a7c48a10020255e8afb2855ccb1df04277ef44c266223c68b2ebf5f3af8a89
+  metadata.gz: 41edd733387784f50d386c5fd718610a00970c5e2d1cb60cc87dae9e79a8883d2447136782c3e7e101e208b949f7451fe99ac8ebc91ab0547b529f097da04286
+  data.tar.gz: f7c553b8fc220a0e1b49ddcbe92d8d1da179330c05dff80e70dbcac6ed9ef501ff27b2e663afdecaff18a471d718e249e0b3d7b704baafb80603c187045321b2

data/.rspec

@@ -1,4 +1,3 @@
 --color
---format Fuubar
 --order random
 --warnings

data/.rubocop.yml

@@ -1,13 +1,52 @@
+require:
+  - rubocop-performance
+  - rubocop-rspec
+
 AllCops:
   Exclude:
     - tmp/**/*
     - vendor/**/*
   DisplayCopNames: true
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.4
 
 # Use older RuboCop default
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
     '%w': ()
 
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Code is currently broken with frozen string literal comments applied.
+# TODO: Enable and fix build
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Be relatively lenient with line length
+Layout/LineLength:
+  Max: 94
+
+# Enable new cops from RuboCop 0.80, 0.81 and 0.84
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
 inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,71 +1,16 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-05-06 11:32:53 +0200 using RuboCop version 0.66.0.
+# on 2020-05-31 23:12:24 +0200 using RuboCop version 0.84.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 5
-# Configuration parameters: Include.
-# Include: **/*.gemfile, **/Gemfile, **/gems.rb
-Bundler/DuplicatedGem:
-  Exclude:
-    - 'Gemfile'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_parameter, with_fixed_indentation
-Layout/AlignParameters:
-  Exclude:
-    - 'lib/aruba/api/commands.rb'
-    - 'lib/aruba/processes/basic_process.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-Layout/ClosingHeredocIndentation:
-  Exclude:
-    - 'lib/aruba/initializer.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: leading, trailing
-Layout/DotPosition:
-  Exclude:
-    - 'spec/aruba/matchers/collection_spec.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
-  Exclude:
-    - 'lib/aruba/initializer.rb'
-
 # Offense count: 7
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/aruba/platforms/announcer.rb'
 
-# Offense count: 6
-Lint/AmbiguousRegexpLiteral:
-  Exclude:
-    - 'lib/aruba/cucumber/testing_frameworks.rb'
-
-# Offense count: 2
-# Configuration parameters: MaximumRangeSize.
-Lint/MissingCopEnableDirective:
-  Exclude:
-    - 'lib/aruba/configuration.rb'
-    - 'lib/aruba/processes/spawn_process.rb'
-
-# Offense count: 1
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/aruba/platforms/unix_environment_variables.rb'
-
 # Offense count: 2
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
@@ -73,52 +18,58 @@ Lint/Void:
     - 'lib/aruba/platforms/announcer.rb'
     - 'lib/aruba/platforms/unix_environment_variables.rb'
 
-# Offense count: 28
+# Offense count: 26
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 116
 
-# Offense count: 69
+# Offense count: 72
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 585
+  Max: 594
 
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 131
+  Max: 158
 
-# Offense count: 19
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
+Metrics/CyclomaticComplexity:
+  Max: 12
+
+# Offense count: 28
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 18
+  Max: 59
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 167
+  Max: 182
 
 # Offense count: 3
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 8
 
-# Offense count: 4
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 10
+  Max: 13
 
 # Offense count: 1
 Naming/ConstantName:
   Exclude:
     - 'lib/aruba/platform.rb'
 
-# Offense count: 8
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Offense count: 5
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'lib/aruba/initializer.rb'
-    - 'spec/aruba/matchers/command_spec.rb'
 
 # Offense count: 1
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
@@ -127,15 +78,13 @@ Naming/MemoizedInstanceVariableName:
   Exclude:
     - 'lib/aruba/api/core.rb'
 
-# Offense count: 18
+# Offense count: 14
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
   Exclude:
     - 'lib/aruba/aruba_path.rb'
     - 'lib/aruba/config_wrapper.rb'
-    - 'lib/aruba/event_bus/name_resolver.rb'
-    - 'lib/aruba/matchers/base/object_formatter.rb'
     - 'lib/aruba/platforms/announcer.rb'
     - 'lib/aruba/platforms/aruba_logger.rb'
     - 'lib/aruba/platforms/unix_platform.rb'
@@ -146,45 +95,102 @@ Performance/Caller:
   Exclude:
     - 'lib/aruba/platforms/unix_platform.rb'
 
+# Offense count: 51
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/api/runtime_spec.rb'
+    - 'spec/aruba/api_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 10
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/aruba/api/runtime_spec.rb'
+    - 'spec/aruba/jruby_spec.rb'
+    - 'spec/aruba/matchers/collection_spec.rb'
+    - 'spec/aruba/matchers/command/have_output_size_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/directory_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/platform/simple_table_spec.rb'
+    - 'spec/aruba/rspec_spec.rb'
+
+# Offense count: 19
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/aruba/api/core_spec.rb'
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/aruba_path_spec.rb'
+    - 'spec/aruba/matchers/collection_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+    - 'spec/aruba/platforms/command_monitor_spec.rb'
+    - 'spec/event_bus/name_resolver_spec.rb'
+    - 'spec/event_bus_spec.rb'
+
+# Offense count: 298
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/aruba/api/bundler_spec.rb'
+    - 'spec/aruba/api/commands_spec.rb'
+    - 'spec/aruba/api/core_spec.rb'
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/api_spec.rb'
+    - 'spec/aruba/matchers/command/have_output_size_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/directory_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/processes/in_process_spec.rb'
+    - 'spec/event_bus_spec.rb'
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 32
+RSpec/MultipleExpectations:
+  Max: 5
+
+# Offense count: 187
+RSpec/NestedGroups:
+  Max: 6
+
+# Offense count: 1
+RSpec/UnspecifiedException:
+  Exclude:
+    - 'spec/aruba/runtime_spec.rb'
+
 # Offense count: 2
 Security/Open:
   Exclude:
     - 'lib/aruba/processes/spawn_process.rb'
 
-# Offense count: 3
-# Configuration parameters: EnforcedStyle.
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
 # SupportedStyles: inline, group
 Style/AccessModifierDeclarations:
   Exclude:
-    - 'lib/aruba/in_config_wrapper.rb'
-    - 'lib/aruba/matchers/base/base_matcher.rb'
     - 'lib/aruba/matchers/collection/all.rb'
 
 # Offense count: 3
+# Configuration parameters: AllowOnConstant.
 Style/CaseEquality:
   Exclude:
     - 'lib/aruba/matchers/base/object_formatter.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/CharacterLiteral:
-  Exclude:
-    - 'spec/support/shared_contexts/aruba.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: is_a?, kind_of?
-Style/ClassCheck:
-  Exclude:
-    - 'lib/aruba/api/filesystem.rb'
-
-# Offense count: 1
-Style/CommentedKeyword:
-  Exclude:
-    - 'spec/aruba/api_spec.rb'
-
-# Offense count: 13
+# Offense count: 12
 Style/Documentation:
   Exclude:
     - 'spec/**/*'
@@ -193,172 +199,18 @@ Style/Documentation:
     - 'fixtures/cli-app/lib/cli/app/suppress_simple_cov_output.rb'
     - 'fixtures/empty-app/lib/cli/app.rb'
     - 'lib/aruba/api/bundler.rb'
-    - 'lib/aruba/colorizer.rb'
     - 'lib/aruba/matchers/collection/include_an_object.rb'
     - 'lib/aruba/platforms/command_monitor.rb'
     - 'lib/aruba/setup.rb'
     - 'lib/aruba/tasks/docker_helpers.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-Style/Encoding:
-  Exclude:
-    - 'aruba.gemspec'
-    - 'fixtures/cli-app/cli-app.gemspec'
-    - 'fixtures/empty-app/cli-app.gemspec'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-Style/EvalWithLocation:
-  Exclude:
-    - 'spec/support/helpers/reporting.rb'
-
-# Offense count: 16
-# Cop supports --auto-correct.
-Style/ExpandPathArguments:
-  Exclude:
-    - 'Gemfile'
-    - 'Rakefile'
-    - 'bin/console'
-    - 'exe/aruba'
-    - 'features/support/env.rb'
-    - 'features/support/simplecov_setup.rb'
-    - 'fixtures/cli-app/bin/aruba-test-cli'
-    - 'fixtures/cli-app/cli-app.gemspec'
-    - 'fixtures/cli-app/lib/cli/app.rb'
-    - 'fixtures/cli-app/spec/spec_helper.rb'
-    - 'fixtures/empty-app/cli-app.gemspec'
-    - 'fixtures/empty-app/lib/cli/app.rb'
-    - 'fixtures/getting-started-app/Gemfile'
-
-# Offense count: 85
+# Offense count: 83
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
   Enabled: false
 
 # Offense count: 2
-Style/IdenticalConditionalBranches:
-  Exclude:
-    - 'lib/aruba/hooks.rb'
-
-# Offense count: 10
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'Gemfile'
-    - 'features/support/env.rb'
-    - 'lib/aruba/cucumber/command.rb'
-    - 'lib/aruba/matchers/collection/include_an_object.rb'
-    - 'lib/aruba/platforms/unix_environment_variables.rb'
-    - 'lib/aruba/setup.rb'
-    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'spec/aruba/hooks_spec.rb'
-
-# Offense count: 5
 Style/MethodMissingSuper:
   Exclude:
-    - 'lib/aruba/config_wrapper.rb'
-    - 'lib/aruba/in_config_wrapper.rb'
     - 'lib/aruba/platforms/command_monitor.rb'
-    - 'lib/aruba/tasks/docker_helpers.rb'
-
-# Offense count: 3
-Style/MissingRespondToMissing:
-  Exclude:
-    - 'lib/aruba/in_config_wrapper.rb'
-    - 'lib/aruba/platforms/command_monitor.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/aruba/colorizer.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: Whitelist.
-# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
-Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'spec/aruba/matchers/collection_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
-# SupportedStyles: predicate, comparison
-Style/NumericPredicate:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/aruba/contracts/is_power_of_two.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/aruba/api/bundler.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/aruba/cucumber/command.rb'
-    - 'lib/aruba/cucumber/file.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Exclude:
-    - 'lib/aruba/contracts/absolute_path.rb'
-    - 'lib/aruba/contracts/is_power_of_two.rb'
-    - 'lib/aruba/contracts/relative_path.rb'
-    - 'lib/aruba/event_bus/name_resolver.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Exclude:
-    - 'lib/aruba/platforms/aruba_fixed_size_file_creator.rb'
-
-# Offense count: 44
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: only_raise, only_fail, semantic
-Style/SignalException:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/StderrPuts:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/aruba/initializer.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: MinSize.
-# SupportedStyles: percent, brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-
-# Offense count: 411
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 174