arel_extensions 1.3.4 → 2.0.0.rc3

data/Gemfile

@@ -1,24 +1,29 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
+
+gem 'rails', '~> 6.0.0.rc2'
 
-gemspec
 
 group :development, :test do
-  gem 'sqlite3', '<= 1.3.13', platforms: [:mri]
-  gem 'mysql2', '0.4.10', platforms: [:mri]
-  gem 'pg', '< 1', platforms: [:mri]
+  gem 'activesupport', '~> 6.0.0.rc2'
+  gem 'activemodel', '~> 6.0.0.rc2'
+  gem 'activerecord', '~> 6.0.0.rc2'
 
-  gem 'jdbc-sqlite3', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
+  gem "sqlite3", '~> 1.4', :platforms => [:mri, :mswin, :mingw]
+  gem "mysql2", '0.5.2', :platforms => [:mri, :mswin, :mingw]
+  gem "pg",'< 1.0.0', :platforms => [:mri, :mingw]
 
-  gem 'tiny_tds', '~> 2.1', require: false, platforms: [:mri, :mingw, :x64_mingw, :mswin]
-  gem 'activerecord-sqlserver-adapter', '~> 6.0', platforms: [:mri, :mingw, :x64_mingw, :mswin]
+  gem "tiny_tds", :platforms => [:mri, :mingw]  if RUBY_PLATFORM =~ /windows/
+  gem "activerecord-sqlserver-adapter", :platforms => [:mri, :mingw]
 
-  gem 'ruby-oci8', platforms: [:mri, :mswin, :x64_mingw, :mingw]
-  gem 'activerecord-oracle_enhanced-adapter', '~> 1.6.0'
+  gem 'ruby-oci8', :platforms => [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
+  gem 'activerecord-oracle_enhanced-adapter', '~> 6.0.0.rc2' if ENV.has_key? 'ORACLE_HOME'
 
-  gem 'activesupport', '~> 6.0'
-  gem 'activemodel', '~> 6.0'
-  gem 'activerecord', '~> 6.0'
+  # for JRuby
+  gem 'activerecord-jdbc-adapter', :platforms => :jruby
+  gem "jdbc-sqlite3", :platforms => :jruby
+  gem "activerecord-jdbcsqlite3-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmysql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcpostgresql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmssql-adapter", :platforms => :jruby
 end
+

data/README.md

@@ -1,6 +1,7 @@
 # Arel Extensions
 
-![GitHub workflow](https://github.com/Faveod/arel-extensions/actions/workflows/ruby.yml/badge.svg)
+[![Travis Build Status](https://img.shields.io/travis/Faveod/arel-extensions.svg?label=Travis%20build)](http://travis-ci.org/Faveod/arel-extensions)
+[![AppVeyor Build Status](https://img.shields.io/appveyor/ci/yazfav/arel-extensions.svg?label=AppVeyor%20build)](https://ci.appveyor.com/project/yazfav/arel-extensions)
 [![Security](https://hakiri.io/github/Faveod/arel-extensions/master.svg)](https://hakiri.io/github/Faveod/arel-extensions/master)
 ![](http://img.shields.io/badge/license-MIT-brightgreen.svg)
 
@@ -18,11 +19,6 @@ It allows to use more advanced SQL functions for any supported RDBMS.
 Arel 6 (Rails 4) or Arel 7+ (Rails 5).
 [Arel Repository](http://github.com/rails/arel)
 
-or
-
-Rails 6
-[Rails Repository](http://github.com/rails/rails)
-
 ## Usage
 
 Most of the features will work just by adding the gem to your Gemfiles. To make sure to get all the features for any dbms, you should execute the next line as soon as you get your connection to your DB:
@@ -76,9 +72,9 @@ With Arel Extensions:
 Other functions : ABS, RAND, ROUND, FLOOR, CEIL, FORMAT
 
 For Example:
-```ruby
+```ruby 
 t[:price].format_number("%07.2f €","fr_FR")
-# equivalent to 'sprintf("%07.2f €",price)' plus locale management
+# equivalent to 'sprintf("%07.2f €",price)' plus locale management 
 ```
 
 ## String operations
@@ -129,77 +125,12 @@ t[:birthdate].month.to_sql
 
 t[:birthdate].year.to_sql
 # => YEAR(my_table.birthdate)
-```
-
-### Datetime
-
-```ruby
-# datetime difference
-t[:birthdate] - Time.utc(2014, 3, 3, 12, 41, 18)
-
-# comparison
-t[:birthdate] >= '2014-03-03 10:10:10'
-```
-
-### Format and Time Zone Conversion
-
-`format` has two forms:
 
-```ruby
 t[:birthdate].format('%Y-%m-%d').to_sql
 # => DATE_FORMAT(my_table.birthdate, '%Y-%m-%d')
 ```
 
-Which formats the datetime without any time zone conversion.
-The second form accepts 2 kinds of values:
-
-1. String:
-
-```ruby
-t[:birthdate].format('%Y/%m/%d %H:%M:%S', 'posix/Pacific/Tahiti')
-# => DATE_FORMAT(CONVERT_TZ(CAST(my_table.birthdate AS datetime), 'UTC', 'posix/Pacific/Tahiti'), '%Y/%m/%d %H:%i:%S')          ## MySQL
-# => TO_CHAR(CAST(my_table.birthdate AS timestamp with time zone) AT TIME ZONE 'posix/Pacific/Tahiti', 'YYYY/MM/DD HH24:MI:SS') ## PostgreSQL
-# => CONVERT(datetime, my_table.birthdate) AT TIME ZONE 'UTC' AT TIME ZONE N'posix/Pacific/Tahiti'                              ## SQL Server (& truncated for clarity)
-#                                                                            ^^^^^^^^^^^^^^^^^^^^ 🚨 Invalid timezone for SQL Server. Explanation below.
-```
-
-which will convert the datetime field to the supplied time zone. This generally
-means that you're letting the RDBMS decide or infer what is the timezone of the
-column before conversion to the supplied timezone.
-
-1. Hash of the form `{ src_time_zone => dst_time_zone }`:
-
-```ruby
-t[:birthdate].format('%Y/%m/%d %H:%M:%S', { 'posix/Europe/Paris' => 'posix/Pacific/Tahiti' })
-```
-
-which will explicitly indicate the original timestamp that should be considered
-by the RDBMS.
-
-Warning:
-
-- ⚠️ Time Zone names are specific to each RDBMS. While `PostgreSQL` and `MySQL`
-  have overlaping names (the ones prefixed with `posix`), you should always
-  read your vendor's documentation. `SQL Server` is a black sheep and has its
-  own conventions.
-- ⚠️ Daylight saving is managed by the RDBMS vendor. Choose the approptiate time
-  zone name that enforces proper daylight saving conversions.
-  - ☣️ Choosing `GMT+offset` will certainly bypass daylight saving computations.
-  - ☣️ Choosing abbreviate forms like `CET`, which stands for `Central European
-    Time` will behave differently on `PostgreSQL` and `MySQL`. Don't assume
-    uniform behavior, or even a _rational_ one.
-- ⚠️ Pay attention to the type of the `datetime` column you're working with. For
-  example, in Postgres, a `datetime` can be one of the following types:
-  1. `timestamp with time zone`
-  2. `timestamp without time zone`
-  In the first case, you don't need to supply a conversion hash because postgres
-  knows how to convert it to the desired time zone. However, if you do the same
-  for the second case, you might get surprises, especially if your Postgres
-  installation's default timezone is not `UTC`.
-- ⚠️ SQLite is not supported.
-- 🚨 Always test against your setup 🚨
-
-## Unions
+## Unions 
 
 ```ruby
 (t.where(t[:name].eq('str')) + t.where(t[:name].eq('test'))).to_sql
@@ -212,7 +143,7 @@ Arel-extensions allows to use functions on case clause
 
 ```ruby
 t[:name].when("smith").then(1).when("doe").then(2).else(0).sum.to_sql
-# => SUM(CASE "my_table"."name" WHEN 'smith' THEN 1 WHEN 'doe' THEN 2 ELSE 0 END)
+# => SUM(CASE "my_table"."name" WHEN 'smith' THEN 1 WHEN 'doe' THEN 2 ELSE 0 END) 
 ```
 
 ## Cast Function
@@ -229,7 +160,7 @@ t[:id].cast('char').to_sql
 
 To optimize queries, some classical functions are defined in databases missing any alternative native functions.
 Examples :
-- FIND_IN_SET
+- FIND_IN_SET 
 
 ## BULK INSERT / UPSERT
 
@@ -278,7 +209,7 @@ User.connection.execute(insert_manager.to_sql)
     <td class="tg-yw4l">CEIL<br>column.ceil</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
-    <td class="tg-j6lv">CASE + CAST</td>
+    <td class="tg-j6lv">CASE + ROUND</td>
     <td class="ok">✔</td>
     <td class="tg-j6lv">CEILING()</td>
     <td class="tg-j6lv">CEILING()</td>
@@ -287,7 +218,7 @@ User.connection.execute(insert_manager.to_sql)
     <td class="tg-yw4l">FLOOR<br>column.floor</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
-    <td class="tg-j6lv">CASE + CAST</td>
+    <td class="tg-j6lv">CASE + ROUND</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
@@ -454,7 +385,7 @@ User.connection.execute(insert_manager.to_sql)
     <td class="ok">✔</td>
     <td class="tg-j6lv">✔</td>
     <td class="tg-j6lv">?</td>
-  </tr>
+  </tr>  
   <tr>
     <td class="tg-yw4l">Matching Accent Insensitive<br>column.ai_matches('blah')</td>
     <td class="ok">not supported</td>
@@ -463,7 +394,7 @@ User.connection.execute(insert_manager.to_sql)
     <td class="ok">not supported</td>
     <td class="tg-j6lv">✔</td>
     <td class="tg-j6lv">?</td>
-  </tr>
+  </tr>  
   <tr>
     <td class="tg-yw4l">Matching Case Insensitive<br>column.imatches('blah')</td>
     <td class="ok">not supported</td>
@@ -472,7 +403,7 @@ User.connection.execute(insert_manager.to_sql)
     <td class="ok">✔</td>
     <td class="tg-j6lv">✔</td>
     <td class="tg-j6lv">?</td>
-  </tr>
+  </tr>  
   <tr>
     <td class="tg-yw4l">Matching Accent/Case Sensitive<br>column.smatches('blah')</td>
     <td class="ok">✔</td>
@@ -481,8 +412,8 @@ User.connection.execute(insert_manager.to_sql)
     <td class="ok">✔</td>
     <td class="tg-j6lv">✔</td>
     <td class="tg-j6lv">?</td>
-  </tr>
-
+  </tr>  
+    
   <tr>
     <th class="tg-4rp9" rowspan="6"><div>Date functions</div></th>
     <td class="tg-yw4l">DATEADD<br>column + 2.year<br></td>
@@ -660,45 +591,3 @@ User.connection.execute(insert_manager.to_sql)
   </tr>
   </tbody>
 </table>
-
-## Version Compatibility
-
-<table>
-  <tr><th>Ruby</th> <th>Rails</th>    <th>Arel Extensions</th></tr>
-  <tr><td>3.1</td>  <td>6.1</td>      <td>2</td></tr>
-  <tr><td>3.0</td>  <td>6.1</td>      <td>2</td></tr>
-  <tr><td>2.7</td>  <td>6.1, 6.0</td> <td>2</td></tr>
-  <tr><td>2.5</td>  <td>6.1, 6.0</td> <td>2</td></tr>
-  <tr><td>2.5</td>  <td>5.2</td>      <td>1</td></tr>
-</table>
-
-## Development
-
-Let's say you want to develop/test for `ruby 2.7.5` and `rails 5.2`.
-
-You will need to fix your ruby version:
-
-```bash
-rbenv install 2.7.5
-rbenv local 2.7.5
-```
-
-Fix your gemfiles:
-
-```bash
-bundle config set --local gemfile ./gemfiles/rails6.gemfile
-```
-
-Install dependencies:
-```bash
-bundle install
-```
-
-Develop, then test:
-
-```bash
-bundle exec rake test:to_sql
-```
-
-Refer to the [Version Compatibility](#version-compatibility) section to correctly
-set your gemfile.

data/Rakefile

@@ -1,50 +1,39 @@
 require 'bundler'
-Bundler::GemHelper.install_tasks name: 'arel_extensions'
+Bundler::GemHelper.install_tasks :name => "arel_extensions"
 
 require 'rake/testtask'
 
-desc 'Default Task'
-task default: [:test]
+desc "Default Task"
+task default: [ :test ]
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/test_*.rb'
-  t.warning = true
-  t.verbose = true
+ 	t.libs << 'lib'
+  	t.libs << 'test'
+  	t.pattern = 'test/**/test_*.rb'
+	t.warning = true
+  	t.verbose = true
 end
 
-namespace :test do
-  Rake::TestTask.new('to_sql' => []) { |t|
-    t.libs << 'lib'
-    t.libs << 'test'
-    t.pattern = 'test/visitors/test_to_sql.rb'
-    t.warning = true
-    t.verbose = true
-    t.ruby_opts = ['--dev'] if defined?(JRUBY_VERSION)
-  }
-end
-
-%w[mysql postgresql sqlite ibm_db oracle mssql].each do |adapter|
-  namespace :test do
-    Rake::TestTask.new(adapter => "#{adapter}:env") { |t|
-      t.libs << 'lib'
-      t.libs << 'test'
-      t.pattern = 'test/with_ar/*_agnostic_test.rb'
-      t.warning = false
-      t.verbose = true
-      t.ruby_opts = ['--dev'] if defined?(JRUBY_VERSION)
-    }
-  end
-
-  namespace adapter do
-    task test: "test_#{adapter}"
-    task isolated_test: "isolated_test_#{adapter}"
-
-    # Set the connection environment for the adapter
-    task(:env) { ENV['DB'] = adapter }
-  end
-
-  # Make sure the adapter test evaluates the env setting task
-  task "test_#{adapter}" => ["#{adapter}:env", "test:#{adapter}"]
+%w(mysql postgresql sqlite ibm_db oracle mssql).each do |adapter|
+	namespace :test do
+		Rake::TestTask.new(adapter => "#{adapter}:env") { |t|
+			t.libs << 'lib'
+		  	t.libs << 'test'
+		  	t.pattern = 'test/with_ar/*_agnostic_test.rb'
+		  	t.warning = true
+		  	t.verbose = true
+		  	t.ruby_opts = ["--dev"] if defined?(JRUBY_VERSION)
+		}
+	end
+
+	namespace adapter do
+	    task :test => "test_#{adapter}"
+	    task :isolated_test => "isolated_test_#{adapter}"
+
+	    # Set the connection environment for the adapter
+	    task(:env) { ENV['DB'] = adapter }
+	end
+
+	  # Make sure the adapter test evaluates the env setting task
+	task "test_#{adapter}" => ["#{adapter}:env", "test:#{adapter}"]
 end

data/TODO

@@ -1,6 +1,7 @@
 Code quality:
 + codeclimate.com
 + gemnasium
++ appveyor.com (windows)
 + hakiri.io
 - coveralls.io
 - inch-ci.org

data/appveyor.yml

@@ -0,0 +1,44 @@
+version: "{build}"
+
+cache:
+  - vendor/bundle
+
+branches:
+  only:
+    - master
+
+services:
+  - mssql2014
+
+
+install:
+  - set PATH=C:\Ruby%RUBY_VERSION%\bin;%PATH%
+  - bundle config --local path vendor/bundle
+  - bundle install
+
+# Disable normal Windows builds in favor of our test script.
+build: off
+
+
+before_test:
+  - ruby -v
+  - gem -v
+  - bundle -v
+
+test_script:
+  - ruby --version
+  - gem --version
+  - bundler --version
+  - bundle exec rake test
+  - ps: Start-Service 'MSSQL$SQL2014'
+  - timeout /t 4 /nobreak > NUL
+  - bundle exec rake test:mssql
+
+environment:
+  matrix:
+    - RUBY_VERSION: 200
+    - RUBY_VERSION: 21
+    - RUBY_VERSION: 22
+    - RUBY_VERSION: 23
+    - RUBY_VERSION: 23-x64
+    

data/arel_extensions.gemspec

@@ -1,28 +1,28 @@
-$:.push File.expand_path('../lib', __FILE__)
-require 'arel_extensions/version'
+$:.push File.expand_path("../lib", __FILE__)
+require "arel_extensions/version"
 
 Gem::Specification.new do |s|
-  s.name        = 'arel_extensions'
+  s.name        = "arel_extensions"
   s.version     = ArelExtensions::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ['Yann Azoury', 'Félix Bellanger', 'Julien Delporte']
-  s.email       = ['yann.azoury@faveod.com', 'felix.bellanger@faveod.com', 'julien.delporte@faveod.com']
-  s.homepage    = 'https://github.com/Faveod/arel-extensions'
-  s.description = 'Adds new features to Arel'
-  s.summary     = 'Extending Arel'
+  s.authors     = ["Yann Azoury", "Félix Bellanger", "Julien Delporte"]
+  s.email       = ["yann.azoury@faveod.com", "felix.bellanger@faveod.com", "julien.delporte@faveod.com"]
+  s.homepage    = "https://github.com/Faveod/arel-extensions"
+  s.description = "Adds new features to Arel"
+  s.summary     = "Extending Arel"
   s.license     = 'MIT'
 
-  s.rdoc_options = ['--main', 'README.md']
-  s.extra_rdoc_files = ['MIT-LICENSE.txt', 'README.md', 'functions.html']
+  s.rdoc_options = ["--main", "README.md"]
+  s.extra_rdoc_files = ["MIT-LICENSE.txt", "README.md", 'functions.html']
 
   # Manifest
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.require_paths = ['lib']
+  s.require_paths = ["lib"]
 
-  s.add_dependency('arel', '>= 6.0')
+  s.add_dependency('activerecord', '>= 6.0.0.rc2')
 
   s.add_development_dependency('minitest', '~> 5.9')
-  s.add_development_dependency('rdoc', '>= 6.3.1')
-  s.add_development_dependency('rake', '~> 12.3.3')
+  s.add_development_dependency('rdoc', '~> 4.0')
+  s.add_development_dependency('rake', '~> 11')
 end

data/functions.html

@@ -55,7 +55,7 @@
     <td class="tg-yw4l">CEIL<br>column.ceil</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
-    <td class="tg-j6lv">CASE + CAST</td>
+    <td class="tg-j6lv">CASE + ROUND</td>
     <td class="ok">✔</td>
     <td class="tg-j6lv">CEILING()</td>
     <td class="tg-j6lv">CEILING()</td>
@@ -64,7 +64,7 @@
     <td class="tg-yw4l">FLOOR<br>column.floor</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
-    <td class="tg-j6lv">CASE + CAST</td>
+    <td class="tg-j6lv">CASE + ROUND</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
@@ -379,7 +379,7 @@
     <td class="ok">✔</td>
     <td class="ok">✔</td>
     <td class="ok">✔</td>
-  </tr>
+  </tr> 
   <tr>
     <th class="bulk_insert" rowspan="1"><div>Set<br/> Operators</div></th>
     <td class="tg-yw4l">UNION ( + )<br/>query + query</td>

data/gemfiles/rails3.gemfile

@@ -1,20 +1,20 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gem 'arel', '~> 3.0' # too old...
 
 group :development, :test do
-  gem 'sqlite3', '<= 1.3.13', platform: [:ruby, :mswin, :mingw]
-  gem 'mysql2', '0.4.10', platform: [:ruby, :mswin, :mingw]
-  gem 'activerecord-mysql2-adapter', platform: [:ruby, :mswin, :mingw]
-  gem 'pg', platform: [:ruby, :mswin, :mingw]
+  gem "sqlite3", '<= 1.3.13', :platform => [:ruby, :mswin, :mingw]
+  gem "mysql2", '0.4.10', :platform => [:ruby, :mswin, :mingw]
+  gem "activerecord-mysql2-adapter", :platform => [:ruby, :mswin, :mingw]
+  gem "pg", :platform => [:ruby, :mswin, :mingw]
   # for JRuby
-  gem 'jdbc-sqlite3', platform: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
-  gem 'activerecord-jdbcmysql-adapter', platform: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platform: :jruby
+  gem "jdbc-sqlite3", :platform => :jruby
+  gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby
+  gem "activerecord-jdbcmysql-adapter", :platform => :jruby
+  gem "activerecord-jdbcpostgresql-adapter", :platform => :jruby
   gem 'activesupport', '~> 3.2'
   gem 'activemodel', '~> 3.2'
   gem 'activerecord', '~> 3.2'
 end
 
-gemspec path: '../'
+gemspec :path => "../"

data/gemfiles/rails4.gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gem 'arel', '~> 6.0'
 
@@ -7,23 +7,23 @@ group :development, :test do
   gem 'activemodel', '~> 4.0'
   gem 'activerecord', '~> 4.0'
 
-  gem 'sqlite3', '<= 1.3.13', platforms: [:mri, :mswin, :mingw]
-  gem 'mysql2', '0.4.10', platforms: [:mri, :mswin, :mingw]
-  gem 'pg', '< 1.0.0', platforms: [:mri, :mingw]
+  gem "sqlite3", '<= 1.3.13', :platforms => [:mri, :mswin, :mingw]
+  gem "mysql2", '0.4.10', :platforms => [:mri, :mswin, :mingw]
+  gem "pg",'< 1.0.0', :platforms => [:mri, :mingw]
 
-  gem 'tiny_tds', platforms: [:mri, :mingw, :mswin] if RUBY_PLATFORM =~ /windows/
-  gem 'activerecord-sqlserver-adapter', '~> 4.2.0', platforms: [:mri, :mingw, :mswin] if RUBY_PLATFORM =~ /windows/
+  gem "tiny_tds", :platforms => [:mri, :mingw, :mswin] if RUBY_PLATFORM =~ /windows/
+  gem "activerecord-sqlserver-adapter", '~> 4.2.0', :platforms => [:mri, :mingw, :mswin] if RUBY_PLATFORM =~ /windows/
 
-  gem 'ruby-oci8', platforms: [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
+  gem 'ruby-oci8', :platforms => [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
   gem 'activerecord-oracle_enhanced-adapter', '~> 1.6.0' if ENV.has_key? 'ORACLE_HOME'
 
   # for JRuby
-  gem 'activerecord-jdbc-adapter', '~> 1.3', platforms: :jruby
-  gem 'jdbc-sqlite3', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcmssql-adapter', platforms: :jruby
+  gem 'activerecord-jdbc-adapter', :platforms => :jruby
+  gem "jdbc-sqlite3", :platforms => :jruby
+  gem "activerecord-jdbcsqlite3-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmysql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcpostgresql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmssql-adapter", :platforms => :jruby
 end
 
-gemspec path: '../'
+gemspec :path => "../"

data/gemfiles/rails5_0.gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gem 'arel', '~> 7.0'
 
@@ -7,23 +7,23 @@ group :development, :test do
   gem 'activemodel', '~> 5.0'
   gem 'activerecord', '5.0.6'
 
-  gem 'sqlite3', '<= 1.3.13', platforms: [:mri, :mswin, :mingw]
-  gem 'mysql2', '0.4.10', platforms: [:mri, :mswin, :mingw]
-  gem 'pg', '< 1.0.0', platforms: [:mri, :mingw]
+  gem "sqlite3", '<= 1.3.13', :platforms => [:mri, :mswin, :mingw]
+  gem "mysql2", '0.4.10', :platforms => [:mri, :mswin, :mingw]
+  gem "pg",'< 1.0.0', :platforms => [:mri, :mingw]
 
-  gem 'tiny_tds', platforms: [:mri, :mingw] if RUBY_PLATFORM =~ /windows/
-  # gem "activerecord-sqlserver-adapter", platforms: [:mri, :mingw]
+  gem "tiny_tds", :platforms => [:mri, :mingw] if RUBY_PLATFORM =~ /windows/
+  #gem "activerecord-sqlserver-adapter", :platforms => [:mri, :mingw]
 
-  gem 'ruby-oci8', platforms: [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
+  gem 'ruby-oci8', :platforms => [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
   gem 'activerecord-oracle_enhanced-adapter', '~> 1.7' if ENV.has_key? 'ORACLE_HOME'
 
   # for JRuby
-  gem 'activerecord-jdbc-adapter', github: 'jruby/activerecord-jdbc-adapter', tag: 'v50.0', platforms: :jruby
-  gem 'jdbc-sqlite3', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcmssql-adapter', platforms: :jruby
+  gem 'activerecord-jdbc-adapter', :github => 'jruby/activerecord-jdbc-adapter', :tag => 'v50.0', :platforms => :jruby
+  gem "jdbc-sqlite3", :platforms => :jruby
+  gem "activerecord-jdbcsqlite3-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmysql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcpostgresql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmssql-adapter", :platforms => :jruby
 end
 
-gemspec path: '../'
+gemspec :path => "../"

data/gemfiles/rails5_1_4.gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gem 'rails', '5.1.4'
 gem 'arel', '~> 8'
@@ -8,23 +8,23 @@ group :development, :test do
   gem 'activemodel', '5.1.4'
   gem 'activerecord', '5.1.4'
 
-  gem 'sqlite3', '<= 1.3.13', platforms: [:mri, :mswin, :mingw]
-  gem 'mysql2', '0.4.10', platforms: [:mri, :mswin, :mingw]
-  gem 'pg', '< 1.0.0', platforms: [:mri, :mingw]
+  gem "sqlite3", '<= 1.3.13', :platforms => [:mri, :mswin, :mingw]
+  gem "mysql2", '0.4.10', :platforms => [:mri, :mswin, :mingw]
+  gem "pg",'< 1.0.0', :platforms => [:mri, :mingw]
 
-  gem 'tiny_tds', platforms: [:mri, :mingw]  if RUBY_PLATFORM =~ /windows/
-  # gem "activerecord-sqlserver-adapter", platforms: [:mri, :mingw]
+  gem "tiny_tds", :platforms => [:mri, :mingw]  if RUBY_PLATFORM =~ /windows/
+  #gem "activerecord-sqlserver-adapter", :platforms => [:mri, :mingw]
 
-  gem 'ruby-oci8', platforms: [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
+  gem 'ruby-oci8', :platforms => [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
   gem 'activerecord-oracle_enhanced-adapter', '~> 1.8' if ENV.has_key? 'ORACLE_HOME'
 
   # for JRuby
-  gem 'activerecord-jdbc-adapter', github: 'jruby/activerecord-jdbc-adapter', tag: 'v51.0', platforms: :jruby
-  gem 'jdbc-sqlite3', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcmssql-adapter', platforms: :jruby
+  gem 'activerecord-jdbc-adapter', :github => 'jruby/activerecord-jdbc-adapter', :tag => 'v51.0', :platforms => :jruby
+  gem "jdbc-sqlite3", :platforms => :jruby
+  gem "activerecord-jdbcsqlite3-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmysql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcpostgresql-adapter", :platforms => :jruby
+  gem "activerecord-jdbcmssql-adapter", :platforms => :jruby
 end
 
-gemspec path: '../'
+gemspec :path => "../"