arel_extensions 1.3.4 → 2.0.0.rc3

data/lib/arel_extensions/visitors/oracle12.rb

@@ -1,7 +1,19 @@
 module ArelExtensions
   module Visitors
-    Arel::Visitors.send(:remove_const, 'Oracle12') if Arel::Visitors.const_defined?('Oracle12')
-    Arel::Visitors.const_set('Oracle12', Class.new(Arel::Visitors::Oracle)).class_eval do
+
+    Arel::Visitors.send(:remove_const,'Oracle12') if Arel::Visitors.const_defined?('Oracle12')
+    Arel::Visitors.const_set('Oracle12',Class.new(Arel::Visitors::Oracle)).class_eval do
+      def visit_Arel_Nodes_SelectStatement(o, collector)
+        # Oracle does not allow LIMIT clause with select for update
+        if o.limit && o.lock
+          raise ArgumentError, <<-MSG
+          'Combination of limit and lock is not supported.
+          because generated SQL statements
+          `SELECT FOR UPDATE and FETCH FIRST n ROWS` generates ORA-02014.`
+          MSG
+        end
+        super
+      end
 
       def visit_Arel_Nodes_SelectOptions(o, collector)
         collector = maybe_visit o.offset, collector
@@ -10,21 +22,21 @@ module ArelExtensions
       end
 
       def visit_Arel_Nodes_Limit(o, collector)
-        collector << 'FETCH FIRST '
+        collector << "FETCH FIRST "
         collector = visit o.expr, collector
-        collector << ' ROWS ONLY'
+        collector << " ROWS ONLY"
       end
 
       def visit_Arel_Nodes_Offset(o, collector)
-        collector << 'OFFSET '
+        collector << "OFFSET "
         visit o.expr, collector
-        collector << ' ROWS'
+        collector << " ROWS"
       end
 
       def visit_Arel_Nodes_Except(o, collector)
-        collector << '( '
-        collector = infix_value o, collector, ' MINUS '
-        collector << ' )'
+        collector << "( "
+        collector = infix_value o, collector, " MINUS "
+        collector << " )"
       end
 
       def visit_Arel_Nodes_UpdateStatement(o, collector)
@@ -43,25 +55,25 @@ module ArelExtensions
       end
 
       def is_distinct_from(o, collector)
-        collector << 'DECODE('
+        collector << "DECODE("
         collector = visit [o.left, o.right, 0, 1], collector
-        collector << ')'
+        collector << ")"
       end
 
-      def visit_ArelExtensions_Nodes_Json o, collector
+      def visit_ArelExtensions_Nodes_Json o,collector
         case o.dict
         when Array
           collector << 'json_array('
-          o.dict.each.with_index do |v, i|
+          o.dict.each.with_index do |v,i|
             if i != 0
               collector << Arel::Visitors::MySQL::COMMA
             end
-            collector = visit v, collector
+            collector  = visit v, collector
           end
           collector << ')'
         when Hash
           collector << 'json__object('
-          o.dict.each.with_index do |(k, v), i|
+          o.dict.each.with_index do |(k,v),i|
             if i != 0
               collector << Arel::Visitors::MySQL::COMMA
             end
@@ -72,11 +84,11 @@ module ArelExtensions
             collector << 'FORMAT JSON'
           end
           collector << ')'
-        when String, Numeric, TrueClass, FalseClass
-          collector = visit Arel.quoted("#{o.dict}"), collector
+        when String,Numeric,TrueClass,FalseClass
+          collector = visit Arel::Nodes.build_quoted("#{o.dict}"), collector
           collector << ' FORMAT JSON'
         when NilClass
-          collector << %Q['null' FORMAT JSON]
+          collector  << %Q['null' FORMAT JSON]
         when Arel::Attributes::Attribute
           collector = visit o.dict.cast('JSON'), collector
         else
@@ -85,6 +97,7 @@ module ArelExtensions
         end
         collector
       end
+
     end
   end
 end