arel_extensions 1.2.25 → 2.0.0.rc3

data/lib/arel_extensions/math.rb

@@ -11,9 +11,9 @@ require 'arel_extensions/nodes/union_all'
 
 module ArelExtensions
   module Math
-    # function + between
-    # String and others (convert in string)  allows you to concatenate 2 or more strings together.
-    # Date and integer adds or subtracts a specified time interval from a date.
+    #function + between
+    #String and others (convert in string)  allows you to concatenate 2 or more strings together.
+    #Date and integer adds or subtracts a specified time interval from a date.
     def +(other)
       case self
         when Arel::Nodes::Quoted
@@ -24,7 +24,7 @@ module ArelExtensions
           else
             return Arel::Nodes::Grouping.new(Arel::Nodes::Addition.new self, other)
           end
-        when ArelExtensions::Nodes::Function,ArelExtensions::Nodes::Case
+        when  ArelExtensions::Nodes::Function,ArelExtensions::Nodes::Case
           return case self.return_type
         when :string, :text
           self.concat(other)
@@ -35,7 +35,7 @@ module ArelExtensions
         else
           self.concat(other)
         end
-      when Arel::Nodes::Function
+      when  Arel::Nodes::Function
         Arel::Nodes::Grouping.new(Arel::Nodes::Addition.new self, other)
       else
         begin
@@ -43,7 +43,7 @@ module ArelExtensions
         rescue Exception
           col = nil
         end
-        if (!col) # if the column doesn't exist in the database
+        if (!col) #if the column doesn't exist in the database
           Arel::Nodes::Grouping.new(Arel::Nodes::Addition.new(self, other))
         else
           arg = col.type
@@ -62,8 +62,8 @@ module ArelExtensions
       end
     end
 
-    # function returns the time between two dates
-    # function returns the substraction between two ints
+    #function returns the time between two dates
+    #function returns the substraction between two ints
     def -(other)
       case self
       when Arel::Nodes::Grouping
@@ -91,7 +91,7 @@ module ArelExtensions
         rescue Exception
           col = nil
         end
-        if (!col) # if the column doesn't exist in the database
+        if (!col) #if the column doesn't exist in the database
           Arel::Nodes::Grouping.new(Arel::Nodes::Subtraction.new(self, other))
         else
           arg = col.type
@@ -103,7 +103,7 @@ module ArelExtensions
               rescue Exception
                 col2 = nil
               end
-              if (!col2) # if the column doesn't exist in the database
+              if (!col2) #if the column doesn't exist in the database
                 ArelExtensions::Nodes::DateSub.new [self, other]
               else
                 arg2 = col2.type
@@ -115,7 +115,7 @@ module ArelExtensions
               end
             when Arel::Nodes::Node, DateTime, Time, String, Date
               ArelExtensions::Nodes::DateDiff.new [self, other]
-            when ArelExtensions::Nodes::Duration, Integer
+            when  ArelExtensions::Nodes::Duration, Integer
               ArelExtensions::Nodes::DateSub.new [self, other]
             else # ActiveSupport::Duration
               ArelExtensions::Nodes::DateAdd.new [self, -other]
@@ -133,5 +133,6 @@ module ArelExtensions
         end
       end
     end
+
   end
 end

data/lib/arel_extensions/math_functions.rb

@@ -7,10 +7,10 @@ require 'arel_extensions/nodes/formatted_number'
 require 'arel_extensions/nodes/log10'
 require 'arel_extensions/nodes/power'
 require 'arel_extensions/nodes/std'
-require 'arel_extensions/nodes/sum'
 
 module ArelExtensions
   module MathFunctions
+
     # Arel does not handle Decimal literal properly
     def * other
       case other
@@ -46,7 +46,7 @@ module ArelExtensions
         ArelExtensions::Nodes::Floor.new [self]
     end
 
-    # function gives the base 10 log
+     # function gives the base 10 log
     def log10
         ArelExtensions::Nodes::Log10.new [self]
     end
@@ -62,29 +62,21 @@ module ArelExtensions
     end
 
     # Aggregate Functions
-    def std opts = {unbiased: true}
-      ArelExtensions::Nodes::Std.new self, **opts
-    end
-
-    def variance opts = {unbiased: true}
-      ArelExtensions::Nodes::Variance.new self, **opts
+    def std unbiased = true
+      ArelExtensions::Nodes::Std.new [self,unbiased]
     end
 
-    def sum opts = {unbiased: true}
-      if Gem::Version.new(Arel::VERSION) >= Gem::Version.new("9.0.0")
-        Arel::Nodes::Sum.new [self]
-      else
-        ArelExtensions::Nodes::Sum.new self, **opts
-      end
+    def variance unbiased = true
+      ArelExtensions::Nodes::Variance.new [self,unbiased]
     end
 
-    # function that can be invoked to produce random numbers between 0 and 1
-    #    def rand seed = nil
-    #        ArelExtensions::Nodes::Rand.new [seed]
-    #    end
-    alias_method(:random, :rand) rescue nil
+    #function that can be invoked to produce random numbers between 0 and 1
+#    def rand seed = nil
+#        ArelExtensions::Nodes::Rand.new [seed]
+#    end
+    alias_method :random, :rand
 
-    # function is used to round a numeric field to the number of decimals specified
+    #function is used to round a numeric field to the number of decimals specified
     def round precision = nil
         if precision
             ArelExtensions::Nodes::Round.new [self, precision]
@@ -94,19 +86,19 @@ module ArelExtensions
     end
 
     # function returning a number at a specific format
-    def format_number format_string, locale = nil
+    def format_number format_string, locale=nil
       begin
         sprintf(format_string,0) # this line is to get the right error message if the format_string is not correct
         m = /^(.*)%([ #+\-0]*)([1-9][0-9]+|[1-9]?)[.]?([0-9]*)([a-zA-Z])(.*)$/.match(format_string)
         opts = {
-          prefix: m[1],
-          flags: m[2].split(//).uniq.join,
-          width: m[3].to_i,
-          precision: m[4] != '' ? m[4].to_i : 6,
-          type: m[5],
-          suffix: m[6],
-          locale: locale,
-          original_string: format_string
+          :prefix     => m[1],
+          :flags      => m[2].split(//).uniq.join,
+          :width      => m[3].to_i,
+          :precision  => m[4] != '' ? m[4].to_i : 6,
+          :type       => m[5],
+          :suffix     => m[6],
+          :locale    => locale,
+          :original_string => format_string
         }
         # opts = {:locale => 'fr_FR', :type => "e"/"f"/"d", :prefix => "$ ", :suffix => " %", :flags => " +-#0", :width => 5, :precision => 6}
         ArelExtensions::Nodes::FormattedNumber.new [self,opts]
@@ -114,5 +106,6 @@ module ArelExtensions
         Arel::Nodes.build_quoted('Wrong Format')
       end
     end
+
   end
 end

data/lib/arel_extensions/nodes/abs.rb

@@ -2,6 +2,7 @@ module ArelExtensions
   module Nodes
     class Abs < Function
       RETURN_TYPE = :number
+
     end
   end
 end

data/lib/arel_extensions/nodes/blank.rb

@@ -19,5 +19,6 @@ module ArelExtensions
           super expr.first
       end
     end
+
   end
 end

data/lib/arel_extensions/nodes/case.rb

@@ -1,11 +1,7 @@
 module ArelExtensions
   module Nodes
-    if Gem::Version.new(Arel::VERSION) < Gem::Version.new("7.1.0")
+    if Arel::VERSION < "7.1.0"
       class Case < Arel::Nodes::Node
-        include Arel::Expressions
-        include Arel::Math
-        include Arel::Predications
-        include Arel::OrderPredications
         attr_accessor :case, :conditions, :default
 
         def initialize expression = nil, default = nil
@@ -19,6 +15,7 @@ module ArelExtensions
 
         class Else < Arel::Nodes::Unary # :nodoc:
         end
+
       end
     else
       class Case < Arel::Nodes::Case
@@ -29,10 +26,8 @@ module ArelExtensions
       end
     end
 
-    class ArelExtensions::Nodes::Case
+    ArelExtensions::Nodes::Case.class_eval do
       include Arel::Expressions
-      include Arel::Math
-      include Arel::Predications
       include Arel::OrderPredications
       include ArelExtensions::Math
       include ArelExtensions::Comparators
@@ -46,6 +41,8 @@ module ArelExtensions
             @conditions.last.right
           elsif @default
             @default.expr
+          else
+            nil
           end
         if obj.respond_to?(:return_type)
           obj.return_type
@@ -95,9 +92,9 @@ module ArelExtensions
 
       def eql? other
         self.class == other.class &&
-          self.case == other.case &&
-          self.conditions == other.conditions &&
-          self.default == other.default
+        self.case == other.case &&
+        self.conditions == other.conditions &&
+        self.default == other.default
       end
       alias :== :eql?
 

data/lib/arel_extensions/nodes/cast.rb

@@ -14,10 +14,7 @@ module ArelExtensions
           @return_type = :decimal
         when :number
           @return_type = :number
-        when 'char', 'varchar', 'nchar', 'nvarchar'
-          @return_type = :string
-        when 'text', :text, 'ntext', :ntext
-          @as_attr = expr[1].to_sym
+        when 'char', 'varchar', 'text', 'nchar', 'nvarchar', 'ntext'
           @return_type = :string
         when :datetime, 'datetime','smalldatetime'
           @return_type = :datetime
@@ -49,6 +46,7 @@ module ArelExtensions
       def return_type
         @return_type
       end
+
     end
   end
 end

data/lib/arel_extensions/nodes/ceil.rb

@@ -1,7 +1,7 @@
 module ArelExtensions
   module Nodes
     class Ceil < Function
-      RETURN_TYPE = :number
+    	RETURN_TYPE = :number
     end
   end
 end

data/lib/arel_extensions/nodes/coalesce.rb

@@ -2,7 +2,7 @@ module ArelExtensions
   module Nodes
     class Coalesce < Function
       RETURN_TYPE = :string
-
+      
       attr_accessor :left_node_type
 
       def return_type
@@ -20,7 +20,7 @@ module ArelExtensions
           @left_node_type = :number
         when ArelExtensions::Nodes::Coalesce, ArelExtensions::Nodes::Function
           @left_node_type = expr.first.respond_to?(:left_node_type) ? expr.first.left_node_type : nil
-        when Arel::Nodes::Node, Arel::Attributes::Attribute
+        when Arel::Nodes::Node, Arel::Attributes::Attribute 
           @left_node_type = type_of_attribute(expr.first)
         when Date
           @left_node_type = :ruby_date
@@ -29,6 +29,7 @@ module ArelExtensions
         end
         return super(tab)
       end
+
     end
   end
 end

data/lib/arel_extensions/nodes/collate.rb

@@ -5,13 +5,14 @@ module ArelExtensions
 
     attr_accessor :ai, :ci, :option
 
-    def initialize left, option = nil, ai = false, ci = false
+    def initialize left, option=nil, ai=false, ci=false
       @ai = ai
       @ci = ci
       @option = option
       tab = [convert_to_node(left)]
       return super(tab)
     end
+
     end
   end
 end

data/lib/arel_extensions/nodes/concat.rb

@@ -11,7 +11,7 @@ module ArelExtensions::Nodes
         else
           node
         end
-      }.flatten.reduce([]) { |res, b|
+      }.flatten.reduce([]) { | res, b |
         # concatenate successive literal strings.
         if b.is_a?(Arel::Nodes::Quoted) && b.expr == ""
           res
@@ -37,16 +37,25 @@ module ArelExtensions::Nodes
     def concat(other)
       Concat.new(self.expressions + [other])
     end
+
   end
 
-  class GroupConcat < AggregateFunction
+  class GroupConcat < Function
     RETURN_TYPE = :string
 
-    attr_accessor :separator
-
-    def initialize node, separator = ', ', **opts
-      @separator = convert_to_node(separator)
-      super node, **opts
+    attr_accessor :orders
+    
+    def initialize expr
+      tab = expr.map { |arg|
+        if arg.is_a?(Array)
+          @orders = arg
+          nil
+        else
+          convert_to_node(arg)
+        end
+      }.compact
+      super(tab)
     end
+
   end
 end

data/lib/arel_extensions/nodes/date_diff.rb

@@ -2,7 +2,7 @@ require 'date'
 
 module ArelExtensions
   module Nodes
-    class DateDiff < Function # difference entre colonne date et date string/date
+    class DateDiff < Function #difference entre colonne date et date string/date
       attr_accessor :left_node_type
       attr_accessor :right_node_type
 
@@ -12,7 +12,7 @@ module ArelExtensions
         res = []
         col = expr.first
         case col
-        when Arel::Nodes::Node, Arel::Attributes::Attribute
+        when Arel::Nodes::Node, Arel::Attributes::Attribute 
           @left_node_type = type_of_attribute(col)
         when Date
           @left_node_type = :ruby_date
@@ -21,7 +21,7 @@ module ArelExtensions
         end
         res << ([:date, :ruby_date].include?(@left_node_type) ? convert_to_date_node(col) : convert_to_datetime_node(col))
         case expr[1]
-        when Arel::Nodes::Node, Arel::Attributes::Attribute
+        when Arel::Nodes::Node, Arel::Attributes::Attribute 
           @right_node_type = type_of_attribute(expr[1])
         when Date
           @right_node_type = :ruby_date
@@ -97,7 +97,7 @@ module ArelExtensions
         v ||= self.expressions.last
         if defined?(ActiveSupport::Duration) && ActiveSupport::Duration === v
           if @date_type == :ruby_date
-            Arel.sql("(INTERVAL '1' DAY) * %s" % v.inspect.to_i)
+            Arel.sql("(INTERVAL '1' DAY) * %s" % v.inspect.to_i )
           else
             Arel.sql("(INTERVAL '1' SECOND) * %s" % v.to_i)
           end
@@ -136,7 +136,7 @@ module ArelExtensions
           if ArelExtensions::Nodes::Duration === v
             v.with_interval = true
             case v.left
-            when 'd','m','y'
+            when  'd','m','y'
               Arel.sql('day')
             when 'h','mn','s'
               Arel.sql('second')
@@ -145,12 +145,13 @@ module ArelExtensions
             else
               Arel.sql(Arel::Visitors::MSSQL::DATE_MAPPING[v.left])
             end
+          else
+            nil
           end
         end
       end
 
       private
-
       def convert(object)
         case object
         when Arel::Attributes::Attribute, Arel::Nodes::Node, ActiveSupport::Duration
@@ -158,16 +159,16 @@ module ArelExtensions
         when Integer
           object.days
         when DateTime, Time, Date
-          raise(ArgumentError, "#{object.class} cannot be converted to Integer")
+          raise(ArgumentError, "#{object.class} can not be converted to Integer")
         when String
           Arel::Nodes.build_quoted(object)
         else
-          raise(ArgumentError, "#{object.class} cannot be converted to Integer")
+          raise(ArgumentError, "#{object.class} can not be converted to Integer")
         end
       end
     end
 
-    class DateSub < Function # difference entre colonne date et date string/date
+    class DateSub < Function #difference entre colonne date et date string/date
       RETURN_TYPE = :integer
 
       def initialize(expr)
@@ -184,10 +185,12 @@ module ArelExtensions
           if defined?(ActiveSupport::Duration) && ActiveSupport::Duration === object
             object.to_i
           else
-            raise(ArgumentError, "#{object.class} cannot be converted to Number")
+            raise(ArgumentError, "#{object.class} can not be converted to Number")
           end
         end
       end
+
     end
+
   end
 end

data/lib/arel_extensions/nodes/duration.rb

@@ -13,13 +13,16 @@ module ArelExtensions
         super(tab, aliaz)
       end
 
+
       def left
         @expressions.first
       end
 
+
       def right
         @expressions[1]
       end
+
     end
   end
 end

data/lib/arel_extensions/nodes/find_in_set.rb

@@ -2,6 +2,7 @@ module ArelExtensions
   module Nodes
     class FindInSet < Function
       RETURN_TYPE = :integer
+
     end
   end
 end

data/lib/arel_extensions/nodes/floor.rb

@@ -1,7 +1,7 @@
 module ArelExtensions
   module Nodes
     class Floor < Function
-      RETURN_TYPE = :number
+    	RETURN_TYPE = :number
     end
   end
 end

data/lib/arel_extensions/nodes/format.rb

@@ -1,41 +1,15 @@
-require 'strscan'
-
 module ArelExtensions
   module Nodes
-    class Format < Function
+    class Format < Function      
       RETURN_TYPE = :string
 
-      attr_accessor :col_type, :iso_format
-
-      def initialize expr
-        col = expr.first
-        @iso_format = convert_format(expr[1])
-        @col_type = type_of_attribute(col)
-        super [col, convert_to_string_node(@iso_format)]
-      end
-
-      private
-
-      # Address portability issues with some of the formats.
-      def convert_format(fmt)
-        s = StringScanner.new fmt
-        res = StringIO.new
-        while !s.eos?
-          res <<
-            case
-            when s.scan(/%D/)    then '%m/%d/%y'
-            when s.scan(/%F/)    then '%Y-%m-%d'
-            when s.scan(/%R/)    then '%H:%M'
-            when s.scan(/%r/)    then '%I:%M:%S %p'
-            when s.scan(/%T/)    then '%H:%M:%S'
-            when s.scan(/%v/)    then '%e-%b-%Y'
-
-            when s.scan(/[^%]+/) then s.matched
-            when s.scan(/./)     then s.matched
-            end
-        end
-        res.string
-      end
+    	attr_accessor :col_type, :iso_format
+    	def initialize expr
+	        col = expr.first
+            @iso_format = expr[1]
+	        @col_type = type_of_attribute(col)
+        	super [col, convert_to_string_node(@iso_format)]
+    	end
     end
   end
 end

data/lib/arel_extensions/nodes/formatted_number.rb

@@ -1,24 +1,25 @@
 module ArelExtensions
-  module Nodes
-    class FormattedNumber < Function
-      RETURN_TYPE = :string
-
-      attr_accessor :locale, :prefix, :suffix, :flags, :scientific_notation, :width,:precision, :type, :original_string
-
-      def initialize expr
-        # expr[1] = {:locale => 'fr_FR', :type => "e"/"f"/"d", :prefix => "$ ", :suffix => " %", :flags => " +-#0", :width => 5, :precision => 6}
-        col = expr.first
-        @locale = expr[1][:locale]
-        @prefix = expr[1][:prefix]
-        @suffix = expr[1][:suffix]
-        @width = expr[1][:width]
-        @precision = expr[1][:precision]
-        @type = expr[1][:type]
-        @flags = expr[1][:flags]
-        @scientific_notation = /[eE]/.match(expr[1][:type]) || false
-        @original_string = expr[1][:original_string]
-        super [col]
-      end
-    end
-  end
+	module Nodes
+		class FormattedNumber < Function		
+			RETURN_TYPE = :string
+			
+			attr_accessor :locale, :prefix, :suffix, :flags, :scientific_notation, :width,:precision, :type, :original_string
+			
+			def initialize expr
+				# expr[1] = {:locale => 'fr_FR', :type => "e"/"f"/"d", :prefix => "$ ", :suffix => " %", :flags => " +-#0", :width => 5, :precision => 6}
+				col = expr.first
+				@locale = expr[1][:locale]
+				@prefix = expr[1][:prefix]
+				@suffix = expr[1][:suffix] 
+				@width = expr[1][:width]
+				@precision = expr[1][:precision]
+				@type = expr[1][:type]
+				@flags = expr[1][:flags]
+				@scientific_notation = /[eE]/.match(expr[1][:type]) || false
+				@original_string = expr[1][:original_string]
+				super [col]
+			end
+			
+		end				
+	end
 end