arel_extensions 1.2.25 → 2.0.0.rc3

data/lib/arel_extensions/visitors.rb

@@ -1,89 +1,81 @@
-require 'arel_extensions/visitors/convert_format'
 require 'arel_extensions/visitors/to_sql'
 require 'arel_extensions/visitors/mysql'
+require 'arel_extensions/visitors/oracle'
+require 'arel_extensions/visitors/oracle12'
 require 'arel_extensions/visitors/postgresql'
 require 'arel_extensions/visitors/sqlite'
+require 'arel_extensions/visitors/mssql'
 
-if defined?(Arel::Visitors::Oracle)
-  require 'arel_extensions/visitors/oracle'
-  require 'arel_extensions/visitors/oracle12'
-end
-
-if defined?(Arel::Visitors::MSSQL)
-  require 'arel_extensions/visitors/mssql'
+Arel::Visitors::MSSQL.class_eval do
+  include ArelExtensions::Visitors::MSSQL
 
-  class Arel::Visitors::MSSQL
-    include ArelExtensions::Visitors::MSSQL
-
-    alias_method(:old_visit_Arel_Nodes_As, :visit_Arel_Nodes_As) rescue nil
-    def visit_Arel_Nodes_As o, collector
-      if o.left.is_a?(Arel::Nodes::Binary)
-        collector << '('
-        collector = visit o.left, collector
-        collector << ')'
-      else
-        collector = visit o.left, collector
-      end
-      collector << " AS ["
-      collector = visit o.right, collector
-      collector << "]"
-      collector
+  alias_method :old_visit_Arel_Nodes_As, :visit_Arel_Nodes_As
+  def visit_Arel_Nodes_As o, collector
+    if o.left.is_a?(Arel::Nodes::Binary)
+      collector << '('
+      collector = visit o.left, collector
+      collector << ')'
+    else
+      collector = visit o.left, collector
     end
+    collector << " AS ["
+    collector = visit o.right, collector
+    collector << "]"
+    collector
+  end
 
-    alias_method(:old_visit_Arel_Nodes_SelectStatement, :visit_Arel_Nodes_SelectStatement) rescue nil
-    def visit_Arel_Nodes_SelectStatement o, collector
-      if !collector.value.blank? && o.limit.blank? && o.offset.blank?
-        o = o.dup
-        o.orders = []
-      end
-      old_visit_Arel_Nodes_SelectStatement(o,collector)
+  alias_method :old_visit_Arel_Nodes_SelectStatement, :visit_Arel_Nodes_SelectStatement
+  def visit_Arel_Nodes_SelectStatement o, collector
+    if !collector.value.blank? && o.limit.blank? && o.offset.blank?
+      o = o.dup
+      o.orders = []
     end
+    old_visit_Arel_Nodes_SelectStatement(o,collector)
   end
+end
 
-  begin
-    require 'arel_sqlserver'
-    if Arel::VERSION.to_i == 6
-      if Arel::Visitors::VISITORS['sqlserver'] && Arel::Visitors::VISITORS['sqlserver'] != Arel::Visitors::MSSQL
-        Arel::Visitors::VISITORS['sqlserver'].class_eval do
-          include ArelExtensions::Visitors::MSSQL
+begin
+  require 'arel_sqlserver'
+  if Arel::VERSION.to_i == 6
+    if Arel::Visitors::VISITORS['sqlserver'] && Arel::Visitors::VISITORS['sqlserver'] != Arel::Visitors::MSSQL
+      Arel::Visitors::VISITORS['sqlserver'].class_eval do
+        include ArelExtensions::Visitors::MSSQL
 
-          alias_method(:old_visit_Arel_Nodes_SelectStatement, :visit_Arel_Nodes_SelectStatement) rescue nil
-          def visit_Arel_Nodes_SelectStatement o, collector
-            if !collector.value.blank? && o.limit.blank? && o.offset.blank?
-              o = o.dup
-              o.orders = []
-            end
-            old_visit_Arel_Nodes_SelectStatement(o,collector)
+        alias_method :old_visit_Arel_Nodes_SelectStatement, :visit_Arel_Nodes_SelectStatement
+        def visit_Arel_Nodes_SelectStatement o, collector
+          if !collector.value.blank? && o.limit.blank? && o.offset.blank?
+            o = o.dup
+            o.orders = []
           end
+          old_visit_Arel_Nodes_SelectStatement(o,collector)
+        end
 
-          alias_method(:old_visit_Arel_Nodes_As, :visit_Arel_Nodes_As) rescue nil
-          def visit_Arel_Nodes_As o, collector
-            if o.left.is_a?(Arel::Nodes::Binary)
-              collector << '('
-              collector = visit o.left, collector
-              collector << ')'
-            else
-              collector = visit o.left, collector
-            end
-            collector << " AS ["
-            collector = visit o.right, collector
-            collector << "]"
-            collector
+        alias_method :old_visit_Arel_Nodes_As, :visit_Arel_Nodes_As
+        def visit_Arel_Nodes_As o, collector
+          if o.left.is_a?(Arel::Nodes::Binary)
+            collector << '('
+            collector = visit o.left, collector
+            collector << ')'
+          else
+            collector = visit o.left, collector
           end
+          collector << " AS ["
+          collector = visit o.right, collector
+          collector << "]"
+          collector
+        end
 
-          alias_method(:old_primary_Key_From_Table, :primary_Key_From_Table) rescue nil
-          def primary_Key_From_Table t
-            return unless t
-
-            column_name = @connection.schema_cache.primary_keys(t.name) ||
-                          @connection.schema_cache.columns_hash(t.name).first.try(:second).try(:name)
-            column_name ? t[column_name] : nil
-          end
+        alias_method :old_primary_Key_From_Table, :primary_Key_From_Table
+        def primary_Key_From_Table t
+          return unless t
+          column_name = @connection.schema_cache.primary_keys(t.name) ||
+            @connection.schema_cache.columns_hash(t.name).first.try(:second).try(:name)
+          column_name ? t[column_name] : nil
         end
       end
     end
-  rescue LoadError
-  rescue => e
-      e
   end
+  rescue LoadError
+rescue => e
+    e
 end

data/lib/arel_extensions.rb

@@ -7,45 +7,35 @@ require 'arel_extensions/railtie' if defined?(Rails::Railtie)
 # Count|NamedFunction < Function < Arel::Nodes::Node
 
 # pure Arel internals improvements
-class Arel::Nodes::Binary
+Arel::Nodes::Binary.class_eval do
   include Arel::AliasPredication
   include Arel::Expressions
 end
 
-class Arel::Nodes::Casted
+Arel::Nodes::Casted.class_eval do
   include Arel::AliasPredication
-
-  # They forget to define hash.
-  if Gem::Version.new(Arel::VERSION) < Gem::Version.new("10.0.0")
-    def hash
-      [self.class, self.val, self.attribute].hash
-    end
-  end
 end
 
-class Arel::Nodes::Unary
+Arel::Nodes::Unary.class_eval do
   include Arel::Math
   include Arel::AliasPredication
   include Arel::Expressions
 end
 
-class Arel::Nodes::Grouping
+Arel::Nodes::Grouping.class_eval do
+  include Arel::Math
+  include Arel::AliasPredication
   include Arel::OrderPredications
+  include Arel::Expressions
 end
 
-class Arel::Nodes::Ordering
-	def eql? other
-		self.hash.eql? other.hash
-	end
-end
-
-class Arel::Nodes::Function
+Arel::Nodes::Function.class_eval do
   include Arel::Math
   include Arel::Expressions
 end
 
-if Gem::Version.new(Arel::VERSION) >= Gem::Version.new("7.1.0")
-  class Arel::Nodes::Case
+if Arel::VERSION >= "7.1.0"
+  Arel::Nodes::Case.class_eval do
     include Arel::Math
     include Arel::Expressions
   end
@@ -103,26 +93,14 @@ module Arel
     ArelExtensions::Nodes::Duration.new(s.to_s+'i',expr)
   end
 
-  def self.true
-    Arel::Nodes::Equality.new(1,1)
-  end
-
-  def self.false
-    Arel::Nodes::Equality.new(1,0)
-  end
-
-  def self.tuple *v
-    tmp = Arel::Nodes::Grouping.new(nil)
-    Arel::Nodes::Grouping.new(v.map{|e| tmp.convert_to_node(e)})
-  end
 end
 
-class Arel::Attributes::Attribute
+Arel::Attributes::Attribute.class_eval do
   include Arel::Math
   include ArelExtensions::Attributes
 end
 
-class Arel::Nodes::Function
+Arel::Nodes::Function.class_eval do
   include ArelExtensions::Math
   include ArelExtensions::Comparators
   include ArelExtensions::DateDuration
@@ -131,84 +109,44 @@ class Arel::Nodes::Function
   include ArelExtensions::BooleanFunctions
   include ArelExtensions::NullFunctions
   include ArelExtensions::Predications
-
-  alias_method(:old_as, :as) rescue nil
-  def as other
-    res = Arel::Nodes::As.new(self.clone, Arel.sql(other))
-    if Gem::Version.new(Arel::VERSION) >= Gem::Version.new("9.0.0")
-      self.alias = Arel.sql(other)
-    end
-    res
-  end
-end
-
-class Arel::Nodes::Grouping
-    include ArelExtensions::Math
-    include ArelExtensions::Comparators
-    include ArelExtensions::DateDuration
-    include ArelExtensions::MathFunctions
-    include ArelExtensions::NullFunctions
-    include ArelExtensions::StringFunctions
-    include ArelExtensions::Predications
 end
 
-class Arel::Nodes::Unary
+Arel::Nodes::Unary.class_eval do
   include ArelExtensions::Math
   include ArelExtensions::Attributes
   include ArelExtensions::MathFunctions
   include ArelExtensions::Comparators
   include ArelExtensions::Predications
-  def eql? other
-    hash == other.hash
-  end
 end
 
-class Arel::Nodes::Binary
+Arel::Nodes::Binary.class_eval do
   include ArelExtensions::Math
   include ArelExtensions::Attributes
   include ArelExtensions::MathFunctions
   include ArelExtensions::Comparators
   include ArelExtensions::BooleanFunctions
   include ArelExtensions::Predications
-  def eql? other
-    hash == other.hash
-  end
 end
 
-class Arel::Nodes::Equality
+Arel::Nodes::Equality.class_eval do
   include ArelExtensions::Comparators
   include ArelExtensions::DateDuration
   include ArelExtensions::MathFunctions
   include ArelExtensions::StringFunctions
 end
 
-class Arel::InsertManager
+
+Arel::InsertManager.class_eval do
   include ArelExtensions::InsertManager
 end
 
-class Arel::SelectManager
+Arel::SelectManager.class_eval do
   include ArelExtensions::SetFunctions
   include ArelExtensions::Nodes
 end
 
-class Arel::Nodes::As
+Arel::Nodes::As.class_eval do
   include ArelExtensions::Nodes
 end
 
-class Arel::Table
-  alias_method(:old_alias, :alias) rescue nil
-  def alias(name = "#{self.name}_2")
-    name.blank? ? self : Arel::Nodes::TableAlias.new(self,name)
-  end
-end
 
-class Arel::Nodes::TableAlias
-  def method_missing(*args)
-    met = args.shift.to_sym
-    if self.relation.respond_to?(met)
-      self.relation.send(met,args)
-    else
-      super(met,*args)
-    end
-  end
-end

data/test/database.yml

@@ -10,8 +10,6 @@ mysql:
   adapter: mysql2
   database: arext_test
   username: travis
-  host: 127.0.0.1
-  port: 3306
   encoding: utf8
 jdbc-mysql:
   adapter: jdbcmysql

data/test/helper.rb

@@ -0,0 +1,18 @@
+require 'rubygems'
+require 'minitest/autorun'
+require 'fileutils'
+require 'arel'
+require 'active_record'
+
+require 'arel_extensions'
+
+require 'support/fake_record'
+Arel::Table.engine = FakeRecord::Base.new
+
+$arel_silence_type_casting_deprecation = true
+
+class Object
+  def must_be_like other
+    gsub(/\s+/, ' ').strip.must_equal other.gsub(/\s+/, ' ').strip
+  end
+end

data/test/real_db_test.rb

@@ -21,15 +21,15 @@ def setup_db
         db.enable_load_extension(0)
       rescue => e
         $load_extension_disabled = true
-        $stderr << "cannot load extensions #{e.inspect}\n"
+        $stderr << "can not load extensions #{e.inspect}\n"
       end
     end
-    # function find_in_set
+    #function find_in_set
     db.create_function("find_in_set", 1) do |func, value1, value2|
       func.result = value1.index(value2)
     end
   end
-  @cnx.drop_table(:users) rescue nil
+  @cnx.drop_table(:users) rescue nil 
   @cnx.create_table :users do |t|
       t.column :age, :integer
       t.column :name, :string
@@ -44,13 +44,15 @@ def teardown_db
 end
 
 class User < ActiveRecord::Base
+
 end
 
 class ListTest < Minitest::Test
+
   def setup
     d = Date.new(2016,05,23)
     setup_db
-    User.create :age => 5, :name => "Lucas", :created_at => d, :score => 20.16
+    User.create :age => 5, :name => "Lucas", :created_at => d , :score => 20.16
     User.create :age => 15, :name => "Sophie", :created_at => d, :score => 20.16
     User.create :age => 20, :name => "Camille", :created_at => d, :score => 20.16
     User.create :age => 21, :name => "Arthur", :created_at => d, :score => 65.62
@@ -88,28 +90,30 @@ class ListTest < Minitest::Test
   end
 
   def test_Comparator
-    assert_equal 2,User.where(User.arel_table[:age] < 6).count
-    assert_equal 2,User.where(User.arel_table[:age] <=10).count
-    assert_equal 3,User.where(User.arel_table[:age] > 20).count
-    assert_equal 4,User.where(User.arel_table[:age] >=20).count
-    assert_equal 1,User.where(User.arel_table[:age] > 5).where(User.arel_table[:age] < 20).count
+    assert_equal 2,User.where(User.arel_table[:age] < 6 ).count
+    assert_equal 2,User.where(User.arel_table[:age] <=10 ).count
+    assert_equal 3,User.where(User.arel_table[:age] > 20 ).count
+    assert_equal 4,User.where(User.arel_table[:age] >=20 ).count
+    assert_equal 1,User.where(User.arel_table[:age] > 5 ).where(User.arel_table[:age] < 20 ).count
   end
 
   def test_date_duration
-    # Year
+    #Year
     assert_equal 2016,User.where(User.arel_table[:name].eq("Lucas")).select((User.arel_table[:created_at].year).as("res")).first.res.to_i
     assert_equal 0,User.where(User.arel_table[:created_at].year.eq("2012")).count
-    # Month
+    #Month
     assert_equal 5,User.where(User.arel_table[:name].eq("Camille")).select((User.arel_table[:created_at].month).as("res")).first.res.to_i
     assert_equal 8,User.where(User.arel_table[:created_at].month.eq("05")).count
-    # Week
+    #Week
     assert_equal 21,User.where(User.arel_table[:name].eq("Arthur")).select((User.arel_table[:created_at].week).as("res")).first.res.to_i
     assert_equal 8,User.where(User.arel_table[:created_at].month.eq("05")).count
-    # Day
+    #Day
     assert_equal 23,User.where(User.arel_table[:name].eq("Laure")).select((User.arel_table[:created_at].day).as("res")).first.res.to_i
     assert_equal 0,User.where(User.arel_table[:created_at].day.eq("05")).count
   end
 
+
+
   def test_length
     assert_equal 7,User.where(User.arel_table[:name].eq("Camille")).select((User.arel_table[:name].length).as("res")).first.res
     assert_equal 5,User.where(User.arel_table[:name].eq("Laure")).select((User.arel_table[:name].length).as("res")).first.res
@@ -132,6 +136,7 @@ class ListTest < Minitest::Test
     end
   end
 
+
   def test_floor
     if !$sqlite || !$load_extension_disabled
       assert_equal 0,User.where(User.arel_table[:name].eq("Negatif")).select((User.arel_table[:score].floor).as("res")).first.res
@@ -139,51 +144,57 @@ class ListTest < Minitest::Test
     end
   end
 
+
   def test_findinset
     db = ActiveRecord::Base.connection.raw_connection
-    assert_equal 3,db.get_first_value("select find_in_set(name,'i') from users where name = 'Camille'")
-    assert_equal "",db.get_first_value("select find_in_set(name,'p') from users where name = 'Camille'").to_s
-    # number
-    # assert_equal 1,User.select(User.arel_table[:name] & ("l")).count
-    # assert_equal 3,(User.select(User.arel_table[:age] & [5,15,20]))
-    # string
+    assert_equal 3,db.get_first_value( "select find_in_set(name,'i') from users where name = 'Camille'" )
+    assert_equal "",db.get_first_value( "select find_in_set(name,'p') from users where name = 'Camille'" ).to_s
+    #number
+    #assert_equal 1,User.select(User.arel_table[:name] & ("l")).count
+    #assert_equal 3,(User.select(User.arel_table[:age] & [5,15,20]))
+    #string
   end
 
+
   def test_math_plus
     d = Date.new(1997,06,15)
-    # Concat String
+    #Concat String
     assert_equal "SophiePhan",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + "Phan").as("res")).first.res
-    assert_equal "Sophie2",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + 2).as("res")).first.res
+    assert_equal "Sophie2",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + 2 ).as("res")).first.res
     assert_equal "Sophie1997-06-15",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + d).as("res")).first.res
     assert_equal "Sophie15",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + User.arel_table[:age]).as("res")).first.res
     assert_equal "SophieSophie",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + User.arel_table[:name]).as("res")).first.res
     assert_equal "Sophie2016-05-23",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + User.arel_table[:created_at]).as("res")).first.res
-    # concat Integer
+    #concat Integer
     assert_equal 1, User.where((User.arel_table[:age] + 10).eq(33)).count
     assert_equal 1, User.where((User.arel_table[:age] + "1").eq(6)).count
     assert_equal 1, User.where((User.arel_table[:age] + User.arel_table[:age]).eq(10)).count
-    # concat Date
-    #    puts((User.arel_table[:created_at] + 1).as("res").to_sql.inspect)
+    #concat Date
+#    puts((User.arel_table[:created_at] + 1).as("res").to_sql.inspect)
     assert_equal "2016-05-24", @myung.select((User.arel_table[:created_at] + 1).as("res")).first.res.to_date.to_s
     assert_equal "2016-05-25", @myung.select((User.arel_table[:created_at] + 2.day).as("res")).first.res.to_date.to_s
   end
 
+
   def test_math_moins
     d = Date.new(2016,05,20)
-    # Datediff
+    #Datediff
     assert_equal 8,User.where((User.arel_table[:created_at] - User.arel_table[:created_at]).eq(0)).count
     assert_equal 3,User.where(User.arel_table[:name].eq("Laure")).select((User.arel_table[:created_at] - d).as("res")).first.res.abs.to_i
-    # Substraction
+    #Substraction
     assert_equal 0, User.where((User.arel_table[:age] - 10).eq(50)).count
     assert_equal 0, User.where((User.arel_table[:age] - "10").eq(50)).count
   end
 
+
+
   def test_rand
     assert_equal 5,User.where(User.arel_table[:score].eq(20.16)).select(User.arel_table[:id]).order(Arel.rand).take(50).count
-    # test_alias  :random  :rand
+    #test_alias  :random  :rand
     assert_equal 8,User.select(User.arel_table[:name]).order(Arel.rand).take(50).count
   end
 
+
   def test_regexp_not_regex
     if !$sqlite || !$load_extension_disabled
       assert_equal 1, User.where(User.arel_table[:name] =~ '^M').count
@@ -196,11 +207,13 @@ class ListTest < Minitest::Test
     assert_equal "replace",User.where(User.arel_table[:name].eq("Lucas")).select(((User.arel_table[:name]).replace(User.arel_table[:name],"replace")).as("res")).first.res
   end
 
+
   def test_round
     assert_equal 1, User.where(((User.arel_table[:age]).round(0)).eq(5.0)).count
     assert_equal 0, User.where(((User.arel_table[:age]).round(-1)).eq(6.0)).count
   end
 
+
   def test_Soundex
     if !$sqlite || !$load_extension_disabled
       assert_equal "C540",User.where(User.arel_table[:name].eq("Camille")).select((User.arel_table[:name].soundex).as("res")).first.res.to_s
@@ -209,13 +222,14 @@ class ListTest < Minitest::Test
   end
 
   def test_Sum
-    # .take(50) because of limit by ORDER BY
+    #.take(50) because of limit by ORDER BY
     assert_equal 110,User.select((User.arel_table[:age].sum + 1).as("res")).take(50).first.res
     assert_equal 218,User.select((User.arel_table[:age].sum + User.arel_table[:age].sum).as("res")).take(50).first.res
     assert_equal 327,User.select(((User.arel_table[:age] * 3).sum).as("res")).take(50).first.res
     assert_equal 2245,User.select(((User.arel_table[:age] * User.arel_table[:age]).sum).as("res")).take(50).first.res
   end
 
+
   def test_trim
     assert_equal "Myun",User.where(User.arel_table[:name].eq("Myung")).select(User.arel_table[:name].rtrim("g").as("res")).first.res
     assert_equal "yung",User.where(User.arel_table[:name].eq("Myung")).select(User.arel_table[:name].ltrim("M").as("res")).first.res
@@ -229,4 +243,5 @@ class ListTest < Minitest::Test
       assert_equal 1,User.where(User.arel_table[:name].eq("Myung")).select((User.arel_table[:created_at].wday).as("res")).first.res.to_i
       assert_equal 0,User.select(d.wday).as("res").first.to_i
   end
+
 end

data/test/support/fake_record.rb

@@ -7,7 +7,7 @@ module FakeRecord
     attr_accessor :visitor
 
     def initialize(visitor = nil)
-      @tables = %w{users photos developers products}
+      @tables = %w{ users photos developers products}
       @columns = {
         'users' => [
           Column.new('id', :integer),
@@ -66,7 +66,7 @@ module FakeRecord
     end
 
     def in_clause_length
-      10000
+      6
     end
 
     def quote thing, column = nil

data/test/test_comparators.rb

@@ -1,8 +1,10 @@
-require 'arelx_test_helper'
+require 'helper'
 
 module ArelExtensions
   module Nodes
+
     describe ArelExtensions::Comparators do
+
       before do
         @conn = FakeRecord::Base.new
         Arel::Table.engine = @conn
@@ -18,25 +20,26 @@ module ArelExtensions
       end
 
       it "< is equal lt" do
-        _(compile(@table[:id] < 10)).must_be_like('"users"."id" < 10')
+        compile(@table[:id] < 10).must_be_like('"users"."id" < 10')
       end
-
+      
       it "<= is equal lteq" do
-        _(compile(@table[:id] <= 10)).must_be_like('"users"."id" <= 10')
+        compile(@table[:id] <= 10).must_be_like('"users"."id" <= 10')
       end
 
       it "> is equal gt" do
-        _(compile(@table[:id] > 10)).must_be_like('"users"."id" > 10')
+        compile(@table[:id] > 10).must_be_like('"users"."id" > 10')
       end
 
       it "< is equal gteq" do
-        _(compile(@table[:id] >= 10)).must_be_like('"users"."id" >= 10')
+        compile(@table[:id] >= 10).must_be_like('"users"."id" >= 10')
       end
 
       it "should compare with dates" do
-        _(compile(@table[:created_at] >= Date.new(2016, 3, 31)))
-          .must_be_like %{"users"."created_at" >= '2016-03-31'}
+        compile(@table[:created_at] >= Date.new(2016, 3, 31)).must_be_like %{"users"."created_at" >= '2016-03-31'}
       end
+
     end
+
   end
-end
+end

data/test/visitors/test_bulk_insert_oracle.rb

@@ -1,4 +1,4 @@
-require 'arelx_test_helper'
+require 'helper'
 
 module ArelExtensions
   module BulkInsertOracle
@@ -9,8 +9,8 @@ module ArelExtensions
         @table = Arel::Table.new(:users)
         @cols = ['name', 'comments', 'created_at']
         @data = [
-          ['nom1', "sdfdsfdsfsdf", '2016-01-01'],
-          ['nom2', "sdfdsfdsfsdf", '2016-01-01']
+        	['nom1', "sdfdsfdsfsdf", '2016-01-01'],
+        	['nom2', "sdfdsfdsfsdf", '2016-01-01']
         ]
       end
 
@@ -24,11 +24,11 @@ module ArelExtensions
 
       it "should import large set of data in Oracle" do
         insert_manager = Arel::VERSION.to_i > 6 ? Arel::InsertManager.new().into(@table) : Arel::InsertManager.new(@conn).into(@table)
-        insert_manager.bulk_insert(@cols, @data)
-        _(compile(insert_manager.ast))
-          .must_be_like %Q[INSERT INTO "users" ("name", "comments", "created_at")
-                        ((SELECT 'nom1', 'sdfdsfdsfsdf', '2016-01-01' FROM DUAL) UNION ALL (SELECT 'nom2', 'sdfdsfdsfsdf', '2016-01-01' FROM DUAL))]
+      	insert_manager.bulk_insert(@cols, @data)
+      	sql = compile(insert_manager.ast)
+      	sql.must_be_like %Q[INSERT INTO "users" ("name", "comments", "created_at") ((SELECT 'nom1', 'sdfdsfdsfsdf', '2016-01-01' FROM DUAL) UNION ALL (SELECT 'nom2', 'sdfdsfdsfsdf', '2016-01-01' FROM DUAL))]
       end
-    end
+
+	  end
   end
 end