arduino_firmata 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 87e21383fdc0053837691237c377c338776f7faa
-  data.tar.gz: 05f23f9a008c7a612f87770060264d57090b6068
+  metadata.gz: cb79730f81ce6d1e5cf252847c00bc6667cd46e4
+  data.tar.gz: 9f589cb5dbff2f8a143cdf8e29f1ae4890a3d8c5
 SHA512:
-  metadata.gz: 61e0ef9f5cdc0adab8ba9095c8de85a3819fba6c849a386c97d83077971ca7344af60050ad1870b5c1c54bf18806447d48391f446eaadd66a1c4246c0b5f1afb
-  data.tar.gz: fc8b15465cf376a04abe433d4baec6fe2eac4b23560aee5d4535dcf6d33443098ca62c98b16b139d1b36b3759b3ed8f7eb63559722afa399737a0055d26ab941
+  metadata.gz: ab7369bd8c68814f5273076fa845558e38531803c48a00454e0425a727edf33293f24307c1844f18b45c780f47f03bdb3f79bcbae2d12d7b6752e46f3ce7b92e
+  data.tar.gz: a8247133ee445fdab29b976f42a65ef5006b15af57950e56d47f573e8f285af82c585d149d3306df64823d1dfc2084c7b0a0d7da13f0a87126693e6d0b96ef5a

data/History.txt

@@ -1,3 +1,7 @@
+=== 0.3.5 2013-11-12
+
+* check arguments on digital/analog read/write  #34
+
 === 0.3.4 2013-09-29
 
 * bugfix "write would block (Errno::EAGAIN)" with eventmachine

data/lib/arduino_firmata/arduino.rb

@@ -105,14 +105,17 @@ module ArduinoFirmata
     end
 
     def digital_read(pin)
+      raise ArgumentError, "invalid pin number (#{pin})" if pin.class != Fixnum or pin < 0
       (@digital_input_data[pin >> 3] >> (pin & 0x07)) & 0x01 > 0
     end
 
     def analog_read(pin)
+      raise ArgumentError, "invalid pin number (#{pin})" if pin.class != Fixnum or pin < 0
       @analog_input_data[pin]
     end
 
     def pin_mode(pin, mode)
+      raise ArgumentError, "invalid pin number (#{pin})" if pin.class != Fixnum or pin < 0
       write SET_PIN_MODE
       write pin
       mode = case mode
@@ -129,6 +132,7 @@ module ArduinoFirmata
     end
 
     def digital_write(pin, value)
+      raise ArgumentError, "invalid pin number (#{pin})" if pin.class != Fixnum or pin < 0
       pin_mode pin, OUTPUT
       port_num = (pin >> 3) & 0x0F
       if value == 0 or value == false
@@ -145,6 +149,8 @@ module ArduinoFirmata
     end
 
     def analog_write(pin, value)
+      raise ArgumentError, "invalid pin number (#{pin})" if pin.class != Fixnum or pin < 0
+      raise ArgumentError, "invalid analog value (#{value})" if value.class != Fixnum or value < 0
       pin_mode pin, PWM
       write(ANALOG_MESSAGE | (pin & 0x0F))
       write(value & 0x7F)
@@ -154,6 +160,8 @@ module ArduinoFirmata
     end
 
     def servo_write(pin, angle)
+      raise ArgumentError, "invalid pin number (#{pin})" if pin.class != Fixnum or pin < 0
+      raise ArgumentError, "invalid angle (#{angle})" if angle.class != Fixnum or angle < 0
       pin_mode pin, SERVO
       write(ANALOG_MESSAGE | (pin & 0x0F))
       write(angle & 0x7F)

data/lib/arduino_firmata/version.rb

@@ -1,3 +1,3 @@
 module ArduinoFirmata
-  VERSION = '0.3.4'
+  VERSION = '0.3.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arduino_firmata
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Sho Hashimoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-29 00:00:00.000000000 Z
+date: 2013-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -173,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.5
+rubygems_version: 2.1.5
 signing_key: 
 specification_version: 4
 summary: Arduino Firmata protocol (http://firmata.org) implementation on Ruby.