ardb 0.28.3 → 0.30.0

data/test/unit/relation_spy_tests.rb

@@ -1,8 +1,9 @@
-require 'assert'
-require 'ardb/relation_spy'
+# frozen_string_literal: true
 
-class Ardb::RelationSpy
+require "assert"
+require "ardb/relation_spy"
 
+class Ardb::RelationSpy
   class UnitTests < Assert::Context
     desc "Ardb::RelationSpy"
     setup do
@@ -50,12 +51,13 @@ class Ardb::RelationSpy
       assert_equal other_relation, subject
     end
 
-    should "build a fake sql string for its applied expressions using `to_sql`" do
-      subject.select 'column'
-      subject.from 'table'
-      subject.joins 'my_table.my_column ON my_table.my_column = table.column'
+    should "build a fake sql string for its applied expressions using "\
+           "`to_sql`" do
+      subject.select "column"
+      subject.from "table"
+      subject.joins "my_table.my_column ON my_table.my_column = table.column"
 
-      expected = subject.applied.map(&:to_sql).join(', ')
+      expected = subject.applied.map(&:to_sql).join(", ")
       assert_equal expected, subject.to_sql
     end
 
@@ -70,7 +72,6 @@ class Ardb::RelationSpy
       assert_nil subject.limit_value
       assert_nil subject.offset_value
     end
-
   end
 
   class SelectTests < UnitTests
@@ -83,9 +84,8 @@ class Ardb::RelationSpy
     should "add a select applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :select, @applied.type
-      assert_equal [ :column_a, :column_b ], @applied.args
+      assert_equal [:column_a, :column_b], @applied.args
     end
-
   end
 
   class FromTests < UnitTests
@@ -98,9 +98,8 @@ class Ardb::RelationSpy
     should "add a from applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :from, @applied.type
-      assert_equal [ "some SQL" ], @applied.args
+      assert_equal ["some SQL"], @applied.args
     end
-
   end
 
   class IncludesTests < UnitTests
@@ -113,9 +112,8 @@ class Ardb::RelationSpy
     should "add an includes applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :includes, @applied.type
-      assert_equal [ :table_a, :table_b ], @applied.args
+      assert_equal [:table_a, :table_b], @applied.args
     end
-
   end
 
   class JoinsTests < UnitTests
@@ -128,24 +126,22 @@ class Ardb::RelationSpy
     should "add a joins applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :joins, @applied.type
-      assert_equal [ :table_a, :table_b ], @applied.args
+      assert_equal [:table_a, :table_b], @applied.args
     end
-
   end
 
   class WhereTests < UnitTests
     desc "where"
     setup do
-      @relation_spy.where :column_a => 'some value'
+      @relation_spy.where column_a: "some value"
       @applied = subject.applied.first
     end
 
     should "add a where applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :where, @applied.type
-      assert_equal [ { :column_a => 'some value' } ], @applied.args
+      assert_equal [{ column_a: "some value" }], @applied.args
     end
-
   end
 
   class OrderTests < UnitTests
@@ -158,9 +154,8 @@ class Ardb::RelationSpy
     should "add an order applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :order, @applied.type
-      assert_equal [ :column_a, :column_b ], @applied.args
+      assert_equal [:column_a, :column_b], @applied.args
     end
-
   end
 
   class ReverseOrderTests < UnitTests
@@ -174,7 +169,6 @@ class Ardb::RelationSpy
       assert_instance_of AppliedExpression, @applied
       assert_equal :reverse_order, @applied.type
     end
-
   end
 
   class GroupTests < UnitTests
@@ -187,24 +181,22 @@ class Ardb::RelationSpy
     should "add a group applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :group, @applied.type
-      assert_equal [ :column_a, :column_b ], @applied.args
+      assert_equal [:column_a, :column_b], @applied.args
     end
-
   end
 
   class HavingTests < UnitTests
     desc "having"
     setup do
-      @relation_spy.having 'COUNT(column_a) > 0'
+      @relation_spy.having "COUNT(column_a) > 0"
       @applied = subject.applied.first
     end
 
     should "add a having applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :having, @applied.type
-      assert_equal [ 'COUNT(column_a) > 0' ], @applied.args
+      assert_equal ["COUNT(column_a) > 0"], @applied.args
     end
-
   end
 
   class ReadonlyTests < UnitTests
@@ -217,9 +209,8 @@ class Ardb::RelationSpy
     should "add a readonly applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :readonly, @applied.type
-      assert_equal [ true ], @applied.args
+      assert_equal [true], @applied.args
     end
-
   end
 
   class LimitTests < UnitTests
@@ -232,13 +223,12 @@ class Ardb::RelationSpy
     should "add a limit applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :limit, @applied.type
-      assert_equal [ 100 ], @applied.args
+      assert_equal [100], @applied.args
     end
 
     should "set it's limit value" do
       assert_equal 100, subject.limit_value
     end
-
   end
 
   class OffsetTests < UnitTests
@@ -251,19 +241,19 @@ class Ardb::RelationSpy
     should "add an offset applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :offset, @applied.type
-      assert_equal [ 100 ], @applied.args
+      assert_equal [100], @applied.args
     end
 
     should "set it's offset value" do
       assert_equal 100, subject.offset_value
     end
-
   end
 
   class MergeWithARelationSpyTests < UnitTests
     desc "merge with a relation spy"
     setup do
-      @other_relation_spy = Ardb::RelationSpy.new.select('column').joins('table')
+      @other_relation_spy =
+        Ardb::RelationSpy.new.select("column").joins("table")
       @relation_spy.merge @other_relation_spy
     end
 
@@ -272,13 +262,12 @@ class Ardb::RelationSpy
         assert_includes applied, @relation_spy.applied
       end
     end
-
   end
 
   class MergeWithNonRelationSpyTests < UnitTests
     desc "merge without a relation spy"
     setup do
-      @fake_relation = 'relation'
+      @fake_relation = "relation"
       @relation_spy.merge @fake_relation
       @applied = subject.applied.first
     end
@@ -286,29 +275,27 @@ class Ardb::RelationSpy
     should "add a merge applied expression with the passed args" do
       assert_instance_of AppliedExpression, @applied
       assert_equal :merge, @applied.type
-      assert_equal [ @fake_relation ], @applied.args
+      assert_equal [@fake_relation], @applied.args
     end
-
   end
 
   class MergeWithSelfTests < UnitTests
     desc "merge with itself"
     setup do
-      @fake_relation = 'relation'
+      @fake_relation = "relation"
       @relation_spy.merge @relation_spy
     end
 
     should "not alter the applied expressions" do
       assert_empty subject.applied
     end
-
   end
 
   class WithExpressionsTests < UnitTests
     setup do
-      @relation_spy.select('column').includes('table').joins('table')
-      @relation_spy.where(:column => 'value').order('column')
-      @relation_spy.group('column').having('count(*) > 1')
+      @relation_spy.select("column").includes("table").joins("table")
+      @relation_spy.where(column: "value").order("column")
+      @relation_spy.group("column").having("count(*) > 1")
       @relation_spy.limit(1).offset(1)
     end
   end
@@ -324,10 +311,10 @@ class Ardb::RelationSpy
     should "remove any applied expressions in the passed types" do
       relation_spy = subject.except(:includes, :where, :group, :offset)
       applied_types = relation_spy.applied.map(&:type)
-      [ :select, :joins, :order, :having, :limit ].each do |type|
+      [:select, :joins, :order, :having, :limit].each do |type|
         assert_includes type, applied_types
       end
-      [ :includes, :where, :group, :offset ].each do |type|
+      [:includes, :where, :group, :offset].each do |type|
         assert_not_includes type, applied_types
       end
     end
@@ -345,7 +332,6 @@ class Ardb::RelationSpy
       relation_spy = subject.except(:offset)
       assert_nil relation_spy.offset_value
     end
-
   end
 
   class OnlyTests < WithExpressionsTests
@@ -359,28 +345,29 @@ class Ardb::RelationSpy
     should "remove any applied expressions not in the passed types" do
       relation_spy = subject.only(:includes, :where, :group, :offset)
       applied_types = relation_spy.applied.map(&:type)
-      [ :includes, :where, :group, :offset ].each do |type|
+      [:includes, :where, :group, :offset].each do |type|
         assert_includes type, applied_types
       end
-      [ :select, :joins, :order, :having, :limit ].each do |type|
+      [:select, :joins, :order, :having, :limit].each do |type|
         assert_not_includes type, applied_types
       end
     end
 
-    should "unset the limit value if limit is not included in the passed types" do
+    should "unset the limit value if limit is not included in the passed "\
+           "types" do
       relation_spy = subject.only(:limit)
       assert_not_nil relation_spy.limit_value
       relation_spy = subject.only(:select)
       assert_nil relation_spy.limit_value
     end
 
-    should "unset the offset value if offset is not included in the passed types" do
+    should "unset the offset value if offset is not included in the passed "\
+           "types" do
       relation_spy = subject.only(:offset)
       assert_not_nil relation_spy.offset_value
       relation_spy = subject.only(:select)
       assert_nil relation_spy.offset_value
     end
-
   end
 
   class WithResultsTests < UnitTests
@@ -401,11 +388,9 @@ class Ardb::RelationSpy
     should "raise a not found error if a result can't be found" do
       assert_raises(NotFoundError){ subject.find(1000) }
     end
-
   end
 
   class FirstTests < WithResultsTests
-
     should "return the first item from `all` using `first`" do
       assert_equal subject.all.first, subject.first
       subject.offset 2
@@ -418,11 +403,9 @@ class Ardb::RelationSpy
       subject.limit 0
       assert_raises(NotFoundError){ subject.first! }
     end
-
   end
 
   class LastTests < WithResultsTests
-
     should "return the last item from `all` using `last`" do
       assert_equal subject.all.last, subject.last
       subject.limit 2
@@ -435,7 +418,6 @@ class Ardb::RelationSpy
       subject.limit 0
       assert_raises(NotFoundError){ subject.last! }
     end
-
   end
 
   class AllTests < WithResultsTests
@@ -458,7 +440,6 @@ class Ardb::RelationSpy
       subject.offset 2
       assert_equal @results[2, 2], subject.all
     end
-
   end
 
   class CountTests < WithResultsTests
@@ -469,7 +450,6 @@ class Ardb::RelationSpy
       subject.limit 2
       assert_equal subject.all.size, subject.count
     end
-
   end
 
   class PluckTests < WithResultsTests
@@ -484,13 +464,12 @@ class Ardb::RelationSpy
       exp = [@column_value] * @results.size
       assert_equal exp, @relation_spy.pluck(@column_name)
     end
-
   end
 
   class AppliedExpressionTests < UnitTests
     desc "AppliedExpression"
     setup do
-      @applied_expression = AppliedExpression.new(:select, 'column')
+      @applied_expression = AppliedExpression.new(:select, "column")
     end
     subject{ @applied_expression }
 
@@ -501,9 +480,7 @@ class Ardb::RelationSpy
       expected = "#{subject.type}: #{subject.args.inspect}"
       assert_equal expected, subject.to_sql
     end
-
   end
 
   Result = Struct.new(:id)
-
 end

data/test/unit/test_helpers_tests.rb

@@ -1,10 +1,11 @@
-require 'assert'
-require 'ardb/test_helpers'
+# frozen_string_literal: true
 
-require 'ardb/adapter_spy'
+require "assert"
+require "ardb/test_helpers"
 
-module Ardb::TestHelpers
+require "ardb/adapter_spy"
 
+module Ardb::TestHelpers
   class UnitTests < Assert::Context
     desc "Ardb::TestHelpers"
     subject{ Ardb::TestHelpers }
@@ -13,7 +14,6 @@ module Ardb::TestHelpers
     should have_imeths :create_db!, :create_db, :drop_db!, :drop_db
     should have_imeths :connect_db!, :connect_db, :migrate_db!, :migrate_db
     should have_imeths :reset_db, :reset_db!
-
   end
 
   class UsageTests < UnitTests
@@ -21,7 +21,6 @@ module Ardb::TestHelpers
       @adapter_spy = Ardb::AdapterSpy.new
       Assert.stub(Ardb, :adapter){ @adapter_spy }
     end
-
   end
 
   class DropTablesTests < UsageTests
@@ -32,7 +31,6 @@ module Ardb::TestHelpers
       subject.drop_tables
       assert_equal 1, @adapter_spy.drop_tables_called_count
     end
-
   end
 
   class LoadSchemaTests < UsageTests
@@ -43,7 +41,6 @@ module Ardb::TestHelpers
       subject.load_schema
       assert_equal 1, @adapter_spy.load_schema_called_count
     end
-
   end
 
   class CreateDbTests < UsageTests
@@ -64,7 +61,6 @@ module Ardb::TestHelpers
       subject.create_db!
       assert_equal 2, @adapter_spy.create_db_called_count
     end
-
   end
 
   class DropDbTests < UsageTests
@@ -85,7 +81,6 @@ module Ardb::TestHelpers
       subject.drop_db!
       assert_equal 2, @adapter_spy.drop_db_called_count
     end
-
   end
 
   class ConnectDbTests < UsageTests
@@ -106,7 +101,6 @@ module Ardb::TestHelpers
       subject.connect_db!
       assert_equal 2, @adapter_spy.connect_db_called_count
     end
-
   end
 
   class MigrateDbTests < UsageTests
@@ -127,13 +121,13 @@ module Ardb::TestHelpers
       subject.migrate_db!
       assert_equal 2, @adapter_spy.migrate_db_called_count
     end
-
   end
 
   class ResetDbTests < UsageTests
     desc "reset db methods"
 
-    should "tell the adapter to drop/create the db and load the schema only once" do
+    should "tell the adapter to drop/create the db and load the schema "\
+           "only once" do
       assert_equal 0, @adapter_spy.drop_db_called_count
       assert_equal 0, @adapter_spy.create_db_called_count
       assert_equal 0, @adapter_spy.load_schema_called_count
@@ -168,7 +162,5 @@ module Ardb::TestHelpers
       assert_equal 2, @adapter_spy.create_db_called_count
       assert_equal 2, @adapter_spy.load_schema_called_count
     end
-
   end
-
 end

data/test/unit/use_db_default_tests.rb

@@ -1,25 +1,27 @@
-require 'assert'
-require 'ardb/use_db_default'
+# frozen_string_literal: true
 
-require 'much-plugin'
-require 'ardb/record_spy'
+require "assert"
+require "ardb/use_db_default"
 
-module Ardb::UseDbDefault
+require "much-mixin"
+require "ardb/record_spy"
 
+module Ardb::UseDbDefault
   class UnitTests < Assert::Context
     desc "Ardb::UseDbDefault"
     setup do
-      @record_class = Class.new do
-        include UseDbDefaultRecordSpy
-        include Ardb::UseDbDefault
-      end
+      @record_class =
+        Class.new do
+          include UseDbDefaultRecordSpy
+          include Ardb::UseDbDefault
+        end
     end
     subject{ @record_class }
 
     should have_imeths :use_db_default, :ardb_use_db_default_attrs
 
-    should "use much-plugin" do
-      assert_includes MuchPlugin, Ardb::UseDbDefault
+    should "use much-mixin" do
+      assert_includes MuchMixin, Ardb::UseDbDefault
     end
 
     should "know its use db default attrs" do
@@ -27,9 +29,9 @@ module Ardb::UseDbDefault
     end
 
     should "add use db default attributes using `use_db_default`" do
-      attr_name = Factory.string
-      subject.use_db_default(attr_name)
-      assert_includes attr_name, subject.ardb_use_db_default_attrs
+      an_attr_name = Factory.string
+      subject.use_db_default(an_attr_name)
+      assert_includes an_attr_name, subject.ardb_use_db_default_attrs
 
       attr_names = [Factory.string, Factory.string.to_sym]
       subject.use_db_default(*attr_names)
@@ -58,7 +60,6 @@ module Ardb::UseDbDefault
       exp = [:ardb_allow_db_to_default_attrs]
       assert_equal exp, callback.args
     end
-
   end
 
   class InitTests < UnitTests
@@ -70,9 +71,10 @@ module Ardb::UseDbDefault
       @record = @record_class.new
 
       # simulate activerecords `@attributes` hash
-      @original_attrs = @attr_names.inject({}) do |h, n|
-        h.merge!(n => [nil, Factory.string, Factory.integer].sample)
-      end
+      @original_attrs =
+        @attr_names.reduce({}) do |h, n|
+          h.merge!(n => [nil, Factory.string, Factory.integer].sample)
+        end
       @original_attrs.merge!(Factory.string => Factory.string)
       @record.attributes = @original_attrs.dup
 
@@ -83,9 +85,10 @@ module Ardb::UseDbDefault
       # we should always get the record we just inserted back
       @record_class.relation_spy.results = [@record]
       # add pluck values into the relation spy
-      @record_class.relation_spy.pluck_values = @attr_names.inject({}) do |h, n|
-        h.merge!(n => Factory.string)
-      end
+      @record_class.relation_spy.pluck_values =
+        @attr_names.reduce({}) do |h, n|
+          h.merge!(n => Factory.string)
+        end
     end
     subject{ @record }
 
@@ -95,7 +98,9 @@ module Ardb::UseDbDefault
       # when it was created (yielded)
       attrs_before_yield = nil
       subject.instance_eval do
-        ardb_allow_db_to_default_attrs{ attrs_before_yield = self.attributes.dup }
+        ardb_allow_db_to_default_attrs do
+          attrs_before_yield = attributes.dup
+        end
       end
 
       assert_instance_of Hash, attrs_before_yield
@@ -119,7 +124,7 @@ module Ardb::UseDbDefault
 
       applied_expr = @record_class.relation_spy.applied.first
       assert_equal :where, applied_expr.type
-      assert_equal [{ :id => subject.id }], applied_expr.args
+      assert_equal [{ id: subject.id }], applied_expr.args
 
       @unchanged_attr_names.each do |name|
         exp = @record_class.relation_spy.pluck_values[name]
@@ -132,7 +137,6 @@ module Ardb::UseDbDefault
         assert_equal @original_attrs[name], subject.attributes[name]
       end
     end
-
   end
 
   module UseDbDefaultRecordSpy
@@ -144,17 +148,21 @@ module Ardb::UseDbDefault
     attr_accessor :attributes, :changed_use_db_default_attrs
 
     def use_db_default_attr_changed?(attr_name)
-      self.changed_use_db_default_attrs.include?(attr_name)
+      changed_use_db_default_attrs.include?(attr_name)
     end
 
     def method_missing(method, *args, &block)
       match_data = method.to_s.match(/(\w+)_changed\?/)
       if match_data && match_data[1]
-        self.use_db_default_attr_changed?(match_data[1])
+        use_db_default_attr_changed?(match_data[1])
       else
         super
       end
     end
-  end
 
+    def respond_to_missing?(method)
+      match_data = method.to_s.match(/(\w+)_changed\?/)
+      match_data && match_data[1]
+    end
+  end
 end