ardb 0.28.3 → 0.30.0

data/test/unit/db_tests_tests.rb

@@ -1,10 +1,11 @@
-require 'assert'
-require 'ardb/db_tests'
+# frozen_string_literal: true
 
-require 'active_record'
+require "assert"
+require "ardb/db_tests"
 
-class Ardb::DbTests
+require "active_record"
 
+class Ardb::DbTests
   class UnitTests < Assert::Context
     desc "Ardb::DbTests"
     setup do
@@ -20,7 +21,8 @@ class Ardb::DbTests
       assert subject < Assert::Context
     end
 
-    should "add an around callback that runs tests in a transaction that rolls back" do
+    should "add an around callback that runs tests in a transaction that "\
+           "rolls back" do
       assert_equal 1, subject.arounds.size
       callback = subject.arounds.first
 
@@ -31,7 +33,5 @@ class Ardb::DbTests
       assert_true @transaction_called
       assert_true block_yielded_to
     end
-
   end
-
 end

data/test/unit/default_order_by_tests.rb

@@ -1,28 +1,30 @@
-require 'assert'
-require 'ardb/default_order_by'
+# frozen_string_literal: true
 
-require 'much-plugin'
-require 'ardb/record_spy'
+require "assert"
+require "ardb/default_order_by"
 
-module Ardb::DefaultOrderBy
+require "much-mixin"
+require "ardb/record_spy"
 
+module Ardb::DefaultOrderBy
   class UnitTests < Assert::Context
     desc "Ardb::DefaultOrderBy"
     setup do
       order_by_attribute = @order_by_attribute = Factory.string.to_sym
-      @scope_proc = proc{ self.class.where(:grouping => self.grouping) }
-      @record_class = Ardb::RecordSpy.new do
-        include Ardb::DefaultOrderBy
-        attr_accessor order_by_attribute, :grouping
-      end
+      @scope_proc = proc{ self.class.where(grouping: grouping) }
+      @record_class =
+        Ardb::RecordSpy.new do
+          include Ardb::DefaultOrderBy
+          attr_accessor order_by_attribute, :grouping
+        end
     end
     subject{ @record_class }
 
     should have_imeths :default_order_by
     should have_imeths :ardb_default_order_by_config
 
-    should "use much-plugin" do
-      assert_includes MuchPlugin, Ardb::DefaultOrderBy
+    should "use much-mixin" do
+      assert_includes MuchMixin, Ardb::DefaultOrderBy
     end
 
     should "know its default attribute, preprocessor and separator" do
@@ -45,8 +47,8 @@ module Ardb::DefaultOrderBy
 
     should "allow customizing the config using `default_order_by`" do
       subject.default_order_by({
-        :attribute => @order_by_attribute,
-        :scope     => @scope_proc
+        attribute: @order_by_attribute,
+        scope: @scope_proc,
       })
 
       config = subject.ardb_default_order_by_config
@@ -60,20 +62,20 @@ module Ardb::DefaultOrderBy
       callback = subject.callbacks.find{ |v| v.type == :before_validation }
       assert_not_nil callback
       assert_equal [:ardb_default_order_by], callback.args
-      assert_equal({ :on => :create }, callback.options)
+      assert_equal({ on: :create }, callback.options)
     end
-
   end
 
   class InitTests < UnitTests
     desc "when init"
     setup do
       @record_class.default_order_by({
-        :attribute => @order_by_attribute,
-        :scope     => @scope_proc
+        attribute: @order_by_attribute,
+        scope: @scope_proc,
       })
       @current_max = Factory.integer
-      @record_class.relation_spy.maximum_values[@order_by_attribute] = @current_max
+      @record_class.relation_spy.maximum_values[@order_by_attribute] =
+        @current_max
 
       @record = @record_class.new
       @record.grouping = Factory.string
@@ -86,7 +88,8 @@ module Ardb::DefaultOrderBy
       assert_equal @current_max + 1, subject.send(@order_by_attribute)
     end
 
-    should "reset its order-by to a start value when there isn't a current max" do
+    should "reset its order-by to a start value when there isn't a "\
+           "current max" do
       @record_class.relation_spy.maximum_values.delete(@order_by_attribute)
 
       subject.instance_eval{ reset_order_by }
@@ -100,7 +103,7 @@ module Ardb::DefaultOrderBy
       assert_equal 1, @record_class.relation_spy.applied.size
       applied_expression = @record_class.relation_spy.applied.last
       assert_equal :where, applied_expression.type
-      assert_equal [{ :grouping => subject.grouping }], applied_expression.args
+      assert_equal [{ grouping: subject.grouping }], applied_expression.args
     end
 
     should "reset its order-by using `ardb_default_order_by`" do
@@ -109,14 +112,13 @@ module Ardb::DefaultOrderBy
       assert_equal @current_max + 1, subject.send(@order_by_attribute)
     end
 
-    should "not reset its order-by if its already set using `ardb_default_order_by`" do
+    should "not reset its order-by if its already set using "\
+           "`ardb_default_order_by`" do
       current_order_by = Factory.integer
       subject.send("#{@order_by_attribute}=", current_order_by)
       subject.instance_eval{ ardb_default_order_by }
 
       assert_equal current_order_by, subject.send(@order_by_attribute)
     end
-
   end
-
 end

data/test/unit/migration_tests.rb

@@ -1,19 +1,19 @@
-require 'assert'
-require 'ardb/migration'
+# frozen_string_literal: true
 
-# This is needed to call `classify` on a string; if this isn't manually required
-# these tests can fail if activesupport hasn't been loaded by activerecord; the
+require "assert"
+require "ardb/migration"
+
+# This is needed to call `classify` on a string; if this isn"t manually required
+# these tests can fail if activesupport hasn"t been loaded by activerecord; the
 # `Migration` class will error saying `classify` is not a method on `String`
-require 'active_support/core_ext/string/inflections'
+require "active_support/core_ext/string/inflections"
 
 class Ardb::Migration
-
   class UnitTests < Assert::Context
     desc "Ardb::Migration"
     setup do
       @migration_class = Ardb::Migration
     end
-
   end
 
   class InitTests < UnitTests
@@ -38,7 +38,7 @@ class Ardb::Migration
     end
     subject{ @migration }
 
-    should have_readers  :migrations_path, :identifier
+    should have_readers :migrations_path, :identifier
     should have_readers :class_name, :file_name, :file_path, :source
     should have_imeths :save!
 
@@ -55,18 +55,19 @@ class Ardb::Migration
       exp = File.join(subject.migrations_path, "#{subject.file_name}.rb")
       assert_equal exp, subject.file_path
 
-      exp = "require 'ardb/migration_helpers'\n\n" \
-            "class #{subject.class_name} < ActiveRecord::Migration\n" \
-            "  include Ardb::MigrationHelpers\n\n" \
-            "  def change\n" \
-            "  end\n\n" \
-            "end\n"
+      exp_version = ActiveRecord::Migration.current_version
+      exp =
+        "class #{subject.class_name} "\
+        "< ActiveRecord::Migration[#{exp_version}]\n" \
+        "  def change\n" \
+        "  end\n" \
+        "end\n"
       assert_equal exp, subject.source
     end
 
     should "complain if no identifier is provided" do
       assert_raises(NoIdentifierError) do
-        @migration_class.new(@ardb_config, [nil, ''].sample)
+        @migration_class.new(@ardb_config, [nil, ""].sample)
       end
     end
 
@@ -74,10 +75,9 @@ class Ardb::Migration
       subject.save!
 
       assert_equal [subject.migrations_path], @mkdir_called_with
-      assert_equal [subject.file_path, 'w'],  @file_open_called_with
+      assert_equal [subject.file_path, "w"],  @file_open_called_with
       assert_equal [subject.source],          @file_spy.write_called_with
     end
-
   end
 
   class FileSpy
@@ -91,5 +91,4 @@ class Ardb::Migration
       @write_called_with = args
     end
   end
-
 end

data/test/unit/record_spy_tests.rb

@@ -1,17 +1,19 @@
-require 'assert'
-require 'ardb/record_spy'
+# frozen_string_literal: true
 
-require 'much-plugin'
+require "assert"
+require "ardb/record_spy"
 
-module Ardb::RecordSpy
+require "much-mixin"
 
+module Ardb::RecordSpy
   class UnitTests < Assert::Context
     desc "Ardb::RecordSpy"
     setup do
-      @record_spy_class = Class.new do
-        include Ardb::RecordSpy
-        attr_accessor :name
-      end
+      @record_spy_class =
+        Class.new do
+          include Ardb::RecordSpy
+          attr_accessor :name
+        end
     end
     subject{ @record_spy_class }
 
@@ -41,13 +43,13 @@ module Ardb::RecordSpy
     should have_imeths :group, :having, :order, :reverse_order, :readonly
     should have_imeths :limit, :offset, :merge, :except, :only
 
-    should "use much-plugin" do
-      assert_includes MuchPlugin, Ardb::RecordSpy
+    should "use much-mixin" do
+      assert_includes MuchMixin, Ardb::RecordSpy
     end
 
     should "allow reading and writing the record's table name" do
-      subject.table_name = 'my_records'
-      assert_equal 'my_records', subject.table_name
+      subject.table_name = "my_records"
+      assert_equal "my_records", subject.table_name
     end
 
     should "default its associations" do
@@ -55,7 +57,7 @@ module Ardb::RecordSpy
     end
 
     should "add an association config with #belongs_to" do
-      subject.belongs_to :area, :foreign_key => :area_id
+      subject.belongs_to :area, foreign_key: :area_id
       association = subject.associations.last
       assert_equal :belongs_to, association.type
       assert_equal :area,       association.name
@@ -63,7 +65,7 @@ module Ardb::RecordSpy
     end
 
     should "add an association config with #has_many" do
-      subject.has_many :comments, :as => :parent
+      subject.has_many :comments, as: :parent
       association = subject.associations.last
       assert_equal :has_many, association.type
       assert_equal :comments, association.name
@@ -71,19 +73,19 @@ module Ardb::RecordSpy
     end
 
     should "add an association config with #has_one" do
-      subject.has_one :linking, :class_name => 'Linking'
+      subject.has_one :linking, class_name: "Linking"
       association = subject.associations.last
       assert_equal :has_one,  association.type
       assert_equal :linking,  association.name
-      assert_equal 'Linking', association.options[:class_name]
+      assert_equal "Linking", association.options[:class_name]
     end
 
     should "default its validations" do
       assert_equal [], subject.validations
     end
 
-    should "add a validation config for '*_of' validations" do
-      subject.validates_presence_of :name, :email, :on => :create
+    should "add a validation config for \"*_of\" validations" do
+      subject.validates_presence_of :name, :email, on: :create
       validation = subject.validations.last
       assert_equal :presence, validation.type
       assert_equal :create,   validation.options[:on]
@@ -110,7 +112,7 @@ module Ardb::RecordSpy
     end
 
     should "add a validation config with #validates_each" do
-      block = proc{ }
+      block = proc{}
       subject.validates_each(:name, :email, &block)
       validation = subject.validations.last
       assert_equal :each, validation.type
@@ -125,7 +127,7 @@ module Ardb::RecordSpy
       assert_equal :custom,      validation.type
       assert_equal :some_method, validation.method_name
 
-      block = proc{ }
+      block = proc{}
       subject.validate(&block)
       validation = subject.validations.last
       assert_equal :custom, validation.type
@@ -144,15 +146,15 @@ module Ardb::RecordSpy
     end
 
     should "add a callback config with a block" do
-      subject.before_validation(:on => :create) do
-        self.name = 'test'
+      subject.before_validation(on: :create) do
+        self.name = "test"
       end
       callback = subject.callbacks.last
       assert_equal :before_validation, callback.type
       assert_equal :create, callback.options[:on]
       record_spy = subject.new
       record_spy.instance_eval(&callback.block)
-      assert_equal 'test', record_spy.name
+      assert_equal "test", record_spy.name
     end
 
     should "default its custom callback types" do
@@ -177,7 +179,12 @@ module Ardb::RecordSpy
       assert_respond_to "around_#{name}", subject
       assert_respond_to "after_#{name}",  subject
 
-      callback_name = ["before_#{name}", "around_#{name}", "after_#{name}"].sample
+      callback_name =
+        [
+          "before_#{name}",
+          "around_#{name}",
+          "after_#{name}",
+        ].sample
       method_name = Factory.string
       subject.send(callback_name, method_name)
       callback = subject.callbacks.last
@@ -185,7 +192,7 @@ module Ardb::RecordSpy
       assert_equal [method_name],        callback.args
 
       name = Factory.string
-      subject.define_model_callbacks(name, :only => [:before])
+      subject.define_model_callbacks(name, only: [:before])
 
       assert_respond_to "before_#{name}", subject
       assert_not_respond_to "around_#{name}", subject
@@ -286,15 +293,15 @@ module Ardb::RecordSpy
       subject.only(*only_args)
       assert_equal only_args, only_called_with
     end
-
   end
 
   class GeneratorTests < UnitTests
     desc "to generate record spy classes"
     setup do
-      @record_spy_class = Ardb::RecordSpy.new do
-        attr_accessor :name
-      end
+      @record_spy_class =
+        Ardb::RecordSpy.new do
+          attr_accessor :name
+        end
       @instance = @record_spy_class.new
     end
     subject{ @record_spy_class }
@@ -305,7 +312,6 @@ module Ardb::RecordSpy
       assert @instance.respond_to? :name
       assert @instance.respond_to? :name=
     end
-
   end
 
   class InstanceTests < UnitTests
@@ -319,24 +325,24 @@ module Ardb::RecordSpy
     should have_imeths :manually_run_callbacks, :run_callbacks
 
     should "allow spying the update_column method by just writing the value" do
-      assert_not_equal 'updated', subject.name
+      assert_not_equal "updated", subject.name
 
-      subject.update_column(:name, 'updated')
-      assert_equal 'updated', subject.name
+      subject.update_column(:name, "updated")
+      assert_equal "updated", subject.name
     end
 
     should "have accessors for each association defined" do
       assert_nil subject.bt_thing
-      subject.bt_thing = 'something'
-      assert_equal 'something', subject.bt_thing
+      subject.bt_thing = "something"
+      assert_equal "something", subject.bt_thing
 
       assert_nil subject.ho_thing
-      subject.ho_thing = 'other thing'
-      assert_equal 'other thing', subject.ho_thing
+      subject.ho_thing = "other thing"
+      assert_equal "other thing", subject.ho_thing
 
       assert_empty subject.hm_things
-      subject.hm_things = [1,2,3]
-      assert_equal [1,2,3], subject.hm_things
+      subject.hm_things = [1, 2, 3]
+      assert_equal [1, 2, 3], subject.hm_things
     end
 
     should "default its manually run callbacks" do
@@ -355,7 +361,6 @@ module Ardb::RecordSpy
       assert_includes name, subject.manually_run_callbacks
       assert_true block_called
     end
-
   end
 
   class MyRecord
@@ -366,5 +371,4 @@ module Ardb::RecordSpy
     has_one    :ho_thing
     has_many   :hm_things
   end
-
 end