appsignal 2.1.0.alpha.3 → 2.1.0.beta.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba449b5302a9acfc332aad78fb6a6ab029a3e7df
-  data.tar.gz: 2e283a5dcd46c361a34cabdff738d37d6722bc49
+  metadata.gz: ae60c35e104278641d1b44e7f90901f0839b3a24
+  data.tar.gz: e7c98edcf3b9c7e66b7d8fdc7d601d53b00512d9
 SHA512:
-  metadata.gz: e256ee143c3495ddee41754fdbe31597ca2d93b50f95dc89a81570e2b147169c5b4b4087361014ab9b9b9ef156fee9e2df1fcbf8302a106a3ca15a428acd6dbe
-  data.tar.gz: 516440b26242a76d90003621dc0cff471c2d2b4f420c3b1aeebc8e695661d99edf8cf2b24261d2197fe0ac007be2cc32fa8a4617ce63815b0f822f90f97d36bc
+  metadata.gz: 829e1eb8cdac7e35ad52067529d2d5ce50495cc0fa95ea5a6d80e6878dba3396a82c0ffa73d8b0c691b4ff472ccd57e3592e96c823786ec7ebd22666456313fd
+  data.tar.gz: 7887a42b3b30b818bc26337f50963d487e8af94be03315e908126bb8dda5bb850c62a48acfd1232bdf63dc2d86ae3a0cc9eabbeb0473634b5690878006d5a6e8

data/.gitignore

@@ -3,6 +3,7 @@
 .sass-cache
 capybara-*.html
 *.log
+/doc
 /.bundle
 /vendor/bundle
 /tmp/*

data/.rubocop.yml

@@ -0,0 +1,43 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  TargetRubyVersion: 1.9
+  Include:
+    - "Gemfile"
+  Exclude:
+    - "tmp/**/*"
+    - "gemfiles/vendor/**/*"
+    - "vendor/**/*"
+  DisplayCopNames: true
+  UseCache: true
+  CacheRootDirectory: ./tmp
+
+Style/Documentation:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+
+Style/AlignParameters:
+  EnforcedStyle: with_fixed_indentation
+
+Style/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets
+
+Style/AlignHash:
+  EnforcedLastArgumentHashStyle: ignore_implicit
+
+Style/IndentArray:
+  EnforcedStyle: consistent
+
+# Metrics/LineLength:
+#   Max: 80

data/.rubocop_todo.yml

@@ -0,0 +1,289 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-12-27 13:45:00 +0100 using RuboCop version 0.46.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 6
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'lib/appsignal/config.rb'
+    - 'lib/appsignal/transaction.rb'
+
+# Offense count: 7
+Lint/HandleExceptions:
+  Exclude:
+    - 'lib/appsignal/cli/install.rb'
+    - 'spec/lib/appsignal/hooks/shoryuken_spec.rb'
+    - 'spec/lib/appsignal/hooks/sidekiq_spec.rb'
+    - 'spec/lib/appsignal/integrations/resque_spec.rb'
+
+# Offense count: 1
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'lib/appsignal/garbage_collection_profiler.rb'
+
+# Offense count: 4
+Lint/RescueException:
+  Exclude:
+    - 'lib/appsignal/minutely.rb'
+    - 'lib/appsignal/rack/streaming_listener.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Lint/UnifiedInteger:
+  Exclude:
+    - 'lib/appsignal/utils.rb'
+    - 'lib/appsignal/utils/params_sanitizer.rb'
+
+# Offense count: 36
+Metrics/AbcSize:
+  Max: 59
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/BlockLength:
+  Max: 31
+
+# Offense count: 4
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 263
+
+# Offense count: 14
+Metrics/CyclomaticComplexity:
+  Max: 11
+
+# Offense count: 378
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 456
+
+# Offense count: 77
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 60
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Exclude:
+    - "lib/appsignal.rb"
+
+# Offense count: 8
+Metrics/PerceivedComplexity:
+  Max: 15
+
+# Offense count: 7
+Style/AccessorMethodName:
+  Exclude:
+    - 'lib/appsignal.rb'
+    - 'lib/appsignal/transaction.rb'
+    - 'spec/support/helpers/cli_helpers.rb'
+
+# Offense count: 19
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: prefer_alias, prefer_alias_method
+Style/Alias:
+  Exclude:
+    - 'lib/appsignal.rb'
+    - 'lib/appsignal/hooks/active_support_notifications.rb'
+    - 'lib/appsignal/hooks/celluloid.rb'
+    - 'lib/appsignal/hooks/net_http.rb'
+    - 'lib/appsignal/hooks/puma.rb'
+    - 'lib/appsignal/hooks/rake.rb'
+    - 'lib/appsignal/hooks/redis.rb'
+    - 'lib/appsignal/hooks/unicorn.rb'
+    - 'lib/appsignal/hooks/webmachine.rb'
+    - 'lib/appsignal/transaction.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: always, conditionals
+Style/AndOr:
+  Exclude:
+    - 'lib/appsignal.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'lib/appsignal/integrations/padrino.rb'
+    - 'lib/appsignal/integrations/webmachine.rb'
+
+# Offense count: 3
+Style/ClassVars:
+  Exclude:
+    - 'lib/appsignal/event_formatter.rb'
+    - 'lib/appsignal/minutely.rb'
+
+# Offense count: 1
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/appsignal.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, expanded
+Style/EmptyMethod:
+  Exclude:
+    - 'lib/appsignal/transaction.rb'
+    - 'spec/lib/appsignal/event_formatter_spec.rb'
+    - 'spec/lib/appsignal/hooks/mongo_ruby_driver_spec.rb'
+    - 'spec/lib/appsignal/hooks/puma_spec.rb'
+    - 'spec/lib/appsignal/hooks/unicorn_spec.rb'
+    - 'spec/lib/appsignal/integrations/data_mapper_spec.rb'
+    - 'spec/lib/appsignal/integrations/resque_active_job_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/appsignal.rb'
+    - 'lib/appsignal/event_formatter.rb'
+    - 'lib/appsignal/event_formatter/moped/query_formatter.rb'
+    - 'lib/appsignal/hooks.rb'
+    - 'lib/appsignal/marker.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/appsignal.rb'
+    - 'lib/appsignal/garbage_collection_profiler.rb'
+
+# Offense count: 2
+Style/MethodMissing:
+  Exclude:
+    - 'lib/appsignal/extension.rb'
+    - 'lib/appsignal/transaction.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MultilineIfModifier:
+  Exclude:
+    - 'lib/appsignal/js_exception_transaction.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Exclude:
+    - 'ext/extconf.rb'
+    - 'lib/appsignal/event_formatter/mongo_ruby_driver/query_formatter.rb'
+    - 'lib/appsignal/integrations/data_mapper.rb'
+    - 'lib/appsignal/marker.rb'
+    - 'lib/appsignal/transaction.rb'
+    - 'lib/appsignal/transmitter.rb'
+    - 'lib/appsignal/version.rb'
+    - 'spec/lib/appsignal/hooks/mongo_ruby_driver_spec.rb'
+    - 'spec/lib/appsignal/hooks/redis_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+# SupportedStyles: skip_modifier_ifs, always
+Style/Next:
+  Exclude:
+    - 'ext/extconf.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IncludeSemanticChanges.
+Style/NonNilCheck:
+  Exclude:
+    - 'lib/appsignal/transaction.rb'
+
+# Offense count: 20
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
+# SupportedOctalStyles: zero_with_o, zero_only
+Style/NumericLiteralPrefix:
+  Exclude:
+    - 'ext/extconf.rb'
+    - 'spec/lib/appsignal/cli/diagnose_spec.rb'
+    - 'spec/lib/appsignal/config_spec.rb'
+    - 'spec/lib/appsignal/system/container_spec.rb'
+    - 'spec/lib/appsignal/transmitter_spec.rb'
+    - 'spec/lib/appsignal_spec.rb'
+    - 'spec/support/helpers/time_helpers.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/appsignal/cli/diagnose.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Exclude:
+    - 'lib/appsignal/system.rb'
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/appsignal.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, exploded
+Style/RaiseArgs:
+  Exclude:
+    - 'lib/appsignal/utils.rb'
+    - 'spec/lib/appsignal/integrations/resque_spec.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Exclude:
+    - 'spec/lib/appsignal/integrations/padrino_spec.rb'
+    - 'spec/lib/appsignal/rack/generic_instrumentation_spec.rb'
+    - 'spec/lib/appsignal/rack/rails_instrumentation_spec.rb'
+    - 'spec/lib/appsignal/rack/sinatra_instrumentation_spec.rb'
+    - 'spec/lib/appsignal/rack/streaming_listener_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  Exclude:
+    - 'lib/appsignal.rb'
+    - 'lib/appsignal/config.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/UnlessElse:
+  Exclude:
+    - 'lib/appsignal.rb'
+
+# Offense count: 16
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, MinSize, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  Exclude:
+    - 'lib/appsignal/cli/install.rb'
+    - 'spec/lib/appsignal/config_spec.rb'
+    - 'spec/lib/appsignal/hooks/shoryuken_spec.rb'
+    - 'spec/lib/appsignal/hooks/sidekiq_spec.rb'
+    - 'spec/lib/appsignal/transaction_spec.rb'
+    - 'spec/lib/appsignal/utils/query_params_sanitizer_spec.rb'

data/.travis.yml

@@ -33,6 +33,10 @@ gemfile:
 
 matrix:
   fast_finish: true
+  include:
+    - rvm: "2.3.0"
+      gemfile: "gemfiles/no_dependencies.gemfile"
+      script: "bundle exec rubocop"
   exclude:
     - rvm: "2.0.0"
       gemfile: "gemfiles/rails-5.0.gemfile"

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # 2.1.0
-* Add support for musl libc
+* Add support for musl based libc (Alpine Linux). PR #229
+* Implement `Appsignal.is_ignored_error?` and `Appsignal.is_ignored_action?`
+  logic in the AppSignal extension. PR #224
+* Deprecate `Appsignal.is_ignored_error?`. PR #224
+* Deprecate `Appsignal.is_ignored_action?`. PR #224
+* Enforce a coding styleguide with RuboCop. PR #226
+
+# 2.0.5
+* Improved logging for agent connection issues.
+  Commit cdf9d3286d704e22473eb901c839cab4fab45a6f
+* Handle nil request/environments in transactions. PR #231
 
 # 2.0.4
 * Use consistent log format for both file and STDOUT logs. PR #203

data/Gemfile

@@ -1,3 +1,3 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012-2013 AppSignal
+Copyright (c) 2012-2017 AppSignal
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/appsignal.gemspec

@@ -31,4 +31,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'pry'
   gem.add_development_dependency 'timecop'
   gem.add_development_dependency 'webmock'
+  gem.add_development_dependency 'rubocop', '0.46.0'
 end

data/bin/appsignal

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-$LOAD_PATH << File.expand_path(File.join(File.dirname(__FILE__), '..','lib'))
-require 'appsignal/cli'
+$LOAD_PATH << File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
+require "appsignal/cli"
 
 begin
   Appsignal::CLI.run

data/ext/agent.yml

@@ -1,18 +1,18 @@
 ---
-version: 65936ce
+version: 5f0c552
 triples:
   x86_64-linux:
-    checksum: b727df7862e9849788f76b3d8640d03ec4fde382da70e8d7f388ffa56e170d84
-    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/65936ce/appsignal-x86_64-linux-all-static.tar.gz
+    checksum: ded20da060a8c05c7551e9d86067ce7eecefca4ee3f8ddf286f79146d0895fd1
+    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/5f0c552/appsignal-x86_64-linux-all-static.tar.gz
   i686-linux:
-    checksum: c9ec34f8f70ffe00e109f6a01d73fc17449ba965957fa8edec54ba2bcab75578
-    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/65936ce/appsignal-i686-linux-all-static.tar.gz
+    checksum: 0332a1d256612b6230212ab5c503b53cf7e4121ff14c9df481d5a08545da89ba
+    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/5f0c552/appsignal-i686-linux-all-static.tar.gz
   x86-linux:
-    checksum: c9ec34f8f70ffe00e109f6a01d73fc17449ba965957fa8edec54ba2bcab75578
-    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/65936ce/appsignal-i686-linux-all-static.tar.gz
+    checksum: 0332a1d256612b6230212ab5c503b53cf7e4121ff14c9df481d5a08545da89ba
+    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/5f0c552/appsignal-i686-linux-all-static.tar.gz
   x86_64-darwin:
-    checksum: dec1ec6196f0b463e660b1bc5bee9200c40b5a2d5e6900e64dc1bc44a17c240b
-    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/65936ce/appsignal-x86_64-darwin-all-static.tar.gz
+    checksum: f4eaf9ef17f0c95adcc3b853f00134b28e1a50e33db48677dc3adfcbe48b14b4
+    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/5f0c552/appsignal-x86_64-darwin-all-static.tar.gz
   universal-darwin:
-    checksum: dec1ec6196f0b463e660b1bc5bee9200c40b5a2d5e6900e64dc1bc44a17c240b
-    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/65936ce/appsignal-x86_64-darwin-all-static.tar.gz
+    checksum: f4eaf9ef17f0c95adcc3b853f00134b28e1a50e33db48677dc3adfcbe48b14b4
+    download_url: https://appsignal-agent-releases.global.ssl.fastly.net/5f0c552/appsignal-x86_64-darwin-all-static.tar.gz

data/ext/extconf.rb

@@ -1,29 +1,29 @@
-require 'digest'
-require 'logger'
-require 'fileutils'
-require 'open-uri'
-require 'zlib'
-require 'rubygems/package'
-require 'yaml'
-require File.expand_path('../../lib/appsignal/version.rb', __FILE__)
+require "digest"
+require "logger"
+require "fileutils"
+require "open-uri"
+require "zlib"
+require "rubygems/package"
+require "yaml"
+require File.expand_path("../../lib/appsignal/version.rb", __FILE__)
 
-EXT_PATH     = File.expand_path('..', __FILE__)
-AGENT_CONFIG = YAML.load(File.read(File.join(EXT_PATH, 'agent.yml')))
+EXT_PATH     = File.expand_path("..", __FILE__)
+AGENT_CONFIG = YAML.load(File.read(File.join(EXT_PATH, "agent.yml")))
 ARCH         = "#{Gem::Platform.local.cpu}-#{Gem::Platform.local.os}"
-CA_CERT_PATH = File.join(EXT_PATH, '../resources/cacert.pem')
+CA_CERT_PATH = File.join(EXT_PATH, "../resources/cacert.pem")
 
 def ext_path(path)
   File.join(EXT_PATH, path)
 end
 
 def logger
-  @logger ||= Logger.new(File.join(EXT_PATH, 'install.log'))
+  @logger ||= Logger.new(File.join(EXT_PATH, "install.log"))
 end
 
 def installation_failed(reason)
   logger.error "Installation failed: #{reason}"
-  File.open(File.join(EXT_PATH, 'Makefile'), 'w') do |file|
-      file.write "default:\nclean:\ninstall:"
+  File.open(File.join(EXT_PATH, "Makefile"), "w") do |file|
+    file.write "default:\nclean:\ninstall:"
   end
 end
 
@@ -37,7 +37,7 @@ def install
     return
   end
 
-  unless AGENT_CONFIG['triples'].keys.include?(ARCH)
+  unless AGENT_CONFIG["triples"].keys.include?(ARCH)
     installation_failed(
       "AppSignal currently does not support your system architecture (#{ARCH})." \
       "Please let us know at support@appsignal.com, we aim to support everything our customers run."
@@ -45,21 +45,21 @@ def install
     return
   end
 
-  arch_config = AGENT_CONFIG['triples'][ARCH]
+  arch_config = AGENT_CONFIG["triples"][ARCH]
 
-  unless File.exist?(ext_path('appsignal-agent')) &&
-           File.exist?(ext_path('libappsignal.a')) &&
-           File.exist?(ext_path('appsignal.h'))
-    logger.info "Downloading agent release from #{arch_config['download_url']}"
+  unless File.exist?(ext_path("appsignal-agent")) &&
+      File.exist?(ext_path("libappsignal.a")) &&
+      File.exist?(ext_path("appsignal.h"))
+    logger.info "Downloading agent release from #{arch_config["download_url"]}"
 
-    archive = open(arch_config['download_url'], :ssl_ca_cert => CA_CERT_PATH)
+    archive = open(arch_config["download_url"], :ssl_ca_cert => CA_CERT_PATH)
 
-    if Digest::SHA256.hexdigest(archive.read) == arch_config['checksum']
-      logger.info 'Checksum of downloaded archive verified, extracting archive'
+    if Digest::SHA256.hexdigest(archive.read) == arch_config["checksum"]
+      logger.info "Checksum of downloaded archive verified, extracting archive"
     else
       installation_failed(
         "Aborting installation, checksum of downloaded archive could not be verified: " \
-        "Expected '#{arch_config['checksum']}', got '#{checksum}'."
+        "Expected '#{arch_config["checksum"]}', got '#{checksum}'."
       )
       return
     end
@@ -67,24 +67,24 @@ def install
     Gem::Package::TarReader.new(Zlib::GzipReader.open(archive)) do |tar|
       tar.each do |entry|
         if entry.file?
-          File.open(ext_path(entry.full_name), 'wb') do |f|
+          File.open(ext_path(entry.full_name), "wb") do |f|
             f.write(entry.read)
           end
         end
       end
     end
-    FileUtils.chmod(0755, ext_path('appsignal-agent'))
+    FileUtils.chmod(0755, ext_path("appsignal-agent"))
   end
 
   logger.info "Creating makefile"
-  require 'mkmf'
-  if !have_library('appsignal', 'appsignal_start', 'appsignal.h')
-    installation_failed 'Aborting installation, libappsignal.a or appsignal.h not found'
-  elsif !find_executable('appsignal-agent', EXT_PATH)
-    installation_failed 'Aborting installation, appsignal-agent not found'
+  require "mkmf"
+  if !have_library("appsignal", "appsignal_start", "appsignal.h")
+    installation_failed "Aborting installation, libappsignal.a or appsignal.h not found"
+  elsif !find_executable("appsignal-agent", EXT_PATH)
+    installation_failed "Aborting installation, appsignal-agent not found"
   else
-    create_makefile 'appsignal_extension'
-    logger.info 'Successfully created Makefile for appsignal extension'
+    create_makefile "appsignal_extension"
+    logger.info "Successfully created Makefile for appsignal extension"
   end
 rescue => ex
   installation_failed "Exception while installing: #{ex}"