appsignal 2.1.0.alpha.3 → 2.1.0.beta.1

data/lib/appsignal/hooks/passenger.rb

@@ -8,12 +8,12 @@ module Appsignal
       end
 
       def install
-        ::PhusionPassenger.on_event(:starting_worker_process) do |forked|
+        ::PhusionPassenger.on_event(:starting_worker_process) do |_forked|
           Appsignal.forked
         end
 
         ::PhusionPassenger.on_event(:stopping_worker_process) do
-          Appsignal.stop('passenger')
+          Appsignal.stop("passenger")
         end
       end
     end

data/lib/appsignal/hooks/puma.rb

@@ -11,20 +11,20 @@ module Appsignal
 
       def install
         ::Puma.cli_config.options[:before_worker_boot] ||= []
-        ::Puma.cli_config.options[:before_worker_boot] << Proc.new do |id|
+        ::Puma.cli_config.options[:before_worker_boot] << proc do |_id|
           Appsignal.forked
         end
 
         ::Puma.cli_config.options[:before_worker_shutdown] ||= []
-        ::Puma.cli_config.options[:before_worker_shutdown] << Proc.new do |id|
-          Appsignal.stop('puma before_worker_shutdown')
+        ::Puma.cli_config.options[:before_worker_shutdown] << proc do |_id|
+          Appsignal.stop("puma before_worker_shutdown")
         end
 
         ::Puma::Cluster.class_eval do
           alias stop_workers_without_appsignal stop_workers
 
           def stop_workers
-            Appsignal.stop('puma cluster')
+            Appsignal.stop("puma cluster")
             stop_workers_without_appsignal
           end
         end

data/lib/appsignal/hooks/rake.rb

@@ -24,7 +24,7 @@ module Appsignal
             transaction.set_action(name)
             transaction.set_error(error)
             transaction.complete
-            Appsignal.stop('rake')
+            Appsignal.stop("rake")
             raise error
           end
         end

data/lib/appsignal/hooks/redis.rb

@@ -14,7 +14,7 @@ module Appsignal
           alias process_without_appsignal process
 
           def process(commands, &block)
-            Appsignal.instrument 'query.redis' do
+            Appsignal.instrument "query.redis" do
               process_without_appsignal(commands, &block)
             end
           end

data/lib/appsignal/hooks/sequel.rb

@@ -4,7 +4,7 @@ module Appsignal
       # Add query instrumentation
       def log_yield(sql, args = nil)
         Appsignal.instrument(
-          'sql.sequel',
+          "sql.sequel",
           nil,
           sql,
           Appsignal::EventFormatter::SQL_BODY_FORMAT
@@ -18,7 +18,7 @@ module Appsignal
       # Add query instrumentation
       def log_connection_yield(sql, conn, args = nil)
         Appsignal.instrument(
-          'sql.sequel',
+          "sql.sequel",
           nil,
           sql,
           Appsignal::EventFormatter::SQL_BODY_FORMAT

data/lib/appsignal/hooks/shoryuken.rb

@@ -1,23 +1,23 @@
 module Appsignal
   class Hooks
     class ShoryukenMiddleware
-      def call(worker_instance, queue, sqs_msg, body)
+      def call(_worker_instance, queue, sqs_msg, body)
         metadata = {
           :queue => queue
         }
-        exclude_keys = [ :job_class, :queue_name, :arguments ]
-        metadata.merge!(body.reject{ |key| exclude_keys.member?(key.to_sym) })
+        exclude_keys = [:job_class, :queue_name, :arguments]
+        metadata.merge!(body.reject { |key| exclude_keys.member?(key.to_sym) })
         metadata.merge!(sqs_msg.attributes)
 
         options = {
-          :class => body['job_class'],
-          :method => 'perform',
+          :class => body["job_class"],
+          :method => "perform",
           :metadata => metadata
         }
-        options[:params] = body['arguments'] if body.key?('arguments')
-        options[:queue_start] = Time.at(sqs_msg.attributes['SentTimestamp'].to_i / 1000) if sqs_msg.attributes.key?('SentTimestamp')
+        options[:params] = body["arguments"] if body.key?("arguments")
+        options[:queue_start] = Time.at(sqs_msg.attributes["SentTimestamp"].to_i / 1000) if sqs_msg.attributes.key?("SentTimestamp")
 
-        Appsignal.monitor_transaction('perform_job.shoryuken', options) do
+        Appsignal.monitor_transaction("perform_job.shoryuken", options) do
           yield
         end
       end

data/lib/appsignal/hooks/sidekiq.rb

@@ -5,28 +5,29 @@ module Appsignal
 
       def job_keys
         @job_keys ||= Set.new(%w(
-            class args retried_at failed_at
-            error_message error_class backtrace
-            error_backtrace enqueued_at retry
-            jid retry created_at wrapped
+          class args retried_at failed_at
+          error_message error_class backtrace
+          error_backtrace enqueued_at retry
+          jid retry created_at wrapped
         ))
       end
 
-      def call(worker, item, queue)
-        if item['class'] == 'ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper'
-          params = format_args(item['args'].first['arguments'])
-        else
-          params = format_args(item['args'])
-        end
+      def call(_worker, item, _queue)
+        params =
+          if item["class"] == "ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper"
+            format_args(item["args"].first["arguments"])
+          else
+            format_args(item["args"])
+          end
 
         Appsignal.monitor_transaction(
-          'perform_job.sidekiq',
-          :class       => item['wrapped'] || item['class'],
-          :method      => 'perform',
+          "perform_job.sidekiq",
+          :class       => item["wrapped"] || item["class"],
+          :method      => "perform",
           :metadata    => formatted_metadata(item),
           :params      => params,
-          :queue_start => item['enqueued_at'],
-          :queue_time  => (Time.now.to_f - item['enqueued_at'].to_f) * 1000
+          :queue_start => item["enqueued_at"],
+          :queue_time  => (Time.now.to_f - item["enqueued_at"].to_f) * 1000
         ) do
           yield
         end

data/lib/appsignal/hooks/unicorn.rb

@@ -29,7 +29,7 @@ module Appsignal
           alias close_without_appsignal close
 
           def close
-            Appsignal.stop('unicorn')
+            Appsignal.stop("unicorn")
             close_without_appsignal
           end
         end

data/lib/appsignal/hooks/webmachine.rb

@@ -8,7 +8,7 @@ module Appsignal
       end
 
       def install
-        require 'appsignal/integrations/webmachine'
+        require "appsignal/integrations/webmachine"
         ::Webmachine::Decision::FSM.class_eval do
           include Appsignal::Integrations::WebmachinePlugin::FSM
           alias run_without_appsignal run

data/lib/appsignal/integrations/capistrano/capistrano_2_tasks.rb

@@ -2,17 +2,17 @@ module Appsignal
   class Capistrano
     def self.tasks(config)
       config.load do
-        after 'deploy', 'appsignal:deploy'
-        after 'deploy:migrations', 'appsignal:deploy'
+        after "deploy", "appsignal:deploy"
+        after "deploy:migrations", "appsignal:deploy"
 
         namespace :appsignal do
           task :deploy do
-            env = fetch(:appsignal_env, fetch(:stage, fetch(:rails_env, fetch(:rack_env, 'production'))))
-            user = ENV['USER'] || ENV['USERNAME']
+            env = fetch(:appsignal_env, fetch(:stage, fetch(:rails_env, fetch(:rack_env, "production"))))
+            user = ENV["USER"] || ENV["USERNAME"]
             revision = fetch(:appsignal_revision, fetch(:current_revision))
 
             appsignal_config = Appsignal::Config.new(
-              ENV['PWD'],
+              ENV["PWD"],
               env,
               fetch(:appsignal_config, {}),
               Logger.new(StringIO.new)
@@ -26,7 +26,7 @@ module Appsignal
 
               marker = Marker.new(marker_data, appsignal_config)
               if config.dry_run
-                puts 'Dry run: AppSignal deploy marker not actually sent.'
+                puts "Dry run: AppSignal deploy marker not actually sent."
               else
                 marker.transmit
               end

data/lib/appsignal/integrations/data_mapper.rb

@@ -20,15 +20,14 @@ module Appsignal
 
         # Record event
         Appsignal::Transaction.current.record_event(
-          'query.data_mapper',
-          'DataMapper Query',
+          "query.data_mapper",
+          "DataMapper Query",
           body_content,
           message.duration,
           body_format
         )
         super
       end
-
     end
   end
 end

data/lib/appsignal/integrations/delayed_job_plugin.rb

@@ -8,8 +8,8 @@ module Appsignal
           invoke_with_instrumentation(job, block)
         end
 
-        lifecycle.after(:execute) do |execute|
-          Appsignal.stop('delayed job')
+        lifecycle.after(:execute) do |_execute|
+          Appsignal.stop("delayed job")
         end
       end
 
@@ -17,18 +17,18 @@ module Appsignal
         if job.respond_to?(:payload_object)
           # Direct Delayed Job
           class_and_method_name = extract_value(job.payload_object, :appsignal_name, job.name)
-          class_name, method_name = class_and_method_name.split('#')
+          class_name, method_name = class_and_method_name.split("#")
           args = extract_value(job.payload_object, :args, {})
           job_data = job
         elsif job.respond_to?(:job_data)
           # Via ActiveJob
-          class_name, method_name = job.job_data[:name].split('#')
+          class_name, method_name = job.job_data[:name].split("#")
           args = job.job_data[:args] || {}
           job_data = job.job_data
         end
 
         Appsignal.monitor_transaction(
-          'perform_job.delayed_job',
+          "perform_job.delayed_job",
           :class    => class_name,
           :method   => method_name,
           :metadata => {

data/lib/appsignal/integrations/mongo_ruby_driver.rb

@@ -12,7 +12,7 @@ module Appsignal
           .format(event.command_name, event.command)
 
         # Store the query on the transaction, we need it when the event finishes
-        store                   = transaction.store('mongo_driver')
+        store                   = transaction.store("mongo_driver")
         store[event.request_id] = command
 
         # Start this event
@@ -22,13 +22,13 @@ module Appsignal
       # Called by Mongo::Monitor when query succeeds
       def succeeded(event)
         # Finish the event as succeeded
-        finish('SUCCEEDED', event)
+        finish("SUCCEEDED", event)
       end
 
       # Called by Mongo::Monitor when query fails
       def failed(event)
         # Finish the event as failed
-        finish('FAILED', event)
+        finish("FAILED", event)
       end
 
       # Finishes the event in the AppSignal extension
@@ -38,13 +38,13 @@ module Appsignal
         return if transaction.paused?
 
         # Get the query from the transaction store
-        store   = transaction.store('mongo_driver')
+        store   = transaction.store("mongo_driver")
         command = store.delete(event.request_id) || {}
 
         # Finish the event in the extension.
         transaction.finish_event(
-          'query.mongodb',
-          "#{event.command_name.to_s} | #{event.database_name} | #{result}",
+          "query.mongodb",
+          "#{event.command_name} | #{event.database_name} | #{result}",
           Appsignal::Utils.data_generate(command),
           Appsignal::EventFormatter::DEFAULT
         )

data/lib/appsignal/integrations/padrino.rb

@@ -1,4 +1,4 @@
-require 'appsignal'
+require "appsignal"
 
 module Appsignal::Integrations
   module PadrinoPlugin
@@ -9,7 +9,7 @@ module Appsignal::Integrations
       Appsignal.config = Appsignal::Config.new(
         root,
         Padrino.env,
-        :log_path => File.join(root, 'log')
+        :log_path => File.join(root, "log")
       )
 
       Appsignal.start_logger
@@ -21,8 +21,8 @@ end
 module Padrino::Routing::InstanceMethods
   alias route_without_appsignal route!
 
-  def route!(base=settings, pass_block=nil)
-    if !Appsignal.active? || env['sinatra.static_file']
+  def route!(base = settings, pass_block = nil)
+    if !Appsignal.active? || env["sinatra.static_file"]
       route_without_appsignal(base, pass_block)
       return
     end
@@ -33,7 +33,7 @@ module Padrino::Routing::InstanceMethods
       request
     )
     begin
-      Appsignal.instrument('process_action.padrino') do
+      Appsignal.instrument("process_action.padrino") do
         route_without_appsignal(base, pass_block)
       end
     rescue => error
@@ -41,8 +41,8 @@ module Padrino::Routing::InstanceMethods
       raise error
     ensure
       transaction.set_action(get_payload_action(request))
-      transaction.set_metadata('path', request.path)
-      transaction.set_metadata('method', request.request_method)
+      transaction.set_metadata("path", request.path)
+      transaction.set_metadata("method", request.request_method)
       transaction.set_http_or_background_queue_start
       Appsignal::Transaction.complete_current!
     end
@@ -50,7 +50,7 @@ module Padrino::Routing::InstanceMethods
 
   def get_payload_action(request)
     # Short-circut is there's no request object to obtain information from
-    return "#{settings.name}" if request.nil?
+    return settings.name.to_s if request.nil?
 
     # Older versions of Padrino work with a route object
     route_obj = defined?(request.route_obj) && request.route_obj

data/lib/appsignal/integrations/railtie.rb

@@ -1,11 +1,11 @@
 Appsignal.logger.info("Loading Rails (#{Rails.version}) integration")
 
-require 'appsignal/rack/rails_instrumentation'
+require "appsignal/rack/rails_instrumentation"
 
 module Appsignal
   module Integrations
     class Railtie < ::Rails::Railtie
-      initializer 'appsignal.configure_rails_initialization' do |app|
+      initializer "appsignal.configure_rails_initialization" do |app|
         Appsignal::Integrations::Railtie.initialize_appsignal(app)
       end
 
@@ -15,7 +15,7 @@ module Appsignal
           Rails.root,
           Rails.env,
           :name => Rails.application.class.parent_name,
-          :log_path => Rails.root.join('log')
+          :log_path => Rails.root.join("log")
         )
 
         # Start logger
@@ -27,10 +27,10 @@ module Appsignal
         )
 
         if Appsignal.config.active? &&
-          Appsignal.config[:enable_frontend_error_catching] == true
+            Appsignal.config[:enable_frontend_error_catching] == true
           app.middleware.insert_before(
             Appsignal::Rack::RailsInstrumentation,
-            Appsignal::Rack::JSExceptionCatcher,
+            Appsignal::Rack::JSExceptionCatcher
           )
         end
 

data/lib/appsignal/integrations/resque.rb

@@ -1,16 +1,15 @@
 module Appsignal
   module Integrations
     module ResquePlugin
-
       # Do not use this file as a template for your own background processor
       # Resque is an exception to the rule and the code below causes the
       # extension to shut itself down after a single job.
       # see http://docs.appsignal.com/background-monitoring/custom.html
-      def around_perform_resque_plugin(*args)
+      def around_perform_resque_plugin(*_args)
         Appsignal.monitor_single_transaction(
-          'perform_job.resque',
-          :class => self.to_s,
-          :method => 'perform'
+          "perform_job.resque",
+          :class => to_s,
+          :method => "perform"
         ) do
           yield
         end

data/lib/appsignal/integrations/resque_active_job.rb

@@ -5,25 +5,22 @@ module Appsignal
 
       def self.included(base)
         base.class_eval do
-
           around_perform do |job, block|
             Appsignal.monitor_single_transaction(
-              'perform_job.resque',
+              "perform_job.resque",
               :class    => job.class.to_s,
-              :method   => 'perform',
+              :method   => "perform",
               :params   => job.format_args(job.arguments),
               :metadata => {
                 :id       => job.job_id,
                 :queue    => job.queue_name
-              },
+              }
             ) do
               block.call
             end
           end
-
         end
       end
-
     end
   end
 end

data/lib/appsignal/integrations/sinatra.rb

@@ -1,5 +1,5 @@
-require 'appsignal'
-require 'appsignal/rack/sinatra_instrumentation'
+require "appsignal"
+require "appsignal/rack/sinatra_instrumentation"
 
 Appsignal.logger.info("Loading Sinatra (#{Sinatra::VERSION}) integration")