appsignal 2.1.0.alpha.3 → 2.1.0.beta.1

data/spec/lib/appsignal/cli/notify_of_deploy_spec.rb

@@ -57,10 +57,8 @@ describe Appsignal::CLI::NotifyOfDeploy do
     let(:config) { project_fixture_config }
     before do
       config[:name] = options[:name] if options[:name]
-      stub_api_request config, "markers", {
-        :revision => options[:revision],
+      stub_api_request config, "markers", :revision => options[:revision],
         :user => options[:user]
-      }
     end
     around do |example|
       Dir.chdir project_fixture_path do
@@ -69,7 +67,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
     end
 
     context "without environment" do
-      let(:options) { {:environment => "", :revision => "foo", :user => "thijs"} }
+      let(:options) { { :environment => "", :revision => "foo", :user => "thijs" } }
       before do
         # Makes the config "active"
         ENV["APPSIGNAL_PUSH_API_KEY"] = "foo"
@@ -83,7 +81,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
     end
 
     context "without known environment" do
-      let(:options) { {:environment => "foo"} }
+      let(:options) { { :environment => "foo" } }
 
       it "prints a config error" do
         expect { run }.to raise_error(SystemExit)
@@ -95,7 +93,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
 
     context "with known environment" do
       context "without required options" do
-        let(:options) { {:environment => "production"} }
+        let(:options) { { :environment => "production" } }
 
         it "prints a missing required options error" do
           expect { run }.to raise_error(SystemExit)
@@ -105,7 +103,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
         end
 
         context "with empty required option" do
-          let(:options) { {:environment => "production", :revision => "foo", :user => ""} }
+          let(:options) { { :environment => "production", :revision => "foo", :user => "" } }
 
           it "prints a missing required option error" do
             expect { run }.to raise_error(SystemExit)
@@ -117,7 +115,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
       end
 
       context "with required options" do
-        let(:options) { {:environment => "production", :revision => "aaaaa", :user => "thijs"} }
+        let(:options) { { :environment => "production", :revision => "aaaaa", :user => "thijs" } }
 
         it "notifies of a deploy" do
           run
@@ -130,7 +128,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
           before { ENV["APPSIGNAL_APP_NAME"] = "" }
 
           context "without name option" do
-            let(:options) { {:environment => "production", :revision => "aaaaa", :user => "thijs"} }
+            let(:options) { { :environment => "production", :revision => "aaaaa", :user => "thijs" } }
 
             it "requires name option" do
               expect { run }.to raise_error(SystemExit)
@@ -141,7 +139,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
           end
 
           context "with name option" do
-            let(:options) { {:environment => "production", :revision => "aaaaa", :user => "thijs", :name => "foo"} }
+            let(:options) { { :environment => "production", :revision => "aaaaa", :user => "thijs", :name => "foo" } }
 
             it "notifies of a deploy with a custom name" do
               run
@@ -154,7 +152,7 @@ describe Appsignal::CLI::NotifyOfDeploy do
 
         context "with name option" do
           let(:options) do
-            {:environment => "production", :revision => "aaaaa", :user => "thijs", :name => "foo"}
+            { :environment => "production", :revision => "aaaaa", :user => "thijs", :name => "foo" }
           end
 
           it "notifies of a deploy with a custom name" do

data/spec/lib/appsignal/cli_spec.rb

@@ -1,4 +1,4 @@
-require 'appsignal/cli'
+require "appsignal/cli"
 
 describe Appsignal::CLI do
   let(:out_stream) { std_stream }
@@ -7,36 +7,36 @@ describe Appsignal::CLI do
   before { Dir.stub(:pwd => project_fixture_path) }
 
   it "should print the help with no arguments, -h and --help" do
-    [nil, '-h', '--help'].each do |arg|
+    [nil, "-h", "--help"].each do |arg|
       expect do
         capture_stdout(out_stream) do
           cli.run([arg].compact)
         end
       end.to raise_error(SystemExit)
 
-      expect(output).to include 'appsignal <command> [options]'
+      expect(output).to include "appsignal <command> [options]"
       expect(output).to include \
-        'Available commands: demo, diagnose, install, notify_of_deploy'
+        "Available commands: demo, diagnose, install, notify_of_deploy"
     end
   end
 
   it "should print the version with -v and --version" do
-    ['-v', '--version'].each do |arg|
+    ["-v", "--version"].each do |arg|
       expect do
         capture_stdout(out_stream) do
           cli.run([arg])
         end
       end.to raise_error(SystemExit)
 
-      expect(output).to include 'AppSignal'
-      expect(output).to include '.'
+      expect(output).to include "AppSignal"
+      expect(output).to include "."
     end
   end
 
   it "should print a notice if a command does not exist" do
     expect do
       capture_stdout(out_stream) do
-        cli.run(['nonsense'])
+        cli.run(["nonsense"])
       end
     end.to raise_error(SystemExit)
 
@@ -49,7 +49,7 @@ describe Appsignal::CLI do
       Appsignal::CLI::Diagnose.should_receive(:run)
 
       cli.run([
-        'diagnose'
+        "diagnose"
       ])
     end
   end

data/spec/lib/appsignal/config_spec.rb

@@ -114,7 +114,7 @@ describe Appsignal::Config do
     it "merges with the default config" do
       expect(config.config_hash).to eq(
         :debug                          => false,
-        :log                            => 'file',
+        :log                            => "file",
         :ignore_errors                  => [],
         :ignore_actions                 => [],
         :filter_parameters              => [],
@@ -123,19 +123,19 @@ describe Appsignal::Config do
         :instrument_sequel              => true,
         :skip_session_data              => false,
         :send_params                    => true,
-        :endpoint                       => 'https://push.appsignal.com',
-        :push_api_key                   => 'abc',
-        :name                           => 'TestApp',
+        :endpoint                       => "https://push.appsignal.com",
+        :push_api_key                   => "abc",
+        :name                           => "TestApp",
         :active                         => true,
         :enable_frontend_error_catching => false,
-        :frontend_error_catching_path   => '/appsignal_error_catcher',
+        :frontend_error_catching_path   => "/appsignal_error_catcher",
         :enable_allocation_tracking     => true,
         :enable_gc_instrumentation      => false,
         :running_in_container           => false,
         :enable_host_metrics            => true,
         :enable_minutely_probes         => false,
         :hostname                       => Socket.gethostname,
-        :ca_file_path                   => File.join(resources_dir, 'cacert.pem')
+        :ca_file_path                   => File.join(resources_dir, "cacert.pem")
       )
     end
 
@@ -177,7 +177,7 @@ describe Appsignal::Config do
   end
 
   context "when root path is nil" do
-    let(:config) { described_class.new(nil, 'production') }
+    let(:config) { described_class.new(nil, "production") }
 
     it "is not valid or active" do
       expect(config.valid?).to be_false
@@ -186,7 +186,7 @@ describe Appsignal::Config do
   end
 
   context "without config file" do
-    let(:config) { described_class.new(tmp_dir, 'production') }
+    let(:config) { described_class.new(tmp_dir, "production") }
 
     it "is not valid or active" do
       expect(config.valid?).to be_false
@@ -195,7 +195,7 @@ describe Appsignal::Config do
   end
 
   context "with a config file" do
-    let(:config) { project_fixture_config('production') }
+    let(:config) { project_fixture_config("production") }
 
     it "is not valid or active" do
       expect(config.valid?).to be_true
@@ -231,12 +231,12 @@ describe Appsignal::Config do
         expect(config.valid?).to be_true
         expect(config.active?).to be_true
 
-        expect(config[:push_api_key]).to eq('abc')
+        expect(config[:push_api_key]).to eq("abc")
       end
     end
 
     context "without the selected env" do
-      let(:config) { project_fixture_config('nonsense') }
+      let(:config) { project_fixture_config("nonsense") }
 
       it "is not valid or active" do
         expect(config.valid?).to be_false
@@ -257,18 +257,18 @@ describe Appsignal::Config do
         subject { config[:push_api_key] }
 
         context "without :push_api_key" do
-          let(:config) { project_fixture_config('old_config') }
+          let(:config) { project_fixture_config("old_config") }
 
           it "sets the :push_api_key with the old :api_key value" do
-            expect(subject).to eq 'def'
+            expect(subject).to eq "def"
           end
         end
 
         context "with :push_api_key" do
-          let(:config) { project_fixture_config('old_config_mixed_with_new_config') }
+          let(:config) { project_fixture_config("old_config_mixed_with_new_config") }
 
           it "ignores the :api_key config" do
-            expect(subject).to eq 'ghi'
+            expect(subject).to eq "ghi"
           end
         end
       end
@@ -277,18 +277,18 @@ describe Appsignal::Config do
         subject { config[:ignore_errors] }
 
         context "without :ignore_errors" do
-          let(:config) { project_fixture_config('old_config') }
+          let(:config) { project_fixture_config("old_config") }
 
           it "sets :ignore_errors with the old :ignore_exceptions value" do
-            expect(subject).to eq ['StandardError']
+            expect(subject).to eq ["StandardError"]
           end
         end
 
         context "with :ignore_errors" do
-          let(:config) { project_fixture_config('old_config_mixed_with_new_config') }
+          let(:config) { project_fixture_config("old_config_mixed_with_new_config") }
 
           it "ignores the :ignore_exceptions config" do
-            expect(subject).to eq ['NoMethodError']
+            expect(subject).to eq ["NoMethodError"]
           end
         end
       end
@@ -305,12 +305,12 @@ describe Appsignal::Config do
       )
     end
     before do
-      ENV['APPSIGNAL_RUNNING_IN_CONTAINER'] = 'true'
-      ENV['APPSIGNAL_PUSH_API_KEY']         = 'aaa-bbb-ccc'
-      ENV['APPSIGNAL_ACTIVE']               = 'true'
-      ENV['APPSIGNAL_APP_NAME']             = 'App name'
-      ENV['APPSIGNAL_DEBUG']                = 'true'
-      ENV['APPSIGNAL_IGNORE_ACTIONS']       = 'action1,action2'
+      ENV["APPSIGNAL_RUNNING_IN_CONTAINER"] = "true"
+      ENV["APPSIGNAL_PUSH_API_KEY"]         = "aaa-bbb-ccc"
+      ENV["APPSIGNAL_ACTIVE"]               = "true"
+      ENV["APPSIGNAL_APP_NAME"]             = "App name"
+      ENV["APPSIGNAL_DEBUG"]                = "true"
+      ENV["APPSIGNAL_IGNORE_ACTIONS"]       = "action1,action2"
     end
     around { |example| recognize_as_container(:none) { example.run } }
 
@@ -319,11 +319,11 @@ describe Appsignal::Config do
       expect(config.active?).to be_true
 
       expect(config[:running_in_container]).to be_true
-      expect(config[:push_api_key]).to eq 'aaa-bbb-ccc'
+      expect(config[:push_api_key]).to eq "aaa-bbb-ccc"
       expect(config[:active]).to be_true
-      expect(config[:name]).to eq 'App name'
+      expect(config[:name]).to eq "App name"
       expect(config[:debug]).to be_true
-      expect(config[:ignore_actions]).to eq ['action1', 'action2']
+      expect(config[:ignore_actions]).to eq ["action1", "action2"]
     end
   end
 
@@ -333,30 +333,30 @@ describe Appsignal::Config do
 
       context "with an pre-0.12-style endpoint" do
         let(:config) do
-          project_fixture_config('production', :endpoint => 'https://push.appsignal.com/1')
+          project_fixture_config("production", :endpoint => "https://push.appsignal.com/1")
         end
 
         it "strips off the path" do
-          expect(subject).to eq 'https://push.appsignal.com'
+          expect(subject).to eq "https://push.appsignal.com"
         end
       end
 
       context "with a non-standard port" do
-        let(:config) { project_fixture_config('production', :endpoint => 'http://localhost:4567') }
+        let(:config) { project_fixture_config("production", :endpoint => "http://localhost:4567") }
 
         it "keeps the port" do
-          expect(subject).to eq 'http://localhost:4567'
+          expect(subject).to eq "http://localhost:4567"
         end
       end
     end
   end
 
   describe "#[]" do
-    let(:config) { project_fixture_config(:none, :push_api_key => 'foo') }
+    let(:config) { project_fixture_config(:none, :push_api_key => "foo") }
 
     context "with existing key" do
       it "gets the value" do
-        expect(config[:push_api_key]).to eq 'foo'
+        expect(config[:push_api_key]).to eq "foo"
       end
     end
 
@@ -373,16 +373,16 @@ describe Appsignal::Config do
     context "with existing key" do
       it "changes the value" do
         expect(config[:push_api_key]).to be_nil
-        config[:push_api_key] = 'abcde'
-        expect(config[:push_api_key]).to eq 'abcde'
+        config[:push_api_key] = "abcde"
+        expect(config[:push_api_key]).to eq "abcde"
       end
     end
 
     context "with new key" do
       it "sets the value" do
         expect(config[:foo]).to be_nil
-        config[:foo] = 'bar'
-        expect(config[:foo]).to eq 'bar'
+        config[:foo] = "bar"
+        expect(config[:foo]).to eq "bar"
       end
     end
   end
@@ -390,48 +390,50 @@ describe Appsignal::Config do
   describe "#write_to_environment" do
     let(:config) { project_fixture_config(:production) }
     before do
-      config[:http_proxy] = 'http://localhost'
-      config[:ignore_actions] = ['action1', 'action2']
-      config[:log_path] = '/tmp'
-      config[:hostname] = 'app1.local'
+      config[:http_proxy] = "http://localhost"
+      config[:ignore_actions] = ["action1", "action2"]
+      config[:ignore_errors] = ["VerySpecificError", "AnotherError"]
+      config[:log_path] = "/tmp"
+      config[:hostname] = "app1.local"
       config[:filter_parameters] = %w(password confirm_password)
       config[:running_in_container] = false
       config.write_to_environment
     end
 
     it "writes the current config to environment variables" do
-      expect(ENV['APPSIGNAL_ACTIVE']).to                       eq 'true'
-      expect(ENV['APPSIGNAL_APP_PATH']).to                     end_with('spec/support/project_fixture')
-      expect(ENV['APPSIGNAL_AGENT_PATH']).to                   end_with('/ext')
-      expect(ENV['APPSIGNAL_DEBUG_LOGGING']).to                eq 'false'
-      expect(ENV['APPSIGNAL_LOG_FILE_PATH']).to                end_with('/tmp/appsignal.log')
-      expect(ENV['APPSIGNAL_PUSH_API_ENDPOINT']).to            eq 'https://push.appsignal.com'
-      expect(ENV['APPSIGNAL_PUSH_API_KEY']).to                 eq 'abc'
-      expect(ENV['APPSIGNAL_APP_NAME']).to                     eq 'TestApp'
-      expect(ENV['APPSIGNAL_ENVIRONMENT']).to                  eq 'production'
-      expect(ENV['APPSIGNAL_AGENT_VERSION']).to                eq Appsignal::Extension.agent_version
-      expect(ENV['APPSIGNAL_LANGUAGE_INTEGRATION_VERSION']).to eq "ruby-#{Appsignal::VERSION}"
-      expect(ENV['APPSIGNAL_HTTP_PROXY']).to                   eq 'http://localhost'
-      expect(ENV['APPSIGNAL_IGNORE_ACTIONS']).to               eq 'action1,action2'
-      expect(ENV['APPSIGNAL_FILTER_PARAMETERS']).to            eq 'password,confirm_password'
-      expect(ENV['APPSIGNAL_SEND_PARAMS']).to                  eq 'true'
-      expect(ENV['APPSIGNAL_RUNNING_IN_CONTAINER']).to         eq 'false'
-      expect(ENV['APPSIGNAL_ENABLE_HOST_METRICS']).to          eq 'true'
-      expect(ENV['APPSIGNAL_ENABLE_MINUTELY_PROBES']).to       eq 'false'
-      expect(ENV['APPSIGNAL_HOSTNAME']).to                     eq 'app1.local'
-      expect(ENV['APPSIGNAL_PROCESS_NAME']).to                 include 'rspec'
-      expect(ENV['APPSIGNAL_CA_FILE_PATH']).to                 eq File.join(resources_dir, "cacert.pem")
-      expect(ENV).to_not                                       have_key('APPSIGNAL_WORKING_DIR_PATH')
+      expect(ENV["APPSIGNAL_ACTIVE"]).to                       eq "true"
+      expect(ENV["APPSIGNAL_APP_PATH"]).to                     end_with("spec/support/project_fixture")
+      expect(ENV["APPSIGNAL_AGENT_PATH"]).to                   end_with("/ext")
+      expect(ENV["APPSIGNAL_DEBUG_LOGGING"]).to                eq "false"
+      expect(ENV["APPSIGNAL_LOG_FILE_PATH"]).to                end_with("/tmp/appsignal.log")
+      expect(ENV["APPSIGNAL_PUSH_API_ENDPOINT"]).to            eq "https://push.appsignal.com"
+      expect(ENV["APPSIGNAL_PUSH_API_KEY"]).to                 eq "abc"
+      expect(ENV["APPSIGNAL_APP_NAME"]).to                     eq "TestApp"
+      expect(ENV["APPSIGNAL_ENVIRONMENT"]).to                  eq "production"
+      expect(ENV["APPSIGNAL_AGENT_VERSION"]).to                eq Appsignal::Extension.agent_version
+      expect(ENV["APPSIGNAL_LANGUAGE_INTEGRATION_VERSION"]).to eq "ruby-#{Appsignal::VERSION}"
+      expect(ENV["APPSIGNAL_HTTP_PROXY"]).to                   eq "http://localhost"
+      expect(ENV["APPSIGNAL_IGNORE_ACTIONS"]).to               eq "action1,action2"
+      expect(ENV["APPSIGNAL_IGNORE_ERRORS"]).to                eq "VerySpecificError,AnotherError"
+      expect(ENV["APPSIGNAL_FILTER_PARAMETERS"]).to            eq "password,confirm_password"
+      expect(ENV["APPSIGNAL_SEND_PARAMS"]).to                  eq "true"
+      expect(ENV["APPSIGNAL_RUNNING_IN_CONTAINER"]).to         eq "false"
+      expect(ENV["APPSIGNAL_ENABLE_HOST_METRICS"]).to          eq "true"
+      expect(ENV["APPSIGNAL_ENABLE_MINUTELY_PROBES"]).to       eq "false"
+      expect(ENV["APPSIGNAL_HOSTNAME"]).to                     eq "app1.local"
+      expect(ENV["APPSIGNAL_PROCESS_NAME"]).to                 include "rspec"
+      expect(ENV["APPSIGNAL_CA_FILE_PATH"]).to                 eq File.join(resources_dir, "cacert.pem")
+      expect(ENV).to_not                                       have_key("APPSIGNAL_WORKING_DIR_PATH")
     end
 
     context "with :working_dir_path" do
       before do
-        config[:working_dir_path] = '/tmp/appsignal2'
+        config[:working_dir_path] = "/tmp/appsignal2"
         config.write_to_environment
       end
 
       it "sets the modified :working_dir_path" do
-        expect(ENV['APPSIGNAL_WORKING_DIR_PATH']).to eq '/tmp/appsignal2'
+        expect(ENV["APPSIGNAL_WORKING_DIR_PATH"]).to eq "/tmp/appsignal2"
       end
     end
   end
@@ -439,7 +441,7 @@ describe Appsignal::Config do
   describe "#log_file_path" do
     let(:out_stream) { std_stream }
     let(:output) { out_stream.read }
-    let(:config) { project_fixture_config('production', :log_path => log_path) }
+    let(:config) { project_fixture_config("production", :log_path => log_path) }
     subject { capture_stdout(out_stream) { config.log_file_path } }
     around do |example|
       recognize_as_container(:none) do
@@ -448,12 +450,12 @@ describe Appsignal::Config do
     end
 
     context "when path is writable" do
-      let(:log_path) { File.join(tmp_dir, 'writable-path') }
+      let(:log_path) { File.join(tmp_dir, "writable-path") }
       before { FileUtils.mkdir_p(log_path, :mode => 0755) }
       after { FileUtils.rm_rf(log_path) }
 
       it "returns log file path" do
-        expect(subject).to eq File.join(log_path, 'appsignal.log')
+        expect(subject).to eq File.join(log_path, "appsignal.log")
       end
 
       it "prints no warning" do
@@ -462,7 +464,7 @@ describe Appsignal::Config do
       end
     end
 
-    shared_examples '#log_file_path: tmp path' do
+    shared_examples "#log_file_path: tmp path" do
       let(:system_tmp_dir) { described_class::SYSTEM_TMP_DIR }
       before { FileUtils.mkdir_p(system_tmp_dir) }
       after { FileUtils.rm_rf(system_tmp_dir) }
@@ -471,7 +473,7 @@ describe Appsignal::Config do
         before { FileUtils.chmod(0777, system_tmp_dir) }
 
         it "returns returns the tmp location" do
-          expect(subject).to eq(File.join(system_tmp_dir, 'appsignal.log'))
+          expect(subject).to eq(File.join(system_tmp_dir, "appsignal.log"))
         end
 
         it "prints a warning" do
@@ -502,12 +504,12 @@ describe Appsignal::Config do
       context "when root_path is nil" do
         before { allow(config).to receive(:root_path).and_return(nil) }
 
-        include_examples '#log_file_path: tmp path'
+        include_examples "#log_file_path: tmp path"
       end
 
       context "when root_path is set" do
         it "returns returns the project log location" do
-          expect(subject).to eq File.join(config.root_path, 'log/appsignal.log')
+          expect(subject).to eq File.join(config.root_path, "log/appsignal.log")
         end
 
         it "prints no warning" do
@@ -518,33 +520,33 @@ describe Appsignal::Config do
     end
 
     context "when path does not exist" do
-      let(:log_path) { '/non-existing' }
+      let(:log_path) { "/non-existing" }
 
-      include_examples '#log_file_path: tmp path'
+      include_examples "#log_file_path: tmp path"
     end
 
     context "when path is not writable" do
-      let(:log_path) { File.join(tmp_dir, 'not-writable-path') }
+      let(:log_path) { File.join(tmp_dir, "not-writable-path") }
       before { FileUtils.mkdir_p(log_path, :mode => 0555) }
       after { FileUtils.rm_rf(log_path) }
 
-      include_examples '#log_file_path: tmp path'
+      include_examples "#log_file_path: tmp path"
     end
 
     context "when path is a symlink" do
       context "when linked path does not exist" do
-        let(:real_path) { File.join(tmp_dir, 'real-path') }
-        let(:log_path) { File.join(tmp_dir, 'symlink-path') }
+        let(:real_path) { File.join(tmp_dir, "real-path") }
+        let(:log_path) { File.join(tmp_dir, "symlink-path") }
         before { File.symlink(real_path, log_path) }
         after { FileUtils.rm(log_path) }
 
-        include_examples '#log_file_path: tmp path'
+        include_examples "#log_file_path: tmp path"
       end
 
       context "when linked path exists" do
         context "when linked path is not writable" do
-          let(:real_path) { File.join(tmp_dir, 'real-path') }
-          let(:log_path) { File.join(tmp_dir, 'symlink-path') }
+          let(:real_path) { File.join(tmp_dir, "real-path") }
+          let(:log_path) { File.join(tmp_dir, "symlink-path") }
           before do
             FileUtils.mkdir_p(real_path)
             FileUtils.chmod(0444, real_path)
@@ -555,12 +557,12 @@ describe Appsignal::Config do
             FileUtils.rm(log_path)
           end
 
-          include_examples '#log_file_path: tmp path'
+          include_examples "#log_file_path: tmp path"
         end
 
         context "when linked path is writable" do
-          let(:real_path) { File.join(tmp_dir, 'real-path') }
-          let(:log_path) { File.join(tmp_dir, 'symlink-path') }
+          let(:real_path) { File.join(tmp_dir, "real-path") }
+          let(:log_path) { File.join(tmp_dir, "symlink-path") }
           before do
             FileUtils.mkdir_p(real_path)
             File.symlink(real_path, log_path)
@@ -571,7 +573,7 @@ describe Appsignal::Config do
           end
 
           it "returns real path of log path" do
-            expect(subject).to eq(File.join(real_path, 'appsignal.log'))
+            expect(subject).to eq(File.join(real_path, "appsignal.log"))
           end
         end
       end