alexandria-book-collection-manager 0.7.4 → 0.7.5

data/lib/alexandria/ui/alert_dialog.rb

@@ -8,7 +8,8 @@ module Alexandria
   module UI
     class AlertDialog < SimpleDelegator
       def initialize(parent, title, stock_icon, buttons, message = nil)
-        dialog = Gtk::Dialog.new(title: "", parent: parent, flags: :destroy_with_parent, buttons: buttons)
+        dialog = Gtk::Dialog.new(title: "", parent: parent, flags: :destroy_with_parent,
+                                 buttons: buttons)
         super(dialog)
 
         self.border_width = 6

data/lib/alexandria/ui/barcode_animation.rb

@@ -129,11 +129,12 @@ module Alexandria
       def draw_barcode_bars
         @barcode_data.each do |space_width, bar_width|
           @hpos += space_width
-          rect_item = GooCanvas::CanvasRect.new(parent: @root,
-                                                x: @bar_left_edge + @scale * @hpos, y: @bar_top,
-                                                width: @scale * bar_width, height: @bar_height,
-                                                line_width: 0,
-                                                fill_color: "white")
+          rect_item =
+            GooCanvas::CanvasRect.new(parent: @root,
+                                      x: @bar_left_edge + @scale * @hpos, y: @bar_top,
+                                      width: @scale * bar_width, height: @bar_height,
+                                      line_width: 0,
+                                      fill_color: "white")
           @hpos += bar_width
           @barcode_bars << rect_item
         end

data/lib/alexandria/ui/book_properties_dialog_base.rb

@@ -279,7 +279,10 @@ module Alexandria
             if cover.height > COVER_ABSOLUTE_MAXHEIGHT
               FileUtils.cp(dialog.filename, "#{@cover_file}.orig")
               new_width = cover.width / (cover.height / COVER_ABSOLUTE_MAXHEIGHT.to_f)
-              puts "Scaling large cover image to #{new_width.to_i} x #{COVER_ABSOLUTE_MAXHEIGHT}"
+              log.info do
+                "Scaling large cover image to" \
+                  " #{new_width.to_i} x #{COVER_ABSOLUTE_MAXHEIGHT}"
+              end
               cover = cover.scale(new_width.to_i, COVER_ABSOLUTE_MAXHEIGHT)
               cover.save(@cover_file, "jpeg")
             else
@@ -393,8 +396,9 @@ module Alexandria
       end
 
       def parse_date(datestring)
-        date_format = "%d/%m/%Y" # or '%m/%d/%Y' for USA and Canada ; or '%Y-%m-%d' for most of Asia
-        ## http://en.wikipedia.org/wiki/Calendar_date#Middle_endian_forms.2C_starting_with_the_month
+        # '%m/%d/%Y' for USA and Canada ; or '%Y-%m-%d' for most of Asia
+        # http://en.wikipedia.org/wiki/Calendar_date#Middle_endian_forms.2C_starting_with_the_month
+        date_format = "%d/%m/%Y"
         begin
           d = Date.strptime(datestring, date_format)
           Time.gm(d.year, d.month, d.day)

data/lib/alexandria/ui/callbacks.rb

@@ -70,7 +70,9 @@ module Alexandria
 
       def on_window_state_event(_window, event)
         log.debug { "window-state-event" }
-        @maximized = event.new_window_state == :maximized if event.is_a?(Gdk::EventWindowState)
+        if event.is_a?(Gdk::EventWindowState)
+          @maximized = event.new_window_state == :maximized
+        end
         log.debug { "end window-state-event" }
       end
 
@@ -274,7 +276,7 @@ module Alexandria
       end
 
       def connect_signals
-        # rubocop:disable Metrics/LineLength
+        # rubocop:disable Layout/LineLength
         standard_actions = [
           ["LibraryMenu", nil, _("_Library")],
           ["New", Gtk::Stock::NEW, _("_New Library"), "<control>L", _("Create a new library"), method(:on_new)],
@@ -313,7 +315,6 @@ module Alexandria
           ["Help", Gtk::Stock::HELP, _("Contents"), "F1", _("View Alexandria's manual"), method(:on_help)],
           ["About", Gtk::Stock::ABOUT, _("_About"), nil, _("Show information about Alexandria"), method(:on_about)],
         ]
-        # rubocop:enable Metrics/LineLength
 
         toggle_actions = [
           ["Sidepane", nil, _("Side _Pane"), "F9", nil, method(:on_view_sidepane), true],
@@ -335,6 +336,8 @@ module Alexandria
           ["ByEdition", nil, _("By _Binding"), nil, nil, 4],
           ["ByRating", nil, _("By _Rating"), nil, nil, 5]
         ]
+        # rubocop:enable Layout/LineLength
+
         providers_actions = BookProviders.map do |provider|
           [provider.action_name, Gtk::Stock::JUMP_TO,
            _("At _%s") % provider.fullname, nil, nil,
@@ -357,8 +360,10 @@ module Alexandria
           action.signal_connect("activate", &callback) if callback
         end
 
-        toggle_actions.each do |name, stock_id, label, accelerator, tooltip, callback, is_active|
-          action = Gtk::ToggleAction.new(name, label: label, tooltip: tooltip, stock_id: stock_id)
+        toggle_actions
+          .each do |name, stock_id, label, accelerator, tooltip, callback, is_active|
+          action = Gtk::ToggleAction.new(name, label: label, tooltip: tooltip,
+                                         stock_id: stock_id)
           action.set_active is_active
           @actiongroup.add_action_with_accel(action, accelerator)
           action.signal_connect("toggled", &callback) if callback
@@ -366,7 +371,8 @@ module Alexandria
 
         first_action = nil
         view_as_actions.each do |name, stock_id, label, accelerator, tooltip, value|
-          action = Gtk::RadioAction.new(name, value, label: label, tooltip: tooltip, stock_id: stock_id)
+          action = Gtk::RadioAction.new(name, value, label: label, tooltip: tooltip,
+                                        stock_id: stock_id)
           if first_action
             action.join_group first_action
           else
@@ -385,7 +391,8 @@ module Alexandria
 
         first_action = nil
         arrange_icons_actions.each do |name, stock_id, label, accelerator, tooltip, value|
-          action = Gtk::RadioAction.new(name, value, label: label, tooltip: tooltip, stock_id: stock_id)
+          action = Gtk::RadioAction.new(name, value, label: label, tooltip: tooltip,
+                                        stock_id: stock_id)
           if first_action
             action.join_group first_action
           else

data/lib/alexandria/ui/dndable.rb

@@ -66,7 +66,7 @@ module Alexandria
           end
         end
 
-        view.signal_connect("drag-data-get") do |_widget, _drag_context, selection_data, _info, _time|
+        view.signal_connect("drag-data-get") do |_, _, selection_data, _, _|
           idents = @parent.selected_books.map(&:ident)
           unless idents.empty?
             selection_data.set(Gdk::Selection::TYPE_STRING,

data/lib/alexandria/ui/export_dialog.rb

@@ -108,8 +108,6 @@ module Alexandria
       private
 
       def on_export(format, theme)
-        raise NotImplementedError unless @library.respond_to?(format.message)
-
         filename = self.filename
         if format.ext
           filename += "." + format.ext if File.extname(filename).empty?

data/lib/alexandria/ui/icons.rb

@@ -70,7 +70,8 @@ module Alexandria
           return GdkPixbuf::Pixbuf.new(file: filename) if File.exist?(filename)
         rescue GdkPixbuf::PixbufError
           log.error do
-            "Failed to load GdkPixbuf::Pixbuf, please ensure that #{filename} is a valid image file"
+            "Failed to load GdkPixbuf::Pixbuf," \
+              " please ensure that #{filename} is a valid image file"
           end
         end
         BOOK_ICON

data/lib/alexandria/ui/iconview.rb

@@ -68,12 +68,14 @@ module Alexandria
 
       ICONS_SORTS = [
         Columns::TITLE, Columns::AUTHORS, Columns::ISBN,
-        Columns::PUBLISHER, Columns::EDITION, Columns::RATING, Columns::REDD, Columns::OWN, Columns::WANT
+        Columns::PUBLISHER, Columns::EDITION, Columns::RATING,
+        Columns::REDD, Columns::OWN, Columns::WANT
       ].freeze
+
       def setup_books_iconview_sorting
         mode = ICONS_SORTS[@prefs.arrange_icons_mode]
-        @iconview_model.set_sort_column_id(mode,
-                                           @prefs.reverse_icons ? Gtk::SORT_DESCENDING : Gtk::SORT_ASCENDING)
+        sort = @prefs.reverse_icons ? Gtk::SORT_DESCENDING : Gtk::SORT_ASCENDING
+        @iconview_model.set_sort_column_id(mode, sort)
         @filtered_model.refilter # force redraw
       end
     end

data/lib/alexandria/ui/import_dialog.rb

@@ -56,7 +56,7 @@ module Alexandria
         end
 
         signal_connect("selection_changed") do
-          import_button.sensitive = filename && File.file?(filename)
+          import_button.sensitive = !!(filename && File.file?(filename))
         end
 
         # before adding the (hidden) progress bar, we must re-set the
@@ -119,13 +119,11 @@ module Alexandria
           @bad_isbns = nil
           @failed_isbns = nil
           thread = Thread.start do
-            begin
-              library, @bad_isbns, @failed_isbns = filter.invoke(new_library_name,
-                                                                 filename)
-            rescue StandardError => ex
-              trace = ex.backtrace.join("\n> ")
-              log.error { "Import failed: #{ex.message} #{trace}" }
-            end
+            library, @bad_isbns, @failed_isbns = filter.invoke(new_library_name,
+                                                               filename)
+          rescue StandardError => ex
+            trace = ex.backtrace.join("\n> ")
+            log.error { "Import failed: #{ex.message} #{trace}" }
           end
 
           while thread.alive? && !@destroyed

data/lib/alexandria/ui/keep_bad_isbn_dialog.rb

@@ -14,9 +14,10 @@ module Alexandria
 
       def initialize(parent, book)
         title = _("Invalid ISBN '%s'") % book.isbn
-        message = _("The book titled '%s' has an invalid ISBN, but still " \
-                    "exists in the providers libraries.  Do you want to " \
-                    "keep the book but change the ISBN or cancel the addition?") % book.title
+        message =
+          _("The book titled '%s' has an invalid ISBN, but still " \
+            "exists in the providers libraries.  Do you want to " \
+            "keep the book but change the ISBN or cancel the addition?") % book.title
         super(parent, title,
               Gtk::Stock::DIALOG_QUESTION,
               [[Gtk::Stock::CANCEL, Gtk::ResponseType::CANCEL],

data/lib/alexandria/ui/listview.rb

@@ -128,40 +128,38 @@ module Alexandria
         renderer = CellRendererToggle.new
         renderer.activatable = true
         renderer.signal_connect("toggled") do |_rndrr, path|
-          begin
-            tree_path = Gtk::TreePath.new(path)
-            child_path = @listview_model.convert_path_to_child_path(tree_path)
-            if child_path
-              unfiltered_path = @filtered_model.convert_path_to_child_path(child_path)
-              # FIX this sometimes returns a nil path for iconview...
-              if unfiltered_path
-                iter = @model.get_iter(unfiltered_path)
-                if iter
-                  book = @parent.book_from_iter(@parent.selected_library, iter)
-                  toggle_state = case iterid
-                                 when Columns::REDD then book.redd
-                                 when Columns::OWN then book.own
-                                 when Columns::WANT then book.want
-                                 end
-                  # invert toggle_state
-                  unless iterid == Columns::WANT && book.own
-                    toggle_state = !toggle_state
-                    case iterid
-                    when Columns::REDD then book.redd = toggle_state
-                    when Columns::OWN then book.own = toggle_state
-                    when Columns::WANT then book.want = toggle_state
-                    end
-                    iter[iterid] = toggle_state
-                    lib = @parent.selected_library
-                    lib.save(book)
+          tree_path = Gtk::TreePath.new(path)
+          child_path = @listview_model.convert_path_to_child_path(tree_path)
+          if child_path
+            unfiltered_path = @filtered_model.convert_path_to_child_path(child_path)
+            # FIX this sometimes returns a nil path for iconview...
+            if unfiltered_path
+              iter = @model.get_iter(unfiltered_path)
+              if iter
+                book = @parent.book_from_iter(@parent.selected_library, iter)
+                toggle_state = case iterid
+                               when Columns::REDD then book.redd
+                               when Columns::OWN then book.own
+                               when Columns::WANT then book.want
+                               end
+                # invert toggle_state
+                unless iterid == Columns::WANT && book.own
+                  toggle_state = !toggle_state
+                  case iterid
+                  when Columns::REDD then book.redd = toggle_state
+                  when Columns::OWN then book.own = toggle_state
+                  when Columns::WANT then book.want = toggle_state
                   end
+                  iter[iterid] = toggle_state
+                  lib = @parent.selected_library
+                  lib.save(book)
                 end
               end
-
             end
-          rescue StandardError => ex
-            log.error { "toggle failed for path #{path} #{ex}\n" + e.backtrace.join("\n") }
+
           end
+        rescue StandardError => ex
+          log.error { "toggle failed for path #{path} #{ex}\n" + e.backtrace.join("\n") }
         end
         column = Gtk::TreeViewColumn.new(title, renderer, text: iterid)
         column.sort_column_id = iterid
@@ -169,7 +167,9 @@ module Alexandria
         log.debug { format("Create listview column for %s...", title) }
 
         column.add_attribute(renderer, "active", iterid)
-        column.add_attribute(renderer, "inconsistent", Columns::OWN) if iterid == Columns::WANT
+        if iterid == Columns::WANT
+          column.add_attribute(renderer, "inconsistent", Columns::OWN)
+        end
 
         log.debug { "append_column #{column}" }
         @listview.append_column(column)
@@ -206,7 +206,10 @@ module Alexandria
         cols.each_index do |i|
           cols[i].visible = !!cols_visibility[i]
         end
-        log.debug { "Columns visibility: " + cols.map { |col| "#{col.title} #{col.visible?}" }.join(", ") }
+        log.debug do
+          "Columns visibility: " +
+            cols.map { |col| "#{col.title} #{col.visible?}" }.join(", ")
+        end
       end
 
       # Sets the width of each column based on any respective

data/lib/alexandria/ui/multi_drag_treeview.rb

@@ -7,7 +7,9 @@
 module Alexandria
   module EventOverrides
     def ==(obj)
-      obj.is_a?(self.class) && (time == obj.time) && (x == obj.x) && (y == obj.y) && (button == obj.button)
+      obj.is_a?(self.class) &&
+        (time == obj.time) && (x == obj.x) && (y == obj.y) &&
+        (button == obj.button)
     end
   end
 
@@ -104,7 +106,6 @@ module Alexandria
       path, _, cell_x, cell_y = get_path_at_pos(event.x, event.y)
       return false if path.nil?
 
-      # call_parent = (event.state.control_mask? or event.state.shift_mask?) or !selected or event.button != 1
       (call_parent = !selection.path_is_selected?(path)) ||
         (event.button != 1)
 

data/lib/alexandria/ui/new_book_dialog.rb

@@ -179,24 +179,22 @@ module Alexandria
             image_error_dialog(@image_error).display
           else
             @images.each_pair do |key, value|
-              begin
-                loader = GdkPixbuf::PixbufLoader.new
-                loader.last_write(value)
-                pixbuf = loader.pixbuf
-
-                if pixbuf.width > 1
-                  iter = @treeview_results.model.get_iter(key.to_s)
-                  unless @treeview_results.model.iter_is_valid?(iter)
-                    raise format("Iter is invalid! %s", iter)
-                  end
-
-                  iter[2] = pixbuf # I bet you this is it!
+              loader = GdkPixbuf::PixbufLoader.new
+              loader.last_write(value)
+              pixbuf = loader.pixbuf
+
+              if pixbuf.width > 1
+                iter = @treeview_results.model.get_iter(key.to_s)
+                unless @treeview_results.model.iter_is_valid?(iter)
+                  raise format("Iter is invalid! %s", iter)
                 end
 
-                @images.delete(key)
-              rescue StandardError => ex
-                image_error_dialog(ex.message).display
+                iter[2] = pixbuf # I bet you this is it!
               end
+
+              @images.delete(key)
+            rescue StandardError => ex
+              image_error_dialog(ex.message).display
             end
           end
 
@@ -538,19 +536,18 @@ module Alexandria
         if (event.event_type == :button_press) &&
             (event.button == 1)
 
-          radio, target_widget, box2, box3 = case widget
-                                             when @eventbox_entry_search
-                                               [@title_radiobutton, @entry_search,
-                                                @eventbox_combo_search, @eventbox_entry_isbn]
-
-                                             when @eventbox_combo_search
-                                               [@title_radiobutton, @combo_search,
-                                                @eventbox_entry_search, @eventbox_entry_isbn]
-
-                                             when @eventbox_entry_isbn
-                                               [@isbn_radiobutton, @entry_isbn,
-                                                @eventbox_entry_search, @eventbox_combo_search]
-                                             end
+          radio, target_widget, box2, box3 =
+            case widget
+            when @eventbox_entry_search
+              [@title_radiobutton, @entry_search,
+               @eventbox_combo_search, @eventbox_entry_isbn]
+            when @eventbox_combo_search
+              [@title_radiobutton, @combo_search,
+               @eventbox_entry_search, @eventbox_entry_isbn]
+            when @eventbox_entry_isbn
+              [@isbn_radiobutton, @entry_isbn,
+               @eventbox_entry_search, @eventbox_combo_search]
+            end
           radio.active = true
           target_widget.grab_focus
           widget.above_child = false
@@ -570,8 +567,9 @@ module Alexandria
         return unless isbn13
 
         if (book = library.find { |bk| bk.isbn == isbn13 })
-          raise DuplicateBookException, format(_("'%s' already exists in '%s' (titled '%s')."),
-                                               isbn, library.name, book.title.sub("&", "&"))
+          raise DuplicateBookException,
+                format(_("'%s' already exists in '%s' (titled '%s')."),
+                       isbn, library.name, book.title.sub("&", "&"))
         end
       end
     end

data/lib/alexandria/ui/new_book_dialog_manual.rb

@@ -75,7 +75,9 @@ module Alexandria
                               "sure it is written correcty, and try again.")
           end
           ary = @library.select { |book| book.ident == isbn }
-          raise AddError, _("The EAN/ISBN you provided is already used in this library.") unless ary.empty?
+          unless ary.empty?
+            raise AddError, _("The EAN/ISBN you provided is already used in this library.")
+          end
         end
         if (publisher = @entry_publisher.text.strip).empty?
           raise AddError, _("A publisher must be provided.")

data/lib/alexandria/ui/provider_preferences_base_dialog.rb

@@ -15,7 +15,8 @@ module Alexandria
   module UI
     class ProviderPreferencesBaseDialog < SimpleDelegator
       def initialize(title:, parent:, flags:, buttons:)
-        dialog = Gtk::Dialog.new(title: title, parent: parent, flags: flags, buttons: buttons)
+        dialog = Gtk::Dialog.new(title: title, parent: parent, flags: flags,
+                                 buttons: buttons)
         super(dialog)
 
         self.resizable = false

data/lib/alexandria/ui/sidepane_manager.rb

@@ -126,7 +126,8 @@ module Alexandria
 
         @library_listview.enable_model_drag_dest(BOOKS_TARGET_TABLE, :move)
 
-        @library_listview.signal_connect("drag-motion") do |_widget, drag_context, x, y, time, _data|
+        @library_listview
+          .signal_connect("drag-motion") do |_widget, drag_context, x, y, time, _data|
           log.debug { "drag-motion" }
 
           path, column, =
@@ -156,7 +157,8 @@ module Alexandria
                           time)
         end
 
-        @library_listview.signal_connect("drag-drop") do |widget, drag_context, _x, _y, time, _data|
+        @library_listview
+          .signal_connect("drag-drop") do |widget, drag_context, _x, _y, time, _data|
           log.debug { "drag-drop" }
 
           widget.drag_get_data(drag_context,
@@ -165,7 +167,8 @@ module Alexandria
           true
         end
 
-        @library_listview.signal_connect("drag-data-received") do |_, drag_context, x, y, data, _, _|
+        @library_listview
+          .signal_connect("drag-data-received") do |_, drag_context, x, y, data, _, _|
           log.debug { "drag-data-received" }
 
           success = false