alexandria-book-collection-manager 0.7.4 → 0.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 44744940c1b1d1eabd2f062869295dcbd42a67347ebc7390e4150ed406de1768
-  data.tar.gz: c9e295c6171d7f88e118c5c998cf6d6507841e78f7dab2f65ccf1a611a8bdd0d
+  metadata.gz: 41c8eead00b7524b5b74feaa6ac01f063faaac747b83fccad928afa9d8b28b58
+  data.tar.gz: 10fd8fa88a3deab629b885c31afae79984c5c706c5ae0bab4a41c7ddd35bf12a
 SHA512:
-  metadata.gz: 9791ac87a6456ec74446ac6a8ce2791f2c0b464c4b843ac69dad561a83bacb286716c9fa940d41b15342e9212339aaa85383e0460128823e711fbe935a1b823f
-  data.tar.gz: b1b803f65c8b88fcfd35f50e3e1aebde2677de06343baaa4b57f359aba9cc6803240ff50d66dfc80c6fffbc1c8eae6a37574588365714e0f656cd7c513cddea2
+  metadata.gz: 0710b1de59aadd9a781760b23b329f4369d42dbc4c77f1dc1f6fee5643a928cccb113390595ad675b766c865f4a8651ae290e1665bed32fb6af9b501d2a2bdec
+  data.tar.gz: b8f0ec703fd44905365c9d66bb28ddb5b4b8e46f3bd26ad9762d99e2e7f66e7ab4634314ec4a06890e0a28fc0cbe752dde704bf03be9371bbc73c5931eb8a605

data/.rubocop.yml

@@ -8,12 +8,16 @@ AllCops:
   Exclude:
     - 'lib/alexandria/default_preferences.rb'
     - 'pkg/**/*'
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
 
-Layout/AlignHash:
+Layout/HashAlignment:
   EnforcedColonStyle: key
   EnforcedHashRocketStyle: table
 
+# Be lenient with line length
+Layout/LineLength:
+  Max: 92
+
 # Don't force lonely closing parentheses
 Layout/MultilineMethodCallBraceLayout:
   EnforcedStyle: same_line
@@ -32,19 +36,27 @@ Layout/MultilineOperationIndentation:
 Layout/SpaceBeforeBlockBraces:
   EnforcedStyleForEmptyBraces: space
 
+# Assume the programmer knows how bracketed block syntax works
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+
 # Allow if (foo = get_foo) style
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
+# Activate new cops from RuboCop 0.81 and 0.82
+Lint/RaiseException:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+
 # Blocks in specs can be any size
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
 
-# Be lenient with line length
-Metrics/LineLength:
-  Max: 110
-
 Naming/AccessorMethodName:
   Enabled: false
 
@@ -56,10 +68,22 @@ Naming/RescuedExceptionsVariableName:
 Style/AndOr:
   EnforcedStyle: conditionals
 
+# Activate new cop from RuboCop 0.82
+Style/ExponentialNotation:
+  Enabled: true
+
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
   MinBodyLength: 2
 
+# Activate new cops from RuboCop 0.80
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+
 # Not all objects that handle #== 0 also handle #zero?
 Style/NumericPredicate:
   Enabled: false
@@ -71,6 +95,7 @@ Style/Next:
 # Use older RuboCop default
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
+    '%W': ()
     '%w': ()
 
 # Allow explicit return with multiple return values

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-10-16 21:37:35 +0200 using RuboCop version 0.75.1.
+# on 2020-02-22 15:02:18 +0100 using RuboCop version 0.80.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -28,7 +28,7 @@ Lint/UselessAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 162
+# Offense count: 160
 Metrics/AbcSize:
   Max: 159
 
@@ -36,38 +36,38 @@ Metrics/AbcSize:
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 66
+  Max: 67
 
 # Offense count: 8
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 32
+# Offense count: 31
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 985
+  Max: 994
 
-# Offense count: 65
+# Offense count: 63
 Metrics/CyclomaticComplexity:
   Max: 22
 
-# Offense count: 212
+# Offense count: 214
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 109
+  Max: 113
 
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 340
+  Max: 346
 
 # Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 63
+# Offense count: 61
 Metrics/PerceivedComplexity:
   Max: 23
 
@@ -82,8 +82,8 @@ Naming/BinaryOperatorParameterName:
     - 'lib/alexandria/ui/multi_drag_treeview.rb'
 
 # Offense count: 13
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'Rakefile'
@@ -98,23 +98,10 @@ Naming/MemoizedInstanceVariableName:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 4
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicateName:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/ui/smart_library_properties_dialog_base.rb'
-    - 'lib/alexandria/web_themes.rb'
-
 # Offense count: 10
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
   Exclude:
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
     - 'lib/alexandria/book_providers/proxis.rb'
@@ -124,6 +111,19 @@ Naming/UncommunicativeMethodParamName:
     - 'lib/alexandria/ui/init.rb'
     - 'util/rake/fileinstall.rb'
 
+# Offense count: 4
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/ui/smart_library_properties_dialog_base.rb'
+    - 'lib/alexandria/web_themes.rb'
+
 # Offense count: 1
 RSpec/DescribeClass:
   Exclude:
@@ -162,10 +162,9 @@ RSpec/InstanceVariable:
   Exclude:
     - 'spec/alexandria/export_library_spec.rb'
 
-# Offense count: 3
+# Offense count: 2
 RSpec/MultipleDescribes:
   Exclude:
-    - 'spec/alexandria/ui/main_app_spec.rb'
     - 'spec/alexandria/ui/ui_utilities_spec.rb'
     - 'spec/alexandria/utilities_spec.rb'
 
@@ -176,7 +175,7 @@ RSpec/MultipleExpectations:
 
 # Offense count: 34
 # Cop supports --auto-correct.
-# Configuration parameters: Strict, EnforcedStyle.
+# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
 # SupportedStyles: inflected, explicit
 RSpec/PredicateMatcher:
   Exclude:
@@ -217,13 +216,14 @@ Style/CommentedKeyword:
     - 'lib/alexandria/ui/new_book_dialog.rb'
     - 'util/rake/fileinstall.rb'
 
-# Offense count: 113
+# Offense count: 112
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 2
 Style/DoubleNegation:
   Exclude:
+    - 'lib/alexandria/ui/import_dialog.rb'
     - 'lib/alexandria/ui/listview.rb'
 
 # Offense count: 10
@@ -236,7 +236,7 @@ Style/FormatStringToken:
     - 'lib/alexandria/ui/listview.rb'
     - 'lib/alexandria/ui/new_book_dialog.rb'
 
-# Offense count: 34
+# Offense count: 27
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false

data/.travis.yml

@@ -0,0 +1,39 @@
+language: ruby
+
+dist: xenial
+
+services:
+  - xvfb
+
+before_install:
+  - sudo apt-get update
+  # Needed for gtk3 gem
+  - sudo apt-get install libgtk-3-dev
+  # Needed for gstreamer gem
+  - sudo apt-get install libgstreamer1.0-dev
+  # Needed for GooCanvas::Canvas widget
+  - sudo apt-get install libgoocanvas-2.0-dev
+  # Needed for zoom gem
+  - sudo apt-get install libyaz-dev
+  # Needed for intltool-merge executable
+  - sudo apt-get install intltool
+  # Needed for gconftool-2 executable
+  - sudo apt-get install gconf2
+  # Needed to provide A11y dbus service to silence warnings
+  - sudo apt-get install at-spi2-core
+  # Needed to set up sound player pipeline
+  - sudo apt-get install gstreamer1.0-plugins-good
+  # Needed to play sound
+  - sudo apt-get install pulseaudio
+
+cache:
+  bundler: true
+
+rvm:
+  - 2.5
+  - 2.6
+  - 2.7
+
+branches:
+  only:
+    - master

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 0.7.5 / 2020-05-11
+
+* Avoid crash when opening Import dialog
+* Avoid crash during export
+* Add support for Ruby 2.7
+* Drop support for Ruby 2.4
+* Remove broken Renaud provider
+
 ## 0.7.4 / 2019-10-24
 
 * Drop support for Ruby 2.3

data/README.md

@@ -161,7 +161,7 @@ Unless otherwise noted, the following license applies to all files that are
 part of Alexandria:
 
 Copyright (C) 2004 Laurent Sansonetti
-Copyright (C) 2005-2010,2014-2019 Alexandria Contributors
+Copyright (C) 2005-2010,2014-2020 Alexandria Contributors
 
 Alexandria is free software; you can redistribute it and/or modify it under the
 terms of the GNU General Public License as published by the Free Software

data/Rakefile

@@ -223,7 +223,9 @@ end
 task :gconf do
   return if ENV["GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL"]
 
-  raise "gconftool-2 cannot be found, is GConf2 correctly installed?" unless system("which gconftool-2")
+  unless system("which gconftool-2")
+    raise "gconftool-2 cannot be found, is GConf2 correctly installed?"
+  end
 
   ENV["GCONF_CONFIG_SOURCE"] = `gconftool-2 --get-default-source`.chomp
   Dir["schemas/*.schemas"].each do |schema|
@@ -244,4 +246,4 @@ task install: [:pre_install, :install_package, :post_install]
 desc "Uninstall Alexandria"
 task uninstall: [:uninstall_package] # TODO: gconf etc...
 
-task default: [:spec, :dogtail]
+task default: [:spec]

data/alexandria-book-collection-manager.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.version = Alexandria::VERSION
 
   s.summary = "GNOME application for managing collections of books"
-  s.required_ruby_version = ">= 2.4.0"
+  s.required_ruby_version = ">= 2.5.0"
 
   s.authors = [
     "Alexander McCormmach",
@@ -51,6 +51,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency("htmlentities", ["~> 4.3"])
   s.add_runtime_dependency("image_size", ["~> 2.0"])
   s.add_runtime_dependency("marc", ["~> 1.0.0"])
+  s.add_runtime_dependency("psych", ["~> 3.1.0"])
   s.add_runtime_dependency("zoom", ["~> 0.5.0"])
 
   s.add_development_dependency("gnome_app_driver", ["~> 0.2.1"])

data/bin/alexandria

@@ -20,16 +20,6 @@ OptionParser.new do |opts|
     puts Alexandria.list_books_on_console
     exit
   end
-  # opts.on("--output FORMAT",
-  #        "Output library as FORMAT: csv|xml|yaml; use with --library or omit for ALL") do |val|
-  #        options.format = val
-  #        exit
-  # end
-  # opts.on("--library LIBRARY",
-  #        "Used with --output to pick a library to output") do |val|
-  #        options.library = val
-  #        exit
-  # end
   opts.on("-d", "--debug", "Run in debug mode") do
     $DEBUG = true
   end

data/doc/FAQ

@@ -290,8 +290,7 @@ Question: I prefer to have the field "Author" as "Surname, Name" instead
 of "Name Surname".
 
 Answer: Alexandria relies on what the providers say: 
-some providers report "Surname, Name": Renaud,
-some "Surname Name": Webster.it, Ibs.it,
+some providers report "Surname Name": Webster.it, Ibs.it,
 some "Name Surname": Bn, Thalia, Bol.it, Adlibris, L Siciliano, Worldcat,
 and some without any rule: Amazon, Proxis.
 You can change, in the preferences, the order in which the providers are 

data/doc/dependency_decisions.yml

@@ -1,29 +1,29 @@
 ---
-- - :whitelist
+- - :permit
   - LGPL-3+
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:51:53.629753437 Z
-- - :whitelist
+- - :permit
   - LGPL-2.1+
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:52:02.088395832 Z
-- - :whitelist
+- - :permit
   - MIT
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:52:06.806192042 Z
-- - :whitelist
+- - :permit
   - LGPLv2+
   - :who: 
     :why: 
     :versions: []
     :when: 2017-07-23 05:52:24.618189811 Z
-- - :whitelist
+- - :permit
   - ruby
   - :who: 
     :why: 

data/lib/alexandria.rb

@@ -22,7 +22,9 @@ require "alexandria/about"
 
 module Alexandria
   def self.set_proxy
-    ENV["http_proxy"] = nil if !ENV["http_proxy"].nil? && URI.parse(ENV["http_proxy"]).userinfo.nil?
+    if !ENV["http_proxy"].nil? && URI.parse(ENV["http_proxy"]).userinfo.nil?
+      ENV["http_proxy"] = nil
+    end
   end
 
   def self.set_log_level

data/lib/alexandria/book_providers.rb

@@ -67,7 +67,7 @@ module Alexandria
           log.info { "found at " + factory.fullname }
           instance.changed
           instance.notify_observers(:found, factory.fullname) # new
-          return results
+          results
         end
       rescue StandardError => ex
         if ex.is_a? NoResultsError
@@ -291,9 +291,6 @@ module Alexandria
 
     require "alexandria/book_providers/douban" # only requires YAML
 
-    # require 'alexandria/book_providers/renaud'
-    log.info { "Not loading Renaud (provider not functional)" }
-
     # Amazon AWS (Amazon Associates Web Services) provider, needs hpricot
     require "alexandria/book_providers/amazon_aws"