alchemy_cms 5.0.1 → 5.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (118) hide show
  1. checksums.yaml +4 -4
  2. data/.github/PULL_REQUEST_TEMPLATE.md +1 -1
  3. data/.github/workflows/ci.yml +126 -0
  4. data/.github/workflows/stale.yml +1 -1
  5. data/.gitignore +1 -0
  6. data/CHANGELOG.md +66 -2
  7. data/CONTRIBUTING.md +2 -2
  8. data/Gemfile +2 -2
  9. data/README.md +2 -2
  10. data/alchemy_cms.gemspec +3 -3
  11. data/app/assets/images/alchemy/missing-image.svg +1 -0
  12. data/app/assets/javascripts/alchemy/admin.js +0 -1
  13. data/app/assets/javascripts/alchemy/alchemy.element_editors.js.coffee +1 -4
  14. data/app/assets/javascripts/alchemy/alchemy.preview.js.coffee +0 -3
  15. data/app/assets/javascripts/alchemy/alchemy.preview_window.js.coffee +29 -4
  16. data/app/assets/stylesheets/alchemy/_variables.scss +8 -0
  17. data/app/assets/stylesheets/alchemy/admin.scss +0 -1
  18. data/app/assets/stylesheets/alchemy/archive.scss +23 -17
  19. data/app/assets/stylesheets/alchemy/buttons.scss +26 -15
  20. data/app/assets/stylesheets/alchemy/elements.scss +58 -19
  21. data/app/assets/stylesheets/alchemy/errors.scss +1 -1
  22. data/app/assets/stylesheets/alchemy/frame.scss +0 -1
  23. data/app/assets/stylesheets/alchemy/hints.scss +2 -1
  24. data/app/assets/stylesheets/alchemy/navigation.scss +7 -10
  25. data/app/assets/stylesheets/alchemy/pagination.scss +1 -1
  26. data/app/assets/stylesheets/alchemy/search.scss +13 -3
  27. data/app/assets/stylesheets/alchemy/selects.scss +26 -20
  28. data/app/assets/stylesheets/alchemy/tables.scss +38 -9
  29. data/app/assets/stylesheets/alchemy/tags.scss +19 -31
  30. data/app/controllers/alchemy/admin/pages_controller.rb +58 -8
  31. data/app/controllers/alchemy/admin/pictures_controller.rb +13 -6
  32. data/app/controllers/alchemy/admin/resources_controller.rb +3 -3
  33. data/app/controllers/alchemy/pages_controller.rb +49 -14
  34. data/app/decorators/alchemy/element_editor.rb +1 -0
  35. data/app/helpers/alchemy/admin/base_helper.rb +0 -44
  36. data/app/helpers/alchemy/admin/navigation_helper.rb +2 -1
  37. data/app/models/alchemy/attachment.rb +20 -3
  38. data/app/models/alchemy/attachment/url.rb +40 -0
  39. data/app/models/alchemy/essence_picture.rb +3 -3
  40. data/app/models/alchemy/essence_picture_view.rb +5 -3
  41. data/app/models/alchemy/legacy_page_url.rb +1 -1
  42. data/app/models/alchemy/page.rb +24 -1
  43. data/app/models/alchemy/page/page_natures.rb +2 -0
  44. data/app/models/alchemy/page/url_path.rb +8 -6
  45. data/app/models/alchemy/picture.rb +58 -2
  46. data/app/models/alchemy/picture/calculations.rb +55 -0
  47. data/app/models/alchemy/picture/transformations.rb +5 -49
  48. data/app/models/alchemy/picture/url.rb +28 -77
  49. data/app/models/alchemy/picture_thumb.rb +57 -0
  50. data/app/models/alchemy/picture_thumb/create.rb +39 -0
  51. data/app/models/alchemy/picture_thumb/signature.rb +23 -0
  52. data/app/models/alchemy/picture_thumb/uid.rb +22 -0
  53. data/app/models/alchemy/picture_variant.rb +114 -0
  54. data/app/models/alchemy/site/layout.rb +30 -2
  55. data/app/serializers/alchemy/page_tree_serializer.rb +4 -4
  56. data/app/views/alchemy/admin/attachments/show.html.erb +8 -8
  57. data/app/views/alchemy/admin/dashboard/index.html.erb +13 -16
  58. data/app/views/alchemy/admin/elements/_element_footer.html.erb +1 -1
  59. data/app/views/alchemy/admin/elements/publish.js.erb +1 -0
  60. data/app/views/alchemy/admin/essence_pictures/crop.html.erb +1 -1
  61. data/app/views/alchemy/admin/essence_pictures/edit.html.erb +2 -2
  62. data/app/views/alchemy/admin/layoutpages/edit.html.erb +4 -6
  63. data/app/views/alchemy/admin/pages/_create_language_form.html.erb +19 -29
  64. data/app/views/alchemy/admin/pages/_form.html.erb +4 -6
  65. data/app/views/alchemy/admin/pages/_new_page_form.html.erb +12 -2
  66. data/app/views/alchemy/admin/pages/_page_layout_filter.html.erb +29 -0
  67. data/app/views/alchemy/admin/pages/_table.html.erb +27 -0
  68. data/app/views/alchemy/admin/pages/_table_row.html.erb +107 -0
  69. data/app/views/alchemy/admin/pages/_toolbar.html.erb +77 -0
  70. data/app/views/alchemy/admin/pages/edit.html.erb +9 -1
  71. data/app/views/alchemy/admin/pages/index.html.erb +41 -74
  72. data/app/views/alchemy/admin/pages/list/_table.html.erb +31 -0
  73. data/app/views/alchemy/admin/pages/unlock.js.erb +2 -2
  74. data/app/views/alchemy/admin/pages/update.js.erb +19 -10
  75. data/app/views/alchemy/admin/partials/_remote_search_form.html.erb +14 -13
  76. data/app/views/alchemy/admin/partials/_search_form.html.erb +8 -8
  77. data/app/views/alchemy/admin/pictures/_archive.html.erb +1 -1
  78. data/app/views/alchemy/admin/pictures/_form.html.erb +1 -1
  79. data/app/views/alchemy/admin/pictures/_picture.html.erb +3 -3
  80. data/app/views/alchemy/admin/pictures/_picture_to_assign.html.erb +1 -1
  81. data/app/views/alchemy/admin/pictures/edit_multiple.html.erb +1 -1
  82. data/app/views/alchemy/admin/pictures/index.html.erb +1 -1
  83. data/app/views/alchemy/admin/pictures/show.html.erb +3 -3
  84. data/app/views/alchemy/admin/resources/_filter_bar.html.erb +13 -11
  85. data/app/views/alchemy/admin/resources/_per_page_select.html.erb +3 -3
  86. data/app/views/alchemy/admin/resources/index.html.erb +4 -1
  87. data/app/views/alchemy/admin/tags/index.html.erb +14 -15
  88. data/app/views/alchemy/base/500.html.erb +11 -13
  89. data/app/views/alchemy/essences/_essence_file_view.html.erb +3 -3
  90. data/config/alchemy/config.yml +15 -11
  91. data/config/alchemy/modules.yml +12 -12
  92. data/config/locales/alchemy.en.yml +6 -4
  93. data/config/routes.rb +1 -1
  94. data/db/migrate/20200617110713_create_alchemy_picture_thumbs.rb +22 -0
  95. data/db/migrate/20200907111332_remove_tri_state_booleans.rb +33 -0
  96. data/lib/alchemy.rb +66 -0
  97. data/lib/alchemy/admin/preview_url.rb +2 -0
  98. data/lib/alchemy/auth_accessors.rb +12 -5
  99. data/lib/alchemy/config.rb +1 -3
  100. data/lib/alchemy/engine.rb +7 -6
  101. data/lib/alchemy/modules.rb +11 -1
  102. data/lib/alchemy/permissions.rb +1 -0
  103. data/lib/alchemy/test_support/factories/picture_factory.rb +0 -1
  104. data/lib/alchemy/test_support/factories/picture_thumb_factory.rb +12 -0
  105. data/lib/alchemy/test_support/integration_helpers.rb +0 -7
  106. data/lib/alchemy/version.rb +1 -1
  107. data/lib/alchemy_cms.rb +2 -4
  108. data/lib/generators/alchemy/install/files/alchemy.en.yml +2 -2
  109. data/lib/generators/alchemy/install/templates/dragonfly.rb.tt +5 -5
  110. data/lib/tasks/alchemy/thumbnails.rake +37 -0
  111. data/vendor/assets/javascripts/jquery_plugins/select2.js +3729 -0
  112. data/vendor/assets/stylesheets/alchemy_admin/select2.scss +740 -0
  113. metadata +46 -37
  114. data/.github/workflows/greetings.yml +0 -13
  115. data/.travis.yml +0 -48
  116. data/app/controllers/concerns/alchemy/locale_redirects.rb +0 -40
  117. data/app/controllers/concerns/alchemy/page_redirects.rb +0 -68
  118. data/lib/alchemy/userstamp.rb +0 -12
@@ -30,11 +30,22 @@ module Alchemy
30
30
 
31
31
  CONVERTIBLE_FILE_FORMATS = %w(gif jpg jpeg png).freeze
32
32
 
33
+ TRANSFORMATION_OPTIONS = [
34
+ :crop,
35
+ :crop_from,
36
+ :crop_size,
37
+ :flatten,
38
+ :format,
39
+ :quality,
40
+ :size,
41
+ :upsample,
42
+ ]
43
+
44
+ include Alchemy::Logger
33
45
  include Alchemy::NameConversions
34
46
  include Alchemy::Taggable
35
47
  include Alchemy::TouchElements
36
- include Alchemy::Picture::Transformations
37
- include Alchemy::Picture::Url
48
+ include Calculations
38
49
 
39
50
  has_many :essence_pictures,
40
51
  class_name: "Alchemy::EssencePicture",
@@ -44,6 +55,7 @@ module Alchemy
44
55
  has_many :contents, through: :essence_pictures
45
56
  has_many :elements, through: :contents
46
57
  has_many :pages, through: :elements
58
+ has_many :thumbs, class_name: "Alchemy::PictureThumb", dependent: :destroy
47
59
 
48
60
  # Raise error, if picture is in use (aka. assigned to an EssencePicture)
49
61
  #
@@ -78,6 +90,9 @@ module Alchemy
78
90
  end
79
91
  end
80
92
 
93
+ # Create important thumbnails upfront
94
+ after_create -> { PictureThumb.generate_thumbs!(self) }
95
+
81
96
  # We need to define this method here to have it available in the validations below.
82
97
  class << self
83
98
  def allowed_filetypes
@@ -103,6 +118,20 @@ module Alchemy
103
118
  # Class methods
104
119
 
105
120
  class << self
121
+ # The class used to generate URLs for pictures
122
+ #
123
+ # @see Alchemy::Picture::Url
124
+ def url_class
125
+ @_url_class ||= Alchemy::Picture::Url
126
+ end
127
+
128
+ # Set a different picture url class
129
+ #
130
+ # @see Alchemy::Picture::Url
131
+ def url_class=(klass)
132
+ @_url_class = klass
133
+ end
134
+
106
135
  def searchable_alchemy_resource_attributes
107
136
  %w(name image_file_name)
108
137
  end
@@ -145,6 +174,33 @@ module Alchemy
145
174
 
146
175
  # Instance methods
147
176
 
177
+ # Returns an url (or relative path) to a processed image for use inside an image_tag helper.
178
+ #
179
+ # Any additional options are passed to the url method, so you can add params to your url.
180
+ #
181
+ # Example:
182
+ #
183
+ # <%= image_tag picture.url(size: '320x200', format: 'png') %>
184
+ #
185
+ # @see Alchemy::PictureVariant#call for transformation options
186
+ # @see Alchemy::Picture::Url#call for url options
187
+ # @return [String|Nil]
188
+ def url(options = {})
189
+ return unless image_file
190
+
191
+ variant = PictureVariant.new(self, options.slice(*TRANSFORMATION_OPTIONS))
192
+ self.class.url_class.new(variant).call(
193
+ options.except(*TRANSFORMATION_OPTIONS).merge(
194
+ basename: name,
195
+ ext: variant.render_format,
196
+ name: name,
197
+ )
198
+ )
199
+ rescue ::Dragonfly::Job::Fetch::NotFound => e
200
+ log_warning(e.message)
201
+ nil
202
+ end
203
+
148
204
  def previous(params = {})
149
205
  query = Picture.ransack(params[:q])
150
206
  Picture.search_by(params, query).where("name < ?", name).last
@@ -0,0 +1,55 @@
1
+ # frozen_string_literal: true
2
+
3
+ module Alchemy
4
+ class Picture < BaseRecord
5
+ module Calculations
6
+ # An Image smaller than dimensions
7
+ # can not be cropped to given size - unless upsample is true.
8
+ #
9
+ def can_be_cropped_to?(string, upsample = false)
10
+ return true if upsample
11
+
12
+ is_bigger_than? sizes_from_string(string)
13
+ end
14
+
15
+ # Returns true if both dimensions of the base image are bigger than the dimensions hash.
16
+ #
17
+ def is_bigger_than?(dimensions)
18
+ image_file_width > dimensions[:width] && image_file_height > dimensions[:height]
19
+ end
20
+
21
+ # Returns true is one dimension of the base image is smaller than the dimensions hash.
22
+ #
23
+ def is_smaller_than?(dimensions)
24
+ !is_bigger_than?(dimensions)
25
+ end
26
+
27
+ # Given a string with an x, this function returns a Hash with point
28
+ # :width and :height.
29
+ #
30
+ def sizes_from_string(string = "0x0")
31
+ string = "0x0" if string.nil? || string.empty?
32
+
33
+ raise ArgumentError unless string =~ /(\d*x\d*)/
34
+
35
+ width, height = string.scan(/(\d*)x(\d*)/)[0].map(&:to_i)
36
+
37
+ width = 0 if width.nil?
38
+ height = 0 if height.nil?
39
+ {
40
+ width: width,
41
+ height: height,
42
+ }
43
+ end
44
+
45
+ # This function returns the :width and :height of the image file
46
+ # as a Hash
47
+ def image_size
48
+ {
49
+ width: image_file_width,
50
+ height: image_file_height,
51
+ }
52
+ end
53
+ end
54
+ end
55
+ end
@@ -7,6 +7,10 @@ module Alchemy
7
7
  module Picture::Transformations
8
8
  extend ActiveSupport::Concern
9
9
 
10
+ included do
11
+ include Alchemy::Picture::Calculations
12
+ end
13
+
10
14
  THUMBNAIL_WIDTH = 160
11
15
  THUMBNAIL_HEIGHT = 120
12
16
 
@@ -66,24 +70,6 @@ module Alchemy
66
70
  image_file.thumb(upsample ? size : "#{size}>")
67
71
  end
68
72
 
69
- # Given a string with an x, this function returns a Hash with point
70
- # :width and :height.
71
- #
72
- def sizes_from_string(string = "0x0")
73
- string = "0x0" if string.nil? || string.empty?
74
-
75
- raise ArgumentError unless string =~ /(\d*x\d*)/
76
-
77
- width, height = string.scan(/(\d*)x(\d*)/)[0].map(&:to_i)
78
-
79
- width = 0 if width.nil?
80
- height = 0 if height.nil?
81
- {
82
- width: width,
83
- height: height,
84
- }
85
- end
86
-
87
73
  # Returns true if picture's width is greater than it's height
88
74
  #
89
75
  def landscape_format?
@@ -105,24 +91,6 @@ module Alchemy
105
91
  end
106
92
  alias_method :square?, :square_format?
107
93
 
108
- # This function returns the :width and :height of the image file
109
- # as a Hash
110
- def image_size
111
- {
112
- width: image_file_width,
113
- height: image_file_height,
114
- }
115
- end
116
-
117
- # An Image smaller than dimensions
118
- # can not be cropped to given size - unless upsample is true.
119
- #
120
- def can_be_cropped_to(string, upsample = false)
121
- return true if upsample
122
-
123
- is_bigger_than sizes_from_string(string)
124
- end
125
-
126
94
  # Returns true if the class we're included in has a meaningful render_size attribute
127
95
  #
128
96
  def render_size?
@@ -217,22 +185,10 @@ module Alchemy
217
185
  "#{dimensions[:width]}x#{dimensions[:height]}"
218
186
  end
219
187
 
220
- # Returns true if both dimensions of the base image are bigger than the dimensions hash.
221
- #
222
- def is_bigger_than(dimensions)
223
- image_file_width > dimensions[:width] && image_file_height > dimensions[:height]
224
- end
225
-
226
- # Returns true is one dimension of the base image is smaller than the dimensions hash.
227
- #
228
- def is_smaller_than(dimensions)
229
- !is_bigger_than(dimensions)
230
- end
231
-
232
188
  # Uses imagemagick to make a centercropped thumbnail. Does not scale the image up.
233
189
  #
234
190
  def center_crop(dimensions, upsample)
235
- if is_smaller_than(dimensions) && upsample == false
191
+ if is_smaller_than?(dimensions) && upsample == false
236
192
  dimensions = reduce_to_image(dimensions)
237
193
  end
238
194
  image_file.thumb("#{dimensions_to_string(dimensions)}#")
@@ -1,94 +1,45 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module Alchemy
4
- module Picture::Url
5
- include Alchemy::Logger
4
+ class Picture < BaseRecord
5
+ class Url
6
+ attr_reader :variant
6
7
 
7
- TRANSFORMATION_OPTIONS = [
8
- :crop,
9
- :crop_from,
10
- :crop_size,
11
- :flatten,
12
- :format,
13
- :quality,
14
- :size,
15
- :upsample,
16
- ]
8
+ # @param [Alchemy::PictureVariant]
9
+ #
10
+ def initialize(variant)
11
+ raise ArgumentError, "Variant missing!" if variant.nil?
17
12
 
18
- # Returns a path to picture for use inside a image_tag helper.
19
- #
20
- # Any additional options are passed to the url_helper, so you can add arguments to your url.
21
- #
22
- # Example:
23
- #
24
- # <%= image_tag picture.url(size: '320x200', format: 'png') %>
25
- #
26
- def url(options = {})
27
- image = image_file
28
-
29
- raise MissingImageFileError, "Missing image file for #{inspect}" if image.nil?
30
-
31
- image = processed_image(image, options)
32
- image = encoded_image(image, options)
33
-
34
- image.url(options.except(*TRANSFORMATION_OPTIONS).merge(name: name))
35
- rescue MissingImageFileError, WrongImageFormatError => e
36
- log_warning e.message
37
- nil
38
- end
39
-
40
- private
41
-
42
- # Returns the processed image dependent of size and cropping parameters
43
- def processed_image(image, options = {})
44
- size = options[:size]
45
- upsample = !!options[:upsample]
46
-
47
- return image unless size.present? && has_convertible_format?
48
-
49
- if options[:crop]
50
- crop(size, options[:crop_from], options[:crop_size], upsample)
51
- else
52
- resize(size, upsample)
13
+ @variant = variant
53
14
  end
54
- end
55
15
 
56
- # Returns the encoded image
57
- #
58
- # Flatten animated gifs, only if converting to a different format.
59
- # Can be overwritten via +options[:flatten]+.
60
- #
61
- def encoded_image(image, options = {})
62
- target_format = options[:format] || default_render_format
16
+ # The URL to a variant of a picture
17
+ #
18
+ # @return [String]
19
+ #
20
+ def call(params = {})
21
+ return variant.image.url(params) unless processible_image?
63
22
 
64
- unless target_format.in?(Alchemy::Picture.allowed_filetypes)
65
- raise WrongImageFormatError.new(self, target_format)
23
+ "/#{uid}"
66
24
  end
67
25
 
68
- options = {
69
- flatten: target_format != "gif" && image_file_format == "gif",
70
- }.with_indifferent_access.merge(options)
71
-
72
- encoding_options = []
26
+ private
73
27
 
74
- convert_format = target_format != image_file_format.sub("jpeg", "jpg")
75
-
76
- if target_format =~ /jpe?g/ && convert_format
77
- quality = options[:quality] || Config.get(:output_image_jpg_quality)
78
- encoding_options << "-quality #{quality}"
28
+ def processible_image?
29
+ variant.image.is_a?(::Dragonfly::Job)
79
30
  end
80
31
 
81
- if options[:flatten]
82
- encoding_options << "-flatten"
32
+ def uid
33
+ signature = PictureThumb::Signature.call(variant)
34
+ thumb = variant.picture.thumbs.detect { |t| t.signature == signature }
35
+ if thumb
36
+ uid = thumb.uid
37
+ else
38
+ uid = PictureThumb::Uid.call(signature, variant)
39
+ PictureThumb.generator_class.call(variant, signature, uid)
40
+ end
41
+ uid
83
42
  end
84
-
85
- convertion_needed = convert_format || encoding_options.present?
86
-
87
- if has_convertible_format? && convertion_needed
88
- image = image.encode(target_format, encoding_options.join(" "))
89
- end
90
-
91
- image
92
43
  end
93
44
  end
94
45
  end
@@ -0,0 +1,57 @@
1
+ # frozen_string_literal: true
2
+
3
+ module Alchemy
4
+ # The persisted version of a rendered picture variant
5
+ #
6
+ # You can configure the generator class to implement a
7
+ # different thumbnail store (ie. a remote file storage).
8
+ #
9
+ # config/initializers/alchemy.rb
10
+ # Alchemy::PictureThumb.generator_class = My::ThumbnailGenerator
11
+ #
12
+ class PictureThumb < BaseRecord
13
+ belongs_to :picture, class_name: "Alchemy::Picture"
14
+
15
+ validates :signature, presence: true
16
+ validates :uid, presence: true
17
+
18
+ class << self
19
+ # Thumbnail generator class
20
+ #
21
+ # @see Alchemy::PictureThumb::Create
22
+ def generator_class
23
+ @_generator_class ||= Alchemy::PictureThumb::Create
24
+ end
25
+
26
+ # Set a thumbnail generator class
27
+ #
28
+ # @see Alchemy::PictureThumb::Create
29
+ def generator_class=(klass)
30
+ @_generator_class = klass
31
+ end
32
+
33
+ # Upfront generation of picture thumbnails
34
+ #
35
+ # Called after a Alchemy::Picture has been created (after an image has been uploaded)
36
+ #
37
+ # Generates three types of thumbnails that are used by Alchemys picture archive and
38
+ # persists them in the configures file store (Default Dragonfly::FileDataStore).
39
+ #
40
+ # @see Picture::THUMBNAIL_SIZES
41
+ def generate_thumbs!(picture)
42
+ Alchemy::Picture::THUMBNAIL_SIZES.values.each do |size|
43
+ variant = Alchemy::PictureVariant.new(picture, {
44
+ size: size,
45
+ flatten: true,
46
+ })
47
+ signature = Alchemy::PictureThumb::Signature.call(variant)
48
+ thumb = find_by(signature: signature)
49
+ next if thumb
50
+
51
+ uid = Alchemy::PictureThumb::Uid.call(signature, variant)
52
+ generator_class.call(variant, signature, uid)
53
+ end
54
+ end
55
+ end
56
+ end
57
+ end
@@ -0,0 +1,39 @@
1
+ # frozen_string_literal: true
2
+
3
+ module Alchemy
4
+ class PictureThumb < BaseRecord
5
+ # Stores the render result of a Alchemy::PictureVariant
6
+ # in the configured Dragonfly datastore
7
+ # (Default: Dragonfly::FileDataStore)
8
+ #
9
+ class Create
10
+ class << self
11
+ # @param [Alchemy::PictureVariant] variant the to be rendered image
12
+ # @param [String] signature A unique hashed version of the rendering options
13
+ # @param [String] uid The Unique Image Identifier the image is stored at
14
+ #
15
+ # @return [Alchemy::PictureThumb] The persisted thumbnail record
16
+ #
17
+ def call(variant, signature, uid)
18
+ image = variant.image
19
+ image.to_file(server_path(uid)).close
20
+ variant.picture.thumbs.create!(
21
+ picture: variant.picture,
22
+ signature: signature,
23
+ uid: uid,
24
+ )
25
+ end
26
+
27
+ private
28
+
29
+ # Alchemys dragonfly datastore config seperates the storage path from the public server
30
+ # path for security reasons. The Dragonfly FileDataStorage does not support that,
31
+ # so we need to build the path on our own.
32
+ def server_path(uid)
33
+ dragonfly_app = ::Dragonfly.app(:alchemy_pictures)
34
+ "#{dragonfly_app.datastore.server_root}/#{uid}"
35
+ end
36
+ end
37
+ end
38
+ end
39
+ end