alchemy_cms 5.0.1 → 5.1.0

data/app/controllers/alchemy/admin/pictures_controller.rb

@@ -11,16 +11,18 @@ module Alchemy
       before_action :load_resource,
         only: [:show, :edit, :update, :destroy, :info]
 
+      before_action :set_size, only: [:index, :show, :edit_multiple]
+
       authorize_resource class: Alchemy::Picture
 
       def index
-        @size = params[:size].present? ? params[:size] : "medium"
         @query = Picture.ransack(search_filter_params[:q])
         @pictures = Picture.search_by(
           search_filter_params,
           @query,
           items_per_page,
         )
+        @pictures = @pictures.includes(:thumbs)
 
         if in_overlay?
           archive_overlay
@@ -115,7 +117,7 @@ module Alchemy
 
       def items_per_page
         if in_overlay?
-          case params[:size]
+          case @size
           when "small" then 25
           when "large" then 4
           else
@@ -124,19 +126,24 @@ module Alchemy
         else
           cookies[:alchemy_pictures_per_page] = params[:per_page] ||
             cookies[:alchemy_pictures_per_page] ||
-            pictures_per_page_for_size(params[:size])
+            pictures_per_page_for_size
         end
       end
 
       def items_per_page_options
-        per_page = pictures_per_page_for_size(@size)
+        per_page = pictures_per_page_for_size
         [per_page, per_page * 2, per_page * 4]
       end
 
       private
 
-      def pictures_per_page_for_size(size)
-        case size
+      def set_size
+        @size = params[:size] || session[:alchemy_pictures_size] || "medium"
+        session[:alchemy_pictures_size] = @size
+      end
+
+      def pictures_per_page_for_size
+        case @size
         when "small" then 60
         when "large" then 12
         else

data/app/controllers/alchemy/admin/resources_controller.rb

@@ -148,15 +148,15 @@ module Alchemy
 
       def common_search_filter_includes
         [
-          {q: [
+          { q: [
             resource_handler.search_field_name,
             :s,
-          ]},
+          ] },
           :tagged_with,
           :filter,
           :page,
           :per_page,
-        ].freeze
+        ]
       end
 
       def items_per_page

data/app/controllers/alchemy/pages_controller.rb

@@ -13,7 +13,10 @@ module Alchemy
 
     # Redirecting concerns. Order is important here!
     include SiteRedirects
-    include LocaleRedirects
+
+    before_action :enforce_no_locale,
+      if: :locale_prefix_not_allowed?,
+      only: [:index, :show]
 
     before_action :load_index_page, only: [:index]
     before_action :load_page, only: [:show]
@@ -21,11 +24,13 @@ module Alchemy
     # Legacy page redirects need to run after the page was loaded and before we render 404.
     include LegacyPageRedirects
 
-    # From here on, we need a +@page+ to work with!
-    before_action :page_not_found!, if: -> { @page.blank? }, only: [:index, :show]
+    # From here on, we need a published +@page+ to work with!
+    before_action :page_not_found!, unless: -> { @page&.public? }, only: [:index, :show]
 
-    # Page redirects need to run after the page was loaded and we're sure to have a +@page+ set.
-    include PageRedirects
+    # Page redirects need to run after the page was loaded and we're sure to have a public +@page+ set.
+    before_action :enforce_locale,
+      if: :locale_prefix_missing?,
+      only: [:index, :show]
 
     # We only need to set the +@root_page+ if we are sure that no more redirects happen.
     before_action :set_root_page, only: [:index, :show]
@@ -66,12 +71,8 @@ module Alchemy
     # descendant it finds. If no public page can be found it renders a 404 error.
     #
     def show
-      if redirect_url.present?
-        redirect_permanently_to redirect_url
-      else
-        authorize! :show, @page
-        render_page if render_fresh_page?
-      end
+      authorize! :show, @page
+      render_page if render_fresh_page?
     end
 
     # Renders a search engine compatible xml sitemap.
@@ -84,13 +85,25 @@ module Alchemy
 
     private
 
+    # Redirects to requested action without locale prefixed
+    def enforce_no_locale
+      redirect_permanently_to additional_params.merge(locale: nil)
+    end
+
+    # Is the requested locale allowed?
+    #
+    # If Alchemy is not in multi language mode or the requested locale is the default locale,
+    # then we want to redirect to a non prefixed url.
+    #
+    def locale_prefix_not_allowed?
+      params[:locale].present? && !multi_language? ||
+        params[:locale].presence == ::I18n.default_locale.to_s
+    end
+
     # == Loads index page
     #
     # Loads the current public language root page.
     #
-    # If the root page is not public it redirects to the first published child.
-    # This can be configured via +redirect_to_public_child+ [default: true]
-    #
     # If no index page and no admin users are present we show the "Welcome to Alchemy" page.
     #
     def load_index_page
@@ -116,6 +129,28 @@ module Alchemy
       )
     end
 
+    def enforce_locale
+      redirect_permanently_to page_locale_redirect_url(locale: Language.current.code)
+    end
+
+    def locale_prefix_missing?
+      multi_language? && params[:locale].blank? && !default_locale?
+    end
+
+    def default_locale?
+      Language.current.code.to_sym == ::I18n.default_locale.to_sym
+    end
+
+    # Page url with or without locale while keeping all additional params
+    def page_locale_redirect_url(options = {})
+      options = {
+        locale: prefix_locale? ? @page.language_code : nil,
+        urlname: @page.urlname,
+      }.merge(options)
+
+      alchemy.show_page_path additional_params.merge(options)
+    end
+
     # Redirects to given url with 301 status
     def redirect_permanently_to(url)
       redirect_to url, status: :moved_permanently

data/app/decorators/alchemy/element_editor.rb

@@ -18,6 +18,7 @@ module Alchemy
         folded ? "folded" : "expanded",
         compact? ? "compact" : nil,
         fixed? ? "is-fixed" : "not-fixed",
+        public? ? "visible" : "hidden",
       ].join(" ")
     end
 

data/app/helpers/alchemy/admin/base_helper.rb

@@ -272,50 +272,6 @@ module Alchemy
         end
       end
 
-      # Renders the toolbar shown on top of the records.
-      #
-      # == Example
-      #
-      #   <% label_title = Alchemy.t("Create #{resource_name}", default: Alchemy.t('Create')) %>
-      #   <% toolbar(
-      #     buttons: [
-      #       {
-      #         icon: :plus,
-      #         label: label_title,
-      #         url: new_resource_path,
-      #         title: label_title,
-      #         hotkey: 'alt+n',
-      #         dialog_options: {
-      #           title: label_title,
-      #           size: "430x400"
-      #         },
-      #         if_permitted_to: [:create, resource_model]
-      #       }
-      #     ]
-      #   ) %>
-      #
-      # @option options [Array] :buttons ([])
-      #   Pass an Array with button options. They will be passed to {#toolbar_button} helper.
-      # @option options [Boolean] :search (true)
-      #   Show searchfield.
-      #
-      def toolbar(options = {})
-        defaults = {
-          buttons: [],
-          search: true,
-        }
-        options = defaults.merge(options)
-        content_for(:toolbar) do
-          content = <<-CONTENT.strip_heredoc
-            #{options[:buttons].map { |button_options| toolbar_button(button_options) }.join}
-            #{render("alchemy/admin/partials/search_form", url: options[:search_url]) if options[:search]}
-          CONTENT
-          content.html_safe
-        end
-      end
-
-      deprecate toolbar: "Please use `content_for(:toolbar)` instead", deprecator: Alchemy::Deprecation
-
       # (internal) Used by upload form
       def new_asset_path_with_session_information(asset_type)
         session_key = Rails.application.config.session_options[:key]

data/app/helpers/alchemy/admin/navigation_helper.rb

@@ -175,7 +175,8 @@ module Alchemy
       # Returns true if the given entry's controller is current controller
       #
       def is_entry_controller_active?(entry)
-        entry["controller"].gsub(/\A\//, "") == params[:controller]
+        entry["controller"].gsub(/\A\//, "") == params[:controller] ||
+          entry.fetch("nested_controllers", []).include?(params[:controller])
       end
 
       # Returns true if the given entry's action is current controllers action

data/app/models/alchemy/attachment.rb

@@ -37,6 +37,20 @@ module Alchemy
 
     # We need to define this method here to have it available in the validations below.
     class << self
+      # The class used to generate URLs for attachments
+      #
+      # @see Alchemy::Attachment::Url
+      def url_class
+        @_url_class ||= Alchemy::Attachment::Url
+      end
+
+      # Set a different attachment url class
+      #
+      # @see Alchemy::Attachment::Url
+      def url_class=(klass)
+        @_url_class = klass
+      end
+
       def searchable_alchemy_resource_attributes
         %w(name file_name)
       end
@@ -76,14 +90,17 @@ module Alchemy
       }
     end
 
+    def url(options = {})
+      if file
+        self.class.url_class.new(self).call(options)
+      end
+    end
+
     # An url save filename without format suffix
     def slug
       CGI.escape(file_name.gsub(/\.#{extension}$/, "").tr(".", " "))
     end
 
-    alias_method :urlname, :slug
-    deprecate urlname: :slug, deprecator: Alchemy::Deprecation
-
     # Checks if the attachment is restricted, because it is attached on restricted pages only
     def restricted?
       pages.any? && pages.not_restricted.blank?

data/app/models/alchemy/attachment/url.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module Alchemy
+  class Attachment < BaseRecord
+    # The class representing an URL to an attachment
+    #
+    # Set a different one
+    #
+    #     Alchemy::Attachment.url_class = MyRemoteUrlClass
+    #
+    class Url
+      def initialize(attachment)
+        @attachment = attachment
+      end
+
+      # The attachment url
+      #
+      # @param [Hash] options
+      # @option options [Symbol] :download return a URL for downloading the attachment
+      # @option options [Symbol] :name The filename
+      # @option options [Symbol] :format The file extension
+      #
+      # @return [String]
+      #
+      def call(options = {})
+        if options.delete(:download)
+          routes.download_attachment_path(@attachment, options)
+        else
+          routes.show_attachment_path(@attachment, options)
+        end
+      end
+
+      private
+
+      def routes
+        Alchemy::Engine.routes.url_helpers
+      end
+    end
+  end
+end

data/app/models/alchemy/essence_picture.rb

@@ -62,7 +62,7 @@ module Alchemy
     def picture_url(options = {})
       return if picture.nil?
 
-      picture.url picture_url_options.merge(options)
+      picture.url(picture_url_options.merge(options)) || "missing-image.png"
     end
 
     # Picture rendering options
@@ -103,7 +103,7 @@ module Alchemy
         format: picture.image_file_format,
       }
 
-      picture.url(options)
+      picture.url(options) || "alchemy/missing-image.svg"
     end
 
     # The name of the picture used as preview text in element editor views.
@@ -140,7 +140,7 @@ module Alchemy
     # Show image cropping link for content
     def allow_image_cropping?
       content && content.settings[:crop] && picture &&
-        picture.can_be_cropped_to(
+        picture.can_be_cropped_to?(
           content.settings[:size],
           content.settings[:upsample],
         ) && !!picture.image_file

data/app/models/alchemy/essence_picture_view.rb

@@ -44,17 +44,19 @@ module Alchemy
       end
     end
 
-    private
-
     def caption
       return unless show_caption?
 
       @_caption ||= content_tag(:figcaption, essence.caption)
     end
 
+    def src
+      essence.picture_url(options.except(*DEFAULT_OPTIONS.keys))
+    end
+
     def img_tag
       @_img_tag ||= image_tag(
-        essence.picture_url(options.except(*DEFAULT_OPTIONS.keys)), {
+        src, {
           alt: alt_text,
           title: essence.title.presence,
           class: caption ? nil : essence.css_class.presence,

data/app/models/alchemy/legacy_page_url.rb

@@ -18,5 +18,5 @@ class Alchemy::LegacyPageUrl < ActiveRecord::Base
 
   validates :urlname,
     presence: true,
-    format: {with: /\A[:\.\w\-+_\/\?&%;=]*\z/}
+    format: {with: /\A[:\.\w\-+_\/\?&%;=#]*\z/}
 end

data/app/models/alchemy/page.rb

@@ -149,6 +149,29 @@ module Alchemy
     # Class methods
     #
     class << self
+      # The url_path class
+      # @see Alchemy::Page::UrlPath
+      def url_path_class
+        @_url_path_class ||= Alchemy::Page::UrlPath
+      end
+
+      # Set a custom url path class
+      #
+      #     # config/initializers/alchemy.rb
+      #     Alchemy::Page.url_path_class = MyPageUrlPathClass
+      #
+      def url_path_class=(klass)
+        @_url_path_class = klass
+      end
+
+      def alchemy_resource_filters
+        %w[published not_public restricted]
+      end
+
+      def searchable_alchemy_resource_attributes
+        %w[name urlname title]
+      end
+
       # Used to store the current page previewed in the edit page template.
       #
       def current_preview=(page)
@@ -298,7 +321,7 @@ module Alchemy
     #
     # @see Alchemy::Page::UrlPath#call
     def url_path
-      Alchemy::Page::UrlPath.new(self).call
+      self.class.url_path_class.new(self).call
     end
 
     # The page's view partial is dependent from its page layout

data/app/models/alchemy/page/page_natures.rb

@@ -17,6 +17,8 @@ module Alchemy
       definition["taggable"] == true
     end
 
+    deprecate :taggable?, deprecator: Alchemy::Deprecation
+
     def rootpage?
       !new_record? && parent_id.blank?
     end

data/app/models/alchemy/page/url_path.rb

@@ -20,8 +20,6 @@ module Alchemy
     #     link_to page.url
     #
     class UrlPath
-      ROOT_PATH = "/"
-
       def initialize(page)
         @page = page
         @language = @page.language
@@ -41,7 +39,7 @@ module Alchemy
       private
 
       def language_root_path
-        @language.default? ? ROOT_PATH : language_path
+        @language.default? ? root_path : language_path
       end
 
       def page_path_with_language_prefix
@@ -49,15 +47,19 @@ module Alchemy
       end
 
       def page_path_with_leading_slash
-        @page.language_root? ? ROOT_PATH : page_path
+        @page.language_root? ? root_path : page_path
       end
 
       def language_path
-        "/#{@page.language_code}"
+        "#{root_path}#{@page.language_code}"
       end
 
       def page_path
-        "/#{@page.urlname}"
+        "#{root_path}#{@page.urlname}"
+      end
+
+      def root_path
+        Engine.routes.url_helpers.root_path
       end
     end
   end