alchemy_cms 2.9.1 → 3.0.0.rc5

data/spec/helpers/admin/elements_helper_spec.rb

@@ -1,46 +1,39 @@
 require 'spec_helper'
 
 module Alchemy
-
-  include BaseHelper
-
   describe Admin::ElementsHelper do
 
-    context "partial rendering" do
-
-      before do
-        @page = FactoryGirl.create(:public_page)
-        @element = FactoryGirl.create(:element, :page => @page, :create_contents_after_create => true)
-      end
+    let(:page)    { build_stubbed(:public_page) }
+    let(:element) { build_stubbed(:element, page: page) }
 
+    context "partial rendering" do
       it "should render an element editor partial" do
-        helper.render_editor(@element).should match(/class="essence_text content_editor".+id="essence_text_\d{1,}"/)
+        should_receive(:render_element).with(element, :editor)
+        render_editor(element)
       end
 
       it "should render a picture gallery editor partial" do
-        helper.render_picture_gallery_editor(@element).should match(/class=".+picture_gallery_editor"/)
+        render_picture_gallery_editor(element).should match(/class=".+picture_gallery_editor"/)
       end
-
     end
 
     describe "#grouped_elements_for_select" do
-
-      before do
-        @page = FactoryGirl.create(:public_page)
-      end
-
-      before(:each) do
-        @page.stub!(:layout_description).and_return({'name' => "foo", 'cells' => ["foo_cell"]})
-        cell_descriptions = [{'name' => "foo_cell", 'elements' => ["1", "2"]}]
-        @elements = [
+      let(:elements) {
+        [
           mock_model('Element', name: '1', display_name: '1'),
           mock_model('Element', name: '2', display_name: '2')
         ]
-        Alchemy::Cell.stub!(:definitions).and_return(cell_descriptions)
+      }
+
+      before do
+        page.stub(layout_description: {'name' => "foo", 'cells' => ["foo_cell"]})
+        cell_descriptions = [{'name' => "foo_cell", 'elements' => ["1", "2"]}]
+        Cell.stub(:definitions).and_return(cell_descriptions)
+        helper.instance_variable_set('@page', page)
       end
 
-      it "should return string of elements grouped by cell for select_tag helper" do
-        helper.grouped_elements_for_select(@elements).should == helper.grouped_options_for_select({"Foo cell" => [["1", "1#foo_cell"], ["2", "2#foo_cell"]]})
+      it "should return array of elements grouped by cell for select_tag helper" do
+        helper.grouped_elements_for_select(elements).should include("Foo cell" => [["1", "1#foo_cell"], ["2", "2#foo_cell"]])
       end
 
       context "with empty elements array" do
@@ -51,15 +44,13 @@ module Alchemy
 
       context "with empty cell definitions" do
         it "should return an empty string" do
-          @page.stub!(:layout_description).and_return({'name' => "foo"})
-          helper.grouped_elements_for_select(@elements).should == ""
+          page.stub(layout_description: {'name' => "foo"})
+          helper.grouped_elements_for_select(elements).should == ""
         end
       end
-
     end
 
     describe "#elements_for_select" do
-
       context "passing element instances" do
         let(:element_objects) do
           [
@@ -68,9 +59,9 @@ module Alchemy
           ]
         end
 
-        it "should return a String with html option tags" do
-          helper.should_receive(:options_for_select)
-          helper.elements_for_select(element_objects)
+        it "should return a array for option tags" do
+          helper.elements_for_select(element_objects).should include(['Element 1', 'element_1'])
+          helper.elements_for_select(element_objects).should include(['Element 2', 'element_2'])
         end
       end
 
@@ -84,9 +75,8 @@ module Alchemy
 
         subject { helper.elements_for_select(element_descriptions) }
 
-        it "should return a String with html option tags" do
-          helper.should_receive(:options_for_select)
-          subject
+        it "should return a array for option tags" do
+          subject.should include(['Headline', 'headline'])
         end
 
         it "should render the elements display name" do
@@ -94,8 +84,6 @@ module Alchemy
           subject
         end
       end
-
     end
-
   end
 end

data/spec/helpers/admin/essences_helper_spec.rb

@@ -7,20 +7,43 @@ describe Alchemy::Admin::EssencesHelper do
 
   describe 'essence rendering' do
     before do
-      element.content_by_name('intro').essence.update_attributes(:body => 'hello!')
+      if element
+        element.content_by_name('intro').essence.update(body: 'hello!')
+      end
     end
 
-    it "should render an essence editor" do
-      content = element.content_by_name('intro')
-      helper.render_essence_editor(content).should match(/input.+type="text".+value="hello!/)
+    describe '#render_essence_editor' do
+      it "should render an essence editor" do
+        content = element.content_by_name('intro')
+        helper.render_essence_editor(content).should match(/input.+type="text".+value="hello!/)
+      end
     end
 
-    it "should render an essence editor by name" do
-      helper.render_essence_editor_by_name(element, 'intro').should match(/input.+type="text".+value="hello!/)
-    end
+    describe '#render_essence_editor_by_name' do
+      subject { render_essence_editor_by_name(element, content) }
+
+      let(:content) { 'intro' }
+
+      it "renders an essence editor by given name" do
+        should match(/input.+type="text".+value="hello!/)
+      end
+
+      context 'when element is nil' do
+        let(:element) { nil }
+
+        it "displays a warning" do
+          should have_selector(".content_editor_error")
+          should have_content("No element given.")
+        end
+      end
 
-    it "should render an essence editor by type" do
-      helper.render_essence_editor_by_type(element, 'EssenceText').should match(/input.+type="text".+value="hello!/)
+      context 'when content is not found on element' do
+        let(:content) { 'sputz' }
+
+        it "displays a warning" do
+          should have_selector(".content_editor.missing")
+        end
+      end
     end
   end
 
@@ -34,7 +57,7 @@ describe Alchemy::Admin::EssencesHelper do
       # to be shure the ordering is alphabetic
       page_b
       page_a
-      helper.session[:language_id] = 1
+      helper.session[:alchemy_language_id] = 1
     end
 
     context "with no arguments given" do
@@ -68,4 +91,19 @@ describe Alchemy::Admin::EssencesHelper do
     end
   end
 
+  describe '#essence_picture_thumbnail' do
+    let(:content) { build_stubbed(:content, essence: build_stubbed(:essence_picture)) }
+
+    it "should return an image tag" do
+      expect(helper.essence_picture_thumbnail(content, {})).to have_selector('img[src]')
+    end
+
+    context 'when given content has no ingredient' do
+      before { content.stub(:ingredient).and_return(nil) }
+      it "should return nil" do
+        expect(helper.essence_picture_thumbnail(content, {})).to eq(nil)
+      end
+    end
+  end
+
 end

data/spec/helpers/admin/navigation_helper_spec.rb

@@ -30,15 +30,15 @@ describe Alchemy::Admin::NavigationHelper do
   let(:navigation) { alchemy_module['navigation'] }
 
   describe '#alchemy_main_navigation_entry' do
-    before {
+    before do
       helper.stub(:url_for_module).and_return('')
       helper.stub(:_t).and_return(alchemy_module['name'])
-    }
+    end
 
     context "with permission" do
-      before {
-        helper.stub(:permitted_to?).and_return(true)
-      }
+      before do
+        helper.stub(:can?).and_return(true)
+      end
 
       it "renders the main navigation entry partial" do
         helper.alchemy_main_navigation_entry(alchemy_module).should match /<a.+class="main_navi_entry/
@@ -46,9 +46,9 @@ describe Alchemy::Admin::NavigationHelper do
     end
 
     context "without permission" do
-      before {
-        helper.stub(:permitted_to?).and_return(false)
-      }
+      before do
+        helper.stub(:can?).and_return(false)
+      end
 
       it "returns empty string" do
         helper.alchemy_main_navigation_entry(alchemy_module).should be_empty
@@ -57,16 +57,16 @@ describe Alchemy::Admin::NavigationHelper do
   end
 
   describe '#admin_subnavigation' do
-    before {
+    before do
       helper.stub(:current_alchemy_module).and_return(alchemy_module)
       helper.stub(:url_for_module_sub_navigation).and_return('')
       helper.stub(:_t).and_return(alchemy_module['name'])
-    }
+    end
 
     context "with permission" do
-      before {
-        helper.stub(:permitted_to?).and_return(true)
-      }
+      before do
+        helper.stub(:can?).and_return(true)
+      end
 
       it "renders the sub navigation for current module" do
         helper.admin_subnavigation.should match /<div.+class="subnavi_tab/
@@ -74,9 +74,9 @@ describe Alchemy::Admin::NavigationHelper do
     end
 
     context "without permission" do
-      before {
-        helper.stub(:permitted_to?).and_return(false)
-      }
+      before do
+        helper.stub(:can?).and_return(false)
+      end
 
       it "renders the sub navigation for current module" do
         helper.admin_subnavigation.should be_empty
@@ -84,9 +84,9 @@ describe Alchemy::Admin::NavigationHelper do
     end
 
     context "without a module present" do
-      before {
+      before do
         helper.stub(:current_alchemy_module).and_return(nil)
-      }
+      end
 
       it "returns nil" do
         helper.admin_subnavigation.should be_nil
@@ -95,9 +95,17 @@ describe Alchemy::Admin::NavigationHelper do
   end
 
   describe '#navigate_module' do
-    it "returns array with symbolized controller and action name" do
+    it "returns array with symbolized action and controller name" do
       helper.navigate_module(navigation).should == [:index, :alchemy_admin_dashboard]
     end
+
+    it "stringifies keys" do
+      helper.navigate_module({action: 'index', controller: 'alchemy/admin/pictures'}).should == [:index, :alchemy_admin_pictures]
+    end
+
+    it "removes leading slash" do
+      helper.navigate_module({action: 'index', controller: '/admin/pictures'}).should == [:index, :admin_pictures]
+    end
   end
 
   describe '#main_navigation_css_classes' do
@@ -106,9 +114,9 @@ describe Alchemy::Admin::NavigationHelper do
     end
 
     context "with active entry" do
-      before {
+      before do
         helper.stub(:params).and_return({controller: 'alchemy/admin/dashboard', action: 'index'})
-      }
+      end
 
       it "includes active class" do
         helper.main_navigation_css_classes(navigation).should == "main_navi_entry active"
@@ -117,14 +125,14 @@ describe Alchemy::Admin::NavigationHelper do
   end
 
   describe '#entry_active?' do
-    let(:entry) {
+    let(:entry) do
       {'controller' => 'alchemy/admin/dashboard', 'action' => 'index'}
-    }
+    end
 
     context "with active entry" do
-      before {
+      before do
         helper.stub(:params).and_return({controller: 'alchemy/admin/dashboard', action: 'index'})
-      }
+      end
 
       it "returns true" do
         helper.entry_active?(entry).should be_true
@@ -139,10 +147,10 @@ describe Alchemy::Admin::NavigationHelper do
       end
 
       context "but with action listed in nested_actions key" do
-        before {
+        before do
           entry['action'] = nil
           entry['nested_actions'] = %w(index)
-        }
+        end
 
         it "returns true" do
           helper.entry_active?(entry).should be_true
@@ -151,9 +159,9 @@ describe Alchemy::Admin::NavigationHelper do
     end
 
     context "with inactive entry" do
-      before {
+      before do
         helper.stub(:params).and_return({controller: 'alchemy/admin/users', action: 'index'})
-      }
+      end
 
       it "returns false" do
         helper.entry_active?(entry).should be_false
@@ -210,4 +218,31 @@ describe Alchemy::Admin::NavigationHelper do
     end
   end
 
+  describe "#sorted_alchemy_modules" do
+    subject { helper.sorted_alchemy_modules }
+
+    context 'with position attribute on modules' do
+      before do
+        alchemy_module['position'] = 1
+        event_module['position'] = 2
+        helper.stub(alchemy_modules: [event_module, alchemy_module])
+      end
+
+      it "returns sorted alchemy modules" do
+        should eq([alchemy_module, event_module])
+      end
+    end
+
+    context 'with no position attribute on one module' do
+      before do
+        event_module['position'] = 2
+        helper.stub(alchemy_modules: [alchemy_module, event_module])
+      end
+
+      it "appends this module at the end" do
+        should eq([event_module, alchemy_module])
+      end
+    end
+  end
+
 end

data/spec/helpers/admin/pages_helper_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Alchemy::Admin::PagesHelper do
 
   describe '#sitemap_folder_link' do
-    let(:user) { mock_model('User', alchemy_roles: %w(admin), role_symbols: [:admin]) }
+    let(:user) { admin_user }
 
     before { helper.stub(:current_alchemy_user).and_return(user) }
 
@@ -40,4 +40,25 @@ describe Alchemy::Admin::PagesHelper do
     end
   end
 
+  describe '#combined_page_status' do
+    let(:page) { FactoryGirl.build_stubbed(:page, restricted: true, visible: true, public: true, locked: true) }
+    subject { helper.combined_page_status(page) }
+
+    context 'when page is locked' do
+      it { should_not match(/locked/) } # We don't want the locked status in the return string
+    end
+
+    context 'when page is restricted' do
+      it { should match(/is restricted/) }
+    end
+
+    context 'when page is visible in navigation' do
+      it { should match(/is visible/) }
+    end
+
+    context 'when page is published' do
+      it { should match(/is published/) }
+    end
+  end
+
 end

data/spec/helpers/admin/pictures_helper_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe Alchemy::Admin::PicturesHelper do
+  describe "#create_or_assign_url" do
+
+    let(:picture) { mock_model('Picture') }
+    let(:options) { Hash.new }
+
+    before { @element = mock_model('Element') }
+
+    it "should return a Hash" do
+      expect(helper.create_or_assign_url(picture, options)).to be_a(Hash)
+    end
+
+    context "when creating" do
+      it "should include 'create' as the value for the action key" do
+        expect(helper.create_or_assign_url(picture, options)[:action]).to be(:create)
+      end
+    end
+
+    context "when assigning" do
+      before { @content = mock_model('Content') }
+
+      it "should include 'assign' as the value for the action key" do
+        expect(helper.create_or_assign_url(picture, options)[:action]).to be(:assign)
+      end
+    end
+  end
+end

data/spec/helpers/admin/tags_helper_spec.rb

@@ -9,7 +9,7 @@ module Alchemy
 
     describe '#render_tag_list' do
       context "with tagged objects" do
-        before { Attachment.stub!(:tag_counts).and_return([tag, tag2]) }
+        before { Attachment.stub(:tag_counts).and_return([tag, tag2]) }
 
         it "returns a tag list as <li> tags" do
           helper.render_tag_list('Alchemy::Attachment', params).should match(/li/)