alchemy_cms 2.9.1 → 3.0.0.rc5

data/spec/features/page_feature_spec.rb

@@ -0,0 +1,225 @@
+require 'spec_helper'
+
+module Alchemy
+  describe 'Page' do
+    let(:default_language)      { Language.default }
+    let(:default_language_root) { FactoryGirl.create(:language_root_page, :language => default_language, :name => 'Home') }
+    let(:public_page_1)         { FactoryGirl.create(:public_page, :visible => true, :name => 'Page 1') }
+    let(:public_child)          { FactoryGirl.create(:public_page, :name => 'Public Child', :parent_id => public_page_1.id) }
+
+    before { default_language_root }
+
+    it "should include all its elements and contents" do
+      p = FactoryGirl.create(:public_page, :do_not_autogenerate => false)
+      article = p.elements.find_by_name('article')
+      article.content_by_name('intro').essence.update_attributes(:body => 'Welcome to Peters Petshop', :public => true)
+      visit "/#{p.urlname}"
+      within('div#content div.article div.intro') { page.should have_content('Welcome to Peters Petshop') }
+    end
+
+    it "should show the navigation with all visible pages" do
+      pages = [
+        FactoryGirl.create(:public_page, :visible => true, :name => 'Page 1'),
+        FactoryGirl.create(:public_page, :visible => true, :name => 'Page 2')
+      ]
+      visit '/'
+      within('div#navigation ul') { page.should have_selector('li a[href="/page-1"], li a[href="/page-2"]') }
+    end
+
+    describe "redirecting" do
+      context "in multi language mode" do
+        before do
+          Config.stub(:get) { |arg| arg == :url_nesting ? true : Config.parameter(arg) }
+          PagesController.any_instance.stub(:multi_language?).and_return(true)
+        end
+
+        context "if no language params are given" do
+          it "should redirect to url with nested language code" do
+            visit "/#{public_page_1.urlname}"
+            page.current_path.should == "/#{public_page_1.language_code}/#{public_page_1.urlname}"
+          end
+        end
+
+        context "if requested page is unpublished" do
+          before do
+            Config.stub(:get) { |arg| arg == :url_nesting ? false : Config.parameter(arg) }
+            public_page_1.update_attributes(:public => false, :name => 'Not Public', :urlname => '')
+            public_child
+          end
+
+          it "should redirect to public child" do
+            visit "/#{default_language.code}/not-public"
+            page.current_path.should == "/#{default_language.code}/public-child"
+          end
+
+          context "and url has no language code" do
+            it "should redirect to url of public child with language code of default language" do
+              visit '/not-public'
+              page.current_path.should == "/#{default_language.code}/public-child"
+            end
+          end
+        end
+
+        context "if requested url is index url" do
+          it "should redirect to pages url with default language" do
+            visit '/'
+            page.current_path.should == "/#{default_language.code}/home"
+          end
+        end
+
+        context "if requested url is only the language code" do
+          it "should redirect to pages url with default language" do
+            visit "/#{default_language.code}"
+            page.current_path.should == "/#{default_language.code}/home"
+          end
+        end
+
+        context "requested url is only the urlname" do
+          it "then it should redirect to pages url with nested language." do
+            visit '/home'
+            page.current_path.should == '/en/home'
+          end
+        end
+
+        it "should keep additional params" do
+          visit "/#{public_page_1.urlname}?query=Peter"
+          page.current_url.should match(/\?query=Peter/)
+        end
+
+        context "wrong language requested" do
+          before { Alchemy.user_class.stub(:admins).and_return([1, 2]) }
+
+          it "should render 404 if urlname and lang parameter do not belong to same page" do
+            FactoryGirl.create(:klingonian)
+            visit "/kl/#{public_page_1.urlname}"
+            page.status_code.should == 404
+          end
+
+          it "should render 404 if requested language does not exist" do
+            public_page_1
+            LegacyPageUrl.delete_all
+            visit "/fo/#{public_page_1.urlname}"
+            page.status_code.should == 404
+          end
+        end
+      end
+
+      context "not in multi language mode" do
+        before do
+          PagesController.any_instance.stub(:multi_language?).and_return(false)
+          Config.stub(:get) { |arg| arg == :url_nesting ? false : Config.parameter(arg) }
+        end
+
+        it "should redirect from nested language code url to normal url" do
+          visit "/en/#{public_page_1.urlname}"
+          page.current_path.should == "/#{public_page_1.urlname}"
+        end
+
+        context "should redirect to public child" do
+          before do
+            public_page_1.update_attributes(:public => false, :name => 'Not Public', :urlname => '')
+            public_child
+          end
+
+          it "if requested page is unpublished" do
+            visit '/not-public'
+            page.current_path.should == '/public-child'
+          end
+
+          it "with normal url, if requested url has nested language code and is not public" do
+            visit '/en/not-public'
+            page.current_path.should == '/public-child'
+          end
+        end
+
+        it "should redirect to pages url, if requested url is index url" do
+          visit '/'
+          page.current_path.should == '/home'
+        end
+
+        it "should keep additional params" do
+          visit "/de/#{public_page_1.urlname}?query=Peter"
+          page.current_url.should match(/\?query=Peter/)
+        end
+      end
+    end
+
+    describe "Handling of non-existing pages" do
+      before do
+        Alchemy.user_class.stub(:admins).and_return([1, 2]) # We need a admin user or the signup page will show up
+        visit "/non-existing-page"
+      end
+
+      it "should render public/404.html" do
+        page.status_code.should == 404
+      end
+    end
+
+    context "with invalid byte code char in urlname parameter" do
+      it "should raise BadRequest (400) error" do
+        expect { visit '/%ed' }.to raise_error(ActionController::BadRequest)
+      end
+    end
+
+    describe "menubar" do
+      context "rendering for guest users" do
+        it "is prohibited" do
+          visit "/#{public_page_1.urlname}"
+          within('body') { page.should_not have_selector('#alchemy_menubar') }
+        end
+      end
+
+      context "rendering for members" do
+        it "is prohibited" do
+          authorize_as_admin(mock_model('DummyUser', alchemy_roles: %w(member), language: 'en'))
+          visit "/#{public_page_1.urlname}"
+          within('body') { page.should_not have_selector('#alchemy_menubar') }
+        end
+      end
+
+      context "rendering for authors" do
+        it "is allowed" do
+          authorize_as_admin(mock_model('DummyUser', alchemy_roles: %w(author), language: 'en', cache_key: 'aaa'))
+          visit "/#{public_page_1.urlname}"
+          within('body') { page.should have_selector('#alchemy_menubar') }
+        end
+      end
+
+      context "rendering for editors" do
+        it "is allowed" do
+          authorize_as_admin(mock_model('DummyUser', alchemy_roles: %w(editor), language: 'en', cache_key: 'aaa'))
+          visit "/#{public_page_1.urlname}"
+          within('body') { page.should have_selector('#alchemy_menubar') }
+        end
+      end
+
+      context "rendering for admins" do
+        it "is allowed" do
+          authorize_as_admin(mock_model('DummyUser', alchemy_roles: %w(admin), language: 'en', cache_key: 'aaa'))
+          visit "/#{public_page_1.urlname}"
+          within('body') { page.should have_selector('#alchemy_menubar') }
+        end
+      end
+
+      context "contains" do
+        before do
+          authorize_as_admin(mock_model('DummyUser', alchemy_roles: %w(admin), language: 'en', cache_key: 'aaa'))
+          visit "/#{public_page_1.urlname}"
+        end
+
+        it "a link to the admin area" do
+          within('#alchemy_menubar') { page.should have_selector("li a[href='#{alchemy.admin_dashboard_path}']") }
+        end
+
+        it "a link to edit the current page" do
+          within('#alchemy_menubar') { page.should have_selector("li a[href='#{alchemy.edit_admin_page_path(public_page_1)}']") }
+        end
+
+        it "a form and button to logout of alchemy" do
+          within('#alchemy_menubar') { page.should have_selector("li form[action='#{Alchemy.logout_path}'], li button[type='submit']") }
+        end
+      end
+    end
+
+  end
+end

data/spec/features/translation_integration_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe "Translation integration" do
   context "in admin backend" do
-    before { authorize_as_admin(mock_model('User', alchemy_roles: %w(admin), role_symbols: [:admin], language: 'de', name: 'Peter')) }
+    before { authorize_as_admin(mock_model('DummyUser', alchemy_roles: %w(admin), language: 'de')) }
 
     it "should be possible to set the locale of the admin backend via params" do
       visit admin_dashboard_path(locale: 'de')
@@ -35,14 +35,14 @@ describe "Translation integration" do
         page.should have_content('Willkommen')
       end
     end
-  end
 
-  context "with translated header" do
-    before { Capybara.current_driver = :rack_test_translated_header }
+    context "with translated header" do
+      before { Capybara.current_driver = :rack_test_translated_header }
 
-    it "should use the browsers language setting if no other parameter is given" do
-      visit root_path
-      ::I18n.locale.should == :de
+      it "should use the browsers language setting if no other parameter is given" do
+        visit admin_dashboard_path
+        page.should have_content('Willkommen')
+      end
     end
   end
 end

data/spec/helpers/admin/attachments_helper_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Alchemy::Admin::AttachmentsHelper do
+  describe '#mime_to_human' do
+    context 'when given mime type has no translation' do
+      it "should return the default" do
+        expect(helper.mime_to_human('something')).to eq('File')
+      end
+    end
+
+    it "should return the translation for the given mime type" do
+      expect(helper.mime_to_human('text/plain')).to eq('Text-Document')
+    end
+  end
+end

data/spec/helpers/admin/base_helper_spec.rb

@@ -86,9 +86,7 @@ module Alchemy
 
     describe '#toolbar_button' do
       context "with permission" do
-        before {
-          helper.stub(:permitted_to?).and_return(true)
-        }
+        before { helper.stub(:can?).and_return(true) }
 
         it "renders a toolbar button" do
           helper.toolbar_button(
@@ -98,9 +96,7 @@ module Alchemy
       end
 
       context "without permission" do
-        before {
-          helper.stub(:permitted_to?).and_return(false)
-        }
+        before { helper.stub(:can?).and_return(false) }
 
         it "returns empty string" do
           helper.toolbar_button(
@@ -110,9 +106,7 @@ module Alchemy
       end
 
       context "with disabled permission check" do
-        before {
-          helper.stub(:permitted_to?).and_return(false)
-        }
+        before { helper.stub(:can?).and_return(false) }
 
         it "returns the button" do
           helper.toolbar_button(
@@ -123,9 +117,7 @@ module Alchemy
       end
 
       context "with empty permission option" do
-        before {
-          helper.stub(:permitted_to?).and_return(true)
-        }
+        before { helper.stub(:can?).and_return(true) }
 
         it "returns reads the permission from url" do
           helper.should_receive(:permission_array_from_url)
@@ -138,7 +130,7 @@ module Alchemy
 
       context "with overlay option set to false" do
         before do
-          helper.stub(:permitted_to?).and_return(true)
+          helper.stub(:can?).and_return(true)
           helper.should_receive(:permission_array_from_url)
         end
 
@@ -153,5 +145,88 @@ module Alchemy
       end
     end
 
+    describe "#translations_for_select" do
+      it "should return an Array of Arrays with available locales" do
+        Alchemy::I18n.stub(:available_locales).and_return([:de, :en, :cz, :it])
+        expect(helper.translations_for_select).to have(4).items
+      end
+    end
+
+    describe '#clipboard_select_tag_options' do
+      let(:page) { build_stubbed(:page) }
+      before { helper.instance_variable_set('@page', page) }
+
+      context 'with element items' do
+        let(:element) { build_stubbed(:element) }
+        let(:clipboard_items) { [element] }
+
+        it "should include select options with the display name and preview text" do
+          element.stub(:display_name_with_preview_text).and_return('Name with Preview text')
+          expect(helper.clipboard_select_tag_options(clipboard_items)).to have_selector('option', text: 'Name with Preview text')
+        end
+
+        context "when @page can have cells" do
+          before { page.stub(:can_have_cells?).and_return(true) }
+          it "should group the elements in the clipboard by cell" do
+            helper.should_receive(:grouped_elements_for_select).and_return({})
+            helper.clipboard_select_tag_options(clipboard_items)
+          end
+        end
+      end
+
+      context 'with page items' do
+        let(:page_in_clipboard) { build_stubbed(:page, name: 'Page name') }
+        let(:clipboard_items) { [page_in_clipboard] }
+
+        it "should include select options with page names" do
+          expect(helper.clipboard_select_tag_options(clipboard_items)).to have_selector('option', text: 'Page name')
+        end
+      end
+    end
+
+    describe '#button_with_confirm' do
+      subject { button_with_confirm }
+
+      it "renders a button tag with a data attribute for confirm dialog" do
+        should have_selector('button[data-alchemy-confirm]')
+      end
+    end
+
+    describe '#delete_button' do
+      subject { delete_button('/admin/pages') }
+
+      it "renders a button tag" do
+        should have_selector('button')
+      end
+
+      it "returns a form tag with method=delete" do
+        should have_selector('form input[name="_method"][value="delete"]')
+      end
+    end
+
+    describe '#alchemy_datepicker' do
+      subject { alchemy_datepicker(essence, :date, {value: now}) }
+
+      let(:essence) { EssenceDate.new() }
+      let(:now)     { Time.now }
+
+      it "renders a date field" do
+        should have_selector("input[type='date']")
+      end
+
+      it "sets default date as value" do
+        should have_selector("input[value='#{::I18n.l(now, format: :datepicker)}']")
+      end
+
+      context 'with date stored on object' do
+        let(:date)    { Time.parse('1976-10-07 00:00 Z') }
+        let(:essence) { EssenceDate.new(date: date) }
+
+        it "sets this date as value" do
+          should have_selector("input[value='#{::I18n.l(date, format: :datepicker)}']")
+        end
+      end
+    end
+
   end
 end

data/spec/helpers/admin/contents_helper_spec.rb

@@ -1,24 +1,65 @@
 require 'spec_helper'
 
 describe Alchemy::Admin::ContentsHelper do
-  let(:element) { FactoryGirl.create(:element, name: 'article', create_contents_after_create: true) }
+  let(:element) { build_stubbed(:element, name: 'article') }
+  let(:content) { mock_model('Content', essence_partial_name: 'essence_text') }
 
-  it "should render a dom id" do
-    helper.content_dom_id(element.content_by_type('EssenceText')).should match(/essence_text_\d{1,}/)
-  end
+  describe 'render_content_name' do
+    let(:content) do
+      mock_model 'Content',
+        name: 'intro',
+        description: {name: 'intro', type: 'EssenceText'},
+        name_for_label: 'Intro',
+        has_validations?: false
+    end
+    subject { helper.render_content_name(content) }
+
+    it "returns the content name" do
+      should == "Intro"
+    end
+
+    context 'if content is nil' do
+      let(:content) { nil }
+
+      it "returns nil" do
+        should be_nil
+      end
+    end
+
+    context 'with missing description' do
+      before { content.stub(description: {}) }
 
-  it "should render the content name" do
-    helper.render_content_name(element.content_by_type('EssenceText')).should == "Intro"
+      it "renders a warning" do
+        should have_selector('span.warning')
+        should have_content('Intro')
+      end
+    end
+
+    context 'with validations' do
+      before { content.stub(has_validations?: true) }
+
+      it "show a validation indicator" do
+        should have_selector('.validation_indicator')
+      end
+    end
   end
 
-  it "should render a link to add new content to element" do
-    helper.stub!(:render_icon).and_return('')
-    helper.render_new_content_link(element).should match(/a.+href.*admin\/elements\/#{element.id}\/contents\/new/m)
+  describe 'render_new_content_link' do
+    subject { helper.render_new_content_link(element) }
+
+    it "renders a link to add new content to element" do
+      helper.stub(:render_icon).and_return('')
+      should match(/a.+href.*admin\/elements\/#{element.id}\/contents\/new/m)
+    end
   end
 
-  it "should render a link to create a content in element" do
-    helper.stub!(:render_icon).and_return('')
-    helper.render_create_content_link(element, 'headline').should match(/a.+href.*admin\/contents.+class.+new_content_link.*data-method.+post/)
+  describe 'render_create_content_link' do
+    subject { helper.render_create_content_link(element, 'headline') }
+
+    it "should render a link to create a content in element" do
+      helper.stub(:render_icon).and_return('')
+      should have_selector('a.new_content_link[data-method="post"]')
+    end
   end
 
 end