adyen-ruby-api-library 7.0.1 → 7.0.2

data/spec/management_spec.rb

@@ -1,68 +1,66 @@
-require "spec_helper"
-require "json"
+require 'spec_helper'
+require 'json'
 
-# rubocop:disable Metrics/BlockLength
-
-RSpec.describe Adyen::Management, service: "Management" do
+RSpec.describe Adyen::Management, service: 'Management' do
   before(:all) do
     @shared_values = {
       client: create_client(:api_key),
-      service: "Management",
+      service: 'Management'
     }
   end
 
   # must be created manually because every field in the response is an array
-  it "makes a companies GET call" do
-    response_body = json_from_file("mocks/responses/Management/get_companies.json")
+  it 'makes a companies GET call' do
+    response_body = json_from_file('mocks/responses/Management/get_companies.json')
 
-    url = @shared_values[:client].service_url(@shared_values[:service], "companies", @shared_values[:client].management.version)
-    WebMock.stub_request(:get, url).
-      with(
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: response_body
-      )
+    url = @shared_values[:client].service_url(@shared_values[:service], 'companies',
+                                              @shared_values[:client].management.version)
+    WebMock.stub_request(:get, url)
+           .with(
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: response_body
+           )
 
-    result = @shared_values[:client].management.account_company_level_api.list_company_accounts()
+    result = @shared_values[:client].management.account_company_level_api.list_company_accounts
     response_hash = result.response
 
-    expect(result.status).
-      to eq(200)
-    expect(response_hash).
-      to eq(JSON.parse(response_body))
-    expect(response_hash).
-      to be_a Adyen::HashWithAccessors
-    expect(response_hash).
-      to be_a_kind_of Hash
+    expect(result.status)
+      .to eq(200)
+    expect(response_hash)
+      .to eq(JSON.parse(response_body))
+    expect(response_hash)
+      .to be_a Adyen::HashWithAccessors
+    expect(response_hash)
+      .to be_a_kind_of Hash
   end
 
-  it "makes a create_store POST call" do
-    request_body = JSON.parse(json_from_file("mocks/responses/LegalEntityManagement/create_business_line.json"))
+  it 'makes a create_store POST call' do
+    request_body = JSON.parse(json_from_file('mocks/responses/LegalEntityManagement/create_business_line.json'))
 
-    response_body = json_from_file("mocks/responses/LegalEntityManagement/create_business_line.json")
+    response_body = json_from_file('mocks/responses/LegalEntityManagement/create_business_line.json')
 
-    url = @shared_values[:client].service_url(@shared_values[:service], "merchants/merchantID/stores", @shared_values[:client].management.version)
-    WebMock.stub_request(:post, url).
-      with(
-        body: request_body,
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: response_body
-      )
+    url = @shared_values[:client].service_url(@shared_values[:service], 'merchants/merchantID/stores',
+                                              @shared_values[:client].management.version)
+    WebMock.stub_request(:post, url)
+           .with(
+             body: request_body,
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: response_body
+           )
 
-    result = @shared_values[:client].management.account_store_level_api.create_store_by_merchant_id(request_body, 'merchantID')
-    response_hash = result.response
+    result = @shared_values[:client].management.account_store_level_api.create_store_by_merchant_id(request_body,
+                                                                                                    'merchantID')
+    result.response
 
-      expect(result.status).
-      to eq(200)
+    expect(result.status)
+      .to eq(200)
   end
-
-
 end
-

data/spec/notification_spec.rb

@@ -1,19 +1,19 @@
-require "spec_helper"
+require 'spec_helper'
 
-RSpec.describe Adyen::Payment, service: "marketpay fund service" do
+RSpec.describe Adyen::Payment, service: 'marketpay fund service' do
   # client instance to be used in dynamically generated tests
   client = create_client(:basic)
 
   # methods / values to test for
   # format is defined in spec_helper
   test_sets = [
-    ["create_notification_configuration", "pspReference", "8515077331535427"],
-    ["delete_notification_configurations", "pspReference", "8515078085249090"],
-    ["get_notification_configuration", "pspReference", "8815078078131377"],
-    ["get_notification_configuration_list", "pspReference", "8515078078661665"],
-    ["test_notification_configuration", "pspReference", "8515078087759211"],
-    ["update_notification_configuration", "pspReference", "8515078084389038"]
+    %w[create_notification_configuration pspReference 8515077331535427],
+    %w[delete_notification_configurations pspReference 8515078085249090],
+    %w[get_notification_configuration pspReference 8815078078131377],
+    %w[get_notification_configuration_list pspReference 8515078078661665],
+    %w[test_notification_configuration pspReference 8515078087759211],
+    %w[update_notification_configuration pspReference 8515078084389038]
   ]
 
-  generate_tests(client, "Notification", test_sets, client.marketpay.notification)
+  generate_tests(client, 'Notification', test_sets, client.marketpay.notification)
 end

data/spec/payments_spec.rb

@@ -1,44 +1,43 @@
-require "spec_helper"
-require "json"
+require 'spec_helper'
+require 'json'
 
-RSpec.describe Adyen::Payment, service: "Payment" do
+RSpec.describe Adyen::Payment, service: 'Payment' do
   before(:all) do
     @shared_values = {
       client: create_client(:api_key),
-      service: "Payment",
+      service: 'Payment'
     }
   end
 
   # must be created manually because every field in the response is an array
-  it "makes an adjust_authorisation POST call" do
-    request_body = JSON.parse(json_from_file("mocks/requests/Payment/adjust_authorisation.json"))
-
-    response_body = json_from_file("mocks/responses/Payment/adjust_authorisation.json")
-
-    url = @shared_values[:client].service_url(@shared_values[:service], "adjustAuthorisation", @shared_values[:client].payment.version)
-    WebMock.stub_request(:post, url).
-      with(
-        body: request_body,
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: response_body
-      )
-
-    result = @shared_values[:client].payment.adjust_authorisation(request_body)
+  it 'makes an adjust_authorisation POST call' do
+    request_body = JSON.parse(json_from_file('mocks/requests/Payment/adjust_authorisation.json'))
+
+    response_body = json_from_file('mocks/responses/Payment/adjust_authorisation.json')
+
+    url = @shared_values[:client].service_url(@shared_values[:service], 'adjustAuthorisation',
+                                              @shared_values[:client].payment.version)
+    WebMock.stub_request(:post, url)
+           .with(
+             body: request_body,
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: response_body
+           )
+
+    result = @shared_values[:client].payment.modifications_api.adjust_authorisation(request_body)
     response_hash = result.response
 
-    expect(result.status).
-      to eq(200)
-    expect(response_hash).
-      to eq(JSON.parse(response_body))
-    expect(response_hash).
-      to be_a Adyen::HashWithAccessors
-    expect(response_hash).
-      to be_a_kind_of Hash
+    expect(result.status)
+      .to eq(200)
+    expect(response_hash)
+      .to eq(JSON.parse(response_body))
+    expect(response_hash)
+      .to be_a Adyen::HashWithAccessors
+    expect(response_hash)
+      .to be_a_kind_of Hash
   end
-
 end
-

data/spec/payouts_spec.rb

@@ -1,46 +1,43 @@
-require "spec_helper"
-require "json"
+require 'spec_helper'
+require 'json'
 
-# rubocop:disable Metrics/BlockLength
-
-RSpec.describe Adyen::Payout, service: "Payout" do
+RSpec.describe Adyen::Payout, service: 'Payout' do
   before(:all) do
     @shared_values = {
       client: create_client(:api_key),
-      service: "Payout",
+      service: 'Payout'
     }
   end
 
   # must be created manually because every field in the response is an array
-  it "makes a business_lines POST call" do
-    request_body = JSON.parse(json_from_file("mocks/requests/Payout/confirm_third_party.json"))
-
-    response_body = json_from_file("mocks/responses/Payout/confirm_third_party.json")
-
-    url = @shared_values[:client].service_url(@shared_values[:service], "confirmThirdParty", @shared_values[:client].payout.version)
-    WebMock.stub_request(:post, url).
-      with(
-        body: request_body,
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: response_body
-      )
+  it 'makes a business_lines POST call' do
+    request_body = JSON.parse(json_from_file('mocks/requests/Payout/confirm_third_party.json'))
+
+    response_body = json_from_file('mocks/responses/Payout/confirm_third_party.json')
+
+    url = @shared_values[:client].service_url(@shared_values[:service], 'confirmThirdParty',
+                                              @shared_values[:client].payout.version)
+    WebMock.stub_request(:post, url)
+           .with(
+             body: request_body,
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: response_body
+           )
 
     result = @shared_values[:client].payout.reviewing_api.confirm_third_party(request_body)
     response_hash = result.response
 
-    expect(result.status).
-      to eq(200)
-    expect(response_hash).
-      to eq(JSON.parse(response_body))
-    expect(response_hash).
-      to be_a Adyen::HashWithAccessors
-    expect(response_hash).
-      to be_a_kind_of Hash
+    expect(result.status)
+      .to eq(200)
+    expect(response_hash)
+      .to eq(JSON.parse(response_body))
+    expect(response_hash)
+      .to be_a Adyen::HashWithAccessors
+    expect(response_hash)
+      .to be_a_kind_of Hash
   end
-
 end
-

data/spec/pos_terminal_management_spec.rb

@@ -1,46 +1,44 @@
-require "spec_helper"
-require "json"
+require 'spec_helper'
+require 'json'
 
-# rubocop:disable Metrics/BlockLength
-
-RSpec.describe Adyen::PosTerminalManagement, service: "PosTerminalManagement" do
+RSpec.describe Adyen::PosTerminalManagement, service: 'PosTerminalManagement' do
   before(:all) do
     @shared_values = {
       client: create_client(:api_key),
-      service: "LegalEntityManagement",
+      service: 'LegalEntityManagement'
     }
   end
 
   # must be created manually because every field in the response is an array
-  it "makes a assign_terminals POST call" do
-    request_body = JSON.parse(json_from_file("mocks/requests/Terminal/assign_terminals.json"))
-
-    response_body = json_from_file("mocks/responses/Terminal/assign_terminals.json")
-
-    url = @shared_values[:client].service_url(@shared_values[:service], "assignTerminals", @shared_values[:client].pos_terminal_management.version)
-    WebMock.stub_request(:post, url).
-      with(
-        body: request_body,
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: response_body
-      )
+  it 'makes a assign_terminals POST call' do
+    request_body = JSON.parse(json_from_file('mocks/requests/Terminal/assign_terminals.json'))
+
+    response_body = json_from_file('mocks/responses/Terminal/assign_terminals.json')
+
+    url = @shared_values[:client].service_url(@shared_values[:service], 'assignTerminals',
+                                              @shared_values[:client].pos_terminal_management.version)
+    WebMock.stub_request(:post, url)
+           .with(
+             body: request_body,
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: response_body
+           )
 
     result = @shared_values[:client].pos_terminal_management.assign_terminals(request_body)
     response_hash = result.response
 
-    expect(result.status).
-      to eq(200)
-    expect(response_hash).
-      to eq(JSON.parse(response_body))
-    expect(response_hash).
-      to be_a Adyen::HashWithAccessors
-    expect(response_hash).
-      to be_a_kind_of Hash
+    expect(result.status)
+      .to eq(200)
+    expect(response_hash)
+      .to eq(JSON.parse(response_body))
+    expect(response_hash)
+      .to be_a Adyen::HashWithAccessors
+    expect(response_hash)
+      .to be_a_kind_of Hash
   end
-
 end
-
+# rubocop:enable Metrics/BlockLength

data/spec/recurring_spec.rb

@@ -1,18 +1,18 @@
-require "spec_helper"
-require_relative "../lib/adyen/errors"
+require 'spec_helper'
+require_relative '../lib/adyen/errors'
 
-RSpec.describe Adyen::Payment, service: "recurring service" do
+RSpec.describe Adyen::Payment, service: 'recurring service' do
   # client instance to be used in dynamically generated tests
   client = create_client(:basic)
 
   # methods / values to test for
   # format is defined in spec_helper
   test_sets = [
-    ["list_recurring_details", "creationDate", "2017-03-01T11:53:11+01:00"],
-    ["disable", "response", "[detail-successfully-disabled]"],
-    ["create_permit", "pspReference", "8815260599791117"],
-    ["schedule_account_updater", "result", "Success"]
+    ['list_recurring_details', 'creationDate', '2017-03-01T11:53:11+01:00'],
+    ['disable', 'response', '[detail-successfully-disabled]'],
+    ['create_permit', 'pspReference', '8815260599791117'],
+    ['schedule_account_updater', 'result', 'Success']
   ]
 
-  generate_tests(client, "Recurring", test_sets, client.recurring)
+  generate_tests(client, 'Recurring', test_sets, client.recurring)
 end

data/spec/service_spec.rb

@@ -1,3 +1,5 @@
+# rubocop:disable Layout/LineLength
+
 require 'spec_helper'
 
 RSpec.describe Adyen::Service do
@@ -44,3 +46,5 @@ RSpec.describe Adyen::Service do
     end
   end
 end
+# rubocop:enable Layout/LineLength
+# rubocop:enable Metrics/BlockLength

data/spec/spec_helper.rb

@@ -1,6 +1,9 @@
-require "webmock/rspec"
-require "base64"
-require_relative "../lib/adyen-ruby-api-library"
+# rubocop:disable Metrics/MethodLength
+# rubocop:disable Metrics/AbcSize
+
+require 'webmock/rspec'
+require 'base64'
+require_relative '../lib/adyen-ruby-api-library'
 
 # disable external connections
 WebMock.disable_net_connect!(allow_localhost: true)
@@ -18,47 +21,46 @@ def create_test(client, service, method_name, parent_object)
   request_body = JSON.parse(json_from_file("mocks/requests/#{service}/#{method_name}.json"))
   response_body = json_from_file("mocks/responses/#{service}/#{method_name}.json")
 
-
   # client-generated headers
   headers = {
-    "Content-Type".to_sym => "application/json",
+    'Content-Type'.to_sym => 'application/json'
   }
 
   # authentication headers
-  if not client.api_key.nil?
-    headers["x-api-key"] = client.api_key
-  elsif not client.ws_user.nil? and not client.ws_password.nil?
-    auth_header = "Basic " + Base64::encode64("#{client.ws_user}:#{client.ws_password}")
-    headers["Authorization"] = auth_header.strip
+  if !client.api_key.nil?
+    headers['x-api-key'] = client.api_key
+  elsif !client.ws_user.nil? && !client.ws_password.nil?
+    auth_header = "Basic #{Base64.encode64("#{client.ws_user}:#{client.ws_password}")}"
+    headers['Authorization'] = auth_header.strip
   else
-    raise ArgumentError, "Authentication not set correctly in test case"
+    raise ArgumentError, 'Authentication not set correctly in test case'
   end
 
   # stub request
   action = Adyen::Service.action_for_method_name(method_name)
   url = client.service_url(service, action, parent_object.version)
-  WebMock.stub_request(:post, url).
-    with(
-    body: request_body,
-    headers: headers,
-  ).
-    to_return(
-    body: response_body,
-  )
+  WebMock.stub_request(:post, url)
+         .with(
+           body: request_body,
+           headers: headers
+         )
+         .to_return(
+           body: response_body
+         )
   result = parent_object.public_send(method_name, request_body)
 
   # result.response is already a Ruby object (Adyen::HashWithAccessors) (rather than an unparsed JSON string)
   response_hash = result.response
 
   # boilerplate error checks
-  expect(result.status).
-    to eq(200)
-  expect(response_hash).
-    to eq(JSON.parse(response_body))
-  expect(response_hash).
-    to be_a Adyen::HashWithAccessors
-  expect(response_hash).
-    to be_a_kind_of Hash
+  expect(result.status)
+    .to eq(200)
+  expect(response_hash)
+    .to eq(JSON.parse(response_body))
+  expect(response_hash)
+    .to be_a Adyen::HashWithAccessors
+  expect(response_hash)
+    .to be_a_kind_of Hash
 
   response_hash
 end
@@ -70,8 +72,8 @@ def generate_tests(client, service, test_sets, parent_object)
   test_sets.each do |test_set|
     it "makes a #{test_set[0]} call" do
       parsed_body = create_test(client, service, test_set[0], parent_object)
-      expect(parsed_body[test_set[1]]).
-        to eq(test_set[2])
+      expect(parsed_body[test_set[1]])
+        .to eq(test_set[2])
     end
   end
 end
@@ -81,15 +83,15 @@ end
 def create_client(auth_type)
   client = Adyen::Client.new
   client.env = :mock
-
   if auth_type == :basic
-    client.ws_user = "user"
-    client.ws_password = "password"
+    client.ws_user = 'user'
+    client.ws_password = 'password'
   elsif auth_type == :api_key
-    client.api_key = "api_key"
+    client.api_key = 'api_key'
   else
-    raise ArgumentError "Invalid auth type for test client"
+    raise ArgumentError 'Invalid auth type for test client'
   end
-
   client
 end
+# rubocop:enable Metrics/MethodLength
+# rubocop:enable Metrics/AbcSize

data/spec/stored_value_spec.rb

@@ -1,43 +1,44 @@
-require "spec_helper"
-require "json"
+require 'spec_helper'
+require 'json'
 
-RSpec.describe Adyen::BalancePlatform, service: "balancePlatform" do
+RSpec.describe Adyen::BalancePlatform, service: 'balancePlatform' do
   before(:all) do
     @shared_values = {
       client: create_client(:api_key),
-      service: "BalancePlatform",
+      service: 'BalancePlatform'
     }
   end
 
   # must be created manually because every field in the response is an array
-  it "makes a issue POST call" do
-    request_body = JSON.parse(json_from_file("mocks/requests/StoredValue/issue_giftcard.json"))
+  it 'makes a issue POST call' do
+    request_body = JSON.parse(json_from_file('mocks/requests/StoredValue/issue_giftcard.json'))
 
-    response_body = json_from_file("mocks/responses/StoredValue/issue_giftcard.json")
+    response_body = json_from_file('mocks/responses/StoredValue/issue_giftcard.json')
 
-    url = @shared_values[:client].service_url(@shared_values[:service], "issue", @shared_values[:client].stored_value.version)
-    WebMock.stub_request(:post, url).
-      with(
-        body: request_body,
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: response_body
-      )
+    url = @shared_values[:client].service_url(@shared_values[:service], 'issue',
+                                              @shared_values[:client].stored_value.version)
+    WebMock.stub_request(:post, url)
+           .with(
+             body: request_body,
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: response_body
+           )
 
     result = @shared_values[:client].stored_value.issue(request_body)
     response_hash = result.response
 
-    expect(result.status).
-      to eq(200)
-    expect(response_hash).
-      to eq(JSON.parse(response_body))
-    expect(response_hash).
-      to be_a Adyen::HashWithAccessors
-    expect(response_hash).
-      to be_a_kind_of Hash
+    expect(result.status)
+      .to eq(200)
+    expect(response_hash)
+      .to eq(JSON.parse(response_body))
+    expect(response_hash)
+      .to be_a Adyen::HashWithAccessors
+    expect(response_hash)
+      .to be_a_kind_of Hash
   end
-
 end
+# rubocop:enable Metrics/BlockLength