adyen-ruby-api-library 7.0.1 → 7.0.2

data/spec/client_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 RSpec.describe Adyen do
   before(:all) do
@@ -7,119 +7,120 @@ RSpec.describe Adyen do
     }
   end
 
-  it "creates Adyen client" do
+  it 'creates Adyen client' do
     @shared_values[:client] = Adyen::Client.new
     expect(@shared_values[:client]).is_a? Adyen::Client
   end
 
-  it "sets env to :mock" do
+  it 'sets env to :mock' do
     @shared_values[:client].env = :test
-    expect(@shared_values[:client].env).
-      to eq(:test)
+    expect(@shared_values[:client].env)
+      .to eq(:test)
   end
 
-  it "sets the version number" do
+  it 'sets the version number' do
     @shared_values[:client].checkout.version = @shared_values[:version]
-    expect(@shared_values[:client].checkout.version).
-      to eq(@shared_values[:version])
+    expect(@shared_values[:client].checkout.version)
+      .to eq(@shared_values[:version])
   end
 
-  it "fails payments call without WS user and password" do
-    expect{ @shared_values[:client].payment.authorise("{}") }.
-      to raise_error(Adyen::AuthenticationError)
+  it 'fails payments call without WS user and password' do
+    expect { @shared_values[:client].payment.general_api.authorise('{}') }
+      .to raise_error(Adyen::AuthenticationError)
     @shared_values[:client].ws_user = @shared_values[:ws_user]
-    expect{ @shared_values[:client].payment.authorise("{}") }.
-      to raise_error(Adyen::AuthenticationError)
+    expect { @shared_values[:client].payment.general_api.authorise('{}') }
+      .to raise_error(Adyen::AuthenticationError)
   end
 
-  it "fails a checkout call without api key" do
-    expect{ @shared_values[:client].checkout.payments_api.payment_methods("{}") }.
-      to raise_error(Adyen::AuthenticationError)
-    @shared_values[:client].api_key = "api_key"
+  it 'fails a checkout call without api key' do
+    expect { @shared_values[:client].checkout.payments_api.payment_methods('{}') }
+      .to raise_error(Adyen::AuthenticationError)
+    @shared_values[:client].api_key = 'api_key'
   end
 
-  it "uses the specified mock service URL" do
-    client = Adyen::Client.new(env: :mock, mock_service_url_base: "https://mock.test")
-    expect(client.service_url_base("Account")).
-      to eq("https://mock.test")
+  it 'uses the specified mock service URL' do
+    client = Adyen::Client.new(env: :mock, mock_service_url_base: 'https://mock.test')
+    expect(client.service_url_base('Account'))
+      .to eq('https://mock.test')
   end
 
-  it "generates localhost service URL when a mock port is specified" do
+  it 'generates localhost service URL when a mock port is specified' do
     client = Adyen::Client.new(env: :mock, mock_port: 3005)
-    expect(client.service_url_base("Account")).
-      to eq("http://localhost:3005")
+    expect(client.service_url_base('Account'))
+      .to eq('http://localhost:3005')
   end
 
-  it "prefers the mock service URL when both mock service URL and port are specified" do
-    client = Adyen::Client.new(env: :mock, mock_port: 3005, mock_service_url_base: "https://this-url-wins.test")
-    expect(client.service_url_base("Account")).
-      to eq("https://this-url-wins.test")
+  it 'prefers the mock service URL when both mock service URL and port are specified' do
+    client = Adyen::Client.new(env: :mock, mock_port: 3005, mock_service_url_base: 'https://this-url-wins.test')
+    expect(client.service_url_base('Account'))
+      .to eq('https://this-url-wins.test')
   end
 
-  it "generates the correct service URL base for CAL TEST" do
+  it 'generates the correct service URL base for CAL TEST' do
     client = Adyen::Client.new(env: :test)
-    client.live_url_prefix = "abcdef1234567890-TestCompany"
-    expect(client.service_url_base("Account")).
-      to eq("https://cal-test.adyen.com/cal/services/Account")
+    client.live_url_prefix = 'abcdef1234567890-TestCompany'
+    expect(client.service_url_base('Account'))
+      .to eq('https://cal-test.adyen.com/cal/services/Account')
   end
 
-  it "generates the correct service URL base for CAL LIVE" do
+  it 'generates the correct service URL base for CAL LIVE' do
     client = Adyen::Client.new(env: :live)
-    client.live_url_prefix = "abcdef1234567890-TestCompany"
-    expect(client.service_url_base("Account")).
-      to eq("https://cal-live.adyen.com/cal/services/Account")
+    client.live_url_prefix = 'abcdef1234567890-TestCompany'
+    expect(client.service_url_base('Account'))
+      .to eq('https://cal-live.adyen.com/cal/services/Account')
   end
 
-  it "generates the correct service URL base for PAL TEST" do
+  it 'generates the correct service URL base for PAL TEST' do
     client = Adyen::Client.new(env: :test)
-    client.live_url_prefix = "abcdef1234567890-TestCompany"
-    expect(client.service_url_base("Payment")).
-      to eq("https://pal-test.adyen.com/pal/servlet/Payment")
+    client.live_url_prefix = 'abcdef1234567890-TestCompany'
+    expect(client.service_url_base('Payment'))
+      .to eq('https://pal-test.adyen.com/pal/servlet/Payment')
   end
 
-  it "generates the correct service URL base for PAL LIVE" do
+  it 'generates the correct service URL base for PAL LIVE' do
     client = Adyen::Client.new(env: :live)
-    client.live_url_prefix = "abcdef1234567890-TestCompany"
-    expect(client.service_url_base("Payment")).
-      to eq("https://abcdef1234567890-TestCompany-pal-live.adyenpayments.com/pal/servlet/Payment")
+    client.live_url_prefix = 'abcdef1234567890-TestCompany'
+    expect(client.service_url_base('Payment'))
+      .to eq('https://abcdef1234567890-TestCompany-pal-live.adyenpayments.com/pal/servlet/Payment')
   end
-  
-  it "generates the correct service URL PAL authorise TEST" do
+
+  it 'generates the correct service URL PAL authorise TEST' do
     client = Adyen::Client.new(env: :test)
-    expect(client.service_url("Payment", "authorise", "68")).
-      to eq("https://pal-test.adyen.com/pal/servlet/Payment/v68/authorise")
+    expect(client.service_url('Payment', 'authorise', '68'))
+      .to eq('https://pal-test.adyen.com/pal/servlet/Payment/v68/authorise')
   end
 
-  it "generates the correct service URL base for PAL LIVE" do
+  it 'generates the correct service URL base for PAL LIVE' do
     client = Adyen::Client.new(env: :live)
-    client.live_url_prefix = "abcdef1234567890-TestCompany"
-    expect(client.service_url("Payment", "authorise", "68")).
-      to eq("https://abcdef1234567890-TestCompany-pal-live.adyenpayments.com/pal/servlet/Payment/v68/authorise")
+    client.live_url_prefix = 'abcdef1234567890-TestCompany'
+    expect(client.service_url('Payment', 'authorise', '68'))
+      .to eq('https://abcdef1234567890-TestCompany-pal-live.adyenpayments.com/pal/servlet/Payment/v68/authorise')
   end
 
-  it "generates a new set of ConnectionOptions when none are provided" do
+  it 'generates a new set of ConnectionOptions when none are provided' do
     expect(Faraday::ConnectionOptions).to receive(:new).and_call_original
-    client = Adyen::Client.new(env: :test)
+    Adyen::Client.new(env: :test)
   end
 
-  it "uses the ConnectionOptions provided" do
+  it 'uses the ConnectionOptions provided' do
     connection_options = Faraday::ConnectionOptions.new
     expect(Faraday::ConnectionOptions).not_to receive(:new)
-    client = Adyen::Client.new(env: :test, connection_options: connection_options)
+    Adyen::Client.new(env: :test, connection_options: connection_options)
   end
 
-  it "initiates a Faraday connection with the provided options" do
+  it 'initiates a Faraday connection with the provided options' do
     connection_options = Faraday::ConnectionOptions.new
     expect(Faraday::ConnectionOptions).not_to receive(:new)
-    client = Adyen::Client.new(api_key: "api_key", env: :mock, connection_options: connection_options)
+    client = Adyen::Client.new(api_key: 'api_key', env: :mock, connection_options: connection_options)
 
     mock_faraday_connection = double(Faraday::Connection)
-    url = client.service_url(@shared_values[:service], "payments/details", client.checkout.version)
-    request_body = JSON.parse(json_from_file("mocks/requests/Checkout/payment-details.json"))
+    client.service_url(@shared_values[:service], 'payments/details', client.checkout.version)
+    request_body = JSON.parse(json_from_file('mocks/requests/Checkout/payment-details.json'))
     mock_response = Faraday::Response.new(status: 200)
 
     expect(Adyen::AdyenResult).to receive(:new)
-    expect(Faraday).to receive(:new).with("http://localhost:3001/v70/payments/details", connection_options).and_return(mock_faraday_connection)
+    expect(Faraday).to receive(:new).with('http://localhost:3001/v70/payments/details',
+                                          connection_options).and_return(mock_faraday_connection)
     expect(mock_faraday_connection).to receive(:post).and_return(mock_response)
     client.checkout.payments_api.payments_details(request_body)
   end
@@ -177,16 +178,62 @@ RSpec.describe Adyen do
     to eq("https://pal-test.adyen.com/pal/servlet/StoredValue/v46/issue")
   end
 
-  it "check the creation of payout url" do
-    client = Adyen::Client.new(api_key: "api_key", env: :test)
-    expect(client.service_url("Payout", "declineThirdParty", "68")).
-    to eq("https://pal-test.adyen.com/pal/servlet/Payout/v68/declineThirdParty")
+  it 'checks the creation of checkout url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :live, live_url_prefix: 'YourLiveUrlPrefix')
+    expect(client.service_url('Checkout', 'paymentMethods', '70'))
+      .to eq('https://YourLiveUrlPrefix-checkout-live.adyenpayments.com/checkout/v70/paymentMethods')
+  end
+  it 'checks the creation of lem url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :live)
+    expect(client.service_url('LegalEntityManagement', 'businessLines', '3'))
+      .to eq('https://kyc-live.adyen.com/lem/v3/businessLines')
   end
 
-  it "checks the creation of PosTerminalManagement url" do
-    client = Adyen::Client.new(api_key: "api_key", env: :test)
-    expect(client.service_url("PosTerminalManagement", "assignTerminals", "1")).
-    to eq("https://postfmapi-test.adyen.com/postfmapi/terminal/v1/assignTerminals")
-  end 
+  it 'checks the creation of balancePlatform url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :live)
+    expect(client.service_url('BalancePlatform', 'legalEntities', '1'))
+      .to eq('https://balanceplatform-api-live.adyen.com/bcl/v1/legalEntities')
+  end
+
+  it 'checks the creation of balancePlatform url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    expect(client.service_url('BalancePlatform', 'legalEntities', '1'))
+      .to eq('https://balanceplatform-api-test.adyen.com/bcl/v1/legalEntities')
+  end
+
+  it 'checks the creation of transfers url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    expect(client.service_url('Transfers', 'transactions', '1'))
+      .to eq('https://balanceplatform-api-test.adyen.com/btl/v1/transactions')
+  end
+
+  it 'checks the creation of management url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    expect(client.service_url('Management', 'companies', '1'))
+      .to eq('https://management-test.adyen.com/v1/companies')
+  end
+
+  it 'checks the creation of binLookup url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    expect(client.service_url('BinLookup', 'getCostEstimate', '54'))
+      .to eq('https://pal-test.adyen.com/pal/servlet/BinLookup/v54/getCostEstimate')
+  end
 
+  it 'check the creation of storedValue url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    expect(client.service_url('StoredValue', 'issue', '46'))
+      .to eq('https://pal-test.adyen.com/pal/servlet/StoredValue/v46/issue')
+  end
+
+  it 'check the creation of payout url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    expect(client.service_url('Payout', 'declineThirdParty', '68'))
+      .to eq('https://pal-test.adyen.com/pal/servlet/Payout/v68/declineThirdParty')
+  end
+
+  it 'checks the creation of PosTerminalManagement url' do
+    client = Adyen::Client.new(api_key: 'api_key', env: :test)
+    expect(client.service_url('PosTerminalManagement', 'assignTerminals', '1'))
+      .to eq('https://postfmapi-test.adyen.com/postfmapi/terminal/v1/assignTerminals')
+  end
 end

data/spec/data_protection_spec.rb

@@ -1,14 +1,14 @@
-require "spec_helper"
+require 'spec_helper'
 
-RSpec.describe Adyen::DataProtection, service: "Data Protection Service" do
+RSpec.describe Adyen::DataProtection, service: 'Data Protection Service' do
   # client instance to be used in dynamically generated tests
   client = create_client(:basic)
 
   # methods / values to test for
   # format is defined in spec_helper
   test_sets = [
-    ["request_subject_erasure", "result", "SUCCESS"],
+    %w[request_subject_erasure result SUCCESS]
   ]
 
-  generate_tests(client, "DataProtectionService", test_sets, client.data_protection)
+  generate_tests(client, 'DataProtectionService', test_sets, client.data_protection)
 end

data/spec/dispute_spec.rb

@@ -1,17 +1,17 @@
-require "spec_helper"
+require 'spec_helper'
 
-RSpec.describe Adyen::Dispute, service: "dispute service" do
+RSpec.describe Adyen::Dispute, service: 'dispute service' do
   # client instance to be used in dynamically generated tests
   client = create_client(:basic)
 
   # methods / values to test for
   # format is defined in spec_helper
   test_sets = [
-    ["retrieve_applicable_defense_reasons", "disputeServiceResult", { "success" => true }],
-    ["supply_defense_document", "disputeServiceResult", { "success" => true }],
-    ["delete_dispute_defense_document", "disputeServiceResult", { "success" => true }],
-    ["defend_dispute", "disputeServiceResult", { "success" => true }],
+    ['retrieve_applicable_defense_reasons', 'disputeServiceResult', { 'success' => true }],
+    ['supply_defense_document', 'disputeServiceResult', { 'success' => true }],
+    ['delete_dispute_defense_document', 'disputeServiceResult', { 'success' => true }],
+    ['defend_dispute', 'disputeServiceResult', { 'success' => true }]
   ]
 
-  generate_tests(client, "DisputeService", test_sets, client.dispute)
+  generate_tests(client, 'DisputeService', test_sets, client.dispute)
 end

data/spec/errors_spec.rb

@@ -7,49 +7,69 @@ RSpec.describe Adyen::AdyenError do
     @shared_values = {
       request: {
         amount: {
-          currency: "USD",
+          currency: 'USD',
           value: 1000
         },
-        reference: "Your order number",
+        reference: 'Your order number',
         paymentMethod: {
-          type: "scheme",
-          number: "4111111111111111",
-          expiryMonth: "10",
-          expiryYear: "2020",
-          holderName: "John Smith",
-          cvc: "737"
+          type: 'scheme',
+          number: '4111111111111111',
+          expiryMonth: '10',
+          expiryYear: '2020',
+          holderName: 'John Smith',
+          cvc: '737'
         },
-        returnUrl: "https://your-company.com/",
-        merchantAccount: "YOUR_MERCHANT_ACCOUNT"
+        returnUrl: 'https://your-company.com/',
+        merchantAccount: 'YOUR_MERCHANT_ACCOUNT'
       }
     }
   end
 
   describe '#to_s' do
     it 'describes using the error properties' do
-      expect(Adyen::AdyenError.new(@shared_values[:request], 'response', 'message', 'code').to_s).to eq("Adyen::AdyenError code:code, msg:message, request:#{@shared_values[:request]}, response:response")
+      expect(Adyen::AdyenError.new(
+        @shared_values[:request],
+        'response',
+        'message',
+        'code'
+      ).to_s).to eq("Adyen::AdyenError code:code, msg:message, request:#{@shared_values[:request]}, response:response")
     end
     it 'skips the null properties' do
-      expect(Adyen::AdyenError.new(@shared_values[:request], nil, nil, 'code').to_s).to eq("Adyen::AdyenError code:code, request:#{@shared_values[:request]}")
+      expect(Adyen::AdyenError.new(
+        @shared_values[:request],
+        nil,
+        nil,
+        'code'
+      ).to_s).to eq("Adyen::AdyenError code:code, request:#{@shared_values[:request]}")
     end
     it 'uses the proper error class name' do
-      expect(Adyen::PermissionError.new('message', @shared_values[:request], 'response').to_s).to eq("Adyen::PermissionError code:403, msg:message, request:#{@shared_values[:request]}, response:response")
+      expect(Adyen::PermissionError.new(
+        'message',
+        @shared_values[:request],
+        'response'
+      ).to_s).to eq(
+        "Adyen::PermissionError code:403, msg:message, request:#{@shared_values[:request]}, response:response"
+      )
     end
   end
   describe '#masking' do
     it 'masks card number when logging request in errors' do
-      expect(Adyen::AdyenError.new(@shared_values[:request], 'response', 'message', 'code').request[:paymentMethod][:number]).to eq('411111******1111')
+      expect(Adyen::AdyenError.new(@shared_values[:request], 'response', 'message',
+                                   'code').request[:paymentMethod][:number]).to eq('411111******1111')
     end
     it 'masks CVC when logging request in errors' do
-      expect(Adyen::AdyenError.new(@shared_values[:request], 'response', 'message', 'code').request[:paymentMethod][:cvc]).to eq('***')
+      expect(Adyen::AdyenError.new(@shared_values[:request], 'response', 'message',
+                                   'code').request[:paymentMethod][:cvc]).to eq('***')
     end
 
     context 'when request is string' do
       it 'masks card number when logging request in errors' do
-        expect(Adyen::AdyenError.new(JSON.generate(@shared_values[:request]), 'response', 'message', 'code').request[:paymentMethod][:number]).to eq('411111******1111')
+        expect(Adyen::AdyenError.new(JSON.generate(@shared_values[:request]), 'response', 'message',
+                                     'code').request[:paymentMethod][:number]).to eq('411111******1111')
       end
       it 'masks CVC when logging request in errors' do
-        expect(Adyen::AdyenError.new(JSON.generate(@shared_values[:request]), 'response', 'message', 'code').request[:paymentMethod][:cvc]).to eq('***')
+        expect(Adyen::AdyenError.new(JSON.generate(@shared_values[:request]), 'response', 'message',
+                                     'code').request[:paymentMethod][:cvc]).to eq('***')
       end
     end
   end

data/spec/fund_spec.rb

@@ -1,20 +1,20 @@
-require "spec_helper"
+require 'spec_helper'
 
-RSpec.describe Adyen::Payment, service: "marketpay fund service" do
+RSpec.describe Adyen::Payment, service: 'marketpay fund service' do
   # client instance to be used in dynamically generated tests
   client = create_client(:basic)
 
   # methods / values to test for
   # format is defined in spec_helper
   test_sets = [
-    ["payout_account_holder", "pspReference", "9915090894325643"],
-    ["account_holder_balance", "pspReference", "9914719436100053"],
-    ["account_holder_transaction_list", "pspReference", "9914721175530029"],
-    ["refund_not_paid_out_transfers", "pspReference", "9915090894215323"],
-    ["setup_beneficiary", "pspReference", "9914860354282596"],
-    ["transfer_funds", "pspReference", "9915090893984580"],
-    ["refund_funds_transfer", "pspReference", "9915090893984580"]
+    %w[payout_account_holder pspReference 9915090894325643],
+    %w[account_holder_balance pspReference 9914719436100053],
+    %w[account_holder_transaction_list pspReference 9914721175530029],
+    %w[refund_not_paid_out_transfers pspReference 9915090894215323],
+    %w[setup_beneficiary pspReference 9914860354282596],
+    %w[transfer_funds pspReference 9915090893984580],
+    %w[refund_funds_transfer pspReference 9915090893984580]
   ]
 
-  generate_tests(client, "Fund", test_sets, client.marketpay.fund)
+  generate_tests(client, 'Fund', test_sets, client.marketpay.fund)
 end

data/spec/hash_with_accessors_spec.rb

@@ -1,3 +1,5 @@
+# rubocop:disable Lint/ConstantDefinitionInBlock
+
 require 'spec_helper'
 
 RSpec.describe Adyen::HashWithAccessors do
@@ -19,15 +21,24 @@ RSpec.describe Adyen::HashWithAccessors do
     end
 
     it 'complains if there are arguments for the accessor' do
-      expect { subject.arbitrary_accessor(1) }.to raise_error(ArgumentError, 'wrong number of arguments (given 1, expected 0)')
-      expect { subject.arbitrary_accessor(1, 2) }.to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 0)')
+      expect do
+        subject.arbitrary_accessor(1)
+      end.to raise_error(ArgumentError, 'wrong number of arguments (given 1, expected 0)')
+      expect do
+        subject.arbitrary_accessor(1, 2)
+      end.to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 0)')
     end
 
     it 'complains if there are arguments for the accessor =' do
       # using send because i'm not sure how to do this wrong with normal ruby setter calling.
       # just here for completeness
-      expect { subject.send(:arbitrary_accessor=) }.to raise_error(ArgumentError, 'wrong number of arguments (given 0, expected 1)')
-      expect { subject.send(:arbitrary_accessor=, 1, 2) }.to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 1)')
+      expect do
+        subject.send(:arbitrary_accessor=)
+      end.to raise_error(ArgumentError, 'wrong number of arguments (given 0, expected 1)')
+      expect do
+        subject.send(:arbitrary_accessor=, 1,
+                     2)
+      end.to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 1)')
     end
 
     it 'responds to the accessor' do
@@ -84,8 +95,7 @@ RSpec.describe Adyen::HashWithAccessors do
 
     before(:all) do
       class Hash
-        def called_super(*args)
-        end
+        def called_super(*args); end
 
         def method_missing(*args)
           called_super(:method_missing, *args)
@@ -118,10 +128,10 @@ RSpec.describe Adyen::HashWithAccessors do
       expect(subject).to receive(:called_super).with(:method_missing, :something_else)
       expect { subject.something_else }.to raise_error(NoMethodError)
     end
-
   end
 
   it "doesn't modify all hashes" do
-    expect { {a: 1}.a }.to raise_error(NoMethodError)
+    expect { { a: 1 }.a }.to raise_error(NoMethodError)
   end
 end
+# rubocop:enable Lint/ConstantDefinitionInBlock

data/spec/hop_spec.rb

@@ -1,14 +1,14 @@
-require "spec_helper"
+require 'spec_helper'
 
-RSpec.describe Adyen::Payment, service: "marketpay hop service" do
+RSpec.describe Adyen::Payment, service: 'marketpay hop service' do
   # client instance to be used in dynamically generated tests
   client = create_client(:basic)
 
   # methods / values to test for
   # format is defined in spec_helper
   test_sets = [
-    ["get_onboarding_url", "pspReference", "8815850625171183"]
+    %w[get_onboarding_url pspReference 8815850625171183]
   ]
 
-  generate_tests(client, "Hop", test_sets, client.marketpay.hop)
+  generate_tests(client, 'Hop', test_sets, client.marketpay.hop)
 end

data/spec/lem_spec.rb

@@ -1,68 +1,63 @@
-require "spec_helper"
-require "json"
+require 'spec_helper'
+require 'json'
 
-# rubocop:disable Metrics/BlockLength
-
-RSpec.describe Adyen::LegalEntityManagement, service: "LegalEntityManagement" do
+RSpec.describe Adyen::LegalEntityManagement, service: 'LegalEntityManagement' do
   before(:all) do
     @shared_values = {
       client: create_client(:api_key),
-      service: "LegalEntityManagement",
+      service: 'LegalEntityManagement'
     }
   end
 
   # must be created manually because every field in the response is an array
-  it "makes a business_lines POST call" do
-    request_body = JSON.parse(json_from_file("mocks/requests/LegalEntityManagement/create_business_line.json"))
-
-    response_body = json_from_file("mocks/responses/LegalEntityManagement/create_business_line.json")
-
-    url = @shared_values[:client].service_url(@shared_values[:service], "businessLines", @shared_values[:client].legal_entity_management.version)
-    WebMock.stub_request(:post, url).
-      with(
-        body: request_body,
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: response_body
-      )
+  it 'makes a business_lines POST call' do
+    request_body = JSON.parse(json_from_file('mocks/requests/LegalEntityManagement/create_business_line.json'))
+
+    response_body = json_from_file('mocks/responses/LegalEntityManagement/create_business_line.json')
+
+    url = @shared_values[:client].service_url(@shared_values[:service], 'businessLines',
+                                              @shared_values[:client].legal_entity_management.version)
+    WebMock.stub_request(:post, url)
+           .with(
+             body: request_body,
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: response_body
+           )
 
     result = @shared_values[:client].legal_entity_management.business_lines_api.create_business_line(request_body)
     response_hash = result.response
 
-    expect(result.status).
-      to eq(200)
-    expect(response_hash).
-      to eq(JSON.parse(response_body))
-    expect(response_hash).
-      to be_a Adyen::HashWithAccessors
-    expect(response_hash).
-      to be_a_kind_of Hash
+    expect(result.status)
+      .to eq(200)
+    expect(response_hash)
+      .to eq(JSON.parse(response_body))
+    expect(response_hash)
+      .to be_a Adyen::HashWithAccessors
+    expect(response_hash)
+      .to be_a_kind_of Hash
   end
 
-  it "makes a documents DELETE call" do
-
-
-    url = @shared_values[:client].service_url(@shared_values[:service], "documents/123", @shared_values[:client].legal_entity_management.version)
-    WebMock.stub_request(:delete, url).
-      with(
-        headers: {
-          "x-api-key" => @shared_values[:client].api_key
-        }
-      ).
-      to_return(
-        body: "{}"
-      )
+  it 'makes a documents DELETE call' do
+    url = @shared_values[:client].service_url(@shared_values[:service], 'documents/123',
+                                              @shared_values[:client].legal_entity_management.version)
+    WebMock.stub_request(:delete, url)
+           .with(
+             headers: {
+               'x-api-key' => @shared_values[:client].api_key
+             }
+           )
+           .to_return(
+             body: '{}'
+           )
 
     result = @shared_values[:client].legal_entity_management.documents_api.delete_document('123')
-    response_hash = result.response
+    result.response
 
-      expect(result.status).
-      to eq(200)
+    expect(result.status)
+      .to eq(200)
   end
-
-
 end
-