adlint 2.4.6 → 2.4.10

data/features/code_check/W0498.feature

@@ -0,0 +1,120 @@
+Feature: W0498
+
+  W0498 detects that different operators of the same priority appear in an
+  expression without appropriate grouping.
+
+  Scenario: multiple additive-expressions in an expression
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return a + b - 5; /* W0498 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 14     |
+      | W0723 | 3    | 18     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0498 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: multiple additive-expressions in an expression with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return a + (b - 5); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 19     |
+      | W0723 | 3    | 14     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: multiple additive-expressions in an expression with large grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return (a + b - 5); /* W0498 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 15     |
+      | W0723 | 3    | 19     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0498 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: multiple multiplicative-expressions in an expression
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return a * b / 5; /* W0498 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 14     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0498 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: multiple multiplicative-expressions in an expression with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return a * (b / 5); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 14     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: multiple multiplicative-expressions in an expression grouped
+            entirely
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return (a * b / 5); /* W0498 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 15     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0498 | 3    | 12     |
+      | W0628 | 1    | 12     |

data/features/code_check/W0499.feature

@@ -0,0 +1,63 @@
+Feature: W0499
+
+  W0499 detects that different operators of the same priority except for `+',
+  `-', `*', `/' and `%' appear in an expression without appropriate grouping.
+
+  Scenario: multiple shift-expressions in an expression
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return a << b >> c; /* W0499 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W0116 | 3    | 14     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0499 | 3    | 12     |
+      | W0628 | 1    | 21     |
+
+  Scenario: multiple shift-expressions in an expression with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return (a << b) >> c; /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W0116 | 3    | 15     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0628 | 1    | 21     |
+
+  Scenario: multiple shift-expressions in an expression with large grouping
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return (a << b >> c); /* W0499 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W0116 | 3    | 15     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0499 | 3    | 12     |
+      | W0628 | 1    | 21     |

data/features/code_check/W0500.feature

@@ -0,0 +1,66 @@
+Feature: W0500
+
+  W0500 detects that `+', `-', `*' and `%' operators of the different priority
+  appear in an expression without appropriate grouping.
+
+  Scenario: additives and multiplicatives in an expression
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return a + b * c; /* W0500 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W1052 | 3    | 18     |
+      | W1052 | 3    | 14     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0500 | 3    | 12     |
+      | W0628 | 1    | 21     |
+
+  Scenario: additives and multiplicatives in an expression with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return a + (b * c); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W1052 | 3    | 19     |
+      | W1052 | 3    | 14     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0628 | 1    | 21     |
+
+  Scenario: additives and multiplicatives in an expression with large grouping
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return (a + b * c); /* W0500 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W1052 | 3    | 19     |
+      | W1052 | 3    | 15     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0500 | 3    | 12     |
+      | W0628 | 1    | 21     |

data/features/code_check/W0501.feature

@@ -0,0 +1,69 @@
+Feature: W0501
+
+  W0501 detects that a binary-expression appars in a conditional-expression
+  without appropriate grouping.
+
+  Scenario: binary-expressions in a conditional-expression
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b, int c)
+      {
+          return a + b ? a + b : c; /* W0501 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 14     |
+      | W0723 | 3    | 22     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0629 | 1    | 12     |
+      | W0501 | 3    | 18     |
+      | W0114 | 3    | 14     |
+      | W0628 | 1    | 12     |
+
+  Scenario: binary-expressions in a conditional-expression with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b, int c)
+      {
+          return (a + b) ? (a + b) : c; /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 15     |
+      | W0723 | 3    | 25     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0629 | 1    | 12     |
+      | W0114 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: binary-expressions in a conditional-expression with large grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b, int c)
+      {
+          return (a + b ? a + b : c); /* W0501 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 15     |
+      | W0723 | 3    | 23     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0104 | 1    | 34     |
+      | W0629 | 1    | 12     |
+      | W0501 | 3    | 19     |
+      | W0114 | 3    | 15     |
+      | W0628 | 1    | 12     |

data/features/code_check/W0502.feature

@@ -0,0 +1,64 @@
+Feature: W0502
+
+  W0502 detects that operators of the different priority except for `+', `-',
+  `*', `/' and `%' appear in an expression without appropriate grouping.
+
+  Scenario: shift-expression and and-expression in an expression
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return a << b & c; /* W0502 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W0116 | 3    | 14     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0502 | 3    | 12     |
+      | W0628 | 1    | 21     |
+
+  Scenario: shift-expression and and-expression in an expression with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return a << (b & c); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W0116 | 3    | 14     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0628 | 1    | 21     |
+
+  Scenario: shift-expression and and-expression in an expression with large
+            grouping
+    Given a target source named "fixture.c" with:
+      """
+      static unsigned int foo(unsigned int a, unsigned int b, unsigned int c)
+      {
+          return (a << b & c); /* W0502 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 21     |
+      | W0116 | 3    | 15     |
+      | W0104 | 1    | 38     |
+      | W0104 | 1    | 54     |
+      | W0104 | 1    | 70     |
+      | W0629 | 1    | 21     |
+      | W0502 | 3    | 12     |
+      | W0628 | 1    | 21     |

data/features/code_check/W0573.feature

@@ -87,5 +87,3 @@ Feature: W0573
       | W0100 | 6    | 9      |
       | W0947 | 6    | 19     |
       | W0628 | 3    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0583.feature

@@ -25,5 +25,3 @@ Feature: W0583
       | W0104 | 7    | 20     |
       | W0589 | 7    | 5      |
       | W0591 | 7    | 5      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0606.feature

@@ -16,5 +16,3 @@ Feature: W0606
       | mesg  | line | column |
       | W0551 | 1    | 7      |
       | W0606 | 1    | 7      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0635.feature

@@ -53,5 +53,3 @@ Feature: W0635
       | W0635 | 9    | 19     |
       | W0100 | 5    | 9      |
       | W0947 | 9    | 19     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0641.feature

@@ -128,5 +128,3 @@ Feature: W0641
       | W0641 | 3   | 12      |
       | W0104 | 1   | 17      |
       | W0628 | 1   | 7       |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0643.feature

@@ -76,5 +76,3 @@ Feature: W0643
       | mesg  | line | column |
       | W0442 | 1    | 1      |
       | W0117 | 2    | 13     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0644.feature

@@ -529,5 +529,3 @@ Feature: W0644
       | W0117 | 3    | 6      |
       | W0644 | 5    | 7      |
       | W0628 | 3    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0645.feature

@@ -138,5 +138,3 @@ Feature: W0645
       | W0002 | 1    | 13     |
       | W0645 | 1    | 13     |
       | W0628 | 1    | 13     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0646.feature

@@ -111,5 +111,3 @@ Feature: W0646
       | mesg  | line | column |
       | W9003 | 4    | 26     |
       | W0626 | 4    | 26     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0649.feature

@@ -273,5 +273,3 @@ Feature: W0649
       | W0572 | 5    | 14     |
       | W0104 | 3    | 13     |
       | W0628 | 3    | 5      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0650.feature

@@ -204,5 +204,3 @@ Feature: W0650
       | W0650 | 3    | 14     |
       | W0104 | 1    | 14     |
       | W0628 | 1    | 5      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0655.feature

@@ -0,0 +1,43 @@
+Feature: W0655
+
+  W0655 detects that a bit-field member appears as an operand of the
+  sizeof-expression.
+
+  Scenario: bit-field as an operand
+    Given a target source named "fixture.c" with:
+      """
+      extern struct Foo { unsigned int b1:1, b2:1; } foo;
+
+      static unsigned long bar(void)
+      {
+          return sizeof(foo.b1); /* W0655 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 48     |
+      | W1076 | 3    | 22     |
+      | W0655 | 5    | 12     |
+      | W0629 | 3    | 22     |
+      | W0425 | 1    | 40     |
+      | W0628 | 3    | 22     |
+
+  Scenario: arithmetic expression of two bit-fields as an operand
+    Given a target source named "fixture.c" with:
+      """
+      extern struct Foo { unsigned int b1:1, b2:1; } foo;
+
+      static unsigned long bar(void)
+      {
+          return sizeof(foo.b1 + foo.b2); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 48     |
+      | W1076 | 3    | 22     |
+      | W0629 | 3    | 22     |
+      | W0425 | 1    | 40     |
+      | W0628 | 3    | 22     |

data/features/code_check/W0685.feature

@@ -116,5 +116,3 @@ Feature: W0685
       | W0100 | 6    | 9      |
       | W0947 | 6    | 19     |
       | W0628 | 3    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0686.feature

@@ -88,5 +88,3 @@ Feature: W0686
       | W0100 | 6    | 9      |
       | W0947 | 6    | 19     |
       | W0628 | 3    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0687.feature

@@ -21,5 +21,3 @@ Feature: W0687
     When I successfully run `adlint fixture.c` on noarch
     Then the output should exactly match with:
       | mesg  | line | column |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0688.feature

@@ -59,5 +59,3 @@ Feature: W0688
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0688 | 1    | 7      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0689.feature

@@ -42,5 +42,3 @@ Feature: W0689
       | mesg  | line | column |
       | W0689 | 1    | 16     |
       | W0690 | 1    | 7      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0690.feature

@@ -31,5 +31,3 @@ Feature: W0690
     When I successfully run `adlint fixture.c` on noarch
     Then the output should exactly match with:
       | mesg  | line | column |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0691.feature

@@ -96,5 +96,3 @@ Feature: W0691
       | W0442 | 1    | 1      |
       | W0691 | 3    | 21     |
       | W0117 | 3    | 8      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0692.feature

@@ -41,5 +41,3 @@ Feature: W0692
       | mesg  | line | column |
       | W0442 | 1    | 1      |
       | W0117 | 3    | 11     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0694.feature

@@ -124,5 +124,3 @@ Feature: W0694
       | W0567 | 7    | 5      |
       | W0085 | 7    | 5      |
       | W0628 | 5    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0695.feature

@@ -74,5 +74,3 @@ Feature: W0695
       | W0567 | 7    | 5      |
       | W0085 | 7    | 5      |
       | W0628 | 5    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0697.feature

@@ -185,5 +185,3 @@ Feature: W0697
       | W0104 | 1    | 21     |
       | W1072 | 4    | 9      |
       | W0628 | 1    | 12     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0698.feature

@@ -17,5 +17,3 @@ Feature: W0698
       | W0117 | 1    | 5      |
       | W0698 | 3    | 5      |
       | W0628 | 1    | 5      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0699.feature

@@ -18,5 +18,3 @@ Feature: W0699
       | W0457 | 1    | 8      |
       | W0699 | 3    | 5      |
       | W0628 | 1    | 8      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0700.feature

@@ -52,5 +52,3 @@ Feature: W0700
       | W0117 | 1    | 8      |
       | W0457 | 1    | 8      |
       | W0628 | 1    | 8      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0703.feature

@@ -70,5 +70,3 @@ Feature: W0703
       | W1060 | 6    | 12     |
       | W0100 | 5    | 25     |
       | W0425 | 5    | 25     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0705.feature

@@ -112,6 +112,7 @@ Feature: W0705
       | W0490 | 6    | 9      |
       | W0499 | 6    | 9      |
       | W0502 | 6    | 9      |
+      | W0498 | 7    | 14     |
       | W0628 | 3    | 5      |
 
   Scenario: indirection-expression with non-constant subscript may cause OOB
@@ -142,6 +143,7 @@ Feature: W0705
       | W0490 | 5    | 9      |
       | W0499 | 5    | 9      |
       | W0502 | 5    | 9      |
+      | W0498 | 6    | 10     |
       | W0628 | 3    | 6      |
 
   Scenario: array-subscript-expression with non-constant subscript must not
@@ -249,6 +251,7 @@ Feature: W0705
       | W0490 | 6    | 9      |
       | W0499 | 6    | 9      |
       | W0502 | 6    | 9      |
+      | W0498 | 7    | 14     |
       | W0628 | 3    | 5      |
 
   Scenario: indirection-expression with non-constant subscript must not cause
@@ -278,6 +281,7 @@ Feature: W0705
       | W0490 | 5    | 9      |
       | W0499 | 5    | 9      |
       | W0502 | 5    | 9      |
+      | W0498 | 6    | 10     |
       | W0628 | 3    | 6      |
 
   Scenario: indirection-expression with non-constant subscript should not cause
@@ -311,6 +315,7 @@ Feature: W0705
       | W0490 | 5    | 9      |
       | W0499 | 5    | 9      |
       | W0502 | 5    | 9      |
+      | W0498 | 7    | 18     |
       | W0628 | 3    | 5      |
 
   Scenario: indirection-expression with non-constant subscript may and should
@@ -345,6 +350,5 @@ Feature: W0705
       | W0490 | 5    | 9      |
       | W0499 | 5    | 9      |
       | W0502 | 5    | 9      |
+      | W0498 | 7    | 18     |
       | W0628 | 3    | 5      |
-
-# vim:ts=2:sw=2:sts=2:et: