adlint 2.4.6 → 2.4.10

data/features/code_check/W0241.feature

@@ -150,5 +150,3 @@ Feature: W0241
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 11     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0242.feature

@@ -151,5 +151,3 @@ Feature: W0242
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 20     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0243.feature

@@ -150,5 +150,3 @@ Feature: W0243
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 11     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0244.feature

@@ -151,5 +151,3 @@ Feature: W0244
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 20     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0245.feature

@@ -143,5 +143,3 @@ Feature: W0245
       | W0117 | 1    | 7      |
       | W0104 | 1    | 25     |
       | W0628 | 1    | 7      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0246.feature

@@ -143,5 +143,3 @@ Feature: W0246
       | W0117 | 1    | 5      |
       | W0104 | 1    | 23     |
       | W0628 | 1    | 5      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0247.feature

@@ -143,5 +143,3 @@ Feature: W0247
       | W0117 | 1    | 6      |
       | W0104 | 1    | 24     |
       | W0628 | 1    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0248.feature

@@ -138,5 +138,3 @@ Feature: W0248
       | W0117 | 1    | 5      |
       | W0104 | 1    | 24     |
       | W0628 | 1    | 5      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0249.feature

@@ -138,5 +138,3 @@ Feature: W0249
       | W0117 | 1    | 6      |
       | W0104 | 1    | 25     |
       | W0628 | 1    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0250.feature

@@ -142,5 +142,3 @@ Feature: W0250
       | W1049 | 3    | 12     |
       | W0104 | 1    | 23     |
       | W0628 | 1    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0251.feature

@@ -155,5 +155,3 @@ Feature: W0251
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 11     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0252.feature

@@ -151,5 +151,3 @@ Feature: W0252
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 11     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0253.feature

@@ -150,5 +150,3 @@ Feature: W0253
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 11     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0254.feature

@@ -150,5 +150,3 @@ Feature: W0254
       | W0834 | 1    | 1      |
       | W0834 | 3    | 13     |
       | W0628 | 1    | 11     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0425.feature

@@ -275,5 +275,3 @@ Feature: W0425
       | W0425 | 2    | 24     |
       | W0425 | 3    | 26     |
       | W0425 | 4    | 25     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0431.feature

@@ -37,5 +37,3 @@ Feature: W0431
       | W0443 | 3    | 1      |
       | W0443 | 4    | 1      |
       | W0628 | 8    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0432.feature

@@ -37,5 +37,3 @@ Feature: W0432
       | W0443 | 3    | 1      |
       | W0443 | 4    | 1      |
       | W0628 | 8    | 6      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0477.feature

@@ -73,5 +73,3 @@ Feature: W0477
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0480 | 1    | 1      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0478.feature

@@ -99,5 +99,3 @@ Feature: W0478
       | mesg  | line | column |
       | W0442 | 1    | 1      |
       | W0549 | 1    | 38     |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0479.feature

@@ -61,5 +61,3 @@ Feature: W0479
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0483 | 1    | 1      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0480.feature

@@ -115,5 +115,3 @@ Feature: W0480
       | mesg  | line | column |
       | W0442 | 1    | 1      |
       | W0478 | 1    | 1      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0481.feature

@@ -24,5 +24,3 @@ Feature: W0481
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0442 | 1    | 1      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0482.feature

@@ -60,5 +60,3 @@ Feature: W0482
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0479 | 1    | 1      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0483.feature

@@ -58,5 +58,3 @@ Feature: W0483
     Then the output should exactly match with:
       | mesg  | line | column |
       | W0479 | 1    | 1      |
-
-# vim:ts=2:sw=2:sts=2:et:

data/features/code_check/W0488.feature

@@ -0,0 +1,132 @@
+Feature: W0488
+
+  W0488 detects that multiple function-call-expressions or
+  member-access-expressions or array-subscript-expressions appear in a
+  logical-and-expression or a logical-or-expression without appropriate
+  grouping.
+
+  Scenario: member-access-expression and array-subscript-expression and
+            function-call-expression as an operand of logical-and-expression
+    Given a target source named "fixture.c" with:
+      """
+      struct foo { int (*a[3])(void); };
+
+      static void foo(struct foo *p)
+      {
+          if (p) {
+              if (p->a[0]() && p->a[1]()) { /* W0488 */
+                  return;
+              }
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 13     |
+      | W0104 | 3    | 29     |
+      | W0105 | 3    | 29     |
+      | W1071 | 3    | 13     |
+      | W0629 | 3    | 13     |
+      | W0488 | 6    | 13     |
+      | W0508 | 6    | 23     |
+      | W0114 | 5    | 5      |
+      | W0628 | 3    | 13     |
+
+  Scenario: member-access-expression and array-subscript-expression and
+            function-call-expression as an operand of logical-and-expression
+            with grouping
+    Given a target source named "fixture.c" with:
+      """
+      struct foo { int (*a[3])(void); };
+
+      static void foo(struct foo *p)
+      {
+          if (p) {
+              if (((p->a[0])()) && ((p->a[1])())) { /* OK */
+                  return;
+              }
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 13     |
+      | W0104 | 3    | 29     |
+      | W0105 | 3    | 29     |
+      | W1071 | 3    | 13     |
+      | W0629 | 3    | 13     |
+      | W0508 | 6    | 27     |
+      | W0114 | 5    | 5      |
+      | W0628 | 3    | 13     |
+
+  Scenario: member-access-expression and array-subscript-expression and
+            function-call-expression as an operand of logical-and-expression
+            grouped entirely
+    Given a target source named "fixture.c" with:
+      """
+      struct foo { int (*a[3])(void); };
+
+      static void foo(struct foo *p)
+      {
+          if (p) {
+              if ((p->a[0]() && p->a[1]())) { /* W0488 */
+                  return;
+              }
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 3    | 13     |
+      | W0104 | 3    | 29     |
+      | W0105 | 3    | 29     |
+      | W1071 | 3    | 13     |
+      | W0629 | 3    | 13     |
+      | W0488 | 6    | 13     |
+      | W0508 | 6    | 24     |
+      | W0114 | 5    | 5      |
+      | W0628 | 3    | 13     |
+
+  Scenario: ungrouped array-subscript-expression in a logical-and-expression
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int a[])
+      {
+          if (i && a[0]) { /* W0488 */
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0488 | 3    | 9      |
+      | W0628 | 1    | 13     |
+
+  Scenario: grouped array-subscript-expression in a logical-and-expression
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int a[])
+      {
+          if (i && (a[0])) { /* OK */
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0628 | 1    | 13     |

data/features/code_check/W0489.feature

@@ -0,0 +1,78 @@
+Feature: W0489
+
+  W0489 detects that multiple unary-expressions appear as an operand of a
+  logical-and-expression or a logical-or-expression without appropriate
+  grouping.
+
+  Scenario: unary-expressions appear as an operand of a logical-and-expression
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int *p)
+      {
+          if (p) {
+              if (-i++ && !*p) { /* W0489 */
+                  return;
+              }
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0104 | 1    | 29     |
+      | W0105 | 1    | 29     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0489 | 4    | 13     |
+      | W0114 | 3    | 5      |
+      | W0628 | 1    | 13     |
+
+  Scenario: unary-expressions appear as an operand of a logical-and-expression
+            with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int *p)
+      {
+          if (p) {
+              if ((-i++) && (!*p)) { /* OK */
+                  return;
+              }
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0104 | 1    | 29     |
+      | W0105 | 1    | 29     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0114 | 3    | 5      |
+      | W0628 | 1    | 13     |
+
+  Scenario: unary-expressions appear as an operand of a logical-and-expression
+            grouped entirely
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int *p)
+      {
+          if (p) {
+              if ((-i++ && !*p)) { /* W0489 */
+                  return;
+              }
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0104 | 1    | 29     |
+      | W0105 | 1    | 29     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0489 | 4    | 13     |
+      | W0114 | 3    | 5      |
+      | W0628 | 1    | 13     |

data/features/code_check/W0490.feature

@@ -0,0 +1,83 @@
+Feature: W0490
+
+  W0490 detects that multiple precedence binary-expressions appear as an
+  operand of a logical-and-expression or a logical-or-expression without
+  appropriate grouping.
+
+  Scenario: precedence binary-expressions appear as an operand of a
+            logical-and-expression
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int j)
+      {
+          if (i + j && i * j) { /* W0490 */
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0723 | 3    | 11     |
+      | W0723 | 3    | 20     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0490 | 3    | 9      |
+      | W0500 | 3    | 9      |
+      | W0502 | 3    | 9      |
+      | W0732 | 3    | 15     |
+      | W0628 | 1    | 13     |
+
+  Scenario: precedence binary-expressions appear as an operand of a
+            logical-and-expression with grouping
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int j)
+      {
+          if ((i + j) && (i * j)) { /* OK */
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0723 | 3    | 12     |
+      | W0723 | 3    | 23     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0732 | 3    | 17     |
+      | W0628 | 1    | 13     |
+
+  Scenario: precedence binary-expressions appear as an operand of a
+            logical-and-expression grouped entirely
+    Given a target source named "fixture.c" with:
+      """
+      static void foo(int i, int j)
+      {
+          if ((i + j && i * j)) { /* W0490 */
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 13     |
+      | W0723 | 3    | 12     |
+      | W0723 | 3    | 21     |
+      | W0104 | 1    | 21     |
+      | W0104 | 1    | 28     |
+      | W1071 | 1    | 13     |
+      | W0629 | 1    | 13     |
+      | W0490 | 3    | 9      |
+      | W0500 | 3    | 9      |
+      | W0502 | 3    | 9      |
+      | W0732 | 3    | 16     |
+      | W0628 | 1    | 13     |

data/features/code_check/W0495.feature

@@ -0,0 +1,60 @@
+Feature: W0495
+
+  W0495 detects that different arithmetic operators appear with modulo operator
+  in an expression without appropriate grouping.
+
+  Scenario: without grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return a + b % 5; /* W0495 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 14     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0495 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: with appropriate grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return (a + b) % 5; /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 15     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: entirely grouped
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return (a + b % 5); /* W0495 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 15     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0495 | 3    | 12     |
+      | W0628 | 1    | 12     |

data/features/code_check/W0496.feature

@@ -0,0 +1,63 @@
+Feature: W0496
+
+  W0496 detects that multiple conditional-expressions appear in an expression
+  without appropriate grouping.
+
+  Scenario: without grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return a < 0 ? a : b > 0 ? a + b : b; /* W0496 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 34     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0496 | 3    | 12     |
+      | W0501 | 3    | 18     |
+      | W0628 | 1    | 12     |
+
+  Scenario: with appropriate grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return a < 0 ? a : (b > 0 ? a + b : b); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 35     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0501 | 3    | 18     |
+      | W0628 | 1    | 12     |
+
+  Scenario: entirely grouped
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(int a, int b)
+      {
+          return (a < 0 ? a : b > 0 ? a + b : b); /* W0496 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0723 | 3    | 35     |
+      | W0104 | 1    | 20     |
+      | W0104 | 1    | 27     |
+      | W0629 | 1    | 12     |
+      | W0496 | 3    | 13     |
+      | W0501 | 3    | 19     |
+      | W0628 | 1    | 12     |

data/features/code_check/W0497.feature

@@ -0,0 +1,65 @@
+Feature: W0497
+
+  W0497 detects that multiple shift-expressions or relational-expressions or
+  equality-expressions appear in an expression without appropriate grouping.
+
+  Scenario: without grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(unsigned int a, unsigned int b)
+      {
+          return a << 1 < b << 2; /* W0497 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0116 | 3    | 14     |
+      | W0116 | 3    | 23     |
+      | W0104 | 1    | 29     |
+      | W0104 | 1    | 45     |
+      | W0629 | 1    | 12     |
+      | W0497 | 3    | 12     |
+      | W0502 | 3    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: with appropriate grouping
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(unsigned int a, unsigned int b)
+      {
+          return (a << 1) < (b << 2); /* OK */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0116 | 3    | 15     |
+      | W0116 | 3    | 26     |
+      | W0104 | 1    | 29     |
+      | W0104 | 1    | 45     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: entirely grouped
+    Given a target source named "fixture.c" with:
+      """
+      static int foo(unsigned int a, unsigned int b)
+      {
+          return (a << 1 < b << 2); /* W0497 */
+      }
+      """
+    When I successfully run `adlint fixture.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0116 | 3    | 15     |
+      | W0116 | 3    | 24     |
+      | W0104 | 1    | 29     |
+      | W0104 | 1    | 45     |
+      | W0629 | 1    | 12     |
+      | W0497 | 3    | 12     |
+      | W0502 | 3    | 12     |
+      | W0628 | 1    | 12     |