adlint 1.6.0 → 1.8.0

data/NEWS

@@ -21,6 +21,50 @@
 
 ++
 
+=== \AdLint 1.8.0 is released (2012-04-27)
+
+==== Changes since the 1.6.0 release
+
+* Add W0607 detection
+* Add W0608 detection
+* Add W0625 detection
+* Add W0632 detection
+* Add W0633 detection
+* Add W0634 detection
+* Add W0642 detection
+* Add W0711 detection
+* Add W0712 detection
+* Add W0713 detection
+* Add W0714 detection
+* Add W0715 detection
+* Add W0832 detection
+* Fix W0629 detection not to warn when the translation-unit local function is
+  referred to derive a pointer to the function
+* Fix W0459 and W0460 detections not to warn about inner variables owned by a
+  temporary variable
+* Fix W0461 and W0462 detections not to warn when the length omitted array
+  parameter is specified as an argument.
+* Fix W1031 detection not to warn when the storage-class-specifier of the
+  object declaration is explicitly specified and the storage-class-specifier of
+  following object definition is omitted
+* Fix W0581, W0582, W0583 and W0584 detections not to warn when the
+  corresponding types of argument and parameter are array-array or
+  array-pointer pair
+* Fix W0581 detection to warn when the number of arguments in current function
+  call is greater than the number of arguments in previous function calls
+* Fix W0582, W0583 and W0584 detections to warn when the number of parameters
+  is greater than the number of arguments
+* Fix abend problem when the pathname of #include_next directive is not in the
+  executing environment
+* Support mswin path separator in #include or #include_next directives
+* Fix bad FN_UELS (number of incomplete if-else-if statement chains) metric
+  measurement
+* Improve value version management of the abstract interpreter
+
+See the file
+{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
+for more details.
+
 === \AdLint 1.6.0 is released (2012-04-06)
 
 ==== Changes since the 1.4.0 release
@@ -49,21 +93,17 @@
 * Add W1061 detection
 * Add W1062 detection
 * Add W1063 detection
-* Fix W0027 detection not to warn when a pointer variable is compared
-  with NULL constant
-* Fix W0728, W0729 and W0730 detections not to warn when the target
-  is a variable of the other enum type
-* Fix W0104 detection not to warn about invariant parameter of array
-  type whose base type is qualified as const
+* Fix W0027 detection not to warn when a pointer variable is compared with NULL
+  constant
+* Fix W0728, W0729 and W0730 detections not to warn when the target is a
+  variable of the other enum type
+* Fix W0104 detection not to warn about invariant parameter of array type whose
+  base type is qualified as const
 * Fix bad W0031, W0100, W0104, W0459 and W0460 detections
 * Fix bad FN_UNUV measurement
 * Update the user's guide in Japanese
 * Update the user's guide in English
 
-See the file
-{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
-for more details.
-
 === \AdLint 1.4.0 is released (2012-03-29)
 
 ==== Changes since the 1.2.0 release

data/etc/conf.d/i686-mingw/cinit-gcc_4.6.1.erb

@@ -220,7 +220,7 @@
 #define __GNUC_GNU_INLINE__ 1
 #define __UINT_FAST8_TYPE__ unsigned char
 #define __declspec(x) __attribute__((x))
-#
+
 #define __const const
 #define __restrict restrict
 #define __restrict__ restrict

data/etc/mesg.d/en_US/messages.yml

@@ -36,7 +36,7 @@
 #     X9999: "Your custom message for the fatal error of #9999."
 #     E9999: "Your custom message for the error of #9999."
 
-version: "1.6.0"
+version: "1.8.0"
 
 message_definition:
   X0001: "An unknown exception `%s' is found."
@@ -497,7 +497,7 @@ message_definition:
   W0535: "A comma operator is used in a 'for' statement."
   W0538: "This 'default' label is not final label in this 'switch' statement."
   W0540: "A function which the blank formal argument list is declared. `void' is omitted."
-  W0541: "This function mixed weaves C code with inline assembly code."
+  W0541: "Inline assembly code should be encapsulated by macro."
   W0542: "There are identifiers in the part of formal argument in a function declaration."
   W0543: "The identifier of formal argument in this function declaration is different from the past declaration of it."
   W0544: "The identifier of formal argument in the function declaration is different from the declaration of function pointer."
@@ -562,8 +562,8 @@ message_definition:
   W0627: "There is a dead letter (only `;') in the following other code."
   W0628: "A function `%s' is defined, but this is not used in this project."
   W0629: "A static function `%s()' is not used in this translation unit."
-  W0632: "If `'' or `/*' use in `#include <%s>', it will unspecify behavior."
-  W0633: "If `'' or `/*' use in `#include \"%s\"', it will unspecify behavior."
+  W0632: "Using ' or \" characters in `#include %s' directive makes undefined behavior."
+  W0633: "Using ' character in `#include %s' directive makes undefined behavior."
   W0634: "`\\' is used in `#include' line. `/' is recommended for the path delimiter."
   W0635: "The type doesn't match with %sth conversion specifier and the corresponding actual argument."
   W0636: "An actual argument doesn't exist correspond to %sth conversion specifier."
@@ -614,9 +614,9 @@ message_definition:
   W0685: "A character preceding the `-' in scanset o `[]' is bigger than a character following the `-'."
   W0686: "The same characters are described in scanset (characters enclosed by `[]')."
   W0687: "#undef is using to delete #defined operator."
-  W0688: "There is no line number in 1 to 32767 ranges after '#line'."
-  W0689: "#line command syntax doesn't match `#line volatile integer constant value \"string\"'."
-  W0690: "This is not line number after '#line' value'."
+  W0688: "There is no line number in 1 to 32767 ranges after #line directive."
+  W0689: "#line directive syntax doesn't match `#line integer constant \"string\"'."
+  W0690: "No line number after #line directive."
   W0691: "The result of `##' operator is not valid preprocessing token."
   W0692: "A function-like macro doesn't given an actual argument."
   W0693: "A function-like macro is called by actual argument which its definition is smaller."

data/etc/mesg.d/ja_JP/messages.yml

@@ -36,7 +36,7 @@
 #     X9999: "Your custom message for the fatal error of #9999."
 #     E9999: "Your custom message for the error of #9999."
 
-version: "1.6.0"
+version: "1.8.0"
 
 message_definition:
   X0001: "不明な例外条件 `%s' を検出しました。"
@@ -497,7 +497,7 @@ message_definition:
   W0535: "for 文の制御式の中にカンマ演算子が使われています。"
   W0538: "この default ラベルは、switch 文内の最後のラベルではありません。"
   W0540: "空の仮引数並びの関数が定義されています。`void' が省略されています。"
-  W0541: "この関数には C コードとインラインアセンブリコードが混在しています。"
+  W0541: "マクロで隠蔽されないインラインアセンブリコードです。"
   W0542: "関数宣言の仮引数の一部にのみ識別子が存在します。"
   W0543: "この関数宣言における仮引数の識別子は、以前の宣言の仮引数の識別子と異なります。"
   W0544: "関数宣言の仮引数の識別子と関数ポインタの宣言の仮引数の識別子が異なります。"
@@ -562,8 +562,8 @@ message_definition:
   W0627: "一行に、空文(`;' だけの文)が、他のコードの後にあります。"
   W0628: "関数 `%s' が定義されていますが、このプロジェクトでは使われていません。"
   W0629: "static 関数 `%s()' は、この翻訳単位の中で使われていません。"
-  W0632: "`#include <%s>' の中で `''、`\"' または `/*' を使うと、未定義の動作になります。"
-  W0633: "`#include \"%s\"' の中で `'' や `/*' を使うと、未定義の動作になります。"
+  W0632: "`#include %s' の中で ' や \" 文字を使うと、未定義の動作になります。"
+  W0633: "`#include %s' の中で ' 文字を使うと、未定義の動作になります。"
   W0634: "`#include' 行の中で `\\' を使っています。パス区切り文字としては `/' を勧めます。"
   W0635: "%s 番目の変換指定子と、対応する実引数の型が合いません。"
   W0636: "%s 番目の変換指定子に対応する実引数が存在しません。"

data/lib/adlint/c/branch.rb

@@ -85,7 +85,7 @@ module C #:nodoc:
     end
 
     def execute(interpreter, expression = nil, &block)
-      environment.begin_versioning_group if first?
+      environment.enter_versioning_group if first?
       environment.begin_versioning
 
       @controlling_expression = ControllingExpression.new(interpreter, self)
@@ -95,7 +95,7 @@ module C #:nodoc:
 
     ensure
       environment.end_versioning(break_with_return?)
-      environment.end_versioning_group(!@group.complete?) if final?
+      environment.leave_versioning_group(!@group.complete?) if final?
 
       if final? && @group.complete?
         rethrow_break_event
@@ -105,8 +105,8 @@ module C #:nodoc:
     def restart_versioning(&block)
       @controlling_expression.save_affected_variables
       environment.end_versioning(false)
-      environment.end_versioning_group(true)
-      environment.begin_versioning_group
+      environment.leave_versioning_group(true)
+      environment.enter_versioning_group
       environment.begin_versioning
       yield
       @controlling_expression.restore_affected_variables

data/lib/adlint/c/code.rb

@@ -356,16 +356,15 @@ module C #:nodoc:
     def do_prepare(context) end
     def do_execute(context) end
 
-    def update_caller(function_definition)
-      @caller = function_definition
+    def update_caller(function_definition, function)
+      @caller = function
     end
 
     def extract_function_call(function_call_expression, function,
                               arg_variables, result_variable)
       if @caller && function.named?
         CALL(function_call_expression.location,
-             FunctionIdentifier.new(@caller.identifier.value,
-                                    @caller.signature.to_s),
+             FunctionIdentifier.new(@caller.name, @caller.signature.to_s),
              FunctionIdentifier.new(function.name, function.signature.to_s))
       end
     end
@@ -387,18 +386,18 @@ module C #:nodoc:
     def do_prepare(context) end
     def do_execute(context) end
 
-    def update_accessor(function_definition)
-      @accessor = function_definition
+    def update_accessor(function_definition, function)
+      @accessor = function
     end
 
-    def clear_accessor(function_definition)
+    def clear_accessor(function_definition, function)
       @accessor = nil
     end
 
     def extract_variable_read(expression, variable)
       if @accessor && variable.scope.global? && variable.named?
         XREF_VAR(expression.location,
-                 FunctionIdentifier.new(@accessor.identifier.value,
+                 FunctionIdentifier.new(@accessor.name,
                                         @accessor.signature.to_s),
                  "R", variable.name)
       end
@@ -407,7 +406,7 @@ module C #:nodoc:
     def extract_variable_write(expression, variable)
       if @accessor && variable.scope.global? && variable.named?
         XREF_VAR(expression.location,
-                 FunctionIdentifier.new(@accessor.identifier.value,
+                 FunctionIdentifier.new(@accessor.name,
                                         @accessor.signature.to_s),
                  "W", variable.name)
       end
@@ -416,11 +415,10 @@ module C #:nodoc:
     def extract_function_reference(expression, function)
       if @accessor && function.named?
         XREF_FUNC(expression.location,
-                  FunctionIdentifier.new(@accessor.identifier.value,
+                  FunctionIdentifier.new(@accessor.name,
                                          @accessor.signature.to_s),
-                  "R",
-                  FunctionIdentifier.new(function.name,
-                                         function.signature.to_s))
+                  "R", FunctionIdentifier.new(function.name,
+                                              function.signature.to_s))
       end
     end
   end

data/lib/adlint/c/enum.rb

@@ -29,8 +29,6 @@
 #
 #++
 
-require "adlint/c/syntax"
-
 module AdLint #:nodoc:
 module C #:nodoc:
 

data/lib/adlint/c/environ.rb

@@ -29,6 +29,7 @@
 #
 #++
 
+require "adlint/c/enum"
 require "adlint/c/object"
 require "adlint/c/builtin"
 require "adlint/c/branch"
@@ -108,18 +109,23 @@ module C #:nodoc:
       @branch_depth -= 1
     end
 
-    def begin_versioning_group
-      @variable_table.begin_versioning_group
+    def enter_versioning_group
+      @variable_table.enter_variables_value_versioning_group
     end
 
-    extend Forwardable
+    def leave_versioning_group(raise_complement)
+      @variable_table.leave_variables_value_versioning_group(raise_complement)
+    end
 
-    def_delegator :variable_table, :end_versioning_group
-    def_delegator :variable_table, :begin_versioning
+    def begin_versioning
+      @variable_table.begin_variables_value_versioning
+    end
 
     def end_versioning(rollback_this_version)
-      @variable_table.rollback_latest_version if rollback_this_version
-      @variable_table.end_versioning
+      if rollback_this_version
+        @variable_table.rollback_latest_variables_value_version!
+      end
+      @variable_table.end_variables_value_versioning
     end
 
     private

data/lib/adlint/c/expr.rb

@@ -316,7 +316,11 @@ module C #:nodoc:
       #       cross-references.
       _notify_variable_value_referred(node, object)
 
-      temporary_variable(pointer_type(object.type), pointer_value_of(object))
+      pointer = temporary_variable(pointer_type(object.type),
+                                   pointer_value_of(object))
+
+      notify_address_expr_evaled(node, object, pointer)
+      pointer
     end
 
     def execute_indirection_expression(node, object)

data/lib/adlint/c/interp.rb

@@ -114,11 +114,11 @@ module C #:nodoc:
 
     # NOTE: Notified when the interpreter starts execution of a
     #       function-definition.
-    def_plugin_and_notifier :function_started, :function_definition
+    def_plugin_and_notifier :function_started, :function_definition, :function
 
     # NOTE: Notified when the interpreter ends execution of a
     #       function-definition.
-    def_plugin_and_notifier :function_ended, :function_definition
+    def_plugin_and_notifier :function_ended, :function_definition, :function
 
     # NOTE: Notified when the interpreter evaluates a parameter-definition at
     #       beginning of execution of a function-definition.
@@ -238,6 +238,10 @@ module C #:nodoc:
                             :conditional_expression, :condition_variable,
                             :result_variable
 
+    # NOTE: Notified when the interpreter evaluates an address-expression.
+    def_plugin_and_notifier :address_expr_evaled,
+                            :address_expression, :object, :pointer_variable
+
     # NOTE: Notified when the interpreter evaluates an indirection-expression.
     def_plugin_and_notifier :indirection_expr_evaled,
                             :indirection_expression, :pointer_variable,
@@ -820,7 +824,7 @@ module C #:nodoc:
       end
 
       scoped_eval do
-        notify_function_started(node)
+        notify_function_started(node, function)
         notify_block_started(node.function_body)
 
         node.parameter_definitions.each { |pdef| interpret(pdef) }
@@ -830,7 +834,7 @@ module C #:nodoc:
         end
 
         notify_block_ended(node.function_body)
-        notify_function_ended(node)
+        notify_function_ended(node, function)
       end
     ensure
       interpreter._leave_function(node)
@@ -1187,11 +1191,11 @@ module C #:nodoc:
         }
 
         unless anterior_gotos.empty?
-          variable.value.begin_versioning_group
+          variable.value.enter_versioning_group
           variable.value.begin_versioning
           variable.uninitialize!
           variable.value.end_versioning
-          variable.value.end_versioning_group(true)
+          variable.value.leave_versioning_group(true)
         end
       end
     end

data/lib/adlint/c/mediator.rb

@@ -211,6 +211,7 @@ module C #:nodoc:
     def_delegator :interpreter, :notify_logical_and_expr_evaled
     def_delegator :interpreter, :notify_logical_or_expr_evaled
     def_delegator :interpreter, :notify_conditional_expr_evaled
+    def_delegator :interpreter, :notify_address_expr_evaled
     def_delegator :interpreter, :notify_indirection_expr_evaled
     def_delegator :interpreter, :notify_member_access_expr_evaled
     def_delegator :interpreter, :notify_prefix_increment_expr_evaled