adlint 1.2.0 → 1.4.0

data/lib/adlint/c/message_shima.rb

@@ -0,0 +1,151 @@
+# Message detection classes for C language.
+#
+# Author::    Rie Shima <mailto:rkakuuchi@users.sourceforge.net>
+# Copyright:: Copyright (C) 2010-2012, OGIS-RI Co.,Ltd.
+# License::   GPLv3+: GNU General Public License version 3 or later
+#
+# Owner::     Rie Shima <mailto:rkakuuchi@users.sourceforge.net>
+
+#--
+#     ___    ____  __    ___   _________
+#    /   |  / _  |/ /   / / | / /__  __/           Source Code Static Analyzer
+#   / /| | / / / / /   / /  |/ /  / /                   AdLint - Advanced Lint
+#  / __  |/ /_/ / /___/ / /|  /  / /
+# /_/  |_|_____/_____/_/_/ |_/  /_/   Copyright (C) 2010-2012, OGIS-RI Co.,Ltd.
+#
+# This file is part of AdLint.
+#
+# AdLint is free software: you can redistribute it and/or modify it under the
+# terms of the GNU General Public License as published by the Free Software
+# Foundation, either version 3 of the License, or (at your option) any later
+# version.
+#
+# AdLint is distributed in the hope that it will be useful, but WITHOUT ANY
+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# AdLint.  If not, see <http://www.gnu.org/licenses/>.
+#
+#++
+
+require "adlint/report"
+require "adlint/message"
+
+module AdLint #:nodoc:
+module C #:nodoc:
+
+  class W0606 < PassiveMessageDetection
+    def initialize(context)
+      super
+      visitor = context[:c_visitor]
+      visitor.enter_union_type_declaration += method(:check)
+    end
+
+    private
+    def check(node)
+      node.struct_declarations.each do |struct_declaration|
+        struct_declaration.items.each do |member_decl|
+          if member_decl.type.scalar? && member_decl.type.floating?
+            W(:W0606, node.location)
+            return
+          end
+        end
+      end
+    end
+  end
+
+  class W0698 < PassiveMessageDetection
+    def initialize(context)
+      super
+      visitor = context[:c_visitor]
+      visitor.enter_ansi_function_definition += method(:start_function)
+      visitor.enter_kandr_function_definition += method(:start_function)
+      visitor.leave_ansi_function_definition += method(:end_function)
+      visitor.leave_kandr_function_definition += method(:end_function)
+      visitor.enter_return_statement += method(:check)
+      @current_function = nil
+    end
+
+    private
+    def start_function(function_definition)
+      @current_function = function_definition
+    end
+
+    def end_function(function_definition)
+      @current_function = nil
+    end
+
+    def check(return_statement)
+      return unless @current_function.explicitly_typed?
+
+      if return_type = @current_function.type.return_type
+        if !return_type.void? && return_statement.expression.nil?
+          W(:W0698, return_statement.location,
+            @current_function.identifier.value)
+        end
+      end
+    end
+  end
+
+  class W0699 < W0698
+    private
+    def check(return_statement)
+      return unless @current_function.implicitly_typed?
+
+      if return_statement.expression.nil?
+        W(:W0699, return_statement.location,
+          @current_function.identifier.value)
+      end
+    end
+  end
+
+  class W0726 < W0698
+    private
+    def check(return_statement)
+      return unless return_statement.expression
+
+      if return_type = @current_function.type.return_type
+        if return_type.void? && (return_type.const? || return_type.volatile?)
+          W(:W0726, return_statement.location,
+            @current_function.identifier.value)
+        end
+      end
+    end
+  end
+
+  class W0801 < PassiveMessageDetection
+    def initialize(context)
+      super
+      visitor = context[:c_visitor]
+      visitor.enter_struct_type_declaration += method(:check)
+      visitor.enter_union_type_declaration += method(:check)
+    end
+
+    private
+    def check(node)
+      W(:W0801, node.location) if node.type.members.empty?
+    end
+  end
+
+  class W1033 < PassiveMessageDetection
+    def initialize(context)
+      super
+      visitor = context[:c_visitor]
+      visitor.enter_ansi_function_definition += method(:check)
+      visitor.enter_kandr_function_definition += method(:check)
+      visitor.enter_function_declaration += method(:check)
+    end
+
+    private
+    def check(definition_or_declaration)
+      if return_type = definition_or_declaration.type.return_type
+        if return_type.const? || return_type.volatile?
+          W(:W1033, definition_or_declaration.location)
+        end
+      end
+    end
+  end
+
+end
+end

data/lib/adlint/c/phase.rb

@@ -563,6 +563,7 @@ module C #:nodoc:
         W0599.new(context),
         W0600.new(context),
         W0605.new(context),
+        W0606.new(context),
         W0609.new(context),
         W0610.new(context),
         W0611.new(context),
@@ -613,12 +614,30 @@ module C #:nodoc:
         W0682.new(context),
         W0683.new(context),
         W0684.new(context),
+        W0698.new(context),
+        W0699.new(context),
         W0703.new(context),
         W0704.new(context),
         W0705.new(context),
         W0708.new(context),
+        W0720.new(context),
+        W0721.new(context),
+        W0722.new(context),
+        W0723.new(context),
+        W0726.new(context),
+        W0727.new(context),
+        W0728.new(context),
+        W0729.new(context),
+        W0730.new(context),
+        W0731.new(context),
         W0736.new(context),
+        W0737.new(context),
+        W0738.new(context),
+        W0739.new(context),
+        W0740.new(context),
+        W0741.new(context),
         W0742.new(context),
+        W0743.new(context),
         W0744.new(context),
         W0745.new(context),
         W0747.new(context),
@@ -660,6 +679,7 @@ module C #:nodoc:
         W0798.new(context),
         W0799.new(context),
         W0800.new(context),
+        W0801.new(context),
         W0810.new(context),
         W0827.new(context),
         W0828.new(context),
@@ -672,11 +692,14 @@ module C #:nodoc:
         W1029.new(context),
         W1031.new(context),
         W1032.new(context),
+        W1033.new(context),
         W1034.new(context),
         W1049.new(context),
         W1050.new(context),
         W1051.new(context),
         W1052.new(context),
+        W1064.new(context),
+        W1065.new(context),
         W9001.new(context)
       ]
     end

data/lib/adlint/c/resolver.rb

@@ -94,6 +94,7 @@ module C #:nodoc:
       checkpoint(node.location)
       type = @type_table.install_enum_type(node)
       node.type = type
+      node.enumerators.each { |enum| enum.type = type }
     end
 
     def visit_typedef_declaration(node)

data/lib/adlint/c/syntax.rb

@@ -1107,7 +1107,38 @@ module C #:nodoc:
     end
   end
 
+  module DeclarationSpecifiersHolder
+    def storage_class_specifier
+      @declaration_specifiers ?
+        @declaration_specifiers.storage_class_specifier : nil
+    end
+
+    def function_specifier
+      # NOTE: A function-specifier should only be in function-definitions.
+      @declaration_specifiers ?
+        @declaration_specifiers.function_specifier : nil
+    end
+
+    def type_qualifiers
+      @declaration_specifiers ? @declaration_specifiers.type_qualifiers : []
+    end
+
+    def type_specifiers
+      @declaration_specifiers ? @declaration_specifiers.type_specifiers : []
+    end
+
+    def explicitly_typed?
+      @declaration_specifiers && @declaration_specifiers.explicitly_typed?
+    end
+
+    def implicitly_typed?
+      !explicitly_typed?
+    end
+  end
+
   class Declaration < SyntaxNode
+    include DeclarationSpecifiersHolder
+
     def initialize(declaration_specifiers, init_declarators, symbol_table)
       super()
       @declaration_specifiers = declaration_specifiers
@@ -1174,8 +1205,7 @@ module C #:nodoc:
         return []
       end
 
-      result = []
-      init_declarators.each do |init_declarator|
+      init_declarators.each_with_object([]) do |init_declarator, result|
         if init_declarator.declarator.function?
           symbol = symbol_table.create_new_symbol(
             ObjectName, init_declarator.declarator.identifier)
@@ -1183,51 +1213,51 @@ module C #:nodoc:
                                               init_declarator, symbol))
         end
       end
-      result
     end
 
     def build_variable_declaration(declaration_specifiers, init_declarators,
                                    symbol_table)
       return [] unless declaration_specifiers
 
-      result = []
-      if declaration_specifiers.storage_class_specifier &&
+      unless declaration_specifiers.storage_class_specifier &&
           declaration_specifiers.storage_class_specifier.type == :EXTERN
-        init_declarators.each do |init_declarator|
-          if init_declarator.declarator.variable?
-            declarator = init_declarator.declarator
-            symbol =
-              symbol_table.create_new_symbol(ObjectName, declarator.identifier)
-            result.push(VariableDeclaration.new(declaration_specifiers,
-                                                declarator, symbol))
-          end
+        return []
+      end
+
+      init_declarators.each_with_object([]) do |init_declarator, result|
+        if init_declarator.declarator.variable?
+          declarator = init_declarator.declarator
+          symbol =
+            symbol_table.create_new_symbol(ObjectName, declarator.identifier)
+          result.push(VariableDeclaration.new(declaration_specifiers,
+                                              declarator, symbol))
         end
       end
-      result
     end
 
     def build_variable_definition(declaration_specifiers, init_declarators,
                                   symbol_table)
-      result = []
-      unless declaration_specifiers &&
+      if declaration_specifiers &&
           declaration_specifiers.storage_class_specifier &&
           (declaration_specifiers.storage_class_specifier.type == :EXTERN ||
            declaration_specifiers.storage_class_specifier.type == :TYPEDEF)
-        init_declarators.each do |init_declarator|
-          if init_declarator.declarator.variable?
-            symbol = symbol_table.create_new_symbol(
-              ObjectName, init_declarator.declarator.identifier)
-            result.push(VariableDefinition.new(declaration_specifiers,
-                                               init_declarator, symbol))
-          end
+        return []
+      end
+
+      init_declarators.each_with_object([]) do |init_declarator, result|
+        if init_declarator.declarator.variable?
+          symbol = symbol_table.create_new_symbol(
+            ObjectName, init_declarator.declarator.identifier)
+          result.push(VariableDefinition.new(declaration_specifiers,
+                                             init_declarator, symbol))
         end
       end
-      result
     end
   end
 
   class FunctionDeclaration < SyntaxNode
     include SymbolicElement
+    include DeclarationSpecifiersHolder
     include SyntaxNodeCollector
 
     def initialize(declaration_specifiers, init_declarator, symbol)
@@ -1247,11 +1277,6 @@ module C #:nodoc:
       @init_declarator.declarator.identifier
     end
 
-    def storage_class_specifier
-      @declaration_specifiers ?
-        @declaration_specifiers.storage_class_specifier : nil
-    end
-
     def signature
       FunctionSignature.new(identifier, @type)
     end
@@ -1272,6 +1297,7 @@ module C #:nodoc:
 
   class VariableDeclaration < SyntaxNode
     include SymbolicElement
+    include DeclarationSpecifiersHolder
 
     def initialize(declaration_specifiers, declarator, symbol)
       super()
@@ -1290,11 +1316,6 @@ module C #:nodoc:
       @declarator.identifier
     end
 
-    def storage_class_specifier
-      @declaration_specifiers ?
-        @declaration_specifiers.storage_class_specifier : nil
-    end
-
     def location
       identifier.location
     end
@@ -1305,33 +1326,35 @@ module C #:nodoc:
     end
   end
 
-  class Definition < SyntaxNode; end
+  class Definition < SyntaxNode
+    include DeclarationSpecifiersHolder
+
+    def initialize(declaration_specifiers)
+      @declaration_specifiers = declaration_specifiers
+      @type = nil
+    end
+
+    attr_reader :declaration_specifiers
+    attr_accessor :type
+  end
 
   class VariableDefinition < Definition
     include SymbolicElement
 
     def initialize(declaration_specifiers, init_declarator, symbol)
-      super()
-      @declaration_specifiers = declaration_specifiers
+      super(declaration_specifiers)
+
       @init_declarator = init_declarator
       @symbol = symbol
-      @type = nil
     end
 
-    attr_reader :declaration_specifiers
     attr_reader :init_declarator
     attr_reader :symbol
-    attr_accessor :type
 
     def identifier
       @init_declarator.declarator.identifier
     end
 
-    def storage_class_specifier
-      @declaration_specifiers ?
-        @declaration_specifiers.storage_class_specifier : nil
-    end
-
     def initializer
       @init_declarator.initializer
     end
@@ -1358,6 +1381,8 @@ module C #:nodoc:
   end
 
   class TypedefDeclaration < TypeDeclaration
+    include DeclarationSpecifiersHolder
+
     def initialize(declaration_specifiers, init_declarator, symbol)
       super(symbol)
       @declaration_specifiers = declaration_specifiers
@@ -1377,14 +1402,6 @@ module C #:nodoc:
       @init_declarator.declarator
     end
 
-    def type_qualifiers
-      @declaration_specifiers.type_qualifiers
-    end
-
-    def type_specifiers
-      @declaration_specifiers.type_specifiers
-    end
-
     def location
       identifier.location
     end
@@ -1519,6 +1536,14 @@ module C #:nodoc:
       head_location
     end
 
+    def explicitly_typed?
+      !implicitly_typed?
+    end
+
+    def implicitly_typed?
+      @type_specifiers.empty?
+    end
+
     def inspect(indent = 0)
       " " * indent + short_class_name
     end
@@ -1689,14 +1714,12 @@ module C #:nodoc:
 
     private
     def build_items(specifier_qualifier_list, struct_declarators)
-      result = []
-      struct_declarators.each do |struct_declarator|
+      struct_declarators.each_with_object([]) do |struct_declarator, items|
         # FIXME: Must support unnamed bit padding.
         next unless struct_declarator.declarator
-        result.push(MemberDeclaration.new(specifier_qualifier_list,
-                                          struct_declarator))
+        items.push(MemberDeclaration.new(specifier_qualifier_list,
+                                         struct_declarator))
       end
-      result
     end
   end
 
@@ -1818,6 +1841,7 @@ module C #:nodoc:
     attr_reader :expression
     attr_reader :symbol
     attr_accessor :value
+    attr_accessor :type
 
     def location
       @identifier.location
@@ -2114,6 +2138,8 @@ module C #:nodoc:
   end
 
   class ParameterDeclaration < SyntaxNode
+    include DeclarationSpecifiersHolder
+
     def initialize(declaration_specifiers, declarator)
       super()
       @declaration_specifiers = declaration_specifiers
@@ -2749,36 +2775,23 @@ module C #:nodoc:
 
     def initialize(declaration_specifiers, declarator, parameter_definitions,
                    compound_statement, symbol_table)
-      super()
-      @declaration_specifiers = declaration_specifiers
+      super(declaration_specifiers)
+
       @declarator = declarator
       @parameter_definitions = parameter_definitions
       @function_body = compound_statement
       @symbol = symbol_table.create_new_symbol(ObjectName, identifier)
-      @type = nil
       @type_declaration = build_type_declaration(declaration_specifiers,
                                                  symbol_table)
       build_label_references(compound_statement)
     end
 
-    attr_reader :declaration_specifiers
     attr_reader :declarator
     attr_reader :parameter_definitions
     attr_reader :function_body
     attr_reader :symbol
-    attr_accessor :type
     attr_reader :type_declaration
 
-    def storage_class_specifier
-      @declaration_specifiers ?
-        @declaration_specifiers.storage_class_specifier : nil
-    end
-
-    def function_specifier
-      @declaration_specifiers ?
-        @declaration_specifiers.function_specifier : nil
-    end
-
     def identifier
       @declarator.identifier
     end
@@ -2856,14 +2869,12 @@ module C #:nodoc:
     def create_parameters(parameter_names, declarations, symbol_table)
       return [] unless parameter_names
 
-      result = []
-      parameter_names.each do |name|
+      parameter_names.each_with_object([]) do |name, result|
         variable_definition =
           find_variable_definition(declarations, name, symbol_table)
         result.push(
           variable_definition_to_parameter_definition(variable_definition))
       end
-      result
     end
 
     def find_variable_definition(declarations, name, symbol_table)
@@ -2942,15 +2953,12 @@ module C #:nodoc:
 
   class ParameterDefinition < Definition
     def initialize(declaration_specifiers, declarator)
-      super()
-      @declaration_specifiers = declaration_specifiers
+      super(declaration_specifiers)
+
       @declarator = declarator
-      @type = nil
     end
 
-    attr_reader :declaration_specifiers
     attr_reader :declarator
-    attr_accessor :type
 
     def identifier
       if @declarator
@@ -2964,19 +2972,14 @@ module C #:nodoc:
       end
     end
 
-    def storage_class_specifier
-      @declaration_specifiers ?
-        @declaration_specifiers.storage_class_specifier : nil
-    end
-
     def location
       identifier ? identifier.location : nil
     end
 
     def to_variable_definition
-      PseudoVariableDefinition.new(@declaration_specifiers,
+      PseudoVariableDefinition.new(declaration_specifiers,
                                    InitDeclarator.new(@declarator, nil),
-                                   @type)
+                                   type)
     end
 
     def inspect(indent = 0)
@@ -2989,7 +2992,8 @@ module C #:nodoc:
   class PseudoVariableDefinition < VariableDefinition
     def initialize(declaration_specifiers, init_declarator, type)
       super(declaration_specifiers, init_declarator, nil)
-      @type = type
+
+      self.type = type
     end
 
     def mark_as_referred_by(token) end