adlint 1.14.0 → 1.16.0

data/features/message_detection/W1072.feature

@@ -24,6 +24,7 @@ Feature: W1072
     When I successfully run `adlint W1072.c` on noarch
     Then the output should exactly match with:
       | mesg  | line | column |
+      | W1076 | 1    | 12     |
       | W0629 | 1    | 12     |
       | W1072 | 4    | 9      |
       | W1072 | 7    | 5      |

data/features/message_detection/W1073.feature

@@ -0,0 +1,145 @@
+Feature: W1073
+
+  W1073 detects that a return value of the function is discarded.
+
+  Scenario: simply discarding a return value
+    Given a target source named "W1073.c" with:
+      """
+      extern int bar(void);
+      static void foo(void)
+      {
+          bar(); /* W1073 */
+      }
+      """
+    When I successfully run `adlint W1073.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1076 | 2    | 13     |
+      | W1073 | 4    | 8      |
+      | W0629 | 2    | 13     |
+      | W0628 | 2    | 13     |
+
+  Scenario: calling `void' function
+    Given a target source named "W1073.c" with:
+      """
+      extern void bar(void);
+      static void foo(void)
+      {
+          bar(); /* OK */
+      }
+      """
+    When I successfully run `adlint W1073.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 13     |
+      | W1076 | 2    | 13     |
+      | W0629 | 2    | 13     |
+      | W0628 | 2    | 13     |
+
+  Scenario: discarding return value in comma separated expression
+    Given a target source named "W1073.c" with:
+      """
+      extern int bar(void);
+      extern void baz(void);
+      static void foo(void)
+      {
+          int i;
+          i = (bar(), baz()); /* W1073 */
+      }
+      """
+    When I successfully run `adlint W1073.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0118 | 2    | 13     |
+      | W1076 | 3    | 13     |
+      | W0100 | 5    | 9      |
+      | W1073 | 6    | 13     |
+      | W0629 | 3    | 13     |
+      | W0447 | 6    | 10     |
+      | W0628 | 3    | 13     |
+
+  Scenario: discarding return value in for-statement
+    Given a target source named "W1073.c" with:
+      """
+      extern int bar(void);
+      static void foo(void)
+      {
+          int i;
+          int j;
+          for (i = 0, bar(); i < 10; i++) { /* W1073 */
+              j = bar(); /* OK */
+          }
+      }
+      """
+    When I successfully run `adlint W1073.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1076 | 2    | 13     |
+      | W0100 | 5    | 9      |
+      | W1073 | 6    | 20     |
+      | W0629 | 2    | 13     |
+      | W0535 | 6    | 10     |
+      | W0628 | 2    | 13     |
+
+  Scenario: no assignment but not discarding the return value
+    Given a target source named "W1073.c" with:
+      """
+      extern int bar(void);
+      static void foo(void)
+      {
+          if (bar() == 0) { /* OK */
+              return;
+          }
+      }
+      """
+    When I successfully run `adlint W1073.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1076 | 2    | 13     |
+      | W0629 | 2    | 13     |
+      | W0628 | 2    | 13     |
+
+  Scenario: propagating the return value
+    Given a target source named "W1073.c" with:
+      """
+      extern int bar(void);
+      static int foo(void)
+      {
+          return bar(); /* OK */
+      }
+      """
+    When I successfully run `adlint W1073.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1076 | 2    | 12     |
+      | W0629 | 2    | 12     |
+      | W0628 | 2    | 12     |
+
+  Scenario: propagating the return value in a conditional-expression
+    Given a target source named "W1073.c" with:
+      """
+      extern int bar(void);
+      extern int baz(void);
+      static int foo(void)
+      {
+          return bar() == 0 ? baz() : 0; /* OK */
+      }
+      """
+    When I successfully run `adlint W1073.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0118 | 2    | 12     |
+      | W1076 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0501 | 5    | 12     |
+      | W0010 | 5    | 23     |
+      | W0086 | 5    | 23     |
+      | W0628 | 3    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W1074.feature

@@ -0,0 +1,139 @@
+Feature: W1074
+
+  W1074 detects that an expression with possible side-effects appears in the
+  `sizeof' expression.
+
+  Scenario: postfix-increment-expression in the sizeof-expression
+    Given a target source named "W1074.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0;
+
+          if (sizeof(i++) == 4) { /* W1074 */
+              return 0;
+          }
+          else {
+              return 1;
+          }
+      }
+      """
+    When I successfully run `adlint W1074.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0612 | 5    | 21     |
+      | W0609 | 5    | 21     |
+      | W0629 | 1    | 12     |
+      | W1074 | 5    | 15     |
+      | W9001 | 9    | 9      |
+      | W0628 | 1    | 12     |
+
+  Scenario: nested sizeof-expression
+    Given a target source named "W1074.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0;
+
+          if (sizeof(1 + sizeof(i++)) == 5) { /* W1074 */
+              return 0;
+          }
+          else {
+              return 1;
+          }
+      }
+      """
+    When I successfully run `adlint W1074.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0613 | 5    | 33     |
+      | W0610 | 5    | 33     |
+      | W0629 | 1    | 12     |
+      | W1074 | 5    | 26     |
+      | W9001 | 6    | 9      |
+      | W0628 | 1    | 12     |
+
+  Scenario: ungrouped postfix-increment-expression in the sizeof-expression
+    Given a target source named "W1074.c" with:
+      """
+      static int foo(void)
+      {
+          int i = 0;
+
+          if (sizeof i++ == 4) { /* W1074 */
+              return 0;
+          }
+          else {
+              return 1;
+          }
+      }
+      """
+    When I successfully run `adlint W1074.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0612 | 5    | 20     |
+      | W0609 | 5    | 20     |
+      | W0629 | 1    | 12     |
+      | W1074 | 5    | 17     |
+      | W9001 | 9    | 9      |
+      | W0628 | 1    | 12     |
+
+  Scenario: function-call-expression in the sizeof-expression
+    Given a target source named "W1074.c" with:
+      """
+      extern int bar(void);
+
+      static int foo(void)
+      {
+          if (sizeof(bar()) == 4) { /* W1074 */
+              return 0;
+          }
+          else {
+              return 1;
+          }
+      }
+      """
+    When I successfully run `adlint W1074.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1076 | 3    | 12     |
+      | W0612 | 5    | 23     |
+      | W0609 | 5    | 23     |
+      | W1073 | 5    | 19     |
+      | W0629 | 3    | 12     |
+      | W1074 | 5    | 15     |
+      | W9001 | 9    | 9      |
+      | W0628 | 3    | 12     |
+
+  Scenario: array-subscript-expression in the sizeof-expression
+    Given a target source named "W1074.c" with:
+      """
+      extern int a[];
+
+      static int foo(void)
+      {
+          if (sizeof(a[0]) == 4) { /* OK */
+              return 0;
+          }
+          else {
+              return 1;
+          }
+      }
+      """
+    When I successfully run `adlint W1074.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W1077 | 1    | 12     |
+      | W1076 | 3    | 12     |
+      | W0612 | 5    | 22     |
+      | W0609 | 5    | 22     |
+      | W0629 | 3    | 12     |
+      | W9001 | 9    | 9      |
+      | W0628 | 3    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W1075.feature

@@ -0,0 +1,86 @@
+Feature: W1075
+
+  W1075 detects that a declaration has no `static' specifier while the anterior
+  declaration is specified as `static'.
+
+  Scenario: colliding global variable declarations
+    Given a target source named "W1075.c" with:
+      """
+      static int i;
+      extern int i; /* W1075 */
+      """
+    When I successfully run `adlint W1075.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1031 | 2    | 12     |
+      | W1075 | 2    | 12     |
+
+  Scenario: `static' function declaration followed by its definition without
+            storage-class-specifier
+    Given a target source named "W1075.c" with:
+      """
+      static int foo(void);
+
+      int foo(void) /* W1075 */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1075.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1075 | 3    | 5      |
+      | W0629 | 3    | 5      |
+      | W0628 | 3    | 5      |
+
+  Scenario: colliding function declarations with `static' and `extern'
+    Given a target source named "W1075.c" with:
+      """
+      static int foo(void);
+
+      extern int foo(void) /* W1075 */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1075.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1031 | 3    | 12     |
+      | W1075 | 3    | 12     |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: all function declarations with `static'
+    Given a target source named "W1075.c" with:
+      """
+      static int foo(void);
+
+      static int foo(void) /* OK */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1075.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: all function declarations with `extern'
+    Given a target source named "W1075.c" with:
+      """
+      extern int foo(void);
+
+      extern int foo(void) /* OK */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1075.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0118 | 1    | 12     |
+      | W0628 | 3    | 12     |
+
+# vim:ts=2:sw=2:sts=2:et:

data/features/message_detection/W1076.feature

@@ -0,0 +1,66 @@
+Feature: W1076
+
+  W1076 detects that a `static' function definition appears with no anterior
+  function declarations.
+
+  Scenario: `static' function definition
+    Given a target source named "W1076.c" with:
+      """
+      static int foo(void) /* W1076 */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1076.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W1076 | 1    | 12     |
+      | W0629 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: `static' function declaration followed by the `static' function
+            definition
+    Given a target source named "W1076.c" with:
+      """
+      static int foo(void);
+
+      static int foo(void) /* OK */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1076.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0629 | 3    | 12     |
+      | W0628 | 3    | 12     |
+
+  Scenario: `extern' function definition
+    Given a target source named "W1076.c" with:
+      """
+      extern int foo(void) /* OK */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1076.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 12     |
+      | W0628 | 1    | 12     |
+
+  Scenario: function definition without storage-class-specifier
+    Given a target source named "W1076.c" with:
+      """
+      int foo(void) /* OK */
+      {
+          return 0;
+      }
+      """
+    When I successfully run `adlint W1076.c` on noarch
+    Then the output should exactly match with:
+      | mesg  | line | column |
+      | W0117 | 1    | 5      |
+      | W0628 | 1    | 5      |
+
+# vim:ts=2:sw=2:sts=2:et: