activity_notification 2.4.1 → 2.5.0

data/spec/controllers/subscriptions_controller_spec.rb

@@ -1,11 +0,0 @@
-require 'controllers/subscriptions_controller_shared_examples'
-
-describe ActivityNotification::SubscriptionsController, type: :controller do
-  let(:test_target)        { create(:user) }
-  let(:target_type)        { :users }
-  let(:typed_target_param) { :user_id }
-  let(:extra_params)       { {} }
-  let(:valid_session)      {}
-
-  it_behaves_like :subscriptions_controller
-end

data/spec/controllers/subscriptions_with_devise_controller_spec.rb

@@ -1,97 +0,0 @@
-require 'controllers/subscriptions_controller_shared_examples'
-
-describe ActivityNotification::SubscriptionsWithDeviseController, type: :controller do
-  include ActivityNotification::ControllerSpec::RequestUtility
-
-  let(:test_user)            { create(:confirmed_user) }
-  let(:unauthenticated_user) { create(:confirmed_user) }
-  let(:test_target)          { create(:admin, user: test_user) }
-  let(:target_type)          { :admins }
-  let(:typed_target_param)   { :admin_id }
-  let(:extra_params)         { { devise_type: :users } }
-  let(:valid_session)        {}
-
-  context "signed in with devise as authenticated user" do
-    before do
-      sign_in test_user
-    end
-  
-    it_behaves_like :subscriptions_controller
-  end
-
-  context "signed in with devise as unauthenticated user" do
-    let(:target_params) { { target_type: target_type, devise_type: :users } }
-
-    describe "GET #index" do
-      before do
-        sign_in unauthenticated_user
-        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
-      end
-  
-      it "returns 403 as http status code" do
-        expect(response.status).to eq(403)
-      end
-    end
-  end
-
-  context "unsigned in with devise" do
-    let(:target_params) { { target_type: target_type, devise_type: :users } }
-
-    describe "GET #index" do
-      before do
-        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
-      end
-  
-      it "returns 302 as http status code" do
-        expect(response.status).to eq(302)
-      end
-
-      it "redirects to sign_in path" do
-        expect(response).to redirect_to new_user_session_path
-      end
-    end
-  end
-
-  context "without devise_type parameter" do
-    let(:target_params) { { target_type: target_type } }
-
-    describe "GET #index" do
-      before do
-        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
-      end
-  
-      it "returns 400 as http status code" do
-        expect(response.status).to eq(400)
-      end
-    end
-  end
-
-  context "with wrong devise_type parameter" do
-    let(:target_params) { { target_type: target_type, devise_type: :dummy_targets } }
-
-    describe "GET #index" do
-      before do
-        get_with_compatibility :index, target_params.merge({ typed_target_param => test_target }), valid_session
-      end
-  
-      it "returns 403 as http status code" do
-        expect(response.status).to eq(403)
-      end
-    end
-  end
-
-  context "without target_id and (typed_target)_id parameters for devise integrated controller with devise_type option" do
-    let(:target_params) { { target_type: target_type, devise_type: :users } }
-
-    describe "GET #index" do
-      before do
-        sign_in test_target.user
-        get_with_compatibility :index, target_params, valid_session
-      end
-
-      it "returns 200 as http status code" do
-        expect(response.status).to eq(200)
-      end
-    end
-  end
-end

data/spec/factories/admins.rb

@@ -1,5 +0,0 @@
-FactoryBot.define do
-  factory :admin do
-    user
-  end
-end

data/spec/factories/articles.rb

@@ -1,5 +0,0 @@
-FactoryBot.define do
-  factory :article do
-    association :user, factory: :confirmed_user
-  end
-end

data/spec/factories/comments.rb

@@ -1,6 +0,0 @@
-FactoryBot.define do
-  factory :comment do
-    article
-    association :user, factory: :confirmed_user
-  end
-end

data/spec/factories/dummy/dummy_group.rb

@@ -1,4 +0,0 @@
-FactoryBot.define do
-  factory :dummy_group, class: Dummy::DummyGroup do
-  end
-end

data/spec/factories/dummy/dummy_notifiable.rb

@@ -1,4 +0,0 @@
-FactoryBot.define do
-  factory :dummy_notifiable, class: Dummy::DummyNotifiable do
-  end
-end

data/spec/factories/dummy/dummy_notifier.rb

@@ -1,4 +0,0 @@
-FactoryBot.define do
-  factory :dummy_notifier, class: Dummy::DummyNotifier do
-  end
-end

data/spec/factories/dummy/dummy_subscriber.rb

@@ -1,4 +0,0 @@
-FactoryBot.define do
-  factory :dummy_subscriber, class: Dummy::DummySubscriber do
-  end
-end

data/spec/factories/dummy/dummy_target.rb

@@ -1,4 +0,0 @@
-FactoryBot.define do
-  factory :dummy_target, class: Dummy::DummyTarget do
-  end
-end

data/spec/factories/notifications.rb

@@ -1,7 +0,0 @@
-FactoryBot.define do
-  factory :notification, class: ActivityNotification::Notification do
-    association :target, factory: :confirmed_user
-    association :notifiable, factory: :article
-    key { "default.default" }
-  end
-end

data/spec/factories/subscriptions.rb

@@ -1,8 +0,0 @@
-FactoryBot.define do
-  factory :subscription, class: ActivityNotification::Subscription do
-    association :target, factory: :confirmed_user
-    key { "default.default" }
-    subscribed_at { Time.current }
-    subscribed_to_email_at { Time.current }
-  end
-end

data/spec/factories/users.rb

@@ -1,11 +0,0 @@
-FactoryBot.define do
-  factory :user do
-    email { Array.new(10){[*"A".."Z", *"0".."9"].sample}.join + '@example.com' }
-    password { "password" }
-    password_confirmation { "password" }
-  end
-
-  factory :confirmed_user, parent: :user do
-    after(:build) { |user| user.skip_confirmation! }
-  end
-end

data/spec/generators/controllers_generator_spec.rb

@@ -1,85 +0,0 @@
-require 'generators/activity_notification/controllers_generator'
-
-describe ActivityNotification::Generators::ControllersGenerator, type: :generator do
-
-  # setup_default_destination
-  destination File.expand_path("../../../tmp", __FILE__)
-  before { prepare_destination }
-
-  it 'runs generating controllers tasks' do
-    gen = generator %w(users)
-    expect(gen).to receive :create_controllers
-    expect(gen).to receive(:readme).and_return(true)
-    gen.invoke_all
-  end
-
-  describe 'the generated files' do
-    context 'without target argument' do
-      it 'raises Thor::RequiredArgumentMissingError' do
-        expect { run_generator }
-        .to raise_error(Thor::RequiredArgumentMissingError)
-      end
-    end
-
-    context 'with users as target' do
-      context 'with target controllers as default' do
-        before do
-          run_generator %w(users)
-        end
-
-        describe 'the notifications_controller' do
-          subject { file('app/controllers/users/notifications_controller.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::NotificationsController < ActivityNotification::NotificationsController/) }
-        end
-
-        describe 'the notifications_with_devise_controller' do
-          subject { file('app/controllers/users/notifications_with_devise_controller.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::NotificationsWithDeviseController < ActivityNotification::NotificationsWithDeviseController/) }
-        end
-
-        describe 'the subscriptions_controller' do
-          subject { file('app/controllers/users/subscriptions_controller.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::SubscriptionsController < ActivityNotification::SubscriptionsController/) }
-        end
-
-        describe 'the subscriptions_with_devise_controller' do
-          subject { file('app/controllers/users/subscriptions_with_devise_controller.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::SubscriptionsWithDeviseController < ActivityNotification::SubscriptionsWithDeviseController/) }
-        end
-      end
-
-      context 'with a controllers option as notifications and subscriptions' do
-        before do
-          run_generator %w(users --controllers notifications subscriptions)
-        end
-
-        describe 'the notifications_controller' do
-          subject { file('app/controllers/users/notifications_controller.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::NotificationsController < ActivityNotification::NotificationsController/) }
-        end
-
-        describe 'the notifications_with_devise_controller' do
-          subject { file('app/controllers/users/notifications_with_devise_controller.rb') }
-          it { is_expected.not_to exist }
-        end
-
-        describe 'the subscriptions_controller' do
-          subject { file('app/controllers/users/subscriptions_controller.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::SubscriptionsController < ActivityNotification::SubscriptionsController/) }
-        end
-
-        describe 'the subscriptions_with_devise_controller' do
-          subject { file('app/controllers/users/subscriptions_with_devise_controller.rb') }
-          it { is_expected.not_to exist }
-        end
-      end
-    end
-
-  end
-end

data/spec/generators/install_generator_spec.rb

@@ -1,43 +0,0 @@
-require 'generators/activity_notification/install_generator'
-
-describe ActivityNotification::Generators::InstallGenerator, type: :generator do
-
-  # setup_default_destination
-  destination File.expand_path("../../../tmp", __FILE__)
-  before { prepare_destination }
-
-  it 'runs both the initializer and locale tasks' do
-    gen = generator
-    expect(gen).to receive :copy_initializer
-    expect(gen).to receive :copy_locale
-    expect(gen).to receive(:readme).and_return(true)
-    gen.invoke_all
-  end
-
-  describe 'the generated files' do
-    context 'with active_record orm as default' do
-      before do
-        run_generator
-      end
-
-      describe 'the initializer' do
-        subject { file('config/initializers/activity_notification.rb') }
-        it { is_expected.to exist }
-        it { is_expected.to contain(/ActivityNotification.configure do |config|/) }
-      end
-
-      describe 'the locale file' do
-        subject { file('config/locales/activity_notification.en.yml') }
-        it { is_expected.to exist }
-        it { is_expected.to contain(/en:\n.+notification:\n.+default:/) }
-      end
-    end
-
-    context 'with orm option as not :active_record' do
-      it 'raises MissingORMError' do
-        expect { run_generator %w(--orm dummy) }
-        .to raise_error(TypeError)
-      end
-    end
-  end
-end

data/spec/generators/migration/migration_generator_spec.rb

@@ -1,80 +0,0 @@
-require 'generators/activity_notification/migration/migration_generator'
-
-describe ActivityNotification::Generators::MigrationGenerator, type: :generator do
-
-  # setup_default_destination
-  destination File.expand_path("../../../../tmp", __FILE__)
-
-  before do
-    prepare_destination
-  end
-
-  after do
-    if ActivityNotification.config.orm == :active_record
-      ActivityNotification::Notification.reset_column_information
-      ActivityNotification::Subscription.reset_column_information
-    end
-  end
-
-  it 'runs generating migration tasks' do
-    gen = generator
-    expect(gen).to receive :create_migrations
-    gen.invoke_all
-  end
-
-  describe 'the generated files' do
-    context 'without name argument' do
-      before do
-        run_generator
-      end
-
-      describe 'CreateNotifications migration file' do
-        subject { file(Dir["tmp/db/migrate/*_create_activity_notification_tables.rb"].first.gsub!('tmp/', '')) }
-        it { is_expected.to exist }
-        it { is_expected.to contain(/class CreateActivityNotificationTables < ActiveRecord::Migration\[\d\.\d\]/) }
-
-        if ActivityNotification.config.orm == :active_record
-          it 'can be executed to migrate scheme' do
-            require subject
-            # Suppress migration output during tests
-            old_verbose = ActiveRecord::Migration.verbose
-            ActiveRecord::Migration.verbose = false
-            begin
-              CreateActivityNotificationTables.new.migrate(:down)
-              CreateActivityNotificationTables.new.migrate(:up)
-            ensure
-              ActiveRecord::Migration.verbose = old_verbose
-            end
-          end
-        end
-      end
-    end
-
-    context 'with CreateCustomNotifications as name argument' do
-      before do
-        run_generator %w(CreateCustomNotifications --tables notifications)
-      end
-
-      describe 'CreateCustomNotifications migration file' do
-        subject { file(Dir["tmp/db/migrate/*_create_custom_notifications.rb"].first.gsub!('tmp/', '')) }
-        it { is_expected.to exist }
-        it { is_expected.to contain(/class CreateCustomNotifications < ActiveRecord::Migration\[\d\.\d\]/) }
-
-        if ActivityNotification.config.orm == :active_record
-          it 'can be executed to migrate scheme' do
-            require subject
-            # Suppress migration output during tests
-            old_verbose = ActiveRecord::Migration.verbose
-            ActiveRecord::Migration.verbose = false
-            begin
-              CreateActivityNotificationTables.new.migrate(:down)
-              CreateActivityNotificationTables.new.migrate(:up)
-            ensure
-              ActiveRecord::Migration.verbose = old_verbose
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/spec/generators/models_generator_spec.rb

@@ -1,96 +0,0 @@
-require 'generators/activity_notification/models_generator'
-
-describe ActivityNotification::Generators::ModelsGenerator, type: :generator do
-
-  # setup_default_destination
-  destination File.expand_path("../../../tmp", __FILE__)
-  before { prepare_destination }
-
-  it 'runs generating model tasks' do
-    gen = generator %w(users)
-    expect(gen).to receive :create_models
-    expect(gen).to receive(:readme).and_return(true)
-    gen.invoke_all
-  end
-
-  describe 'the generated files' do
-    context 'without target argument' do
-      it 'raises Thor::RequiredArgumentMissingError' do
-        expect { run_generator }
-        .to raise_error(Thor::RequiredArgumentMissingError)
-      end
-    end
-
-    context 'with users as target' do
-      context 'with target models as default' do
-        before do
-          run_generator %w(users)
-        end
-
-        describe 'the notification' do
-          subject { file('app/models/users/notification.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::Notification < ActivityNotification::Notification/) }
-        end
-
-        describe 'the subscription' do
-          subject { file('app/models/users/subscription.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::Subscription < ActivityNotification::Subscription/) }
-        end
-      end
-
-      context 'with a models option as notification' do
-        before do
-          run_generator %w(users --models notification)
-        end
-
-        describe 'the notification' do
-          subject { file('app/models/users/notification.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::Notification < ActivityNotification::Notification/) }
-        end
-
-        describe 'the subscription' do
-          subject { file('app/models/users/subscription.rb') }
-          it { is_expected.not_to exist }
-        end
-      end
-
-      context 'with a names option as custom_notification and custom_subscription' do
-        before do
-          run_generator %w(users --names custom_notification custom_subscription)
-        end
-
-        describe 'the notification' do
-          subject { file('app/models/users/custom_notification.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::CustomNotification < ActivityNotification::Notification/) }
-        end
-
-        describe 'the subscription' do
-          subject { file('app/models/users/custom_subscription.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::CustomSubscription < ActivityNotification::Subscription/) }
-        end
-      end
-
-      context 'with a models option as notification and a names option as custom_notification' do
-        before do
-          run_generator %w(users --models notification --names custom_notification)
-        end
-
-        describe 'the notification' do
-          subject { file('app/models/users/custom_notification.rb') }
-          it { is_expected.to exist }
-          it { is_expected.to contain(/class Users::CustomNotification < ActivityNotification::Notification/) }
-        end
-
-        describe 'the subscription' do
-          subject { file('app/models/users/subscription.rb') }
-          it { is_expected.not_to exist }
-        end
-      end
-    end
-  end
-end