activerecord 2.3.18 → 3.0.0.beta

data/test/cases/lifecycle_test.rb

@@ -1,193 +0,0 @@
-require "cases/helper"
-require 'models/topic'
-require 'models/developer'
-require 'models/reply'
-require 'models/minimalistic'
-
-class Topic; def after_find() end end
-class Developer; def after_find() end end
-class SpecialDeveloper < Developer; end
-
-class TopicManualObserver
-  include Singleton
-
-  attr_reader :action, :object, :callbacks
-
-  def initialize
-    Topic.add_observer(self)
-    @callbacks = []
-  end
-
-  def update(callback_method, object)
-    @callbacks << { "callback_method" => callback_method, "object" => object }
-  end
-
-  def has_been_notified?
-    !@callbacks.empty?
-  end
-end
-
-class TopicaAuditor < ActiveRecord::Observer
-  observe :topic
-
-  attr_reader :topic
-
-  def after_find(topic)
-    @topic = topic
-  end
-end
-
-class TopicObserver < ActiveRecord::Observer
-  attr_reader :topic
-
-  def after_find(topic)
-    @topic = topic
-  end
-end
-
-class MinimalisticObserver < ActiveRecord::Observer
-  attr_reader :minimalistic
-
-  def after_find(minimalistic)
-    @minimalistic = minimalistic
-  end
-end
-
-class MultiObserver < ActiveRecord::Observer
-  attr_reader :record
-
-  def self.observed_class() [ Topic, Developer ] end
-
-  cattr_reader :last_inherited
-  @@last_inherited = nil
-
-  def observed_class_inherited_with_testing(subclass)
-    observed_class_inherited_without_testing(subclass)
-    @@last_inherited = subclass
-  end
-
-  alias_method_chain :observed_class_inherited, :testing
-
-  def after_find(record)
-    @record = record
-  end
-end
-
-class LifecycleTest < ActiveRecord::TestCase
-  fixtures :topics, :developers, :minimalistics
-
-  def test_before_destroy
-    original_count = Topic.count
-    (topic_to_be_destroyed = Topic.find(1)).destroy
-    assert_equal original_count - (1 + topic_to_be_destroyed.replies.size), Topic.count
-  end
-
-  def test_after_save
-    ActiveRecord::Base.observers = :topic_manual_observer
-    ActiveRecord::Base.instantiate_observers
-
-    topic = Topic.find(1)
-    topic.title = "hello"
-    topic.save
-
-    assert TopicManualObserver.instance.has_been_notified?
-    assert_equal :after_save, TopicManualObserver.instance.callbacks.last["callback_method"]
-  end
-
-  def test_observer_update_on_save
-    ActiveRecord::Base.observers = TopicManualObserver
-    ActiveRecord::Base.instantiate_observers
-
-    topic = Topic.find(1)
-    assert TopicManualObserver.instance.has_been_notified?
-    assert_equal :after_find, TopicManualObserver.instance.callbacks.first["callback_method"]
-  end
-
-  def test_auto_observer
-    topic_observer = TopicaAuditor.instance
-    assert_nil TopicaAuditor.observed_class
-    assert_equal [Topic], TopicaAuditor.instance.observed_classes.to_a
-
-    topic = Topic.find(1)
-    assert_equal topic.title, topic_observer.topic.title
-  end
-
-  def test_inferred_auto_observer
-    topic_observer = TopicObserver.instance
-    assert_equal Topic, TopicObserver.observed_class
-
-    topic = Topic.find(1)
-    assert_equal topic.title, topic_observer.topic.title
-  end
-
-  def test_observing_two_classes
-    multi_observer = MultiObserver.instance
-
-    topic = Topic.find(1)
-    assert_equal topic.title, multi_observer.record.title
-
-    developer = Developer.find(1)
-    assert_equal developer.name, multi_observer.record.name
-  end
-
-  def test_observing_subclasses
-    multi_observer = MultiObserver.instance
-
-    developer = SpecialDeveloper.find(1)
-    assert_equal developer.name, multi_observer.record.name
-
-    klass = Class.new(Developer)
-    assert_equal klass, multi_observer.last_inherited
-
-    developer = klass.find(1)
-    assert_equal developer.name, multi_observer.record.name
-  end
-
-  def test_after_find_can_be_observed_when_its_not_defined_on_the_model
-    observer = MinimalisticObserver.instance
-    assert_equal Minimalistic, MinimalisticObserver.observed_class
-
-    minimalistic = Minimalistic.find(1)
-    assert_equal minimalistic, observer.minimalistic
-  end
-
-  def test_after_find_can_be_observed_when_its_defined_on_the_model
-    observer = TopicObserver.instance
-    assert_equal Topic, TopicObserver.observed_class
-
-    topic = Topic.find(1)
-    assert_equal topic, observer.topic
-  end
-
-  def test_after_find_is_not_created_if_its_not_used
-    # use a fresh class so an observer can't have defined an
-    # after_find on it
-    model_class = Class.new(ActiveRecord::Base)
-    observer_class = Class.new(ActiveRecord::Observer)
-    observer_class.observe(model_class)
-
-    observer = observer_class.instance
-
-    assert !model_class.method_defined?(:after_find)
-  end
-
-  def test_after_find_is_not_clobbered_if_it_already_exists
-    # use a fresh observer class so we can instantiate it (Observer is
-    # a Singleton)
-    model_class = Class.new(ActiveRecord::Base) do
-      def after_find; end
-    end
-    original_method = model_class.instance_method(:after_find)
-    observer_class = Class.new(ActiveRecord::Observer) do
-      def after_find; end
-    end
-    observer_class.observe(model_class)
-
-    observer = observer_class.instance
-    assert_equal original_method, model_class.instance_method(:after_find)
-  end
-
-  def test_invalid_observer
-    assert_raise(ArgumentError) { Topic.observers = Object.new; Topic.instantiate_observers }
-  end
-end

data/test/cases/locking_test.rb

@@ -1,350 +0,0 @@
-require "cases/helper"
-require 'models/person'
-require 'models/reader'
-require 'models/legacy_thing'
-require 'models/reference'
-
-class LockWithoutDefault < ActiveRecord::Base; end
-
-class LockWithCustomColumnWithoutDefault < ActiveRecord::Base
-  set_table_name :lock_without_defaults_cust
-  set_locking_column :custom_lock_version
-end
-
-class ReadonlyFirstNamePerson < Person
-  attr_readonly :first_name
-end
-
-class OptimisticLockingTest < ActiveRecord::TestCase
-  fixtures :people, :legacy_things, :references
-
-  # need to disable transactional fixtures, because otherwise the sqlite3
-  # adapter (at least) chokes when we try and change the schema in the middle
-  # of a test (see test_increment_counter_*).
-  self.use_transactional_fixtures = false
-
-  def test_lock_existing
-    p1 = Person.find(1)
-    p2 = Person.find(1)
-    assert_equal 0, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    p1.first_name = 'stu'
-    p1.save!
-    assert_equal 1, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    p2.first_name = 'sue'
-    assert_raise(ActiveRecord::StaleObjectError) { p2.save! }
-  end
-
-  # See Lighthouse ticket #1966
-  def test_lock_destroy
-    p1 = Person.find(1)
-    p2 = Person.find(1)
-    assert_equal 0, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    p1.first_name = 'stu'
-    p1.save!
-    assert_equal 1, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    assert_raises(ActiveRecord::StaleObjectError) { p2.destroy }
-
-    assert p1.destroy
-    assert p1.frozen?
-    assert p1.destroyed?
-    assert_raises(ActiveRecord::RecordNotFound) { Person.find(1) }
-  end
-
-  def test_lock_repeating
-    p1 = Person.find(1)
-    p2 = Person.find(1)
-    assert_equal 0, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    p1.first_name = 'stu'
-    p1.save!
-    assert_equal 1, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    p2.first_name = 'sue'
-    assert_raise(ActiveRecord::StaleObjectError) { p2.save! }
-    p2.first_name = 'sue2'
-    assert_raise(ActiveRecord::StaleObjectError) { p2.save! }
-  end
-
-  def test_lock_new
-    p1 = Person.new(:first_name => 'anika')
-    assert_equal 0, p1.lock_version
-
-    p1.first_name = 'anika2'
-    p1.save!
-    p2 = Person.find(p1.id)
-    assert_equal 0, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    p1.first_name = 'anika3'
-    p1.save!
-    assert_equal 1, p1.lock_version
-    assert_equal 0, p2.lock_version
-
-    p2.first_name = 'sue'
-    assert_raise(ActiveRecord::StaleObjectError) { p2.save! }
-  end
-
-  def test_lock_new_with_nil
-    p1 = Person.new(:first_name => 'anika')
-    p1.save!
-    p1.lock_version = nil # simulate bad fixture or column with no default
-    p1.save!
-    assert_equal 1, p1.lock_version
-  end
-
-
-  def test_lock_column_name_existing
-    t1 = LegacyThing.find(1)
-    t2 = LegacyThing.find(1)
-    assert_equal 0, t1.version
-    assert_equal 0, t2.version
-
-    t1.tps_report_number = 700
-    t1.save!
-    assert_equal 1, t1.version
-    assert_equal 0, t2.version
-
-    t2.tps_report_number = 800
-    assert_raise(ActiveRecord::StaleObjectError) { t2.save! }
-  end
-
-  def test_lock_column_is_mass_assignable
-    p1 = Person.create(:first_name => 'bianca')
-    assert_equal 0, p1.lock_version
-    assert_equal p1.lock_version, Person.new(p1.attributes).lock_version
-
-    p1.first_name = 'bianca2'
-    p1.save!
-    assert_equal 1, p1.lock_version
-    assert_equal p1.lock_version, Person.new(p1.attributes).lock_version
-  end
-
-  def test_lock_without_default_sets_version_to_zero
-    t1 = LockWithoutDefault.new
-    assert_equal 0, t1.lock_version
-  end
-
-  def test_lock_with_custom_column_without_default_sets_version_to_zero
-    t1 = LockWithCustomColumnWithoutDefault.new
-    assert_equal 0, t1.custom_lock_version
-  end
-
-  def test_readonly_attributes
-    assert_equal Set.new([ 'first_name' ]), ReadonlyFirstNamePerson.readonly_attributes
-
-    p = ReadonlyFirstNamePerson.create(:first_name => "unchangeable name")
-    p.reload
-    assert_equal "unchangeable name", p.first_name
-
-    p.update_attributes(:first_name => "changed name")
-    p.reload
-    assert_equal "unchangeable name", p.first_name
-  end
-
-  { :lock_version => Person, :custom_lock_version => LegacyThing }.each do |name, model|
-    define_method("test_increment_counter_updates_#{name}") do
-      counter_test model, 1 do |id|
-        model.increment_counter :test_count, id
-      end
-    end
-
-    define_method("test_decrement_counter_updates_#{name}") do
-      counter_test model, -1 do |id|
-        model.decrement_counter :test_count, id
-      end
-    end
-
-    define_method("test_update_counters_updates_#{name}") do
-      counter_test model, 1 do |id|
-        model.update_counters id, :test_count => 1
-      end
-    end
-  end
-
-  # See Lighthouse ticket #1966
-  def test_destroy_dependents
-    # Establish dependent relationship between People and LegacyThing
-    add_counter_column_to(Person, 'legacy_things_count')
-    LegacyThing.connection.add_column LegacyThing.table_name, 'person_id', :integer
-    LegacyThing.reset_column_information
-    LegacyThing.class_eval do
-      belongs_to :person, :counter_cache => true
-    end
-    Person.class_eval do
-      has_many :legacy_things, :dependent => :destroy
-    end
-
-    # Make sure that counter incrementing doesn't cause problems
-    p1 = Person.new(:first_name => 'fjord')
-    p1.save!
-    t = LegacyThing.new(:person => p1)
-    t.save!
-    p1.reload
-    assert_equal 1, p1.legacy_things_count
-    assert p1.destroy
-    assert_equal true, p1.frozen?
-    assert_raises(ActiveRecord::RecordNotFound) { Person.find(p1.id) }
-    assert_raises(ActiveRecord::RecordNotFound) { LegacyThing.find(t.id) }
-  end
-  
-  def test_quote_table_name
-    ref = references(:michael_magician)
-    ref.favourite = !ref.favourite
-    assert ref.save
-  end
-
-  # Useful for partial updates, don't only update the lock_version if there
-  # is nothing else being updated.
-  def test_update_without_attributes_does_not_only_update_lock_version
-    assert_nothing_raised do
-      p1 = Person.new(:first_name => 'anika')
-      p1.send(:update_with_lock, [])
-    end
-  end
-
-  private
-
-    def add_counter_column_to(model, col='test_count')
-      model.connection.add_column model.table_name, col, :integer, :null => false, :default => 0
-      model.reset_column_information
-      # OpenBase does not set a value to existing rows when adding a not null default column
-      model.update_all(col => 0) if current_adapter?(:OpenBaseAdapter)
-    end
-
-    def remove_counter_column_from(model)
-      model.connection.remove_column model.table_name, :test_count
-      model.reset_column_information
-    end
-
-    def counter_test(model, expected_count)
-      add_counter_column_to(model)
-      object = model.find(:first)
-      assert_equal 0, object.test_count
-      assert_equal 0, object.send(model.locking_column)
-      yield object.id
-      object.reload
-      assert_equal expected_count, object.test_count
-      assert_equal 1, object.send(model.locking_column)
-    ensure
-      remove_counter_column_from(model)
-    end
-end
-
-
-# TODO: test against the generated SQL since testing locking behavior itself
-# is so cumbersome. Will deadlock Ruby threads if the underlying db.execute
-# blocks, so separate script called by Kernel#system is needed.
-# (See exec vs. async_exec in the PostgreSQL adapter.)
-
-# TODO: The Sybase, and OpenBase adapters currently have no support for pessimistic locking
-
-unless current_adapter?(:SybaseAdapter, :OpenBaseAdapter)
-  class PessimisticLockingTest < ActiveRecord::TestCase
-    self.use_transactional_fixtures = false
-    fixtures :people, :readers
-
-    def setup
-      # Avoid introspection queries during tests.
-      Person.columns; Reader.columns
-    end
-
-    # Test typical find.
-    def test_sane_find_with_lock
-      assert_nothing_raised do
-        Person.transaction do
-          Person.find 1, :lock => true
-        end
-      end
-    end
-
-    # Test scoped lock.
-    def test_sane_find_with_scoped_lock
-      assert_nothing_raised do
-        Person.transaction do
-          Person.with_scope(:find => { :lock => true }) do
-            Person.find 1
-          end
-        end
-      end
-    end
-
-    # PostgreSQL protests SELECT ... FOR UPDATE on an outer join.
-    unless current_adapter?(:PostgreSQLAdapter)
-      # Test locked eager find.
-      def test_eager_find_with_lock
-        assert_nothing_raised do
-          Person.transaction do
-            Person.find 1, :include => :readers, :lock => true
-          end
-        end
-      end
-    end
-
-    # Locking a record reloads it.
-    def test_sane_lock_method
-      assert_nothing_raised do
-        Person.transaction do
-          person = Person.find 1
-          old, person.first_name = person.first_name, 'fooman'
-          person.lock!
-          assert_equal old, person.first_name
-        end
-      end
-    end
-
-    if current_adapter?(:PostgreSQLAdapter, :OracleAdapter)
-      use_concurrent_connections
-
-      def test_no_locks_no_wait
-        first, second = duel { Person.find 1 }
-        assert first.end > second.end
-      end
-
-      def test_second_lock_waits
-        assert [0.2, 1, 5].any? { |zzz|
-          first, second = duel(zzz) { Person.find 1, :lock => true }
-          second.end > first.end
-        }
-      end
-
-      protected
-        def duel(zzz = 5)
-          t0, t1, t2, t3 = nil, nil, nil, nil
-
-          a = Thread.new do
-            t0 = Time.now
-            Person.transaction do
-              yield
-              sleep zzz       # block thread 2 for zzz seconds
-            end
-            t1 = Time.now
-          end
-
-          b = Thread.new do
-            sleep zzz / 2.0   # ensure thread 1 tx starts first
-            t2 = Time.now
-            Person.transaction { yield }
-            t3 = Time.now
-          end
-
-          a.join
-          b.join
-
-          assert t1 > t0 + zzz
-          assert t2 > t0
-          assert t3 > t2
-          [t0.to_f..t1.to_f, t2.to_f..t3.to_f]
-        end
-    end
-  end
-end