activerecord-sqlserver-adapter 5.2.1 → 6.0.0

data/lib/active_record/connection_adapters/sqlserver/type/smalldatetime.rb

@@ -1,15 +1,16 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class SmallDateTime < DateTime
-
           def type
             :smalldatetime
           end
 
           def sqlserver_type
-            'smalldatetime'.freeze
+            "smalldatetime"
           end
 
           private
@@ -21,7 +22,6 @@ module ActiveRecord
           def apply_seconds_precision(value)
             value.change usec: 0 if value
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/string.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class String < ActiveRecord::Type::String
-
           def changed_in_place?(raw_old_value, new_value)
             if raw_old_value.is_a?(Data)
               raw_old_value.value != new_value
@@ -11,7 +12,6 @@ module ActiveRecord
               super
             end
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/text.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Text < VarcharMax
-
           def type
             :text_basic
           end
 
           def sqlserver_type
-            'text'.freeze
+            "text"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/time.rb

@@ -1,18 +1,18 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Time < ActiveRecord::Type::Time
-
           include TimeValueFractional2
 
           def serialize(value)
             value = super
             return value unless value.acts_like?(:time)
-            time = value.to_s(:_sqlserver_time).tap do |v|
-              fraction = quote_fractional(value)
-              v << ".#{fraction}"
-            end
+
+            time = "#{value.to_s(:_sqlserver_time)}.#{quote_fractional(value)}"
+
             Data.new time, self
           end
 
@@ -37,6 +37,7 @@ module ActiveRecord
           def cast_value(value)
             value = super
             return if value.blank?
+
             value = value.change year: 2000, month: 01, day: 01
             apply_seconds_precision(value)
           end
@@ -44,7 +45,6 @@ module ActiveRecord
           def fractional_scale
             precision
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/time_value_fractional.rb

@@ -1,19 +1,21 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
-
         module TimeValueFractional
-
           private
 
           def apply_seconds_precision(value)
             return value if !value.respond_to?(fractional_property) || value.send(fractional_property).zero?
+
             value.change fractional_property => seconds_precision(value)
           end
 
           def seconds_precision(value)
             return 0 if fractional_scale == 0
+
             seconds = value.send(fractional_property).to_f / fractional_operator.to_f
             seconds = ((seconds * (1 / fractional_precision)).round / (1 / fractional_precision)).round(fractional_scale)
             (seconds * fractional_operator).round(0).to_i
@@ -21,9 +23,10 @@ module ActiveRecord
 
           def quote_fractional(value)
             return 0 if fractional_scale == 0
+
             frac_seconds = seconds_precision(value)
             seconds = (frac_seconds.to_f / fractional_operator.to_f).round(fractional_scale)
-            seconds.to_d.to_s.split('.').last.to(fractional_scale-1)
+            seconds.to_d.to_s.split(".").last.to(fractional_scale - 1)
           end
 
           def fractional_property
@@ -35,7 +38,7 @@ module ActiveRecord
           end
 
           def fractional_operator
-            10 ** fractional_digits
+            10**fractional_digits
           end
 
           def fractional_precision
@@ -45,11 +48,9 @@ module ActiveRecord
           def fractional_scale
             3
           end
-
         end
 
         module TimeValueFractional2
-
           include TimeValueFractional
 
           private
@@ -80,11 +81,9 @@ module ActiveRecord
           end
 
           def fractional_scale_max
-            ('9' * fractional_scale) + ('0' * (fractional_digits - fractional_scale))
+            ("9" * fractional_scale) + ("0" * (fractional_digits - fractional_scale))
           end
-
         end
-
       end
     end
   end

data/lib/active_record/connection_adapters/sqlserver/type/timestamp.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Timestamp < Binary
-
           def type
             :ss_timestamp
           end
 
           def sqlserver_type
-            'timestamp'.freeze
+            "timestamp"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/tiny_integer.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class TinyInteger < Integer
-
           def sqlserver_type
-            'tinyint'.freeze
+            "tinyint"
           end
 
           private
@@ -17,7 +18,6 @@ module ActiveRecord
           def min_value
             0
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/unicode_char.rb

@@ -1,19 +1,20 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class UnicodeChar < UnicodeString
-
           def type
             :nchar
           end
 
           def sqlserver_type
-            'nchar'.tap do |type|
-              type << "(#{limit})" if limit
+            "nchar".yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/unicode_string.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class UnicodeString < String
-
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/unicode_text.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class UnicodeText < UnicodeVarcharMax
-
           def type
             :ntext
           end
 
           def sqlserver_type
-            'ntext'.freeze
+            "ntext"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/unicode_varchar.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class UnicodeVarchar < UnicodeChar
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 4000 if @limit.to_i == 0
           end
@@ -14,11 +15,11 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'nvarchar'.tap do |type|
-              type << "(#{limit})" if limit
+            "nvarchar".yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/unicode_varchar_max.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class UnicodeVarcharMax < UnicodeVarchar
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 2_147_483_647
           end
@@ -14,9 +15,8 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'nvarchar(max)'.freeze
+            "nvarchar(max)"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/uuid.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Uuid < String
-
           ACCEPTABLE_UUID = %r{\A\{?([a-fA-F0-9]{4}-?){8}\}?\z}x
 
           alias_method :serialize, :deserialize
@@ -13,11 +14,12 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'uniqueidentifier'.freeze
+            "uniqueidentifier"
           end
 
           def serialize(value)
             return unless value
+
             Data.new super, self
           end
 
@@ -28,7 +30,6 @@ module ActiveRecord
           def quoted(value)
             Utils.quote_string_single(value) if value
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/varbinary.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Varbinary < Binary
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 8000 if @limit.to_i == 0
           end
@@ -14,11 +15,11 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'varbinary'.tap do |type|
-              type << "(#{limit})" if limit
+            "varbinary".yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/varbinary_max.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class VarbinaryMax < Varbinary
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 2_147_483_647
           end
@@ -14,9 +15,8 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'varbinary(max)'.freeze
+            "varbinary(max)"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/varchar.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Varchar < Char
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 8000 if @limit.to_i == 0
           end
@@ -14,11 +15,11 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'varchar'.tap do |type|
-              type << "(#{limit})" if limit
+            "varchar".yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type/varchar_max.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class VarcharMax < Varchar
-
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 2_147_483_647
           end
@@ -14,9 +15,8 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'varchar(max)'.freeze
+            "varchar(max)"
           end
-
         end
       end
     end

data/lib/active_record/connection_adapters/sqlserver/type.rb

@@ -1,46 +1,48 @@
-require 'active_record/type'
+# frozen_string_literal: true
+
+require "active_record/type"
 # Behaviors
-require 'active_record/connection_adapters/sqlserver/type/data'
-require 'active_record/connection_adapters/sqlserver/type/time_value_fractional'
+require "active_record/connection_adapters/sqlserver/type/data"
+require "active_record/connection_adapters/sqlserver/type/time_value_fractional"
 # Exact Numerics
-require 'active_record/connection_adapters/sqlserver/type/integer'
-require 'active_record/connection_adapters/sqlserver/type/big_integer'
-require 'active_record/connection_adapters/sqlserver/type/small_integer'
-require 'active_record/connection_adapters/sqlserver/type/tiny_integer'
-require 'active_record/connection_adapters/sqlserver/type/boolean'
-require 'active_record/connection_adapters/sqlserver/type/decimal'
-require 'active_record/connection_adapters/sqlserver/type/money'
-require 'active_record/connection_adapters/sqlserver/type/small_money'
+require "active_record/connection_adapters/sqlserver/type/integer"
+require "active_record/connection_adapters/sqlserver/type/big_integer"
+require "active_record/connection_adapters/sqlserver/type/small_integer"
+require "active_record/connection_adapters/sqlserver/type/tiny_integer"
+require "active_record/connection_adapters/sqlserver/type/boolean"
+require "active_record/connection_adapters/sqlserver/type/decimal"
+require "active_record/connection_adapters/sqlserver/type/money"
+require "active_record/connection_adapters/sqlserver/type/small_money"
 # Approximate Numerics
-require 'active_record/connection_adapters/sqlserver/type/float'
-require 'active_record/connection_adapters/sqlserver/type/real'
+require "active_record/connection_adapters/sqlserver/type/float"
+require "active_record/connection_adapters/sqlserver/type/real"
 # Date and Time
-require 'active_record/connection_adapters/sqlserver/type/date'
-require 'active_record/connection_adapters/sqlserver/type/datetime'
-require 'active_record/connection_adapters/sqlserver/type/datetime2'
-require 'active_record/connection_adapters/sqlserver/type/datetimeoffset'
-require 'active_record/connection_adapters/sqlserver/type/smalldatetime'
-require 'active_record/connection_adapters/sqlserver/type/time'
+require "active_record/connection_adapters/sqlserver/type/date"
+require "active_record/connection_adapters/sqlserver/type/datetime"
+require "active_record/connection_adapters/sqlserver/type/datetime2"
+require "active_record/connection_adapters/sqlserver/type/datetimeoffset"
+require "active_record/connection_adapters/sqlserver/type/smalldatetime"
+require "active_record/connection_adapters/sqlserver/type/time"
 # Character Strings
-require 'active_record/connection_adapters/sqlserver/type/string'
-require 'active_record/connection_adapters/sqlserver/type/char'
-require 'active_record/connection_adapters/sqlserver/type/varchar'
-require 'active_record/connection_adapters/sqlserver/type/varchar_max'
-require 'active_record/connection_adapters/sqlserver/type/text'
+require "active_record/connection_adapters/sqlserver/type/string"
+require "active_record/connection_adapters/sqlserver/type/char"
+require "active_record/connection_adapters/sqlserver/type/varchar"
+require "active_record/connection_adapters/sqlserver/type/varchar_max"
+require "active_record/connection_adapters/sqlserver/type/text"
 # Unicode Character Strings
-require 'active_record/connection_adapters/sqlserver/type/unicode_string'
-require 'active_record/connection_adapters/sqlserver/type/unicode_char'
-require 'active_record/connection_adapters/sqlserver/type/unicode_varchar'
-require 'active_record/connection_adapters/sqlserver/type/unicode_varchar_max'
-require 'active_record/connection_adapters/sqlserver/type/unicode_text'
+require "active_record/connection_adapters/sqlserver/type/unicode_string"
+require "active_record/connection_adapters/sqlserver/type/unicode_char"
+require "active_record/connection_adapters/sqlserver/type/unicode_varchar"
+require "active_record/connection_adapters/sqlserver/type/unicode_varchar_max"
+require "active_record/connection_adapters/sqlserver/type/unicode_text"
 # Binary Strings
-require 'active_record/connection_adapters/sqlserver/type/binary'
-require 'active_record/connection_adapters/sqlserver/type/varbinary'
-require 'active_record/connection_adapters/sqlserver/type/varbinary_max'
+require "active_record/connection_adapters/sqlserver/type/binary"
+require "active_record/connection_adapters/sqlserver/type/varbinary"
+require "active_record/connection_adapters/sqlserver/type/varbinary_max"
 # Other Data Types
-require 'active_record/connection_adapters/sqlserver/type/uuid'
-require 'active_record/connection_adapters/sqlserver/type/timestamp'
-require 'active_record/connection_adapters/sqlserver/type/json'
+require "active_record/connection_adapters/sqlserver/type/uuid"
+require "active_record/connection_adapters/sqlserver/type/timestamp"
+require "active_record/connection_adapters/sqlserver/type/json"
 
 module ActiveRecord
   module Type

data/lib/active_record/connection_adapters/sqlserver/utils.rb

@@ -1,17 +1,17 @@
-require 'strscan'
+# frozen_string_literal: true
+
+require "strscan"
 
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Utils
-
-        QUOTED_STRING_PREFIX = 'N'
+        QUOTED_STRING_PREFIX = "N"
 
         # Value object to return identifiers from SQL Server names http://bit.ly/1CZ3EiL
         # Inspiried from Rails PostgreSQL::Name adapter object in their own Utils.
         #
         class Name
-
           SEPARATOR = "."
           UNQUOTED_SCANNER = /\]?\./
           QUOTED_SCANNER   = /\A\[.*?\]\./
@@ -54,15 +54,15 @@ module ActiveRecord
           end
 
           def quoted
-            parts.map{ |p| quote(p) if p }.join SEPARATOR
+            parts.map { |p| quote(p) if p }.join SEPARATOR
           end
 
           def quoted_raw
             quote @raw_name
           end
 
-          def ==(o)
-            o.class == self.class && o.parts == parts
+          def ==(other)
+            other.class == self.class && other.parts == parts
           end
           alias_method :eql?, :==
 
@@ -75,6 +75,7 @@ module ActiveRecord
           def parse_raw_name
             @parts = []
             return if raw_name.blank?
+
             scanner = StringScanner.new(raw_name)
             matched = scanner.exist?(QUOTED_CHECKER) ? scanner.scan_until(QUOTED_SCANNER) : scanner.scan_until(UNQUOTED_SCANNER)
             while matched
@@ -91,7 +92,7 @@ module ActiveRecord
               @schema = @parts.first
             end
             rest = scanner.rest
-            rest = rest.starts_with?('.') ? rest[1..-1] : rest[0..-1]
+            rest = rest.starts_with?(".") ? rest[1..-1] : rest[0..-1]
             @object = unquote(rest)
             @parts << @object
           end
@@ -101,7 +102,7 @@ module ActiveRecord
           end
 
           def unquote(part)
-            if part && part.start_with?('[')
+            if part && part.start_with?("[")
               part[1..-2]
             else
               part
@@ -111,7 +112,6 @@ module ActiveRecord
           def parts
             @parts
           end
-
         end
 
         extend self
@@ -139,7 +139,6 @@ module ActiveRecord
         def extract_identifiers(name)
           SQLServer::Utils::Name.new(name)
         end
-
       end
     end
   end

data/lib/active_record/connection_adapters/sqlserver/version.rb

@@ -1,10 +1,10 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Version
-
         VERSION = File.read(File.expand_path("../../../../../VERSION", __FILE__)).chomp
-
       end
     end
   end