activerecord-sqlserver-adapter 5.2.1 → 6.0.0

data/test/debug.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 # require 'rails/all'
-require 'tiny_tds'
+require "tiny_tds"
 
 c = TinyTds::Client.new(
-  host: ENV['CI_AZURE_HOST'],
-  username: 'rails',
-  password: ENV['CI_AZURE_PASS'],
-  database: 'activerecord_unittest',
+  host: ENV["CI_AZURE_HOST"],
+  username: "rails",
+  password: ENV["CI_AZURE_PASS"],
+  database: "activerecord_unittest",
   azure: true,
-  tds_version: '7.3'
+  tds_version: "7.3"
 )
 
 puts c.execute("SELECT 1 AS [one]").each

data/test/migrations/create_clients_and_change_column_null.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateClientsAndChangeColumnNull < ActiveRecord::Migration[5.2]
   def up
     create_table :clients do |t|
@@ -9,7 +11,7 @@ class CreateClientsAndChangeColumnNull < ActiveRecord::Migration[5.2]
     end
 
     change_column :clients, :name, :string, limit: 15
-    change_column :clients, :code, :string, default: 'n/a'
+    change_column :clients, :code, :string, default: "n/a"
     change_column :clients, :value, :decimal, precision: 32, scale: 8
 
     change_column_null :clients, :name, false

data/test/migrations/transaction_table/1_table_will_never_be_created.rb

@@ -1,11 +1,11 @@
-class TableWillNeverBeCreated < ActiveRecord::Migration
+# frozen_string_literal: true
 
+class TableWillNeverBeCreated < ActiveRecord::Migration
   def self.up
-    create_table(:sqlserver_trans_table1) {  }
-    create_table(:sqlserver_trans_table2) { raise('HELL') }
+    create_table(:sqlserver_trans_table1) {}
+    create_table(:sqlserver_trans_table2) { raise("HELL") }
   end
 
   def self.down
   end
-
 end

data/test/models/sqlserver/booking.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestBooking < ActiveRecord::Base
-  self.table_name = 'sst_bookings'
+  self.table_name = "sst_bookings"
 end

data/test/models/sqlserver/customers_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestCustomersView < ActiveRecord::Base
-  self.table_name = 'sst_customers_view'
+  self.table_name = "sst_customers_view"
 end

data/test/models/sqlserver/datatype.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDatatype < ActiveRecord::Base
   self.table_name = :sst_datatypes
 end

data/test/models/sqlserver/datatype_migration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDatatypeMigration < ActiveRecord::Base
   self.table_name = :sst_datatypes_migration
 end

data/test/models/sqlserver/dollar_table_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDollarTableName < ActiveRecord::Base
-  self.table_name = 'sst_my$strange_table'
+  self.table_name = "sst_my$strange_table"
 end

data/test/models/sqlserver/edge_schema.rb

@@ -1,6 +1,7 @@
-class SSTestEdgeSchema < ActiveRecord::Base
+# frozen_string_literal: true
 
-  self.table_name = 'sst_edge_schemas'
+class SSTestEdgeSchema < ActiveRecord::Base
+  self.table_name = "sst_edge_schemas"
 
   def with_spaces
     read_attribute :'with spaces'
@@ -9,5 +10,4 @@ class SSTestEdgeSchema < ActiveRecord::Base
   def with_spaces=(value)
     write_attribute :'with spaces', value
   end
-
 end

data/test/models/sqlserver/fk_has_fk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestHasFk < ActiveRecord::Base
-  self.table_name = 'sst_has_fks'
+  self.table_name = "sst_has_fks"
 end

data/test/models/sqlserver/fk_has_pk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestHasPk < ActiveRecord::Base
-  self.table_name = 'sst_has_pks'
+  self.table_name = "sst_has_pks"
 end

data/test/models/sqlserver/natural_pk_data.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 class SSTestNaturalPkData < ActiveRecord::Base
-  self.table_name = 'sst_natural_pk_data'
-  self.primary_key = 'legacy_id'
+  self.table_name = "sst_natural_pk_data"
+  self.primary_key = "legacy_id"
 end

data/test/models/sqlserver/natural_pk_int_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNaturalPkIntData < ActiveRecord::Base
-  self.table_name = 'sst_natural_pk_int_data'
+  self.table_name = "sst_natural_pk_int_data"
 end

data/test/models/sqlserver/no_pk_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNoPkData < ActiveRecord::Base
-  self.table_name = 'sst_no_pk_data'
+  self.table_name = "sst_no_pk_data"
 end

data/test/models/sqlserver/object_default.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestObjectDefault < ActiveRecord::Base
-  self.table_name = 'sst_defaultobjects'
+  self.table_name = "sst_defaultobjects"
 end

data/test/models/sqlserver/quoted_table.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 class SSTestQuotedTable < ActiveRecord::Base
-  self.table_name = '[sst_quoted-table]'
+  self.table_name = "[sst_quoted-table]"
 end
 
 class SSTestQuotedTableUser < ActiveRecord::Base
-  self.table_name = '[dbo].[sst_quoted-table]'
+  self.table_name = "[dbo].[sst_quoted-table]"
 end

data/test/models/sqlserver/quoted_view_1.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedView1 < ActiveRecord::Base
-  self.table_name = 'sst_quoted-view1'
+  self.table_name = "sst_quoted-view1"
 end

data/test/models/sqlserver/quoted_view_2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedView2 < ActiveRecord::Base
-  self.table_name = 'sst_quoted-view2'
+  self.table_name = "sst_quoted-view2"
 end

data/test/models/sqlserver/sst_memory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTMemory < ActiveRecord::Base
-  self.table_name = 'sst_memory'
+  self.table_name = "sst_memory"
 end

data/test/models/sqlserver/string_default.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefault < ActiveRecord::Base
-  self.table_name = 'sst_string_defaults'
+  self.table_name = "sst_string_defaults"
 end

data/test/models/sqlserver/string_defaults_big_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefaultsBigView < ActiveRecord::Base
-  self.table_name = 'sst_string_defaults_big_view'
+  self.table_name = "sst_string_defaults_big_view"
 end

data/test/models/sqlserver/string_defaults_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefaultsView < ActiveRecord::Base
-  self.table_name = 'sst_string_defaults_view'
+  self.table_name = "sst_string_defaults_view"
 end

data/test/models/sqlserver/tinyint_pk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTinyintPk < ActiveRecord::Base
-  self.table_name = 'sst_tinyint_pk'
+  self.table_name = "sst_tinyint_pk"
 end

data/test/models/sqlserver/trigger.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 class SSTestTrigger < ActiveRecord::Base
-  self.table_name = 'sst_table_with_trigger'
+  self.table_name = "sst_table_with_trigger"
 end
 
 class SSTestTriggerUuid < ActiveRecord::Base
-  self.table_name = 'sst_table_with_uuid_trigger'
+  self.table_name = "sst_table_with_uuid_trigger"
 end

data/test/models/sqlserver/trigger_history.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTriggerHistory < ActiveRecord::Base
-  self.table_name = 'sst_table_with_trigger_history'
+  self.table_name = "sst_table_with_trigger_history"
 end

data/test/models/sqlserver/upper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUpper < ActiveRecord::Base
-  self.table_name = 'sst_upper_tests'
+  self.table_name = "sst_upper_tests"
 end

data/test/models/sqlserver/uppered.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUppered < ActiveRecord::Base
-  self.table_name = 'SST_UPPER_TESTS'
+  self.table_name = "SST_UPPER_TESTS"
 end

data/test/models/sqlserver/uuid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUuid < ActiveRecord::Base
-  self.table_name = 'sst_uuids'
+  self.table_name = "sst_uuids"
 end

data/test/schema/sqlserver_specific_schema.rb

@@ -1,5 +1,6 @@
-ActiveRecord::Schema.define do
+# frozen_string_literal: true
 
+ActiveRecord::Schema.define do
   # Exhaustive Data Types
 
   execute File.read(ARTest::SQLServer.schema_datatypes_2012_file)
@@ -43,28 +44,28 @@ ActiveRecord::Schema.define do
 
   # Edge Cases
 
-  if ENV['IN_MEMORY_OLTP'] && supports_in_memory_oltp?
-    create_table 'sst_memory', force: true, id: false,
-                 options: 'WITH (MEMORY_OPTIMIZED = ON, DURABILITY = SCHEMA_AND_DATA)' do |t|
+  if ENV["IN_MEMORY_OLTP"] && supports_in_memory_oltp?
+    create_table "sst_memory", force: true, id: false,
+                               options: "WITH (MEMORY_OPTIMIZED = ON, DURABILITY = SCHEMA_AND_DATA)" do |t|
       t.primary_key_nonclustered :id
       t.string :name
       t.timestamps
     end
   end
 
-  create_table 'sst_bookings', force: true do |t|
+  create_table "sst_bookings", force: true do |t|
     t.string :name
     t.datetime2 :created_at, null: false
     t.datetime2 :updated_at, null: false
   end
 
-  create_table 'sst_uuids', force: true, id: :uuid do |t|
+  create_table "sst_uuids", force: true, id: :uuid do |t|
     t.string :name
-    t.uuid   :other_uuid, default: 'NEWID()'
+    t.uuid   :other_uuid, default: "NEWID()"
     t.uuid   :uuid_nil_default, default: nil
   end
 
-  create_table 'sst_my$strange_table', force: true do |t|
+  create_table "sst_my$strange_table", force: true do |t|
     t.string :name
   end
 
@@ -77,27 +78,27 @@ ActiveRecord::Schema.define do
     t.string :name
   end
 
-  create_table 'sst_quoted-table', force: true do |t|
+  create_table "sst_quoted-table", force: true do |t|
   end
   execute "IF EXISTS (SELECT TABLE_NAME FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = 'sst_quoted-view1') DROP VIEW [sst_quoted-view1]"
   execute "CREATE VIEW [sst_quoted-view1] AS SELECT * FROM [sst_quoted-table]"
   execute "IF EXISTS (SELECT TABLE_NAME FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = 'sst_quoted-view2') DROP VIEW [sst_quoted-view2]"
-  execute "CREATE VIEW [sst_quoted-view2] AS \n /*#{'x'*4000}}*/ \n SELECT * FROM [sst_quoted-table]"
+  execute "CREATE VIEW [sst_quoted-view2] AS \n /*#{'x' * 4000}}*/ \n SELECT * FROM [sst_quoted-table]"
 
   create_table :sst_string_defaults, force: true do |t|
     t.column :string_with_null_default, :string, default: nil
-    t.column :string_with_pretend_null_one, :string, default: 'null'
-    t.column :string_with_pretend_null_two, :string, default: '(null)'
-    t.column :string_with_pretend_null_three, :string, default: 'NULL'
-    t.column :string_with_pretend_null_four, :string, default: '(NULL)'
-    t.column :string_with_pretend_paren_three, :string, default: '(3)'
+    t.column :string_with_pretend_null_one, :string, default: "null"
+    t.column :string_with_pretend_null_two, :string, default: "(null)"
+    t.column :string_with_pretend_null_three, :string, default: "NULL"
+    t.column :string_with_pretend_null_four, :string, default: "(NULL)"
+    t.column :string_with_pretend_paren_three, :string, default: "(3)"
     t.column :string_with_multiline_default, :string, default: "Some long default with a\nnew line."
   end
 
   create_table :sst_edge_schemas, force: true do |t|
     t.string :description
-    t.column 'crazy]]quote', :string
-    t.column 'with spaces', :string
+    t.column "crazy]]quote", :string
+    t.column "with spaces", :string
   end
 
   execute "IF EXISTS(SELECT * FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 'sst_natural_pk_data') DROP TABLE sst_natural_pk_data"
@@ -130,7 +131,7 @@ ActiveRecord::Schema.define do
 
   execute "DROP DEFAULT [sst_getdateobject];" rescue nil
   execute "CREATE DEFAULT [sst_getdateobject] AS getdate();" rescue nil
-  create_table 'sst_defaultobjects', force: true do |t|
+  create_table "sst_defaultobjects", force: true do |t|
     t.string :name
     t.date   :date
   end
@@ -149,7 +150,7 @@ ActiveRecord::Schema.define do
     t.column(:fk_id2, :bigint)
   end
 
-  create_table(:sst_has_pks, force: true) { }
+  create_table(:sst_has_pks, force: true) {}
   execute <<-ADDFKSQL
     ALTER TABLE sst_has_fks
     ADD CONSTRAINT FK__sst_has_fks_id
@@ -181,7 +182,7 @@ ActiveRecord::Schema.define do
   execute <<-STRINGDEFAULTSBIGVIEW
     CREATE VIEW sst_string_defaults_big_view AS
       SELECT id, string_with_pretend_null_one as pretend_null
-      /*#{'x'*4000}}*/
+      /*#{'x' * 4000}}*/
       FROM sst_string_defaults
   STRINGDEFAULTSBIGVIEW
 
@@ -226,7 +227,7 @@ ActiveRecord::Schema.define do
   # Another schema.
 
   create_table :sst_schema_columns, force: true do |t|
-    t.column :field1 , :integer
+    t.column :field1, :integer
   end
 
   execute "IF NOT EXISTS(SELECT * FROM sys.schemas WHERE name = 'test') EXEC sp_executesql N'CREATE SCHEMA test'"
@@ -276,5 +277,4 @@ ActiveRecord::Schema.define do
       field_2 int NOT NULL PRIMARY KEY,
     )
   SCHEMATESTMULTIPLESCHEMA
-
 end

data/test/support/coerceable_test_sqlserver.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
     module CoerceableTest
-
       extend ActiveSupport::Concern
 
       included do
@@ -10,7 +11,6 @@ module ARTest
       end
 
       module ClassMethods
-
         def coerce_tests!(*methods)
           methods.each do |method|
             self.coerced_tests.push(method)
@@ -19,21 +19,29 @@ module ARTest
         end
 
         def coerce_all_tests!
-          once = false
           instance_methods(false).each do |method|
             next unless method.to_s =~ /\Atest/
+
             undef_method(method)
-            once = true
           end
           STDOUT.puts "🙉 🙈 🙊  Undefined all tests: #{self.name}"
         end
 
         private
 
-        def coerced_test_warning(method)
-          method = instance_methods(false).select { |m| m =~ method } if method.is_a?(Regexp)
+        def coerced_test_warning(test_to_coerce)
+          if test_to_coerce.is_a?(Regexp)
+            method = instance_methods(false).select { |m| m =~ test_to_coerce }
+          else
+            method = test_to_coerce
+          end
+
           Array(method).each do |m|
-            result = undef_method(m) if m && method_defined?(m)
+            result = if m && method_defined?(m)
+                       alias_method("original_#{test_to_coerce.inspect.tr('/\:"', '')}", m)
+                       undef_method(m)
+                     end
+
             if result.blank?
               STDOUT.puts "🐳  Unfound coerced test: #{self.name}##{m}"
             else
@@ -41,9 +49,7 @@ module ARTest
             end
           end
         end
-
       end
-
     end
   end
 end

data/test/support/connection_reflection.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
     module ConnectionReflection
-
       extend ActiveSupport::Concern
 
       included { extend ConnectionReflection }
@@ -20,6 +21,7 @@ module ARTest
 
       def connection_dblib_73?
         return false unless connection_dblib?
+
         rc = connection.raw_connection
         rc.respond_to?(:tds_73?) && rc.tds_73?
       end
@@ -27,7 +29,6 @@ module ARTest
       def connection_sqlserver_azure?
         connection.sqlserver_azure?
       end
-
     end
   end
 end

data/test/support/core_ext/query_cache.rb

@@ -1,10 +1,13 @@
-require 'active_record/connection_adapters/sqlserver_adapter'
+# frozen_string_literal: true
+
+require "active_record/connection_adapters/sqlserver_adapter"
 
 module SqlIgnoredCache
   extend ActiveSupport::Concern
 
   IGNORED_SQL = [
     /INFORMATION_SCHEMA\.(TABLES|VIEWS|COLUMNS|KEY_COLUMN_USAGE)/im,
+    /sys.columns/i,
     /SELECT @@version/,
     /SELECT @@TRANCOUNT/,
     /(BEGIN|COMMIT|ROLLBACK|SAVE) TRANSACTION/,

data/test/support/load_schema_sqlserver.rb

@@ -1,18 +1,19 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
-
     extend self
 
     def schema_root
-      File.join ARTest::SQLServer.test_root_sqlserver, 'schema'
+      File.join ARTest::SQLServer.test_root_sqlserver, "schema"
     end
 
     def schema_file
-      File.join schema_root, 'sqlserver_specific_schema.rb'
+      File.join schema_root, "sqlserver_specific_schema.rb"
     end
 
     def schema_datatypes_2012_file
-      File.join schema_root, 'datatypes', '2012.sql'
+      File.join schema_root, "datatypes", "2012.sql"
     end
 
     def load_schema
@@ -22,7 +23,6 @@ module ARTest
     ensure
       $stdout = original_stdout
     end
-
   end
 end
 

data/test/support/minitest_sqlserver.rb

@@ -1 +1,3 @@
-require 'minitest-spec-rails/init/active_support'
+# frozen_string_literal: true
+
+require "minitest-spec-rails/init/active_support"

data/test/support/paths_sqlserver.rb

@@ -1,30 +1,31 @@
+# frozen_string_literal: true
+
 module ARTest
   module SQLServer
-
     extend self
 
     def root_sqlserver
-      File.expand_path File.join(File.dirname(__FILE__), '..', '..')
+      File.expand_path File.join(File.dirname(__FILE__), "..", "..")
     end
 
     def test_root_sqlserver
-      File.join root_sqlserver, 'test'
+      File.join root_sqlserver, "test"
     end
 
     def root_activerecord
-      File.join Gem.loaded_specs['rails'].full_gem_path, 'activerecord'
+      File.join Gem.loaded_specs["rails"].full_gem_path, "activerecord"
     end
 
     def root_activerecord_lib
-      File.join root_activerecord, 'lib'
+      File.join root_activerecord, "lib"
     end
 
     def root_activerecord_test
-      File.join root_activerecord, 'test'
+      File.join root_activerecord, "test"
     end
 
     def test_load_paths
-      ['lib', 'test', root_activerecord_lib, root_activerecord_test]
+      ["lib", "test", root_activerecord_lib, root_activerecord_test]
     end
 
     def add_to_load_paths!
@@ -32,17 +33,16 @@ module ARTest
     end
 
     def migrations_root
-      File.join test_root_sqlserver, 'migrations'
+      File.join test_root_sqlserver, "migrations"
     end
 
     def arconfig_file
-      File.join test_root_sqlserver, 'config.yml'
+      File.join test_root_sqlserver, "config.yml"
     end
 
     def arconfig_file_env!
-      ENV['ARCONFIG'] = arconfig_file
+      ENV["ARCONFIG"] = arconfig_file
     end
-
   end
 end
 

data/test/support/rake_helpers.rb

@@ -1,28 +1,31 @@
+# frozen_string_literal: true
 
-SQLSERVER_HELPER = 'test/cases/helper_sqlserver.rb'
-SQLSERVER_COERCED = 'test/cases/coerced_tests.rb'
+SQLSERVER_HELPER = "test/cases/helper_sqlserver.rb"
+SQLSERVER_COERCED = "test/cases/coerced_tests.rb"
 
 def env_ar_test_files
-  return unless ENV['TEST_FILES_AR'] && !ENV['TEST_FILES_AR'].empty?
+  return unless ENV["TEST_FILES_AR"] && !ENV["TEST_FILES_AR"].empty?
+
   @env_ar_test_files ||= begin
-    ENV['TEST_FILES_AR'].split(',').map { |file|
+    ENV["TEST_FILES_AR"].split(",").map { |file|
       File.join ARTest::SQLServer.root_activerecord, file.strip
     }.sort
   end
 end
 
 def env_test_files
-  return unless ENV['TEST_FILES'] && !ENV['TEST_FILES'].empty?
-  @env_test_files ||= ENV['TEST_FILES'].split(',').map(&:strip)
+  return unless ENV["TEST_FILES"] && !ENV["TEST_FILES"].empty?
+
+  @env_test_files ||= ENV["TEST_FILES"].split(",").map(&:strip)
 end
 
 def sqlserver_cases
-  @sqlserver_cases ||= Dir.glob('test/cases/*_test_sqlserver.rb')
+  @sqlserver_cases ||= Dir.glob("test/cases/*_test_sqlserver.rb")
 end
 
 def ar_cases
   @ar_cases ||= begin
-    Dir.glob("#{ARTest::SQLServer.root_activerecord}/test/cases/**/*_test.rb").reject{ |x| x =~ /\/adapters\// }.sort
+    Dir.glob("#{ARTest::SQLServer.root_activerecord}/test/cases/**/*_test.rb").reject { |x| x =~ /\/adapters\// }.sort
   end
 end
 
@@ -31,9 +34,9 @@ def test_files
     [SQLSERVER_HELPER] + env_ar_test_files
   elsif env_test_files
     env_test_files
-  elsif ENV['ONLY_SQLSERVER']
+  elsif ENV["ONLY_SQLSERVER"]
     sqlserver_cases
-  elsif ENV['ONLY_ACTIVERECORD']
+  elsif ENV["ONLY_ACTIVERECORD"]
     [SQLSERVER_HELPER] + (ar_cases + [SQLSERVER_COERCED])
   else
     [SQLSERVER_HELPER] + (ar_cases + [SQLSERVER_COERCED] + sqlserver_cases)