activerecord-sqlserver-adapter 5.2.1 → 6.0.0.rc1

data/test/cases/column_test_sqlserver.rb

@@ -1,4 +1,5 @@
-# encoding: UTF-8
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class ColumnTestSQLServer < ActiveRecord::TestCase

data/test/cases/connection_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/reply'
 require 'models/topic'

data/test/cases/execute_procedure_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class ExecuteProcedureTestSQLServer < ActiveRecord::TestCase

data/test/cases/fetch_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/book'
 

data/test/cases/fully_qualified_identifier_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class FullyQualifiedIdentifierTestSQLServer < ActiveRecord::TestCase
@@ -42,14 +44,14 @@ class FullyQualifiedIdentifierTestSQLServer < ActiveRecord::TestCase
 
     it 'should not use fully qualified table name in order clause' do
       table = Arel::Table.new(:table)
-      expected_sql = "SELECT * FROM [my.server].[db].[schema].[table]  ORDER BY [table].[name]"
+      expected_sql = "SELECT * FROM [my.server].[db].[schema].[table] ORDER BY [table].[name]"
       assert_equal expected_sql, table.project(Arel.star).order(table[:name]).to_sql
     end
 
     it 'should use fully qualified table name in insert statement' do
       manager = Arel::InsertManager.new
       manager.into Arel::Table.new(:table)
-      manager.values = manager.create_values [Arel.sql('*')], %w{ a }
+      manager.values = manager.create_values [Arel.sql('*')]
       expected_sql = "INSERT INTO [my.server].[db].[schema].[table] VALUES (*)"
       quietly { assert_equal expected_sql, manager.to_sql }
     end

data/test/cases/helper_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'support/paths_sqlserver'
 require 'bundler/setup'
 Bundler.require :default, :development

data/test/cases/in_clause_test_sqlserver.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'cases/helper_sqlserver'
+require 'models/post'
+require 'models/author'
+
+class InClauseTestSQLServer < ActiveRecord::TestCase
+  fixtures :posts, :authors
+
+  it 'removes ordering from subqueries' do
+    authors_subquery = Author.where(name: ['David', 'Mary', 'Bob']).order(:name)
+    posts = Post.where(author: authors_subquery)
+
+    assert_includes authors_subquery.to_sql, "ORDER BY [authors].[name]"
+    assert_not_includes posts.to_sql, "ORDER BY [authors].[name]"
+    assert_equal 10, posts.length
+  end
+
+  it 'does not remove ordering from subquery that includes a limit' do
+    authors_subquery = Author.where(name: ['David', 'Mary', 'Bob']).order(:name).limit(2)
+    posts = Post.where(author: authors_subquery)
+
+    assert_includes authors_subquery.to_sql, "ORDER BY [authors].[name]"
+    assert_includes posts.to_sql, "ORDER BY [authors].[name]"
+    assert_equal 7, posts.length
+  end
+
+  it 'does not remove ordering from subquery that includes an offset' do
+    authors_subquery = Author.where(name: ['David', 'Mary', 'Bob']).order(:name).offset(1)
+    posts = Post.where(author: authors_subquery)
+
+    assert_includes authors_subquery.to_sql, "ORDER BY [authors].[name]"
+    assert_includes posts.to_sql, "ORDER BY [authors].[name]"
+    assert_equal 8, posts.length
+  end
+end

data/test/cases/index_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class IndexTestSQLServer < ActiveRecord::TestCase

data/test/cases/json_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 if ActiveRecord::Base.connection.supports_json?

data/test/cases/migration_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/person'
 
@@ -20,7 +22,7 @@ class MigrationTestSQLServer < ActiveRecord::TestCase
     it 'not create a tables if error in migrations' do
       begin
         migrations_dir = File.join ARTest::SQLServer.migrations_root, 'transaction_table'
-        quietly { ActiveRecord::MigrationContext.new(migrations_dir).up }
+        quietly { ActiveRecord::MigrationContext.new(migrations_dir, ActiveRecord::SchemaMigration).up }
       rescue Exception => e
         assert_match %r|this and all later migrations canceled|, e.message
       end
@@ -45,7 +47,7 @@ class MigrationTestSQLServer < ActiveRecord::TestCase
       Person.reset_column_information
     end
 
-    it 'not drop the default contraint if just renaming' do
+    it 'not drop the default constraint if just renaming' do
       find_default = lambda do
         connection.execute_procedure(:sp_helpconstraint, 'sst_string_defaults', 'nomsg').select do |row|
           row['constraint_type'] == "DEFAULT on column string_with_pretend_paren_three"

data/test/cases/order_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/post'
 

data/test/cases/pessimistic_locking_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/person'
 require 'models/reader'

data/test/cases/rake_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SQLServerRakeTest < ActiveRecord::TestCase

data/test/cases/schema_dumper_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SchemaDumperTestSQLServer < ActiveRecord::TestCase
@@ -168,7 +170,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
       if expected.nil?
         _(actual).must_be_nil message
       elsif expected.is_a?(Array)
-        actual.must_include expected, message
+        _(actual).must_include expected, message
       elsif expected.is_a?(Float)
         _(actual).must_be_close_to expected, 0.001
       elsif expected.is_a?(Proc)

data/test/cases/schema_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SchemaTestSQLServer < ActiveRecord::TestCase

data/test/cases/scratchpad_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class ScratchpadTestSQLServer < ActiveRecord::TestCase

data/test/cases/showplan_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/car'
 
@@ -21,14 +23,14 @@ class ShowplanTestSQLServer < ActiveRecord::TestCase
 
     it 'from prepared statement' do
       plan = Car.where(name: ',').limit(1).explain
-      _(plan).must_include " SELECT  [cars].* FROM [cars] WHERE [cars].[name]"
+      _(plan).must_include "SELECT [cars].* FROM [cars] WHERE [cars].[name]"
       _(plan).must_include "TOP EXPRESSION", 'make sure we do not showplan the sp_executesql'
       _(plan).must_include "Clustered Index Scan", 'make sure we do not showplan the sp_executesql'
     end
 
     it 'from array condition using index' do
       plan = Car.where(id: [1, 2]).explain
-      _(plan).must_include " SELECT [cars].* FROM [cars] WHERE [cars].[id] IN (1, 2)"
+      _(plan).must_include "SELECT [cars].* FROM [cars] WHERE [cars].[id] IN (1, 2)"
       _(plan).must_include "Clustered Index Seek", 'make sure we do not showplan the sp_executesql'
     end
 

data/test/cases/specific_schema_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SpecificSchemaTestSQLServer < ActiveRecord::TestCase

data/test/cases/transaction_test_sqlserver.rb

@@ -1,4 +1,5 @@
-# encoding: UTF-8
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 require 'models/ship'
 require 'models/developer'

data/test/cases/trigger_test_sqlserver.rb

@@ -1,4 +1,5 @@
-# encoding: UTF-8
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SQLServerTriggerTest < ActiveRecord::TestCase

data/test/cases/utils_test_sqlserver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class UtilsTestSQLServer < ActiveRecord::TestCase

data/test/cases/uuid_test_sqlserver.rb

@@ -1,4 +1,5 @@
-# encoding: UTF-8
+# frozen_string_literal: true
+
 require 'cases/helper_sqlserver'
 
 class SQLServerUuidTest < ActiveRecord::TestCase

data/test/debug.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # require 'rails/all'
 require 'tiny_tds'
 

data/test/migrations/create_clients_and_change_column_null.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateClientsAndChangeColumnNull < ActiveRecord::Migration[5.2]
   def up
     create_table :clients do |t|

data/test/migrations/transaction_table/1_table_will_never_be_created.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TableWillNeverBeCreated < ActiveRecord::Migration
 
   def self.up

data/test/models/sqlserver/booking.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestBooking < ActiveRecord::Base
   self.table_name = 'sst_bookings'
 end

data/test/models/sqlserver/customers_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestCustomersView < ActiveRecord::Base
   self.table_name = 'sst_customers_view'
 end

data/test/models/sqlserver/datatype.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDatatype < ActiveRecord::Base
   self.table_name = :sst_datatypes
 end

data/test/models/sqlserver/datatype_migration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDatatypeMigration < ActiveRecord::Base
   self.table_name = :sst_datatypes_migration
 end

data/test/models/sqlserver/dollar_table_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestDollarTableName < ActiveRecord::Base
   self.table_name = 'sst_my$strange_table'
 end

data/test/models/sqlserver/edge_schema.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestEdgeSchema < ActiveRecord::Base
 
   self.table_name = 'sst_edge_schemas'

data/test/models/sqlserver/fk_has_fk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestHasFk < ActiveRecord::Base
   self.table_name = 'sst_has_fks'
 end

data/test/models/sqlserver/fk_has_pk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestHasPk < ActiveRecord::Base
   self.table_name = 'sst_has_pks'
 end

data/test/models/sqlserver/natural_pk_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNaturalPkData < ActiveRecord::Base
   self.table_name = 'sst_natural_pk_data'
   self.primary_key = 'legacy_id'

data/test/models/sqlserver/natural_pk_int_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNaturalPkIntData < ActiveRecord::Base
   self.table_name = 'sst_natural_pk_int_data'
 end

data/test/models/sqlserver/no_pk_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestNoPkData < ActiveRecord::Base
   self.table_name = 'sst_no_pk_data'
 end

data/test/models/sqlserver/object_default.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestObjectDefault < ActiveRecord::Base
   self.table_name = 'sst_defaultobjects'
 end

data/test/models/sqlserver/quoted_table.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedTable < ActiveRecord::Base
   self.table_name = '[sst_quoted-table]'
 end

data/test/models/sqlserver/quoted_view_1.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedView1 < ActiveRecord::Base
   self.table_name = 'sst_quoted-view1'
 end

data/test/models/sqlserver/quoted_view_2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestQuotedView2 < ActiveRecord::Base
   self.table_name = 'sst_quoted-view2'
 end

data/test/models/sqlserver/sst_memory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTMemory < ActiveRecord::Base
   self.table_name = 'sst_memory'
 end

data/test/models/sqlserver/string_default.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefault < ActiveRecord::Base
   self.table_name = 'sst_string_defaults'
 end

data/test/models/sqlserver/string_defaults_big_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefaultsBigView < ActiveRecord::Base
   self.table_name = 'sst_string_defaults_big_view'
 end

data/test/models/sqlserver/string_defaults_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestStringDefaultsView < ActiveRecord::Base
   self.table_name = 'sst_string_defaults_view'
 end

data/test/models/sqlserver/tinyint_pk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTinyintPk < ActiveRecord::Base
   self.table_name = 'sst_tinyint_pk'
 end

data/test/models/sqlserver/trigger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTrigger < ActiveRecord::Base
   self.table_name = 'sst_table_with_trigger'
 end

data/test/models/sqlserver/trigger_history.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestTriggerHistory < ActiveRecord::Base
   self.table_name = 'sst_table_with_trigger_history'
 end

data/test/models/sqlserver/upper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUpper < ActiveRecord::Base
   self.table_name = 'sst_upper_tests'
 end

data/test/models/sqlserver/uppered.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUppered < ActiveRecord::Base
   self.table_name = 'SST_UPPER_TESTS'
 end

data/test/models/sqlserver/uuid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SSTestUuid < ActiveRecord::Base
   self.table_name = 'sst_uuids'
 end

data/test/schema/sqlserver_specific_schema.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ActiveRecord::Schema.define do
 
   # Exhaustive Data Types