activerecord-sqlserver-adapter 5.2.1 → 6.0.0.rc1

data/lib/active_record/connection_adapters/sqlserver/type/binary.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,8 +11,9 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'binary'.tap do |type|
-              type << "(#{limit})" if limit
+            "binary".yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
 

data/lib/active_record/connection_adapters/sqlserver/type/boolean.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -5,7 +7,7 @@ module ActiveRecord
         class Boolean < ActiveRecord::Type::Boolean
 
           def sqlserver_type
-            'bit'.freeze
+            "bit"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/char.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -15,8 +17,9 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'char'.tap do |type|
-              type << "(#{limit})" if limit
+            "char".yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
 

data/lib/active_record/connection_adapters/sqlserver/type/data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

data/lib/active_record/connection_adapters/sqlserver/type/date.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -5,7 +7,7 @@ module ActiveRecord
         class Date < ActiveRecord::Type::Date
 
           def sqlserver_type
-            'date'.freeze
+            'date'
           end
 
           def serialize(value)

data/lib/active_record/connection_adapters/sqlserver/type/datetime.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -7,16 +9,15 @@ module ActiveRecord
           include TimeValueFractional
 
           def sqlserver_type
-            'datetime'.freeze
+            "datetime"
           end
 
           def serialize(value)
             value = super
             return value unless value.acts_like?(:time)
-            datetime = value.to_s(:_sqlserver_datetime).tap do |v|
-              fraction = quote_fractional(value)
-              v << ".#{fraction}"
-            end
+            
+            datetime = "#{value.to_s(:_sqlserver_datetime)}.#{quote_fractional(value)}"
+
             Data.new datetime, self
           end
 
@@ -43,7 +44,7 @@ module ActiveRecord
           end
 
           def fast_string_to_time_format
-            "#{::Time::DATE_FORMATS[:_sqlserver_datetime]}.%N".freeze
+            "#{::Time::DATE_FORMATS[:_sqlserver_datetime]}.%N"
           end
         end
       end

data/lib/active_record/connection_adapters/sqlserver/type/datetime2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

data/lib/active_record/connection_adapters/sqlserver/type/datetimeoffset.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

data/lib/active_record/connection_adapters/sqlserver/type/decimal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -5,8 +7,9 @@ module ActiveRecord
         class Decimal < ActiveRecord::Type::Decimal
 
           def sqlserver_type
-            'decimal'.tap do |type|
-              type << "(#{precision.to_i},#{scale.to_i})" if precision || scale
+            "decimal".yield_self do |type|
+              type += "(#{precision.to_i},#{scale.to_i})" if precision || scale
+              type
             end
           end
 

data/lib/active_record/connection_adapters/sqlserver/type/float.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,7 +11,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'float'.freeze
+            "float"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/integer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -5,7 +7,7 @@ module ActiveRecord
         class Integer < ActiveRecord::Type::Integer
 
           def sqlserver_type
-            'int'.freeze
+            "int"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/json.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

data/lib/active_record/connection_adapters/sqlserver/type/money.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class Money < Decimal
 
-          def initialize(*args)
+          def initialize(**args)
             super
             @precision = 19
             @scale = 4
@@ -15,7 +17,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'money'.freeze
+            "money"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/real.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,7 +11,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'real'.freeze
+            "real"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/small_integer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -5,7 +7,7 @@ module ActiveRecord
         class SmallInteger < Integer
 
           def sqlserver_type
-            'smallint'.freeze
+            "smallint"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/small_money.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class SmallMoney < Money
 
-          def initialize(*args)
+          def initialize(**args)
             super
             @precision = 10
             @scale = 4
@@ -15,7 +17,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'smallmoney'.freeze
+            "smallmoney"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/smalldatetime.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,7 +11,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'smalldatetime'.freeze
+            "smalldatetime"
           end
 
           private

data/lib/active_record/connection_adapters/sqlserver/type/string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

data/lib/active_record/connection_adapters/sqlserver/type/text.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,7 +11,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'text'.freeze
+            "text"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/time.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,10 +11,9 @@ module ActiveRecord
           def serialize(value)
             value = super
             return value unless value.acts_like?(:time)
-            time = value.to_s(:_sqlserver_time).tap do |v|
-              fraction = quote_fractional(value)
-              v << ".#{fraction}"
-            end
+
+            time = "#{value.to_s(:_sqlserver_time)}.#{quote_fractional(value)}"
+            
             Data.new time, self
           end
 

data/lib/active_record/connection_adapters/sqlserver/type/time_value_fractional.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

data/lib/active_record/connection_adapters/sqlserver/type/timestamp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,7 +11,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'timestamp'.freeze
+            "timestamp"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/tiny_integer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -5,7 +7,7 @@ module ActiveRecord
         class TinyInteger < Integer
 
           def sqlserver_type
-            'tinyint'.freeze
+            "tinyint"
           end
 
           private

data/lib/active_record/connection_adapters/sqlserver/type/unicode_char.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,8 +11,9 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'nchar'.tap do |type|
-              type << "(#{limit})" if limit
+            'nchar'.yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
 

data/lib/active_record/connection_adapters/sqlserver/type/unicode_string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer

data/lib/active_record/connection_adapters/sqlserver/type/unicode_text.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -9,7 +11,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'ntext'.freeze
+            "ntext"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/unicode_varchar.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class UnicodeVarchar < UnicodeChar
 
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 4000 if @limit.to_i == 0
           end
@@ -14,8 +16,9 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'nvarchar'.tap do |type|
-              type << "(#{limit})" if limit
+            "nvarchar".yield_self do |type|
+              type += "(#{limit})" if limit
+              type
             end
           end
 

data/lib/active_record/connection_adapters/sqlserver/type/unicode_varchar_max.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
       module Type
         class UnicodeVarcharMax < UnicodeVarchar
 
-          def initialize(*args)
+          def initialize(**args)
             super
             @limit = 2_147_483_647
           end
@@ -14,7 +16,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'nvarchar(max)'.freeze
+            "nvarchar(max)"
           end
 
         end

data/lib/active_record/connection_adapters/sqlserver/type/uuid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module SQLServer
@@ -13,7 +15,7 @@ module ActiveRecord
           end
 
           def sqlserver_type
-            'uniqueidentifier'.freeze
+            "uniqueidentifier"
           end
 
           def serialize(value)