activerecord-sqlserver-adapter 2.2.18

data/test/cases/eager_association_test_sqlserver.rb

@@ -0,0 +1,42 @@
+require 'cases/sqlserver_helper'
+require 'models/author'
+require 'models/post'
+require 'models/comment'
+
+class EagerAssociationTestSqlserver < ActiveRecord::TestCase
+end
+
+class EagerAssociationTest < ActiveRecord::TestCase
+  
+  COERCED_TESTS = [
+    :test_count_with_include,
+    :test_eager_with_has_many_and_limit_and_high_offset_and_multiple_array_conditions,
+    :test_eager_with_has_many_and_limit_and_high_offset_and_multiple_hash_conditions
+  ]
+  
+  include SqlserverCoercedTest
+  
+  fixtures :authors, :posts, :comments
+  
+  def test_coerced_test_count_with_include
+    assert_equal 3, authors(:david).posts_with_comments.count(:conditions => "len(comments.body) > 15")
+  end
+  
+  def test_coerced_eager_with_has_many_and_limit_and_high_offset_and_multiple_array_conditions
+    assert_queries(2) do
+      posts = Post.find(:all, :include => [ :author, :comments ], :limit => 2, :offset => 10,
+        :conditions => [ "authors.name = ? and comments.body = ?", 'David', 'go crazy' ])
+      assert_equal 0, posts.size
+    end
+  end
+
+  def test_coerced_eager_with_has_many_and_limit_and_high_offset_and_multiple_hash_conditions
+    assert_queries(2) do
+      posts = Post.find(:all, :include => [ :author, :comments ], :limit => 2, :offset => 10,
+        :conditions => { 'authors.name' => 'David', 'comments.body' => 'go crazy' })
+      assert_equal 0, posts.size
+    end
+  end unless active_record_2_point_2?
+  
+  
+end

data/test/cases/execute_procedure_test_sqlserver.rb

@@ -0,0 +1,33 @@
+require 'cases/sqlserver_helper'
+
+class ExecuteProcedureTestSqlserver < ActiveRecord::TestCase
+  
+  def setup
+    @klass = ActiveRecord::Base
+  end
+  
+  should 'execute a simple procedure' do
+    tables = @klass.execute_procedure :sp_tables
+    assert_instance_of Array, tables
+    assert_instance_of HashWithIndifferentAccess, tables.first
+  end
+  
+  should 'take parameter arguments' do
+    tables = @klass.execute_procedure :sp_tables, 'sql_server_chronics'
+    table_info = tables.first
+    assert_equal 1, tables.size
+    assert_equal 'activerecord_unittest', table_info[:TABLE_QUALIFIER], "Table Info: #{table_info.inspect}"
+    assert_equal 'TABLE', table_info[:TABLE_TYPE], "Table Info: #{table_info.inspect}"
+  end
+  
+  should 'quote bind vars correctly' do
+    assert_sql(/EXEC sp_tables '%sql_server%', NULL, NULL, NULL, 1/) do
+      @klass.execute_procedure :sp_tables, '%sql_server%', nil, nil, nil, true
+    end if sqlserver_2005? || sqlserver_2008?
+    assert_sql(/EXEC sp_tables '%sql_server%', NULL, NULL, NULL/) do
+      @klass.execute_procedure :sp_tables, '%sql_server%', nil, nil, nil
+    end if sqlserver_2000?
+  end
+  
+  
+end

data/test/cases/inheritance_test_sqlserver.rb

@@ -0,0 +1,28 @@
+require 'cases/sqlserver_helper'
+require 'models/company'
+
+class InheritanceTestSqlserver < ActiveRecord::TestCase
+end
+
+class InheritanceTest < ActiveRecord::TestCase
+  
+  COERCED_TESTS = [
+    :test_eager_load_belongs_to_primary_key_quoting,
+    :test_a_bad_type_column
+  ]
+  
+  include SqlserverCoercedTest
+  
+  def test_coerced_test_eager_load_belongs_to_primary_key_quoting
+    assert_sql(/\(\[companies\].\[id\] = 1\)/) do
+      Account.find(1, :include => :firm)
+    end
+  end
+  
+  def test_coerced_test_a_bad_type_column
+    Company.connection.insert "INSERT INTO [companies] ([id], #{QUOTED_TYPE}, [name]) VALUES(100, 'bad_class!', 'Not happening')"
+    assert_raises(ActiveRecord::SubclassNotFound) { Company.find(100) }
+  end
+  
+  
+end

data/test/cases/method_scoping_test_sqlserver.rb

@@ -0,0 +1,28 @@
+require 'cases/sqlserver_helper'
+require 'models/developer'
+
+class MethodScopingTestSqlServer < ActiveRecord::TestCase
+end
+
+class NestedScopingTest < ActiveRecord::TestCase
+  
+  COERCED_TESTS = [:test_merged_scoped_find]
+  
+  include SqlserverCoercedTest
+  
+  fixtures :developers
+
+  def test_coerced_test_merged_scoped_find
+    poor_jamis = developers(:poor_jamis)
+    Developer.with_scope(:find => { :conditions => "salary < 100000" }) do
+      Developer.with_scope(:find => { :offset => 1, :order => 'id asc' }) do
+        assert_sql /ORDER BY id ASC/ do
+          assert_equal(poor_jamis, Developer.find(:first, :order => 'id asc'))
+        end
+      end
+    end
+  end
+  
+end
+
+

data/test/cases/migration_test_sqlserver.rb

@@ -0,0 +1,93 @@
+require 'cases/sqlserver_helper'
+require 'models/person'
+
+class MigrationTestSqlserver < ActiveRecord::TestCase
+  
+  context 'For transactions' do
+    
+    setup do
+      @connection = ActiveRecord::Base.connection
+      @trans_test_table1 = 'sqlserver_trans_table1'
+      @trans_test_table2 = 'sqlserver_trans_table2'
+      @trans_tables = [@trans_test_table1,@trans_test_table2]
+    end
+    
+    teardown do
+      @trans_tables.each do |table_name|
+        ActiveRecord::Migration.drop_table(table_name) if @connection.tables.include?(table_name)
+      end
+    end
+    
+    should 'not create a tables if error in migrations' do
+      begin
+        ActiveRecord::Migrator.up(SQLSERVER_MIGRATIONS_ROOT+'/transaction_table')
+      rescue Exception => e
+        assert_match %r|this and all later migrations canceled|, e.message
+      end
+      assert_does_not_contain @trans_test_table1, @connection.tables
+      assert_does_not_contain @trans_test_table2, @connection.tables
+    end
+    
+  end
+  
+  
+end
+
+
+class MigrationTest < ActiveRecord::TestCase
+  
+  COERCED_TESTS = [:test_add_column_not_null_without_default]
+  
+  include SqlserverCoercedTest
+  
+  def test_coerced_test_add_column_not_null_without_default
+    Person.connection.create_table :testings do |t| 
+      t.column :foo, :string
+      t.column :bar, :string, :null => false
+    end
+    assert_raises(ActiveRecord::StatementInvalid) do
+      Person.connection.execute "INSERT INTO [testings] ([foo], [bar]) VALUES ('hello', NULL)"
+    end
+  ensure
+    Person.connection.drop_table :testings rescue nil
+  end
+  
+end
+
+class ChangeTableMigrationsTest < ActiveRecord::TestCase
+  
+  COERCED_TESTS = [:test_string_creates_string_column]
+
+  include SqlserverCoercedTest
+  
+  def setup
+    @connection = Person.connection
+    @connection.create_table :delete_me, :force => true do |t|
+    end
+  end
+
+  def teardown
+    @connection.drop_table :delete_me rescue nil
+  end
+  
+  def test_coerced_string_creates_string_column
+    with_sqlserver_change_table do |t|
+      @connection.expects(:add_column).with(:delete_me, :foo, sqlserver_string_column, {})
+      @connection.expects(:add_column).with(:delete_me, :bar, sqlserver_string_column, {})
+      t.string :foo, :bar
+    end
+  end
+  
+  protected
+
+  def with_sqlserver_change_table
+    @connection.change_table :delete_me do |t|
+      yield t
+    end
+  end
+  
+  def sqlserver_string_column
+    "#{@connection.native_string_database_type}(255)"
+  end
+  
+end

data/test/cases/offset_and_limit_test_sqlserver.rb

@@ -0,0 +1,108 @@
+require 'cases/sqlserver_helper'
+require 'models/book'
+
+class OffsetAndLimitTestSqlserver < ActiveRecord::TestCase
+  
+  class Account < ActiveRecord::Base; end
+  
+  def setup
+    @connection = ActiveRecord::Base.connection
+  end
+  
+  context 'When selecting with limit' do
+
+    setup do
+      @select_sql = 'SELECT * FROM schema'
+    end
+
+    should 'alter SQL to limit number of records returned' do
+      options = { :limit => 10 }
+      assert_equal('SELECT TOP 10 * FROM schema', @connection.add_limit_offset!(@select_sql, options))
+    end
+
+    should 'only allow integers for limit' do
+      options = { :limit => 'ten' }
+      assert_raise(ArgumentError) {@connection.add_limit_offset!(@select_sql, options) }
+    end
+
+    should 'convert strings which look like integers to integers' do
+      options = { :limit => '42' }
+      assert_nothing_raised(ArgumentError) {@connection.add_limit_offset!(@select_sql, options)}
+    end
+
+    should 'not allow sql injection via limit' do
+      options = { :limit => '1 * FROM schema; DELETE * FROM table; SELECT TOP 10 *'}
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options) }
+    end
+
+  end
+  
+  context 'When selecting with limit and offset' do
+
+    setup do
+      @select_sql = 'SELECT * FROM books'
+      @subquery_select_sql = 'SELECT *, (SELECT TOP 1 id FROM books) AS book_id FROM books'
+      @books = (1..10).map {|i| Book.create!}
+    end
+    
+    teardown do
+      @books.each {|b| b.destroy}
+    end
+
+    should 'have limit if offset is passed' do
+      options = { :offset => 1 }
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options) }
+    end
+
+    should 'only allow integers for offset' do
+      options = { :limit => 10, :offset => 'five' }
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options)}
+    end
+
+    should 'convert strings which look like integers to integers' do
+      options = { :limit => 10, :offset => '5' }
+      assert_nothing_raised(ArgumentError) {@connection.add_limit_offset!(@select_sql, options)}
+    end
+
+    should 'alter SQL to limit number of records returned offset by specified amount' do
+      options = { :limit => 3, :offset => 5 }
+      expected_sql = "SELECT * FROM (SELECT TOP 3 * FROM (SELECT TOP 8 * FROM books) AS tmp1) AS tmp2"
+      assert_equal(expected_sql, @connection.add_limit_offset!(@select_sql, options))
+    end
+    
+    should 'add locks to deepest sub select in limit offset sql that has a limited tally' do
+      options = { :limit => 3, :offset => 5, :lock => 'WITH (NOLOCK)' }
+      expected_sql = "SELECT * FROM (SELECT TOP 3 * FROM (SELECT TOP 8 * FROM books WITH (NOLOCK)) AS tmp1) AS tmp2"
+      @connection.add_limit_offset! @select_sql, options
+      assert_equal expected_sql, @connection.add_lock!(@select_sql,options)
+    end
+
+    # Not really sure what an offset sql injection might look like
+    should 'not allow sql injection via offset' do
+      options = { :limit => 10, :offset => '1 * FROM schema; DELETE * FROM table; SELECT TOP 10 *'}
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options) }
+    end
+
+    should 'not create invalid SQL with subquery SELECTs with TOP' do
+      options = { :limit => 5, :offset => 1 }
+      expected_sql = "SELECT * FROM (SELECT TOP 5 * FROM (SELECT TOP 6 *, (SELECT TOP 1 id FROM books) AS book_id FROM books) AS tmp1) AS tmp2"
+      assert_equal expected_sql, @connection.add_limit_offset!(@subquery_select_sql,options)
+    end
+    
+    should 'add lock hints to tally sql if :lock option is present' do
+      assert_sql %r|SELECT TOP 1000000000 \* FROM \[people\] WITH \(NOLOCK\)| do
+        Person.all :limit => 5, :offset => 1, :lock => 'WITH (NOLOCK)'
+      end
+    end
+    
+    should 'not add lock hints to tally sql if there is no :lock option' do
+      assert_sql %r|\(SELECT TOP 1000000000 \* FROM \[people\] \)| do
+        Person.all :limit => 5, :offset => 1
+      end
+    end
+    
+  end
+  
+  
+end
+

data/test/cases/pessimistic_locking_test_sqlserver.rb

@@ -0,0 +1,125 @@
+require 'cases/sqlserver_helper'
+require 'models/person'
+require 'models/reader'
+
+class PessimisticLockingTestSqlserver < ActiveRecord::TestCase
+  
+  self.use_transactional_fixtures = false
+  fixtures :people, :readers
+  
+  def setup
+    Person.columns; Reader.columns # Avoid introspection queries during tests.
+  end
+  
+  context 'For simple finds with default lock option' do
+
+    should 'lock with simple find' do
+      assert_nothing_raised do
+        Person.transaction do
+          Person.find 1, :lock => true
+        end
+      end
+    end
+
+    should 'lock with scoped find' do
+      assert_nothing_raised do
+        Person.transaction do
+          Person.with_scope(:find => { :lock => true }) do
+            Person.find 1
+          end
+        end
+      end
+    end
+
+    should 'lock with eager find' do
+      assert_nothing_raised do
+        Person.transaction do
+          Person.find 1, :include => :readers, :lock => true
+        end
+      end
+    end
+
+    should 'reload with lock when #lock! called' do
+      assert_nothing_raised do
+        Person.transaction do
+          person = Person.find 1
+          old, person.first_name = person.first_name, 'fooman'
+          person.lock!
+          assert_equal old, person.first_name
+        end
+      end
+    end
+    
+    should 'simply add lock to find all' do
+      assert_sql %r|SELECT \* FROM \[people\] WITH \(NOLOCK\)| do
+        Person.all(:lock => 'WITH (NOLOCK)')
+      end
+    end
+
+  end
+  
+  context 'For paginated finds' do
+    
+    setup do
+      20.times { |n| Person.create!(:first_name => "Thing_#{n}") }
+    end
+    
+    should 'cope with un-locked paginated results' do
+      tally_not_locked = %r|SELECT count\(\*\) as TotalRows from \(SELECT TOP 1000000000 \* FROM \[people\]\s+WITH \(NOLOCK\) \) tally|
+      inner_tmp_not_locked = %r|SELECT TOP 15 \* FROM \[people\] WITH \(NOLOCK\)|
+      # Currently association limiting is not locked like the parent.
+      association_limiting_not_locked = %r|SELECT \[readers\]\.\* FROM \[readers\] WITH \(NOLOCK\) WHERE \(\[readers\]\.person_id IN \(1,2,3,4,5\)\)|
+      assert_sql(tally_not_locked,inner_tmp_not_locked) do
+        Person.all(:include => :readers, :lock => 'WITH (NOLOCK)', :limit => 5, :offset => 10)
+      end
+    end
+
+  end
+  
+  
+  context 'For dueling concurrent connections' do
+    
+    use_concurrent_connections
+
+    should 'no locks does not wait' do
+      first, second = duel { Person.find 1 }
+      assert first.end > second.end
+    end
+    
+    should 'that second lock waits' do
+      assert [0.2, 1, 5].any? { |zzz|
+        first, second = duel(zzz) { Person.find 1, :lock => true }
+        second.end > first.end
+      }
+    end
+    
+  end
+  
+    
+  protected
+  
+  def duel(zzz = 5)
+    t0, t1, t2, t3 = nil, nil, nil, nil
+    a = Thread.new do
+      t0 = Time.now
+      Person.transaction do
+        yield
+        sleep zzz       # block thread 2 for zzz seconds
+      end
+      t1 = Time.now
+    end
+    b = Thread.new do
+      sleep zzz / 2.0   # ensure thread 1 tx starts first
+      t2 = Time.now
+      Person.transaction { yield }
+      t3 = Time.now
+    end
+    a.join
+    b.join
+    assert t1 > t0 + zzz
+    assert t2 > t0
+    assert t3 > t2
+    [t0.to_f..t1.to_f, t2.to_f..t3.to_f]
+  end
+  
+end