activemerchant 1.45.0 → 1.126.0

data/lib/active_merchant/billing/gateways/psl_card.rb

@@ -17,11 +17,11 @@ module ActiveMerchant
       self.default_currency = 'GBP'
 
       self.supported_countries = ['GB']
-      # Visa Credit, Visa Debit, Mastercard, Maestro, Solo, Electron,
+      # Visa Credit, Visa Debit, Mastercard, Maestro, Electron,
       # American Express, Diners Club, JCB, International Maestro,
       # Style, Clydesdale Financial Services, Other
 
-      self.supported_cardtypes = [ :visa, :master, :american_express, :diners_club, :jcb, :switch, :solo, :maestro ]
+      self.supported_cardtypes = %i[visa master american_express diners_club jcb maestro]
       self.homepage_url = 'http://www.paymentsolutionsltd.com/'
       self.display_name = 'PSL Payment Solutions'
 
@@ -46,38 +46,38 @@ module ActiveMerchant
         'USD' => 840
       }
 
-      #The terminal used - only for swipe transactions, so hard coded to 32 for online
+      # The terminal used - only for swipe transactions, so hard coded to 32 for online
       EMV_TERMINAL_TYPE = 32
 
-      #Different Dispatch types
+      # Different Dispatch types
       DISPATCH_LATER  = 'LATER'
       DISPATCH_NOW    = 'NOW'
 
       # Return codes
       APPROVED = '00'
 
-      #Nominal amount to authorize for a 'dispatch later' type
-      #The nominal amount is held straight away, when the goods are ready
-      #to be dispatched, PSL is informed and the full amount is the
-      #taken.
+      # Nominal amount to authorize for a 'dispatch later' type
+      # The nominal amount is held straight away, when the goods are ready
+      # to be dispatched, PSL is informed and the full amount is the
+      # taken.
       NOMINAL_AMOUNT = 101
 
       AVS_CODE = {
-        "ALL MATCH"	=> 'Y',
-        "SECURITY CODE MATCH ONLY" => 'N',
-        "ADDRESS MATCH ONLY" => 'Y',
-        "NO DATA MATCHES"	=> 'N',
-        "DATA NOT CHECKED"	=> 'R',
-        "SECURITY CHECKS NOT SUPPORTED"	=> 'X'
+        'ALL MATCH'	=> 'Y',
+        'SECURITY CODE MATCH ONLY' => 'N',
+        'ADDRESS MATCH ONLY' => 'Y',
+        'NO DATA MATCHES'	=> 'N',
+        'DATA NOT CHECKED'	=> 'R',
+        'SECURITY CHECKS NOT SUPPORTED'	=> 'X'
       }
 
       CVV_CODE = {
-        "ALL MATCH"	=> 'M',
-        "SECURITY CODE MATCH ONLY" => 'M',
-        "ADDRESS MATCH ONLY" => 'N',
-        "NO DATA MATCHES"	=> 'N',
-        "DATA NOT CHECKED"	=> 'P',
-        "SECURITY CHECKS NOT SUPPORTED"	=> 'X'
+        'ALL MATCH'	=> 'M',
+        'SECURITY CODE MATCH ONLY' => 'M',
+        'ADDRESS MATCH ONLY' => 'N',
+        'NO DATA MATCHES'	=> 'N',
+        'DATA NOT CHECKED'	=> 'P',
+        'SECURITY CHECKS NOT SUPPORTED'	=> 'X'
       }
 
       # Create a new PslCardGateway
@@ -101,7 +101,7 @@ module ActiveMerchant
       #   -options:
       #
       # Returns:
-      #   -ActiveRecord::Billing::Response object
+      #   -ActiveMerchant::Billing::Response object
       #
       def purchase(money, credit_card, options = {})
         post = {}
@@ -129,7 +129,7 @@ module ActiveMerchant
       #   -options:
       #
       # Returns:
-      #   -ActiveRecord::Billing::Response object
+      #   -ActiveMerchant::Billing::Response object
       #
       def authorize(money, credit_card, options = {})
         post = {}
@@ -153,7 +153,7 @@ module ActiveMerchant
       #   -options:
       #
       # Returns:
-      #   -ActiveRecord::Billing::Response object
+      #   -ActiveMerchant::Billing::Response object
       #
       def capture(money, authorization, options = {})
         post = {}
@@ -174,12 +174,6 @@ module ActiveMerchant
         post[:ExpMonth] = credit_card.month
         post[:ExpYear] = credit_card.year
 
-        if requires_start_date_or_issue_number?(credit_card)
-          post[:IssueNumber] = credit_card.issue_number unless credit_card.issue_number.blank?
-          post[:StartMonth] = credit_card.start_month unless credit_card.start_month.blank?
-          post[:StartYear] = credit_card.start_year unless credit_card.start_year.blank?
-        end
-
         # CV2 check
         post[:AVSCV2Check] = credit_card.verification_value? ? 'YES' : 'NO'
         post[:CV2] = credit_card.verification_value if credit_card.verification_value?
@@ -189,7 +183,7 @@ module ActiveMerchant
         address = options[:billing_address] || options[:address]
         return if address.nil?
 
-        post[:QAAddress] = [:address1, :address2, :city, :state].collect{|a| address[a]}.reject{|a| a.blank?}.join(' ')
+        post[:QAAddress] = %i[address1 address2 city state].collect { |a| address[a] }.reject(&:blank?).join(' ')
         post[:QAPostcode] = address[:zip]
       end
 
@@ -217,7 +211,7 @@ module ActiveMerchant
 
       def add_purchase_details(post)
         post[:EchoAmount] = 'YES'
-        post[:SCBI] = 'YES'                   # Return information about the transaction
+        post[:SCBI] = 'YES' # Return information about the transaction
         post[:MessageType] = MESSAGE_TYPE
       end
 
@@ -246,10 +240,9 @@ module ActiveMerchant
       #   -a hash with all of the values returned in the PSL response
       #
       def parse(body)
-
         fields = {}
         for line in body.split('&')
-          key, value = *line.scan( %r{^(\w+)\=(.*)$} ).flatten
+          key, value = *line.scan(%r{^(\w+)\=(.*)$}).flatten
           fields[key] = CGI.unescape(value)
         end
         fields.symbolize_keys
@@ -264,14 +257,13 @@ module ActiveMerchant
       #   - ActiveMerchant::Billing::Response object
       #
       def commit(request)
-        response = parse( ssl_post(self.live_url, post_data(request)) )
+        response = parse(ssl_post(self.live_url, post_data(request)))
 
         Response.new(response[:ResponseCode] == APPROVED, response[:Message], response,
-          :test => test?,
-          :authorization => response[:CrossReference],
-          :cvv_result => CVV_CODE[response[:AVSCV2Check]],
-          :avs_result => { :code => AVS_CODE[response[:AVSCV2Check]] }
-        )
+          test: test?,
+          authorization: response[:CrossReference],
+          cvv_result: CVV_CODE[response[:AVSCV2Check]],
+          avs_result: { code: AVS_CODE[response[:AVSCV2Check]] })
       end
 
       # Put the passed data into a format that can be submitted to PSL
@@ -296,7 +288,7 @@ module ActiveMerchant
 
         post.collect { |key, value|
           "#{key}=#{CGI.escape(value.to_s.tr('&=', ' '))}"
-        }.join("&")
+        }.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/qbms.rb

@@ -5,22 +5,22 @@ module ActiveMerchant #:nodoc:
 
       class_attribute :test_url, :live_url
 
-      self.test_url = "https://webmerchantaccount.ptc.quickbooks.com/j/AppGateway"
-      self.live_url = "https://webmerchantaccount.quickbooks.com/j/AppGateway"
+      self.test_url = 'https://webmerchantaccount.ptc.quickbooks.com/j/AppGateway'
+      self.live_url = 'https://webmerchantaccount.quickbooks.com/j/AppGateway'
 
       self.homepage_url = 'http://payments.intuit.com/'
       self.display_name = 'QuickBooks Merchant Services'
       self.default_currency = 'USD'
-      self.supported_cardtypes = [ :visa, :master, :discover, :american_express, :diners_club, :jcb ]
-      self.supported_countries = [ 'US' ]
+      self.supported_cardtypes = %i[visa master discover american_express diners_club jcb]
+      self.supported_countries = ['US']
 
       TYPES = {
-        :authorize => 'CustomerCreditCardAuth',
-        :capture   => 'CustomerCreditCardCapture',
-        :purchase  => 'CustomerCreditCardCharge',
-        :refund    => 'CustomerCreditCardTxnVoidOrRefund',
-        :void      => 'CustomerCreditCardTxnVoid',
-        :query     => 'MerchantAccountQuery',
+        authorize: 'CustomerCreditCardAuth',
+        capture: 'CustomerCreditCardCapture',
+        purchase: 'CustomerCreditCardCharge',
+        refund: 'CustomerCreditCardTxnVoidOrRefund',
+        void: 'CustomerCreditCardTxnVoid',
+        query: 'MerchantAccountQuery'
       }
 
       # Creates a new QbmsGateway
@@ -51,7 +51,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>options</tt> -- A hash of optional parameters.
       #
       def authorize(money, creditcard, options = {})
-        commit(:authorize, money, options.merge(:credit_card => creditcard))
+        commit(:authorize, money, options.merge(credit_card: creditcard))
       end
 
       # Perform a purchase, which is essentially an authorization and capture in a single operation.
@@ -63,7 +63,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>options</tt> -- A hash of optional parameters.
       #
       def purchase(money, creditcard, options = {})
-        commit(:purchase, money, options.merge(:credit_card => creditcard))
+        commit(:purchase, money, options.merge(credit_card: creditcard))
       end
 
       # Captures the funds from an authorized transaction.
@@ -74,7 +74,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>authorization</tt> -- The authorization returned from the previous authorize request.
       #
       def capture(money, authorization, options = {})
-        commit(:capture, money, options.merge(:transaction_id => authorization))
+        commit(:capture, money, options.merge(transaction_id: authorization))
       end
 
       # Void a previous transaction
@@ -84,7 +84,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>authorization</tt> - The authorization returned from the previous authorize request.
       #
       def void(authorization, options = {})
-        commit(:void, nil, options.merge(:transaction_id => authorization))
+        commit(:void, nil, options.merge(transaction_id: authorization))
       end
 
       # Credit an account.
@@ -101,11 +101,11 @@ module ActiveMerchant #:nodoc:
       #
       def credit(money, identification, options = {})
         ActiveMerchant.deprecated CREDIT_DEPRECATION_MESSAGE
-        refund(money, identification, options = {})
+        refund(money, identification, {})
       end
 
       def refund(money, identification, options = {})
-        commit(:refund, money, options.merge(:transaction_id => identification))
+        commit(:refund, money, options.merge(transaction_id: identification))
       end
 
       # Query the merchant account status
@@ -113,6 +113,17 @@ module ActiveMerchant #:nodoc:
         commit(:query, nil, {})
       end
 
+      def supports_scrubbing?
+        true
+      end
+
+      def scrub(transcript)
+        transcript.
+          gsub(%r((<ConnectionTicket>)[^<]*(</ConnectionTicket>))i, '\1[FILTERED]\2').
+          gsub(%r((<CreditCardNumber>)[^<]*(</CreditCardNumber>))i, '\1[FILTERED]\2').
+          gsub(%r((<CardSecurityCode>)[^<]*(</CardSecurityCode>))i, '\1[FILTERED]\2')
+      end
+
       private
 
       def hosted?
@@ -127,17 +138,16 @@ module ActiveMerchant #:nodoc:
 
         req = build_request(type, money, parameters)
 
-        data = ssl_post(url, req, "Content-Type" => "application/x-qbmsxml")
+        data = ssl_post(url, req, 'Content-Type' => 'application/x-qbmsxml')
         response = parse(type, data)
         message = (response[:status_message] || '').strip
 
         Response.new(success?(response), message, response,
-          :test          => test?,
-          :authorization => response[:credit_card_trans_id],
-          :fraud_review  => fraud_review?(response),
-          :avs_result    => { :code => avs_result(response) },
-          :cvv_result    => cvv_result(response)
-        )
+          test: test?,
+          authorization: response[:credit_card_trans_id],
+          fraud_review: fraud_review?(response),
+          avs_result: { code: avs_result(response) },
+          cvv_result: cvv_result(response))
       end
 
       def success?(response)
@@ -152,20 +162,20 @@ module ActiveMerchant #:nodoc:
         xml = REXML::Document.new(body)
 
         signon = REXML::XPath.first(xml, "//SignonMsgsRs/#{hosted? ? 'SignonAppCertRs' : 'SignonDesktopRs'}")
-        status_code = signon.attributes["statusCode"].to_i
+        status_code = signon.attributes['statusCode'].to_i
 
         if status_code != 0
           return {
-            :status_code    => status_code,
-            :status_message => signon.attributes["statusMessage"],
+            status_code: status_code,
+            status_message: signon.attributes['statusMessage']
           }
         end
 
         response = REXML::XPath.first(xml, "//QBMSXMLMsgsRs/#{type}Rs")
 
         results = {
-          :status_code    => response.attributes["statusCode"].to_i,
-          :status_message => response.attributes["statusMessage"],
+          status_code: response.attributes['statusCode'].to_i,
+          status_message: response.attributes['statusMessage']
         }
 
         response.elements.each do |e|
@@ -184,21 +194,21 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_request(type, money, parameters = {})
-        xml = Builder::XmlMarkup.new(:indent => 0)
+        xml = Builder::XmlMarkup.new(indent: 0)
 
-        xml.instruct!(:xml, :version => '1.0', :encoding => 'utf-8')
-        xml.instruct!(:qbmsxml, :version => API_VERSION)
+        xml.instruct!(:xml, version: '1.0', encoding: 'utf-8')
+        xml.instruct!(:qbmsxml, version: API_VERSION)
 
-        xml.tag!("QBMSXML") do
-          xml.tag!("SignonMsgsRq") do
-            xml.tag!(hosted? ? "SignonAppCertRq" : "SignonDesktopRq") do
-              xml.tag!("ClientDateTime", Time.now.xmlschema)
-              xml.tag!("ApplicationLogin", @options[:login])
-              xml.tag!("ConnectionTicket", @options[:ticket])
+        xml.tag!('QBMSXML') do
+          xml.tag!('SignonMsgsRq') do
+            xml.tag!(hosted? ? 'SignonAppCertRq' : 'SignonDesktopRq') do
+              xml.tag!('ClientDateTime', Time.now.xmlschema)
+              xml.tag!('ApplicationLogin', @options[:login])
+              xml.tag!('ConnectionTicket', @options[:ticket])
             end
           end
 
-          xml.tag!("QBMSXMLMsgsRq") do
+          xml.tag!('QBMSXMLMsgsRq') do
             xml.tag!("#{type}Rq") do
               method("build_#{type}").call(xml, money, parameters)
             end
@@ -212,47 +222,47 @@ module ActiveMerchant #:nodoc:
         cc = parameters[:credit_card]
         name = "#{cc.first_name} #{cc.last_name}"[0...30]
 
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardNumber", cc.number)
-        xml.tag!("ExpirationMonth", cc.month)
-        xml.tag!("ExpirationYear", cc.year)
-        xml.tag!("IsECommerce", "true")
-        xml.tag!("Amount", amount(money))
-        xml.tag!("NameOnCard", name)
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardNumber', cc.number)
+        xml.tag!('ExpirationMonth', cc.month)
+        xml.tag!('ExpirationYear', cc.year)
+        xml.tag!('IsECommerce', 'true')
+        xml.tag!('Amount', amount(money))
+        xml.tag!('NameOnCard', name)
         add_address(xml, parameters)
-        xml.tag!("CardSecurityCode", cc.verification_value) if cc.verification_value?
+        xml.tag!('CardSecurityCode', cc.verification_value) if cc.verification_value?
       end
 
       def build_CustomerCreditCardCapture(xml, money, parameters)
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardTransID", parameters[:transaction_id])
-        xml.tag!("Amount", amount(money))
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardTransID', parameters[:transaction_id])
+        xml.tag!('Amount', amount(money))
       end
 
       def build_CustomerCreditCardCharge(xml, money, parameters)
         cc = parameters[:credit_card]
         name = "#{cc.first_name} #{cc.last_name}"[0...30]
 
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardNumber", cc.number)
-        xml.tag!("ExpirationMonth", cc.month)
-        xml.tag!("ExpirationYear", cc.year)
-        xml.tag!("IsECommerce", "true")
-        xml.tag!("Amount", amount(money))
-        xml.tag!("NameOnCard", name)
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardNumber', cc.number)
+        xml.tag!('ExpirationMonth', cc.month)
+        xml.tag!('ExpirationYear', cc.year)
+        xml.tag!('IsECommerce', 'true')
+        xml.tag!('Amount', amount(money))
+        xml.tag!('NameOnCard', name)
         add_address(xml, parameters)
-        xml.tag!("CardSecurityCode", cc.verification_value) if cc.verification_value?
+        xml.tag!('CardSecurityCode', cc.verification_value) if cc.verification_value?
       end
 
       def build_CustomerCreditCardTxnVoidOrRefund(xml, money, parameters)
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardTransID", parameters[:transaction_id])
-        xml.tag!("Amount", amount(money))
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardTransID', parameters[:transaction_id])
+        xml.tag!('Amount', amount(money))
       end
 
       def build_CustomerCreditCardTxnVoid(xml, money, parameters)
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardTransID", parameters[:transaction_id])
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardTransID', parameters[:transaction_id])
       end
 
       # Called reflectively by build_request
@@ -261,30 +271,30 @@ module ActiveMerchant #:nodoc:
 
       def add_address(xml, parameters)
         if address = parameters[:billing_address] || parameters[:address]
-          xml.tag!("CreditCardAddress", (address[:address1] || "")[0...30])
-          xml.tag!("CreditCardPostalCode", (address[:zip] || "")[0...9])
+          xml.tag!('CreditCardAddress', (address[:address1] || '')[0...30])
+          xml.tag!('CreditCardPostalCode', (address[:zip] || '')[0...9])
         end
       end
 
       def cvv_result(response)
         case response[:card_security_code_match]
-        when "Pass"         then 'M'
-        when "Fail"         then 'N'
-        when "NotAvailable" then 'P'
+        when 'Pass'         then 'M'
+        when 'Fail'         then 'N'
+        when 'NotAvailable' then 'P'
         end
       end
 
       def avs_result(response)
         case "#{response[:avs_street]}|#{response[:avs_zip]}"
-        when "Pass|Pass"                 then "D"
-        when "Pass|Fail"                 then "A"
-        when "Pass|NotAvailable"         then "B"
-        when "Fail|Pass"                 then "Z"
-        when "Fail|Fail"                 then "C"
-        when "Fail|NotAvailable"         then "N"
-        when "NotAvailable|Pass"         then "P"
-        when "NotAvailable|Fail"         then "N"
-        when "NotAvailable|NotAvailable" then "U"
+        when 'Pass|Pass'                 then 'D'
+        when 'Pass|Fail'                 then 'A'
+        when 'Pass|NotAvailable'         then 'B'
+        when 'Fail|Pass'                 then 'Z'
+        when 'Fail|Fail'                 then 'C'
+        when 'Fail|NotAvailable'         then 'N'
+        when 'NotAvailable|Pass'         then 'P'
+        when 'NotAvailable|Fail'         then 'N'
+        when 'NotAvailable|NotAvailable' then 'U'
         end
       end
     end

data/lib/active_merchant/billing/gateways/quantum.rb

@@ -13,7 +13,7 @@ module ActiveMerchant #:nodoc:
       self.live_url = self.test_url = 'https://secure.quantumgateway.com/cgi/xml_requester.php'
 
       # visa, master, american_express, discover
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
       self.supported_countries = ['US']
       self.default_currency = 'USD'
       self.money_format = :dollars
@@ -44,7 +44,7 @@ module ActiveMerchant #:nodoc:
       #
       def authorize(money, creditcard, options = {})
         setup_address_hash(options)
-        commit(build_auth_request(money, creditcard, options), options )
+        commit(build_auth_request(money, creditcard, options), options)
       end
 
       # Capture an authorization that has previously been requested
@@ -81,7 +81,7 @@ module ActiveMerchant #:nodoc:
 
       def build_auth_request(money, creditcard, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'AUTH_ONLY')
+        add_common_credit_card_info(xml, 'AUTH_ONLY')
         add_purchase_data(xml, money)
         add_creditcard(xml, creditcard)
         add_address(xml, creditcard, options[:billing_address], options)
@@ -94,15 +94,15 @@ module ActiveMerchant #:nodoc:
 
       def build_capture_request(money, authorization, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'PREVIOUS_SALE')
-        transaction_id, _ = authorization_parts_from(authorization)
+        add_common_credit_card_info(xml, 'PREVIOUS_SALE')
+        transaction_id, = authorization_parts_from(authorization)
         add_transaction_id(xml, transaction_id)
         xml.target!
       end
 
       def build_purchase_request(money, creditcard, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml, @options[:ignore_avs] ||  @options[:ignore_cvv] ? 'SALES' : 'AUTH_CAPTURE')
+        add_common_credit_card_info(xml, @options[:ignore_avs] || @options[:ignore_cvv] ? 'SALES' : 'AUTH_CAPTURE')
         add_address(xml, creditcard, options[:billing_address], options)
         add_purchase_data(xml, money)
         add_creditcard(xml, creditcard)
@@ -115,15 +115,15 @@ module ActiveMerchant #:nodoc:
 
       def build_void_request(authorization, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'VOID')
-        transaction_id, _ = authorization_parts_from(authorization)
+        add_common_credit_card_info(xml, 'VOID')
+        transaction_id, = authorization_parts_from(authorization)
         add_transaction_id(xml, transaction_id)
         xml.target!
       end
 
       def build_credit_request(money, authorization, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'RETURN')
+        add_common_credit_card_info(xml, 'RETURN')
         add_purchase_data(xml, money)
         transaction_id, cc = authorization_parts_from(authorization)
         add_transaction_id(xml, transaction_id)
@@ -182,7 +182,7 @@ module ActiveMerchant #:nodoc:
         xml.tag! 'CreditCardNumber', creditcard.number
         xml.tag! 'ExpireMonth', format(creditcard.month, :two_digits)
         xml.tag! 'ExpireYear', format(creditcard.year, :four_digits)
-        xml.tag!('CVV2', creditcard.verification_value) unless (@options[:ignore_cvv] || creditcard.verification_value.blank? )
+        xml.tag!('CVV2', creditcard.verification_value) unless @options[:ignore_cvv] || creditcard.verification_value.blank?
       end
 
       # Where we actually build the full SOAP request using builder
@@ -206,7 +206,7 @@ module ActiveMerchant #:nodoc:
         headers = { 'Content-Type' => 'text/xml' }
         response = parse(ssl_post(self.live_url, build_request(request, options), headers))
 
-        success = response[:request_status] == "Success"
+        success = response[:request_status] == 'Success'
         message = response[:request_message]
 
         if success # => checking for connectivity success first
@@ -216,11 +216,10 @@ module ActiveMerchant #:nodoc:
         end
 
         Response.new(success, message, response,
-        :test => test?,
-        :authorization => authorization,
-        :avs_result => { :code => response[:AVSResponseCode] },
-        :cvv_result => response[:CVV2ResponseCode]
-        )
+          test: test?,
+          authorization: authorization,
+          avs_result: { code: response[:AVSResponseCode] },
+          cvv_result: response[:CVV2ResponseCode])
       end
 
       # Parse the SOAP response
@@ -231,19 +230,19 @@ module ActiveMerchant #:nodoc:
         begin
           xml = REXML::Document.new(xml)
 
-          root = REXML::XPath.first(xml, "//QGWRequest/ResponseSummary")
+          root = REXML::XPath.first(xml, '//QGWRequest/ResponseSummary')
           parse_element(reply, root)
           reply[:request_status] = reply[:Status]
           reply[:request_message] = "#{reply[:Status]}: #{reply[:StatusDescription]}"
 
-          if root = REXML::XPath.first(xml, "//QGWRequest/Result")
+          if root = REXML::XPath.first(xml, '//QGWRequest/Result')
             root.elements.to_a.each do |node|
               parse_element(reply, node)
             end
           end
         rescue Exception
           reply[:request_status] = 'Failure'
-          reply[:request_message] = "Failure: There was a problem parsing the response XML"
+          reply[:request_message] = 'Failure: There was a problem parsing the response XML'
         end
 
         return reply
@@ -251,10 +250,10 @@ module ActiveMerchant #:nodoc:
 
       def parse_element(reply, node)
         if node.has_elements?
-          node.elements.each{|e| parse_element(reply, e) }
+          node.elements.each { |e| parse_element(reply, e) }
         else
-          if node.parent.name =~ /item/
-            parent = node.parent.name + (node.parent.attributes["id"] ? "_" + node.parent.attributes["id"] : '')
+          if /item/.match?(node.parent.name)
+            parent = node.parent.name + (node.parent.attributes['id'] ? '_' + node.parent.attributes['id'] : '')
             reply[(parent + '_' + node.name).to_sym] = node.text
           else
             reply[node.name.to_sym] = node.text
@@ -270,7 +269,6 @@ module ActiveMerchant #:nodoc:
       def authorization_parts_from(authorization)
         authorization.split(/;/)
       end
-
     end
   end
 end