activemerchant 1.45.0 → 1.126.0

data/lib/active_merchant/billing/gateways/cashnet.rb

@@ -1,13 +1,17 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CashnetGateway < Gateway
-      self.live_url      = "https://commerce.cashnet.com/"
+      include Empty
 
-      self.supported_countries = ["US"]
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb]
-      self.homepage_url        = "http://www.higherone.com/"
-      self.display_name        = "Cashnet"
+      self.live_url = 'https://commerce.cashnet.com/'
+      self.test_url = 'https://train.cashnet.com/'
+
+      self.supported_countries = ['US']
+      self.supported_cardtypes = %i[visa master american_express discover diners_club jcb]
+      self.homepage_url        = 'https://transactcampus.com'
+      self.display_name        = 'Cashnet'
       self.money_format        = :dollars
+      self.max_retries         = 0
 
       # Creates a new CashnetGateway
       #
@@ -30,14 +34,14 @@ module ActiveMerchant #:nodoc:
           :password,
           :merchant_gateway_name
         )
-        options[:default_item_code] ||= "FEE"
+        options[:default_item_code] ||= 'FEE'
         super
       end
 
       def purchase(money, payment_object, options = {})
         post = {}
         add_creditcard(post, payment_object)
-        add_invoice(post, options)
+        add_invoice(post, money, options)
         add_address(post, options)
         add_customer_data(post, options)
         commit('SALE', money, post)
@@ -45,37 +49,56 @@ module ActiveMerchant #:nodoc:
 
       def refund(money, identification, options = {})
         post = {}
-        post[:origtx]  = identification
-        add_invoice(post, options)
+        post[:origtx] = identification
+        add_invoice(post, money, options)
+        add_customer_data(post, options)
         commit('REFUND', money, post)
       end
 
+      def supports_scrubbing?
+        true
+      end
+
+      def scrub(transcript)
+        transcript.
+          gsub(%r{(password=)[^&]+}, '\1[FILTERED]').
+          gsub(%r{(cardno=)[^&]+}, '\1[FILTERED]').
+          gsub(%r{(cid=)[^&]+}, '\1[FILTERED]')
+      end
+
       private
 
       def commit(action, money, fields)
-        fields[:amount] = amount(money)
-        url = live_url + @options[:merchant_gateway_name]
-        response = parse(ssl_post(url, post_data(action, fields)))
+        url = (test? ? test_url : live_url) + CGI.escape(@options[:merchant_gateway_name])
+        raw_response = ssl_post(url, post_data(action, fields))
+        parsed_response = parse(raw_response)
 
-        success = (response[:result] == '0')
+        return unparsable_response(raw_response) unless parsed_response
+
+        success = success?(parsed_response)
         Response.new(
           success,
-          CASHNET_CODES[response[:result]],
-          response,
+          CASHNET_CODES[parsed_response[:result]],
+          parsed_response,
           test:          test?,
-          authorization: (success ? response[:tx] : '')
+          authorization: (success ? parsed_response[:tx] : '')
         )
       end
 
+      def success?(response)
+        response[:result] == '0'
+      end
+
       def post_data(action, parameters = {})
         post = {}
+
         post[:command]        = action
         post[:merchant]       = @options[:merchant]
         post[:operator]       = @options[:operator]
         post[:password]       = @options[:password]
-        post[:station]        = (@options[:station] || "WEB")
+        post[:station]        = (@options[:station] || 'WEB')
         post[:custcode]       = (@options[:custcode] || "ActiveMerchant/#{ActiveMerchant::VERSION}")
-        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def add_creditcard(post, creditcard)
@@ -87,9 +110,19 @@ module ActiveMerchant #:nodoc:
         post[:lname]           = creditcard.last_name
       end
 
-      def add_invoice(post, options)
-        post[:order_number]    = options[:order_id] if options[:order_id].present?
-        post[:itemcode]       = (options[:item_code] || @options[:default_item_code])
+      def add_invoice(post, money, options)
+        post[:order_number] = options[:order_id] if options[:order_id].present?
+
+        if options[:item_codes].present?
+          codes_and_amounts = options[:item_codes].transform_keys { |key| key.to_s.delete('_') }
+          codes_and_amounts.each do |key, value|
+            post[key] = value if key.start_with?('itemcode')
+            post[key] = amount(value.to_i) if key.start_with?('amount')
+          end
+        else
+          post[:itemcode] = (options[:item_code] || @options[:default_item_code])
+          post[:amount] = amount(money.to_i)
+        end
       end
 
       def add_address(post, options)
@@ -102,7 +135,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_data(post, options)
-        post[:email_g]  = options[:email]
+        post[:email_g] = options[:email]
+        post[:custcode] = options[:custcode] unless empty?(options[:custcode])
       end
 
       def expdate(creditcard)
@@ -113,19 +147,28 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(body)
-        response_data = body.match(/<cngateway>(.*)<\/cngateway>/)[1]
-        Hash[CGI::parse(response_data).map{|k,v| [k.to_sym,v.first]}]
+        match = body.match(/<cngateway>(.*)<\/cngateway>/)
+        return nil unless match
+
+        Hash[CGI::parse(match[1]).map { |k, v| [k.to_sym, v.first] }]
       end
 
       def handle_response(response)
-        if (200...300).include?(response.code.to_i)
+        if (200...300).cover?(response.code.to_i)
           return response.body
-        elsif 302 == response.code.to_i
+        elsif response.code.to_i == 302
           return ssl_get(URI.parse(response['location']))
         end
+
         raise ResponseError.new(response)
       end
 
+      def unparsable_response(raw_response)
+        message = 'Unparsable response received from Cashnet. Please contact Cashnet if you continue to receive this message.'
+        message += " (The raw response returned by the API was #{raw_response.inspect})"
+        return Response.new(false, message)
+      end
+
       CASHNET_CODES = {
         '0' => 'Success',
         '1' => 'Invalid customer code, no customer code specified',
@@ -162,6 +205,7 @@ module ActiveMerchant #:nodoc:
         '215' => 'Old PIN does not validate ',
         '221' => 'Invalid credit card processor type specified in location or payment code',
         '222' => 'Credit card processor error',
+        '230' => 'Host Error (USE VOID OR REVERSAL TO REFUND UNSETTLED TRANSACTIONS)',
         '280' => 'SmartPay transaction not posted',
         '301' => 'Original transaction not found for this customer',
         '302' => 'Amount to refund exceeds original payment amount or is missing',

data/lib/active_merchant/billing/gateways/cc5.rb

@@ -48,9 +48,9 @@ module ActiveMerchant #:nodoc:
       protected
 
       def build_sale_request(type, money, creditcard, options = {})
-        requires!(options,  :order_id)
+        requires!(options, :order_id)
 
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new indent: 2
 
         xml.tag! 'CC5Request' do
           add_login_tags(xml)
@@ -62,7 +62,7 @@ module ActiveMerchant #:nodoc:
           add_amount_tags(money, options, xml)
           xml.tag! 'Email', options[:email] if options[:email]
 
-          if(address = (options[:billing_address] || options[:address]))
+          if (address = (options[:billing_address] || options[:address]))
             xml.tag! 'BillTo' do
               add_address(xml, address)
             end
@@ -70,14 +70,13 @@ module ActiveMerchant #:nodoc:
               add_address(xml, address)
             end
           end
-
         end
 
         xml.target!
       end
 
       def build_capture_request(money, authorization, options = {})
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new indent: 2
 
         xml.tag! 'CC5Request' do
           add_login_tags(xml)
@@ -88,7 +87,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_void_request(authorization, options = {})
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new indent: 2
 
         xml.tag! 'CC5Request' do
           add_login_tags(xml)
@@ -98,7 +97,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_authorization_credit_request(money, authorization, options = {})
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new indent: 2
 
         xml.tag! 'CC5Request' do
           add_login_tags(xml)
@@ -109,7 +108,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_creditcard_credit_request(money, creditcard, options = {})
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new indent: 2
 
         xml.tag! 'CC5Request' do
           add_login_tags(xml)
@@ -148,7 +147,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def commit(request)
-        raw_response = ssl_post((test? ? self.test_url : self.live_url), "DATA=" + request)
+        raw_response = ssl_post((test? ? self.test_url : self.live_url), 'DATA=' + request)
 
         response = parse(raw_response)
 
@@ -158,8 +157,8 @@ module ActiveMerchant #:nodoc:
           success,
           (success ? 'Approved' : "Declined (Reason: #{response[:proc_return_code]} - #{response[:err_msg]})"),
           response,
-          :test => test?,
-          :authorization => response[:order_id]
+          test: test?,
+          authorization: response[:order_id]
         )
       end
 
@@ -175,25 +174,23 @@ module ActiveMerchant #:nodoc:
 
       def parse_element(response, node)
         if node.has_elements?
-          node.elements.each{|element| parse_element(response, element) }
+          node.elements.each { |element| parse_element(response, element) }
         else
           response[node.name.underscore.to_sym] = node.text
         end
       end
 
       def success?(response)
-        (response[:response] == "Approved")
+        (response[:response] == 'Approved')
       end
 
       def normalize(text)
         return unless text
 
         if ActiveSupport::Inflector.method(:transliterate).arity == -2
-          ActiveSupport::Inflector.transliterate(text,'')
-        elsif RUBY_VERSION >= '1.9'
-          text.gsub(/[^\x00-\x7F]+/, '')
+          ActiveSupport::Inflector.transliterate(text, '')
         else
-          ActiveSupport::Inflector.transliterate(text).to_s
+          text.gsub(/[^\x00-\x7F]+/, '')
         end
       end
     end

data/lib/active_merchant/billing/gateways/cecabank.rb

@@ -1,11 +1,11 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CecabankGateway < Gateway
-      self.test_url = 'http://tpv.ceca.es:8000'
+      self.test_url = 'https://tpv.ceca.es'
       self.live_url = 'https://pgw.ceca.es'
 
       self.supported_countries = ['ES']
-      self.supported_cardtypes = [:visa, :master, :american_express]
+      self.supported_cardtypes = %i[visa master american_express]
       self.homepage_url = 'http://www.ceca.es/es/'
       self.display_name = 'Cecabank'
       self.default_currency = 'EUR'
@@ -13,15 +13,15 @@ module ActiveMerchant #:nodoc:
 
       #### CECA's MAGIC NUMBERS
       CECA_NOTIFICATIONS_URL = 'NONE'
-      CECA_ENCRIPTION = 'SHA1'
+      CECA_ENCRIPTION = 'SHA2'
       CECA_DECIMALS = '2'
       CECA_MODE = 'SSL'
       CECA_UI_LESS_LANGUAGE = 'XML'
       CECA_UI_LESS_LANGUAGE_REFUND = '1'
       CECA_UI_LESS_REFUND_PAGE = 'anulacion_xml'
-      CECA_ACTION_REFUND   = 'tpvanularparcialmente' #use partial refund's URL to avoid time frame limitations and decision logic on client side
-      CECA_ACTION_PURCHASE = 'tpv'
-      CECA_CURRENCIES_DICTIONARY = {'EUR' => 978, 'USD' => 840, 'GBP' => 826}
+      CECA_ACTION_REFUND   = 'anulaciones/anularParcial' # use partial refund's URL to avoid time frame limitations and decision logic on client side
+      CECA_ACTION_PURCHASE = 'tpv/compra'
+      CECA_CURRENCIES_DICTIONARY = { 'EUR' => 978, 'USD' => 840, 'GBP' => 826 }
 
       # Creates a new CecabankGateway
       #
@@ -57,14 +57,14 @@ module ActiveMerchant #:nodoc:
       def purchase(money, creditcard, options = {})
         requires!(options, :order_id)
 
-        post = {'Descripcion' => options[:description],
+        post = { 'Descripcion' => options[:description],
                 'Num_operacion' => options[:order_id],
                 'Idioma' => CECA_UI_LESS_LANGUAGE,
                 'Pago_soportado' => CECA_MODE,
                 'URL_OK' => CECA_NOTIFICATIONS_URL,
                 'URL_NOK' => CECA_NOTIFICATIONS_URL,
                 'Importe' => amount(money),
-                'TipoMoneda' => CECA_CURRENCIES_DICTIONARY[options[:currency] || currency(money)]}
+                'TipoMoneda' => CECA_CURRENCIES_DICTIONARY[options[:currency] || currency(money)] }
 
         add_creditcard(post, creditcard)
 
@@ -84,16 +84,27 @@ module ActiveMerchant #:nodoc:
       def refund(money, identification, options = {})
         reference, order_id = split_authorization(identification)
 
-        post = {'Referencia' => reference,
+        post = { 'Referencia' => reference,
                 'Num_operacion' => order_id,
                 'Idioma' => CECA_UI_LESS_LANGUAGE_REFUND,
                 'Pagina' => CECA_UI_LESS_REFUND_PAGE,
                 'Importe' => amount(money),
-                'TipoMoneda' => CECA_CURRENCIES_DICTIONARY[options[:currency] || currency(money)]}
+                'TipoMoneda' => CECA_CURRENCIES_DICTIONARY[options[:currency] || currency(money)] }
 
         commit(CECA_ACTION_REFUND, post)
       end
 
+      def supports_scrubbing
+        true
+      end
+
+      def scrub(transcript)
+        transcript.
+          gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]').
+          gsub(%r((&?pan=)[^&]*)i, '\1[FILTERED]').
+          gsub(%r((&?cvv2=)[^&]*)i, '\1[FILTERED]')
+      end
+
       private
 
       def add_creditcard(post, creditcard)
@@ -112,14 +123,14 @@ module ActiveMerchant #:nodoc:
 
         root = REXML::Document.new(body).root
 
-        response[:success] = (root.attributes['valor'] == "OK")
+        response[:success] = (root.attributes['valor'] == 'OK')
         response[:date] = root.attributes['fecha']
         response[:operation_number] = root.attributes['numeroOperacion']
         response[:message] = root.attributes['valor']
 
         if root.elements['OPERACION']
           response[:operation_type] = root.elements['OPERACION'].attributes['tipo']
-          response[:amount] =  root.elements['OPERACION/importe'].text.strip
+          response[:amount] = root.elements['OPERACION/importe'].text.strip
         end
 
         response[:description] = root.elements['OPERACION/descripcion'].text if root.elements['OPERACION/descripcion']
@@ -131,20 +142,17 @@ module ActiveMerchant #:nodoc:
           response[:error_code] = root.elements['ERROR/codigo'].text
           response[:error_message] = root.elements['ERROR/descripcion'].text
         else
-          if("000" == root.elements['OPERACION'].attributes['numeroOperacion'])
-            if(root.elements['OPERACION/numeroAutorizacion'])
-              response[:authorization] = root.elements['OPERACION/numeroAutorizacion'].text
-            end
+          if root.elements['OPERACION'].attributes['numeroOperacion'] == '000'
+            response[:authorization] = root.elements['OPERACION/numeroAutorizacion'].text if root.elements['OPERACION/numeroAutorizacion']
           else
             response[:authorization] = root.attributes['numeroOperacion']
           end
         end
 
         return response
-
       rescue REXML::ParseException => e
         response[:success] = false
-        response[:message] = "Unable to parse the response."
+        response[:message] = 'Unable to parse the response.'
         response[:error_message] = e.message
         response
       end
@@ -158,23 +166,35 @@ module ActiveMerchant #:nodoc:
           'AcquirerBIN' => options[:acquirer_bin],
           'TerminalID' => options[:terminal_id]
         )
-        url = (test? ? self.test_url : self.live_url) + "/cgi-bin/#{action}"
-        xml = ssl_post(url, post_data(parameters))
+        url = (test? ? self.test_url : self.live_url) + "/tpvweb/#{action}.action"
+        xml = ssl_post("#{url}?", post_data(parameters))
         response = parse(xml)
         Response.new(
           response[:success],
-          response[:message],
+          message_from(response),
           response,
-          :test => test?,
-          :authorization => build_authorization(response)
+          test: test?,
+          authorization: build_authorization(response),
+          error_code: response[:error_code]
         )
       end
 
+      def message_from(response)
+        if response[:message] == 'ERROR' && response[:error_message]
+          response[:error_message]
+        elsif response[:error_message]
+          "#{response[:message]} #{response[:error_message]}"
+        else
+          response[:message]
+        end
+      end
+
       def post_data(params)
         return nil unless params
 
         params.map do |key, value|
           next if value.blank?
+
           if value.is_a?(Hash)
             h = {}
             value.each do |k, v|
@@ -184,46 +204,46 @@ module ActiveMerchant #:nodoc:
           else
             "#{key}=#{CGI.escape(value.to_s)}"
           end
-        end.compact.join("&")
+        end.compact.join('&')
       end
 
       def build_authorization(response)
-        [response[:reference], response[:authorization]].join("|")
+        [response[:reference], response[:authorization]].join('|')
       end
 
       def split_authorization(authorization)
-        authorization.split("|")
+        authorization.split('|')
       end
 
       def generate_signature(action, parameters)
-        signature_fields = case action
-        when CECA_ACTION_REFUND
-          options[:key].to_s +
-          options[:merchant_id].to_s +
-          options[:acquirer_bin].to_s +
-          options[:terminal_id].to_s +
-          parameters['Num_operacion'].to_s +
-          parameters['Importe'].to_s +
-          parameters['TipoMoneda'].to_s +
-          CECA_DECIMALS +
-          parameters['Referencia'].to_s +
-          CECA_ENCRIPTION
-        else
-          options[:key].to_s +
-          options[:merchant_id].to_s +
-          options[:acquirer_bin].to_s +
-          options[:terminal_id].to_s +
-          parameters['Num_operacion'].to_s +
-          parameters['Importe'].to_s +
-          parameters['TipoMoneda'].to_s +
-          CECA_DECIMALS +
-          CECA_ENCRIPTION +
-          CECA_NOTIFICATIONS_URL +
-          CECA_NOTIFICATIONS_URL
-        end
-        Digest::SHA1.hexdigest(signature_fields)
+        signature_fields =
+          case action
+          when CECA_ACTION_REFUND
+            options[:key].to_s +
+            options[:merchant_id].to_s +
+            options[:acquirer_bin].to_s +
+            options[:terminal_id].to_s +
+            parameters['Num_operacion'].to_s +
+            parameters['Importe'].to_s +
+            parameters['TipoMoneda'].to_s +
+            CECA_DECIMALS +
+            parameters['Referencia'].to_s +
+            CECA_ENCRIPTION
+          else
+            options[:key].to_s +
+            options[:merchant_id].to_s +
+            options[:acquirer_bin].to_s +
+            options[:terminal_id].to_s +
+            parameters['Num_operacion'].to_s +
+            parameters['Importe'].to_s +
+            parameters['TipoMoneda'].to_s +
+            CECA_DECIMALS +
+            CECA_ENCRIPTION +
+            CECA_NOTIFICATIONS_URL +
+            CECA_NOTIFICATIONS_URL
+          end
+        Digest::SHA2.hexdigest(signature_fields)
       end
     end
   end
 end
-