activemerchant 1.2.1 → 1.3.0

data/test/{remote_tests → remote/integrations}/remote_paypal_integration_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../test_helper'
+require File.dirname(__FILE__) + '/../../test_helper'
 
 class RemotePaypalIntegrationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/test_helper.rb

@@ -17,76 +17,133 @@ require 'digest/md5'
 
 require File.dirname(__FILE__) + '/../lib/active_merchant'
 
+begin
+  if respond_to? :gem
+    gem 'actionpack'
+  else
+    require_gem 'actionpack'
+  end
+rescue LoadError
+  raise StandardError, "The view tests need ActionPack installed as gem to run"
+end
+
+require 'action_controller'
+require 'action_controller/test_process'
+require 'active_merchant/billing/integrations/action_view_helper'
+
 ActiveMerchant::Billing::Base.mode = :test
 
-module Test
-  module Unit
-    class TestCase
-      LOCAL_CREDENTIALS = ENV['HOME'] + '/.active_merchant/fixtures.yml' unless defined?(LOCAL_CREDENTIALS)
-      DEFAULT_CREDENTIALS = File.dirname(__FILE__) + '/fixtures.yml' unless defined?(DEFAULT_CREDENTIALS)
-      
-      include ActiveMerchant::Billing
+module ActiveMerchant
+  module Assertions
+    def assert_field(field, value)
+      clean_backtrace do 
+        assert_equal value, @helper.fields[field]
+      end
+    end
     
-      # Allows the testing of you to check for negative assertions: 
-      # 
-      #   # Instead of
-      #   assert !something_that_is_false
-      # 
-      #   # Do this
-      #   assert_false something_that_should_be_false
-      # 
-      # An optional +msg+ parameter is available to help you debug.
-      def assert_false(boolean, message = nil)
-        message = build_message message, '<?> is not false or nil.', boolean
+    # Allows the testing of you to check for negative assertions: 
+    # 
+    #   # Instead of
+    #   assert !something_that_is_false
+    # 
+    #   # Do this
+    #   assert_false something_that_should_be_false
+    # 
+    # An optional +msg+ parameter is available to help you debug.
+    def assert_false(boolean, message = nil)
+      message = build_message message, '<?> is not false or nil.', boolean
+    
+      clean_backtrace do
         assert_block message do
           not boolean
         end
       end
-          
-      # A handy little assertion to check for a successful response: 
-      # 
-      #   # Instead of
-      #   assert_success response
-      # 
-      #   # DRY that up with
-      #   assert_success response
-      # 
-      # A message will automatically show the inspection of the response 
-      # object if things go afoul.
-      def assert_success(response)
+    end
+    
+    # A handy little assertion to check for a successful response: 
+    # 
+    #   # Instead of
+    #   assert_success response
+    # 
+    #   # DRY that up with
+    #   assert_success response
+    # 
+    # A message will automatically show the inspection of the response 
+    # object if things go afoul.
+    def assert_success(response)
+      clean_backtrace do
         assert response.success?, "Response failed: #{response.inspect}"
       end
-      
-      # The negative of +assert_success+
-      def assert_failure(response)
+    end
+    
+    # The negative of +assert_success+
+    def assert_failure(response)
+      clean_backtrace do
         assert_false response.success?, "Response expected to fail: #{response.inspect}"
       end
+    end
     
-      private
-      def generate_order_id
-        md5 = Digest::MD5.new
-        now = Time.now
-        md5 << now.to_s
-        md5 << String(now.usec)
-        md5 << String(rand(0))
-        md5 << String($$)
-        md5 << self.class.name
-        md5.hexdigest
+    def assert_valid(validateable)
+      clean_backtrace do
+        assert validateable.valid?, "Expected to be valid"
+      end
+    end
+    
+    def assert_not_valid(validateable)
+      clean_backtrace do
+        assert_false validateable.valid?, "Expected to not be valid"
       end
+    end
+    
+    private
+    def clean_backtrace(&block)
+      yield
+    rescue Test::Unit::AssertionFailedError => e
+      path = File.expand_path(__FILE__)
+      raise Test::Unit::AssertionFailedError, e.message, e.backtrace.reject { |line| File.expand_path(line) =~ /#{path}/ }
+    end
+  end
+end
+
+module Test
+  module Unit
+    class TestCase
+      LOCAL_CREDENTIALS = ENV['HOME'] + '/.active_merchant/fixtures.yml' unless defined?(LOCAL_CREDENTIALS)
+      DEFAULT_CREDENTIALS = File.dirname(__FILE__) + '/fixtures.yml' unless defined?(DEFAULT_CREDENTIALS)
       
-      def credit_card(number, options = {})
+      include ActiveMerchant::Billing
+      include ActiveMerchant::Assertions
+      include ActiveMerchant::Utils
+
+      private
+      def credit_card(number = '4242424242424242', options = {})
         defaults = {
           :number => number,
           :month => 9,
           :year => Time.now.year + 1,
           :first_name => 'Longbob',
           :last_name => 'Longsen',
-          :verification_value => '123'
+          :verification_value => '123',
+          :type => 'visa'
         }.update(options)
 
         ActiveMerchant::Billing::CreditCard.new(defaults)
       end
       
+      def address(options = {})
+        { 
+          :name => 'Jim Smith',
+          :address1 => '1234 My Street',
+          :address2 => 'Apt 1',
+          :company => 'Widgets Inc',
+          :city => 'Ottawa',
+          :state => 'ON',
+          :zip => 'K1C2N6',
+          :country => 'CA',
+          :phone => '(555)555-5555'
+        }.update(options)
+      end
+      
       def all_fixtures
         @@fixtures ||= load_fixtures
       end
@@ -112,21 +169,5 @@ module Test
         hash.each{|k,v| symbolize_keys(v)}
       end
     end
-
-    module Assertions
-      def assert_field(field, value)
-        clean_backtrace do 
-          assert_equal value, @helper.fields[field]
-        end
-      end
-
-      private
-      def clean_backtrace(&block)
-        yield
-      rescue AssertionFailedError => e
-        path = File.expand_path(__FILE__)
-        raise AssertionFailedError, e.message, e.backtrace.reject { |line| File.expand_path(line) =~ /#{path}/ }
-      end
-    end
   end
 end

data/test/unit/avs_result_test.rb

@@ -0,0 +1,59 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+class AVSResultTest < Test::Unit::TestCase
+  def test_nil
+    result = AVSResult.new(nil)
+  end
+  
+  def test_no_match
+    result = AVSResult.new(:code => 'N')
+    assert_equal 'N', result.code
+    assert_equal 'N', result.street_match
+    assert_equal 'N', result.postal_match
+    assert_equal AVSResult.messages['N'], result.message
+  end
+  
+  def test_only_street_match
+    result = AVSResult.new(:code => 'A')
+    assert_equal 'A', result.code
+    assert_equal 'Y', result.street_match
+    assert_equal 'N', result.postal_match
+    assert_equal AVSResult.messages['A'], result.message
+  end
+  
+  def test_only_postal_match
+    result = AVSResult.new(:code => 'W')
+    assert_equal 'W', result.code
+    assert_equal 'N', result.street_match
+    assert_equal 'Y', result.postal_match
+    assert_equal AVSResult.messages['W'], result.message
+  end
+  
+  def test_nil_data
+    result = AVSResult.new(:code => nil)
+    assert_nil result.code
+    assert_nil result.message
+  end
+  
+  def test_empty_data
+    result = AVSResult.new(:code => '')
+    assert_nil result.code
+    assert_nil result.message
+  end
+  
+  def test_to_hash
+    avs_data = AVSResult.new(:code => 'X').to_hash
+    assert_equal 'X', avs_data['code']
+    assert_equal AVSResult.messages['X'], avs_data['message']
+  end
+  
+  def test_street_match
+    avs_data = AVSResult.new(:street_match => 'Y')
+    assert_equal 'Y', avs_data.street_match
+  end
+  
+  def test_postal_match
+    avs_data = AVSResult.new(:postal_match => 'Y')
+    assert_equal 'Y', avs_data.postal_match
+  end
+end

data/test/unit/base_test.rb

@@ -8,54 +8,48 @@ class BaseTest < Test::Unit::TestCase
   def teardown
     ActiveMerchant::Billing::Base.mode = :test
   end
-
-  def test_get_gateway_by_name
-    assert_equal BogusGateway, Base.gateway(:bogus)
-  end
-
-  def test_get_moneris_by_name
-    assert_equal MonerisGateway, Base.gateway(:moneris)
-  end
-
-  def test_get_authorize_net_by_name
-    assert_equal AuthorizeNetGateway, Base.gateway(:authorize_net)
-  end
-
-  def test_get_usay_epay_by_name
-    assert_equal UsaEpayGateway, Base.gateway(:usa_epay)
-  end
-  
-  def test_get_linkpoint_by_name
-    assert_equal LinkpointGateway, Base.gateway(:linkpoint)
-  end
   
-  def test_get_authorize_net_deprecated
+  def test_should_return_a_new_gateway_specified_by_symbol_name
+    assert_equal BogusGateway,         Base.gateway(:bogus)
+    assert_equal MonerisGateway,       Base.gateway(:moneris) 
+    assert_equal AuthorizeNetGateway,  Base.gateway(:authorize_net)
+    assert_equal UsaEpayGateway,       Base.gateway(:usa_epay)
+    assert_equal LinkpointGateway,     Base.gateway(:linkpoint)
     assert_equal AuthorizedNetGateway, Base.gateway(:authorized_net)
   end
 
-  def test_get_integration
+  def test_should_return_an_integration_by_name
     chronopay = Base.integration(:chronopay)
-    assert_equal ActiveMerchant::Billing::Integrations::Chronopay, chronopay
-    assert_instance_of ActiveMerchant::Billing::Integrations::Chronopay::Notification, chronopay.notification('name=cody')
+    
+    assert_equal Integrations::Chronopay, chronopay
+    assert_instance_of Integrations::Chronopay::Notification, chronopay.notification('name=cody')
   end
 
-  def test_set_modes
-    ActiveMerchant::Billing::Base.mode = :test
-    assert_equal :test, ActiveMerchant::Billing::Base.mode
-    assert_equal :test, ActiveMerchant::Billing::Base.gateway_mode
-    assert_equal :test, ActiveMerchant::Billing::Base.integration_mode
+  def test_should_set_modes
+    Base.mode = :test
+    assert_equal :test, Base.mode
+    assert_equal :test, Base.gateway_mode
+    assert_equal :test, Base.integration_mode
 
-    ActiveMerchant::Billing::Base.mode = :production
-    assert_equal :production, ActiveMerchant::Billing::Base.mode
-    assert_equal :production, ActiveMerchant::Billing::Base.gateway_mode
-    assert_equal :production, ActiveMerchant::Billing::Base.integration_mode
+    Base.mode = :production
+    assert_equal :production, Base.mode
+    assert_equal :production, Base.gateway_mode
+    assert_equal :production, Base.integration_mode
 
-    ActiveMerchant::Billing::Base.mode = :development
-    ActiveMerchant::Billing::Base.gateway_mode = :test
-    ActiveMerchant::Billing::Base.integration_mode = :staging
-    assert_equal :development, ActiveMerchant::Billing::Base.mode
-    assert_equal :test, ActiveMerchant::Billing::Base.gateway_mode
-    assert_equal :staging, ActiveMerchant::Billing::Base.integration_mode
+    Base.mode             = :development
+    Base.gateway_mode     = :test
+    Base.integration_mode = :staging
+    assert_equal :development, Base.mode
+    assert_equal :test,        Base.gateway_mode
+    assert_equal :staging,     Base.integration_mode
+  end
+  
+  def test_should_identify_if_test_mode
+    Base.gateway_mode = :test
+    assert Base.test?
+    
+    Base.gateway_mode = :production
+    assert_false Base.test?
   end
 
 end

data/test/unit/check_test.rb

@@ -0,0 +1,76 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+class CheckTest < Test::Unit::TestCase
+  include ActiveMerchant::Billing
+  
+  VALID_ABA     = '111000025'
+  INVALID_ABA   = '999999999'
+  MALFORMED_ABA = 'I like fish'
+  
+  ACCOUNT_NUMBER = '123456789012'
+  
+  def test_validation
+    c = Check.new
+    assert !c.valid?
+    assert !c.errors.empty?
+  end
+  
+  def test_valid
+    c = Check.new(:name => 'Fred Bloggs',
+                  :routing_number => VALID_ABA,
+                  :account_number => ACCOUNT_NUMBER,
+                  :account_holder_type => 'personal',
+                  :account_type => 'checking')
+    assert c.valid?
+  end
+  
+  def test_invalid_routing_number
+    c = Check.new(:routing_number => INVALID_ABA)
+    assert !c.valid?
+    assert_equal c.errors.on(:routing_number), "is invalid"
+  end
+  
+  def test_malformed_routing_number
+    c = Check.new(:routing_number => MALFORMED_ABA)
+    assert !c.valid?
+    assert_equal c.errors.on(:routing_number), "is invalid"
+  end
+  
+  def test_account_holder_type
+    c = Check.new
+    c.account_holder_type = 'business'
+    c.valid?
+    assert !c.errors.on(:account_holder_type)
+    
+    c.account_holder_type = 'personal'
+    c.valid?
+    assert !c.errors.on(:account_holder_type)
+    
+    c.account_holder_type = 'pleasure'
+    c.valid?
+    assert_equal c.errors.on(:account_holder_type), 'must be personal or business'
+    
+    c.account_holder_type = nil
+    c.valid?
+    assert !c.errors.on(:account_holder_type)
+  end
+  
+  def test_account_type
+    c = Check.new
+    c.account_type = 'checking'
+    c.valid?
+    assert !c.errors.on(:account_type)
+    
+    c.account_type = 'savings'
+    c.valid?
+    assert !c.errors.on(:account_type)
+    
+    c.account_type = 'moo'
+    c.valid?
+    assert_equal c.errors.on(:account_type), "must be checking or savings"
+    
+    c.account_type = nil
+    c.valid?
+    assert !c.errors.on(:account_type)
+  end
+end

data/test/unit/credit_card_formatting_test.rb

@@ -3,22 +3,17 @@ require File.dirname(__FILE__) + '/../test_helper'
 class CreditCardFormattingTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::CreditCardFormatting
   
-  def test_format_expiry_year
-    year = 2005
+  def test_should_format_number_by_rule
+    assert_equal 2005, format(2005, :steven_colbert)
     
-    assert_equal '05', format(year, :two_digits)
-    assert_equal '2005', format(year, :four_digits)
-    assert_equal '05', format(05, :two_digits)
     assert_equal '0005', format(05, :four_digits)
-  end
-
-  def test_format_expiry_month
-    month = 8
-    assert_equal '08', format(month, :two_digits)
-  end
-  
-  def test_format_empty_numbers
-    assert_equal '', format(nil, :two_digits)
-    assert_equal '', format('', :two_digits)
+    assert_equal '2005', format(2005, :four_digits)
+    
+    assert_equal '05', format(2005, :two_digits)
+    assert_equal '05', format(05, :two_digits)
+    assert_equal '08', format(8, :two_digits)
+    
+    assert format(nil, :two_digits).blank?
+    assert format('', :two_digits).blank?
   end
 end