activemerchant 1.2.1 → 1.3.0

data/lib/active_merchant/billing/gateways/verifi.rb

@@ -4,7 +4,7 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class VerifiGateway < Gateway 
       class VerifiPostData < PostData
-        # Fields that will be send even if they are blank
+        # Fields that will be sent even if they are blank
         self.required_fields = [ :amount, :type, :ccnumber, :ccexp, :firstname, :lastname,
           :company, :address1, :address2, :city, :state, :zip, :country, :phone ]   
       end
@@ -62,23 +62,19 @@ module ActiveMerchant #:nodoc:
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
       self.homepage_url = 'http://www.verifi.com/'
       self.display_name = 'Verifi'
-                               
-      attr_reader :url 
-      attr_reader :response
-      attr_reader :options
-	                               
+
     	def initialize(options = {})
         requires!(options, :login, :password)
         @options = options
         super
     	end
 
-      def purchase(money, creditcard, options = {})
-        sale_authorization_or_credit_template(:purchase, money, creditcard, options)
+      def purchase(money, credit_card, options = {})
+        sale_authorization_or_credit_template(:purchase, money, credit_card, options)
       end
 
-      def authorize(money, creditcard, options = {})
-        sale_authorization_or_credit_template(:authorization, money, creditcard, options)
+      def authorize(money, credit_card, options = {})
+        sale_authorization_or_credit_template(:authorization, money, credit_card, options)
       end
                        
       def capture(money, authorization, options = {})
@@ -89,20 +85,20 @@ module ActiveMerchant #:nodoc:
         capture_void_or_refund_template(:void, 0, authorization, options)
       end
       
-      def credit(money, creditcard_or_authorization, options = {})
-        if creditcard_or_authorization.is_a?(String)
-          capture_void_or_refund_template(:refund, money, creditcard_or_authorization, options)
+      def credit(money, credit_card_or_authorization, options = {})
+        if credit_card_or_authorization.is_a?(String)
+          capture_void_or_refund_template(:refund, money, credit_card_or_authorization, options)
         else
-          sale_authorization_or_credit_template(:credit, money, creditcard_or_authorization, options)
+          sale_authorization_or_credit_template(:credit, money, credit_card_or_authorization, options)
         end
       end
 
       private  
              
-      def sale_authorization_or_credit_template(trx_type, money, creditcard, options = {})
+      def sale_authorization_or_credit_template(trx_type, money, credit_card, options = {})
         post = VerifiPostData.new
         add_security_key_data(post, options, money)
-        add_creditcard(post, creditcard)
+        add_credit_card(post, credit_card)
         add_addresses(post, options)
         add_customer_data(post, options)
         add_invoice_data(post, options)
@@ -117,17 +113,17 @@ module ActiveMerchant #:nodoc:
         commit(trx_type, money, post)
       end
                     
-      def add_creditcard(post, creditcard)
-        post[:ccnumber]  = creditcard.number
-        post[:ccexp]     = expdate(creditcard)
-        post[:firstname] = creditcard.first_name
-        post[:lastname]  = creditcard.last_name      
-        post[:cvv]       = creditcard.verification_value
+      def add_credit_card(post, credit_card)
+        post[:ccnumber]  = credit_card.number
+        post[:ccexp]     = expdate(credit_card)
+        post[:firstname] = credit_card.first_name
+        post[:lastname]  = credit_card.last_name      
+        post[:cvv]       = credit_card.verification_value
       end      
                  
-      def expdate(creditcard)
-        year  = sprintf("%.4i", creditcard.year)
-        month = sprintf("%.2i", creditcard.month)
+      def expdate(credit_card)
+        year  = sprintf("%.4i", credit_card.year)
+        month = sprintf("%.2i", credit_card.month)
 
         "#{month}#{year[-2..-1]}"
       end
@@ -145,7 +141,7 @@ module ActiveMerchant #:nodoc:
           post[:fax]        = billing_address[:fax]             
         end
         
-        if shipping_address = options[:shipping_address] || billing_address
+        if shipping_address = options[:shipping_address]
           post[:shipping_firstname] = shipping_address[:first_name]
           post[:shipping_lastname]  = shipping_address[:last_name]  
           post[:shipping_company]   = shipping_address[:company]    
@@ -197,24 +193,21 @@ module ActiveMerchant #:nodoc:
       end                  
                                                     
       def commit(trx_type, money, post)
-          
         post[:amount] = amount(money)
         
-        if result = test_result_from_cc_number(post[:ccnumber])
-          return result
-        end
-                                                                            
-        data = ssl_post(URL, post_data(trx_type, post), 'Content-type' => "application/x-www-form-urlencoded")
-        @response = parse(data)
-                          
-        success = @response[:response].to_i == SUCCESS
-        message = @response[:response_code_message] ? @response[:response_code_message] : "" 
-    
-        Response.new(success, message, @response,
+        response = parse( ssl_post(URL, post_data(trx_type, post)) )
+                         
+        Response.new(response[:response].to_i == SUCCESS, message_from(response), response,
           :test => test?,
-          :authorization => @response[:transactionid]
+          :authorization => response[:transactionid],
+          :avs_result => { :code => response[:avsresponse] },
+          :cvv_result => response[:cvvresponse]
         )
       end
+      
+      def message_from(response)
+        response[:response_code_message] ? response[:response_code_message] : ""
+      end
                                                       
       def parse(body)
         results = {}

data/lib/active_merchant/billing/gateways/viaklix.rb

@@ -42,7 +42,7 @@ module ActiveMerchant #:nodoc:
       # Viaklix does not support credits by reference. You must pass in the credit card
       def credit(money, creditcard, options = {})
         if creditcard.is_a?(String)
-          raise ArgumentError, "Reference credits are not supported.  Please supply the original credit card"
+          raise ArgumentError, "Reference credits are not supported. Please supply the original credit card"
         end
         
         form = {}
@@ -55,39 +55,39 @@ module ActiveMerchant #:nodoc:
       
       private
       def add_customer_data(form, options)
-        form[:email] = options[:email] unless options[:email].blank?
+        form[:email] = options[:email].to_s.slice(0, 100) unless options[:email].blank?
         form[:customer_code] = options[:customer].to_s.slice(0, 17) unless options[:customer].blank?
       end
       
       def add_invoice(form,options)
-        form[:invoice_number] = options[:order_id] || options[:invoice]
+        form[:invoice_number] = (options[:order_id] || options[:invoice]).to_s.slice(0, 10)
+        form[:description] = options[:description].to_s.slice(0, 255)
       end
       
       def add_address(form,options)
         billing_address = options[:billing_address] || options[:address] 
         
         if billing_address
-          form[:avs_address]    = billing_address[:address1]
-          form[:avs_zip]        = billing_address[:zip]
-          form[:city]           = billing_address[:city]
-          form[:state]          = billing_address[:state]
-          form[:company]        = billing_address[:company]
-          form[:phone]          = billing_address[:phone]
-          form[:country]        = billing_address[:country]
+          form[:avs_address]    = billing_address[:address1].to_s.slice(0, 30)
+          form[:address2]       = billing_address[:address2].to_s.slice(0, 30)
+          form[:avs_zip]        = billing_address[:zip].to_s.slice(0, 10)
+          form[:city]           = billing_address[:city].to_s.slice(0, 30)
+          form[:state]          = billing_address[:state].to_s.slice(0, 10)
+          form[:company]        = billing_address[:company].to_s.slice(0, 50)
+          form[:phone]          = billing_address[:phone].to_s.slice(0, 20)
+          form[:country]        = billing_address[:country].to_s.slice(0, 50)
         end
-        
-        shipping_address = options[:shipping_address] || billing_address
-        
-        if shipping_address
+                
+        if shipping_address = options[:shipping_address]
           first_name, last_name = parse_first_and_last_name(shipping_address[:name])
-          form[:ship_to_first_name]     = first_name
-          form[:ship_to_last_name]      = last_name
-          form[:ship_to_address]        = shipping_address[:address1]
-          form[:ship_to_city]           = shipping_address[:city]
-          form[:ship_to_state]          = shipping_address[:state]
-          form[:ship_to_company]        = shipping_address[:company]
-          form[:ship_to_country]        = shipping_address[:country]
-          form[:ship_to_zip]            = shipping_address[:zip]
+          form[:ship_to_first_name]     = first_name.to_s.slice(0, 20)
+          form[:ship_to_last_name]      = last_name.to_s.slice(0, 30)
+          form[:ship_to_address]        = shipping_address[:address1].to_s.slice(0, 30)
+          form[:ship_to_city]           = shipping_address[:city].to_s.slice(0, 30)
+          form[:ship_to_state]          = shipping_address[:state].to_s.slice(0, 10)
+          form[:ship_to_company]        = shipping_address[:company].to_s.slice(0, 50)
+          form[:ship_to_country]        = shipping_address[:country].to_s.slice(0, 50)
+          form[:ship_to_zip]            = shipping_address[:zip].to_s.slice(0, 10)
         end
       end
       
@@ -108,8 +108,8 @@ module ActiveMerchant #:nodoc:
           form[:cvv2] = 'present'
         end
         
-        form[:first_name] = creditcard.first_name
-        form[:last_name] = creditcard.last_name        
+        form[:first_name] = creditcard.first_name.to_s.slice(0, 20)
+        form[:last_name] = creditcard.last_name.to_s.slice(0, 30)
       end
       
       def preamble
@@ -126,22 +126,16 @@ module ActiveMerchant #:nodoc:
       end
       
       def commit(action, money, parameters)
-        if result = test_result_from_cc_number(parameters[:card_number])
-          return result
-        end
-        
         parameters[:amount] = amount(money)
         parameters[:transaction_type] = action
             
-        msg = ssl_post(test? ? TEST_URL : LIVE_URL, post_data(parameters))
-        
-        @response = parse(msg)
-        success = @response['result'] == APPROVED
-        message = @response['result_message']
-        
-        Response.new(success, message, @response, 
+        response = parse( ssl_post(test? ? TEST_URL : LIVE_URL, post_data(parameters)) )
+
+        Response.new(response['result'] == APPROVED, response['result_message'], response, 
           :test => @options[:test] || test?, 
-          :authorization => @response['txn_id']
+          :authorization => response['txn_id'],
+          :avs_result => { :code => response['avs_response'] },
+          :cvv_result => response['cvv2_response']
         )
       end
       
@@ -159,7 +153,7 @@ module ActiveMerchant #:nodoc:
       
       # Parse the response message
       def parse(msg)
-        resp = Hash.new;
+        resp = {}
         msg.split("\r\n").collect{|li|
             key, value = li.split("=")
             resp[key.gsub(/^ssl_/, '')] = value.to_s.strip

data/lib/active_merchant/billing/integrations.rb

@@ -1,11 +1,13 @@
 require 'active_merchant/billing/integrations/notification'
 require 'active_merchant/billing/integrations/helper'
+require 'active_merchant/billing/integrations/return'
 require 'active_merchant/billing/integrations/bogus'
 require 'active_merchant/billing/integrations/chronopay'
 require 'active_merchant/billing/integrations/paypal'
 require 'active_merchant/billing/integrations/nochex'
 require 'active_merchant/billing/integrations/gestpay'
 require 'active_merchant/billing/integrations/two_checkout'
+require 'active_merchant/billing/integrations/hi_trust'
 
 # make the bogus gateway be classified correctly by the inflector
 Inflector.inflections do |inflect|

data/lib/active_merchant/billing/integrations/bogus.rb

@@ -1,5 +1,6 @@
 require 'active_merchant/billing/integrations/bogus/helper.rb'
 require 'active_merchant/billing/integrations/bogus/notification.rb'
+require 'active_merchant/billing/integrations/bogus/return.rb'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -11,6 +12,10 @@ module ActiveMerchant #:nodoc:
         def self.notification(post)
           Notification.new(post)
         end
+        
+        def self.return(query_string)
+          Return.new(query_string)
+        end
       end
     end
   end

data/lib/active_merchant/billing/integrations/bogus/return.rb

@@ -0,0 +1,10 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module Integrations #:nodoc:
+      module Bogus
+        class Return < ActiveMerchant::Billing::Integrations::Return
+	      end
+      end
+    end
+  end
+end

data/lib/active_merchant/billing/integrations/chronopay.rb

@@ -1,5 +1,6 @@
 require 'active_merchant/billing/integrations/chronopay/helper.rb'
 require 'active_merchant/billing/integrations/chronopay/notification.rb'
+require 'active_merchant/billing/integrations/chronopay/return.rb'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -11,6 +12,10 @@ module ActiveMerchant #:nodoc:
         def self.notification(post)
           Notification.new(post)
         end
+        
+        def self.return(query_string)
+          Return.new(query_string)
+        end
       end
     end
   end

data/lib/active_merchant/billing/integrations/chronopay/return.rb

@@ -0,0 +1,10 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module Integrations #:nodoc:
+      module Chronopay
+        class Return < ActiveMerchant::Billing::Integrations::Return
+	      end
+      end
+    end
+  end
+end

data/lib/active_merchant/billing/integrations/gestpay.rb

@@ -3,6 +3,7 @@
 require File.dirname(__FILE__) + '/gestpay/common.rb'
 require File.dirname(__FILE__) + '/gestpay/helper.rb'
 require File.dirname(__FILE__) + '/gestpay/notification.rb'
+require File.dirname(__FILE__) + '/gestpay/return.rb'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -15,6 +16,10 @@ module ActiveMerchant #:nodoc:
         def self.notification(post)
           Notification.new(post)
         end  
+        
+        def self.return(query_string)
+          Return.new(query_string)
+        end
       end
     end
   end

data/lib/active_merchant/billing/integrations/gestpay/return.rb

@@ -0,0 +1,10 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module Integrations #:nodoc:
+      module Gestpay
+        class Return < ActiveMerchant::Billing::Integrations::Return
+	      end
+      end
+    end
+  end
+end

data/lib/active_merchant/billing/integrations/hi_trust.rb

@@ -0,0 +1,26 @@
+require File.dirname(__FILE__) + '/hi_trust/helper.rb'
+require File.dirname(__FILE__) + '/hi_trust/notification.rb'
+require File.dirname(__FILE__) + '/hi_trust/return.rb'
+
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module Integrations #:nodoc:
+      module HiTrust 
+        TEST_URL = 'https://testtrustlink.hitrust.com.tw/TrustLink/TrxReq'
+        LIVE_URL = 'https://trustlink.hitrust.com.tw/TrustLink/TrxReq'
+        
+        def self.service_url
+          ActiveMerchant::Billing::Base.integration_mode == :test ? TEST_URL : LIVE_URL
+        end
+
+        def self.notification(post)
+          Notification.new(post)
+        end
+        
+        def self.return(query_string)
+          Return.new(query_string)
+        end  
+      end
+    end
+  end
+end

data/lib/active_merchant/billing/integrations/hi_trust/helper.rb

@@ -0,0 +1,58 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module Integrations #:nodoc:
+      module HiTrust
+        class Helper < ActiveMerchant::Billing::Integrations::Helper
+          
+          # Transaction types
+          # * Auth
+          # * AuthRe
+          # * Capture
+          # * CaptureRe
+          # * Refund
+          # * RefundRe
+          # * Query
+          def initialize(order, account, options = {})
+            super  
+            # Perform an authorization by default
+            add_field('Type', 'Auth')
+            
+            # Capture the payment right away
+            add_field('depositflag', '1')
+            
+            # Disable auto query - who knows what it does?
+            add_field('queryflag', '1')
+            
+            add_field('orderdesc', 'Store purchase')
+          end
+          
+          mapping :account, 'storeid'
+          mapping :amount, 'amount'
+          
+          def amount=(money)
+            cents = money.respond_to?(:cents) ? money.cents : money 
+
+            if money.is_a?(String) or cents.to_i < 0
+              raise ArgumentError, 'money amount must be either a Money object or a positive integer in cents.' 
+            end
+            
+            add_field(mappings[:amount], cents)
+          end
+          # Supported currencies include:
+          # * CNY：Chinese Yuan (Renminbi)
+          # * TWD：New Taiwan Dollar 
+          # * HKD：Hong Kong Dollar 
+          # * USD：US Dollar 
+          # * AUD：Austrian Dollar 
+          mapping :currency, 'currency'
+        
+          mapping :order, 'ordernumber'
+          mapping :description, 'orderdesc'
+
+          mapping :notify_url, 'merUpdateURL'
+          mapping :return_url, 'returnURL'
+        end
+      end
+    end
+  end
+end

data/lib/active_merchant/billing/integrations/hi_trust/notification.rb

@@ -0,0 +1,57 @@
+require 'net/http'
+
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module Integrations #:nodoc:
+      module HiTrust
+        class Notification < ActiveMerchant::Billing::Integrations::Notification
+          SUCCESS = '00'
+          
+          def complete?
+            status == 'Completed'
+          end 
+
+          def transaction_id
+            params['authRRN']
+          end
+          
+          def item_id
+            params['ordernumber']
+          end
+          
+          def received_at
+            Time.parse(params['orderdate']) rescue nil
+          end
+          
+          def currency
+            params['currency']
+          end
+
+          def gross
+            params['approveamount']
+          end
+          
+          def gross_cents
+            gross.to_i
+          end
+          
+          def account
+            params['storeid']
+          end
+
+          def status
+            params['retcode'] == SUCCESS ? 'Completed' : 'Failed'
+          end
+          
+          def test?
+            ActiveMerchant::Billing::Base.integration_mode == :test
+          end
+    
+          def acknowledge      
+            true
+          end
+        end
+      end
+    end
+  end
+end