activemerchant 1.133.0 → 1.138.0

data/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     # This module is included in both PaypalGateway and PaypalExpressGateway
     module PaypalCommonAPI
       include Empty
@@ -7,13 +7,6 @@ module ActiveMerchant #:nodoc:
       API_VERSION = '124'
       API_VERSION_3DS2 = '214.0'
 
-      URLS = {
-        :test => { :certificate => 'https://api.sandbox.paypal.com/2.0/',
-                   :signature   => 'https://api-3t.sandbox.paypal.com/2.0/' },
-        :live => { :certificate => 'https://api.paypal.com/2.0/',
-                   :signature   => 'https://api-3t.paypal.com/2.0/' }
-      }
-
       PAYPAL_NAMESPACE = 'urn:ebay:api:PayPalAPI'
       EBAY_NAMESPACE = 'urn:ebay:apis:eBLBaseComponents'
 
@@ -59,8 +52,6 @@ module ActiveMerchant #:nodoc:
         base.default_currency = 'USD'
         base.cattr_accessor :pem_file
         base.cattr_accessor :signature
-        base.live_url = URLS[:live][:signature]
-        base.test_url = URLS[:test][:signature]
       end
 
       # The gateway must be configured with either your PayPal PEM file
@@ -96,6 +87,15 @@ module ActiveMerchant #:nodoc:
         super(options)
       end
 
+      def urls
+        {
+          :test => { :certificate => "https://api.sandbox.paypal.com/#{fetch_version}/",
+                    :signature   => "https://api-3t.sandbox.paypal.com/#{fetch_version}/" },
+          :live => { :certificate => "https://api.paypal.com/#{fetch_version}/",
+                    :signature   => "https://api-3t.paypal.com/#{fetch_version}/" }
+        }
+      end
+
       def reauthorize(money, authorization, options = {})
         commit 'DoReauthorization', build_reauthorize_request(money, authorization, options)
       end
@@ -179,6 +179,11 @@ module ActiveMerchant #:nodoc:
       #     . (period)
       #     {space}
       #
+
+      def inquire(authorization, options = {})
+        transaction_details(authorization)
+      end
+
       def reference_transaction(money, options = {})
         requires!(options, :reference_id)
         commit 'DoReferenceTransaction', build_reference_transaction_request(money, options)
@@ -656,7 +661,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def endpoint_url
-        URLS[test? ? :test : :live][@options[:signature].blank? ? :certificate : :signature]
+        urls[test? ? :test : :live][@options[:signature].blank? ? :certificate : :signature]
       end
 
       def commit(action, request)

data/lib/active_merchant/billing/gateways/paypal/paypal_express_response.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaypalExpressResponse < Response
       def email
         info['Payer']

data/lib/active_merchant/billing/gateways/paypal/paypal_recurring_api.rb

@@ -1,7 +1,7 @@
 require 'active_merchant/billing/gateways/paypal/paypal_common_api'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     # This module is included in both PaypalGateway and PaypalExpressGateway
     module PaypalRecurringApi
       PAYPAL_NAMESPACE = ActiveMerchant::Billing::PaypalCommonAPI::PAYPAL_NAMESPACE

data/lib/active_merchant/billing/gateways/paypal.rb

@@ -2,9 +2,11 @@ require 'active_merchant/billing/gateways/paypal/paypal_common_api'
 require 'active_merchant/billing/gateways/paypal/paypal_recurring_api'
 require 'active_merchant/billing/gateways/paypal_express'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaypalGateway < Gateway
+      version '2.0'
+
       include PaypalCommonAPI
       include PaypalRecurringApi
 

data/lib/active_merchant/billing/gateways/paypal_ca.rb

@@ -1,7 +1,7 @@
 require 'active_merchant/billing/gateways/paypal'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     # The PayPal gateway for PayPal Website Payments Pro Canada only supports Visa and MasterCard
     class PaypalCaGateway < PaypalGateway
       self.supported_cardtypes = %i[visa master]

data/lib/active_merchant/billing/gateways/paypal_digital_goods.rb

@@ -2,8 +2,8 @@ require 'active_merchant/billing/gateways/paypal/paypal_common_api'
 require 'active_merchant/billing/gateways/paypal/paypal_express_response'
 require 'active_merchant/billing/gateways/paypal_express_common'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaypalDigitalGoodsGateway < PaypalExpressGateway
       self.test_redirect_url = 'https://www.sandbox.paypal.com/incontext'
       self.live_redirect_url = 'https://www.paypal.com/incontext'

data/lib/active_merchant/billing/gateways/paypal_express.rb

@@ -3,9 +3,11 @@ require 'active_merchant/billing/gateways/paypal/paypal_express_response'
 require 'active_merchant/billing/gateways/paypal/paypal_recurring_api'
 require 'active_merchant/billing/gateways/paypal_express_common'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaypalExpressGateway < Gateway
+      version '2.0'
+
       include PaypalCommonAPI
       include PaypalExpressCommon
       include PaypalRecurringApi

data/lib/active_merchant/billing/gateways/paysafe.rb

@@ -1,6 +1,8 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaysafeGateway < Gateway
+      version 'v1'
+
       self.test_url = 'https://api.test.paysafe.com'
       self.live_url = 'https://api.paysafe.com'
 
@@ -58,6 +60,9 @@ module ActiveMerchant #:nodoc:
         post = {}
         add_invoice(post, money, options)
         add_payment(post, payment)
+        add_customer_data(post, payment, options) unless payment.is_a?(String)
+        add_merchant_details(post, options)
+        add_billing_address(post, options)
 
         commit(:post, 'standalonecredits', post, options)
       end
@@ -74,12 +79,28 @@ module ActiveMerchant #:nodoc:
 
       def store(payment, options = {})
         post = {}
-        add_payment(post, payment)
-        add_address_for_vaulting(post, options)
-        add_profile_data(post, payment, options)
-        add_store_data(post, payment, options)
 
-        commit(:post, 'profiles', post, options)
+        if options[:profile_id]
+          post[:cardNum] = payment.number
+          post[:cardExpiry] = {
+            month: payment.month,
+            year: payment.year
+          }
+          post[:accountId] = options[:account_id] if options[:account_id]
+          post[:nickName] = options[:nickname] if options[:nickname]
+          post[:holderName] = payment.name
+          post[:billingAddressId] = options[:billing_address_id] if options[:billing_address_id]
+          post[:defaultCardIndicator] = normalize(options[:default_card_indicator]) if options[:default_card_indicator]
+        else
+          add_payment(post, payment)
+          add_address_for_vaulting(post, options)
+          add_profile_data(post, payment, options)
+          add_store_data(post, payment, options)
+        end
+
+        endpoint = options[:profile_id] ? "profiles/#{options[:profile_id]}/cards" : 'profiles'
+
+        commit(:post, endpoint, post, options)
       end
 
       def unstore(pm_profile_id)
@@ -117,6 +138,7 @@ module ActiveMerchant #:nodoc:
         post[:profile][:firstName] = creditcard.first_name
         post[:profile][:lastName] = creditcard.last_name
         post[:profile][:email] = options[:email] if options[:email]
+        post[:profile][:merchantCustomerId] = options[:customer_id] if options[:customer_id]
         post[:customerIp] = options[:ip] if options[:ip]
       end
 
@@ -124,12 +146,13 @@ module ActiveMerchant #:nodoc:
         return unless address = options[:billing_address] || options[:address]
 
         post[:billingDetails] = {}
-        post[:billingDetails][:street] = address[:address1]
-        post[:billingDetails][:city] = address[:city]
-        post[:billingDetails][:state] = address[:state]
+        post[:billingDetails][:street] = truncate(address[:address1], 50)
+        post[:billingDetails][:street2] = truncate(address[:address2], 50)
+        post[:billingDetails][:city] = truncate(address[:city], 40)
+        post[:billingDetails][:state] = truncate(address[:state], 40)
         post[:billingDetails][:country] = address[:country]
-        post[:billingDetails][:zip] = address[:zip]
-        post[:billingDetails][:phone] = address[:phone]
+        post[:billingDetails][:zip] = truncate(address[:zip], 10)
+        post[:billingDetails][:phone] = truncate(address[:phone], 40)
       end
 
       # The add_address_for_vaulting method is applicable to the store method, as the APIs address
@@ -138,12 +161,12 @@ module ActiveMerchant #:nodoc:
         return unless address = options[:billing_address] || options[:address]
 
         post[:card][:billingAddress] = {}
-        post[:card][:billingAddress][:street] = address[:address1]
-        post[:card][:billingAddress][:street2] = address[:address2]
-        post[:card][:billingAddress][:city] = address[:city]
-        post[:card][:billingAddress][:zip] = address[:zip]
+        post[:card][:billingAddress][:street] = truncate(address[:address1], 50)
+        post[:card][:billingAddress][:street2] = truncate(address[:address2], 50)
+        post[:card][:billingAddress][:city] = truncate(address[:city], 40)
+        post[:card][:billingAddress][:zip] = truncate(address[:zip], 10)
         post[:card][:billingAddress][:country] = address[:country]
-        post[:card][:billingAddress][:state] = address[:state] if address[:state]
+        post[:card][:billingAddress][:state] = truncate(address[:state], 40) if address[:state]
       end
 
       # This data is specific to creating a profile at the gateway's vault level
@@ -151,9 +174,9 @@ module ActiveMerchant #:nodoc:
         post[:firstName] = payment.first_name
         post[:lastName] = payment.last_name
         post[:dateOfBirth] = {}
-        post[:dateOfBirth][:year] = options[:date_of_birth][:year]
-        post[:dateOfBirth][:month] = options[:date_of_birth][:month]
-        post[:dateOfBirth][:day] = options[:date_of_birth][:day]
+        post[:dateOfBirth][:year] = options.dig(:date_of_birth, :year)
+        post[:dateOfBirth][:month] = options.dig(:date_of_birth, :month)
+        post[:dateOfBirth][:day] = options.dig(:date_of_birth, :day)
         post[:email] = options[:email] if options[:email]
         post[:ip] = options[:ip] if options[:ip]
 
@@ -320,6 +343,7 @@ module ActiveMerchant #:nodoc:
         end
 
         post[:storedCredential][:initialTransactionId] = options[:stored_credential][:network_transaction_id] if options[:stored_credential][:network_transaction_id]
+        post[:storedCredential][:externalInitialTransactionId] = options[:external_initial_transaction_id] if options[:external_initial_transaction_id]
       end
 
       def mastercard?(payment)
@@ -363,9 +387,9 @@ module ActiveMerchant #:nodoc:
         base_url = (test? ? test_url : live_url)
 
         if action.include? 'profiles'
-          "#{base_url}/customervault/v1/#{action}"
+          "#{base_url}/customervault/#{fetch_version}/#{action}"
         else
-          "#{base_url}/cardpayments/v1/accounts/#{@options[:account_id]}/#{action}"
+          "#{base_url}/cardpayments/#{fetch_version}/accounts/#{@options[:account_id]}/#{action}"
         end
       end
 
@@ -383,7 +407,7 @@ module ActiveMerchant #:nodoc:
 
       def authorization_from(action, response)
         if action == 'profiles'
-          pm = response['cards'].first['paymentToken']
+          pm = response['cards']&.first&.dig('paymentToken')
           "#{pm}|#{response['id']}"
         else
           response['id']
@@ -401,7 +425,7 @@ module ActiveMerchant #:nodoc:
       def post_data(parameters = {}, options = {})
         return unless parameters.present?
 
-        parameters[:merchantRefNum] = options[:merchant_ref_num] || SecureRandom.hex(16).to_s
+        parameters[:merchantRefNum] = options[:merchant_ref_num] || options[:order_id] || SecureRandom.hex(16).to_s
 
         parameters.to_json
       end

data/lib/active_merchant/billing/gateways/payscout.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PayscoutGateway < Gateway
       self.live_url = self.test_url = 'https://secure.payscout.com/api/transact.php'
 
@@ -115,12 +115,16 @@ module ActiveMerchant #:nodoc:
 
         message = message_from(response)
         test_mode = (test? || message =~ /TESTMODE/)
-        Response.new(success?(response), message, response,
+        Response.new(
+          success?(response),
+          message,
+          response,
           test: test_mode,
           authorization: response['transactionid'],
           fraud_review: fraud_review?(response),
           avs_result: { code: response['avsresponse'] },
-          cvv_result: response['cvvresponse'])
+          cvv_result: response['cvvresponse']
+        )
       end
 
       def message_from(response)
@@ -151,8 +155,7 @@ module ActiveMerchant #:nodoc:
         post[:password]       = @options[:password]
         post[:type]           = action
 
-        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
-        request
+        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/paystation.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaystationGateway < Gateway
       self.live_url = self.test_url = 'https://www.paystation.co.nz/direct/paystation.dll'
 
@@ -177,9 +177,13 @@ module ActiveMerchant #:nodoc:
         response = parse(data)
         message  = message_from(response)
 
-        PaystationResponse.new(success?(response), message, response,
-          test: (response[:tm]&.casecmp('t')&.zero?),
-          authorization: response[:paystation_transaction_id])
+        PaystationResponse.new(
+          success?(response),
+          message,
+          response,
+          test: response[:tm]&.casecmp('t')&.zero?,
+          authorization: response[:paystation_transaction_id]
+        )
       end
 
       def success?(response)

data/lib/active_merchant/billing/gateways/payu_in.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PayuInGateway < Gateway
       self.test_url = 'https://test.payu.in/_payment'
       self.live_url = 'https://secure.payu.in/_payment'

data/lib/active_merchant/billing/gateways/payu_latam.rb

@@ -1,13 +1,15 @@
 require 'digest/md5'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PayuLatamGateway < Gateway
+      version '4.0'
+
       self.display_name = 'PayU Latam'
       self.homepage_url = 'http://www.payulatam.com'
 
-      self.test_url = 'https://sandbox.api.payulatam.com/payments-api/4.0/service.cgi'
-      self.live_url = 'https://api.payulatam.com/payments-api/4.0/service.cgi'
+      self.test_url = "https://sandbox.api.payulatam.com/payments-api/#{fetch_version}/service.cgi"
+      self.live_url = "https://api.payulatam.com/payments-api/#{fetch_version}/service.cgi"
 
       self.supported_countries = %w[AR BR CL CO MX PA PE]
       self.default_currency = 'USD'
@@ -167,7 +169,7 @@ module ActiveMerchant #:nodoc:
         order[:accountId] = @options[:account_id]
         order[:partnerId] = options[:partner_id] if options[:partner_id]
         order[:referenceCode] = options[:order_id] || generate_unique_id
-        order[:description] = options[:description] || 'Compra en ' + @options[:merchant_id]
+        order[:description] = options[:description] || ('Compra en ' + @options[:merchant_id])
         order[:language] = options[:language] || 'en'
         order[:shippingAddress] = shipping_address_fields(options) if options[:shipping_address]
         post[:transaction][:order] = order

data/lib/active_merchant/billing/gateways/payway.rb

@@ -192,9 +192,13 @@ module ActiveMerchant
 
         success = (params[:summary_code] ? (params[:summary_code] == '0') : (params[:response_code] == '00'))
 
-        Response.new(success, message, params,
+        Response.new(
+          success,
+          message,
+          params,
           test: (@options[:merchant].to_s == 'TEST'),
-          authorization: post[:order_number])
+          authorization: post[:order_number]
+        )
       rescue ActiveMerchant::ResponseError => e
         raise unless e.response.code == '403'
 

data/lib/active_merchant/billing/gateways/payway_dot_com.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaywayDotComGateway < Gateway
       self.test_url = 'https://paywaywsdev.com/PaywayWS/Payment/CreditCard'
       self.live_url = 'https://paywayws.net/PaywayWS/Payment/CreditCard'
@@ -48,7 +48,7 @@ module ActiveMerchant #:nodoc:
         'I5'  => 'M', #  +4 and Address Match
         'I6'  => 'W', #  +4 Match
         'I7'  => 'A', #  Address Match
-        'I8'  => 'C', #  No Match
+        'I8'  => 'C' #  No Match
       }
 
       PAYWAY_WS_SUCCESS = '5000'
@@ -212,8 +212,8 @@ module ActiveMerchant #:nodoc:
           test: test?,
           error_code: error_code_from(response),
           authorization: authorization_from(response),
-          avs_result: avs_result,
-          cvv_result: cvv_result
+          avs_result:,
+          cvv_result:
         )
       end
 
@@ -224,7 +224,7 @@ module ActiveMerchant #:nodoc:
       def error_code_from(response)
         return '' if success_from(response)
 
-        error = !STANDARD_ERROR_CODE_MAPPING[response['paywayCode']].nil? ? STANDARD_ERROR_CODE_MAPPING[response['paywayCode']] : STANDARD_ERROR_CODE[:processing_error]
+        error = STANDARD_ERROR_CODE_MAPPING[response['paywayCode']].nil? ? STANDARD_ERROR_CODE[:processing_error] : STANDARD_ERROR_CODE_MAPPING[response['paywayCode']]
         return error
       end