activemerchant 1.133.0 → 1.138.0

data/lib/active_merchant/billing/gateways/orbital.rb

@@ -1,8 +1,9 @@
 require 'active_merchant/billing/gateways/orbital/orbital_soft_descriptors'
 require 'rexml/document'
+require 'active_merchant/billing/gateways/orbital/orbital_codes'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     # For more information on Orbital, visit the {integration center}[http://download.chasepaymentech.com]
     #
     # ==== Authentication Options
@@ -28,13 +29,14 @@ module ActiveMerchant #:nodoc:
     # Company will automatically be affiliated.
 
     class OrbitalGateway < Gateway
+      include OrbitalCodes
       include Empty
 
-      API_VERSION = '9.0'
+      version '9.5'
 
       POST_HEADERS = {
         'MIME-Version' => '1.1',
-        'Content-Type' => "application/PTI#{API_VERSION.delete('.')}",
+        'Content-Type' => "application/PTI#{fetch_version.delete('.')}",
         'Content-transfer-encoding' => 'text',
         'Request-number' => '1',
         'Document-type' => 'Request',
@@ -84,50 +86,6 @@ module ActiveMerchant #:nodoc:
 
       AVS_SUPPORTED_COUNTRIES = %w[US CA UK GB]
 
-      CURRENCY_CODES = {
-        'AUD' => '036',
-        'BRL' => '986',
-        'CAD' => '124',
-        'CLP' => '152',
-        'CZK' => '203',
-        'DKK' => '208',
-        'HKD' => '344',
-        'ICK' => '352',
-        'JPY' => '392',
-        'MXN' => '484',
-        'NZD' => '554',
-        'NOK' => '578',
-        'SGD' => '702',
-        'ZAR' => '710',
-        'SEK' => '752',
-        'CHF' => '756',
-        'GBP' => '826',
-        'USD' => '840',
-        'EUR' => '978'
-      }
-
-      CURRENCY_EXPONENTS = {
-        'AUD' => '2',
-        'BRL' => '2',
-        'CAD' => '2',
-        'CLP' => '2',
-        'CZK' => '2',
-        'DKK' => '2',
-        'HKD' => '2',
-        'ICK' => '2',
-        'JPY' => '0',
-        'MXN' => '2',
-        'NZD' => '2',
-        'NOK' => '2',
-        'SGD' => '2',
-        'ZAR' => '2',
-        'SEK' => '2',
-        'CHF' => '2',
-        'GBP' => '2',
-        'USD' => '2',
-        'EUR' => '2'
-      }
-
       # INDUSTRY TYPES
       ECOMMERCE_TRANSACTION = 'EC'
       RECURRING_PAYMENT_TRANSACTION = 'RC'
@@ -193,6 +151,10 @@ module ActiveMerchant #:nodoc:
         'checking' => 'C'
       }
 
+      # safetech token flags
+      GET_TOKEN = 'GT'
+      USE_TOKEN = 'UT'
+
       def initialize(options = {})
         requires!(options, :merchant_id)
         requires!(options, :login, :password) unless options[:ip_authentication]
@@ -210,7 +172,7 @@ module ActiveMerchant #:nodoc:
 
         order = build_new_auth_purchase_order(AUTH_ONLY, money, payment_source, options)
 
-        commit(order, :authorize, options[:retry_logic], options[:trace_number])
+        commit(order, :authorize, options)
       end
 
       def verify(credit_card, options = {})
@@ -226,23 +188,23 @@ module ActiveMerchant #:nodoc:
         action = options[:force_capture] ? FORCE_AUTH_AND_CAPTURE : AUTH_AND_CAPTURE
         order = build_new_auth_purchase_order(action, money, payment_source, options)
 
-        commit(order, :purchase, options[:retry_logic], options[:trace_number])
+        commit(order, :purchase, options)
       end
 
       # MFC - Mark For Capture
       def capture(money, authorization, options = {})
-        commit(build_mark_for_capture_xml(money, authorization, options), :capture, options[:retry_logic], options[:trace_number])
+        commit(build_mark_for_capture_xml(money, authorization, options), :capture, options)
       end
 
       # R – Refund request
       def refund(money, authorization, options = {})
         payment_method = options[:payment_method]
-        order = build_new_order_xml(REFUND, money, payment_method, options.merge(authorization: authorization)) do |xml|
+        order = build_new_order_xml(REFUND, money, payment_method, options.merge(authorization:)) do |xml|
           add_payment_source(xml, payment_method, options)
           xml.tag! :CustomerRefNum, options[:customer_ref_num] if @options[:customer_profiles] && options[:profile_txn]
         end
 
-        commit(order, :refund, options[:retry_logic], options[:trace_number])
+        commit(order, :refund, options)
       end
 
       def credit(money, payment_method, options = {})
@@ -250,7 +212,14 @@ module ActiveMerchant #:nodoc:
           add_payment_source(xml, payment_method, options)
         end
 
-        commit(order, :refund, options[:retry_logic], options[:trace_number])
+        commit(order, :refund, options)
+      end
+
+      # Orbital save a payment method if the TokenTxnType is 'GT', that's why we use this as the default value for store
+      def store(creditcard, options = {})
+        options[:exp_date] = expiry_date(creditcard) if creditcard.is_a?(CreditCard)
+
+        authorize(0, creditcard, options.merge({ token_txn_type: GET_TOKEN }))
       end
 
       def void(authorization, options = {}, deprecated = {})
@@ -261,7 +230,7 @@ module ActiveMerchant #:nodoc:
 
         order = build_void_request_xml(authorization, options)
 
-        commit(order, :void, options[:retry_logic], options[:trace_number])
+        commit(order, :void, options)
       end
 
       def default_verify_amount(credit_card)
@@ -307,13 +276,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def retrieve_customer_profile(customer_ref_num)
-        options = { customer_profile_action: RETRIEVE, customer_ref_num: customer_ref_num }
+        options = { customer_profile_action: RETRIEVE, customer_ref_num: }
         order = build_customer_request_xml(nil, options)
         commit(order, :retrieve_customer_profile)
       end
 
       def delete_customer_profile(customer_ref_num)
-        options = { customer_profile_action: DELETE, customer_ref_num: customer_ref_num }
+        options = { customer_profile_action: DELETE, customer_ref_num: }
         order = build_customer_request_xml(nil, options)
         commit(order, :delete_customer_profile)
       end
@@ -380,8 +349,10 @@ module ActiveMerchant #:nodoc:
         xml.tag! :TxRefNum, split_authorization(authorization).first
       end
 
-      def authorization_string(*args)
-        args.compact.join(';')
+      def authorization_string(options, response)
+        authorization = [response[:tx_ref_num], response[:order_id], response[:safetech_token], response[:card_brand]]
+        authorization << options[:exp_date] if options[:exp_date] && options[:token_txn_type] == GET_TOKEN
+        authorization.compact.join(';')
       end
 
       def split_authorization(authorization)
@@ -487,6 +458,35 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_level2_card_and_more_tax(xml, options = {})
+        if (level2 = options[:level_2_data])
+          xml.tag! :PCardRequestorName, byte_limit(level2[:requestor_name], 38) if level2[:requestor_name]
+          xml.tag! :PCardLocalTaxRate, byte_limit(level2[:local_tax_rate], 5) if level2[:local_tax_rate]
+          # Canadian Merchants Only
+          xml.tag! :PCardNationalTax, byte_limit(level2[:national_tax], 12) if level2[:national_tax]
+          xml.tag! :PCardPstTaxRegNumber, byte_limit(level2[:pst_tax_reg_number], 15) if level2[:pst_tax_reg_number]
+          xml.tag! :PCardCustomerVatRegNumber, byte_limit(level2[:customer_vat_reg_number], 13) if level2[:customer_vat_reg_number]
+          # Canadian Merchants Only
+          xml.tag! :PCardMerchantVatRegNumber, byte_limit(level2[:merchant_vat_reg_number], 20) if level2[:merchant_vat_reg_number]
+          xml.tag! :PCardTotalTaxAmount, byte_limit(level2[:total_tax_amount], 12) if level2[:total_tax_amount]
+        end
+      end
+
+      def add_card_commodity_code(xml, options = {})
+        if (level2 = options[:level_2_data]) && (level2[:commodity_code])
+          xml.tag! :PCardCommodityCode, byte_limit(level2[:commodity_code], 4)
+        end
+      end
+
+      def add_level3_vat_fields(xml, options = {})
+        if (level3 = options[:level_3_data])
+          xml.tag! :PC3InvoiceDiscTreatment, byte_limit(level3[:invoice_discount_treatment], 1) if level3[:invoice_discount_treatment]
+          xml.tag! :PC3TaxTreatment, byte_limit(level3[:tax_treatment], 1) if level3[:tax_treatment]
+          xml.tag! :PC3UniqueVATInvoiceRefNum, byte_limit(level3[:unique_vat_invoice_ref], 15) if level3[:unique_vat_invoice_ref]
+          xml.tag! :PC3ShipVATRate, byte_limit(level3[:ship_vat_rate], 4) if level3[:ship_vat_rate]
+        end
+      end
+
       #=====ADDRESS FIELDS=====
 
       def add_address(xml, payment_source, options)
@@ -536,11 +536,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def billing_name(payment_source, options)
-        if payment_source&.name.present?
-          payment_source.name[0..29]
-        elsif options[:billing_address][:name].present?
-          options[:billing_address][:name][0..29]
-        end
+        name =
+          if !payment_source.is_a?(String) && payment_source&.name.present?
+            payment_source.name
+          elsif options[:billing_address] && options[:billing_address][:name].present?
+            options[:billing_address][:name]
+          end
+        name ? format_name(name)[0..29] : nil
       end
 
       def avs_supported?(address)
@@ -555,10 +557,18 @@ module ActiveMerchant #:nodoc:
         options[:billing_address] || options[:address]
       end
 
+      def add_safetech_token_data(xml, payment_source, options)
+        _, _, payment_source_token, card_brand, exp_date = split_authorization(payment_source)
+        xml.tag! :CardBrand, card_brand
+        xml.tag! :AccountNum, payment_source_token
+        xml.tag! :Exp, exp_date if exp_date && options[:pass_exp_date]&.to_s == 'true'
+      end
+
       #=====PAYMENT SOURCE FIELDS=====
 
       # Payment can be done through either Credit Card or Electronic Check
       def add_payment_source(xml, payment_source, options = {})
+        add_safetech_token_data(xml, payment_source, options) if payment_source.is_a?(String)
         payment_source.is_a?(Check) ? add_echeck(xml, payment_source, options) : add_credit_card(xml, payment_source, options)
       end
 
@@ -572,14 +582,14 @@ module ActiveMerchant #:nodoc:
         add_bank_account_type(xml, check)
         xml.tag! :ECPAuthMethod, options[:auth_method] if options[:auth_method]
         xml.tag! :BankPmtDelv, options[:payment_delivery] || 'B'
-        xml.tag! :AVSname, (check&.name ? check.name[0..29] : nil) if get_address(options).blank?
+        xml.tag! :AVSname, (check&.name ? format_name(check.name)[0..29] : nil) if get_address(options).blank?
       end
 
       def add_credit_card(xml, credit_card, options)
-        xml.tag! :AccountNum, credit_card.number if credit_card
-        xml.tag! :Exp, expiry_date(credit_card) if credit_card
+        xml.tag! :AccountNum, credit_card.number if credit_card.is_a?(CreditCard)
+        xml.tag! :Exp, options[:override_exp_date] || expiry_date(credit_card) if credit_card.is_a?(CreditCard)
         add_currency_fields(xml, options[:currency])
-        add_verification_value(xml, credit_card) if credit_card
+        add_verification_value(xml, credit_card) if credit_card.is_a?(CreditCard)
       end
 
       def add_verification_value(xml, credit_card)
@@ -664,10 +674,14 @@ module ActiveMerchant #:nodoc:
         xml.tag!(:XID, three_d_secure[:xid]) if three_d_secure[:xid]
       end
 
+      PYMT_PROGRAM_CODE_BY_BRAND = {
+        'american_express' => 'ASK',
+        'discover' => 'DPB'
+      }.freeze
       def add_pymt_brand_program_code(xml, credit_card, three_d_secure)
-        return unless three_d_secure && credit_card.brand == 'american_express'
+        return unless three_d_secure && (code = PYMT_PROGRAM_CODE_BY_BRAND[credit_card.brand])
 
-        xml.tag!(:PymtBrandProgramCode, 'ASK')
+        xml.tag!(:PymtBrandProgramCode, code)
       end
 
       def mastercard?(payment_source)
@@ -679,7 +693,7 @@ module ActiveMerchant #:nodoc:
         add_mc_sca_recurring(xml, credit_card, parameters, three_d_secure)
         add_mc_program_protocol(xml, credit_card, three_d_secure)
         add_mc_directory_trans_id(xml, credit_card, three_d_secure)
-        add_mc_ucafind(xml, credit_card, three_d_secure)
+        add_mc_ucafind(xml, credit_card, three_d_secure, parameters)
       end
 
       def add_mc_sca_merchant_initiated(xml, credit_card, parameters, three_d_secure)
@@ -708,16 +722,16 @@ module ActiveMerchant #:nodoc:
         xml.tag!(:MCDirectoryTransID, three_d_secure[:ds_transaction_id]) if three_d_secure[:ds_transaction_id]
       end
 
-      def add_mc_ucafind(xml, credit_card, three_d_secure)
-        return unless three_d_secure
+      def add_mc_ucafind(xml, credit_card, three_d_secure, options)
+        return unless three_d_secure && %w(4 6 7).include?(three_d_secure&.dig(:eci))
 
-        xml.tag! :UCAFInd, '4'
+        xml.tag! :UCAFInd, options[:ucaf_collection_indicator] if options[:ucaf_collection_indicator]
       end
 
       #=====SCA (STORED CREDENTIAL) FIELDS=====
 
       def add_stored_credentials(xml, parameters)
-        return unless parameters[:mit_stored_credential_ind] == 'Y' || parameters[:stored_credential] && !parameters[:stored_credential].values.all?(&:nil?)
+        return unless parameters[:mit_stored_credential_ind] == 'Y' || (parameters[:stored_credential] && !parameters[:stored_credential].values.all?(&:nil?))
 
         if msg_type = get_msg_type(parameters)
           xml.tag! :MITMsgType, msg_type
@@ -769,7 +783,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_digital_token_cryptogram(xml, credit_card, three_d_secure)
-        return unless credit_card.is_a?(NetworkTokenizationCreditCard) || three_d_secure && credit_card.brand == 'discover'
+        return unless credit_card.is_a?(NetworkTokenizationCreditCard) || (three_d_secure && credit_card.brand == 'discover')
 
         cryptogram =
           if three_d_secure && credit_card.brand == 'discover'
@@ -868,10 +882,10 @@ module ActiveMerchant #:nodoc:
 
       #=====REQUEST/RESPONSE METHODS=====
 
-      def commit(order, message_type, retry_logic = nil, trace_number = nil)
+      def commit(order, message_type, options = {})
         headers = POST_HEADERS.merge('Content-length' => order.size.to_s)
-        if (@options[:retry_logic] || retry_logic) && trace_number
-          headers['Trace-number'] = trace_number.to_s
+        if (@options[:retry_logic] || options[:retry_logic]) && options[:trace_number]
+          headers['Trace-number'] = options[:trace_number].to_s
           headers['Merchant-Id'] = @options[:merchant_id]
         end
         request = ->(url) { parse(ssl_post(url, order, headers)) }
@@ -886,13 +900,17 @@ module ActiveMerchant #:nodoc:
             request.call(remote_url(:secondary))
           end
 
-        Response.new(success?(response, message_type), message_from(response), response,
+        Response.new(
+          success?(response, message_type),
+          message_from(response),
+          response,
           {
-            authorization: authorization_string(response[:tx_ref_num], response[:order_id]),
+            authorization: authorization_string(options, response),
             test: self.test?,
             avs_result: OrbitalGateway::AVSResult.new(response[:avs_resp_code]),
             cvv_result: OrbitalGateway::CVVResult.new(response[:cvv2_resp_code])
-          })
+          }
+        )
       end
 
       def remote_url(url = :primary)
@@ -981,35 +999,34 @@ module ActiveMerchant #:nodoc:
             xml.tag! :OrderID, format_order_id(parameters[:order_id])
             xml.tag! :Amount, amount(money)
             xml.tag! :Comments, parameters[:comments] if parameters[:comments]
-
             add_level2_tax(xml, parameters)
             add_level2_advice_addendum(xml, parameters)
-
             add_aav(xml, payment_source, three_d_secure)
             # CustomerAni, AVSPhoneType and AVSDestPhoneType could be added here.
-
             add_soft_descriptors(xml, parameters[:soft_descriptors])
-            add_payment_action_ind(xml, parameters[:payment_action_ind])
-            add_dpanind(xml, payment_source, parameters[:industry_type])
-            add_aevv(xml, payment_source, three_d_secure)
-            add_digital_token_cryptogram(xml, payment_source, three_d_secure)
-
-            xml.tag! :ECPSameDayInd, parameters[:same_day] if parameters[:same_day] && payment_source.is_a?(Check)
-
             set_recurring_ind(xml, parameters)
 
             # Append Transaction Reference Number at the end for Refund transactions
             add_tx_ref_num(xml, parameters[:authorization]) if action == REFUND && payment_source.nil?
-
             add_level2_purchase(xml, parameters)
             add_level3_purchase(xml, parameters)
             add_level3_tax(xml, parameters)
             add_line_items(xml, parameters) if parameters[:line_items]
-            add_ecp_details(xml, payment_source, parameters) if payment_source.is_a?(Check)
             add_card_indicators(xml, parameters)
+            add_payment_action_ind(xml, parameters[:payment_action_ind])
+            add_dpanind(xml, payment_source, parameters[:industry_type])
+            add_aevv(xml, payment_source, three_d_secure)
+            add_level2_card_and_more_tax(xml, parameters)
+            add_digital_token_cryptogram(xml, payment_source, three_d_secure)
+            xml.tag! :ECPSameDayInd, parameters[:same_day] if parameters[:same_day] && payment_source.is_a?(Check)
+            add_ecp_details(xml, payment_source, parameters) if payment_source.is_a?(Check)
+
             add_stored_credentials(xml, parameters)
             add_pymt_brand_program_code(xml, payment_source, three_d_secure)
+            xml.tag! :TokenTxnType, parameters[:token_txn_type] if parameters[:token_txn_type]
             add_mastercard_fields(xml, payment_source, parameters, three_d_secure) if mastercard?(payment_source)
+            add_card_commodity_code(xml, parameters)
+            add_level3_vat_fields(xml, parameters)
           end
         end
         xml.target!
@@ -1031,6 +1048,9 @@ module ActiveMerchant #:nodoc:
             add_level3_purchase(xml, parameters)
             add_level3_tax(xml, parameters)
             add_line_items(xml, parameters) if parameters[:line_items]
+            add_level2_card_and_more_tax(xml, parameters)
+            add_card_commodity_code(xml, parameters)
+            add_level3_vat_fields(xml, parameters)
           end
         end
         xml.target!

data/lib/active_merchant/billing/gateways/pac_net_raven.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PacNetRavenGateway < Gateway
       AVS_ADDRESS_CODES = {
         'avs_address_unavailable'   => 'X',
@@ -121,7 +121,10 @@ module ActiveMerchant #:nodoc:
 
         test_mode = test? || message =~ /TESTMODE/
 
-        Response.new(success?(response), message, response,
+        Response.new(
+          success?(response),
+          message,
+          response,
           test: test_mode,
           authorization: response['TrackingNumber'],
           fraud_review: fraud_review?(response),
@@ -129,7 +132,8 @@ module ActiveMerchant #:nodoc:
             postal_match: AVS_POSTAL_CODES[response['AVSPostalResponseCode']],
             street_match: AVS_ADDRESS_CODES[response['AVSAddressResponseCode']]
           },
-          cvv_result: CVV2_CODES[response['CVV2ResponseCode']])
+          cvv_result: CVV2_CODES[response['CVV2ResponseCode']]
+        )
       end
 
       def url(action)
@@ -178,8 +182,7 @@ module ActiveMerchant #:nodoc:
         post['RequestID']     = request_id
         post['Signature']     = signature(action, post, parameters)
 
-        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
-        request
+        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def timestamp

data/lib/active_merchant/billing/gateways/pagarme.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PagarmeGateway < Gateway
       self.live_url = 'https://api.pagar.me/1/'
 

data/lib/active_merchant/billing/gateways/pago_facil.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PagoFacilGateway < Gateway
       self.test_url = 'https://www.pagofacil.net/st/public/Wsrtransaccion/index/format/json?'
       self.live_url = 'https://www.pagofacil.net/ws/public/Wsrtransaccion/index/format/json?'

data/lib/active_merchant/billing/gateways/pay_arc.rb

@@ -1,8 +1,10 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PayArcGateway < Gateway
-      self.test_url = 'https://testapi.payarc.net/v1'
-      self.live_url = 'https://api.payarc.net/v1'
+      version 'v1'
+
+      self.test_url = "https://testapi.payarc.net/#{fetch_version}"
+      self.live_url = "https://api.payarc.net/#{fetch_version}"
 
       self.supported_countries = ['US']
       self.default_currency = 'usd'
@@ -242,7 +244,7 @@ module ActiveMerchant #:nodoc:
         token(creditcard, options)
       end
 
-      #:nodoc:
+      # :nodoc:
       def token(creditcard, options = {})
         post = {}
         post['authorize_card'] = 1
@@ -253,12 +255,12 @@ module ActiveMerchant #:nodoc:
         commit(STANDARD_ACTIONS[:token][:end_point], post)
       end
 
-      def supports_scrubbing? #:nodoc:
+      def supports_scrubbing? # :nodoc:
         true
       end
 
       def scrub(transcript)
-        #:nodoc:
+        # :nodoc:
         transcript.
           gsub(%r((Authorization: Bearer )[^\s]+\s)i, '\1[FILTERED]\2').
           gsub(%r((&?card_number=)[^&]*)i, '\1[FILTERED]').

data/lib/active_merchant/billing/gateways/pay_conex.rb

@@ -1,10 +1,12 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PayConexGateway < Gateway
       include Empty
 
-      self.test_url = 'https://cert.payconex.net/api/qsapi/3.8/'
-      self.live_url = 'https://secure.payconex.net/api/qsapi/3.8/'
+      version '3.8'
+
+      self.test_url = "https://cert.payconex.net/api/qsapi/#{fetch_version}/"
+      self.live_url = "https://secure.payconex.net/api/qsapi/#{fetch_version}/"
 
       self.supported_countries = %w(US CA)
       self.default_currency = 'USD'

data/lib/active_merchant/billing/gateways/pay_gate_xml.rb

@@ -1,7 +1,7 @@
 require 'digest/md5'
 
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     # This gateway accepts the following arguments:
     #   :login    => your PayJunction username
     #   :password => your PayJunction pass
@@ -264,9 +264,13 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, request, authorization = nil)
         response = parse(action, ssl_post(self.live_url, request))
-        Response.new(successful?(response), message_from(response), response,
+        Response.new(
+          successful?(response),
+          message_from(response),
+          response,
           test: test?,
-          authorization: authorization || response[:tid])
+          authorization: authorization || response[:tid]
+        )
       end
 
       def message_from(response)

data/lib/active_merchant/billing/gateways/pay_hub.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PayHubGateway < Gateway
       self.live_url = 'https://checkout.payhub.com/transaction/api'
 
@@ -182,14 +182,16 @@ module ActiveMerchant #:nodoc:
           response = json_error(raw_response)
         end
 
-        Response.new(success,
+        Response.new(
+          success,
           response_message(response),
           response,
           test: test?,
           avs_result: { code: response['AVS_RESULT_CODE'] },
           cvv_result: response['VERIFICATION_RESULT_CODE'],
           error_code: (success ? nil : STANDARD_ERROR_CODE_MAPPING[response['RESPONSE_CODE']]),
-          authorization: response['TRANSACTION_ID'])
+          authorization: response['TRANSACTION_ID']
+        )
       end
 
       def response_error(raw_response)
@@ -201,7 +203,7 @@ module ActiveMerchant #:nodoc:
       def json_error(raw_response)
         {
           error_message: 'Invalid response received from the Payhub API.  Please contact wecare@payhub.com if you continue to receive this message.' \
-            "  (The raw response returned by the API was #{raw_response.inspect})"
+                         "  (The raw response returned by the API was #{raw_response.inspect})"
         }
       end
 

data/lib/active_merchant/billing/gateways/pay_junction.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     # PayJunction Gateway
     #
     # This gateway accepts the following arguments:
@@ -337,9 +337,13 @@ module ActiveMerchant #:nodoc:
 
         response = parse(ssl_post(url, post_data(action, parameters)))
 
-        Response.new(successful?(response), message_from(response), response,
+        Response.new(
+          successful?(response),
+          message_from(response),
+          response,
           test: test?,
-          authorization: response[:transaction_id] || parameters[:transaction_id])
+          authorization: response[:transaction_id] || parameters[:transaction_id]
+        )
       end
 
       def successful?(response)

data/lib/active_merchant/billing/gateways/pay_junction_v2.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PayJunctionV2Gateway < Gateway
       self.display_name = 'PayJunction'
       self.homepage_url = 'https://www.payjunction.com/'

data/lib/active_merchant/billing/gateways/pay_secure.rb

@@ -1,5 +1,5 @@
-module ActiveMerchant #:nodoc:
-  module Billing #:nodoc:
+module ActiveMerchant # :nodoc:
+  module Billing # :nodoc:
     class PaySecureGateway < Gateway
       self.live_url = self.test_url = 'https://clearance.commsecure.com.au/cgi-bin/PSDirect'
 
@@ -68,9 +68,13 @@ module ActiveMerchant #:nodoc:
       def commit(action, money, parameters)
         response = parse(ssl_post(self.live_url, post_data(action, parameters)))
 
-        Response.new(successful?(response), message_from(response), response,
+        Response.new(
+          successful?(response),
+          message_from(response),
+          response,
           test: test_response?(response),
-          authorization: authorization_from(response))
+          authorization: authorization_from(response)
+        )
       end
 
       def successful?(response)