activemerchant 1.114.0 → 1.116.0

data/lib/active_merchant/billing/gateways/iats_payments.rb

@@ -23,7 +23,7 @@ module ActiveMerchant #:nodoc:
         unstore: 'DeleteCustomerCode'
       }
 
-      def initialize(options={})
+      def initialize(options = {})
         if options[:login]
           ActiveMerchant.deprecated("The 'login' option is deprecated in favor of 'agent_code' and will be removed in a future version.")
           options[:agent_code] = options[:login]
@@ -35,18 +35,19 @@ module ActiveMerchant #:nodoc:
         super
       end
 
-      def purchase(money, payment, options={})
+      def purchase(money, payment, options = {})
         post = {}
         add_invoice(post, money, options)
         add_payment(post, payment)
         add_address(post, options)
         add_ip(post, options)
         add_description(post, options)
+        add_customer_details(post, options)
 
         commit(determine_purchase_type(payment), post)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         post = {}
         transaction_id, payment_type = split_authorization(authorization)
         post[:transaction_id] = transaction_id
@@ -160,6 +161,10 @@ module ActiveMerchant #:nodoc:
         post[:amount] = 0
       end
 
+      def add_customer_details(post, options)
+        post[:email] = options[:email] if options[:email]
+      end
+
       def expdate(creditcard)
         year  = sprintf('%.4i', creditcard.year)
         month = sprintf('%.2i', creditcard.month)
@@ -181,7 +186,7 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, parameters)
         response = parse(ssl_post(url(action), post_data(action, parameters),
-          { 'Content-Type' => 'application/soap+xml; charset=utf-8'}))
+          { 'Content-Type' => 'application/soap+xml; charset=utf-8' }))
 
         Response.new(
           success_from(response),

data/lib/active_merchant/billing/gateways/in_context_paypal_express.rb

@@ -5,7 +5,7 @@ module ActiveMerchant #:nodoc:
       self.live_redirect_url = 'https://www.paypal.com/checkoutnow'
 
       def redirect_url_for(token, options = {})
-        options = {review: true}.update(options)
+        options = { review: true }.update(options)
         url  = "#{redirect_url}?token=#{token}"
         url += '&useraction=commit' unless options[:review]
         url

data/lib/active_merchant/billing/gateways/inspire.rb

@@ -96,7 +96,7 @@ module ActiveMerchant #:nodoc:
         authorize(100, creditcard, options.merge(store: billing_id))
       end
 
-      alias_method :unstore, :delete
+      alias unstore delete
 
       private
 
@@ -124,7 +124,7 @@ module ActiveMerchant #:nodoc:
         post[:orderdescription] = options[:description]
       end
 
-      def add_payment_source(params, source, options={})
+      def add_payment_source(params, source, options = {})
         case determine_funding_source(source)
         when :vault       then add_customer_vault_id(params, source)
         when :credit_card then add_creditcard(params, source, options)
@@ -176,8 +176,7 @@ module ActiveMerchant #:nodoc:
           authorization: response['transactionid'],
           test: test?,
           cvv_result: response['cvvresponse'],
-          avs_result: { code: response['avsresponse'] }
-        )
+          avs_result: { code: response['avsresponse'] })
       end
 
       def message_from(response)

data/lib/active_merchant/billing/gateways/instapay.rb

@@ -143,8 +143,7 @@ module ActiveMerchant #:nodoc:
         Response.new(response[:success], response[:message], response,
           authorization: response[:transaction_id],
           avs_result: { code: response[:avs_result] },
-          cvv_result: response[:cvv_result]
-        )
+          cvv_result: response[:cvv_result])
       end
 
       def post_data(action, parameters = {})

data/lib/active_merchant/billing/gateways/ipp.rb

@@ -21,13 +21,13 @@ module ActiveMerchant #:nodoc:
         '54' => STANDARD_ERROR_CODE[:expired_card]
       }
 
-      def initialize(options={})
+      def initialize(options = {})
         ActiveMerchant.deprecated('IPP gateway is now named Bambora Asia-Pacific')
         requires!(options, :username, :password)
         super
       end
 
-      def purchase(money, payment, options={})
+      def purchase(money, payment, options = {})
         commit('SubmitSinglePayment') do |xml|
           xml.Transaction do
             xml.CustRef options[:order_id]
@@ -40,7 +40,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def authorize(money, payment, options={})
+      def authorize(money, payment, options = {})
         commit('SubmitSinglePayment') do |xml|
           xml.Transaction do
             xml.CustRef options[:order_id]
@@ -53,7 +53,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         commit('SubmitSingleCapture') do |xml|
           xml.Capture do
             xml.Receipt authorization
@@ -63,7 +63,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         commit('SubmitSingleRefund') do |xml|
           xml.Refund do
             xml.Receipt authorization

data/lib/active_merchant/billing/gateways/iridium.rb

@@ -251,16 +251,16 @@ module ActiveMerchant #:nodoc:
         commit(build_reference_request('COLLECTION', money, authorization, options), options)
       end
 
-      def credit(money, authorization, options={})
+      def credit(money, authorization, options = {})
         ActiveMerchant.deprecated CREDIT_DEPRECATION_MESSAGE
         refund(money, authorization, options)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         commit(build_reference_request('REFUND', money, authorization, options), options)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         commit(build_reference_request('VOID', nil, authorization, options), options)
       end
 
@@ -292,12 +292,12 @@ module ActiveMerchant #:nodoc:
         build_request(options) do |xml|
           if money
             currency = options[:currency] || currency(money)
-            details = {'CurrencyCode' => currency_code(currency), 'Amount' => localized_amount(money, currency)}
+            details = { 'CurrencyCode' => currency_code(currency), 'Amount' => localized_amount(money, currency) }
           else
-            details = {'CurrencyCode' => currency_code(default_currency), 'Amount' => '0'}
+            details = { 'CurrencyCode' => currency_code(default_currency), 'Amount' => '0' }
           end
           xml.tag! 'TransactionDetails', details do
-            xml.tag! 'MessageDetails', {'TransactionType' => type, 'CrossReference' => cross_reference}
+            xml.tag! 'MessageDetails', { 'TransactionType' => type, 'CrossReference' => cross_reference }
             xml.tag! 'OrderID', (options[:order_id] || order_id)
           end
         end
@@ -309,9 +309,9 @@ module ActiveMerchant #:nodoc:
         xml.instruct!(:xml, version: '1.0', encoding: 'utf-8')
         xml.tag! 'soap:Envelope', { 'xmlns:soap' => 'http://schemas.xmlsoap.org/soap/envelope/',
                                     'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance',
-                                    'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema'} do
+                                    'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema' } do
           xml.tag! 'soap:Body' do
-            xml.tag! options[:action], {'xmlns' => 'https://www.thepaymentgateway.net/'} do
+            xml.tag! options[:action], { 'xmlns' => 'https://www.thepaymentgateway.net/' } do
               xml.tag! 'PaymentMessage' do
                 add_merchant_data(xml, options)
                 yield(xml)
@@ -330,8 +330,8 @@ module ActiveMerchant #:nodoc:
       def add_purchase_data(xml, type, money, options)
         currency = options[:currency] || currency(money)
         requires!(options, :order_id)
-        xml.tag! 'TransactionDetails', {'Amount' => localized_amount(money, currency), 'CurrencyCode' => currency_code(currency)} do
-          xml.tag! 'MessageDetails', {'TransactionType' => type}
+        xml.tag! 'TransactionDetails', { 'Amount' => localized_amount(money, currency), 'CurrencyCode' => currency_code(currency) } do
+          xml.tag! 'MessageDetails', { 'TransactionType' => type }
           xml.tag! 'OrderID', options[:order_id]
           xml.tag! 'TransactionControl' do
             xml.tag! 'ThreeDSecureOverridePolicy', 'FALSE'
@@ -371,13 +371,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_merchant_data(xml, options)
-        xml.tag! 'MerchantAuthentication', {'MerchantID' => @options[:login], 'Password' => @options[:password]}
+        xml.tag! 'MerchantAuthentication', { 'MerchantID' => @options[:login], 'Password' => @options[:password] }
       end
 
       def commit(request, options)
         requires!(options, :action)
         response = parse(ssl_post(test? ? self.test_url : self.live_url, request,
-          {'SOAPAction' => 'https://www.thepaymentgateway.net/' + options[:action],
+          { 'SOAPAction' => 'https://www.thepaymentgateway.net/' + options[:action],
            'Content-Type' => 'text/xml; charset=utf-8' }))
 
         success = response[:transaction_result][:status_code] == '0'
@@ -391,14 +391,13 @@ module ActiveMerchant #:nodoc:
             street_match: AVS_CODE[ response[:transaction_output_data][:address_numeric_check_result] ],
             postal_match: AVS_CODE[ response[:transaction_output_data][:post_code_check_result] ]
           },
-          cvv_result: CVV_CODE[ response[:transaction_output_data][:cv2_check_result] ]
-        )
+          cvv_result: CVV_CODE[ response[:transaction_output_data][:cv2_check_result] ])
       end
 
       def parse(xml)
         reply = {}
         xml = REXML::Document.new(xml)
-        if (root = REXML::XPath.first(xml, '//CardDetailsTransactionResponse')) or
+        if (root = REXML::XPath.first(xml, '//CardDetailsTransactionResponse')) ||
            (root = REXML::XPath.first(xml, '//CrossReferenceTransactionResponse'))
           root.elements.to_a.each do |node|
             case node.name

data/lib/active_merchant/billing/gateways/iveri.rb

@@ -13,12 +13,12 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://www.iveri.com'
       self.display_name = 'iVeri'
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :app_id, :cert_id)
         super
       end
 
-      def purchase(money, payment_method, options={})
+      def purchase(money, payment_method, options = {})
         post = build_vxml_request('Debit', options) do |xml|
           add_auth_purchase_params(xml, money, payment_method, options)
         end
@@ -26,7 +26,7 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def authorize(money, payment_method, options={})
+      def authorize(money, payment_method, options = {})
         post = build_vxml_request('Authorisation', options) do |xml|
           add_auth_purchase_params(xml, money, payment_method, options)
         end
@@ -34,7 +34,7 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         post = build_vxml_request('Debit', options) do |xml|
           add_authorization(xml, authorization, options)
         end
@@ -42,7 +42,7 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         post = build_vxml_request('Credit', options) do |xml|
           add_amount(xml, money, options)
           add_authorization(xml, authorization, options)
@@ -51,7 +51,7 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         post = build_vxml_request('Void', options) do |xml|
           add_authorization(xml, authorization, options)
         end
@@ -59,7 +59,7 @@ module ActiveMerchant #:nodoc:
         commit(post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }

data/lib/active_merchant/billing/gateways/ixopay.rb

@@ -14,13 +14,13 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'https://www.ixopay.com'
       self.display_name = 'Ixopay'
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :username, :password, :secret, :api_key)
         @secret = options[:secret]
         super
       end
 
-      def purchase(money, payment_method, options={})
+      def purchase(money, payment_method, options = {})
         request = build_xml_request do |xml|
           add_card_data(xml, payment_method)
           add_debit(xml, money, options)
@@ -29,7 +29,7 @@ module ActiveMerchant #:nodoc:
         commit(request)
       end
 
-      def authorize(money, payment_method, options={})
+      def authorize(money, payment_method, options = {})
         request = build_xml_request do |xml|
           add_card_data(xml, payment_method)
           add_preauth(xml, money, options)
@@ -38,7 +38,7 @@ module ActiveMerchant #:nodoc:
         commit(request)
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         request = build_xml_request do |xml|
           add_capture(xml, money, authorization, options)
         end
@@ -46,7 +46,7 @@ module ActiveMerchant #:nodoc:
         commit(request)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         request = build_xml_request do |xml|
           add_refund(xml, money, authorization, options)
         end
@@ -54,7 +54,7 @@ module ActiveMerchant #:nodoc:
         commit(request)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         request = build_xml_request do |xml|
           add_void(xml, authorization)
         end
@@ -62,7 +62,7 @@ module ActiveMerchant #:nodoc:
         commit(request)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }

data/lib/active_merchant/billing/gateways/jetpay.rb

@@ -290,8 +290,7 @@ module ActiveMerchant #:nodoc:
           test: test?,
           authorization: authorization_from(response, money, token),
           avs_result: { code: response[:avs] },
-          cvv_result: response[:cvv2]
-        )
+          cvv_result: response[:cvv2])
       end
 
       def url

data/lib/active_merchant/billing/gateways/jetpay_v2.rb

@@ -210,8 +210,8 @@ module ActiveMerchant #:nodoc:
           xml.tag! 'TransactionID', transaction_id.nil? ? generate_unique_id.slice(0, 18) : transaction_id
           xml.tag! 'Origin', options[:origin] || 'INTERNET'
           xml.tag! 'IndustryInfo', 'Type' => options[:industry_info] || 'ECOMMERCE'
-          xml.tag! 'Application', (options[:application] || 'n/a'), {'Version' => options[:application_version] || '1.0'}
-          xml.tag! 'Device', (options[:device] || 'n/a'), {'Version' => options[:device_version] || '1.0'}
+          xml.tag! 'Application', (options[:application] || 'n/a'), { 'Version' => options[:application_version] || '1.0' }
+          xml.tag! 'Device', (options[:device] || 'n/a'), { 'Version' => options[:device_version] || '1.0' }
           xml.tag! 'Library', 'VirtPOS SDK', 'Version' => '1.5'
           xml.tag! 'Gateway', 'JetPay'
           xml.tag! 'DeveloperID', options[:developer_id] || 'n/a'
@@ -302,8 +302,7 @@ module ActiveMerchant #:nodoc:
           authorization: authorization_from(response, money, token),
           avs_result: AVSResult.new(code: response[:avs]),
           cvv_result: CVVResult.new(response[:cvv2]),
-          error_code: success ? nil : error_code_from(response)
-        )
+          error_code: success ? nil : error_code_from(response))
       end
 
       def url
@@ -406,7 +405,7 @@ module ActiveMerchant #:nodoc:
       def add_invoice_data(xml, options)
         xml.tag! 'OrderNumber', options[:order_id] if options[:order_id]
         if tax_amount = options[:tax_amount]
-          xml.tag! 'TaxAmount', tax_amount, {'ExemptInd' => options[:tax_exempt] || 'false'}
+          xml.tag! 'TaxAmount', tax_amount, { 'ExemptInd' => options[:tax_exempt] || 'false' }
         end
       end
 

data/lib/active_merchant/billing/gateways/kushki.rb

@@ -12,26 +12,26 @@ module ActiveMerchant #:nodoc:
       self.money_format = :dollars
       self.supported_cardtypes = %i[visa master american_express discover diners_club alia]
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :public_merchant_id, :private_merchant_id)
         super
       end
 
-      def purchase(amount, payment_method, options={})
+      def purchase(amount, payment_method, options = {})
         MultiResponse.run() do |r|
           r.process { tokenize(amount, payment_method, options) }
           r.process { charge(amount, r.authorization, options) }
         end
       end
 
-      def authorize(amount, payment_method, options={})
+      def authorize(amount, payment_method, options = {})
         MultiResponse.run() do |r|
           r.process { tokenize(amount, payment_method, options) }
           r.process { preauthorize(amount, r.authorization, options) }
         end
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         action = 'capture'
 
         post = {}
@@ -41,7 +41,7 @@ module ActiveMerchant #:nodoc:
         commit(action, post)
       end
 
-      def refund(amount, authorization, options={})
+      def refund(amount, authorization, options = {})
         action = 'refund'
 
         post = {}
@@ -50,7 +50,7 @@ module ActiveMerchant #:nodoc:
         commit(action, post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         action = 'void'
 
         post = {}

data/lib/active_merchant/billing/gateways/latitude19.rb

@@ -51,12 +51,12 @@ module ActiveMerchant #:nodoc:
         'jcb' => 'JC'
       }
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :account_number, :configuration_id, :secret)
         super
       end
 
-      def purchase(amount, payment_method, options={})
+      def purchase(amount, payment_method, options = {})
         if payment_method.is_a?(String)
           auth_or_sale('sale', payment_method, amount, nil, options)
         else
@@ -68,7 +68,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def authorize(amount, payment_method, options={})
+      def authorize(amount, payment_method, options = {})
         if payment_method.is_a?(String)
           auth_or_sale('auth', payment_method, amount, nil, options)
         else
@@ -80,7 +80,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         post = {}
         post[:method] = 'deposit'
         add_request_id(post)
@@ -96,7 +96,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         method, pgwTID = split_authorization(authorization)
         case method
         when 'auth'
@@ -109,7 +109,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def credit(amount, payment_method, options={})
+      def credit(amount, payment_method, options = {})
         if payment_method.is_a?(String)
           refundWithCard(payment_method, amount, nil, options)
         else
@@ -121,7 +121,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def verify(payment_method, options={}, action=nil)
+      def verify(payment_method, options = {}, action = nil)
         if payment_method.is_a?(String)
           verifyOnly(action, payment_method, nil, options)
         else
@@ -133,7 +133,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def store(payment_method, options={})
+      def store(payment_method, options = {})
         verify(payment_method, options, 'store')
       end
 
@@ -201,7 +201,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def get_session(options={})
+      def get_session(options = {})
         post = {}
         post[:method] = 'getSession'
         add_request_id(post)
@@ -213,7 +213,7 @@ module ActiveMerchant #:nodoc:
         commit('session', post)
       end
 
-      def get_token(authorization, payment_method, options={})
+      def get_token(authorization, payment_method, options = {})
         post = {}
         post[:method] = 'tokenize'
         add_request_id(post)
@@ -226,7 +226,7 @@ module ActiveMerchant #:nodoc:
         commit('token', post)
       end
 
-      def auth_or_sale(method, authorization, amount, credit_card, options={})
+      def auth_or_sale(method, authorization, amount, credit_card, options = {})
         post = {}
         post[:method] = method
         add_request_id(post)
@@ -246,7 +246,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def verifyOnly(action, authorization, credit_card, options={})
+      def verifyOnly(action, authorization, credit_card, options = {})
         post = {}
         post[:method] = 'verifyOnly'
         add_request_id(post)
@@ -267,7 +267,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def refundWithCard(authorization, amount, credit_card, options={})
+      def refundWithCard(authorization, amount, credit_card, options = {})
         post = {}
         post[:method] = 'refundWithCard'
         add_request_id(post)
@@ -286,7 +286,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def reverse_or_void(method, pgwTID, options={})
+      def reverse_or_void(method, pgwTID, options = {})
         post = {}
         post[:method] = method
         add_request_id(post)