activemerchant 1.114.0 → 1.116.0

data/lib/active_merchant/billing/gateways/linkpoint.rb

@@ -166,7 +166,7 @@ module ActiveMerchant #:nodoc:
       # :threshold              Tells how many times to retry the transaction (if it fails) before contacting the merchant.
       # :comments               Uh... comments
       #
-      def recurring(money, creditcard, options={})
+      def recurring(money, creditcard, options = {})
         ActiveMerchant.deprecated RECURRING_DEPRECATION_MESSAGE
 
         requires!(options, %i[periodicity bimonthly monthly biweekly weekly yearly daily], :installments, :order_id)
@@ -184,7 +184,7 @@ module ActiveMerchant #:nodoc:
       end
 
       # Buy the thing
-      def purchase(money, creditcard, options={})
+      def purchase(money, creditcard, options = {})
         requires!(options, :order_id)
         options.update(
           ordertype: 'SALE'
@@ -267,8 +267,7 @@ module ActiveMerchant #:nodoc:
           test: test?,
           authorization: response[:ordernum],
           avs_result: { code: response[:avs].to_s[2, 1] },
-          cvv_result: response[:avs].to_s[3, 1]
-        )
+          cvv_result: response[:avs].to_s[3, 1])
       end
 
       def successful?(response)
@@ -431,7 +430,7 @@ module ActiveMerchant #:nodoc:
         # <r_approved>APPROVED</r_approved>
         # <r_avs></r_avs>
 
-        response = {message: 'Global Error Receipt', complete: false}
+        response = { message: 'Global Error Receipt', complete: false }
 
         xml = REXML::Document.new("<response>#{xml}</response>")
         xml.root&.elements&.each do |node|

data/lib/active_merchant/billing/gateways/litle.rb

@@ -15,12 +15,12 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://www.vantiv.com/'
       self.display_name = 'Vantiv eCommerce'
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :login, :password, :merchant_id)
         super
       end
 
-      def purchase(money, payment_method, options={})
+      def purchase(money, payment_method, options = {})
         request = build_xml_request do |doc|
           add_authentication(doc)
           if check?(payment_method)
@@ -36,7 +36,7 @@ module ActiveMerchant #:nodoc:
         check?(payment_method) ? commit(:echeckSales, request, money) : commit(:sale, request, money)
       end
 
-      def authorize(money, payment_method, options={})
+      def authorize(money, payment_method, options = {})
         request = build_xml_request do |doc|
           add_authentication(doc)
           if check?(payment_method)
@@ -52,7 +52,7 @@ module ActiveMerchant #:nodoc:
         check?(payment_method) ? commit(:echeckVerification, request, money) : commit(:authorization, request, money)
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         transaction_id, = split_authorization(authorization)
 
         request = build_xml_request do |doc|
@@ -72,7 +72,7 @@ module ActiveMerchant #:nodoc:
         refund(money, authorization, options)
       end
 
-      def refund(money, payment, options={})
+      def refund(money, payment, options = {})
         request = build_xml_request do |doc|
           add_authentication(doc)
           add_descriptor(doc, options)
@@ -99,7 +99,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         transaction_id, kind, money = split_authorization(authorization)
 
         request = build_xml_request do |doc|
@@ -227,7 +227,7 @@ module ActiveMerchant #:nodoc:
         add_stored_credential_params(doc, options)
       end
 
-      def add_merchant_data(doc, options={})
+      def add_merchant_data(doc, options = {})
         if options[:affiliate] || options[:campaign] || options[:merchant_grouping_id]
           doc.merchantData do
             doc.affiliate(options[:affiliate]) if options[:affiliate]
@@ -296,7 +296,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def add_stored_credential_params(doc, options={})
+      def add_stored_credential_params(doc, options = {})
         return unless options[:stored_credential]
 
         if options[:stored_credential][:initial_transaction]
@@ -381,7 +381,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def order_source(options={})
+      def order_source(options = {})
         return options[:order_source] unless options[:stored_credential]
 
         order_source = nil
@@ -448,7 +448,7 @@ module ActiveMerchant #:nodoc:
         parsed
       end
 
-      def commit(kind, request, money=nil)
+      def commit(kind, request, money = nil)
         parsed = parse(kind, ssl_post(url, request, headers))
 
         options = {
@@ -481,7 +481,7 @@ module ActiveMerchant #:nodoc:
         attributes[:id] = truncate(options[:id] || options[:order_id], 24)
         attributes[:reportGroup] = options[:merchant] || 'Default Report Group'
         attributes[:customerId] = options[:customer]
-        attributes.delete_if { |key, value| value == nil }
+        attributes.delete_if { |_key, value| value == nil }
         attributes
       end
 

data/lib/active_merchant/billing/gateways/mastercard.rb

@@ -1,12 +1,12 @@
 module ActiveMerchant
   module Billing
     module MastercardGateway
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :userid, :password)
         super
       end
 
-      def purchase(amount, payment_method, options={})
+      def purchase(amount, payment_method, options = {})
         if options[:pay_mode]
           post = new_post
           add_invoice(post, amount, options)
@@ -24,7 +24,7 @@ module ActiveMerchant
         end
       end
 
-      def authorize(amount, payment_method, options={})
+      def authorize(amount, payment_method, options = {})
         post = new_post
         add_invoice(post, amount, options)
         add_reference(post, *new_authorization)
@@ -35,7 +35,7 @@ module ActiveMerchant
         commit('authorize', post)
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         post = new_post
         add_invoice(post, amount, options, :transaction)
         add_reference(post, *next_authorization(authorization))
@@ -45,7 +45,7 @@ module ActiveMerchant
         commit('capture', post)
       end
 
-      def refund(amount, authorization, options={})
+      def refund(amount, authorization, options = {})
         post = new_post
         add_invoice(post, amount, options, :transaction)
         add_reference(post, *next_authorization(authorization))
@@ -54,14 +54,14 @@ module ActiveMerchant
         commit('refund', post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         post = new_post
         add_reference(post, *next_authorization(authorization), :targetTransactionId)
 
         commit('void', post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }
@@ -109,12 +109,12 @@ module ActiveMerchant
         }
       end
 
-      def add_invoice(post, amount, options, node=:order)
+      def add_invoice(post, amount, options, node = :order)
         post[node][:amount] = amount(amount)
         post[node][:currency] = (options[:currency] || currency(amount))
       end
 
-      def add_reference(post, orderid, transactionid, transaction_reference, reference_key=:reference)
+      def add_reference(post, orderid, transactionid, transaction_reference, reference_key = :reference)
         post[:orderid] = orderid
         post[:transactionid] = transactionid
         post[:transaction][reference_key] = transaction_reference if transaction_reference
@@ -176,7 +176,7 @@ module ActiveMerchant
       def add_3dsecure_id(post, options)
         return unless options[:threed_secure_id]
 
-        post.merge!({'3DSecureId' => options[:threed_secure_id]})
+        post.merge!({ '3DSecureId' => options[:threed_secure_id] })
       end
 
       def country_code(country)

data/lib/active_merchant/billing/gateways/mercado_pago.rb

@@ -10,12 +10,12 @@ module ActiveMerchant #:nodoc:
       self.display_name = 'Mercado Pago'
       self.money_format = :dollars
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :access_token)
         super
       end
 
-      def purchase(money, payment, options={})
+      def purchase(money, payment, options = {})
         MultiResponse.run do |r|
           r.process { commit('tokenize', 'card_tokens', card_token_request(money, payment, options)) }
           options[:card_token] = r.authorization.split('|').first
@@ -23,7 +23,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def authorize(money, payment, options={})
+      def authorize(money, payment, options = {})
         MultiResponse.run do |r|
           r.process { commit('tokenize', 'card_tokens', card_token_request(money, payment, options)) }
           options[:card_token] = r.authorization.split('|').first
@@ -31,7 +31,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         post = {}
         authorization, = authorization.split('|')
         post[:capture] = true
@@ -39,20 +39,20 @@ module ActiveMerchant #:nodoc:
         commit('capture', "payments/#{authorization}", post)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         post = {}
         authorization, original_amount = authorization.split('|')
         post[:amount] = amount(money).to_f if original_amount && original_amount.to_f > amount(money).to_f
         commit('refund', "payments/#{authorization}/refunds", post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         authorization, = authorization.split('|')
         post = { status: 'cancelled' }
         commit('void', "payments/#{authorization}", post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }

data/lib/active_merchant/billing/gateways/merchant_e_solutions.rb

@@ -169,8 +169,7 @@ module ActiveMerchant #:nodoc:
           authorization: response['transaction_id'],
           test: test?,
           cvv_result: response['cvv2_result'],
-          avs_result: { code: response['avs_result'] }
-        )
+          avs_result: { code: response['avs_result'] })
       end
 
       def message_from(response)

data/lib/active_merchant/billing/gateways/merchant_one.rb

@@ -79,7 +79,7 @@ module ActiveMerchant #:nodoc:
         post['ccexp'] = "#{sprintf('%02d', creditcard.month)}#{creditcard.year.to_s[-2, 2]}"
       end
 
-      def commit(action, money, parameters={})
+      def commit(action, money, parameters = {})
         parameters['username'] = @options[:username]
         parameters['password'] = @options[:password]
         parse(ssl_post(BASE_URL, post_data(action, parameters)))

data/lib/active_merchant/billing/gateways/merchant_partners.rb

@@ -13,12 +13,12 @@ module ActiveMerchant #:nodoc:
       self.money_format = :dollars
       self.supported_cardtypes = %i[visa master american_express discover diners_club jcb]
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :account_id, :merchant_pin)
         super
       end
 
-      def purchase(amount, payment_method, options={})
+      def purchase(amount, payment_method, options = {})
         post = {}
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
@@ -27,7 +27,7 @@ module ActiveMerchant #:nodoc:
         commit(payment_method.is_a?(String) ? :stored_purchase : :purchase, post)
       end
 
-      def authorize(amount, payment_method, options={})
+      def authorize(amount, payment_method, options = {})
         post = {}
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
@@ -36,7 +36,7 @@ module ActiveMerchant #:nodoc:
         commit(:authorize, post)
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         post = {}
         add_invoice(post, amount, options)
         add_reference(post, authorization)
@@ -45,14 +45,14 @@ module ActiveMerchant #:nodoc:
         commit(:capture, post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         post = {}
         add_reference(post, authorization)
 
         commit(:void, post)
       end
 
-      def refund(amount, authorization, options={})
+      def refund(amount, authorization, options = {})
         post = {}
         add_invoice(post, amount, options)
         add_reference(post, authorization)
@@ -61,7 +61,7 @@ module ActiveMerchant #:nodoc:
         commit(:refund, post)
       end
 
-      def credit(amount, payment_method, options={})
+      def credit(amount, payment_method, options = {})
         post = {}
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
@@ -69,7 +69,7 @@ module ActiveMerchant #:nodoc:
         commit(payment_method.is_a?(String) ? :stored_credit : :credit, post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }
@@ -111,9 +111,9 @@ module ActiveMerchant #:nodoc:
 
       def add_payment_method(post, payment_method)
         if payment_method.is_a?(String)
-          user_profile_id, last_4 = split_authorization(payment_method)
+          user_profile_id, last4 = split_authorization(payment_method)
           post[:userprofileid] = user_profile_id
-          post[:last4digits] = last_4
+          post[:last4digits] = last4
         else
           post[:ccname] = payment_method.name
           post[:ccnum] = payment_method.number

data/lib/active_merchant/billing/gateways/merchant_ware.rb

@@ -13,10 +13,10 @@ module ActiveMerchant #:nodoc:
 
       ENV_NAMESPACES = { 'xmlns:xsi'  => 'http://www.w3.org/2001/XMLSchema-instance',
                          'xmlns:xsd'  => 'http://www.w3.org/2001/XMLSchema',
-                         'xmlns:env' => 'http://schemas.xmlsoap.org/soap/envelope/'}
+                         'xmlns:env' => 'http://schemas.xmlsoap.org/soap/envelope/' }
       ENV_NAMESPACES_V4 = { 'xmlns:xsi'  => 'http://www.w3.org/2001/XMLSchema-instance',
                             'xmlns:xsd'  => 'http://www.w3.org/2001/XMLSchema',
-                            'xmlns:soap' => 'http://schemas.xmlsoap.org/soap/envelope/'}
+                            'xmlns:soap' => 'http://schemas.xmlsoap.org/soap/envelope/' }
 
       TX_NAMESPACE = 'http://merchantwarehouse.com/MerchantWARE/Client/TransactionRetail'
       TX_NAMESPACE_V4 = 'http://schemas.merchantwarehouse.com/merchantware/40/Credit/'
@@ -272,7 +272,7 @@ module ActiveMerchant #:nodoc:
           response[element.name] = element.text
         end
 
-        response[:message] = response['faultstring'].to_s.gsub("\n", ' ')
+        response[:message] = response['faultstring'].to_s.tr("\n", ' ')
         response
       rescue REXML::ParseException
         response[:http_body]        = http_response.body
@@ -292,8 +292,7 @@ module ActiveMerchant #:nodoc:
         begin
           data = ssl_post(url(v4), request,
             'Content-Type' => 'text/xml; charset=utf-8',
-            'SOAPAction'   => soap_action(action, v4)
-          )
+            'SOAPAction'   => soap_action(action, v4))
           response = parse(action, data)
         rescue ActiveMerchant::ResponseError => e
           response = parse_error(e.response)
@@ -303,8 +302,7 @@ module ActiveMerchant #:nodoc:
           test: test?,
           authorization: authorization_from(response),
           avs_result: { code: response['AVSResponse'] },
-          cvv_result: response['CVResponse']
-        )
+          cvv_result: response['CVResponse'])
       end
 
       def authorization_from(response)

data/lib/active_merchant/billing/gateways/merchant_ware_version_four.rb

@@ -108,7 +108,7 @@ module ActiveMerchant #:nodoc:
         commit(:refund, request)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }
@@ -243,7 +243,7 @@ module ActiveMerchant #:nodoc:
           response[element.name] = element.text
         end
 
-        response[:message] = response['ErrorMessage'].to_s.gsub("\n", ' ')
+        response[:message] = response['ErrorMessage'].to_s.tr("\n", ' ')
         response
       rescue REXML::ParseException
         response[:http_body]        = http_response.body
@@ -263,8 +263,7 @@ module ActiveMerchant #:nodoc:
         begin
           data = ssl_post(url, request,
             'Content-Type' => 'text/xml; charset=utf-8',
-            'SOAPAction'   => soap_action(action)
-          )
+            'SOAPAction'   => soap_action(action))
           response = parse(action, data)
         rescue ActiveMerchant::ResponseError => e
           response = parse_error(e.response, action)
@@ -274,8 +273,7 @@ module ActiveMerchant #:nodoc:
           test: test?,
           authorization: authorization_from(response),
           avs_result: { code: response['AvsResponse'] },
-          cvv_result: response['CvResponse']
-        )
+          cvv_result: response['CvResponse'])
       end
 
       def authorization_from(response)

data/lib/active_merchant/billing/gateways/mercury.rb

@@ -69,14 +69,14 @@ module ActiveMerchant #:nodoc:
         commit('Return', request)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         requires!(options, :credit_card) unless @use_tokenization
 
         request = build_authorized_request('VoidSale', nil, authorization, options[:credit_card], options)
         commit('VoidSale', request)
       end
 
-      def store(credit_card, options={})
+      def store(credit_card, options = {})
         request = build_card_lookup_request(credit_card, options)
         commit('CardLookup', request)
       end
@@ -211,11 +211,11 @@ module ActiveMerchant #:nodoc:
             # handle with the validation error as it sees fit.
             # Track 2 requires having the STX and ETX stripped. Track 1 does not.
             # Max-length track 1s require having the STX and ETX stripped. Max is 79 bytes including LRC.
-            is_track_2 = credit_card.track_data[0] == ';'
+            is_track2 = credit_card.track_data[0] == ';'
             etx_index = credit_card.track_data.rindex('?') || credit_card.track_data.length
             is_max_track1 = etx_index >= 77
 
-            if is_track_2
+            if is_track2
               xml.tag! 'Track2', credit_card.track_data[1...etx_index]
             elsif is_max_track1
               xml.tag! 'Track1', credit_card.track_data[1...etx_index]