activeadmin 0.5.1 → 0.6.0

data/docs/3-index-pages/create-an-index.md

@@ -0,0 +1,29 @@
+# Create an Index
+
+If the supplied Active Admin index components are insufficient for your project
+feel free to define your own. Index classes extend ActiveAdmin::Component and 
+require a build method and an index_name class method.
+
+    module ActiveAdmin
+      module Views
+      	class IndexAsMyIdea < ActiveAdmin::Component
+
+          def build(page_presenter, collection)
+            ...
+          end
+
+          def self.index_name
+            "my_idea"
+          end
+
+        end
+      end
+    end
+
+The build method takes a PagePresenter object and collection of whatever you 
+choose.
+
+The index_name class method takes no arguments and returns a string that should
+be representative of the the class name. If this method is not defined, your
+index component will not be able take advantage of Active Admin's 
+*multiple index pages* feature.

data/docs/3-index-pages/index-as-table.md

@@ -28,12 +28,11 @@ If the default title does not work for you, pass it as the first argument:
       column "My Custom Title", :title
     end
 
-Sometimes calling methods just isn't enough and you need to write some view
-specific code. For example, say we wanted a colum called Title which holds a
-link to the posts admin screen.
+Sometimes that just isn't enough and you need to write some view-specific code.
+For example, say we wanted a "Title" column that links to the posts admin screen.
 
-The column method accepts a block as an argument which will then be rendered
-within the context of the view for each of the objects in the collection.
+`column` accepts a block that will be rendered for each of the objects in the collection.
+The block is called once for each resource, which is passed as an argument to the block.
 
     index do
       column "Title" do |post|
@@ -41,21 +40,27 @@ within the context of the view for each of the objects in the collection.
       end
     end
 
-The block gets called once for each resource in the collection. The resource gets passed into
-the block as an argument.
+To setup links to View, Edit and Delete a resource, use the `actions` method:
 
-To setup links to View, Edit and Delete a resource, use the default_actions method:
+    index do
+      column :title
+      actions
+    end
+
+You can also append custom links to the default links:
 
     index do
       column :title
-      default_actions
+      actions do |post|
+        link_to "Preview", admin_preview_post_path(post), :class => "member_link"
+      end
     end
 
-Alternatively, you can create a column with custom links:
+Or forego the default links entirely:
 
     index do
       column :title
-      column "Actions" do |post|
+      actions :defaults => false do |post|
         link_to "View", admin_post_path(post)
       end
     end
@@ -81,6 +86,25 @@ You can turn off sorting on any column by passing false:
       column :title, :sortable => false
     end
 
+## Associated Sorting
+
+You're normally able to sort columns alphabetically, but by default you
+can't sort by associated objects. Though with a few simple changes, you can.
+
+Assuming you're on the Books index page, and Book has_one Publisher:
+
+    controller do
+      def scoped_collection
+        resource_class.includes(:publisher) # prevents N+1 queries to your database
+      end
+    end
+
+Then it's simple to sort by any Publisher attribute from within the index table:
+
+    index do
+      column :publisher, sortable: 'publishers.name'
+    end
+
 ## Showing and Hiding Columns
 
 The entire index block is rendered within the context of the view, so you can

data/docs/5-forms.md

@@ -14,7 +14,7 @@ the fabulous DSL created by Formtastic (http://github.com/justinfrench/formtasti
         f.inputs "Content" do
           f.input :body
         end
-        f.buttons
+        f.actions
       end
 
     end
@@ -35,5 +35,5 @@ Then implement app/views/admin/posts/_form.html.erb:
 
     <%= semantic_form_for [:admin, @post] do |f| %>
       <%= f.inputs :title, :body %>
-      <%= f.buttons :commit %>
+      <%= f.actions :commit %>
     <% end %>

data/features/authorization.feature

@@ -0,0 +1,64 @@
+Feature: Authorizing Access
+
+  Ensure that access denied exceptions are managed
+
+  Background:
+    Given I am logged in
+    And 1 post exists
+    And a configuration of:
+    """
+    class OnlyAuthorsAuthorization < ActiveAdmin::AuthorizationAdapter
+
+      def authorized?(action, subject = nil)
+        case subject
+
+        when normalized(Post)
+          case action
+          when ActiveAdmin::Auth::UPDATE, ActiveAdmin::Auth::DESTROY
+            false
+          else
+            true
+          end
+
+        when ActiveAdmin::Page
+          if subject.name == "No Access"
+            false
+          else
+            true
+          end
+
+        else
+          false
+        end
+      end
+
+    end
+
+    ActiveAdmin.application.namespace(:admin).authorization_adapter = OnlyAuthorsAuthorization
+
+    ActiveAdmin.register Post do
+    end
+
+    ActiveAdmin.register_page "No Access" do
+    end
+    """
+    And I am on the index page for posts
+
+  @allow-rescue
+  Scenario: Attempt to access a resource I am not authorized to see
+    When I go to the last post's edit page
+    Then I should see "You are not authorized to perform this action"
+
+  Scenario: Viewing the default action items
+    When I follow "View"
+    Then I should not see an action item link to "Edit"
+
+  @allow-rescue
+  Scenario: Attempting to visit a Page without authorization
+    When I go to the admin no access page
+    Then I should see "You are not authorized to perform this action"
+
+  @allow-rescue
+  Scenario: Viewing a page with authorization
+    When I go to the admin dashboard page
+    Then I should see "Dashboard"

data/features/authorization_cancan.feature

@@ -0,0 +1,52 @@
+Feature: Authorizing Access using CanCan
+
+  Background:
+    Given I am logged in
+    And 1 post exists
+    And a configuration of:
+    """
+    require 'cancan'
+
+    class ::Ability 
+      include ::CanCan::Ability
+
+      def initialize(user)
+        # Manage Posts
+        can [:edit, :destroy], Post, :author_id => user.id
+        can :read, Post
+
+        # View Pages
+        can :read, ActiveAdmin::Page, :name => "Dashboard"
+        cannot :read, ActiveAdmin::Page, :name => "No Access"
+      end
+
+    end
+
+    ActiveAdmin.application.namespace(:admin).authorization_adapter = ActiveAdmin::CanCanAdapter
+
+    ActiveAdmin.register Post do
+    end
+
+    ActiveAdmin.register_page "No Access" do
+    end
+    """
+    And I am on the index page for posts
+
+  @allow-rescue
+  Scenario: Attempt to access a resource I am not authorized to see
+    When I go to the last post's edit page
+    Then I should see "You are not authorized to perform this action"
+
+  Scenario: Viewing the default action items
+    When I follow "View"
+    Then I should not see an action item link to "Edit"
+
+  @allow-rescue
+  Scenario: Attempting to visit a Page without authorization
+    When I go to the admin no access page
+    Then I should see "You are not authorized to perform this action"
+
+  @allow-rescue
+  Scenario: Viewing a page with authorization
+    When I go to the admin dashboard page
+    Then I should see "Dashboard"

data/features/belongs_to.feature

@@ -3,6 +3,11 @@ Feature: Belongs To
   A resource belongs to another resource
 
   Background:
+    Given I am logged in
+    And a post with the title "Hello World" written by "John Doe" exists
+    And a post with the title "Hello World" written by "Jane Doe" exists
+
+  Scenario: Viewing the child resource index page
     Given a configuration of:
     """
       ActiveAdmin.register User
@@ -10,18 +15,49 @@ Feature: Belongs To
         belongs_to :user
       end
     """
-    And I am logged in
-    And a post with the title "Hello World" written by "John Doe" exists
-    And a post with the title "Hello World" written by "Jane Doe" exists
-
-  Scenario: Viewing the child resource index page
     When I go to the last author's posts
     Then the "Users" tab should be selected
+    And I should not see a menu item for "Posts"
     And I should see "Displaying 1 Post"
     And I should see a link to "Users" in the breadcrumb
 
   Scenario: Viewing a child resource page
+    Given a configuration of:
+    """
+      ActiveAdmin.register User
+      ActiveAdmin.register Post do
+        belongs_to :user
+      end
+    """
     When I go to the last author's posts
     And I follow "View"
     Then I should be on the last author's last post page
     And the "Users" tab should be selected
+
+  Scenario: When the belongs to is optional
+    Given a configuration of:
+    """
+      ActiveAdmin.register User
+      ActiveAdmin.register Post do
+        belongs_to :user, :optional => true
+      end
+    """
+    When I go to the last author's posts
+    Then the "Users" tab should be selected
+    And I should see a menu item for "Posts"
+
+    When I follow "Posts"
+    Then the "Posts" tab should be selected
+
+  Scenario: Displaying belongs to resources in main menu
+    Given a configuration of:
+    """
+      ActiveAdmin.register User
+      ActiveAdmin.register Post do
+        belongs_to :user
+        navigation_menu :user
+      end
+    """
+    When I go to the last author's posts
+    And I follow "View"
+    Then the "Posts" tab should be selected

data/features/index/batch_actions.feature

@@ -12,14 +12,38 @@ Feature: Batch Actions
     And I should see 10 posts in the table
 
     When I check the 1st record
-    When I check the 2nd record
+    And I check the 2nd record
     And I follow "Batch Actions"
     Then I should see the batch action :destroy "Delete Selected"
 
+    Given I submit the batch action form with "destroy"
+    Then I should see a flash with "Successfully destroyed 2 posts"
+    And I should see 8 posts in the table
+
+  Scenario: Use default (destroy) batch action on a nested resource
+    Given I am logged in
+    And 5 posts written by "John Doe" exist
+    And a configuration of:
+    """
+      ActiveAdmin.register User
+      ActiveAdmin.register Post do
+        belongs_to :user
+      end
+    """
+    When I go to the last author's posts
+    Then I should see the batch action button
+    And I should see that the batch action button is disabled
+    And I should see the batch action popover exists
+    And I should see 5 posts in the table
+
+    When I check the 2nd record
+    And I check the 4th record
+    And I follow "Batch Actions"
+    Then I should see the batch action :destroy "Delete Selected"
 
     Given I submit the batch action form with "destroy"
-    Then I should see a flash with "Successfully destroyed 1 post"
-    And I should see 9 posts in the table
+    Then I should see a flash with "Successfully destroyed 2 posts"
+    And I should see 3 posts in the table
 
   Scenario: Using a custom batch action
     Given 10 posts exist

data/features/index/formats.feature

@@ -10,3 +10,30 @@ Feature: Index Formats
     Then I should see a link to download "CSV"
     And I should see a link to download "XML"
     And I should see a link to download "JSON"
+
+  Scenario: View index with download_links set to false
+    Given an index configuration of:
+    """
+      ActiveAdmin.register Post do
+        index :download_links => false
+      end
+    """
+    And 1 post exists
+    When I am on the index page for posts
+    Then I should not see a link to download "CSV"
+    And I should not see a link to download "XML"
+    And I should not see a link to download "JSON"
+
+  Scenario: View index with pdf download link set
+    Given an index configuration of:
+    """
+      ActiveAdmin.register Post do
+        index :download_links => [:pdf]
+      end
+    """
+    And 1 post exists
+    When I am on the index page for posts
+    Then I should not see a link to download "CSV"
+    And I should not see a link to download "XML"
+    And I should not see a link to download "JSON"
+    And I should see a link to download "PDF"

data/features/index/index_as_table.feature

@@ -11,6 +11,7 @@ Feature: Index as Table
     When I am on the index page for posts
     Then I should see a sortable table header with "Id"
     And I should see a sortable table header with "Title"
+    And I should see a table with id "index_table_posts"
 
   Scenario: Viewing the default table with a resource
     Given a post with the title "Hello World" exists
@@ -92,6 +93,46 @@ Feature: Index as Table
     And I should see a member link to "Edit"
     And I should not see a member link to "Delete"
 
+  Scenario: Actions with defaults and custom actions
+    Given a post with the title "Hello World" and body "From the body" exists
+    And an index configuration of:
+      """
+      ActiveAdmin.register Post do
+        actions :index, :show, :edit, :update
+
+        index do
+          column :category
+          actions do |resource|
+            link_to 'Custom Action', edit_admin_post_path(resource), :class => 'member_link'
+          end
+        end
+      end
+      """
+    Then I should see a member link to "View"
+    And I should see a member link to "Edit"
+    And I should not see a member link to "Delete"
+    And I should see a member link to "Custom Action"
+
+  Scenario: Actions without default actions
+    Given a post with the title "Hello World" and body "From the body" exists
+    And an index configuration of:
+      """
+      ActiveAdmin.register Post do
+        actions :index, :show, :edit, :update
+
+        index do
+          column :category
+          actions :defaults => false do |resource|
+            link_to 'Custom Action', edit_admin_post_path(resource), :class => 'member_link'
+          end
+        end
+      end
+      """
+    Then I should not see a member link to "View"
+    And I should not see a member link to "Edit"
+    And I should not see a member link to "Delete"
+    And I should see a member link to "Custom Action"
+
   Scenario: Associations are not sortable
     Given 1 post exists
     And an index configuration of:
@@ -112,12 +153,43 @@ Feature: Index as Table
       ActiveAdmin.register Post
       """
     When I am on the index page for posts
-    Then I should see the "posts" table:
+    Then I should see the "index_table_posts" table:
       | [ ] | Id | Title        | Body | Published At | Starred | Created At | Updated At | |
       | [ ] | 2 | Bye bye world | Move your...  |  |  | /.*/ | /.*/ | ViewEditDelete |
       | [ ] | 1 | Hello World   | From the body |  |  | /.*/ | /.*/ | ViewEditDelete |
     When I follow "Id"
-    Then I should see the "posts" table:
+    Then I should see the "index_table_posts" table:
       | [ ] | Id | Title        | Body | Published At | Starred | Created At | Updated At | |
       | [ ] | 1 | Hello World   | From the body |  |  | /.*/ | /.*/ | ViewEditDelete |
       | [ ] | 2 | Bye bye world | Move your...  |  |  | /.*/ | /.*/ | ViewEditDelete |
+
+  Scenario: Sorting by a virtual column
+    Given a post with the title "Hello World" exists
+    And a post with the title "Bye bye world" exists
+    And an index configuration of:
+      """
+        ActiveAdmin.register Post do
+          controller do
+            def scoped_collection
+              Post.select("id, title, length(title) as title_length")
+            end
+          end
+
+          index do
+            column :id
+            column :title
+            column("Title Length", :sortable => :title_length) { |post| post.title_length }
+          end
+        end
+      """
+    When I am on the index page for posts
+    And I follow "Title Length"
+    Then I should see the "index_table_posts" table:
+      | Id | Title        | Title Length |
+      | 2 | Bye bye world | 13 |
+      | 1 | Hello World   | 11 |    
+    When I follow "Title Length"
+    Then I should see the "index_table_posts" table:
+      | Id | Title        | Title Length |
+      | 1 | Hello World   | 11 |
+      | 2 | Bye bye world | 13 |