activeadmin 0.5.1 → 0.6.0

data/spec/unit/authorization/authorization_adapter_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe ActiveAdmin::AuthorizationAdapter do
+
+  let(:adapter) { ActiveAdmin::AuthorizationAdapter.new(stub, stub) }
+
+  describe "#authorized?" do
+
+    it "should always return true" do
+      adapter.authorized?(:read, "Resource").should == true
+    end
+
+  end
+
+  describe "#scope_collection" do
+
+    it "should return the collection unscoped" do
+      collection = stub
+      adapter.scope_collection(collection).should == collection
+    end
+
+  end
+
+  describe "using #normalized in a subclass" do
+
+    let(:auth_class) do
+      Class.new(ActiveAdmin::AuthorizationAdapter) do 
+
+        def authorized?(action, subject = nil)
+          case subject
+          when normalized(String)
+            true
+          else
+            false
+          end
+        end
+
+      end
+    end
+
+    let(:adapter) { auth_class.new(stub, stub) }
+
+    it "should match agains a class" do
+      adapter.authorized?(:read, String).should == true
+    end
+
+    it 'should match against an instance' do
+      adapter.authorized?(:read, "String").should == true
+    end
+
+    it 'should not match a different class' do
+      adapter.authorized?(:read, Hash).should == false
+    end
+
+    it 'should not match a different instance' do
+      adapter.authorized?(:read, {}).should == false
+    end
+
+  end
+
+end

data/spec/unit/authorization/controller_authorization_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Admin::PostsController, "Controller Authorization", :type => :controller do
+
+  let(:user) { AdminUser.create!(:email => "example@admin.com", :password => "password", :password_confirmation => "password") }
+  let(:app) { ActiveAdmin.application }
+  let(:authorization){ controller.send(:active_admin_authorization) }
+
+  before do
+  # TODO: Get these tests passing...
+    pending
+
+    load_defaults!
+    @request.env["devise.mapping"] = Devise.mappings[:admin]
+    @resource.namespace.current_user_method = :current_admin_user
+
+    sign_in(user)
+  end
+
+  it "should authorize the index action" do
+    authorization.should_receive(:authorized?).
+      with(ActiveAdmin::Authorization::READ, Post).
+      and_return(true)
+
+    get :index
+  end
+
+  it "should authorize the new action" do
+    authorization.should_receive(:authorized?).
+      with(ActiveAdmin::Authorization::CREATE, an_instance_of(Post)).
+      and_return(true)
+
+    get :new
+  end
+
+  it "should authorize the create action with the new resource" do
+    mock_post = mock("Post", :save => true, :errors => [])
+    Post.should_receive(:new).at_least(:once).and_return(mock_post)
+
+    authorization.should_receive(:authorized?).
+      with(ActiveAdmin::Authorization::CREATE, mock_post).
+      and_return(true)
+
+    post :create
+  end
+
+end

data/spec/unit/base_controller_spec.rb

@@ -1,8 +1,6 @@
 require 'spec_helper'
-require File.expand_path('base_controller_shared_examples', File.dirname(__FILE__))
 
 describe ActiveAdmin::BaseController do
   let(:controller) { ActiveAdmin::BaseController.new }
 
-  it_should_behave_like "BaseController"
 end

data/spec/unit/batch_actions/resource_spec.rb

@@ -54,7 +54,7 @@ describe ActiveAdmin::BatchActions::ResourceExtension do
   describe "#batch_action_path" do
 
     it "returns the path as a symbol" do
-      resource.batch_action_path.should == :batch_action_admin_posts_path
+      resource.batch_action_path.should == "/admin/posts/batch_action"
     end
 
   end

data/spec/unit/breadcrumbs_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper' 
+require 'spec_helper'
 
 describe "Breadcrumbs" do
 
@@ -73,7 +73,7 @@ describe "Breadcrumbs" do
 
       context "when Post.find(1) does exist" do
         before do
-          Post.stub!(:find).and_return{ mock(:display_name => "Hello World") }
+          Post.stub!(:find_by_id).and_return{ mock(:display_name => "Hello World") }
         end
         it "should have a link to /admin/posts/1 using display name" do
           trail[2][:name].should == "Hello World"
@@ -106,7 +106,7 @@ describe "Breadcrumbs" do
 
       context "when Post.find(4e24d6249ccf967313000000) does exist" do
         before do
-          Post.stub!(:find).with('4e24d6249ccf967313000000').and_return{ mock(:display_name => "Hello World") }
+          Post.stub!(:find_by_id).with('4e24d6249ccf967313000000').and_return{ mock(:display_name => "Hello World") }
         end
         it "should have a link to /admin/posts/4e24d6249ccf967313000000 using display name" do
           trail[2][:name].should == "Hello World"

data/spec/unit/cancan_adapter_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe ActiveAdmin::CanCanAdapter do
+
+  describe "full integration" do
+
+    let(:application){ ActiveAdmin::Application.new }
+    let(:namespace){ ActiveAdmin::Namespace.new(application, "Admin") }
+    let(:resource){ namespace.register(Post) }
+
+    let :mock_ability_class do
+      Class.new do
+        include CanCan::Ability
+
+        def initialize(user)
+          can :read, Post
+          cannot :update, Post
+        end
+
+      end
+    end
+
+    it "should initialize the ability stored in the namespace configuration" do
+      namespace.authorization_adapter = ActiveAdmin::CanCanAdapter
+      namespace.cancan_ability_class = mock_ability_class
+
+      auth = namespace.authorization_adapter.new(resource, mock)
+
+      auth.authorized?(:read, Post).should == true
+      auth.authorized?(:update, Post).should == false
+    end
+
+  end
+
+end

data/spec/unit/config_shared_examples.rb

@@ -31,22 +31,18 @@ shared_examples_for "ActiveAdmin::Config" do
   end
 
   describe "Menu" do
-    describe "menu item" do
+    describe "#menu_item_options" do
 
-    it "initializes a new menu item with defaults" do
-        config.menu_item.label.should == config.plural_resource_label
-    end
+      it "initializes a new menu item with defaults" do
+          config.menu_item_options[:label].call.should == config.plural_resource_label
+      end
 
-    it "initialize a new menu item with custom options" do
-      config.menu :label => "Hello"
-      config.menu_item.label.should == "Hello"
-    end
+      it "initialize a new menu item with custom options" do
+        config.menu_item_options = { :label => "Hello" }
+        config.menu_item_options[:label].should == "Hello"
+      end
 
-    it "initialize a new menu item with label as Proc object" do
-      config.menu :label => proc { "Hello" }
-      config.menu_item.label.should == "Hello"
     end
-  end
 
     describe "#include_in_menu?" do
       it "should be included in menu by default" do
@@ -54,27 +50,10 @@ shared_examples_for "ActiveAdmin::Config" do
       end
 
       it "should not be included in menu when menu set to false" do
-        config.menu false
+        config.menu_item_options = false
         config.include_in_menu?.should == false
       end
     end
 
-    describe "parent menu item name" do
-
-      it "should be nil when not set" do
-        config.parent_menu_item_name.should == nil
-      end
-
-      it "should return the name if set" do
-        config.menu :parent => "Blog"
-        config.parent_menu_item_name.should == "Blog"
-      end
-
-      it "initialize a new parent menu item with label as Proc object" do
-        config.menu :parent => proc{ "Blog" }
-        config.parent_menu_item_name.should == "Blog"
-      end
-    end
-
   end
 end

data/spec/unit/devise_spec.rb

@@ -42,6 +42,35 @@ describe ActiveAdmin::Devise::Controller do
     end
     
   end
+
+  context "within a scoped route" do
+
+    SCOPE = '/aa_scoped'
+
+    before do
+      # Remove existing routes
+      routes = Rails.application.routes
+      routes.clear!
+
+      # Add scoped routes
+      routes.draw do
+        scope :path => SCOPE do
+          ActiveAdmin.routes(self)
+          devise_for :admin_users, ActiveAdmin::Devise.config
+        end
+      end
+    end
+
+    after do
+      # Resume default routes
+      reload_routes!
+    end
+
+    it "should include scope path in root_path" do
+      controller.root_path.should == "#{SCOPE}/admin"
+    end
+
+  end
   
   describe "#config" do
     let(:config) { ActiveAdmin::Devise.config }

data/spec/unit/dsl_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+
+module MockModuleToInclude
+  def self.included(dsl)
+  end
+end
+
+describe ActiveAdmin::DSL do
+
+  let(:config){ mock }
+  let(:application) { ActiveAdmin::Application.new }
+  let(:namespace) { ActiveAdmin::Namespace.new application, :admin }
+  let(:resource_config) { ActiveAdmin::Resource.new namespace, Post }
+  let(:dsl){ ActiveAdmin::DSL.new(config) }
+
+  describe "#include" do
+
+    it "should call the included class method on the module that is included" do
+      MockModuleToInclude.should_receive(:included).with(dsl)
+      dsl.run_registration_block do
+        include MockModuleToInclude
+      end
+    end
+
+  end
+
+  describe "#menu" do
+
+    it "should set the menu_item_options on the configuration" do
+      config.should_receive(:menu_item_options=).with({:parent => "Admin"})
+      dsl.run_registration_block do
+        menu :parent => "Admin"
+      end
+    end
+
+  end
+
+  describe "#navigation_menu" do
+
+    it "should set the navigation_menu_name on the configuration" do
+      config.should_receive(:navigation_menu_name=).with(:admin)
+      dsl.run_registration_block do
+        navigation_menu :admin
+      end
+    end
+
+    it "should accept a block" do
+
+      dsl = ActiveAdmin::DSL.new(resource_config)
+      dsl.run_registration_block do
+        navigation_menu { :dynamic_menu }
+      end
+
+      resource_config.navigation_menu_name.should == :dynamic_menu
+
+    end
+
+  end
+
+end

data/spec/unit/filters/filter_form_builder_spec.rb

@@ -22,16 +22,19 @@ describe ActiveAdmin::Filters::ViewHelper do
     view
   end
 
-  def render_filter(search, name, options = {})
-    render_arbre_component({:filter_args => [search, [options.merge(:attribute => name)]]}, helpers) do
+  def render_filter(search, filters)
+    render_arbre_component({:filter_args => [search, filters]}, helpers) do
       text_node active_admin_filters_form_for(*assigns[:filter_args])
     end
   end
 
   def filter(name, options = {})
-    render_filter Post.search, name, options
+    render_filter Post.search, @filters.push(options.merge(:attribute => name))
   end
 
+  before(:each) { @filters = [] }
+
+
   describe "the form in general" do
     let(:body) { filter :title }
 
@@ -72,6 +75,22 @@ describe ActiveAdmin::Filters::ViewHelper do
         I18n.backend.reload!
       end
     end
+
+    context "using starts_with and as" do
+      let(:body) { filter :title_starts_with, :as => :string }
+
+      it "should generate a search field for a string attribute with query starts_with" do
+        body.should have_tag("input", :attributes => { :name => "q[title_starts_with]" })
+      end
+    end
+
+    context "using ends_with and as" do
+      let(:body) { filter :title_ends_with, :as => :string }
+
+      it "should generate a search field for a string attribute with query starts_with" do
+        body.should have_tag("input", :attributes => { :name => "q[title_ends_with]" })
+      end
+    end
   end
 
   describe "text attribute" do
@@ -217,11 +236,46 @@ describe ActiveAdmin::Filters::ViewHelper do
     context "when polymorphic relationship" do
       let(:body) do
         search = ActiveAdmin::Comment.search
-        render_filter(search, :resource)
+        render_filter(search, [{:attribute => :resource}])
       end
       it "should not generate any field" do
         body.should have_tag("form", :attributes => { :method => 'get' })
       end
     end
   end # belongs to
+
+
+  describe "conditional display" do
+
+    context "with :if block" do
+      let(:body) do
+        filter :body,   :if => proc{true}
+        filter :author, :if => proc{false}
+      end
+
+      it "should be displayed if true" do
+        body.should have_tag("input", :attributes => { :name => "q[body_contains]"})
+      end
+
+      it "should NOT be displayed if false" do
+        body.should_not have_tag("input", :attributes => { :name => "q[author_id_eq]"})
+      end
+    end
+
+    context "with :unless block" do
+      let(:body) do
+        filter :created_at, :unless => proc{false}
+        filter :updated_at, :unless => proc{true}
+      end
+
+      it "should be displayed if false" do
+        body.should have_tag("input", :attributes => { :name => "q[created_at_gte]"})
+      end
+
+      it "should NOT be displayed if true" do
+        body.should_not have_tag("input", :attributes => { :name => "q[updated_at_gte]"})
+      end
+    end
+  end
+
 end

data/spec/unit/filters/resource_spec.rb

@@ -28,12 +28,25 @@ describe ActiveAdmin::Filters::ResourceExtension do
     resource.filters.should be_empty
   end
 
-  it "should remove a filter" do
-    resource.filters.should include({:attribute => :author})
-    resource.remove_filter :author
-    resource.filters.should_not include({:attribute => :author})
+  context "filter removal" do
+    it "should work" do
+      resource.filters.should include :attribute => :author
+      resource.remove_filter :author
+      resource.filters.should_not include :attribute => :author
+    end
+
+    it "should be lazy" do
+      resource.should_not_receive :default_filters # this hits the DB
+      resource.remove_filter :author
+    end
+
+    it "should not prevent the default filters from being added" do
+      resource.remove_filter :author
+      resource.filters.should_not be_empty
+    end
   end
 
+  # TODO: wrap the below in a context like "filter removal" was above
   it "should add a filter" do
     resource.add_filter :title
     resource.filters.should == [{:attribute => :title}]
@@ -70,5 +83,4 @@ describe ActiveAdmin::Filters::ResourceExtension do
     resource.sidebar_sections.first.name.should == :filters
   end
 
-
 end