activeadmin 0.4.4 → 0.5.0.pre

data/spec/unit/views/components/attributes_table_spec.rb

@@ -2,8 +2,6 @@ require 'spec_helper'
 
 describe ActiveAdmin::Views::AttributesTable do
 
-  setup_arbre_context!
-
   describe "creating with the dsl" do
     let(:helpers) { action_view }
 
@@ -14,31 +12,40 @@ describe ActiveAdmin::Views::AttributesTable do
       post
     end
 
+    let(:assigns){ { :post => post } }
 
     # Loop through a few different ways to make the same table
     # and ensure that they produce the same results
     {
       "when attributes are passed in to the builder methods" => proc {
-        attributes_table_for post, :id, :title, :body
+        render_arbre_component(assigns) {
+          attributes_table_for post, :id, :title, :body
+        }
       },
       "when attributes are built using the block" => proc {
-        attributes_table_for post do
-          rows :id, :title, :body
-        end
+        render_arbre_component(assigns) {
+          attributes_table_for post do
+            rows :id, :title, :body
+          end
+        }
       },
       "when each attribute is passed in by itself" => proc {
-        attributes_table_for post do
-          row :id
-          row :title
-          row :body
-        end
+        render_arbre_component(assigns) {
+          attributes_table_for post do
+            row :id
+            row :title
+            row :body
+          end
+        }
       },
       "when you create each row with a custom block" => proc {
-        attributes_table_for post do
-          row("Id")   { post.id }
-          row("Title"){ post.title }
-          row("Body") { post.body }
-        end
+        render_arbre_component(assigns) {
+          attributes_table_for post do
+            row("Id")   { post.id }
+            row("Title"){ post.title }
+            row("Body") { post.body }
+          end
+        }
       }
 
     }.each do |context_title, table_decleration|
@@ -49,6 +56,7 @@ describe ActiveAdmin::Views::AttributesTable do
           table.tag_name.should == 'div'
           table.attr(:class).should include('attributes_table')
         end
+
         it "should add id and type class" do
           table.class_names.should include("post")
           table.id.should == "attributes_table_post_1"
@@ -83,15 +91,19 @@ describe ActiveAdmin::Views::AttributesTable do
     end # describe dsl styles
 
     it "should allow html content inside the attributes table" do
-      table = attributes_table_for(post) do
-        row("ID"){ span(post.id, :class => 'id') }
-      end
+      table = render_arbre_component(assigns) {
+        attributes_table_for(post) do
+          row("ID"){ span(post.id, :class => 'id') }
+        end
+      }
       table.find_by_tag("td").first.content.chomp.strip.should == "<span class=\"id\">1</span>"
     end
 
     it "should check if an association exists when an attribute has id in it" do
       post.author = User.new(:username => "john_doe")
-      table = attributes_table_for post, :author_id
+      table = render_arbre_component(assigns) {
+        attributes_table_for post, :author_id
+      }
       table.find_by_tag("td").first.content.should == "john_doe"
     end
 

data/spec/unit/views/components/batch_action_popover_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+require 'active_admin/batch_actions/views/batch_action_popover'
+
+describe ActiveAdmin::BatchActions::BatchActionPopover do
+
+  let(:the_popover) do
+    render_arbre_component do
+      batch_action_popover do
+        action ActiveAdmin::BatchAction.new( :action_1, "Action 1" )
+        action ActiveAdmin::BatchAction.new( :action_2, "Action 2" )
+        action ActiveAdmin::BatchAction.new( :action_3, "Action 3" )
+      end
+    end
+  end
+  
+  it "should have an id" do
+    the_popover.id.should == "batch_actions_popover"
+  end
+  
+  describe "the action list" do
+    subject do
+      the_popover.find_by_class("popover_contents").first
+    end
+
+    its(:tag_name) { should eql("ul") }
+    
+    its(:content){ should include("<li><a href=\"#\" class=\"batch_action\" data-action=\"action_1\">Action 1 Selected</a></li>") }
+    its(:content){ should include("<li><a href=\"#\" class=\"batch_action\" data-action=\"action_2\">Action 2 Selected</a></li>") }
+    its(:content){ should include("<li><a href=\"#\" class=\"batch_action\" data-action=\"action_3\">Action 3 Selected</a></li>") }
+    
+  end
+
+end

data/spec/unit/views/components/blank_slate_spec.rb

@@ -2,10 +2,12 @@ require 'spec_helper'
 
 describe ActiveAdmin::Views::BlankSlate do
 
-  setup_arbre_context!
-
   describe "#blank_slate" do
-    subject { blank_slate("There are no Posts yet. <a href=\"/posts/new\">Create one</a></span>") }
+    subject do
+      render_arbre_component do
+        blank_slate("There are no Posts yet. <a href=\"/posts/new\">Create one</a></span>")
+      end
+    end
 
     its(:tag_name)    { should eql 'div' }
     its(:class_list)  { should include('blank_slate_container') }

data/spec/unit/views/components/columns_spec.rb

@@ -2,12 +2,12 @@ require 'spec_helper'
 
 describe ActiveAdmin::Views::Columns do
 
-  setup_arbre_context!
-
   describe "Rendering one column" do
     let(:cols) do
-      columns do
-        column { span "Hello World" }
+      render_arbre_component do
+        columns do
+          column { span "Hello World" }
+        end
       end
     end
 
@@ -27,9 +27,11 @@ describe ActiveAdmin::Views::Columns do
 
   describe "Rendering two columns" do
     let(:cols) do
-      columns do
-        column { span "Hello World" }
-        column { span "Hello World" }
+      render_arbre_component do
+        columns do
+          column { span "Hello World" }
+          column { span "Hello World" }
+        end
       end
     end
 
@@ -48,11 +50,13 @@ describe ActiveAdmin::Views::Columns do
 
   describe "Rendering four columns" do
     let(:cols) do
-      columns do
-        column { span "Hello World" }
-        column { span "Hello World" }
-        column { span "Hello World" }
-        column { span "Hello World" }
+      render_arbre_component do
+        columns do
+          column { span "Hello World" }
+          column { span "Hello World" }
+          column { span "Hello World" }
+          column { span "Hello World" }
+        end
       end
     end
 
@@ -75,10 +79,12 @@ describe ActiveAdmin::Views::Columns do
 
   describe "Column Spans" do
     let(:cols) do
-      columns do
-        column(:span => 2){ "Hello World" }
-        column(){ "Hello World" }
-        column(){ "Hello World" }
+      render_arbre_component do
+        columns do
+          column(:span => 2){ "Hello World" }
+          column(){ "Hello World" }
+          column(){ "Hello World" }
+        end
       end
     end
 
@@ -94,9 +100,11 @@ describe ActiveAdmin::Views::Columns do
   describe "Column max width" do
 
     let(:cols) do
-      columns do
-        column(:max_width => "100px"){ "Hello World" }
-        column(){ "Hello World" }
+      render_arbre_component do
+        columns do
+          column(:max_width => "100px"){ "Hello World" }
+          column(){ "Hello World" }
+        end
       end
     end
 
@@ -113,9 +121,11 @@ describe ActiveAdmin::Views::Columns do
   describe "Column min width" do
 
     let(:cols) do
-      columns do
-        column(:min_width => "100px"){ "Hello World" }
-        column(){ "Hello World" }
+      render_arbre_component do
+        columns do
+          column(:min_width => "100px"){ "Hello World" }
+          column(){ "Hello World" }
+        end
       end
     end
 

data/spec/unit/views/components/paginated_collection_spec.rb

@@ -2,21 +2,33 @@ require 'spec_helper'
 
 describe ActiveAdmin::Views::PaginatedCollection do
   describe "creating with the dsl" do
-    setup_arbre_context!
-
-    let(:collection) do
-      posts = [Post.new(:title => "First Post"), Post.new(:title => "Second Post"), Post.new(:title => "Third Post")]
-      Kaminari.paginate_array(posts).page(1).per(5)
-    end
 
     before :all do
       load_defaults!
       reload_routes!
     end
 
+    let(:view) do
+      view = mock_action_view
+      view.request.stub!(:query_parameters).and_return({:controller => 'admin/posts', :action => 'index', :page => '1'})
+      view.controller.params = {:controller => 'admin/posts', :action => 'index'}
+      view
+    end
+
+    # Helper to render paginated collections within an arbre context
+    def paginated_collection(*args)
+      render_arbre_component({:paginated_collection_args => args}, view) do
+        paginated_collection(*paginated_collection_args)
+      end
+    end
+
+    let(:collection) do
+      posts = [Post.new(:title => "First Post"), Post.new(:title => "Second Post"), Post.new(:title => "Third Post")]
+      Kaminari.paginate_array(posts).page(1).per(5)
+    end
+
     before do
-      request.stub!(:query_parameters).and_return({:controller => 'admin/posts', :action => 'index', :page => '1'})
-      controller.params = {:controller => 'admin/posts', :action => 'index'}
+      collection.stub!(:reorder) { collection }
     end
 
     context "when specifying collection" do
@@ -44,7 +56,7 @@ describe ActiveAdmin::Views::PaginatedCollection do
       let(:pagination) { paginated_collection(collection, :param_name => :post_page) }
 
       it "should customize the page number parameter in pagination links" do
-        pagination.find_by_tag('div')[1].content.should match(/\/admin\/posts\?post_page=2/)
+        pagination.children.last.content.should match(/\/admin\/posts\?post_page=2/)
       end
     end
 
@@ -116,7 +128,7 @@ describe ActiveAdmin::Views::PaginatedCollection do
       end
 
       it "should use 'Singular' as the collection name when there is an I18n translation" do
-        I18n.stub(:translate!) { "Singular" }
+        I18n.stub(:translate) { "Singular" }
         pagination.find_by_class('pagination_information').first.content.should == "Displaying <b>1</b> Singular"
       end
     end
@@ -129,7 +141,7 @@ describe ActiveAdmin::Views::PaginatedCollection do
       end
 
       it "should use 'Plural' as the collection name when there is an I18n translation" do
-        I18n.stub(:translate!) { "Plural" }
+        I18n.stub(:translate) { "Plural" }
         pagination.find_by_class('pagination_information').first.content.should == "Displaying <b>all 3</b> Plural"
       end
     end
@@ -150,7 +162,7 @@ describe ActiveAdmin::Views::PaginatedCollection do
     context "when collection comes from find with GROUP BY" do
       let(:collection) do
         %w{Foo Foo Bar}.each {|title| Post.create(:title => title) }
-        Post.group(:title).page(1).per(5)
+        Post.select(:title).group(:title).page(1).per(5)
       end
 
       let(:pagination) { paginated_collection(collection) }
@@ -159,5 +171,35 @@ describe ActiveAdmin::Views::PaginatedCollection do
         pagination.find_by_class('pagination_information').first.content.should == "Displaying <b>all 2</b> posts"
       end
     end
+
+    context "when collection with many pages comes from find with GROUP BY" do
+      let(:collection) do
+        %w{Foo Foo Bar Baz}.each {|title| Post.create(:title => title) }
+        Post.select(:title).group(:title).page(1).per(2)
+      end
+
+      let(:pagination) { paginated_collection(collection) }
+
+      it "should display proper message (including number and not hash)" do
+        pagination.find_by_class('pagination_information').first.content.
+          gsub('&nbsp;',' ').should == "Displaying posts <b>1 - 2</b> of <b>3</b> in total"
+      end
+    end
+
+    context "when viewing the last page of a collection that has multiple pages" do
+      let(:collection) do
+        posts = [Post.new] * 81
+        Kaminari.paginate_array(posts).page(3).per(30)
+      end
+
+      let(:pagination) { paginated_collection(collection) }
+
+      it "should show the proper item counts" do
+        pagination.find_by_class('pagination_information').first.content.
+            gsub('&nbsp;',' ').should == "Displaying posts <b>61 - 81</b> of <b>81</b> in total"
+      end
+    end
+
+
   end
 end

data/spec/unit/views/components/panel_spec.rb

@@ -2,11 +2,11 @@ require 'spec_helper'
 
 describe ActiveAdmin::Views::Panel do
 
-  setup_arbre_context!
-
   let(:the_panel) do
-    panel "My Title" do
-      span("Hello World")
+    render_arbre_component do
+      panel "My Title" do
+        span("Hello World")
+      end
     end
   end
 
@@ -23,13 +23,18 @@ describe ActiveAdmin::Views::Panel do
   end
 
   it "should set the icon" do
-    panel("Title", :icon => :arrow_down).find_by_tag("h3").first.content.should include("span class=\"icon")
+    the_panel = render_arbre_component do
+      panel("Title", :icon => :arrow_down)
+    end
+    the_panel.find_by_tag("h3").first.content.should include("span class=\"icon")
   end
 
   describe "#children?" do
 
     it "returns false if no children have been added to the panel" do
-      the_panel = panel("A Panel")
+      the_panel = render_arbre_component do
+        panel("A Panel")
+      end
       the_panel.children?.should == false
     end
 

data/spec/unit/views/components/popover_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe ActiveAdmin::Views::Popover do
+
+  let(:the_popover) do
+    render_arbre_component do
+      popover :id => "my_awesome_popover" do
+        para "Hello World, this is popover content baby."
+      end
+    end
+  end
+
+  it "should have the class of 'sidebar_section'" do
+    the_popover.class_list.should include("popover")
+  end
+
+  it "should have an inner content element class of 'popover_contents'" do
+    the_popover.find_by_tag("div").first.class_list.should include("popover_contents")
+  end
+
+  it "should have the popover content in the inner content element" do
+    the_popover.find_by_class("popover_contents").first.content.should include("Hello World, this is popover content baby.")
+  end
+
+  it "should have an id" do
+    the_popover.id.should == "my_awesome_popover"
+  end
+
+  it "should be hidden" do
+    the_popover.attributes.should include(:style => "display: none");
+  end
+
+end

data/spec/unit/views/components/sidebar_section_spec.rb

@@ -2,20 +2,20 @@ require 'spec_helper'
 
 describe ActiveAdmin::Views::SidebarSection do
 
-  setup_arbre_context!
-
   let(:section) do
-    ActiveAdmin::SidebarSection.new(:help) do
+    ActiveAdmin::SidebarSection.new("Help Section") do
       span "Help Me"
     end
   end
 
   let(:html) do
-    sidebar_section(section)
+    render_arbre_component :section => section do
+      sidebar_section(assigns[:section])
+    end
   end
 
   it "should have a title h3" do
-    html.find_by_tag("h3").first.content.should == "Help"
+    html.find_by_tag("h3").first.content.should == "Help Section"
   end
 
   it "should have the class of 'sidebar_section'" do
@@ -23,7 +23,7 @@ describe ActiveAdmin::Views::SidebarSection do
   end
 
   it "should have an id based on the title" do
-    html.id.should == "help_sidebar_section"
+    html.id.should == "help-section_sidebar_section"
   end
 
   it "should have a contents div" do