activeadmin 0.4.4 → 0.5.0.pre

data/spec/unit/batch_actions/resource_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+describe ActiveAdmin::BatchActions::ResourceExtension do
+
+  let(:resource) do
+    namespace = ActiveAdmin::Namespace.new(ActiveAdmin::Application.new, :admin)
+    namespace.batch_actions = true
+    namespace.register(Post)
+  end
+  
+  describe "default action" do
+
+    it "should have the default action by default" do
+      resource.batch_actions.size.should == 1 and resource.batch_actions.first.sym == :destroy
+    end
+
+  end
+  
+  describe "adding a new batch action" do
+
+    before do
+      resource.clear_batch_actions!
+      resource.add_batch_action :flag, "Flag" do
+        # Empty
+      end
+    end
+
+    it "should add an batch action" do
+      resource.batch_actions.size.should == 1
+    end
+
+    it "should store an instance of BatchAction" do
+      resource.batch_actions.first.should be_an_instance_of(ActiveAdmin::BatchAction)
+    end
+
+    it "should store the block in the batch action" do
+      resource.batch_actions.first.block.should_not be_nil
+    end
+
+  end
+  
+  describe "removing batch action" do
+    
+    before do
+      resource.remove_batch_action :destroy
+    end
+    
+    it "should allow for batch action removal" do
+      resource.batch_actions.size.should == 0
+    end
+    
+  end
+
+  describe "#batch_action_path" do
+
+    it "returns the path as a symbol" do
+      resource.batch_action_path.should == :batch_action_admin_posts_path
+    end
+
+  end
+
+  describe "#display_if_block" do
+
+    it "should return true by default" do
+      action = ActiveAdmin::BatchAction.new :default, "Default"
+      action.display_if_block.call.should == true
+    end
+
+    it "should return the :if block if set" do
+      action = ActiveAdmin::BatchAction.new :with_block, "With Block", :if => proc { false } 
+      action.display_if_block.call.should == false
+    end
+
+  end
+  
+  describe "batch action priority" do
+    
+    it "should have a default priority" do
+      action = ActiveAdmin::BatchAction.new :default, "Default"
+      action.priority.should == 10
+    end
+    
+    it "should correctly order two actions" do
+      priority_one = ActiveAdmin::BatchAction.new :one, "One", :priority => 1
+      priority_ten = ActiveAdmin::BatchAction.new :ten, "Ten", :priority => 10
+      priority_one.should be < priority_ten
+    end
+    
+  end
+
+end

data/spec/unit/batch_actions/settings_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe "Batch Actions Settings" do
+  let(:app) { ActiveAdmin::Application.new }
+  let(:ns) { ActiveAdmin::Namespace.new(app, "Admin") }
+  let(:post_resource) { ns.register Post }
+
+  it "should be disabled globally by default" do
+    # Note: the default initializer would set it to true
+
+    app.batch_actions.should be_false
+    ns.batch_actions.should be_false
+    post_resource.batch_actions_enabled?.should be_false
+  end
+
+  it "should be settable to true" do
+    app.batch_actions = true
+    app.batch_actions.should == true
+  end
+
+  it "should be an inheritable_setting" do
+    app.batch_actions = true
+    ns.batch_actions.should == true
+  end
+
+  it "should be settable at the namespace level" do
+    app.batch_actions = true
+    ns.batch_actions = false
+
+    app.batch_actions.should == true
+    ns.batch_actions.should == false
+  end
+
+  it "should be settable at the resource level" do
+    post_resource.batch_actions_enabled?.should == false
+    post_resource.batch_actions = true
+    post_resource.batch_actions_enabled?.should == true
+  end
+
+  it "should inherit the setting on the resource from the namespace" do
+    ns.batch_actions = false
+    post_resource.batch_actions_enabled?.should == false
+    post_resource.batch_actions.should be_empty
+
+    post_resource.batch_actions = true
+    post_resource.batch_actions_enabled?.should == true
+    post_resource.batch_actions.should_not be_empty
+  end
+
+  it "should inherit the setting from the namespace when set to nil" do
+    ns.batch_actions = true
+
+    post_resource.batch_actions = true
+    post_resource.batch_actions_enabled?.should == true
+    post_resource.batch_actions.should_not be_empty
+
+    post_resource.batch_actions = nil
+    post_resource.batch_actions_enabled?.should == true # inherited from namespace
+    post_resource.batch_actions.should_not be_empty
+  end
+end

data/spec/unit/breadcrumbs_spec.rb

@@ -82,6 +82,39 @@ describe "Breadcrumbs" do
       end
     end
 
+    context "when path '/admin/posts/4e24d6249ccf967313000000/comments'" do
+      let(:path) { "/admin/posts/4e24d6249ccf967313000000/comments" }
+
+      it "should have 3 items" do
+        trail.size.should == 3
+      end
+      it "should have a link to /admin" do
+        trail[0][:name].should == "Admin"
+        trail[0][:path].should == "/admin"
+      end
+      it "should have a link to /admin/posts" do
+        trail[1][:name].should == "Posts"
+        trail[1][:path].should == "/admin/posts"
+      end
+
+      context "when Post.find(4e24d6249ccf967313000000) doesn't exist" do
+        it "should have a link to /admin/posts/4e24d6249ccf967313000000" do
+          trail[2][:name].should == "4e24d6249ccf967313000000"
+          trail[2][:path].should == "/admin/posts/4e24d6249ccf967313000000"
+        end
+      end
+
+      context "when Post.find(4e24d6249ccf967313000000) does exist" do
+        before do
+          Post.stub!(:find).with('4e24d6249ccf967313000000').and_return{ mock(:display_name => "Hello World") }
+        end
+        it "should have a link to /admin/posts/4e24d6249ccf967313000000 using display name" do
+          trail[2][:name].should == "Hello World"
+          trail[2][:path].should == "/admin/posts/4e24d6249ccf967313000000"
+        end
+      end
+    end
+
     context "when path '/admin/posts/1/coments/1'" do
       let(:path) { "/admin/posts/1/comments/1" }
 

data/spec/unit/comments_spec.rb

@@ -4,7 +4,13 @@ describe "Comments" do
   let(:application){ ActiveAdmin::Application.new }
 
   describe ActiveAdmin::Comment do
+    subject { ActiveAdmin::Comment }
+
     describe "Associations and Validations" do
+      before do
+        pending "This is not passing on Travis-CI. See Issue #1273."
+      end
+
       it { should belong_to :resource }
       it { should belong_to :author }
 

data/spec/unit/config_shared_examples.rb

@@ -21,56 +21,27 @@ shared_examples_for "ActiveAdmin::Config" do
   it { respond_to :sidebar_sections? }
 
   describe "Naming" do
-    it "implements #resource_name" do
-      expect { config.resource_name }.should_not raise_error
+    it "implements #resource_label" do
+      expect { config.resource_label }.should_not raise_error
     end
 
-    it "implements #plural_resource_name" do
-      expect { config.plural_resource_name }.should_not raise_error
-    end
-
-    it "implements #safe_resource_name" do
-      expect { config.safe_resource_name }.should_not raise_error
-    end
-
-    describe "#camelized_resource_name" do
-      it "returns a camelized version of the safe_resource_name" do
-        config.should_receive(:safe_resource_name).and_return "My resource"
-        config.camelized_resource_name.should == "MyResource"
-      end
+    it "implements #plural_resource_label" do
+      expect { config.plural_resource_label }.should_not raise_error
     end
+  end
 
-    describe "#plural_camelized_resource_name" do
-      it "returns a camelized version of the plural_safe_resource_name" do
-        config.should_receive(:safe_resource_name).and_return "My resource"
-        config.camelized_resource_name.should == "MyResource"
-      end
-    end
+  describe "Menu" do
+    describe "menu item" do
 
-    describe "#underscored_resource_name" do
-      it "returns the camelized_resource_name underscored" do
-        config.should_receive(:camelized_resource_name).and_return "MyResource"
-        config.underscored_resource_name.should == "my_resource"
-      end
-    end
+	  it "initializes a new menu item with defaults" do
+        config.menu_item.label.should == config.plural_resource_label
+	  end
 
-    describe "#plural_underscored_resource_name" do
-      it "returns the plural_camelized_resource_name underscored" do
-        config.should_receive(:plural_camelized_resource_name).and_return "MyResources"
-        config.plural_underscored_resource_name.should == "my_resources"
+      it "initialize a new menu item with custom options" do
+		config.menu :label => "Hello"
+        config.menu_item.label.should == "Hello"
       end
-    end
-  end
 
-  describe "Menu" do
-    describe "menu item name" do
-      it "should be the plural resource name when not set" do
-        config.menu_item_name.should == config.plural_resource_name
-      end
-      it "should be settable" do
-        config.menu :label => "My Label"
-        config.menu_item_name.should == "My Label"
-      end
     end
 
     describe "#include_in_menu?" do
@@ -85,35 +56,17 @@ shared_examples_for "ActiveAdmin::Config" do
     end
 
     describe "parent menu item name" do
+
       it "should be nil when not set" do
         config.parent_menu_item_name.should == nil
       end
+
       it "should return the name if set" do
-        config.tap do |c|
-          c.menu :parent => "Blog"
-        end.parent_menu_item_name.should == "Blog"
+		config.menu :parent => "Blog"
+        config.parent_menu_item_name.should == "Blog"
       end
-    end
 
-    describe "menu item priority" do
-      it "should be 10 when not set" do
-        config.menu_item_priority.should == 10
-      end
-      it "should be settable" do
-        config.menu :priority => 2
-        config.menu_item_priority.should == 2
-      end
     end
 
-    describe "menu item display if" do
-      it "should be a proc always returning true if not set" do
-        config.menu_item_display_if.should be_instance_of(Proc)
-        config.menu_item_display_if.call.should == true
-      end
-      it "should be settable" do
-        config.menu :if => proc { false }
-        config.menu_item_display_if.call.should == false
-      end
-    end
   end
 end

data/spec/unit/csv_builder_spec.rb

@@ -37,7 +37,7 @@ describe ActiveAdmin::CSVBuilder do
       end
     end
 
-    it "should have one colum" do
+    it "should have one column" do
       builder.columns.size.should == 1
     end
 
@@ -63,7 +63,7 @@ describe ActiveAdmin::CSVBuilder do
       end
     end
 
-    it "should have one colum" do
+    it "should have one column" do
       builder.columns.size.should == 1
     end
 
@@ -80,4 +80,14 @@ describe ActiveAdmin::CSVBuilder do
     end
   end
 
+  context "with a separator" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new :separator => ";"
+    end
+
+    it "should have proper separator" do
+      builder.column_separator.should == ";"
+    end
+  end
+
 end

data/spec/unit/dashboard_controller_spec.rb

@@ -1,11 +1,17 @@
 require 'spec_helper' 
 
+require 'active_admin/dashboards/dashboard_controller'
+require 'active_admin/dashboards/section'
 
 module Admin
-  class DashboardController < ActiveAdmin::Dashboards::DashboardController
+  class TestDashboardController < ActiveAdmin::PageController
+    include ActiveAdmin::Dashboards::DashboardController
   end
 end
-class DashboardController < ActiveAdmin::Dashboards::DashboardController; end
+
+class TestDashboardController < ActiveAdmin::PageController
+  include ActiveAdmin::Dashboards::DashboardController
+end
 
 describe ActiveAdmin::Dashboards::DashboardController do
 
@@ -13,19 +19,19 @@ describe ActiveAdmin::Dashboards::DashboardController do
     subject{ controller.send :namespace }
 
     context "when admin namespace" do
-      let(:controller){ Admin::DashboardController.new }
+      let(:controller){ Admin::TestDashboardController.new }
       it { should == :admin }
     end
 
     context "when root namespace" do
-      let(:controller){ DashboardController.new }
+      let(:controller){ TestDashboardController.new }
       it { should == :root }
     end
   end
 
   describe "conditionally displaying sections" do
     before { ActiveAdmin::Dashboards.clear_all_sections! }
-    let(:controller){ Admin::DashboardController.new }
+    let(:controller){ Admin::TestDashboardController.new }
     
     context "when :if not specified" do
       before do

data/spec/unit/dsl_include_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+module MockModuleToInclude
+  def self.included(dsl)
+  end
+end
+
+
+describe ActiveAdmin::DSL, "#include" do
+
+  let(:dsl){ ActiveAdmin::DSL.new(mock) }
+
+  it "should call the included class method on the module that is included" do
+    MockModuleToInclude.should_receive(:included).with(dsl)
+    dsl.run_registration_block do
+      include MockModuleToInclude
+    end
+  end
+
+end

data/spec/unit/{filter_form_builder_spec.rb → filters/filter_form_builder_spec.rb}

@@ -1,9 +1,7 @@
 require 'spec_helper' 
 
 
-describe ActiveAdmin::ViewHelpers::FilterFormHelper do
-
-  setup_arbre_context!
+describe ActiveAdmin::Filters::ViewHelper do
 
   # Setup an ActionView::Base object which can be used for
   # generating the form for.
@@ -24,9 +22,14 @@ describe ActiveAdmin::ViewHelpers::FilterFormHelper do
     view
   end
 
+  def render_filter(search, name, options = {})
+    render_arbre_component({:filter_args => [search, [options.merge(:attribute => name)]]}, helpers) do
+      text_node active_admin_filters_form_for(*assigns[:filter_args])
+    end
+  end
+
   def filter(name, options = {})
-    search = Post.search
-    active_admin_filters_form_for(search, [options.merge(:attribute => name)])
+    render_filter Post.search, name, options
   end
 
   describe "the form in general" do
@@ -42,7 +45,7 @@ describe ActiveAdmin::ViewHelpers::FilterFormHelper do
     end
 
     it "should only generate the form once" do
-      body.scan(/q\[title_contains\]/).size.should == 1
+      body.to_s.scan(/q\[title_contains\]/).size.should == 1
     end
 
     it "should generate a clear filters link" do
@@ -190,7 +193,7 @@ describe ActiveAdmin::ViewHelpers::FilterFormHelper do
     context "when polymorphic relationship" do
       let(:body) do
         search = ActiveAdmin::Comment.search
-        active_admin_filters_form_for(search, [{ :attribute => :resource}])
+        render_filter(search, :resource)
       end
       it "should not generate any field" do
         body.should have_tag("form", :attributes => { :method => 'get' })