activeadmin-rails 1.7.0

data/spec/unit/namespace_spec.rb

@@ -0,0 +1,132 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::Namespace do
+
+  let(:application){ ActiveAdmin::Application.new }
+
+  context "when new" do
+    let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
+
+    it "should have an application instance" do
+      expect(namespace.application).to eq application
+    end
+
+    it "should have a name" do
+      expect(namespace.name).to eq :admin
+    end
+
+    it "should have no resources" do
+      expect(namespace.resources).to be_empty
+    end
+
+    it "should not have any menu item" do
+      expect(namespace.fetch_menu(:default).children).to be_empty
+    end
+  end # context "when new"
+
+  describe "#unload!" do
+    context "when controller is only defined without a namespace" do
+      before do
+        # To ensure Admin::PostsController is defined
+        ActiveAdmin.register Post
+
+        # To ensure ::PostsController is defined
+        ActiveAdmin.register Post, namespace: false
+
+        # To prevent unload! from unregistering ::PostsController
+        ActiveAdmin.application.namespaces.instance_variable_get(:@namespaces).delete(:root)
+
+        # To force Admin::PostsController to not be there
+        Admin.send(:remove_const, 'PostsController')
+      end
+
+      it "should not crash" do
+        expect { ActiveAdmin.unload! }.not_to raise_error
+      end
+    end
+  end
+
+  describe "settings" do
+    let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
+
+    it "should inherit the site title from the application" do
+      if Rails.gem_version >= Gem::Version.new("7.1.0")
+        Rails.application.deprecators.silence do
+          ActiveAdmin::Namespace.setting :site_title, "Not the Same"
+        end
+      else
+        ActiveSupport::Deprecation.silence do
+          ActiveAdmin::Namespace.setting :site_title, "Not the Same"
+        end
+      end
+      expect(namespace.site_title).to eq application.site_title
+    end
+
+    it "should be able to override the site title" do
+      expect(namespace.site_title).to eq application.site_title
+      namespace.site_title = "My Site Title"
+      expect(namespace.site_title).to_not eq application.site_title
+    end
+  end
+
+  describe "#fetch_menu" do
+    let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
+
+    it "returns the menu" do
+      expect(namespace.fetch_menu(:default)).to be_an_instance_of(ActiveAdmin::Menu)
+    end
+
+    it "should have utility nav menu" do
+      expect(namespace.fetch_menu(:utility_navigation)).to be_an_instance_of(ActiveAdmin::Menu)
+    end
+
+    it "should raise an exception if the menu doesn't exist" do
+      expect {
+        namespace.fetch_menu(:not_a_menu_that_exists)
+      }.to raise_error(KeyError)
+    end
+  end
+
+  describe "#build_menu" do
+    let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
+
+    it "should set the block as a menu build callback" do
+      namespace.build_menu do |menu|
+        menu.add label: "menu item"
+      end
+
+      expect(namespace.fetch_menu(:default)["menu item"]).to_not eq nil
+    end
+
+    it "should set a block on a custom menu" do
+      namespace.build_menu :test do |menu|
+        menu.add label: "menu item"
+      end
+
+      expect(namespace.fetch_menu(:test)["menu item"]).to_not eq nil
+    end
+  end
+
+  describe "utility navigation" do
+    let(:namespace){ ActiveAdmin::Namespace.new(application, :admin) }
+    let(:menu) do
+      namespace.build_menu :utility_navigation do |menu|
+        menu.add label: "ActiveAdmin.org", url: "http://www.activeadmin.org", html_options: { target: :blank }
+        namespace.add_logout_button_to_menu menu, 1, class: "matt"
+      end
+      namespace.fetch_menu(:utility_navigation)
+    end
+
+    it "should have a logout button to the far left" do
+      expect(menu["Logout"]).to_not eq nil
+      expect(menu["Logout"].priority).to eq 1
+    end
+
+    it "should have a static link with a target of :blank" do
+      expect(menu["ActiveAdmin.org"]).to_not eq nil
+      expect(menu["ActiveAdmin.org"].html_options).to include(target: :blank)
+    end
+
+  end
+
+end

data/spec/unit/order_clause_spec.rb

@@ -0,0 +1,81 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::OrderClause do
+  subject { described_class.new(config, clause) }
+
+  let(:application) { ActiveAdmin::Application.new }
+  let(:namespace) { ActiveAdmin::Namespace.new application, :admin }
+  let(:config) { ActiveAdmin::Resource.new namespace, Post }
+
+  describe 'id_asc (existing column)' do
+    let(:clause) { 'id_asc' }
+
+    it { is_expected.to be_valid }
+
+    describe '#field' do
+      subject { super().field }
+      it { is_expected.to eq('id') }
+    end
+
+    describe '#order' do
+      subject { super().order }
+      it { is_expected.to eq('asc') }
+    end
+
+    specify '#to_sql prepends table name' do
+      expect(subject.to_sql).to eq '"posts"."id" asc'
+    end
+  end
+
+  describe 'virtual_column_asc' do
+    let(:clause) { 'virtual_column_asc' }
+
+    it { is_expected.to be_valid }
+
+    describe '#field' do
+      subject { super().field }
+      it { is_expected.to eq('virtual_column') }
+    end
+
+    describe '#order' do
+      subject { super().order }
+      it { is_expected.to eq('asc') }
+    end
+
+    specify '#to_sql' do
+      expect(subject.to_sql).to eq '"virtual_column" asc'
+    end
+  end
+
+  describe "hstore_col->'field'_desc" do
+    let(:clause) { "hstore_col->'field'_desc" }
+
+    it { is_expected.to be_valid }
+
+    describe '#field' do
+      subject { super().field }
+      it { is_expected.to eq("hstore_col->'field'") }
+    end
+
+    describe '#order' do
+      subject { super().order }
+      it { is_expected.to eq('desc') }
+    end
+
+    it 'converts to sql' do
+      expect(subject.to_sql).to eq %Q("hstore_col"->'field' desc)
+    end
+  end
+
+  describe '_asc' do
+    let(:clause) { '_asc' }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe 'nil' do
+    let(:clause) { nil }
+
+    it { is_expected.not_to be_valid }
+  end
+end

data/spec/unit/page_controller_spec.rb

@@ -0,0 +1,5 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::PageController do
+  let(:controller) { ActiveAdmin::PageController.new }
+end

data/spec/unit/page_spec.rb

@@ -0,0 +1,128 @@
+require 'rails_helper'
+require File.expand_path('config_shared_examples', File.dirname(__FILE__))
+
+module ActiveAdmin
+  RSpec.describe Page do
+
+    it_should_behave_like "ActiveAdmin::Resource"
+    before { load_defaults! }
+
+    let(:application){ ActiveAdmin::Application.new }
+    let(:namespace){ Namespace.new(application, :admin) }
+    let(:page_name) { "Chocolate I lØve You!" }
+
+    def config(options = {})
+      @config ||= namespace.register_page("Chocolate I lØve You!", options)
+    end
+
+    describe "controller name" do
+      it "should return a namespaced controller name" do
+        expect(config.controller_name).to eq "Admin::ChocolateILoveYouController"
+      end
+      context "when non namespaced controller" do
+        let(:namespace){ ActiveAdmin::Namespace.new(application, :root) }
+        it "should return a non namespaced controller name" do
+          expect(config.controller_name).to eq "ChocolateILoveYouController"
+        end
+      end
+    end
+
+    describe "#resource_name" do
+      it "returns the name" do
+        expect(config.resource_name).to eq "Chocolate I lØve You!"
+      end
+
+      it "returns the singular, lowercase name" do
+        if RUBY_VERSION >= '2.4.0'
+          expect(config.resource_name.singular).to eq "chocolate i løve you!"
+        else
+          expect(config.resource_name.singular).to eq "chocolate i lØve you!"
+        end
+      end
+    end
+
+    describe "#plural_resource_label" do
+      it "returns the singular name" do
+        expect(config.plural_resource_label).to eq "Chocolate I lØve You!"
+      end
+    end
+
+    describe "#underscored_resource_name" do
+      it "returns the resource name underscored" do
+        expect(config.underscored_resource_name).to eq "chocolate_i_love_you"
+      end
+    end
+
+    describe "#camelized_resource_name" do
+      it "returns the resource name camel case" do
+        expect(config.camelized_resource_name).to eq "ChocolateILoveYou"
+      end
+    end
+
+    describe "#namespace_name" do
+      it "returns the name of the namespace" do
+        expect(config.namespace_name).to eq "admin"
+      end
+    end
+
+    it "should not belong_to anything" do
+      expect(config.belongs_to?).to eq false
+    end
+
+    it "should not have any action_items" do
+      expect(config.action_items?).to eq false
+    end
+
+    it "should not have any sidebar_sections" do
+      expect(config.sidebar_sections?).to eq false
+    end
+
+    context "with belongs to config" do
+      let!(:post_config) { namespace.register Post }
+      let!(:page_config) {
+        namespace.register_page page_name do
+          belongs_to :post
+        end
+      }
+
+      it "configures page with belongs_to" do
+        expect(page_config.belongs_to?).to be true
+      end
+
+      it "sets navigation menu to parent" do
+        expect(page_config.navigation_menu_name).to eq :post
+      end
+
+      it "builds a belongs_to relationship" do
+        belongs_to = page_config.belongs_to_config
+
+        expect(belongs_to.target).to eq(post_config)
+        expect(belongs_to.owner).to eq(page_config)
+        expect(belongs_to.optional?).to be_falsy
+      end
+
+      it "forwards belongs_to call to controller" do
+        options = { optional: true }
+        expect(page_config.controller).to receive(:belongs_to).with(:post, options)
+        page_config.belongs_to :post, options
+      end
+    end # context "with belongs to config" do
+
+    context "with optional belongs to config" do
+      let!(:post_config) { namespace.register Post }
+      let!(:page_config) {
+        namespace.register_page page_name do
+          belongs_to :post, optional: true
+        end
+      }
+
+      it "does not override default navigation menu" do
+        expect(page_config.navigation_menu_name).to eq(:default)
+      end
+    end # context "with optional belongs to config" do
+
+    it "has no belongs_to by default" do
+      expect(config.belongs_to?).to be_falsy
+    end
+  end
+end

data/spec/unit/pretty_format_spec.rb

@@ -0,0 +1,133 @@
+require 'rails_helper'
+require 'active_admin/view_helpers/display_helper'
+
+RSpec.describe "#pretty_format" do
+  let(:view_klass) do
+    Class.new(ActionView::Base) do
+      include ActiveAdmin::ViewHelpers
+    end
+  end
+
+  let(:view) { mock_action_view(view_klass) }
+
+  let(:formatted_obj) { view.pretty_format(obj) }
+
+  shared_examples_for 'an object convertible to string' do
+    it "should call `to_s` on the given object" do
+      expect(formatted_obj).to eq obj.to_s
+    end
+  end
+
+  context 'when given a string' do
+    let(:obj) { 'hello' }
+
+    it_behaves_like 'an object convertible to string'
+  end
+
+  context 'when given an integer' do
+    let(:obj) { 23 }
+
+    it_behaves_like 'an object convertible to string'
+  end
+
+  context 'when given a float' do
+    let(:obj) { 5.67 }
+
+    it_behaves_like 'an object convertible to string'
+  end
+
+  context 'when given an exponential' do
+    let(:obj) { 10**30 }
+
+    it_behaves_like 'an object convertible to string'
+  end
+
+  context 'when given a symbol' do
+    let(:obj) { :foo }
+
+    it_behaves_like 'an object convertible to string'
+  end
+
+  context 'when given an arbo element' do
+    let(:obj) { Arbo::Element.new.br }
+
+    it_behaves_like 'an object convertible to string'
+  end
+
+  shared_examples_for 'a time-ish object' do
+    it "formats it with the default long format" do
+      expect(formatted_obj).to eq "February 28, 1985 20:15"
+    end
+
+    it "formats it with a customized long format" do
+      with_translation time: { formats: { long: "%B %d, %Y, %l:%M%P" } } do
+        expect(formatted_obj).to eq "February 28, 1985,  8:15pm"
+      end
+    end
+
+    context "with a custom localize format" do
+      around do |example|
+        previous_localize_format = ActiveAdmin.application.localize_format
+        ActiveAdmin.application.localize_format = :short
+        example.call
+        ActiveAdmin.application.localize_format = previous_localize_format
+      end
+
+      it "formats it with the default custom format" do
+        expect(formatted_obj).to eq "28 Feb 20:15"
+      end
+
+      it "formats it with i18n custom format" do
+        with_translation time: { formats: { short: "%-m %d %Y" } } do
+          expect(formatted_obj).to eq "2 28 1985"
+        end
+      end
+    end
+
+    context "with non-English locale" do
+      around do |example|
+        I18n.with_locale(:es) { example.call }
+      end
+
+      it "formats it with the default long format" do
+        expect(formatted_obj).to eq "28 de febrero de 1985 20:15"
+      end
+
+      it "formats it with a customized long format" do
+        with_translation time: { formats: { long: "El %d de %B de %Y a las %H horas y %M minutos" } } do
+          expect(formatted_obj).to eq "El 28 de febrero de 1985 a las 20 horas y 15 minutos"
+        end
+      end
+    end
+  end
+
+  context 'when given a Time in utc' do
+    let(:obj) { Time.utc(1985, "feb", 28, 20, 15, 1) }
+
+    it_behaves_like 'a time-ish object'
+  end
+
+  context 'when given a DateTime' do
+    let(:obj) { DateTime.new(1985, 2, 28, 20, 15, 1) }
+
+    it_behaves_like 'a time-ish object'
+  end
+
+  context "given an ActiveRecord object" do
+    let(:obj) { Post.new }
+
+    it "should delegate to auto_link" do
+      expect(view).to receive(:auto_link).with(obj).and_return("model name")
+      expect(formatted_obj).to eq "model name"
+    end
+  end
+
+  context "given an arbitrary object" do
+    let(:obj)  { Class.new.new }
+
+    it "should delegate to `display_name`" do
+      expect(view).to receive(:display_name).with(obj) { "I'm not famous" }
+      expect(formatted_obj).to eq "I'm not famous"
+    end
+  end
+end

data/spec/unit/pundit_adapter_spec.rb

@@ -0,0 +1,98 @@
+require 'rails_helper'
+
+class DefaultPolicy < ApplicationPolicy
+  def respond_to_missing?(method, include_private = false)
+    method.to_s[0...3] == "foo" || super
+  end
+
+  def method_missing(method, *args, &block)
+    if method.to_s[0...3] == "foo"
+      method.to_s[4...7] == "yes"
+    else
+      super
+    end
+  end
+
+  class Scope
+
+    attr_reader :user, :scope
+
+    def initialize(user, scope)
+      @user = user
+      @scope = scope
+    end
+
+    def resolve
+      scope
+    end
+  end
+end
+
+RSpec.describe ActiveAdmin::PunditAdapter do
+
+  describe "full integration" do
+
+    let(:application) { ActiveAdmin::Application.new }
+    let(:namespace) { ActiveAdmin::Namespace.new(application, "Admin") }
+    let(:resource) { namespace.register(Post) }
+    let(:auth) { namespace.authorization_adapter.new(resource, double) }
+    let(:default_policy_klass) { DefaultPolicy }
+    let(:default_policy_klass_name) { "DefaultPolicy" }
+
+    before do
+      namespace.authorization_adapter = ActiveAdmin::PunditAdapter
+    end
+
+    it "should initialize the ability stored in the namespace configuration" do
+      expect(auth.authorized?(:read, Post)).to eq true
+      expect(auth.authorized?(:update, Post)).to eq false
+    end
+
+    it "should scope the collection" do
+      class RSpec::Mocks::DoublePolicy < ApplicationPolicy
+        class Scope < Struct.new(:user, :scope)
+          def resolve
+            scope
+          end
+        end
+      end
+
+      collection = double
+      auth.scope_collection(collection, :read)
+      expect(collection).to eq collection
+    end
+
+    it "works well with method_missing" do
+      allow(auth).to receive(:retrieve_policy).and_return(DefaultPolicy.new(double, double))
+      expect(auth.authorized?(:foo_no)).to eq false
+      expect(auth.authorized?(:foo_yes)).to eq true
+      expect(auth.authorized?(:bar_yes)).to eq false
+    end
+
+    context 'when Pundit is unable to find policy scope' do
+      let(:collection) { double("collection", to_sym: :collection) }
+      subject(:scope) { auth.scope_collection(collection, :read) }
+
+      before do
+        allow(ActiveAdmin.application).to receive(:pundit_default_policy).and_return default_policy_klass_name
+        allow(Pundit).to receive(:policy_scope!) { raise Pundit::NotDefinedError.new }
+      end
+
+      it("should return default policy's scope if defined") { is_expected.to eq(collection) }
+    end
+
+    context "when Pundit is unable to find policy" do
+      let(:record) { double }
+
+      subject(:policy) { auth.retrieve_policy(record) }
+
+      before do
+        allow(ActiveAdmin.application).to receive(:pundit_default_policy).and_return default_policy_klass_name
+        allow(Pundit).to receive(:policy!) { raise Pundit::NotDefinedError.new }
+      end
+
+      it("should return default policy instance") { is_expected.to be_instance_of(default_policy_klass) }
+    end
+  end
+
+end

data/spec/unit/resource/action_items_spec.rb

@@ -0,0 +1,83 @@
+require 'rails_helper'
+
+RSpec.describe ActiveAdmin::Resource::ActionItems do
+
+  let(:resource) do
+    namespace = ActiveAdmin::Namespace.new(ActiveAdmin::Application.new, :admin)
+    namespace.register(Post)
+  end
+
+  describe "adding a new action item" do
+
+    before do
+      resource.clear_action_items!
+      resource.add_action_item :empty, class: :test do
+        # Empty ...
+      end
+    end
+
+    it "should add an action item" do
+      expect(resource.action_items.size).to eq 1
+    end
+
+    it "should store an instance of ActionItem" do
+      expect(resource.action_items.first).to be_an_instance_of(ActiveAdmin::ActionItem)
+    end
+
+    it "should store the block in the action item" do
+      expect(resource.action_items.first.block).to_not eq nil
+    end
+
+    it "should include class from options" do
+      expect(resource.action_items.first.html_class).to eq("action_item test")
+    end
+
+    it 'should be ordered by priority' do
+      resource.add_action_item :first, priority: 0 do
+        # Empty ...
+      end
+      resource.add_action_item :some_other do
+        # Empty ...
+      end
+      resource.add_action_item :second, priority: 1 do
+        # Empty ...
+      end
+
+      expect(resource.action_items_for(:index).collect(&:name)).to eq [:first, :second, :empty, :some_other]
+    end
+
+  end
+
+  describe "setting an action item to only display on specific controller actions" do
+
+    before do
+      resource.clear_action_items!
+      resource.add_action_item :new, only: :index do
+        raise StandardError
+      end
+      resource.add_action_item :edit, only: :show do
+        # Empty ...
+      end
+    end
+
+    it "should return only relevant action items" do
+      expect(resource.action_items_for(:index).size).to eq 1
+      expect {
+        resource.action_items_for(:index).first.call
+      }.to raise_exception(StandardError)
+    end
+
+  end
+
+  describe "default action items" do
+    it "should have 3 action items" do
+      expect(resource.action_items.size).to eq 3
+    end
+
+    it 'can be removed by name' do
+      resource.remove_action_item :new
+      expect(resource.action_items.size).to eq 2
+    end
+  end
+
+end